[GitHub] tajo issue #1050: TAJO-2159: Function document should be modified as removin...

2017-12-03 Thread eminency
Github user eminency commented on the issue: https://github.com/apache/tajo/pull/1050 @hyunsik Thanks, I'll ship it soon. ---

[GitHub] tajo pull request #1050: TAJO-2159: Function document should be modified as ...

2016-09-16 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/1050 TAJO-2159: Function document should be modified as removing INET4 type Please review it. This document is describing changes at https://github.com/apache/tajo/commit

[GitHub] tajo pull request #1038: TAJO-2176: Refining function documents

2016-07-16 Thread eminency
Github user eminency closed the pull request at: https://github.com/apache/tajo/pull/1038 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tajo issue #1038: TAJO-2176: Refining function documents

2016-07-16 Thread eminency
Github user eminency commented on the issue: https://github.com/apache/tajo/pull/1038 Thanks, I'll ship it and close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo issue #1038: TAJO-2176: Refining function documents

2016-07-16 Thread eminency
Github user eminency commented on the issue: https://github.com/apache/tajo/pull/1038 @jihoonson Thanks for good catches! I fixed them, please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo issue #986: TAJO-2068: MySQL JDBC Tablespace support

2016-07-10 Thread eminency
Github user eminency commented on the issue: https://github.com/apache/tajo/pull/986 Could you merge master branch? If so, I'll review in this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tajo pull request #1038: TAJO-2176: Refining function documents

2016-07-10 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/1038 TAJO-2176: Refining function documents Done. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-2176 Alternatively you can

[GitHub] tajo pull request #1027: TAJO-2156: Create GeoIP functions taking various ty...

2016-06-15 Thread eminency
Github user eminency closed the pull request at: https://github.com/apache/tajo/pull/1027 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tajo issue #1027: TAJO-2156: Create GeoIP functions taking various types ins...

2016-06-15 Thread eminency
Github user eminency commented on the issue: https://github.com/apache/tajo/pull/1027 Thanks for the review. I'll commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-2156: Create GeoIP functions taking variou...

2016-05-27 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/1027#issuecomment-222081661 Separated issues and refined code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo pull request: TAJO-2027: Writing Hive UDF integration documen...

2016-05-21 Thread eminency
Github user eminency closed the pull request at: https://github.com/apache/tajo/pull/1026 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tajo pull request: TAJO-2156: Create GeoIP functions taking variou...

2016-05-19 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/1027#issuecomment-220504281 Good suggestion. I will separate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tajo pull request: TAJO-2027: Writing Hive UDF integration documen...

2016-05-18 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/1026#issuecomment-219938008 @hyunsik , it's done. Please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo pull request: TAJO-2156: Create GeoIP functions taking variou...

2016-05-17 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/1027#issuecomment-219928860 Oh, I got it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-2156: Create GeoIP functions taking variou...

2016-05-17 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/1027#issuecomment-219926775 Hi, @jinossy Other geoip functions(old ones) have not had a test. I think it is because of license problem - GeoIP library is set as 'provided' in pom.xml

[GitHub] tajo pull request: TAJO-2027: Writing Hive UDF integration documen...

2016-05-17 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/1026#discussion_r63645472 --- Diff: tajo-docs/src/main/sphinx/functions/hivefunc.rst --- @@ -0,0 +1,81 @@ +## +Hive Functions +## + +Tajo

[GitHub] tajo pull request: TAJO-2027: Writing Hive UDF integration documen...

2016-05-17 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/1026#discussion_r63645666 --- Diff: tajo-docs/src/main/sphinx/functions/hivefunc.rst --- @@ -0,0 +1,81 @@ +## +Hive Functions +## + +Tajo

[GitHub] tajo pull request: TAJO-2156: Create GeoIP functions taking variou...

2016-05-16 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/1027 TAJO-2156: Create GeoIP functions taking various types instead of INET4 type You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo

[GitHub] tajo pull request: TAJO-2027: Writing Hive UDF integration documen...

2016-05-16 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/1026 TAJO-2027: Writing Hive UDF integration document You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo hiveudf_doc Alternatively you

[GitHub] tajo pull request: TAJO-2130: Remove inet4 data type

2016-05-14 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/1007#issuecomment-219213140 @hyunsik , master branch is merged. @jihoonson , I created the issued you mentioned, TAJO-2155 and TAJO-2156. --- If your project is set up for it, you can

[GitHub] tajo pull request: TAJO-2145: Error codes based on errno.h need pr...

2016-05-10 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/1014 TAJO-2145: Error codes based on errno.h need prefix You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-2145 Alternatively you

[GitHub] tajo pull request: TAJO-2130: Remove inet4 data type

2016-04-27 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/1007#discussion_r61223109 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryInet4.java --- @@ -1,54 +0,0 @@ -/* - * Licensed to the Apache

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-04-24 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/929#issuecomment-214145976 @jihoonson The problem you mentioned and null handling problem are fixed. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tajo pull request: TAJO-2130: Remove inet4 data type

2016-04-24 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/1007 TAJO-2130: Remove inet4 data type You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-2130 Alternatively you can review

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-03-25 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/929#issuecomment-201157356 @jihoonson I fixed some of what you suggested. Read my comments. In addition, loading from HDFS might be separated to another issue. It needs too large working

[GitHub] tajo pull request: TAJO-1929: Can't read ORC file on hive-meta

2016-03-22 Thread eminency
Github user eminency closed the pull request at: https://github.com/apache/tajo/pull/974 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-03-22 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/929#discussion_r56941559 --- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/function/HiveFunctionInvoke.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-03-22 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/929#discussion_r56941033 --- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/function/HiveFunctionInvoke.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-03-21 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/929#discussion_r56934161 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/hiveudf/HiveFunctionLoader.java --- @@ -0,0 +1,161 @@ +/*** + * Licensed

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-19 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/944#discussion_r56449935 --- Diff: tajo-core-tests/src/test/java/org/apache/tajo/client/TestTajoClient.java --- @@ -175,10 +176,8 @@ public final void testSessionVariables() throws

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-19 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/944#discussion_r56449210 --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java --- @@ -644,30 +631,22 @@ protected void

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-19 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/944#discussion_r56448985 --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java --- @@ -602,18 +597,10 @@ protected void

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-19 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/944#discussion_r56448401 --- Diff: tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java --- @@ -471,10 +469,7 @@ public Object clone() throws

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-19 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/944#discussion_r56449510 --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java --- @@ -675,40 +654,38 @@ protected void

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-19 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/944#discussion_r56448372 --- Diff: tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java --- @@ -418,10 +419,7 @@ public Object clone() throws

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-19 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/944#discussion_r56452167 --- Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java --- @@ -303,12 +304,7 @@ public QueryHistory getQueryHistory

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-19 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/944#issuecomment-197701836 Even though they may not exact, I left some comments. Please check them out. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-18 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/944#discussion_r56451584 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/query/TaskRequestImpl.java --- @@ -216,49 +217,42 @@ public Enforcer getEnforcer() { return

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-03-10 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/929#discussion_r55786236 --- Diff: tajo-common/pom.xml --- @@ -245,6 +249,12 @@ powermock-api-mockito test + + org.apache.hive

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-03-10 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/929#discussion_r55785562 --- Diff: tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDescBuilder.java --- @@ -0,0 +1,105 @@ +/*** + * Licensed

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-03-09 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/929#discussion_r55643624 --- Diff: tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDescBuilder.java --- @@ -0,0 +1,105 @@ +/*** + * Licensed

[GitHub] tajo pull request: TAJO-1929: Can't read ORC file on hive-meta

2016-03-08 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/974 TAJO-1929: Can't read ORC file on hive-meta Creating table and reading ORC files are tested in Tajo with Hive catalog. And, ORC files created from Tajo are read well on Hive. You can merge

[GitHub] tajo pull request: TAJO-2064: Supporting auto-completion in Tsql

2016-03-08 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/955#issuecomment-194071033 @blrunner SQL keywords are fetched from SQLLexer now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-03-08 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/944#issuecomment-194070707 Time to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-2090: Bump up orc version to 0.141.

2016-03-08 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/973#issuecomment-194069841 +1. I think it is absolutely clear :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tajo pull request: TAJO-2064: Supporting auto-completion in Tsql

2016-03-07 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/955#issuecomment-193579952 @blrunner Ok, please check what you commented. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tajo pull request: TAJO-2064: Supporting auto-completion in Tsql

2016-03-07 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/955#discussion_r55304007 --- Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoGetConfCommand.java --- @@ -55,4 +62,52 @@ public String getUsage() { public

[GitHub] tajo pull request: TAJO-2064: Supporting auto-completion in Tsql

2016-03-07 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/955#discussion_r55176131 --- Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoShellCommand.java --- @@ -126,4 +136,56 @@ protected void print(char c, int count

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-02-24 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/929#issuecomment-188273376 @jihoonson I applied most of your suggestions. Could you check them again? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-02-16 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/929#discussion_r53128977 --- Diff: tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java --- @@ -200,6 +200,7 @@ public void serviceInit(Configuration conf) throws Exception

[GitHub] tajo pull request: TAJO-2064: Supporting auto-completion in Tsql

2016-02-13 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/955#issuecomment-183840136 Never mind. It is not a critical patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-02-11 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/929#discussion_r52709548 --- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/function/HiveFunctionInvoke.java --- @@ -0,0 +1,95 @@ +/** + * Licensed to the Apache Software

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-02-04 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/929#issuecomment-179781185 I missed many things... I will make the code handle them soon. UDF call test also will be done ASAP. Thanks @jihoonson . --- If your project is set up

[GitHub] tajo pull request: TAJO-2064: Supporting auto-completion in Tsql

2016-01-31 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/955 TAJO-2064: Supporting auto-completion in Tsql Use tab in Tsql! You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo auto-completion

[GitHub] tajo pull request: TAJO-2052: Upgrading ORC reader version

2016-01-28 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/937#issuecomment-176605183 @blrunner I fixed it. Please verify if it fits in your intention. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tajo pull request: TAJO-2052: Upgrading ORC reader version

2016-01-27 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/937#issuecomment-175999530 @blrunner It's already reported issue. Refer this: https://issues.apache.org/jira/browse/TAJO-1929 I will fix it after this PR because it needs ORC

[GitHub] tajo pull request: TAJO-1332 Implement Python Client for Tajo

2016-01-21 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/660#issuecomment-173832814 Hi, @charsyam May I take this on to continue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tajo pull request: TAJO-2058: foreach loop can be collapsed with s...

2016-01-19 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/944#discussion_r50217032 --- Diff: tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java --- @@ -419,9 +420,7 @@ public Object clone() throws CloneNotSupportedException

[GitHub] tajo pull request: TAJO-2059: Binary search in BST reader does com...

2016-01-18 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/945#issuecomment-172755772 @jihoonson Thank you for the comment. I'm working on it. I will keep you posted. --- If your project is set up for it, you can reply to this email and have your

[GitHub] tajo pull request: TAJO-1740: Update Partition Table document

2016-01-17 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/896#discussion_r49963051 --- Diff: tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst --- @@ -44,9 +72,166 @@ during query planning phase. * LIKE predicates

[GitHub] tajo pull request: TAJO-1740: Update Partition Table document

2016-01-17 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/896#issuecomment-172441743 It looks good. +1, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tajo pull request: TAJO-1740: Update Partition Table document

2016-01-17 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/896#issuecomment-172430843 Hi, I leave some comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tajo pull request: TAJO-1740: Update Partition Table document

2016-01-17 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/896#discussion_r49962664 --- Diff: tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst --- @@ -11,22 +11,50 @@ How to Create a Column Partitioned Table You can create

[GitHub] tajo pull request: TAJO-1740: Update Partition Table document

2016-01-17 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/896#discussion_r49962595 --- Diff: tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst --- @@ -11,22 +11,50 @@ How to Create a Column Partitioned Table You can create

[GitHub] tajo pull request: TAJO-2059: Binary search in BST reader does com...

2016-01-15 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/945 TAJO-2059: Binary search in BST reader does compare too frequently Some simple test based on unit test was done with 1M tuples and searching 1M times. Two columns, which are long and double

[GitHub] tajo pull request: TAJO-2057: Remove redundant class loading in pl...

2016-01-15 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/943#issuecomment-171945025 +1 It looks so clear. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tajo pull request: TAJO-2052: Upgrading ORC reader version

2016-01-11 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/937 TAJO-2052: Upgrading ORC reader version Code is refined, and it is based on presto-orc-0.132. * Base data structure is changed from Vector to Block. * Some bugs are fixed

[GitHub] tajo pull request: TAJO-1686: Allow Tajo to use Hive UDF

2016-01-06 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/929 TAJO-1686: Allow Tajo to use Hive UDF This patch consists of parts below. Core Logic 1. **TajoMaster.java / HiveFunctionLoader.java** : in charge of finding Hive UDFs

[GitHub] tajo pull request: TAJO-2034: Files required for executing python ...

2016-01-05 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/925#issuecomment-168949700 That's clear. My +1 here is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo pull request: TAJO-1997: Registering UDF, it needs to check d...

2015-12-20 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/883#issuecomment-166204080 Hi, @jihoonson . I applied what you suggested and rebased. Could you verify them? --- If your project is set up for it, you can reply to this email and have your

[GitHub] tajo pull request: TAJO-2028: Refining Hive Integration document i...

2015-12-17 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/916 TAJO-2028: Refining Hive Integration document including typo RFR You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-2028

[GitHub] tajo pull request: TAJO-1997: Registering UDF, it needs to check d...

2015-12-14 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/883#discussion_r47590084 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/FunctionLoader.java --- @@ -299,4 +284,38 @@ private static StaticMethodInvocationDesc

[GitHub] tajo pull request: TAJO-1997: Registering UDF, it needs to check d...

2015-12-14 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/883#discussion_r47589003 --- Diff: tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java --- @@ -167,6 +171,13 @@ public boolean equals(Object obj

[GitHub] tajo pull request: TAJO-1997: Registering UDF, it needs to check d...

2015-12-14 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/883#discussion_r47589327 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/FunctionLoader.java --- @@ -299,4 +284,38 @@ private static StaticMethodInvocationDesc

[GitHub] tajo pull request: TAJO-1997: Registering UDF, it needs to check d...

2015-12-14 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/883#discussion_r47589038 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/FunctionLoader.java --- @@ -299,4 +284,38 @@ private static StaticMethodInvocationDesc

[GitHub] tajo pull request: TAJO-1997: Registering UDF, it needs to check d...

2015-12-14 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/883#issuecomment-164664621 @jihoonson Thanks for the review. I applied what you advised and left some answers. Please check them. --- If your project is set up for it, you can reply

[GitHub] tajo pull request: TAJO-2021: Some refactoring and changing anonym...

2015-12-13 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/911 TAJO-2021: Some refactoring and changing anonymous class to lambda expression It's some simplified code changes You can merge this pull request into a Git repository by running: $ git pull

[GitHub] tajo pull request: TAJO-1855: Add document for tablespace configur...

2015-11-30 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/873#issuecomment-160833947 Good advices. Comments are applied, @jihoonson --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-29 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/870#issuecomment-160502247 Sure, I close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-29 Thread eminency
Github user eminency closed the pull request at: https://github.com/apache/tajo/pull/870 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tajo pull request: TAJO-1971: Replace 'for' loop with 'foreach'

2015-11-29 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/855#issuecomment-160504334 Could you merge latest master branch please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tajo pull request: TAJO-1973: Replace 'while' loop with 'foreach'

2015-11-29 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/858#issuecomment-160504248 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tajo pull request: TAJO-1971: Replace 'for' loop with 'foreach'

2015-11-29 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/890#discussion_r46111387 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/query/TaskRequestImpl.java --- @@ -258,9 +258,9 @@ private void mergeLocalToBuilder

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-26 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/870#issuecomment-160034320 @jihoonson I submitted new PR : https://github.com/apache/tajo/pull/881 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tajo pull request: TAJO-1994: Some trivial modification is needed ...

2015-11-26 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/881 TAJO-1994: Some trivial modification is needed in compression document You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-1994

[GitHub] tajo pull request: TAJO-1997: Registering UDF, it needs to check d...

2015-11-26 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/883 TAJO-1997: Registering UDF, it needs to check duplication You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo ambiguous_excpetion

[GitHub] tajo pull request: TAJO-1997: Registering UDF, it needs to check d...

2015-11-26 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/883#issuecomment-160060793 Ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tajo pull request: TAJO-1962: Add description for session variable...

2015-11-25 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/848#issuecomment-159808526 I think it's very good. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo pull request: TAJO-1856: Add a description about the relation...

2015-11-25 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/878#issuecomment-159804277 Refined more simply, please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo pull request: TAJO-1856: Add a description about the relation...

2015-11-24 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/878 TAJO-1856: Add a description about the relationship of tablespace, managed table, and external table to Tablespace section of Table Management chapter Hi @hyunsik , @jihoonson . One more PR

[GitHub] tajo pull request: TAJO-1855: Add document for tablespace configur...

2015-11-23 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/873 TAJO-1855: Add document for tablespace configuration to the Configuration chapter. @hyunsik , @jihoonson I added a document describing tablespace feature -exactly speaking, for storage

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-23 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/870#issuecomment-159132318 @jihoonson , I updated what you mentioned and a bit further. Please check it out. Thanks. --- If your project is set up for it, you can reply

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-20 Thread eminency
GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/870 TAJO-1857: Rename the section of 'File Formats' to 'Data Formats' and fill compression section of the 'Table Management' chapter Hi, @jihoonson. I modified docs and wrote a compression doc newly

[GitHub] tajo pull request: TAJO-1963: Add more configuration descriptions ...

2015-11-07 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/844#issuecomment-154697044 Thanks, it looks good. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tajo pull request: TAJO-1962: Add description for session variable...

2015-11-05 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/848#issuecomment-154285736 I leave some comments. Actually many items are related and duplicated with 'tajo-site.xml' doc. I think you'd better consider to omit explanations for those

[GitHub] tajo pull request: TAJO-1962: Add description for session variable...

2015-11-05 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/848#discussion_r44101925 --- Diff: tajo-docs/src/main/sphinx/tsql/variables.rst --- @@ -28,35 +30,456 @@ Each client connection to TajoMaster creates a unique session, and the client

[GitHub] tajo pull request: TAJO-1963: Add more configuration descriptions ...

2015-11-05 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/844#discussion_r44100331 --- Diff: tajo-docs/src/main/sphinx/configuration/tajo-site-xml.rst --- @@ -2,23 +2,455 @@ The tajo-site.xml File

[GitHub] tajo pull request: TAJO-1962: Add description for session variable...

2015-11-05 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/848#discussion_r44101567 --- Diff: tajo-docs/src/main/sphinx/tsql/variables.rst --- @@ -28,35 +30,456 @@ Each client connection to TajoMaster creates a unique session, and the client

[GitHub] tajo pull request: TAJO-1962: Add description for session variable...

2015-11-05 Thread eminency
Github user eminency commented on a diff in the pull request: https://github.com/apache/tajo/pull/848#discussion_r44102039 --- Diff: tajo-docs/src/main/sphinx/tsql/variables.rst --- @@ -28,35 +30,456 @@ Each client connection to TajoMaster creates a unique session, and the client

[GitHub] tajo pull request: TAJO-1963: Add more configuration descriptions ...

2015-11-05 Thread eminency
Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/844#issuecomment-154274813 I leave some comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

  1   2   >