[GitHub] [trafficcontrol] rawlinp commented on pull request #7021: Fix t3c to parent.config gen for IP origins

rawlinp commented on PR #7021: URL: https://github.com/apache/trafficcontrol/pull/7021#issuecomment-1213598520 #890 mentions cache.config too, do we already use `dest_ip` in that file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] rob05c commented on issue #890: [TC-85] Should use "dest_ip" instead of "dest_domain" in "parent.config" and "cache.config" when ofqdn is ip

rob05c commented on issue #890: URL: https://github.com/apache/trafficcontrol/issues/890#issuecomment-1213580935 Copied from #7021 : > it seems to work. It doesn't work, that statement is wrong. I think we just didn't realize it before, because it falls back to the default,

[GitHub] [trafficcontrol] rob05c commented on pull request #7021: Fix t3c to parent.config gen for IP origins

rob05c commented on PR #7021: URL: https://github.com/apache/trafficcontrol/pull/7021#issuecomment-1213580405 > Does this fix the following issue? #890 Yes, I added a link. > it seems to work. It doesn't work, that statement is wrong. I think we just didn't realize it

[GitHub] [trafficcontrol] rawlinp opened a new pull request, #7022: Traffic Stats: reuse http influx client

rawlinp opened a new pull request, #7022: URL: https://github.com/apache/trafficcontrol/pull/7022 Instead of creating a new http influx client with each request, reuse the existing client. This should prevent connection leaks when an old client is discarded for a new one but

[GitHub] [trafficcontrol] rawlinp commented on pull request #7021: Fix t3c to parent.config gen for IP origins

rawlinp commented on PR #7021: URL: https://github.com/apache/trafficcontrol/pull/7021#issuecomment-1213547705 Does this fix the following issue? https://github.com/apache/trafficcontrol/issues/890 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [trafficcontrol] rob05c opened a new pull request, #7021: Fix t3c to parent.config gen for IP origins

rob05c opened a new pull request, #7021: URL: https://github.com/apache/trafficcontrol/pull/7021 Currently, the cache config doesn't do any insight into the Delivery Service OrgServerFQDN field, and simply injects it as if it were a URI with an FQDN. This causes issues as a

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7020: [TPv1] Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 opened a new pull request, #7020: URL: https://github.com/apache/trafficcontrol/pull/7020 Closes: https://github.com/apache/trafficcontrol/issues/6033 ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7019: Remove reference to removed endpoint from TO API docs

ocket opened a new pull request, #7019: URL: https://github.com/apache/trafficcontrol/pull/7019 The documentation for `/deliveryservices/{{ID}}/servers` currently has a "caution"-level admonition advising users to use `/deliveryservices/{{XML ID}}/servers` instead. However, those

[GitHub] [trafficcontrol] shamrickus merged pull request #7017: Bump got and geckodriver in /experimental/traffic-portal

shamrickus merged PR #7017: URL: https://github.com/apache/trafficcontrol/pull/7017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus merged pull request #7016: Bump yargs-parser and protractor in /traffic_portal/test/integration

shamrickus merged PR #7016: URL: https://github.com/apache/trafficcontrol/pull/7016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rawlinp commented on issue #7018: Remove use of postgres prepared queries

rawlinp commented on issue #7018: URL: https://github.com/apache/trafficcontrol/issues/7018#issuecomment-1212368475 FYI for whoever picks this up, I think

[GitHub] [trafficcontrol] jhg03a opened a new issue, #7018: Remove use of postgres prepared queries

jhg03a opened a new issue, #7018: URL: https://github.com/apache/trafficcontrol/issues/7018 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Ops ## Current behavior: The current TO

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7016: Bump yargs-parser and protractor in /traffic_portal/test/integration

dependabot[bot] opened a new pull request, #7016: URL: https://github.com/apache/trafficcontrol/pull/7016 Bumps [yargs-parser](https://github.com/yargs/yargs-parser) and [protractor](https://github.com/angular/protractor). These dependencies needed to be updated together. Updates

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7017: Bump got and geckodriver in /experimental/traffic-portal

dependabot[bot] opened a new pull request, #7017: URL: https://github.com/apache/trafficcontrol/pull/7017 Bumps [got](https://github.com/sindresorhus/got) and [geckodriver](https://github.com/vladikoff/node-geckodriver). These dependencies needed to be updated together. Updates `got`

[GitHub] [trafficcontrol] ocket8888 merged pull request #7000: TPv2 Add page for tenant details

ocket merged PR #7000: URL: https://github.com/apache/trafficcontrol/pull/7000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7015: Add blueprint for a Global Configuration object

ocket opened a new pull request, #7015: URL: https://github.com/apache/trafficcontrol/pull/7015 Currently, we use a ton of "global" Parameters to configure large-scale settings for ATC instances. Not only are many of these undocumented, but they are by nature prone to human error. Any

[GitHub] [trafficcontrol] mitchell852 opened a new issue, #7014: Cleanup abandoned DS secrets from TV on snapshot

mitchell852 opened a new issue, #7014: URL: https://github.com/apache/trafficcontrol/issues/7014 ## This Feature Request affects these Traffic Control components: - Traffic Ops ## Description On CDN snapshot, abandoned delivery service SSL keys (typically due to the deletion of

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7013: Refactor Origins Tests

ericholguin opened a new pull request, #7013: URL: https://github.com/apache/trafficcontrol/pull/7013 This PR refactors **v4/origins_test.go**, **v3/origins_test.go**, in order to make tests more granular, providing transparency on what is being tested and reducing the need to

[GitHub] [trafficcontrol] shamrickus commented on pull request #6989: Convert Delivery Services table to use "common" grid controller

shamrickus commented on PR #6989: URL: https://github.com/apache/trafficcontrol/pull/6989#issuecomment-1211096917 This broke several tables that extended The `TableDeliveryServiceController` such as server delivery serviecs, cdn delivery services, tenant delivery services, and several

[GitHub] [trafficcontrol] rob05c merged pull request #7012: t3c: change call from t3c diff to t3c-diff to fix a performance regression

rob05c merged PR #7012: URL: https://github.com/apache/trafficcontrol/pull/7012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] traeak opened a new pull request, #7012: t3c: change call from t3c diff to t3c-diff to fix a performance regression

traeak opened a new pull request, #7012: URL: https://github.com/apache/trafficcontrol/pull/7012 While testing t3c in 6.2.0 side by side with 7.0.0 a performance regression was observed. I traced it back to the exec path PR which converted the t3c-diff call to 't3c diff'. This

[GitHub] [trafficcontrol] rawlinp merged pull request #7010: Improve the blur on 'private' text fields

rawlinp merged PR #7010: URL: https://github.com/apache/trafficcontrol/pull/7010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7011: Remove imports from Traffic Router source files that were never used

ocket opened a new pull request, #7011: URL: https://github.com/apache/trafficcontrol/pull/7011 This just removes some imports that were never used from some Java files. ## Which Traffic Control components are affected by this PR? - Traffic Router ## What is the

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7010: Improve the blur on 'private' text fields

ocket opened a new pull request, #7010: URL: https://github.com/apache/trafficcontrol/pull/7010 Instead of un-blurring on mouse-over, it now un-blurs on focus; i.e. while the text box is selected. ## Which Traffic Control components are affected by this PR? - Traffic

[GitHub] [trafficcontrol] ocket8888 merged pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

ocket merged PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rob05c commented on issue #6198: t3c-apply doesn't respect -R/--trafficserver-home for t3c-check-refs calls

rob05c commented on issue #6198: URL: https://github.com/apache/trafficcontrol/issues/6198#issuecomment-1209602597 I haven't tested, but looking at the code, it appears to still be true. `t3c-check-refs` takes a flag `--trafficserver-config-dir`, but `t3c-apply` doesn't appear to

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7009: Refactor Profiles and Profile Parameters Tests

ericholguin opened a new pull request, #7009: URL: https://github.com/apache/trafficcontrol/pull/7009 This PR refactors **v4/profiles_test.go**, **v3/profiles_test.go**, **v4/profile_parameters_test.go**, **v3/profile_parameters_test.go**in order to make tests more granular,

[GitHub] [trafficcontrol] ocket8888 commented on issue #6198: t3c-apply doesn't respect -R/--trafficserver-home for t3c-check-refs calls

ocket commented on issue #6198: URL: https://github.com/apache/trafficcontrol/issues/6198#issuecomment-1209590634 I'm not sure this is still true, may need re-investigating -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [trafficcontrol] ocket8888 commented on issue #5159: CiaB produces invalid configuration/required parameter is undocumented

ocket commented on issue #5159: URL: https://github.com/apache/trafficcontrol/issues/5159#issuecomment-1209499720 Huh, yeah, I guess it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] ocket8888 closed issue #5159: CiaB produces invalid configuration/required parameter is undocumented

ocket closed issue #5159: CiaB produces invalid configuration/required parameter is undocumented URL: https://github.com/apache/trafficcontrol/issues/5159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [trafficcontrol] zrhoffman commented on issue #5159: CiaB produces invalid configuration/required parameter is undocumented

zrhoffman commented on issue #5159: URL: https://github.com/apache/trafficcontrol/issues/5159#issuecomment-1208680885 This is it, right? https://github.com/apache/trafficcontrol/blob/743f1d49c0047458b95e6c047363863e8120ec39/docs/source/overview/profiles_and_parameters.rst#L465-L469

[GitHub] [trafficcontrol] ocket8888 commented on issue #5159: CiaB produces invalid configuration/required parameter is undocumented

ocket commented on issue #5159: URL: https://github.com/apache/trafficcontrol/issues/5159#issuecomment-1208674859 No, the parameter is still undocumented -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r940701152 ## docs/source/api/v4/multiple_server_capabilities.rst: ## @@ -0,0 +1,83 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0 (the "License"); +..

[GitHub] [trafficcontrol] mitchell852 commented on issue #5159: CiaB produces invalid configuration/required parameter is undocumented

mitchell852 commented on issue #5159: URL: https://github.com/apache/trafficcontrol/issues/5159#issuecomment-1208637342 can this be closed @ocket @zrhoffman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [trafficcontrol] zrhoffman opened a new issue, #7008: Traffic Ops should be able to auto-renew self-signed Delivery Service certificates

zrhoffman opened a new issue, #7008: URL: https://github.com/apache/trafficcontrol/issues/7008 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Ops ## Current behavior: Traffic Ops

[GitHub] [trafficcontrol] jhg03a merged pull request #6975: Ansible Dataset Loader: Filter out ALL CDN before performing CDN snap…

jhg03a merged PR #6975: URL: https://github.com/apache/trafficcontrol/pull/6975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7000: TPv2 Add page for tenant details

ocket commented on code in PR #7000: URL: https://github.com/apache/trafficcontrol/pull/7000#discussion_r940526544 ## experimental/traffic-portal/src/app/shared/tree-select/tree-select.component.html: ## @@ -0,0 +1,47 @@ + + + + {{label}} +

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7000: TPv2 Add page for tenant details

ocket commented on code in PR #7000: URL: https://github.com/apache/trafficcontrol/pull/7000#discussion_r940526544 ## experimental/traffic-portal/src/app/shared/tree-select/tree-select.component.html: ## @@ -0,0 +1,47 @@ + + + + {{label}} +

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

ocket commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r940520327 ## docs/source/api/v4/multiple_server_capabilities.rst: ## @@ -0,0 +1,83 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0 (the "License"); +.. you

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

ocket commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r940394232 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -516,13 +516,14 @@ func AssignMultipleServerCapabilities(w http.ResponseWriter, r

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7000: TPv2 Add page for tenant details

ocket commented on code in PR #7000: URL: https://github.com/apache/trafficcontrol/pull/7000#discussion_r940381051 ## experimental/traffic-portal/src/app/core/users/tenants/tenants.component.ts: ## @@ -122,7 +114,17 @@ export class TenantsComponent implements OnInit,

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7000: TPv2 Add page for tenant details

shamrickus commented on code in PR #7000: URL: https://github.com/apache/trafficcontrol/pull/7000#discussion_r940284613 ## experimental/traffic-portal/src/app/shared/tree-select/tree-select.component.html: ## @@ -14,15 +14,15 @@ {{label}} -

[GitHub] [trafficcontrol] rawlinp commented on pull request #7007: Fix t3c timeouts and retries

rawlinp commented on PR #7007: URL: https://github.com/apache/trafficcontrol/pull/7007#issuecomment-1206860282 > t3c runs should already be dispersed. The ATC cache-config itself doesn't do that, users need to make their script do that, but I think the Ansible in the repo has an example,

[GitHub] [trafficcontrol] rob05c commented on pull request #7007: Fix t3c timeouts and retries

rob05c commented on PR #7007: URL: https://github.com/apache/trafficcontrol/pull/7007#issuecomment-1206728564 > Otherwise, clients will all retry at the same time still t3c runs should already be dispersed. The ATC cache-config itself doesn't do that, users need to make their script

[GitHub] [trafficcontrol] rawlinp commented on pull request #7007: Fix t3c timeouts and retries

rawlinp commented on PR #7007: URL: https://github.com/apache/trafficcontrol/pull/7007#issuecomment-1206720102 So, exponential backoff retrying is certainly better than non-exponential, but it's really important for there to be jitter in the sleep intervals as well. Otherwise, clients will

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7007: Fix t3c timeouts and retries

rob05c commented on code in PR #7007: URL: https://github.com/apache/trafficcontrol/pull/7007#discussion_r939017728 ## CHANGELOG.md: ## @@ -65,6 +65,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - t3c-generate fix for combining

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7007: Fix t3c timeouts and retries

ocket commented on code in PR #7007: URL: https://github.com/apache/trafficcontrol/pull/7007#discussion_r939012242 ## CHANGELOG.md: ## @@ -65,6 +65,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - t3c-generate fix for combining

[GitHub] [trafficcontrol] rob05c closed pull request #7005: DO NOT MERGE Test uncached github action ats build

rob05c closed pull request #7005: DO NOT MERGE Test uncached github action ats build URL: https://github.com/apache/trafficcontrol/pull/7005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] rob05c opened a new pull request, #7007: Fix t3c timeouts and retries

rob05c opened a new pull request, #7007: URL: https://github.com/apache/trafficcontrol/pull/7007 Fixes bugs in t3c of both timeouts and retries to Traffic Ops. Config values of the Traffic Ops client weren't getting set correctly, resulting in no retries and timeouts far longer than

[GitHub] [trafficcontrol] zrhoffman merged pull request #7003: Update dockerfile to include various required packages

zrhoffman merged PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7003: Update dockerfile to include various required packages

zrhoffman commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938160531 ## cache-config/testing/docker/trafficserver/Dockerfile: ## @@ -63,10 +63,12 @@ RUN if [[ ${OS_VERSION%%.*} -ge 8 ]]; then \ curl \

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7003: Update dockerfile to include various required packages

zrhoffman commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938160085 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] zrhoffman opened a new issue, #7006: Building ATS 9.1.x: error: File not found: [...]/ssl_server_name.yaml

zrhoffman opened a new issue, #7006: URL: https://github.com/apache/trafficcontrol/issues/7006 ## This Bug Report affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic Server RPM used by integration tests ##

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7003: Update dockerfile to include various required packages

rob05c commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938155402 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r938003370 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -441,3 +442,87 @@ func getDSTenantIDsByIDs(tx *sqlx.Tx, dsIDs []int64)

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7003: Update dockerfile to include various required packages

zrhoffman commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938109883 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7003: Update dockerfile to include various required packages

zrhoffman commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938107434 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7003: Update dockerfile to include various required packages

zrhoffman commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938107434 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] rob05c opened a new pull request, #7005: DO NOT MERGE Test uncached github action ats build

rob05c opened a new pull request, #7005: URL: https://github.com/apache/trafficcontrol/pull/7005 Testing the Github Action ciab ats build, do not merge. ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Control Cache

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7003: Update dockerfile to include various required packages

rob05c commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938088749 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7003: Update dockerfile to include various required packages

zrhoffman commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938070464 ## cache-config/testing/docker/trafficserver/Dockerfile: ## @@ -63,10 +63,12 @@ RUN if [[ ${OS_VERSION%%.*} -ge 8 ]]; then \ curl \

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7003: Update dockerfile to include various required packages

zrhoffman commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938070464 ## cache-config/testing/docker/trafficserver/Dockerfile: ## @@ -63,10 +63,12 @@ RUN if [[ ${OS_VERSION%%.*} -ge 8 ]]; then \ curl \

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7003: Update dockerfile to include various required packages

zrhoffman commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938069106 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7003: Update dockerfile to include various required packages

rob05c commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938068183 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7003: Update dockerfile to include various required packages

zrhoffman commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938061786 ## cache-config/testing/docker/trafficserver/Dockerfile: ## @@ -63,10 +63,12 @@ RUN if [[ ${OS_VERSION%%.*} -ge 8 ]]; then \ curl \

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

ocket commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r938022975 ## lib/go-tc/server_server_capability.go: ## @@ -27,6 +27,12 @@ type ServerServerCapability struct { ServerCapability *string

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7003: Update dockerfile to include various required packages

ocket commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938013787 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] ocket8888 merged pull request #7002: Update Go version to 1.19

ocket merged PR #7002: URL: https://github.com/apache/trafficcontrol/pull/7002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7002: Update Go version to 1.19

ocket commented on code in PR #7002: URL: https://github.com/apache/trafficcontrol/pull/7002#discussion_r938002353 ## lib/go-tc/doc.go: ## @@ -157,23 +157,23 @@ // necessarily named FooV1/FooV11 etc.) indicating the new structure. For // example: // -// // FooV11

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r938006883 ## docs/source/api/v4/multiple_server_capabilities.rst: ## @@ -0,0 +1,83 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0 (the "License"); +..

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r938005307 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -441,3 +442,87 @@ func getDSTenantIDsByIDs(tx *sqlx.Tx, dsIDs []int64)

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r938003370 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -441,3 +442,87 @@ func getDSTenantIDsByIDs(tx *sqlx.Tx, dsIDs []int64)

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r938000476 ## lib/go-tc/server_server_capability.go: ## @@ -27,6 +27,12 @@ type ServerServerCapability struct { ServerCapability *string

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

ocket commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r937986723 ## docs/source/api/v4/multiple_server_capabilities.rst: ## @@ -0,0 +1,83 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0 (the "License"); +.. you

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7003: Update dockerfile to include various required packages

ezelkow1 commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r937991143 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7000: TPv2 Add page for tenant details

ocket commented on code in PR #7000: URL: https://github.com/apache/trafficcontrol/pull/7000#discussion_r937982380 ## experimental/traffic-portal/src/app/core/users/tenants/tenants.component.ts: ## @@ -80,10 +80,12 @@ export class TenantsComponent implements OnInit,

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

ocket commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r937980036 ## lib/go-tc/server_server_capability.go: ## @@ -27,6 +27,11 @@ type ServerServerCapability struct { ServerCapability *string

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7003: Update dockerfile to include various required packages

ocket commented on code in PR #7003: URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r937962760 ## infrastructure/cdn-in-a-box/cache/Dockerfile: ## @@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \ libmaxminddb\

[GitHub] [trafficcontrol] ocket8888 opened a new issue, #7004: TPv2 context menu items that aren't multi-row should be disabled when multiple rows are selected.

ocket opened a new issue, #7004: URL: https://github.com/apache/trafficcontrol/issues/7004 ## This Bug Report affects these Traffic Control components: - Traffic Portal (experimental v2) ## Current behavior: Non-multi-row context menu items on tables in TPv2 are not disabled

[GitHub] [trafficcontrol] ezelkow1 opened a new pull request, #7003: Update dockerfile to include various required packages

ezelkow1 opened a new pull request, #7003: URL: https://github.com/apache/trafficcontrol/pull/7003 ## Which Traffic Control components are affected by this PR? - Automation (docker images) ## What is the best way to verify this PR? Currently

[GitHub] [trafficcontrol] shamrickus merged pull request #6981: Obscure sensitive Traffic Portal form fields

shamrickus merged PR #6981: URL: https://github.com/apache/trafficcontrol/pull/6981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r937187242 ## traffic_ops/v4-client/endpoints.go: ## @@ -22,6 +22,6 @@ package client // Versions are ordered latest-first. func apiVersions() []string {

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r937009786 ## traffic_ops/v4-client/server_server_capabilities.go: ## @@ -16,17 +16,20 @@ package client */ import ( + "fmt" "net/url"

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r937001171 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -441,3 +442,87 @@ func getDSTenantIDsByIDs(tx *sqlx.Tx, dsIDs []int64)

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r936921115 ## traffic_ops/traffic_ops_golang/routing/routes.go: ## @@ -131,6 +131,9 @@ func Routes(d ServerData) ([]Route, http.Handler, error) { * 4.x

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r936920224 ## lib/go-tc/server_server_capability.go: ## @@ -27,6 +27,11 @@ type ServerServerCapability struct { ServerCapability *string

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6981: Obscure sensitive Traffic Portal form fields

ocket commented on code in PR #6981: URL: https://github.com/apache/trafficcontrol/pull/6981#discussion_r936816518 ## experimental/traffic-portal/src/app/shared/obscured-text-input/obscured-text-input.component.html: ## @@ -0,0 +1,31 @@ + + Review Comment: nvm, I can't

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6981: Obscure sensitive Traffic Portal form fields

ocket commented on code in PR #6981: URL: https://github.com/apache/trafficcontrol/pull/6981#discussion_r936809572 ## experimental/traffic-portal/src/app/shared/obscured-text-input/obscured-text-input.component.html: ## @@ -0,0 +1,31 @@ + + Review Comment: It could be

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

ocket commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r936072015 ## traffic_ops/traffic_ops_golang/routing/routes.go: ## @@ -131,6 +131,9 @@ func Routes(d ServerData) ([]Route, http.Handler, error) { * 4.x

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

ocket commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r936806424 ## traffic_ops/v4-client/server_server_capabilities.go: ## @@ -16,17 +16,20 @@ package client */ import ( + "fmt" "net/url" "strconv"

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

rimashah25 commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r936077902 ## traffic_ops/v4-client/server_server_capabilities.go: ## @@ -16,17 +16,20 @@ package client */ import ( + "fmt" "net/url"

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6996: Added a new route and logic for assigning multiple server capabilities to a server

ocket commented on code in PR #6996: URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r936070291 ## lib/go-tc/server_server_capability.go: ## @@ -27,6 +27,11 @@ type ServerServerCapability struct { ServerCapability *string

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7000: TPv2 Add page for tenant details

ocket commented on code in PR #7000: URL: https://github.com/apache/trafficcontrol/pull/7000#discussion_r936053642 ## experimental/traffic-portal/src/app/core/users/tenants/tenant-details/tenant-details.component.ts: ## @@ -0,0 +1,175 @@ +/* +* Licensed under the Apache

[GitHub] [trafficcontrol] shamrickus merged pull request #6989: Convert Delivery Services table to use "common" grid controller

shamrickus merged PR #6989: URL: https://github.com/apache/trafficcontrol/pull/6989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7002: Update Go version to 1.19

zrhoffman opened a new pull request, #7002: URL: https://github.com/apache/trafficcontrol/pull/7002 ## What does this PR (Pull Request) do? This PR makes the Go components of Traffic Control build using Go version 1.19. No `golang.org/x/` dependency updates were needed. See

[GitHub] [trafficcontrol] smalenfant closed issue #6816: Can't enable http2 with ATS9

smalenfant closed issue #6816: Can't enable http2 with ATS9 URL: https://github.com/apache/trafficcontrol/issues/6816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] smalenfant commented on pull request #6944: Change t3c h2 disable to enable

smalenfant commented on PR #6944: URL: https://github.com/apache/trafficcontrol/pull/6944#issuecomment-1202858715 Closes #6816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7001: Refactor Parameters tests

ericholguin opened a new pull request, #7001: URL: https://github.com/apache/trafficcontrol/pull/7001 This PR refactors **v4/parameters_test.go**, **v3/parameters_test.go**, in order to make tests more granular, providing transparency on what is being tested and reducing the need

[GitHub] [trafficcontrol] shamrickus merged pull request #6988: remove broken and/or unusued tables

shamrickus merged PR #6988: URL: https://github.com/apache/trafficcontrol/pull/6988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7000: TPv2 Add page for tenant details

shamrickus opened a new pull request, #7000: URL: https://github.com/apache/trafficcontrol/pull/7000 This PR adds the tenant details page for add/edit. It also adds a common component for tree-select like what was in TPv1. ## Which Traffic Control components are affected

<    9   10   11   12   13   14   15   16   17   18   >