[GitHub] [trafficcontrol] zrhoffman commented on pull request #7192: update health-client to v4 API

2022-11-14 Thread GitBox
zrhoffman commented on PR #7192: URL: https://github.com/apache/trafficcontrol/pull/7192#issuecomment-1314502931 This looks good, but let's wait until #7190 is merged or closed to merge #7192. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [trafficcontrol] kdamichie opened a new pull request, #7194: Added catch for missing POST body when posted to profileparameters

2022-11-14 Thread GitBox
kdamichie opened a new pull request, #7194: URL: https://github.com/apache/trafficcontrol/pull/7194 This PR closes #4428 ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Ops ## What is the best way to verify this

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1314374384 All comments have been resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] jhg03a commented on issue #4023: Incorrect total available bandwidth from astats

2022-11-14 Thread GitBox
jhg03a commented on issue #4023: URL: https://github.com/apache/trafficcontrol/issues/4023#issuecomment-1314374102 There's nowhere to do that because TM just expects a single piece of data to evaluate via the rascal profile -- This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7193: Refactor by renaming CCR to Traffic Router/TR

2022-11-14 Thread GitBox
rimashah25 opened a new pull request, #7193: URL: https://github.com/apache/trafficcontrol/pull/7193 Related: #https://github.com/apache/trafficcontrol/issues/2564 from CCR (Traffic Router) Perspective. ## Which Traffic Control components are affected by this PR?

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7192: update health-client to v4 API

2022-11-14 Thread GitBox
zrhoffman commented on code in PR #7192: URL: https://github.com/apache/trafficcontrol/pull/7192#discussion_r1022032181 ## tc-health-client/tmagent/tmagent.go: ## @@ -656,7 +656,9 @@ func (pi *ParentInfo) GetTOData(cfg *config.Cfg) error { if *sv.CDNName !=

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7192: update health-client to v4 API

2022-11-14 Thread GitBox
zrhoffman commented on code in PR #7192: URL: https://github.com/apache/trafficcontrol/pull/7192#discussion_r1022032181 ## tc-health-client/tmagent/tmagent.go: ## @@ -656,7 +656,9 @@ func (pi *ParentInfo) GetTOData(cfg *config.Cfg) error { if *sv.CDNName !=

[GitHub] [trafficcontrol] jpappa200 commented on a diff in pull request #7192: update health-client to v4 API

2022-11-14 Thread GitBox
jpappa200 commented on code in PR #7192: URL: https://github.com/apache/trafficcontrol/pull/7192#discussion_r1022031760 ## tc-health-client/tmagent/tmagent.go: ## @@ -656,7 +656,9 @@ func (pi *ParentInfo) GetTOData(cfg *config.Cfg) error { if *sv.CDNName !=

[GitHub] [trafficcontrol] jpappa200 commented on a diff in pull request #7192: update health-client to v4 API

2022-11-14 Thread GitBox
jpappa200 commented on code in PR #7192: URL: https://github.com/apache/trafficcontrol/pull/7192#discussion_r1021985725 ## CHANGELOG.md: ## @@ -23,6 +23,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] srijeet0406 commented on issue #6533: TR should not rename/recreate log files on rollover

2022-11-14 Thread GitBox
srijeet0406 commented on issue #6533: URL: https://github.com/apache/trafficcontrol/issues/6533#issuecomment-1314277504 Excellent, thanks @villajo ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [trafficcontrol] zrhoffman commented on issue #6533: TR should not rename/recreate log files on rollover

2022-11-14 Thread GitBox
zrhoffman commented on issue #6533: URL: https://github.com/apache/trafficcontrol/issues/6533#issuecomment-1314266520 That all sounds great -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7192: update health-client to v4 API

2022-11-14 Thread GitBox
zrhoffman commented on code in PR #7192: URL: https://github.com/apache/trafficcontrol/pull/7192#discussion_r1021969022 ## tc-health-client/tmagent/tmagent.go: ## @@ -656,7 +656,9 @@ func (pi *ParentInfo) GetTOData(cfg *config.Cfg) error { if *sv.CDNName !=

[GitHub] [trafficcontrol] villajo commented on issue #6533: TR should not rename/recreate log files on rollover

2022-11-14 Thread GitBox
villajo commented on issue #6533: URL: https://github.com/apache/trafficcontrol/issues/6533#issuecomment-1314264463 So, they would both have separate log files still. That portion would still be controlled by log4j. It's the log rotation that would be removed from the log4j2.xml

[GitHub] [trafficcontrol] zrhoffman commented on issue #6533: TR should not rename/recreate log files on rollover

2022-11-14 Thread GitBox
zrhoffman commented on issue #6533: URL: https://github.com/apache/trafficcontrol/issues/6533#issuecomment-131494 > I feel logrotate does this reliably. Using `logrotate` for TR logs sounds good to me, too > I simplified the configuration of our log4j2.xml to only use one

[GitHub] [trafficcontrol] jpappa200 opened a new pull request, #7192: update health-client to v4 API

2022-11-14 Thread GitBox
jpappa200 opened a new pull request, #7192: URL: https://github.com/apache/trafficcontrol/pull/7192 Closes: #7191 Updates to use traffic ops api v4. Also adds reload capability to systemd ## Which Traffic Control components are affected by this PR? - Traffic

[GitHub] [trafficcontrol] ocket8888 commented on issue #7191: tc-health-client update to v4 API

2022-11-14 Thread GitBox
ocket commented on issue #7191: URL: https://github.com/apache/trafficcontrol/issues/7191#issuecomment-1314214070 > v3 API will be deprecated soon... [APIv3 was already deprecated in ATCv7.0.0](https://traffic-control-cdn.readthedocs.io/en/v7.0.0/api/index.html#api-v3-routes).

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021926483 ## traffic_ops/app/db/migrations/2022110908494015_ds_active_flag.down.sql: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021926483 ## traffic_ops/app/db/migrations/2022110908494015_ds_active_flag.down.sql: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021927175 ## docs/source/api/v5/deliveryservice_requests.rst: ## @@ -663,59 +504,315 @@ The response is a full representation of the edited :term:`Delivery Service

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021926483 ## traffic_ops/app/db/migrations/2022110908494015_ds_active_flag.down.sql: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [trafficcontrol] jpappa200 opened a new issue, #7191: tc-health-client update to v4 API

2022-11-14 Thread GitBox
jpappa200 opened a new issue, #7191: URL: https://github.com/apache/trafficcontrol/issues/7191 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Control Health Client (tc-health-client)

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7190: Revert Traffic Monitor renaming to rascal

2022-11-14 Thread GitBox
zrhoffman commented on PR #7190: URL: https://github.com/apache/trafficcontrol/pull/7190#issuecomment-1314191555 This PR reverts #7068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7190: Revert Traffic Monitor renaming to rascal

2022-11-14 Thread GitBox
rimashah25 opened a new pull request, #7190: URL: https://github.com/apache/trafficcontrol/pull/7190 ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic Control Health

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021899761 ## traffic_ops/testing/api/v5/tc-fixtures.json: ## @@ -341,7 +341,7 @@ { Review Comment: #7189 -- This is an automated message from the

[GitHub] [trafficcontrol] ocket8888 opened a new issue, #7189: Testing Delivery Services are not full representations

2022-11-14 Thread GitBox
ocket opened a new issue, #7189: URL: https://github.com/apache/trafficcontrol/issues/7189 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Ops Client (Go) (Tests) ## Current behavior: In the

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021893838 ## docs/source/api/v5/deliveryservice_requests.rst: ## @@ -663,59 +504,315 @@ The response is a full representation of the edited :term:`Delivery Service

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021880374 ## traffic_ops/app/db/migrations/2022110908494015_ds_active_flag.down.sql: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [trafficcontrol] ocket8888 merged pull request #7188: Dev CiaB: Use Almquist shell for TP/TPv2 since the base image is Alpine

2022-11-14 Thread GitBox
ocket merged PR #7188: URL: https://github.com/apache/trafficcontrol/pull/7188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021842607 ## traffic_ops/app/db/migrations/2022110908494015_ds_active_flag.up.sql: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021841781 ## traffic_ops/app/db/migrations/2022110908494015_ds_active_flag.down.sql: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021835875 ## docs/source/api/v5/deliveryservice_requests.rst: ## @@ -214,18 +303,19 @@ The request must be a well-formed representation of a :term:`Delivery Service

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021832101 ## docs/source/api/v5/deliveryservice_requests.rst: ## @@ -214,18 +303,19 @@ The request must be a well-formed representation of a :term:`Delivery Service

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021830441 ## docs/source/api/v5/deliveryservice_requests.rst: ## @@ -663,59 +504,315 @@ The response is a full representation of the edited :term:`Delivery Service

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021753057 ## traffic_ops/testing/api/v5/tc-fixtures.json: ## @@ -341,7 +341,7 @@ { Review Comment: Wanna create an issue for that? -- This is an

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021752174 ## docs/source/api/v5/deliveryservices_id.rst: ## @@ -400,20 +404,25 @@ Response Structure Access-Control-Allow-Headers: Origin, X-Requested-With,

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-14 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1021745429 ## traffic_ops/testing/api/v3/tc-fixtures.json: ## @@ -858,7 +858,7 @@ "regexRemap": null, "regionalGeoBlocking": false,

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7187: Minimize Snapshot diff for Server Server Capabilities

2022-11-14 Thread GitBox
zrhoffman opened a new pull request, #7187: URL: https://github.com/apache/trafficcontrol/pull/7187 This PR fixes #7113 by reordering the Server Server Capabilities in the new Snapshot to make Server Server capabilities occurring in both the old and new arrays have the same

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7188: Dev CiaB: Use Almquist shell for TP/TPv2 since the base image is Alpine

2022-11-14 Thread GitBox
zrhoffman opened a new pull request, #7188: URL: https://github.com/apache/trafficcontrol/pull/7188 This PR fixes an issue introduced by merging #7142, which changes the `run.sh` shell for the `trafficportal` and `tpv2` Dev CDN-in-a-Box services to `bash` because `dash` (`sh` on

[GitHub] [trafficcontrol] srijeet0406 opened a new pull request, #7186: Add reqd caps to ds

2022-11-11 Thread GitBox
srijeet0406 opened a new pull request, #7186: URL: https://github.com/apache/trafficcontrol/pull/7186 This PR adds the `required capabilities` into the `deliveryservice` structure. ## Which Traffic Control components are affected by this PR? - Documentation -

[GitHub] [trafficcontrol] rawlinp merged pull request #7185: adds issue and/or PR links to changelog entries

2022-11-11 Thread GitBox
rawlinp merged PR #7185: URL: https://github.com/apache/trafficcontrol/pull/7185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] mitchell852 opened a new pull request, #7185: adds issue and/or PR links to changelog entries

2022-11-11 Thread GitBox
mitchell852 opened a new pull request, #7185: URL: https://github.com/apache/trafficcontrol/pull/7185 ## Which Traffic Control components are affected by this PR? - Documentation ## What is the best way to verify this PR? render the changelog and verify the unreleased section

[GitHub] [trafficcontrol] ocket8888 merged pull request #7142: Run CDN in a Box for Developers services as unprivileged users

2022-11-11 Thread GitBox
ocket merged PR #7142: URL: https://github.com/apache/trafficcontrol/pull/7142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rawlinp commented on issue #6533: TR should not rename/recreate log files on rollover

2022-11-11 Thread GitBox
rawlinp commented on issue #6533: URL: https://github.com/apache/trafficcontrol/issues/6533#issuecomment-1311998664 That sounds reasonable to me, but the trade-off is that the log storage requirements will be increased since logrotate is only run 1x/day whereas log4j can rollover whenever

[GitHub] [trafficcontrol] villajo commented on issue #6533: TR should not rename/recreate log files on rollover

2022-11-11 Thread GitBox
villajo commented on issue #6533: URL: https://github.com/apache/trafficcontrol/issues/6533#issuecomment-1311983448 So, after reviewing the issue, the code and then reviewing the default configuration used on Traffic Router. I feel that a different approach would be better. The

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7142: Run CDN in a Box for Developers services as unprivileged users

2022-11-10 Thread GitBox
zrhoffman commented on PR #7142: URL: https://github.com/apache/trafficcontrol/pull/7142#issuecomment-1311000307 Oops, the condition checking if t3c's `run.sh` was being run as root was always checking the unprivileged user's UID instead. Fixed in 0150a22289 -- This is an automated

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7184: Add a button to toggle the visibility of all sensitive fields to DS forms

2022-11-10 Thread GitBox
ocket opened a new pull request, #7184: URL: https://github.com/apache/trafficcontrol/pull/7184 This PR adds a button to the top of DS forms (except for STEERING-based DSes, which have no use for it) that can be used to toggle the visibility of fields considered "sensitive" throughout

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7180: Add go mod vendor to t3c run.sh

2022-11-10 Thread GitBox
ericholguin commented on code in PR #7180: URL: https://github.com/apache/trafficcontrol/pull/7180#discussion_r1019552146 ## dev/atc.dev.sh: ## @@ -15,10 +15,16 @@ # specific language governing permissions and limitations # under the License. -alias

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7180: Add go mod vendor to t3c run.sh

2022-11-10 Thread GitBox
zrhoffman commented on code in PR #7180: URL: https://github.com/apache/trafficcontrol/pull/7180#discussion_r1019454714 ## dev/atc.dev.sh: ## @@ -15,10 +15,16 @@ # specific language governing permissions and limitations # under the License. -alias atc-start="docker-compose

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7180: Add go mod vendor to t3c run.sh

2022-11-10 Thread GitBox
zrhoffman commented on code in PR #7180: URL: https://github.com/apache/trafficcontrol/pull/7180#discussion_r1019454222 ## dev/atc.dev.sh: ## @@ -15,10 +15,16 @@ # specific language governing permissions and limitations # under the License. -alias atc-start="docker-compose

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7180: Add go mod vendor to t3c run.sh

2022-11-10 Thread GitBox
ericholguin commented on code in PR #7180: URL: https://github.com/apache/trafficcontrol/pull/7180#discussion_r1019452292 ## dev/atc.dev.sh: ## @@ -15,10 +15,16 @@ # specific language governing permissions and limitations # under the License. -alias

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7180: Add go mod vendor to t3c run.sh

2022-11-10 Thread GitBox
zrhoffman commented on code in PR #7180: URL: https://github.com/apache/trafficcontrol/pull/7180#discussion_r1019422562 ## dev/atc.dev.sh: ## @@ -15,10 +15,16 @@ # specific language governing permissions and limitations # under the License. -alias atc-start="docker-compose

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7180: Add go mod vendor to t3c run.sh

2022-11-10 Thread GitBox
ericholguin commented on code in PR #7180: URL: https://github.com/apache/trafficcontrol/pull/7180#discussion_r1019381682 ## dev/t3c/run.sh: ## @@ -20,6 +20,9 @@ set -o errexit trap '[ $? -eq 0 ] && exit 0 || echo "Error on line ${LINENO} of ${0}"; exit 1' EXIT +cd $TC +go

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-10 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1013546976 ## docs/source/api/v5/deliveryservice_requests.rst: ## @@ -214,18 +303,19 @@ The request must be a well-formed representation of a :term:`Delivery Service

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-09 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1018590003 ## traffic_ops/testing/api/v4/tc-fixtures.json: ## @@ -907,7 +907,7 @@ "regexRemap": null, "regionalGeoBlocking": false,

[GitHub] [trafficcontrol] ocket8888 merged pull request #7169: Update TPv2 dependencies and node version

2022-11-09 Thread GitBox
ocket merged PR #7169: URL: https://github.com/apache/trafficcontrol/pull/7169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus merged pull request #7183: Bump socket.io-parser from 4.0.4 to 4.0.5 in /experimental/traffic-portal

2022-11-09 Thread GitBox
shamrickus merged PR #7183: URL: https://github.com/apache/trafficcontrol/pull/7183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-09 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1018500420 ## traffic_ops/testing/api/v5/tc-fixtures.json: ## @@ -341,7 +341,7 @@ { Review Comment: it would seem not. The PR that added that field didn't

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7183: Bump socket.io-parser from 4.0.4 to 4.0.5 in /experimental/traffic-portal

2022-11-09 Thread GitBox
dependabot[bot] opened a new pull request, #7183: URL: https://github.com/apache/trafficcontrol/pull/7183 Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5. Release notes Sourced from

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-09 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1018455483 ## traffic_ops/testing/api/v3/tc-fixtures.json: ## @@ -858,7 +858,7 @@ "regexRemap": null, "regionalGeoBlocking": false,

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-09 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1018452494 ## docs/source/api/v5/deliveryservice_requests.rst: ## @@ -214,18 +303,19 @@ The request must be a well-formed representation of a :term:`Delivery Service Re

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-09 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1018451789 ## docs/source/api/v5/deliveryservice_requests.rst: ## @@ -663,59 +504,315 @@ The response is a full representation of the edited :term:`Delivery Service

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-09 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1018283500 ## docs/source/api/v5/deliveryservices_id.rst: ## @@ -400,20 +404,25 @@ Response Structure Access-Control-Allow-Headers: Origin, X-Requested-With,

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7142: Run CDN in a Box for Developers services as unprivileged users

2022-11-09 Thread GitBox
zrhoffman commented on code in PR #7142: URL: https://github.com/apache/trafficcontrol/pull/7142#discussion_r1018267515 ## docker-compose.yml: ## @@ -33,8 +33,10 @@ services: ports: - 6443:443 - 6444:6444 +sysctls: +-

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7142: Run CDN in a Box for Developers services as unprivileged users

2022-11-09 Thread GitBox
zrhoffman commented on code in PR #7142: URL: https://github.com/apache/trafficcontrol/pull/7142#discussion_r1018267515 ## docker-compose.yml: ## @@ -33,8 +33,10 @@ services: ports: - 6443:443 - 6444:6444 +sysctls: +-

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7142: Run CDN in a Box for Developers services as unprivileged users

2022-11-09 Thread GitBox
ericholguin commented on code in PR #7142: URL: https://github.com/apache/trafficcontrol/pull/7142#discussion_r1018258352 ## docker-compose.yml: ## @@ -33,8 +33,10 @@ services: ports: - 6443:443 - 6444:6444 +sysctls: +-

[GitHub] [trafficcontrol] ocket8888 merged pull request #4074: Set Content-Length header in Traffic Router

2022-11-09 Thread GitBox
ocket merged PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 closed issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests

2022-11-09 Thread GitBox
ocket closed issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests URL: https://github.com/apache/trafficcontrol/issues/3965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-09 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1018210728 ## CHANGELOG.md: ## @@ -211,6 +212,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Updated `t3c-apply` to reduce

[GitHub] [trafficcontrol] traeak opened a new pull request, #7182: t3c: sort peers in strategies.yaml

2022-11-09 Thread GitBox
traeak opened a new pull request, #7182: URL: https://github.com/apache/trafficcontrol/pull/7182 During T3C strategy.yaml generation, make sure the peers are sorted by key before writing out. This can cause false positives for reloading ATS. ## Which Traffic Control

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7142: Run CDN in a Box for Developers services as unprivileged users

2022-11-08 Thread GitBox
zrhoffman commented on code in PR #7142: URL: https://github.com/apache/trafficcontrol/pull/7142#discussion_r1017158790 ## dev/tpv2/run.sh: ## @@ -16,5 +16,24 @@ set -o errexit cd "$TC/experimental/traffic-portal" + +user=tpv2 +uid="$(stat -c%u "$TC")" +gid="$(stat -c%g

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7142: Run CDN in a Box for Developers services as unprivileged users

2022-11-08 Thread GitBox
ocket commented on code in PR #7142: URL: https://github.com/apache/trafficcontrol/pull/7142#discussion_r1017140520 ## dev/tpv2/run.sh: ## @@ -16,5 +16,24 @@ set -o errexit cd "$TC/experimental/traffic-portal" + +user=tpv2 +uid="$(stat -c%u "$TC")" +gid="$(stat -c%g

[GitHub] [trafficcontrol] shamrickus merged pull request #7181: Bump loader-utils from 2.0.2 to 2.0.3 in /experimental/traffic-portal

2022-11-08 Thread GitBox
shamrickus merged PR #7181: URL: https://github.com/apache/trafficcontrol/pull/7181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7181: Bump loader-utils from 2.0.2 to 2.0.3 in /experimental/traffic-portal

2022-11-08 Thread GitBox
dependabot[bot] opened a new pull request, #7181: URL: https://github.com/apache/trafficcontrol/pull/7181 Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.3. Release notes Sourced from https://github.com/webpack/loader-utils/releases;>loader-utils's

[GitHub] [trafficcontrol] ocket8888 merged pull request #7176: ATC build system: aarch64 support

2022-11-08 Thread GitBox
ocket merged PR #7176: URL: https://github.com/apache/trafficcontrol/pull/7176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 merged pull request #7179: Fixed column search filter in Delivery Service table

2022-11-08 Thread GitBox
ocket merged PR #7179: URL: https://github.com/apache/trafficcontrol/pull/7179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ezelkow1 commented on issue #4023: Incorrect total available bandwidth from astats

2022-11-08 Thread GitBox
ezelkow1 commented on issue #4023: URL: https://github.com/apache/trafficcontrol/issues/4023#issuecomment-1307699906 > No. The system stats plugin also doesn't take this into account I believe. But if you have all the information about the various links and link states then you

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7180: Add go mod vendor to t3c run.sh

2022-11-08 Thread GitBox
zrhoffman commented on code in PR #7180: URL: https://github.com/apache/trafficcontrol/pull/7180#discussion_r1017012943 ## dev/t3c/run.sh: ## @@ -20,6 +20,9 @@ set -o errexit trap '[ $? -eq 0 ] && exit 0 || echo "Error on line ${LINENO} of ${0}"; exit 1' EXIT +cd $TC +go

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7180: Add go mod vendor to t3c run.sh

2022-11-08 Thread GitBox
ericholguin opened a new pull request, #7180: URL: https://github.com/apache/trafficcontrol/pull/7180 Adds the `go mod vendor` command to the t3c `run.sh` file, for when a user has a clean repo t3c won't fail to start up due to missing packages ## Which Traffic

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7179: Fixed column search filter in Delivery Service table

2022-11-08 Thread GitBox
rimashah25 opened a new pull request, #7179: URL: https://github.com/apache/trafficcontrol/pull/7179 Fixed column search filter in Delivery Service Table. ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best

[GitHub] [trafficcontrol] jhg03a commented on issue #4023: Incorrect total available bandwidth from astats

2022-11-08 Thread GitBox
jhg03a commented on issue #4023: URL: https://github.com/apache/trafficcontrol/issues/4023#issuecomment-1307618055 No. The system stats plugin also doesn't take this into account I believe. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [trafficcontrol] zrhoffman merged pull request #7161: DTP open sourcing

2022-11-08 Thread GitBox
zrhoffman merged PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rob05c commented on issue #3537: Duplicate Origin Problem

2022-11-08 Thread GitBox
rob05c commented on issue #3537: URL: https://github.com/apache/trafficcontrol/issues/3537#issuecomment-1307560241 > So when we move from parent.config to strategies.yaml, duplicate origins won't be a problem anymore, different remaps (Delivery Services) can map to the same parent without

[GitHub] [trafficcontrol] zrhoffman commented on issue #1131: Provide an updated trafficserver.spec file

2022-11-08 Thread GitBox
zrhoffman commented on issue #1131: URL: https://github.com/apache/trafficcontrol/issues/1131#issuecomment-1307554181 A more recent spec file exists in the repo at

[GitHub] [trafficcontrol] rob05c commented on issue #3537: Duplicate Origin Problem

2022-11-08 Thread GitBox
rob05c commented on issue #3537: URL: https://github.com/apache/trafficcontrol/issues/3537#issuecomment-1307552532 We already generate strategies.yaml, though I don't think anyone has tested it in production yet.

[GitHub] [trafficcontrol] zrhoffman commented on issue #4023: Incorrect total available bandwidth from astats

2022-11-08 Thread GitBox
zrhoffman commented on issue #4023: URL: https://github.com/apache/trafficcontrol/issues/4023#issuecomment-1307543292 @jhg03a, does the `system_stats.so` plugin solution work for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] zrhoffman commented on issue #3537: Duplicate Origin Problem

2022-11-08 Thread GitBox
zrhoffman commented on issue #3537: URL: https://github.com/apache/trafficcontrol/issues/3537#issuecomment-1307528695 > So when we move from parent.config to strategies.yaml, duplicate origins won't be a problem anymore, different remaps (Delivery Services) can map to the same parent

[GitHub] [trafficcontrol] zrhoffman commented on issue #6161: tc-health-client: Display errors on stderr

2022-11-08 Thread GitBox
zrhoffman commented on issue #6161: URL: https://github.com/apache/trafficcontrol/issues/6161#issuecomment-1307511490 This still happens for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-07 Thread GitBox
ocket commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1016152519 ## CHANGELOG.md: ## @@ -211,6 +212,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Updated `t3c-apply` to reduce

[GitHub] [trafficcontrol] ocket8888 closed issue #5970: Fix numeric sort in DSCP List

2022-11-07 Thread GitBox
ocket closed issue #5970: Fix numeric sort in DSCP List URL: https://github.com/apache/trafficcontrol/issues/5970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] ocket8888 closed issue #5971: Tool tip link for `Max DN answers` opens in the same tab instead of a new tab

2022-11-07 Thread GitBox
ocket closed issue #5971: Tool tip link for `Max DN answers` opens in the same tab instead of a new tab URL: https://github.com/apache/trafficcontrol/issues/5971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [trafficcontrol] ocket8888 merged pull request #7174: Fixed sort in topologies table, in a DS form for topologies and DSCP and tool tip (Max DNS) opens in a new page

2022-11-07 Thread GitBox
ocket merged PR #7174: URL: https://github.com/apache/trafficcontrol/pull/7174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7142: Run CDN in a Box for Developers services as unprivileged users

2022-11-07 Thread GitBox
zrhoffman commented on PR #7142: URL: https://github.com/apache/trafficcontrol/pull/7142#issuecomment-1306334417 Rebased onto master to get #7164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] zrhoffman merged pull request #7177: dep(run-ciab): update from Node12 to Node16

2022-11-07 Thread GitBox
zrhoffman merged PR #7177: URL: https://github.com/apache/trafficcontrol/pull/7177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] devenes commented on pull request #7177: dep(run-ciab): update from Node12 to Node16

2022-11-07 Thread GitBox
devenes commented on PR #7177: URL: https://github.com/apache/trafficcontrol/pull/7177#issuecomment-1306262254 > This looks good so far. Would you mind updating the other actions, too? > >

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7178: Update log4j to version 2.19.0

2022-11-07 Thread GitBox
srijeet0406 merged PR #7178: URL: https://github.com/apache/trafficcontrol/pull/7178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7178: Update log4j to version 2.19.0

2022-11-07 Thread GitBox
zrhoffman opened a new pull request, #7178: URL: https://github.com/apache/trafficcontrol/pull/7178 This PR updates the [`org.apache.logging.log4j.log4j-core`](https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core) dependency to version 2.19.0. ## Which

[GitHub] [trafficcontrol] devenes opened a new pull request, #7177: dep(run-ciab): update from Node12 to Node16

2022-11-07 Thread GitBox
devenes opened a new pull request, #7177: URL: https://github.com/apache/trafficcontrol/pull/7177 The GitHub Actions workflow gives the following annotation while running the action: > Node.js 12 actions are deprecated. For more information see:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7176: ATC build system: aarch64 support

2022-11-07 Thread GitBox
zrhoffman commented on PR #7176: URL: https://github.com/apache/trafficcontrol/pull/7176#issuecomment-1306031439 Rebased so *TR Ultimate Test Harness* passes now that #7175 is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] zrhoffman commented on pull request #4074: Set Content-Length header in Traffic Router

2022-11-07 Thread GitBox
zrhoffman commented on PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#issuecomment-1306026713 Rebased onto master so tests will pass now that #7175 is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [trafficcontrol] ocket8888 commented on issue #7094: Routing Name can be changed to default

2022-11-07 Thread GitBox
ocket commented on issue #7094: URL: https://github.com/apache/trafficcontrol/issues/7094#issuecomment-1306023201 correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

<    1   2   3   4   5   6   7   8   9   10   >