[GitHub] dangogh commented on issue #3040: CIAB: Make the socks container optional

2018-12-06 Thread GitBox
dangogh commented on issue #3040: CIAB: Make the socks container optional URL: https://github.com/apache/trafficcontrol/pull/3040#issuecomment-445074950 this was included in #3005 -- closing this one to avoid merge conflicts T

[GitHub] asfgit commented on issue #3102: Fix Test cg bad login expecting nil err

2018-12-06 Thread GitBox
asfgit commented on issue #3102: Fix Test cg bad login expecting nil err URL: https://github.com/apache/trafficcontrol/pull/3102#issuecomment-445075748 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2915/ T

[GitHub] asfgit commented on issue #3005: Fix optional vnc container

2018-12-06 Thread GitBox
asfgit commented on issue #3005: Fix optional vnc container URL: https://github.com/apache/trafficcontrol/pull/3005#issuecomment-445076604 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2916/ Test PASSed.

[GitHub] mitchell852 closed issue #3076: Federations page in Traffic Portal won't load for CDNs with no federations

2018-12-06 Thread GitBox
mitchell852 closed issue #3076: Federations page in Traffic Portal won't load for CDNs with no federations URL: https://github.com/apache/trafficcontrol/issues/3076 This is an automated message from the Apache Git Service. T

[GitHub] mitchell852 closed pull request #2857: Fixes TO cdn/federations to return [] not null

2018-12-06 Thread GitBox
mitchell852 closed pull request #2857: Fixes TO cdn/federations to return [] not null URL: https://github.com/apache/trafficcontrol/pull/2857 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] moltzaum commented on issue #3097: Blank fields incorrectly returns 200 OK when POSTing

2018-12-07 Thread GitBox
moltzaum commented on issue #3097: Blank fields incorrectly returns 200 OK when POSTing URL: https://github.com/apache/trafficcontrol/issues/3097#issuecomment-445275266 Fixed by #3098 This is an automated message from the Ap

[GitHub] moltzaum closed issue #3097: Blank fields incorrectly returns 200 OK when POSTing

2018-12-07 Thread GitBox
moltzaum closed issue #3097: Blank fields incorrectly returns 200 OK when POSTing URL: https://github.com/apache/trafficcontrol/issues/3097 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] rawlinp closed pull request #3083: grovetccfg: use kernel host name if -host argument is not used on the command line.

2018-12-07 Thread GitBox
rawlinp closed pull request #3083: grovetccfg: use kernel host name if -host argument is not used on the command line. URL: https://github.com/apache/trafficcontrol/pull/3083 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below fo

[GitHub] asfgit commented on issue #3100: Updated profiles and parameters test to clean up parameters better

2018-12-07 Thread GitBox
asfgit commented on issue #3100: Updated profiles and parameters test to clean up parameters better URL: https://github.com/apache/trafficcontrol/pull/3100#issuecomment-445295830 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/

[GitHub] rawlinp closed pull request #3099: Udate the grove logrotate config to include the custom_ats_2.log

2018-12-07 Thread GitBox
rawlinp closed pull request #3099: Udate the grove logrotate config to include the custom_ats_2.log URL: https://github.com/apache/trafficcontrol/pull/3099 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prove

[GitHub] dneuman64 closed pull request #3072: Emit warning when adding self-signed certs using the API rather than prohibiting them

2018-12-07 Thread GitBox
dneuman64 closed pull request #3072: Emit warning when adding self-signed certs using the API rather than prohibiting them URL: https://github.com/apache/trafficcontrol/pull/3072 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed belo

[GitHub] dneuman64 closed pull request #3085: Add a TR_LOC type to seeds.sql

2018-12-07 Thread GitBox
dneuman64 closed pull request #3085: Add a TR_LOC type to seeds.sql URL: https://github.com/apache/trafficcontrol/pull/3085 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] dneuman64 closed issue #3084: Missing default type TR_LOC

2018-12-07 Thread GitBox
dneuman64 closed issue #3084: Missing default type TR_LOC URL: https://github.com/apache/trafficcontrol/issues/3084 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] asfgit commented on issue #1781: Add SSL private key and CSR generation functionality to traffic_ops_golang

2018-12-07 Thread GitBox
asfgit commented on issue #1781: Add SSL private key and CSR generation functionality to traffic_ops_golang URL: https://github.com/apache/trafficcontrol/pull/1781#issuecomment-445366299 Refer to this link for build results (access rights to CI server needed): https://builds.apache.

[GitHub] asfgit commented on issue #3078: WIP - API documentation overhaul

2018-12-07 Thread GitBox
asfgit commented on issue #3078: WIP - API documentation overhaul URL: https://github.com/apache/trafficcontrol/pull/3078#issuecomment-445382657 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2919/ Test PAS

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239965999 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239953358 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239944793 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239932511 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239950394 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239947686 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239965576 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239947342 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239956450 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239934665 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239962607 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239955341 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239933601 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239932659 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239965677 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on issue #1781: Add SSL private key and CSR generation functionality to traffic_ops_golang

2018-12-07 Thread GitBox
rawlinp commented on issue #1781: Add SSL private key and CSR generation functionality to traffic_ops_golang URL: https://github.com/apache/trafficcontrol/pull/1781#issuecomment-445389378 @jrushford can this PR be closed? This functionality has since been added to traffic_ops_golang, right

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239954440 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239967210 ## File path: traffic_router/core/src/test/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239951408 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239965776 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239964647 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239953126 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2018-12-07 Thread GitBox
rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239959708 ## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control

[GitHub] ocket8888 opened a new issue #3103: /api/1.x/profileparameters route in Go has dropped support for array format

2018-12-10 Thread GitBox
ocket opened a new issue #3103: /api/1.x/profileparameters route in Go has dropped support for array format URL: https://github.com/apache/trafficcontrol/issues/3103 The old Perl API would allow either single-object profileId/parameterId pairs like so: ```json { "profileI

[GitHub] asfgit commented on issue #3078: WIP - API documentation overhaul

2018-12-10 Thread GitBox
asfgit commented on issue #3078: WIP - API documentation overhaul URL: https://github.com/apache/trafficcontrol/pull/3078#issuecomment-445863331 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2921/ Test FAI

[GitHub] ezelkow1 opened a new pull request #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
ezelkow1 opened a new pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104 These changes are to fix the issue of the monitoring.json and crconfig's being out of sync. Currently it is possible to make a change to a status (or other fie

[GitHub] asfgit commented on issue #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
asfgit commented on issue #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#issuecomment-445867991 Can one of the admins verify this patch? This is an automated message from the Ap

[GitHub] rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240312552 ## File path: traffic_ops/traffic_ops_golang/crconfig/snapshot.go ## @@ -40,10 +42,14 @@ func Snapshot(tx *sql

[GitHub] rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240294906 ## File path: traffic_ops/traffic_ops_golang/crconfig/snapshot.go ## @@ -40,10 +42,14 @@ func Snapshot(tx *sql

[GitHub] rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240307983 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -142,7 +141,8 @@ func Routes(d ServerData) ([]Rou

[GitHub] rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240293991 ## File path: traffic_ops/traffic_ops_golang/crconfig/snapshot.go ## @@ -27,9 +27,11 @@ import ( "gi

[GitHub] rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240321578 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -142,7 +141,8 @@ func Routes(d ServerData) ([]Rou

[GitHub] rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240295443 ## File path: traffic_ops/traffic_ops_golang/crconfig/snapshot.go ## @@ -40,10 +42,14 @@ func Snapshot(tx *sql

[GitHub] asfgit commented on issue #3078: WIP - API documentation overhaul

2018-12-10 Thread GitBox
asfgit commented on issue #3078: WIP - API documentation overhaul URL: https://github.com/apache/trafficcontrol/pull/3078#issuecomment-445928959 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2922/ Test PAS

[GitHub] ocket8888 opened a new pull request #3105: Fixed minor spelling issues, made formatting slightly more consistent

2018-12-10 Thread GitBox
ocket opened a new pull request #3105: Fixed minor spelling issues, made formatting slightly more consistent URL: https://github.com/apache/trafficcontrol/pull/3105 ## What does this PR do? Fixes some minor issues with the CIAB documentation, eliminating docs compiler warnings/error

[GitHub] asfgit commented on issue #3078: WIP - API documentation overhaul

2018-12-10 Thread GitBox
asfgit commented on issue #3078: WIP - API documentation overhaul URL: https://github.com/apache/trafficcontrol/pull/3078#issuecomment-445931517 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2923/ Test PAS

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240335508 ## File path: traffic_monitor/config/config.go ## @@ -147,6 +157,9 @@ func (c *Config) UnmarshalJSON(data []byte) e

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240339772 ## File path: traffic_monitor/towrap/towrap.go ## @@ -277,8 +312,30 @@ func (s TrafficOpsSessionThreadsafe) traffi

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240335125 ## File path: traffic_monitor/config/config.go ## @@ -40,6 +40,10 @@ const ( LogLocationNull = "null"

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240340268 ## File path: traffic_monitor/towrap/towrap.go ## @@ -229,16 +244,36 @@ func (s *TrafficOpsSessionThreadsafe) CRCon

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240335381 ## File path: traffic_monitor/config/config.go ## @@ -67,6 +71,9 @@ type Config struct { CRConfigHistoryCou

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240338772 ## File path: traffic_monitor/towrap/towrap.go ## @@ -277,8 +312,30 @@ func (s TrafficOpsSessionThreadsafe) traffi

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240337540 ## File path: traffic_monitor/towrap/towrap.go ## @@ -229,16 +244,36 @@ func (s *TrafficOpsSessionThreadsafe) CRCon

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240338531 ## File path: traffic_monitor/towrap/towrap.go ## @@ -229,16 +244,36 @@ func (s *TrafficOpsSessionThreadsafe) CRCon

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240339206 ## File path: traffic_monitor/towrap/towrap.go ## @@ -277,8 +312,30 @@ func (s TrafficOpsSessionThreadsafe) traffi

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240339377 ## File path: traffic_monitor/towrap/towrap.go ## @@ -277,8 +312,30 @@ func (s TrafficOpsSessionThreadsafe) traffi

[GitHub] rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3053: Traffic Monitor Disk Support URL: https://github.com/apache/trafficcontrol/pull/3053#discussion_r240342432 ## File path: traffic_monitor/towrap/towrap.go ## @@ -229,16 +244,36 @@ func (s *TrafficOpsSessionThreadsafe) CRCon

[GitHub] asfgit commented on issue #3105: Fixed minor spelling issues, made formatting slightly more consistent

2018-12-10 Thread GitBox
asfgit commented on issue #3105: Fixed minor spelling issues, made formatting slightly more consistent URL: https://github.com/apache/trafficcontrol/pull/3105#issuecomment-445940326 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/j

[GitHub] mitchell852 closed pull request #3105: Fixed minor spelling issues, made formatting slightly more consistent

2018-12-10 Thread GitBox
mitchell852 closed pull request #3105: Fixed minor spelling issues, made formatting slightly more consistent URL: https://github.com/apache/trafficcontrol/pull/3105 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] ezelkow1 commented on a change in pull request #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
ezelkow1 commented on a change in pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240370858 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -142,7 +141,8 @@ func Routes(d ServerData) ([]R

[GitHub] asfgit commented on issue #3078: WIP - API documentation overhaul

2018-12-10 Thread GitBox
asfgit commented on issue #3078: WIP - API documentation overhaul URL: https://github.com/apache/trafficcontrol/pull/3078#issuecomment-445966566 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2925/ Test PAS

[GitHub] mitchell852 commented on issue #3091: Fixed bad default parent.config line generation

2018-12-10 Thread GitBox
mitchell852 commented on issue #3091: Fixed bad default parent.config line generation URL: https://github.com/apache/trafficcontrol/pull/3091#issuecomment-445969082 @ocket - can you remove the formatting changes? This is

[GitHub] ezelkow1 commented on a change in pull request #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
ezelkow1 commented on a change in pull request #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#discussion_r240396553 ## File path: traffic_ops/client/atsconfig.go ## @@ -0,0 +1,91 @@ +/* + + Licensed under the Apache Licens

[GitHub] ezelkow1 commented on a change in pull request #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
ezelkow1 commented on a change in pull request #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#discussion_r240396969 ## File path: traffic_ops/client/atsconfig.go ## @@ -0,0 +1,91 @@ +/* + + Licensed under the Apache Licens

[GitHub] ezelkow1 commented on a change in pull request #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
ezelkow1 commented on a change in pull request #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#discussion_r240397065 ## File path: traffic_ops/client/atsconfig.go ## @@ -0,0 +1,91 @@ +/* + + Licensed under the Apache Licens

[GitHub] rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#discussion_r240400974 ## File path: traffic_ops/client/atsconfig.go ## @@ -0,0 +1,91 @@ +/* + + Licensed under the Apache License,

[GitHub] rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#discussion_r240401315 ## File path: traffic_ops/client/atsconfig.go ## @@ -0,0 +1,91 @@ +/* + + Licensed under the Apache License,

[GitHub] rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#discussion_r240401068 ## File path: traffic_ops/client/atsconfig.go ## @@ -0,0 +1,91 @@ +/* + + Licensed under the Apache License,

[GitHub] rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#discussion_r240401325 ## File path: traffic_ops/client/atsconfig.go ## @@ -0,0 +1,91 @@ +/* + + Licensed under the Apache License,

[GitHub] rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
rob05c commented on a change in pull request #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#discussion_r240404548 ## File path: traffic_ops/client/atsconfig.go ## @@ -0,0 +1,91 @@ +/* + + Licensed under the Apache License,

[GitHub] asfgit commented on issue #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
asfgit commented on issue #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#issuecomment-445997368 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2926/ Test FAI

[GitHub] ezelkow1 commented on a change in pull request #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
ezelkow1 commented on a change in pull request #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#discussion_r240405538 ## File path: traffic_ops/client/atsconfig.go ## @@ -0,0 +1,91 @@ +/* + + Licensed under the Apache Licens

[GitHub] asfgit commented on issue #3075: Traffic Ops Golang parent.config

2018-12-10 Thread GitBox
asfgit commented on issue #3075: Traffic Ops Golang parent.config URL: https://github.com/apache/trafficcontrol/pull/3075#issuecomment-445998822 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2927/ Test FAI

[GitHub] dneuman64 commented on a change in pull request #3104: Add monitoring.json snapshotting

2018-12-10 Thread GitBox
dneuman64 commented on a change in pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240410412 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -142,7 +141,7 @@ func Routes(d ServerData) ([]

[GitHub] mitchell852 commented on issue #3043: removes max-length from profile name

2018-12-11 Thread GitBox
mitchell852 commented on issue #3043: removes max-length from profile name URL: https://github.com/apache/trafficcontrol/pull/3043#issuecomment-446223236 retest this please This is an automated message from the Apache Git Serv

[GitHub] asfgit commented on issue #3043: removes max-length from profile name

2018-12-11 Thread GitBox
asfgit commented on issue #3043: removes max-length from profile name URL: https://github.com/apache/trafficcontrol/pull/3043#issuecomment-446225409 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2928/ Test

[GitHub] asfgit commented on issue #3078: WIP - API documentation overhaul

2018-12-11 Thread GitBox
asfgit commented on issue #3078: WIP - API documentation overhaul URL: https://github.com/apache/trafficcontrol/pull/3078#issuecomment-446229336 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2929/ Test PAS

[GitHub] asfgit commented on issue #3091: Fixed bad default parent.config line generation

2018-12-11 Thread GitBox
asfgit commented on issue #3091: Fixed bad default parent.config line generation URL: https://github.com/apache/trafficcontrol/pull/3091#issuecomment-446234820 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/29

[GitHub] ocket8888 commented on issue #3091: Fixed bad default parent.config line generation

2018-12-11 Thread GitBox
ocket commented on issue #3091: Fixed bad default parent.config line generation URL: https://github.com/apache/trafficcontrol/pull/3091#issuecomment-446237060 Done This is an automated message from the Apache Git Service.

[GitHub] mitchell852 opened a new issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
mitchell852 opened a new issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106 The following ATS "config" files are generated from TO: https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficS

[GitHub] rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting

2018-12-11 Thread GitBox
rob05c commented on a change in pull request #3104: Add monitoring.json snapshotting URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240659712 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -142,7 +141,7 @@ func Routes(d ServerData) ([]Rou

[GitHub] ocket8888 commented on issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
ocket commented on issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106#issuecomment-446251379 The files which I believe have important ordering are: * cache.config * hosting.config * ip_allow.config * parent.config *

[GitHub] rob05c commented on issue #1739: Traffic Monitor CRConfig and monitoring.json polls aren't synchronized

2018-12-11 Thread GitBox
rob05c commented on issue #1739: Traffic Monitor CRConfig and monitoring.json polls aren't synchronized URL: https://github.com/apache/trafficcontrol/issues/1739#issuecomment-446251341 **Update** We have a PR to fix #1738 - PR #3104. But that PR does **not** fix this bug. The two

[GitHub] ocket8888 edited a comment on issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
ocket edited a comment on issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106#issuecomment-446251379 The files which I believe have important ordering are: * cache.config * hosting.config * ip_allow.config * parent.confi

[GitHub] rob05c edited a comment on issue #1739: Traffic Monitor CRConfig and monitoring.json polls aren't synchronized

2018-12-11 Thread GitBox
rob05c edited a comment on issue #1739: Traffic Monitor CRConfig and monitoring.json polls aren't synchronized URL: https://github.com/apache/trafficcontrol/issues/1739#issuecomment-446251341 **Update** We have a PR to fix #1738 - PR #3104. But that PR does **not** fix this bug. T

[GitHub] rob05c commented on issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
rob05c commented on issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106#issuecomment-446254574 I'd like to request this, and all ATS config file changes, are done in Go, not Perl; unless they're critical bugs. I've done a great deal

[GitHub] rob05c edited a comment on issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
rob05c edited a comment on issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106#issuecomment-446254574 I'd like to request this, and all ATS config file changes, are done in Go, not Perl; unless they're critical bugs. I've done a gre

[GitHub] ocket8888 commented on issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
ocket commented on issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106#issuecomment-446256740 I wholeheartedly agree with @rob05c This is an automated message from the Ap

[GitHub] ocket8888 opened a new issue #3107: /api/1.3/origins has bad interactions with STEERING Delivery Services

2018-12-11 Thread GitBox
ocket opened a new issue #3107: /api/1.3/origins has bad interactions with STEERING Delivery Services URL: https://github.com/apache/trafficcontrol/issues/3107 Despite that an origin on a STEERING (or CLIENT_STEERING) Delivery Service is a more or less meaningless notion, it is perfect

[GitHub] mitchell852 commented on issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
mitchell852 commented on issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106#issuecomment-446277335 ok @rob05c i can't argue with that. i opened this issue because i was really trying to satisfy a compare tool that we have that shows false

[GitHub] mitchell852 closed issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
mitchell852 closed issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] rob05c commented on issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
rob05c commented on issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106#issuecomment-446300720 To be clear, I'm not opposed to ordering, just asking to wait until Go. FWIW I think there are pros and cons of ordering, of making the ge

[GitHub] rob05c edited a comment on issue #3106: ATS config file content ordering

2018-12-11 Thread GitBox
rob05c edited a comment on issue #3106: ATS config file content ordering URL: https://github.com/apache/trafficcontrol/issues/3106#issuecomment-446300720 To be clear, I'm not opposed to ordering, just asking to wait until Go. FWIW I think there are pros and cons of ordering, of making

[GitHub] chadgilloth opened a new pull request #3108: Delivery Service Requests Protractor Tests

2018-12-11 Thread GitBox
chadgilloth opened a new pull request #3108: Delivery Service Requests Protractor Tests URL: https://github.com/apache/trafficcontrol/pull/3108 What does this PR do? Adds CRUD Protractor tests for Delivery Service Requests Fixes #(issue_number) Which TC components

[GitHub] dangogh commented on a change in pull request #3047: Golang DB admin

2018-12-11 Thread GitBox
dangogh commented on a change in pull request #3047: Golang DB admin URL: https://github.com/apache/trafficcontrol/pull/3047#discussion_r240736820 ## File path: traffic_ops_db/test/docker/Dockerfile-db-admin ## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation

  1   2   3   4   5   6   7   8   9   10   >