Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/568
@zwoop clang-formatted & rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/issues/1483
I wonder if there's a way to roll in header logging for 4xx/5xx
transactions into this idea as well.
See #1210.
---
If your project is set up for it, you can reply to this email
GitHub user danobi opened an issue:
https://github.com/apache/trafficserver/issues/1484
There should be a Cache-Control immutable constant in the API
We could call it `TS_HTTP_VALUE_IMMUTABLE`.
See https://tools.ietf.org/html/draft-mcmanus-immutable-01 for the RFC
draft
Github user danobi closed the issue at:
https://github.com/apache/trafficserver/issues/1486
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1487
esi/combo_handler plugin doesn't register
The plugin doesn't call TSPluginRegister. The causes ATS to crash upon
startup if combo_handler is enabled.
See issue #1486.
You can
GitHub user danobi opened an issue:
https://github.com/apache/trafficserver/issues/1486
esi/combo_handler plugin doesn't call TSPluginRegister
This causes ATS to crash if ATS is run with combo_handler.
---
If your project is set up for it, you can reply to this email
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1516
I'm on the fence about including the `Cache-Control: private` changes in
this patch. On one hand, it makes sense for that to be in this refactor. On the
other, it has nothing to do
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1516
Implement Cache-Control: immutable handling
This patch makes `combo_handler` correctly handle the presence of one or
more immutable flags.
In short, the combo response
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1059
TS-4626: LogFile::close_file should not delete m_log handle
LogFile::close_file was incorrectly deleting the m_log object.
This caused potential race conditions when flushing m_log since
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1073
TS-4399 TS-4400 Management API messes up proxy options
TS-4399: Management API breaks diagnostic log rotation
TS-4400: TSProxyStateSet persist cache clearing across restart
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1086
Clarify logging docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver logging_doc_fix
Alternatively you can review
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1073
I think the delay issue is either:
1) The `mgmt_sleep_sec(1)` loop in `ProxyStateSet` b/c the main
`traffic_manager` loop needs to run for the `lmgmt->proxy_running` flag to flip
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1210
Created under @SolidWallOfCode 's orders.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1210
Create log_requests plugin
This plugin records status line & headers for all 4xx/5xx response
transactions. Also included is a blacklist feature to omit any
specific response
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1210#discussion_r87227079
--- Diff: plugins/experimental/log_requests/log_requests.c ---
@@ -0,0 +1,301 @@
+/** @file
+
+ Logs full request/response headers
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1073
How does that look? Still need to figure out that delay issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1073
@jpeach, is this what you were thinking?
Also, between commit 82037 and 3365b, `traffic_ctl` stopped working
immediately after ATS starts up. There is ~30s gap between startup any
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1073#discussion_r83509798
--- Diff: cmd/traffic_manager/traffic_manager.cc ---
@@ -835,10 +824,11 @@ main(int argc, const char **argv)
} else
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1210#discussion_r89883222
--- Diff: plugins/experimental/log_requests/log_requests.cc ---
@@ -0,0 +1,352 @@
+/** @file
+
+ Logs full request/response headers
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1210#discussion_r89884095
--- Diff: plugins/experimental/log_requests/log_requests.cc ---
@@ -0,0 +1,352 @@
+/** @file
+
+ Logs full request/response headers
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1210#discussion_r89882819
--- Diff: plugins/experimental/log_requests/log_requests.cc ---
@@ -0,0 +1,352 @@
+/** @file
+
+ Logs full request/response headers
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1210
I'm just going to start adding ideas of names to this comment as I come up
with them.
`dump_errors`, `log_bad`, `log_errors`
---
If your project is set up for it, you can reply
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1225
Create a tool to list files changed since a tag
As requested by @dragon512
===
The default (no args) is to ouput all files changed since the
most recent tag (lexicographically
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1225
I'm less convinced this works than when I opened the PR. Testing some more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1224
TS-5056 Implement nonrecoverable error mechanism
Change `Emergency()` to terminate the current process with status
code UNRECOVERABLE_EXIT.
Also change traffic_manager to listen
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1165
TS-5023 Allow diags.log and traffic.out to be rotated by size or time
Create a third option for diagnostic logs: roll by time or size,
whichever comes first. This is useful in certain
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1073
The actual issue was suspected issue #1, where there was a sleeping
deadlock scenario. See commit message for details.
Other than that most recent change, I think the patch is ready
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1073
I couldn't figure out where the dup option was so I changed TS-4400 to a
subtask of TS-4399.
Also, can you kick off the CI again? I think I fixed the build.
---
If your project
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1253
TS-5084 Make logcat follow file rotation
This patch makes `traffic_logcat -f` follow squid.blog even when
squid.blog is rotated. Previously, the tool did not do this at all
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1254
TS-5085 `posix_fadvise` is incorrectly used in traffic_logcat
`traffic_logcat` was not using `posix_fadvise` correctly. This
patch corrects the original poor usage as well as adds some
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1254
@shinrich Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1257
That sounds like a good idea. I'll open up a separate ticket for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1268
TS-5097 Validate plugin argument count
If we don't validate the plugin argument count, the plugin API is
vulnerable to buffer overflow fun (not actually fun).
You can merge this pull
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1257
TS-5053 const char **argv passed to TSPluginInit is not null terminated
Typically **argv is null terminated in other systems. There's no
good reason for ATS to be any different.
You can
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1225
Forget about this for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user danobi closed the pull request at:
https://github.com/apache/trafficserver/pull/1225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1254#discussion_r91414850
--- Diff: proxy/logcat.cc ---
@@ -300,6 +307,9 @@ main(int /* argc ATS_UNUSED */, const char *argv
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1248
TS-5070 Add configuration variables to set file permissions for diags.log &
traffic.out
We add 2 more config variables to control file permissions for
diagnostics
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1253
@shinrich Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1623
Delete dead code
None of this code was being called or used elsewhere. Most likely some
point before git history someone migrated off the abstract base class
and never bothered
GitHub user danobi opened an issue:
https://github.com/apache/trafficserver/issues/1622
Delete proxyAbstractBuffer.{cc,h}
These files are never used, despite the fact that other comments seem to
indicate otherwise.
Just another day in the logging subsystem, I guess
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/issues/1622
Sorry. I made this issue to put off the task but I never ended up putting
it off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1623#discussion_r109180096
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -112,14 +112,6 @@ LogBufferHeader::log_filename()
return addr
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1516
I didn't realize there was a doc page for that. Updating now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1567#discussion_r106496765
--- Diff: lib/ts/Scrubber.h ---
@@ -0,0 +1,89 @@
+/** @file
+
+ The Scrubber class helps replace patterns of text inside a buffer
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1567#discussion_r106495464
--- Diff: lib/ts/Diags.h ---
@@ -226,6 +242,10 @@ class Diags
mutable ink_mutex tag_table_lock; // prevents reconfig/read races
DFA
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1567#discussion_r106495318
--- Diff: lib/ts/Scrubber.cc ---
@@ -0,0 +1,201 @@
+/** @file
+
+ Implementation for Scrubber.h
+
+ @section license License
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1516
I just copied over the same text from the README to the admin config docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1588
Make clear the implicit relationship between configs
`periodic_tasks_interval` is the gatekeeper for all periodic tasks.
Meaning, the implicit lower bound for all other log related
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1516
@shukitchan @SolidWallOfCode Alright I believe I've made all the requested
changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1516
Before, all combo handler documents were marked public. In the current
state of the patch, combo handler documents will be private if any of the
requested documents is private.
---
If your
GitHub user danobi opened an issue:
https://github.com/apache/trafficserver/issues/1599
Remove combohandler feature gate for 8.0 release
I recently noticed `combohandler` was marking all of its generated
documents as `Cache-Control: Public` regardless of what the requested
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1567#discussion_r106498117
--- Diff: proxy/logging/LogObject.h ---
@@ -299,6 +299,10 @@ class LogObject : public RefCountObj
unsigned m_buffer_manager_idx
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r106499461
--- Diff: doc/admin-guide/plugins/combo_handler.en.rst ---
@@ -83,3 +83,16 @@ results in these file paths being "reconstructed"::
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1516
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1567
Personally, I don't think this feature has much use in open source. If
nothing else, it probably encourages poor security practices. Even with this
patch, someone could still do a `fprintf
GitHub user danobi opened an issue:
https://github.com/apache/trafficserver/issues/1589
glibc 2.25 will cause compile errors
Heads up: according to the 2.25 release document:
> * The types res_sendhookact, res_send_qhook, re_send_rhook, and the
qhook and rhook memb
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1210
Closing. I'm in the process of creating new log fields to do the same thing
here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user danobi closed the pull request at:
https://github.com/apache/trafficserver/pull/1210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1567
@SolidWallOfCode This patch is done on my end and ready for review. If I
find some time tonight I'll stare at the code and see if I can catch any bugs.
It doesn't have any AFAICT
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1516
Ok. Does a feature gate sound good? We can flip the flag on the next
release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103987142
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
~InterceptData
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103965747
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
~InterceptData
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103965565
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
~InterceptData
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1516
@shukitchan, I've updated the documentation.
@SolidWallOfCode @shukitchan, What's the consensus on the max-age change &
private change? For max age, @shukitchan is right, the
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r104771989
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
}
}
+void
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1567
Diags scrubbing mechanism
This should be the squashed commit message:
Diagnostic log scrubbing is intended an extra security measure to prevent
sensitive strings from leaking
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1567
The last commit gets error.log scrubbed too. I'll fix the allocation stuff
on Tuesday. Nobody tell Leif.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r104584519
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
}
}
+void
69 matches
Mail list logo
