[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176893779 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java

[GitHub] merlimat opened a new pull request #1290: Added executeOrdered to complement submitOrdered

merlimat opened a new pull request #1290: Added executeOrdered to complement submitOrdered URL: https://github.com/apache/bookkeeper/pull/1290 In many cases, we are not interested in the `ListenableFuture` returned by `submitOrdered()` call. In these cases we can avoid creating the future

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176652302 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java

[GitHub] sijie commented on a change in pull request #1284: Improve FileInfoBackingCache

sijie commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176669548 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -52,25

[GitHub] sijie commented on a change in pull request #1284: Improve FileInfoBackingCache

sijie commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176669917 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -92,8

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176653861 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java

[GitHub] ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache

ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176658666 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -52,25

[GitHub] ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache

ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176658955 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -92,8

[GitHub] eolivelli commented on issue #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli commented on issue #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375587351 @sijie @merlimat @ivankelly I have updated the patch. I will run this code on

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375587424 > Ah yes. At minimum we should be checking again for existence inside the write lock. this is one of the change I made here, checking the

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176651575 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176651575 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176658665 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ## @@

[GitHub] sijie commented on a change in pull request #1284: Improve FileInfoBackingCache

sijie commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176671260 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -92,8

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176654536 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ## @@

[GitHub] ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache

ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176673561 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -52,25

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375587424 > Ah yes. At minimum we should be checking again for existence inside the write lock. this is one of the change I made here, checking the

[GitHub] eolivelli commented on a change in pull request #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli commented on a change in pull request #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#discussion_r176820894 ## File path:

[GitHub] sijie commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

sijie commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375761202 > This change prevents errors seen when Bookie runs on java 9. > There must be some race

[GitHub] sijie commented on a change in pull request #1288: Add sync variants of all methods in handles

sijie commented on a change in pull request #1288: Add sync variants of all methods in handles URL: https://github.com/apache/bookkeeper/pull/1288#discussion_r176840948 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/Handle.java ## @@ -21,7

[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375755481 @sijie MessageToMessageEncoder uses reflection and does checks on objects types and it

[GitHub] ivankelly commented on issue #1284: Improve FileInfoBackingCache

ivankelly commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375764973 Sure. I'm fine with current approach. If we were using stock ConcurrentHashMap it'd be less risky, but since the hashmap is our code too, it's better

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375752857 @ivankelly > it seems pointless to have locks around a concurrent hashmap well. depends on how you see stuffs. concurrent hashmap is section

[GitHub] ivankelly opened a new pull request #1288: Add sync variants of all methods in handles

ivankelly opened a new pull request #1288: Add sync variants of all methods in handles URL: https://github.com/apache/bookkeeper/pull/1288 As discussed on the mailing list [1], this patch removes the inconsistency around the naming of the close call on the new handle APIs, by

[GitHub] sijie commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

sijie commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375759930 > MessageToMessageEncoder uses reflection and does checks on objects types and it does other

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375770793 > If we were using stock ConcurrentHashMap it'd be less risky, but since the hashmap is our code too, it's better to err on the safe side.

[GitHub] ivankelly commented on issue #1284: Improve FileInfoBackingCache

ivankelly commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375784499 retest this please This is an automated message from the Apache Git Service. To

[GitHub] ivankelly commented on issue #1288: Add sync variants of all methods in handles

ivankelly commented on issue #1288: Add sync variants of all methods in handles URL: https://github.com/apache/bookkeeper/pull/1288#issuecomment-375784107 @sijie updated This is an automated message from the Apache Git

[GitHub] ivankelly commented on issue #1284: Improve FileInfoBackingCache

ivankelly commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375654584 I'm fine with the current approach, but it seems pointless to have locks around a concurrent hashmap. I've made a PR into your branch with a lockless

Jenkins build is back to normal : bookkeeper_release_nightly_snapshot #107

See

Jenkins build is back to stable : bookkeeper_postcommit_master_java8 #79

See

Jenkins build is unstable: bookkeeper_postcommit_master_java9 #79

See

[GitHub] sijie commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage

sijie commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1289#discussion_r176889479 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java

[GitHub] merlimat commented on issue #1289: Allow multiple directories in DbLedgerStorage

merlimat commented on issue #1289: Allow multiple directories in DbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1289#issuecomment-375828219 In any case, I'm still testing this code. This is an automated

[GitHub] merlimat opened a new pull request #1289: Allow multiple directories in DbLedgerStorage

merlimat opened a new pull request #1289: Allow multiple directories in DbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1289 In normal conditions, the max throughput that a bookie can sustain is mostly determined by how fast we can write entries on the journal. If

[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375820877 @sijie I have addressed your comment and simplified the description

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375821309 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage

merlimat commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1289#discussion_r176886446 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java

[GitHub] sijie commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage

sijie commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1289#discussion_r176886832 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176881392 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java

[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375818341 @sijie thank you. Description updated. I will create an issue with logs and the full story

[GitHub] sijie commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage

sijie commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1289#discussion_r176884131 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java

[GitHub] sijie commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage

sijie commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1289#discussion_r176883633 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java

[GitHub] merlimat commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage

merlimat commented on a change in pull request #1289: Allow multiple directories in DbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1289#discussion_r176888177 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java

Jenkins build is back to stable : bookkeeper_release_branch #97

See

[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375712254 @merlimat @sijie since you already took a look to this patch I will wait your ack before

[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375702124 The fix is running without problem, my collegues are very happy. I am removing the flag

[GitHub] sijie commented on a change in pull request #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

sijie commented on a change in pull request #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#discussion_r176809493 ## File path: