[jira] [Commented] (FLINK-3475) DISTINCT aggregate function support for SQL queries

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885559#comment-15885559 ] ASF GitHub Bot commented on FLINK-3475: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty f...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3417#discussion_r103203173 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java --- @@ -358,24 +358,27 @@ protected boolean

[GitHub] flink pull request #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty f...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3417#discussion_r103183251 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java --- @@ -957,6 +964,42 @@ public void testPojoTypeWithPrivateField()

[jira] [Commented] (FLINK-5907) RowCsvInputFormat bug on parsing tsv

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885781#comment-15885781 ] ASF GitHub Bot commented on FLINK-5907: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5907) RowCsvInputFormat bug on parsing tsv

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885777#comment-15885777 ] ASF GitHub Bot commented on FLINK-5907: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5907) RowCsvInputFormat bug on parsing tsv

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885780#comment-15885780 ] ASF GitHub Bot commented on FLINK-5907: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3111: [FLINK-3475] [Table] DISTINCT aggregate function s...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3111#discussion_r103165057 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/rules/dataSet/FlinkAggregateExpandDistinctAggregatesRule.java --- @@ -0,0

[GitHub] flink pull request #3111: [FLINK-3475] [Table] DISTINCT aggregate function s...

2017-02-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3111#discussion_r103170129 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/DistinctAggregateTest.scala --- @@ -0,0 +1,275 @@ +/*

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885579#comment-15885579 ] ASF GitHub Bot commented on FLINK-4422: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3421: [FLINK-4422] Convert all time interval measurements to Sy...

2017-02-27 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3421 +1 to merge, with #3422. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Created] (FLINK-5927) Remove old Aggregate interface and built-in functions

2017-02-27 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-5927: Summary: Remove old Aggregate interface and built-in functions Key: FLINK-5927 URL: https://issues.apache.org/jira/browse/FLINK-5927 Project: Flink Issue

[jira] [Created] (FLINK-5928) Externalized checkpoints overwritting each other

2017-02-27 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-5928: -- Summary: Externalized checkpoints overwritting each other Key: FLINK-5928 URL: https://issues.apache.org/jira/browse/FLINK-5928 Project: Flink Issue Type: Bug

[GitHub] flink issue #3348: [FLINK-5090] [network] Add metrics for details about inbo...

2017-02-27 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3348 Right, that was missing indeed. I also found some bugs and useful extensions / inconsistencies that I fixed. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885712#comment-15885712 ] ASF GitHub Bot commented on FLINK-5090: --- Github user NicoK commented on the issue:

[GitHub] flink pull request #3420: [FLINK-4422] Convert all time interval measurement...

2017-02-27 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3420#discussion_r103182219 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/ClosableBlockingQueue.java --- @@

[jira] [Commented] (FLINK-5501) Determine whether the job starts from last JobManager failure

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885588#comment-15885588 ] ASF GitHub Bot commented on FLINK-5501: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3385: [FLINK-5501] JM use running job registry to determine whe...

2017-02-27 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3385 Thanks! I think I can take this over now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-4810) Checkpoint Coordinator should fail ExecutionGraph after "n" unsuccessful checkpoints

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885697#comment-15885697 ] ASF GitHub Bot commented on FLINK-4810: --- Github user ramkrish86 commented on the issue:

[GitHub] flink issue #3334: FLINK-4810 Checkpoint Coordinator should fail ExecutionGr...

2017-02-27 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3334 @StephanEwen - Ping for initial reviews. Will work on it based on the feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-5849) Kafka Consumer checkpointed state may contain undefined offsets

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885720#comment-15885720 ] ASF GitHub Bot commented on FLINK-5849: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3378: [FLINK-5849] [kafka] Move FlinkKafkaConsumer start...

2017-02-27 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3378#discussion_r103199733 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -330,8

[jira] [Commented] (FLINK-5907) RowCsvInputFormat bug on parsing tsv

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885778#comment-15885778 ] ASF GitHub Bot commented on FLINK-5907: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5907) RowCsvInputFormat bug on parsing tsv

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885776#comment-15885776 ] ASF GitHub Bot commented on FLINK-5907: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5907) RowCsvInputFormat bug on parsing tsv

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885779#comment-15885779 ] ASF GitHub Bot commented on FLINK-5907: --- Github user fhueske commented on a diff in the pull

[GitHub] flink issue #3422: [FLINK-4422] Convert all time interval measurements to Sy...

2017-02-27 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3422 Thanks for the fixes, +1 to merge. @jinmingjian I will proceed to merge this by squashing it with the other 3 PRs (0.8, 0.8, 0.10) as a single commit. --- If your project is set up for it, you

[jira] [Commented] (FLINK-5897) Untie Checkpoint Externalization from FileSystems

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885661#comment-15885661 ] ASF GitHub Bot commented on FLINK-5897: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #3378: [FLINK-5849] [kafka] Move FlinkKafkaConsumer start...

2017-02-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/3378#discussion_r103196367 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -330,8

[jira] [Commented] (FLINK-5849) Kafka Consumer checkpointed state may contain undefined offsets

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885719#comment-15885719 ] ASF GitHub Bot commented on FLINK-5849: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3378: [FLINK-5849] [kafka] Move FlinkKafkaConsumer start...

2017-02-27 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3378#discussion_r103199655 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java --- @@

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r102957246 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885741#comment-15885741 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103195228 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196509 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885734#comment-15885734 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196163 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196433 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103197159 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -136,21 +137,36 @@ public static Path setupLocalResource(

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103195082 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196883 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -136,21 +137,36 @@ public static Path setupLocalResource(

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103197726 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -131,6 +134,8 @@ /** Lazily initialized

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885749#comment-15885749 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885736#comment-15885736 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103195968 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885738#comment-15885738 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103177980 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/FileUtilsTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196755 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103181903 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885743#comment-15885743 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103177702 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/FileUtilsTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103200589 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnCLI.java --- @@ -85,6 +89,10 @@ public FlinkYarnCLI(String shortPrefix, String

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103177388 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103194179 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/FileUtilsTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103194600 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -248,6 +253,14 @@ public void addShipFiles(List

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103194453 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103197098 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -136,21 +137,36 @@ public static Path setupLocalResource(

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103196289 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -742,6 +755,24 @@ public FileVisitResult

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103177052 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885733#comment-15885733 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3475) DISTINCT aggregate function support for SQL queries

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885560#comment-15885560 ] ASF GitHub Bot commented on FLINK-3475: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3475) DISTINCT aggregate function support for SQL queries

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885558#comment-15885558 ] ASF GitHub Bot commented on FLINK-3475: --- Github user fhueske commented on a diff in the pull

[GitHub] flink issue #3419: [FLINK-4422] Convert all time interval measurements to Sy...

2017-02-27 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3419 +1 to merge, with #3422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885578#comment-15885578 ] ASF GitHub Bot commented on FLINK-4422: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885577#comment-15885577 ] ASF GitHub Bot commented on FLINK-4422: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885750#comment-15885750 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885754#comment-15885754 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885739#comment-15885739 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885752#comment-15885752 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885735#comment-15885735 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885746#comment-15885746 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885753#comment-15885753 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885748#comment-15885748 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885744#comment-15885744 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3388#discussion_r103178916 --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java --- @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885747#comment-15885747 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885740#comment-15885740 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885745#comment-15885745 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885737#comment-15885737 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885755#comment-15885755 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885742#comment-15885742 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885751#comment-15885751 ] ASF GitHub Bot commented on FLINK-5815: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5133) Support to set resource for operator in DataStream and DataSet

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885784#comment-15885784 ] ASF GitHub Bot commented on FLINK-5133: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #3303: [FLINK-5133][core] Support to set resource for operator i...

2017-02-27 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/3303 Hi @StephanEwen , thanks for detail reviews of this PR and I learnt a lot from your comments. I considered all your suggestions above and submitted the modifications, including:

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885565#comment-15885565 ] ASF GitHub Bot commented on FLINK-4422: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-5849) Kafka Consumer checkpointed state may contain undefined offsets

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885602#comment-15885602 ] ASF GitHub Bot commented on FLINK-5849: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3378: [FLINK-5849] [kafka] Move FlinkKafkaConsumer start offset...

2017-02-27 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3378 Rebased on `master`. Note about changes to partition assignment logic in deleted lines 538 - 553 and added lines 563 -565 of `FlinkKafkaConsumerBase`: The change is irrelevant to this

[jira] [Commented] (FLINK-5768) Apply new aggregation functions for datastream and dataset tables

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885601#comment-15885601 ] ASF GitHub Bot commented on FLINK-5768: --- GitHub user shaoxuan-wang opened a pull request:

[GitHub] flink pull request #3423: [FLINK-5768] [table] Apply new aggregation functio...

2017-02-27 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3423 [FLINK-5768] [table] Apply new aggregation functions for datastream and dataset tables This PR includes the following changes: 1. Change the implementation of the DataStream aggregation

[jira] [Created] (FLINK-5926) Show state backend information in web UI

2017-02-27 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-5926: -- Summary: Show state backend information in web UI Key: FLINK-5926 URL: https://issues.apache.org/jira/browse/FLINK-5926 Project: Flink Issue Type: Improvement

[GitHub] flink pull request #3411: [FLINK-5897] & [FLINK-5822] First step towards Gen...

2017-02-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3411#discussion_r103169593 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStore.java --- @@ -72,4 +72,5 @@ */ int

[jira] [Commented] (FLINK-5897) Untie Checkpoint Externalization from FileSystems

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885620#comment-15885620 ] ASF GitHub Bot commented on FLINK-5897: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-5897) Untie Checkpoint Externalization from FileSystems

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885618#comment-15885618 ] ASF GitHub Bot commented on FLINK-5897: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #3411: [FLINK-5897] & [FLINK-5822] First step towards Gen...

2017-02-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3411#discussion_r103169078 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -100,7 +107,9 @@ * accessing this don't

[GitHub] flink pull request #3411: [FLINK-5897] & [FLINK-5822] First step towards Gen...

2017-02-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3411#discussion_r103170089 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java --- @@ -21,20 +21,50 @@ import

[GitHub] flink pull request #3411: [FLINK-5897] & [FLINK-5822] First step towards Gen...

2017-02-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3411#discussion_r103192397 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java --- @@ -203,48 +208,67 @@ void setStatsCallback(@Nullable

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885571#comment-15885571 ] ASF GitHub Bot commented on FLINK-4422: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3420: [FLINK-4422] Convert all time interval measurement...

2017-02-27 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3420#discussion_r103181679 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KillerWatchDog.java --- @@ -42,12

[jira] [Commented] (FLINK-5897) Untie Checkpoint Externalization from FileSystems

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885619#comment-15885619 ] ASF GitHub Bot commented on FLINK-5897: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-5849) Kafka Consumer checkpointed state may contain undefined offsets

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885704#comment-15885704 ] ASF GitHub Bot commented on FLINK-5849: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #3378: [FLINK-5849] [kafka] Move FlinkKafkaConsumer start...

2017-02-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/3378#discussion_r103197252 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java --- @@

[jira] [Commented] (FLINK-5849) Kafka Consumer checkpointed state may contain undefined offsets

2017-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885705#comment-15885705 ] ASF GitHub Bot commented on FLINK-5849: --- Github user rmetzger commented on a diff in the pull

  1   2   3   >