[jira] [Commented] (FLINK-8324) Expose another offsets metrics by using new metric API to specify user defined variables

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321536#comment-16321536 ] ASF GitHub Bot commented on FLINK-8324: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321616#comment-16321616 ] ASF GitHub Bot commented on FLINK-6951: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5214: [FLINK-8324] [kafka] Expose another offsets metrics by us...

2018-01-10 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5214 Thanks for the PR @tony810430. The changes LGTM, will merge this a bit later. ---

[jira] [Commented] (FLINK-8327) ClassLoader resolution of child-first does not appear to work

2018-01-10 Thread Raymond Tay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321642#comment-16321642 ] Raymond Tay commented on FLINK-8327: Closing this as i have to dynamic classloading with {{http4s}}

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321558#comment-16321558 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2018-01-10 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 @casidiablo @tzulitai sorry, I had a long day yesterday and misunderstood what you mean. And thank you @casidiablo @xiatao123 both for confirming it works. ---

[jira] [Created] (FLINK-8410) Kafka consumer's commitedOffsets gauge metric is prematurely set

2018-01-10 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-8410: -- Summary: Kafka consumer's commitedOffsets gauge metric is prematurely set Key: FLINK-8410 URL: https://issues.apache.org/jira/browse/FLINK-8410 Project:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-10 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r160849478 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java --- @@ -88,6 +94,37 @@ public void run() {

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2018-01-10 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r160849525 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java --- @@ -250,10 +304,12 @@ private void

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321557#comment-16321557 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on a diff in the pull

[jira] [Resolved] (FLINK-8327) ClassLoader resolution of child-first does not appear to work

2018-01-10 Thread Raymond Tay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Tay resolved FLINK-8327. Resolution: Information Provided > ClassLoader resolution of child-first does not appear to work >

[jira] [Comment Edited] (FLINK-8327) ClassLoader resolution of child-first does not appear to work

2018-01-10 Thread Raymond Tay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321642#comment-16321642 ] Raymond Tay edited comment on FLINK-8327 at 1/11/18 3:34 AM: - Closing this as

[GitHub] flink pull request #5280: Fix typo in AbstractMetricGroup.java

2018-01-10 Thread maqingxiang
GitHub user maqingxiang opened a pull request: https://github.com/apache/flink/pull/5280 Fix typo in AbstractMetricGroup.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/maqingxiang/flink fix-typo-in-AbstractMetricGroup

[jira] [Commented] (FLINK-6109) Add "consumer lag" report metric to FlinkKafkaConsumer

2018-01-10 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321533#comment-16321533 ] Tzu-Li (Gordon) Tai commented on FLINK-6109: Thanks for picking the issue up [~aitozi]! Of

[GitHub] flink issue #5124: [FLINK-8199] [elasticsearch connector] Properly annotate ...

2018-01-10 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5124 Will merge this by the end of the week, given that there are no other objections ... ---

[jira] [Commented] (FLINK-8199) Annotation for Elasticsearch connector

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319930#comment-16319930 ] ASF GitHub Bot commented on FLINK-8199: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319938#comment-16319938 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in the pull

[GitHub] flink issue #4810: [FLINK-6926] [table] Add support for MD5,SHA1 and SHA256 ...

2018-01-10 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4810 Thank you for the PR @genged. I would throw an exception if the algorithm can not be found and would also move this code into the member part of a Flink `Function`. I will do the final polishing and

[jira] [Commented] (FLINK-6926) Add MD5/SHA1/SHA2 supported in SQL

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319991#comment-16319991 ] ASF GitHub Bot commented on FLINK-6926: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-7711) Port JarListHandler to new REST endpoint

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320044#comment-16320044 ] ASF GitHub Bot commented on FLINK-7711: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5209: [FLINK-7711] Port JarListHandler to WebMonitorEndp...

2018-01-10 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5209#discussion_r160638625 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/JarWithProgramUtils.java --- @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache

[jira] [Created] (FLINK-8407) Setting the parallelism after a partitioning operation should be forbidden

2018-01-10 Thread Xingcan Cui (JIRA)
Xingcan Cui created FLINK-8407: -- Summary: Setting the parallelism after a partitioning operation should be forbidden Key: FLINK-8407 URL: https://issues.apache.org/jira/browse/FLINK-8407 Project: Flink

[jira] [Created] (FLINK-8408) YarnFileStageTestS3ITCase.testRecursiveUploadForYarnS3n unstable on Travis

2018-01-10 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8408: Summary: YarnFileStageTestS3ITCase.testRecursiveUploadForYarnS3n unstable on Travis Key: FLINK-8408 URL: https://issues.apache.org/jira/browse/FLINK-8408 Project:

[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320327#comment-16320327 ] ASF GitHub Bot commented on FLINK-8306: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320376#comment-16320376 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320374#comment-16320374 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320375#comment-16320375 ] ASF GitHub Bot commented on FLINK-8332: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320430#comment-16320430 ] ASF GitHub Bot commented on FLINK-8333: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8324) Expose another offsets metrics by using new metric API to specify user defined variables

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319936#comment-16319936 ] ASF GitHub Bot commented on FLINK-8324: --- Github user tony810430 commented on the issue:

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160622372 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@ class

[jira] [Closed] (FLINK-8252) Convert network benchmarks to streaming benchmarks

2018-01-10 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-8252. -- Resolution: Fixed Fix Version/s: 1.5.0 Merged. 1.5.0: 544c9703d97668b8d4a952501756db52156ff2ef

[jira] [Commented] (FLINK-6892) Add L/RPAD supported in SQL

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319978#comment-16319978 ] ASF GitHub Bot commented on FLINK-6892: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6892) Add L/RPAD supported in SQL

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319977#comment-16319977 ] ASF GitHub Bot commented on FLINK-6892: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6892) Add L/RPAD supported in SQL

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319976#comment-16319976 ] ASF GitHub Bot commented on FLINK-6892: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6892) Add L/RPAD supported in SQL

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319975#comment-16319975 ] ASF GitHub Bot commented on FLINK-6892: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6892) Add L/RPAD supported in SQL

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319979#comment-16319979 ] ASF GitHub Bot commented on FLINK-6892: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8371) Buffers are not recycled in a non-spilled SpillableSubpartition upon release

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1631#comment-1631 ] ASF GitHub Bot commented on FLINK-8371: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #5276: [FLINK-8371][network] always recycle Buffers when ...

2018-01-10 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5276 [FLINK-8371][network] always recycle Buffers when releasing SpillableSubpartition ## What is the purpose of the change This is a rebase of #5261 for the release-1.4 branch. Please refer to

[jira] [Closed] (FLINK-8251) Add network (micro) benchmarks in Flink

2018-01-10 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-8251. -- Resolution: Fixed Fix Version/s: 1.5.0 > Add network (micro) benchmarks in Flink >

[jira] [Commented] (FLINK-6926) Add support for MD5, SHA1 and SHA2

2018-01-10 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320314#comment-16320314 ] Timo Walther commented on FLINK-6926: - [~micg] Thank you. I just gave you contributor permissions. You

[GitHub] flink pull request #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitte...

2018-01-10 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5200#discussion_r160692827 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java --- @@

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320328#comment-16320328 ] ASF GitHub Bot commented on FLINK-8234: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r160692953 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -956,23 +958,29 @@ private void jobStatusChanged(

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320326#comment-16320326 ] ASF GitHub Bot commented on FLINK-8234: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320363#comment-16320363 ] ASF GitHub Bot commented on FLINK-8332: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320361#comment-16320361 ] ASF GitHub Bot commented on FLINK-8332: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Assigned] (FLINK-6926) Add support for MD5, SHA1 and SHA2

2018-01-10 Thread Michael Gendelman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gendelman reassigned FLINK-6926: Assignee: Michael Gendelman > Add support for MD5, SHA1 and SHA2 >

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r160698812 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java --- @@ -77,23 +74,25 @@ public void

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320369#comment-16320369 ] ASF GitHub Bot commented on FLINK-8332: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320379#comment-16320379 ] ASF GitHub Bot commented on FLINK-8332: --- Github user GJL commented on a diff in the pull request:

[jira] [Created] (FLINK-8409) Race condition in KafkaConsumerThread leads to potential NPE

2018-01-10 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-8409: -- Summary: Race condition in KafkaConsumerThread leads to potential NPE Key: FLINK-8409 URL: https://issues.apache.org/jira/browse/FLINK-8409 Project:

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-10 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r160699710 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java --- @@ -128,13 +131,14 @@ public void

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-10 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160700659 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -150,16 +126,13 @@ */ private boolean

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r160704416 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java --- @@ -178,65 +185,30 @@ public void

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320411#comment-16320411 ] ASF GitHub Bot commented on FLINK-8332: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r160706043 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java --- @@ -178,65 +185,30 @@ public void

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320415#comment-16320415 ] ASF GitHub Bot commented on FLINK-8332: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320435#comment-16320435 ] ASF GitHub Bot commented on FLINK-8333: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r160710138 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -292,20 +267,14 @@ protected int run(String[] args) {

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2018-01-10 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r160687024 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala --- @@ -414,6 +414,34 @@ object

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320307#comment-16320307 ] ASF GitHub Bot commented on FLINK-8302: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320308#comment-16320308 ] ASF GitHub Bot commented on FLINK-8302: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2018-01-10 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r160687249 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala --- @@ -1216,6 +1216,74 @@ class

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r160692288 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -357,6 +360,31 @@ public void start() throws

[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320339#comment-16320339 ] ASF GitHub Bot commented on FLINK-8306: --- Github user pnowojski commented on the issue:

[GitHub] flink issue #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitter inter...

2018-01-10 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/5200 Regarding the race condition. I think we meant the same thing or maybe I misunderstood part of the code, but yes, this NPE seems like a possible outcome of this race condition. If you

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r160697769 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -659,128 +655,107 @@ protected int savepoint(String[] args) {

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r160697901 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -659,128 +655,107 @@ protected int savepoint(String[] args) {

[GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...

2018-01-10 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r160699235 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -660,7 +570,25 @@ public int run(

[GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...

2018-01-10 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r160699294 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -717,7 +645,26 @@ public int run(

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r160699257 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java --- @@ -149,23 +153,26 @@ public void

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r160699213 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java --- @@ -128,13 +131,14 @@ public void

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320373#comment-16320373 ] ASF GitHub Bot commented on FLINK-8332: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320387#comment-16320387 ] ASF GitHub Bot commented on FLINK-7511: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320404#comment-16320404 ] ASF GitHub Bot commented on FLINK-8332: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink issue #5219: [FLINK-8332] [flip6] Move savepoint dispose into ClusterC...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5219 Thanks for the review @GJL. I've addressed your comments. As soon as Travis gives green light, I'll merge this PR. ---

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r160709495 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -274,19 +251,13 @@ protected int run(String[] args) {

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r160711940 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -515,33 +464,28 @@ protected int stop(String[] args) {

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320717#comment-16320717 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160751897 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320744#comment-16320744 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160755282 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorage.java --- @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160756347 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorage.java --- @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320763#comment-16320763 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160759604 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java --- @@ -0,0 +1,265 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320776#comment-16320776 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160760708 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/AbstractFileStateBackend.java --- @@ -0,0 +1,224 @@ +/* + *

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320789#comment-16320789 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320816#comment-16320816 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on the issue:

[jira] [Updated] (FLINK-8405) Keyed State in broadcasted data steam.

2018-01-10 Thread Marek Barak (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marek Barak updated FLINK-8405: --- Description: Hi guys, I am trying to join 2 streams. Where the second stream is an codelist used by

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160752496 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointProperties.java --- @@ -251,77 +225,66 @@ public String toString()

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160752558 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -1185,6 +1153,10 @@ public int

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320723#comment-16320723 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320720#comment-16320720 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160754932 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/Checkpoints.java --- @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320757#comment-16320757 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160756970 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorage.java --- @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #5248: [FLINK-5823] [checkpoints] State backends now also...

2018-01-10 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160756860 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorage.java --- @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320756#comment-16320756 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)

2018-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320771#comment-16320771 ] ASF GitHub Bot commented on FLINK-5823: --- Github user StephanEwen commented on a diff in the pull

  1   2   3   4   >