[GitHub] [flink] dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274790557 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186)

2019-04-12 Thread GitBox
pnowojski commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186) URL: https://github.com/apache/flink/pull/7938#discussion_r274810924 ## File path:

[jira] [Commented] (FLINK-12152) Make the vcore that Application Master used configurable for Flink on YARN

2019-04-12 Thread Paul Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816103#comment-16816103 ] Paul Lin commented on FLINK-12152: -- [~yanghua] Would you mind clarifying further about under what

[jira] [Comment Edited] (FLINK-12152) Make the vcore that Application Master used configurable for Flink on YARN

2019-04-12 Thread Paul Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816103#comment-16816103 ] Paul Lin edited comment on FLINK-12152 at 4/12/19 9:00 AM: --- [~yanghua] Would

[jira] [Reopened] (FLINK-10941) Slots prematurely released which still contain unconsumed data

2019-04-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reopened FLINK-10941: --- Backport for 1.8.1 and 1.7.x still pending > Slots prematurely released which still contain

[jira] [Updated] (FLINK-10941) Slots prematurely released which still contain unconsumed data

2019-04-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-10941: -- Fix Version/s: 1.8.1 1.7.3 > Slots prematurely released which still

[GitHub] [flink] zhijiangW commented on issue #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-12 Thread GitBox
zhijiangW commented on issue #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#issuecomment-482500738 Thanks for merging and the kindly reminder. I would copy it to the commit next time. :)

[GitHub] [flink] dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274824516 ## File path:

[GitHub] [flink] zhijiangW commented on issue #8136: [FLINK-12154][network] Remove legacy fields for SingleInputGate

2019-04-12 Thread GitBox
zhijiangW commented on issue #8136: [FLINK-12154][network] Remove legacy fields for SingleInputGate URL: https://github.com/apache/flink/pull/8136#issuecomment-482503488 @pnowojski I already rebased the master. :) This is an

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274779381 ## File path:

[GitHub] [flink] klion26 commented on issue #8153: Update metrics.md

2019-04-12 Thread GitBox
klion26 commented on issue #8153: Update metrics.md URL: https://github.com/apache/flink/pull/8153#issuecomment-482466047 @kbohinski thank you for your contribution, could you please update the title of the pr. This is an

[GitHub] [flink] dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274788682 ## File path:

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274788310 ## File path:

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274798827 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186)

2019-04-12 Thread GitBox
azagrebin commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186) URL: https://github.com/apache/flink/pull/7938#discussion_r274806030 ## File path:

[jira] [Updated] (FLINK-12169) Improve Javadoc of MessageAcknowledgingSourceBase

2019-04-12 Thread Konstantin Knauf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Knauf updated FLINK-12169: - Component/s: Connectors/ RabbitMQ > Improve Javadoc of MessageAcknowledgingSourceBase >

[jira] [Comment Edited] (FLINK-11107) [state] Avoid memory stateBackend to create arbitrary folders under HA path when no checkpoint path configured

2019-04-12 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815949#comment-16815949 ] Yun Tang edited comment on FLINK-11107 at 4/12/19 8:43 AM: --- [~ykt836] This is

[GitHub] [flink] flinkbot commented on issue #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch

2019-04-12 Thread GitBox
flinkbot commented on issue #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch URL: https://github.com/apache/flink/pull/8156#issuecomment-482496189 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[jira] [Updated] (FLINK-12168) Support e2e limit, sortLimit, rank, union in blink batch

2019-04-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12168: --- Labels: pull-request-available (was: ) > Support e2e limit, sortLimit, rank, union in

[GitHub] [flink] pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem

2019-04-12 Thread GitBox
pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem URL: https://github.com/apache/flink/pull/8038#discussion_r274833288 ## File path:

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274780968 ## File path:

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274784128 ## File path: docs/dev/table/functions.md ## @@ -5800,3 +5800,284 @@ For Table API, please

[jira] [Created] (FLINK-12168) Support e2e limit, sortLimit, rank, union in blink batch

2019-04-12 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12168: Summary: Support e2e limit, sortLimit, rank, union in blink batch Key: FLINK-12168 URL: https://issues.apache.org/jira/browse/FLINK-12168 Project: Flink

[GitHub] [flink] yanghua commented on issue #7470: [FLINK-11283] Accessing the key when processing connected keyed stream

2019-04-12 Thread GitBox
yanghua commented on issue #7470: [FLINK-11283] Accessing the key when processing connected keyed stream URL: https://github.com/apache/flink/pull/7470#issuecomment-482475894 @aljoscha thanks for your review. I have done some refactor based on your suggestion.

[jira] [Created] (FLINK-12169) Improve Javadoc of MessageAcknowledgingSourceBase

2019-04-12 Thread Konstantin Knauf (JIRA)
Konstantin Knauf created FLINK-12169: Summary: Improve Javadoc of MessageAcknowledgingSourceBase Key: FLINK-12169 URL: https://issues.apache.org/jira/browse/FLINK-12169 Project: Flink

[GitHub] [flink] beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-12 Thread GitBox
beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r274812014 ## File path:

[GitHub] [flink] pnowojski merged pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186)

2019-04-12 Thread GitBox
pnowojski merged pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186) URL: https://github.com/apache/flink/pull/7938 This is an automated message from the Apache Git

[jira] [Updated] (FLINK-12170) Add support for generating optimized logical plan for Over aggregate

2019-04-12 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12170: --- Description: This issue aims to generate optimized plan for Over aggregate queries on both Batch

[jira] [Updated] (FLINK-12170) Add support for generating optimized logical plan for Over aggregate

2019-04-12 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12170: --- Description: This issue aims to generate optimized plan for Over aggregate queries on both Batch

[jira] [Updated] (FLINK-12170) Add support for generating optimized logical plan for Over aggregate

2019-04-12 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12170: --- Description: This issue aims to generate optimized plan for Over aggregate queries on both Batch

[GitHub] [flink] flinkbot commented on issue #8157: [FLINK-12170] [table-planner-blink] Add support for generating optimized logical plan for Over aggregate

2019-04-12 Thread GitBox
flinkbot commented on issue #8157: [FLINK-12170] [table-planner-blink] Add support for generating optimized logical plan for Over aggregate URL: https://github.com/apache/flink/pull/8157#issuecomment-482512574 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274792694 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274792694 ## File path:

[jira] [Commented] (FLINK-11619) Make ScheduleMode configurable via user code or configuration file

2019-04-12 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816047#comment-16816047 ] Ji Liu commented on FLINK-11619: [~yuqi] Thanks for replying. You mean you will continue to work on

[GitHub] [flink] dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274792694 ## File path:

[GitHub] [flink] Myasuka edited a comment on issue #7281: [FLINK-11107][state] Avoid memory stateBackend to create arbitrary folders under HA path when no checkpoint path configured

2019-04-12 Thread GitBox
Myasuka edited a comment on issue #7281: [FLINK-11107][state] Avoid memory stateBackend to create arbitrary folders under HA path when no checkpoint path configured URL: https://github.com/apache/flink/pull/7281#issuecomment-468532245 Since Flink-1.8 is about to release, @StephanEwen

[GitHub] [flink] azagrebin commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186)

2019-04-12 Thread GitBox
azagrebin commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186) URL: https://github.com/apache/flink/pull/7938#discussion_r274806030 ## File path:

[GitHub] [flink] JingsongLi opened a new pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch

2019-04-12 Thread GitBox
JingsongLi opened a new pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch URL: https://github.com/apache/flink/pull/8156 ## What is the purpose of the change Support limit and add limit it cases to blink batch. Support

[GitHub] [flink] sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-12 Thread GitBox
sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274742418 ## File path:

[jira] [Commented] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-12 Thread yankai zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816008#comment-16816008 ] yankai zhang commented on FLINK-12113: -- I'm not quite familiar with flink project development,

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274780674 ## File path:

[GitHub] [flink] sunhaibotb commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-12 Thread GitBox
sunhaibotb commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-482464445 The code has been updated. @StefanRRichter The performance regression is a concern. @pnowojski

[jira] [Updated] (FLINK-12168) Support e2e limit, sortLimit, rank, union in blink batch

2019-04-12 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-12168: - Component/s: Table SQL / Planner > Support e2e limit, sortLimit, rank, union in blink batch >

[GitHub] [flink] flinkbot commented on issue #8155: [FLINK-12169] [javadocs] improve javadoc of MessageAcknowledgingSource…

2019-04-12 Thread GitBox
flinkbot commented on issue #8155: [FLINK-12169] [javadocs] improve javadoc of MessageAcknowledgingSource… URL: https://github.com/apache/flink/pull/8155#issuecomment-482485664 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Updated] (FLINK-12169) Improve Javadoc of MessageAcknowledgingSourceBase

2019-04-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12169: --- Labels: pull-request-available (was: ) > Improve Javadoc of MessageAcknowledgingSourceBase

[GitHub] [flink] knaufk opened a new pull request #8155: [FLINK-12169] [javadoc] improve javadoc of MessageAcknowledgingSource…

2019-04-12 Thread GitBox
knaufk opened a new pull request #8155: [FLINK-12169] [javadoc] improve javadoc of MessageAcknowledgingSource… URL: https://github.com/apache/flink/pull/8155 ## What is the purpose of the change * Improve Javadocs of {{MessageAcknowledgngSourceBase}} ## Brief change log

[GitHub] [flink] pnowojski commented on issue #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-12 Thread GitBox
pnowojski commented on issue #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#issuecomment-482488114 One remark @zhijiangW, if you are already providing more detailed description of a change in the PR description,

[jira] [Closed] (FLINK-12067) Refactor the constructor of NetworkEnvironment

2019-04-12 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-12067. -- Resolution: Fixed Fix Version/s: 1.9.0 merged commit 352a995 into apache:master >

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-12 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816093#comment-16816093 ] vinoyang commented on FLINK-11935: -- [~walterddr] what do you think? > Remove DateTimeUtils pull-in and

[GitHub] [flink] zhuzhurk opened a new pull request #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly…

2019-04-12 Thread GitBox
zhuzhurk opened a new pull request #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly… URL: https://github.com/apache/flink/pull/8158 … on ExecutionVertex reset ## What is the purpose of the change *This pull request fixes

[GitHub] [flink] flinkbot commented on issue #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly…

2019-04-12 Thread GitBox
flinkbot commented on issue #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly… URL: https://github.com/apache/flink/pull/8158#issuecomment-482516088 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[jira] [Updated] (FLINK-12131) Resetting ExecutionVertex in region failover may cause inconsistency of IntermediateResult status

2019-04-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12131: --- Labels: pull-request-available (was: ) > Resetting ExecutionVertex in region failover may

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274774904 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-12 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274775151 ## File path:

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274779381 ## File path:

[jira] [Commented] (FLINK-11107) [state] Avoid memory stateBackend to create arbitrary folders under HA path when no checkpoint path configured

2019-04-12 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816041#comment-16816041 ] Kurt Young commented on FLINK-11107: Got it, thanks [~yunta], i think this should be fixed in 1.9.0

[GitHub] [flink] link3280 commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-04-12 Thread GitBox
link3280 commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#issuecomment-482476930 @tzulitai @zentol PTAL

[jira] [Closed] (FLINK-10941) Slots prematurely released which still contain unconsumed data

2019-04-12 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-10941. -- Resolution: Fixed Fix Version/s: 1.9.0 merged commit 264a0c9 into apache:master >

[jira] [Commented] (FLINK-10052) Tolerate temporarily suspended ZooKeeper connections

2019-04-12 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816118#comment-16816118 ] Xiaogang Shi commented on FLINK-10052: -- What's the status of the issue? [~Wosinsan]

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274780674 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274784319 ## File path:

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274784128 ## File path: docs/dev/table/functions.md ## @@ -5800,3 +5800,284 @@ For Table API, please

[GitHub] [flink] dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274801032 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274821607 ## File path:

[jira] [Created] (FLINK-12170) Add support for generating optimized logical plan for Over aggregate

2019-04-12 Thread godfrey he (JIRA)
godfrey he created FLINK-12170: -- Summary: Add support for generating optimized logical plan for Over aggregate Key: FLINK-12170 URL: https://issues.apache.org/jira/browse/FLINK-12170 Project: Flink

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-12 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r274844341 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-12 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r274846133 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-12 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r274851278 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-12 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r274848674 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-12 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r274849522 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-12 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r274847069 ## File path:

[GitHub] [flink] KurtYoung merged pull request #8120: [FLINK-12120][table-planner-blink] Support e2e SortAggregate and HashAggregate operator run in batch mode

2019-04-12 Thread GitBox
KurtYoung merged pull request #8120: [FLINK-12120][table-planner-blink] Support e2e SortAggregate and HashAggregate operator run in batch mode URL: https://github.com/apache/flink/pull/8120 This is an automated message from

[jira] [Closed] (FLINK-12120) Support e2e SortAggregate and HashAggregate operator run in batch mode

2019-04-12 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12120. -- Resolution: Fixed Fix Version/s: 1.9.0 fixed in 76841beb72eb095c3615653439effd43f3594a6f >

[GitHub] [flink] dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274789014 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274789014 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8148: [FLINK-12161] [table-planner-blink] Supports partial-final optimization for stream group aggregate

2019-04-12 Thread GitBox
KurtYoung commented on a change in pull request #8148: [FLINK-12161] [table-planner-blink] Supports partial-final optimization for stream group aggregate URL: https://github.com/apache/flink/pull/8148#discussion_r274784306 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8148: [FLINK-12161] [table-planner-blink] Supports partial-final optimization for stream group aggregate

2019-04-12 Thread GitBox
KurtYoung commented on a change in pull request #8148: [FLINK-12161] [table-planner-blink] Supports partial-final optimization for stream group aggregate URL: https://github.com/apache/flink/pull/8148#discussion_r274782226 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274792694 ## File path:

[GitHub] [flink] pnowojski merged pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-12 Thread GitBox
pnowojski merged pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] zhijiangW commented on issue #8136: [FLINK-12154][network] Remove legacy fields for SingleInputGate

2019-04-12 Thread GitBox
zhijiangW commented on issue #8136: [FLINK-12154][network] Remove legacy fields for SingleInputGate URL: https://github.com/apache/flink/pull/8136#issuecomment-482501474 Sure, I would solve it right now. This is an automated

[GitHub] [flink] dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274824516 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274831488 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274831488 ## File path:

[GitHub] [flink] godfreyhe opened a new pull request #8157: [FLINK-12170] [table-planner-blink] Add support for generating optimized logical plan for Over aggregate

2019-04-12 Thread GitBox
godfreyhe opened a new pull request #8157: [FLINK-12170] [table-planner-blink] Add support for generating optimized logical plan for Over aggregate URL: https://github.com/apache/flink/pull/8157 ## What is the purpose of the change *Add support for generating optimized logical

[jira] [Updated] (FLINK-12170) Add support for generating optimized logical plan for Over aggregate

2019-04-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12170: --- Labels: pull-request-available (was: ) > Add support for generating optimized logical plan

[GitHub] [flink] wuchong commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-12 Thread GitBox
wuchong commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#issuecomment-482454071 Hi @sunjincheng121 , @xuefuz , @bowenli86 Regarding to the `listTables()`, I'm fine with current

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-12 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274773927 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186)

2019-04-12 Thread GitBox
azagrebin commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186) URL: https://github.com/apache/flink/pull/7938#discussion_r274806030 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

2019-04-12 Thread GitBox
azagrebin commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService URL: https://github.com/apache/flink/pull/8133#discussion_r274914550 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

2019-04-12 Thread GitBox
azagrebin commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService URL: https://github.com/apache/flink/pull/8133#discussion_r274957657 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

2019-04-12 Thread GitBox
azagrebin commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService URL: https://github.com/apache/flink/pull/8133#discussion_r273917521 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-12 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r274975029 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-12 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r274974832 ## File path:

[jira] [Comment Edited] (FLINK-11813) Standby per job mode Dispatchers don't know job's JobSchedulingStatus

2019-04-12 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816558#comment-16816558 ] TisonKun edited comment on FLINK-11813 at 4/12/19 6:22 PM: --- Thanks for you

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-12 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r274962877 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-12 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r274965744 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-12 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r274967719 ## File path:

[GitHub] [flink] beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-12 Thread GitBox
beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r274981377 ## File path:

[jira] [Commented] (FLINK-11813) Standby per job mode Dispatchers don't know job's JobSchedulingStatus

2019-04-12 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816558#comment-16816558 ] TisonKun commented on FLINK-11813: -- Thanks for you clarification and explanation [~till.rohrmann]. I

[GitHub] [flink] wuchong commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-12 Thread GitBox
wuchong commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r274953377 ## File path:

  1   2   >