Re: [PR] [FLINK-33721][dist] Fix unsupported env.java.home in configuration file. [flink]

2024-01-25 Thread via GitHub
zhuzhurk commented on code in PR #24194: URL: https://github.com/apache/flink/pull/24194#discussion_r1466072601 ## flink-dist/src/main/flink-bin/bin/config-parser-utils.sh: ## @@ -23,6 +23,42 @@ if [ "$#" -lt 3 ]; then echo "$USAGE" exit 1 fi +

[jira] [Commented] (FLINK-34048) Support session window agg in table runtime instead of using legacy group window agg op

2024-01-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810771#comment-17810771 ] dalongliu commented on FLINK-34048: --- Merged in master: de7322112cbf594ae4b74163b5e58892e6cdf4ca >

[jira] [Resolved] (FLINK-34048) Support session window agg in table runtime instead of using legacy group window agg op

2024-01-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-34048. --- Fix Version/s: 1.19.0 Resolution: Fixed > Support session window agg in table runtime

[jira] [Assigned] (FLINK-34048) Support session window agg in table runtime instead of using legacy group window agg op

2024-01-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-34048: - Assignee: xuyang > Support session window agg in table runtime instead of using legacy group

Re: [PR] [FLINK-34122][core] Deprecate old serialization config methods and options [flink]

2024-01-25 Thread via GitHub
reswqa commented on code in PR #24193: URL: https://github.com/apache/flink/pull/24193#discussion_r1466089942 ## flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfig.java: ## @@ -185,16 +205,25 @@ public void registerPojoType(Class type) { *

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810799#comment-17810799 ] Matthias Pohl commented on FLINK-34206: --- I'm not able to pinpoint the cause of this test failure.

[jira] [Commented] (FLINK-34233) HybridShuffleITCase.testHybridSelectiveExchangesRestart failed due to a IllegalStateException

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810801#comment-17810801 ] Matthias Pohl commented on FLINK-34233: ---

[jira] [Closed] (FLINK-34218) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-34218. - Resolution: Duplicate I'm gonna close this issue in favor of FLINK-34200. There are two other

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810818#comment-17810818 ] Matthias Pohl commented on FLINK-34200: --- Copied over from FLINK-34218:

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810827#comment-17810827 ] Matthias Pohl commented on FLINK-28440: --- 1.18:

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810832#comment-17810832 ] Matthias Pohl commented on FLINK-22765: ---

Re: [PR] [FLINK-34117][bugfix][table] Fix CompactCoordinator data loss upon termination [flink]

2024-01-25 Thread via GitHub
flinkbot commented on PR #24195: URL: https://github.com/apache/flink/pull/24195#issuecomment-1910007779 ## CI report: * 8f961e6a303b035426ada6374c14cf952cebde27 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-25 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1466287619 ## .github/workflows/ci.yml: ## @@ -49,8 +50,18 @@ jobs: -Plicense-check \ | tee ${{ env.MVN_BUILD_OUTPUT_FILE }} + mvn

Re: [PR] [FLINK-34223][dist] Introduce a migration tool to transfer legacy config file to new config file. [flink]

2024-01-25 Thread via GitHub
JunRuiLee commented on PR #24185: URL: https://github.com/apache/flink/pull/24185#issuecomment-1910097113 Squashed this PR and rebased it onto https://github.com/apache/flink/pull/24194 to includes the latest fixes. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-34231][doc] fix typo in doc [flink]

2024-01-25 Thread via GitHub
luoyuxia merged PR #24192: URL: https://github.com/apache/flink/pull/24192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-34220) introduce buffer bundle for minibatch join

2024-01-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-34220. --- Assignee: Shuai Xu Resolution: Fixed > introduce buffer bundle for minibatch join >

[jira] [Assigned] (FLINK-34219) Introduce a new join operator to support minibatch

2024-01-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-34219: - Assignee: Shuai Xu > Introduce a new join operator to support minibatch >

[jira] [Assigned] (FLINK-32074) Support file merging across checkpoints

2024-01-25 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-32074: --- Assignee: Zakelly Lan (was: Han Yin) > Support file merging across checkpoints >

Re: [PR] [hotfix][docs] fix typo in classloading option in Debugging Classloading [flink]

2024-01-25 Thread via GitHub
slankka commented on PR #24037: URL: https://github.com/apache/flink/pull/24037#issuecomment-1909782465 https://issues.apache.org/jira/browse/FLINK-33997 Closed for duplicates. https://github.com/apache/flink/pull/24052 -- This is an automated message from the Apache Git

Re: [PR] [hotfix][docs] fix typo in classloading option in Debugging Classloading [flink]

2024-01-25 Thread via GitHub
slankka closed pull request #24037: [hotfix][docs] fix typo in classloading option in Debugging Classloading URL: https://github.com/apache/flink/pull/24037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810811#comment-17810811 ] Matthias Pohl commented on FLINK-34202: ---

[jira] [Comment Edited] (FLINK-26644) python StreamExecutionEnvironmentTests.test_generate_stream_graph_with_dependencies failed on azure

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810831#comment-17810831 ] Matthias Pohl edited comment on FLINK-26644 at 1/25/24 11:02 AM: - Twice

Re: [PR] [FLINK-34223][dist] Introduce a migration tool to transfer legacy config file to new config file. [flink]

2024-01-25 Thread via GitHub
zhuzhurk commented on code in PR #24185: URL: https://github.com/apache/flink/pull/24185#discussion_r1466215828 ## flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java: ## @@ -244,6 +244,21 @@ public static List parseStringFromCachedFiles(

Re: [PR] [FLINK-33577][dist] Change the default config file to config.yaml in flink-dist. [flink]

2024-01-25 Thread via GitHub
JunRuiLee commented on PR #24177: URL: https://github.com/apache/flink/pull/24177#issuecomment-1910014658 Thanks @HuangXingBo for reviews, I've updated this pr follow your comments, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-25 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1466288220 ## flink-shaded-asm-9/pom.xml: ## @@ -43,24 +43,28 @@ under the License. org.ow2.asm asm ${asm.version} +

[jira] [Updated] (FLINK-34234) Apply ShadeOptionalChecker for flink-shaded

2024-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34234: --- Labels: pull-request-available (was: ) > Apply ShadeOptionalChecker for flink-shaded >

Re: [PR] [FLINK-34055][table] Introduce a new annotation for named parameters [flink]

2024-01-25 Thread via GitHub
fsk119 merged PR #24106: URL: https://github.com/apache/flink/pull/24106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-25 Thread via GitHub
XComp commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1466310753 ## .github/workflows/ci.yml: ## @@ -49,8 +50,18 @@ jobs: -Plicense-check \ | tee ${{ env.MVN_BUILD_OUTPUT_FILE }} + mvn

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-25 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1909799398 @snuyanzin @libenchao I have squashed the commit. Thank you both for all your help and support on this. Are you OK to merge? -- This is an automated message from the

[jira] [Updated] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34206: -- Priority: Blocker (was: Critical) > CacheITCase.testRetryOnCorruptedClusterDataset(Path)

[jira] [Comment Edited] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810812#comment-17810812 ] Matthias Pohl edited comment on FLINK-34206 at 1/25/24 10:42 AM: - Same

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810812#comment-17810812 ] Matthias Pohl commented on FLINK-34206: ---

[jira] [Commented] (FLINK-26644) python StreamExecutionEnvironmentTests.test_generate_stream_graph_with_dependencies failed on azure

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810836#comment-17810836 ] Matthias Pohl commented on FLINK-26644: ---

Re: [PR] E2E for minibatch join [flink]

2024-01-25 Thread via GitHub
xishuaidelin commented on code in PR #24161: URL: https://github.com/apache/flink/pull/24161#discussion_r1466230805 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala: ## @@ -95,6 +105,18 @@ object JoinUtil { } }

Re: [PR] [FLINK-34100][table] Support session window table function without pulling up with window agg [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24162: URL: https://github.com/apache/flink/pull/24162#discussion_r1466230991 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecWindowTableFunction.java: ## @@ -103,4 +111,67 @@

Re: [PR] [FLINK-34223][dist] Introduce a migration tool to transfer legacy config file to new config file. [flink]

2024-01-25 Thread via GitHub
zhuzhurk commented on code in PR #24185: URL: https://github.com/apache/flink/pull/24185#discussion_r1466251588 ## flink-dist/src/main/flink-bin/bin/migrate-config-file.sh: ## @@ -0,0 +1,65 @@ +#!/usr/bin/env bash

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-25 Thread via GitHub
snuyanzin commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1910277677 yes, backport would make sense, i guess it could be cherry-picked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810805#comment-17810805 ] Matthias Pohl commented on FLINK-34206: ---

[jira] [Commented] (FLINK-26644) python StreamExecutionEnvironmentTests.test_generate_stream_graph_with_dependencies failed on azure

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810831#comment-17810831 ] Matthias Pohl commented on FLINK-26644: ---

Re: [PR] [FLINK-34100][table] Support session window table function without pulling up with window agg [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24162: URL: https://github.com/apache/flink/pull/24162#discussion_r1466223510 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/operator/WindowTableFunctionOperatorBase.java: ## @@ -91,28

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-25 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1909958760 > for future: it is better not to squash commits unless it was requested explicitely by reviewer. The reason is that since there is no tool in GitHub confirming that the set

Re: [PR] [FLINK-34100][table] Support session window table function without pulling up with window agg [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24162: URL: https://github.com/apache/flink/pull/24162#discussion_r1466235244 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/WindowAggOperatorBuilder.java: ## @@ -170,4 +202,17 @@

[jira] [Created] (FLINK-34235) Not using Optional as input arguments in QueryHintsResolver

2024-01-25 Thread xuyang (Jira)
xuyang created FLINK-34235: -- Summary: Not using Optional as input arguments in QueryHintsResolver Key: FLINK-34235 URL: https://issues.apache.org/jira/browse/FLINK-34235 Project: Flink Issue Type:

[jira] [Commented] (FLINK-21126) Reconsider FLINK_PROPERTIES

2024-01-25 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810859#comment-17810859 ] Junrui Li commented on FLINK-21126: --- After reviewing the considerations for deprecating the

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-25 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810860#comment-17810860 ] lincoln lee commented on FLINK-34206: - [~xiasun] Can you take a look at this? The stack trace seems

Re: [PR] [FLINK-34053][table-planner] Support state ttl hint for group aggregate [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24179: URL: https://github.com/apache/flink/pull/24179#discussion_r1466284522 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/QueryHintsResolver.java: ## @@ -83,21 +85,50 @@ final List

Re: [PR] [FLINK-34121][core] Introduce pipeline.force-kryo-avro to control whe… [flink]

2024-01-25 Thread via GitHub
X-czh commented on PR #24129: URL: https://github.com/apache/flink/pull/24129#issuecomment-1910213715 Thanks for the contribution. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig [flink]

2024-01-25 Thread via GitHub
reswqa commented on code in PR #24187: URL: https://github.com/apache/flink/pull/24187#discussion_r1466393637 ## flink-core/src/main/java/org/apache/flink/api/common/state/StateDescriptor.java: ## @@ -320,7 +320,10 @@ public void initializeSerializerUnlessSet(ExecutionConfig

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-25 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1910329090 > yes, backport would make sense, i guess it could be cherry-picked @snuyanzin once this pr is merged - I assume I raise a second pr against this issue, would you be ok

[jira] [Updated] (FLINK-34232) Config file unexpectedly lacks support for env.java.home

2024-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34232: --- Labels: pull-request-available (was: ) > Config file unexpectedly lacks support for

[jira] [Commented] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810802#comment-17810802 ] Matthias Pohl commented on FLINK-34115: --- 1.18 build that didn't include the fix, yet:

Re: [PR] [FLINK-34232][dist] Fix unsupported env.java.home in configuration file. [flink]

2024-01-25 Thread via GitHub
JunRuiLee commented on PR #24194: URL: https://github.com/apache/flink/pull/24194#issuecomment-1909862013 Thanks @zhuzhurk for reviews, I've updated this pr follow your comment, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Comment Edited] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809780#comment-17809780 ] Matthias Pohl edited comment on FLINK-34202 at 1/25/24 10:48 AM: - 1.18:

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810820#comment-17810820 ] Matthias Pohl commented on FLINK-34206: ---

[jira] [Comment Edited] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809774#comment-17809774 ] Matthias Pohl edited comment on FLINK-34202 at 1/25/24 10:48 AM: -

[jira] [Commented] (FLINK-34117) CompactCoordinator for table file sink loses data upon job termination

2024-01-25 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810848#comment-17810848 ] Alexander Fedulov commented on FLINK-34117: --- [~leonard] thanks! Here is the backport PR

Re: [PR] [FLINK-34223][dist] Introduce a migration tool to transfer legacy config file to new config file. [flink]

2024-01-25 Thread via GitHub
JunRuiLee commented on PR #24185: URL: https://github.com/apache/flink/pull/24185#issuecomment-1910041516 Thanks @zhuzhurk for reviews, I've updated this pr. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-34053][table-planner] Support state ttl hint for group aggregate [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24179: URL: https://github.com/apache/flink/pull/24179#discussion_r1466282357 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/hint/FlinkHints.java: ## @@ -52,10 +52,13 @@ public abstract class FlinkHints {

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-25 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810877#comment-17810877 ] Jufang He commented on FLINK-33856: --- [~martijnvisser] I tried to signup for

[jira] [Commented] (FLINK-34220) introduce buffer bundle for minibatch join

2024-01-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810773#comment-17810773 ] dalongliu commented on FLINK-34220: --- Merged in master: 1bf27c6362413709226cd5d6f3dc5ae9223cc37c >

[jira] [Updated] (FLINK-34222) Get minibatch join operator involved

2024-01-25 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-34222: - Description: Get minibatch join operator involved in which includes both plan and operator. Implement

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-25 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810783#comment-17810783 ] Jufang He commented on FLINK-33856: --- [~pnowojski] I wrote a draft of a flip, but found I didn't have

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810786#comment-17810786 ] Matthias Pohl commented on FLINK-34206: ---

[jira] [Reopened] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-34115: --- [~qingyue] Unfortunately, the following build is based on

Re: [PR] [FLINK-33668] Decoupling Shuffle network memory and job topology [flink]

2024-01-25 Thread via GitHub
jiangxin369 commented on code in PR #23851: URL: https://github.com/apache/flink/pull/23851#discussion_r1466154957 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java: ## @@ -335,19 +338,21 @@

[jira] [Commented] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810806#comment-17810806 ] Matthias Pohl commented on FLINK-33186: ---

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810819#comment-17810819 ] Matthias Pohl commented on FLINK-34202: ---

[jira] [Comment Edited] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810819#comment-17810819 ] Matthias Pohl edited comment on FLINK-34202 at 1/25/24 10:47 AM: - 1.17:

[jira] [Comment Edited] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810811#comment-17810811 ] Matthias Pohl edited comment on FLINK-34202 at 1/25/24 10:47 AM: -

[jira] [Updated] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34202: -- Affects Version/s: 1.19.0 > python tests take suspiciously long in some of the cases >

[jira] [Updated] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34202: -- Affects Version/s: 1.17.2 > python tests take suspiciously long in some of the cases >

Re: [PR] [FLINK-34145][connector/filesystem] support dynamic source parallelism inference in batch jobs [flink]

2024-01-25 Thread via GitHub
SinBex commented on PR #24186: URL: https://github.com/apache/flink/pull/24186#issuecomment-1909902429 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-33595) StreamDependencyTests.test_set_requirements_with_cached_directory failed with ModuleNotFoundError

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810826#comment-17810826 ] Matthias Pohl commented on FLINK-33595: ---

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-01-25 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1466256133 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusRemoteWriteHttpRequestBuilder.java: ## @@ -0,0 +1,70 @@ +/* + *

[jira] [Assigned] (FLINK-34055) Introduce a new annotation for named parameters

2024-01-25 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-34055: - Assignee: Feng Jin > Introduce a new annotation for named parameters >

[jira] [Updated] (FLINK-34234) Apply ShadeOptionalChecker for flink-shaded

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34234: -- Priority: Blocker (was: Major) > Apply ShadeOptionalChecker for flink-shaded >

[jira] [Commented] (FLINK-34055) Introduce a new annotation for named parameters

2024-01-25 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810863#comment-17810863 ] Shengkai Fang commented on FLINK-34055: --- Merged into master:

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-25 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1466289100 ## pom.xml: ## @@ -341,21 +342,41 @@ under the License. java + +

Re: [PR] [FLINK-34121][core] Introduce pipeline.force-kryo-avro to control whe… [flink]

2024-01-25 Thread via GitHub
reswqa commented on code in PR #24129: URL: https://github.com/apache/flink/pull/24129#discussion_r1466302040 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DataTypeFactoryImpl.java: ## @@ -141,6 +141,16 @@ private static Supplier

Re: [PR] [FLINK-34053][table-planner] Support state ttl hint for group aggregate [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24179: URL: https://github.com/apache/flink/pull/24179#discussion_r1466314159 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/hint/StateTtlHint.java: ## @@ -87,4 +91,28 @@ public static Map

Re: [PR] [FLINK-34053][table-planner] Support state ttl hint for group aggregate [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24179: URL: https://github.com/apache/flink/pull/24179#discussion_r1466324477 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalGlobalGroupAggregate.scala: ## @@ -123,6

[jira] [Assigned] (FLINK-34236) Evaluate strange unstable build after cleaning up CI machines

2024-01-25 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-34236: --- Assignee: Jeyhun Karimov > Evaluate strange unstable build after cleaning up CI machines >

[jira] [Closed] (FLINK-34209) Migrate FileSink to the new SinkV2 API

2024-01-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-34209. -- Fix Version/s: 1.19.0 Assignee: Peter Vary Resolution: Fixed merged to master

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-25 Thread via GitHub
lsyldliu closed pull request #24150: [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op URL: https://github.com/apache/flink/pull/24150 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Assigned] (FLINK-32080) Restoration of FileMergingSnapshotManager

2024-01-25 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-32080: --- Assignee: Jinzhong Li (was: Zakelly Lan) > Restoration of FileMergingSnapshotManager >

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810785#comment-17810785 ] Martijn Visser commented on FLINK-33856: [~hejufang001] What's your Confluence ID? I'll add you

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810784#comment-17810784 ] Matthias Pohl commented on FLINK-18476: ---

[jira] [Comment Edited] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810247#comment-17810247 ] Matthias Pohl edited comment on FLINK-33186 at 1/25/24 10:40 AM: - 1.18:

[jira] [Comment Edited] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810247#comment-17810247 ] Matthias Pohl edited comment on FLINK-33186 at 1/25/24 10:40 AM: - 1.18:

[jira] [Updated] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33186: -- Affects Version/s: 1.18.1 >

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810822#comment-17810822 ] Matthias Pohl commented on FLINK-31472: --- 1.18:

[jira] [Commented] (FLINK-34225) HybridShuffleITCase.testHybridSelectiveExchangesRestart failed due to NullPointerException

2024-01-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810828#comment-17810828 ] Matthias Pohl commented on FLINK-34225: ---

[jira] [Commented] (FLINK-34229) Duplicate entry in InnerClasses attribute in class file FusionStreamOperator

2024-01-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810847#comment-17810847 ] dalongliu commented on FLINK-34229: --- [~xiasun]Thanks for double-checking. [~FrankZou] Can you help to

[PR] [FLINK-34111][bugfix][table] Fix CompactCoordinator data loss upon termination [flink]

2024-01-25 Thread via GitHub
afedulov opened a new pull request, #24195: URL: https://github.com/apache/flink/pull/24195 `CompactCoordinator` accumulates data in `currentInputFiles` and only rolls them into `inputFiles` when `snapshotState()` gets called. At the same time it relies on separately receiving checkpoint

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-01-25 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1466268497 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkBuilder.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-34229) Duplicate entry in InnerClasses attribute in class file FusionStreamOperator

2024-01-25 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810856#comment-17810856 ] Zhu Zhu commented on FLINK-34229: - [~FrankZou] the query plan can be different between q35 of

[jira] [Created] (FLINK-34234) Apply ShadeOptionalChecker for flink-shaded

2024-01-25 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34234: --- Summary: Apply ShadeOptionalChecker for flink-shaded Key: FLINK-34234 URL: https://issues.apache.org/jira/browse/FLINK-34234 Project: Flink Issue

Re: [PR] [FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig [flink]

2024-01-25 Thread via GitHub
X-czh commented on code in PR #24187: URL: https://github.com/apache/flink/pull/24187#discussion_r1466307183 ## tools/ci/test_controller.sh: ## @@ -105,7 +105,7 @@ if [ $STAGE == $STAGE_PYTHON ]; then run_with_watchdog "./flink-python/dev/lint-python.sh"

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-25 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1466332128 ## pom.xml: ## @@ -341,21 +341,41 @@ under the License. java + +

Re: [PR] [FLINK-34053][table-planner] Support state ttl hint for group aggregate [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24179: URL: https://github.com/apache/flink/pull/24179#discussion_r1466362809 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/QueryHintsResolver.java: ## @@ -83,21 +85,50 @@ final List

  1   2   3   4   >