[GitHub] [hbase] Apache-HBase commented on pull request #2169: HBASE-24792 return value of LogRoller.walRollFinished may be wrong

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2169: URL: https://github.com/apache/hbase/pull/2169#issuecomment-708986710 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-15 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25189: -- Summary: [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level (was: [Metrics]

[jira] [Commented] (HBASE-25186) TestMasterRegionOnTwoFileSystems is failing after HBASE-25065

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214583#comment-17214583 ] Hudson commented on HBASE-25186: Results for branch master [build #95 on

[jira] [Commented] (HBASE-25117) ReplicationSourceShipper thread can not be finished

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214582#comment-17214582 ] Hudson commented on HBASE-25117: Results for branch master [build #95 on

[jira] [Commented] (HBASE-25065) WAL archival to be done by a separate thread

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214584#comment-17214584 ] Hudson commented on HBASE-25065: Results for branch master [build #95 on

[jira] [Commented] (HBASE-14067) bundle ruby files for hbase shell into a jar.

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214581#comment-17214581 ] Hudson commented on HBASE-14067: Results for branch master [build #95 on

[jira] [Updated] (HBASE-24792) return value of LogRoller.walRollFinished may be wrong

2020-10-15 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-24792: Summary: return value of LogRoller.walRollFinished may be wrong (was: LogRoller.walRollFinished

[jira] [Resolved] (HBASE-25177) Try create table with 100 regions for branch-2.2 nightly job's hadoop integration test

2020-10-15 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-25177. Resolution: Won't Fix > Try create table with 100 regions for branch-2.2 nightly job's

[GitHub] [hbase] Reidddddd commented on pull request #2194: HBASE-24849 Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-15 Thread GitBox
Reidd commented on pull request #2194: URL: https://github.com/apache/hbase/pull/2194#issuecomment-708997085 can use this SuppressWarnings, with value and justification. {code} edu.umd.cs.findbugs.annotations.SuppressWarnings( value="", justification="")

[GitHub] [hbase] Reidddddd commented on a change in pull request #2548: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics

2020-10-15 Thread GitBox
Reidd commented on a change in pull request #2548: URL: https://github.com/apache/hbase/pull/2548#discussion_r505360423 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java ## @@ -162,17 +162,6 @@ public void

[GitHub] [hbase] Reidddddd opened a new pull request #2548: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics

2020-10-15 Thread GitBox
Reidd opened a new pull request #2548: URL: https://github.com/apache/hbase/pull/2548 [HBASE-25189](https://issues.apache.org/jira/browse/HBASE-25189) This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] infraio closed pull request #2532: HBASE-25177 Try create table with 100 regions for branch-2.2 nightly …

2020-10-15 Thread GitBox
infraio closed pull request #2532: URL: https://github.com/apache/hbase/pull/2532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio commented on pull request #2532: HBASE-25177 Try create table with 100 regions for branch-2.2 nightly …

2020-10-15 Thread GitBox
infraio commented on pull request #2532: URL: https://github.com/apache/hbase/pull/2532#issuecomment-708958949 https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/95/ passed now. So not related to regions number. Close this.

[jira] [Commented] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214500#comment-17214500 ] Duo Zhang commented on HBASE-25183: --- {quote} Your favorite question... is there a write-up for this

[GitHub] [hbase] Apache-HBase commented on pull request #2135: HBASE-23285 LogCleaner should not delete empty oldWALs/rs directories…

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2135: URL: https://github.com/apache/hbase/pull/2135#issuecomment-708994052 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2169: HBASE-24792 return value of LogRoller.walRollFinished may be wrong

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2169: URL: https://github.com/apache/hbase/pull/2169#issuecomment-709073615 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio commented on a change in pull request #2546: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-10-15 Thread GitBox
infraio commented on a change in pull request #2546: URL: https://github.com/apache/hbase/pull/2546#discussion_r505196724 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -712,8 +707,14 @@ public void

[GitHub] [hbase] Reidddddd commented on pull request #2194: HBASE-24849 Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-15 Thread GitBox
Reidd commented on pull request #2194: URL: https://github.com/apache/hbase/pull/2194#issuecomment-708952307 Let's wait for QA This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (HBASE-23935) Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1

2020-10-15 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23935: - Description: (was: Backport Online Slow Response Log to branch-1.) > Backport

[GitHub] [hbase] Apache9 commented on pull request #2169: HBASE-24792 return value of LogRoller.walRollFinished may be wrong

2020-10-15 Thread GitBox
Apache9 commented on pull request #2169: URL: https://github.com/apache/hbase/pull/2169#issuecomment-709047762 OK, so the problem here is that, walRollFinished returns true but the roll has not been finished yet? Maybe we need to define the exact semantic of this method first...

[jira] [Updated] (HBASE-24792) Return value of LogRoller.walRollFinished may be wrong

2020-10-15 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-24792: Summary: Return value of LogRoller.walRollFinished may be wrong (was: return value of

[jira] [Updated] (HBASE-24792) return value of LogRoller.walRollFinished may be wrong

2020-10-15 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-24792: Summary: return value of LogRoller.walRollFinished may be wrong (was: Return value of

[jira] [Commented] (HBASE-23935) Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1

2020-10-15 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214515#comment-17214515 ] Viraj Jasani commented on HBASE-23935: -- [~apurtell] Could you please take a look? Addressed your

[jira] [Assigned] (HBASE-24745) 'Failed report transition' logs too often

2020-10-15 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 reassigned HBASE-24745: --- Assignee: (was: wenfeiyi666) > 'Failed report transition' logs too often >

[GitHub] [hbase] Apache-HBase commented on pull request #2158: HBASE-24769 Auto scale RSGroup

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2158: URL: https://github.com/apache/hbase/pull/2158#issuecomment-708964544 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2158: HBASE-24769 Auto scale RSGroup

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2158: URL: https://github.com/apache/hbase/pull/2158#issuecomment-708964369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2233: HBASE-24842 make export snapshot report size can be config

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2233: URL: https://github.com/apache/hbase/pull/2233#issuecomment-708981865 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2233: HBASE-24842 make export snapshot report size can be config

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2233: URL: https://github.com/apache/hbase/pull/2233#issuecomment-708981276 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics

2020-10-15 Thread Reid Chan (Jira)
Reid Chan created HBASE-25189: - Summary: [Metrics] Add checkAndPut and checkAndDelete latency metrics Key: HBASE-25189 URL: https://issues.apache.org/jira/browse/HBASE-25189 Project: HBase

[GitHub] [hbase] Reidddddd opened a new pull request #2549: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-15 Thread GitBox
Reidd opened a new pull request #2549: URL: https://github.com/apache/hbase/pull/2549 https://issues.apache.org/jira/browse/HBASE-25189 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Reidddddd edited a comment on pull request #2194: HBASE-24849 Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-15 Thread GitBox
Reidd edited a comment on pull request #2194: URL: https://github.com/apache/hbase/pull/2194#issuecomment-708997085 can use this SuppressWarnings, with value and justification. ``` edu.umd.cs.findbugs.annotations.SuppressWarnings( value="", justification="")

[GitHub] [hbase] Apache-HBase commented on pull request #2548: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2548: URL: https://github.com/apache/hbase/pull/2548#issuecomment-709335300 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2549: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2549: URL: https://github.com/apache/hbase/pull/2549#issuecomment-709321575 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ramkrish86 opened a new pull request #2550: HBASE-25187 Improve SizeCachedKV variants initialization

2020-10-15 Thread GitBox
ramkrish86 opened a new pull request #2550: URL: https://github.com/apache/hbase/pull/2550 Patch for just review. I have currently created it against hbase-2.2. I will later prepare a patch for master. @anoopsjohn

[GitHub] [hbase] Apache-HBase commented on pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #251: URL: https://github.com/apache/hbase/pull/251#issuecomment-709209554 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s

[GitHub] [hbase] Apache-HBase commented on pull request #2550: HBASE-25187 Improve SizeCachedKV variants initialization

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2550: URL: https://github.com/apache/hbase/pull/2550#issuecomment-709307038 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache9 commented on a change in pull request #2522: HBASE-25215 Create a ReplicationEndPoint for meta/root replica replic…

2020-10-15 Thread GitBox
Apache9 commented on a change in pull request #2522: URL: https://github.com/apache/hbase/pull/2522#discussion_r505536165 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java ## @@ -40,6 +39,10 @@ private static final

[GitHub] [hbase] Apache9 commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-15 Thread GitBox
Apache9 commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-709353266 Oh I checked the exceptions under the exceptions package, there are IA.Public and also IA.Private. So let's keep it as IA.Private for now. Anyway, it should not be

[jira] [Commented] (HBASE-25117) ReplicationSourceShipper thread can not be finished

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214599#comment-17214599 ] Hudson commented on HBASE-25117: Results for branch branch-2 [build #77 on

[jira] [Commented] (HBASE-25186) TestMasterRegionOnTwoFileSystems is failing after HBASE-25065

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214600#comment-17214600 ] Hudson commented on HBASE-25186: Results for branch branch-2 [build #77 on

[jira] [Commented] (HBASE-11686) Shell code should create a binding / irb workspace instead of polluting the root namespace

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214594#comment-17214594 ] Hudson commented on HBASE-11686: Results for branch branch-2 [build #77 on

[jira] [Commented] (HBASE-24806) Small Updates to Functionality of Shell IRB Workspace

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214595#comment-17214595 ] Hudson commented on HBASE-24806: Results for branch branch-2 [build #77 on

[jira] [Commented] (HBASE-24877) Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214598#comment-17214598 ] Hudson commented on HBASE-24877: Results for branch branch-2 [build #77 on

[jira] [Commented] (HBASE-14067) bundle ruby files for hbase shell into a jar.

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214597#comment-17214597 ] Hudson commented on HBASE-14067: Results for branch branch-2 [build #77 on

[GitHub] [hbase] Apache-HBase commented on pull request #2549: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2549: URL: https://github.com/apache/hbase/pull/2549#issuecomment-709278767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2549: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2549: URL: https://github.com/apache/hbase/pull/2549#issuecomment-709110527 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-25093) the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214593#comment-17214593 ] Hudson commented on HBASE-25093: Results for branch branch-2 [build #77 on

[jira] [Commented] (HBASE-25065) WAL archival to be done by a separate thread

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214601#comment-17214601 ] Hudson commented on HBASE-25065: Results for branch branch-2 [build #77 on

[jira] [Commented] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214596#comment-17214596 ] Hudson commented on HBASE-24875: Results for branch branch-2 [build #77 on

[GitHub] [hbase] Apache-HBase commented on pull request #2549: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2549: URL: https://github.com/apache/hbase/pull/2549#issuecomment-709285006 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2169: HBASE-24792 return value of LogRoller.walRollFinished may be wrong

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2169: URL: https://github.com/apache/hbase/pull/2169#issuecomment-709292931 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24628) Region normalizer now respects a rate limit

2020-10-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214725#comment-17214725 ] Duo Zhang commented on HBASE-24628: --- Let's keep this issue open for a while to see if the flaky board

[GitHub] [hbase] Apache-HBase commented on pull request #2169: HBASE-24792 return value of LogRoller.walRollFinished may be wrong

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2169: URL: https://github.com/apache/hbase/pull/2169#issuecomment-709355568 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ramkrish86 commented on pull request #2550: HBASE-25187 Improve SizeCachedKV variants initialization

2020-10-15 Thread GitBox
ramkrish86 commented on pull request #2550: URL: https://github.com/apache/hbase/pull/2550#issuecomment-709203316 Just targetting SizedCached KV variants. We can use this in rowindexV1 also even for getting the rowLen. But I did not change them. Just for review.

[GitHub] [hbase] Apache-HBase commented on pull request #2194: HBASE-24849 Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2194: URL: https://github.com/apache/hbase/pull/2194#issuecomment-709274667 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache9 merged pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-15 Thread GitBox
Apache9 merged pull request #2540: URL: https://github.com/apache/hbase/pull/2540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

2020-10-15 Thread GitBox
Apache9 commented on pull request #2540: URL: https://github.com/apache/hbase/pull/2540#issuecomment-709346862 Yes, the initialization order of HMaster is just a mess, too many dependencies... I like that you want to keep align with the current design of how to schedule chores. It

[GitHub] [hbase] Apache-HBase commented on pull request #2551: [HBASE-25179] Fix Assert format in HFilePerformanceEvaluation class.

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2551: URL: https://github.com/apache/hbase/pull/2551#issuecomment-709396451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25118) Extend Cell Tags to Delete object.

2020-10-15 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214783#comment-17214783 ] Rushabh Shah commented on HBASE-25118: -- Asked this question in dev mailing list. Copying the

[jira] [Commented] (HBASE-25117) ReplicationSourceShipper thread can not be finished

2020-10-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214838#comment-17214838 ] Hudson commented on HBASE-25117: Results for branch branch-2.3 [build #83 on

[GitHub] [hbase] shahrs87 opened a new pull request #2551: [HBASE-25179] Fix Assert format in HFilePerformanceEvaluation class.

2020-10-15 Thread GitBox
shahrs87 opened a new pull request #2551: URL: https://github.com/apache/hbase/pull/2551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] nyl3532016 commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-15 Thread GitBox
nyl3532016 commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-709418629 Yes, let me collect the exception which can change from IA.Public to IA.Private? And I find some exceptions(in hbase-client module) are not in

[GitHub] [hbase] nyl3532016 edited a comment on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-15 Thread GitBox
nyl3532016 edited a comment on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-709418629 @Apache9 Yes, let me collect the exception which can change from IA.Public to IA.Private? And I find some exceptions(in hbase-client module) are not in

[GitHub] [hbase] Apache-HBase commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-709416621 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2549: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2549: URL: https://github.com/apache/hbase/pull/2549#issuecomment-709445241 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Work started] (HBASE-25179) Assert format is incorrect in HFilePerformanceEvaluation class.

2020-10-15 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25179 started by Rushabh Shah. > Assert format is incorrect in HFilePerformanceEvaluation class. >

[jira] [Updated] (HBASE-25118) Extend Cell Tags to Delete object.

2020-10-15 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25118: - Description: We want to track the source of mutations (especially Deletes) via Phoenix. We

[jira] [Commented] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-15 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214870#comment-17214870 ] Andrew Kyle Purtell commented on HBASE-25183: - bq. I think I've already tried my best to

[jira] [Comment Edited] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-15 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214880#comment-17214880 ] Andrew Kyle Purtell edited comment on HBASE-25183 at 10/15/20, 6:08 PM:

[GitHub] [hbase] shahrs87 commented on pull request #2551: [HBASE-25179] Fix Assert format in HFilePerformanceEvaluation class.

2020-10-15 Thread GitBox
shahrs87 commented on pull request #2551: URL: https://github.com/apache/hbase/pull/2551#issuecomment-709510408 @virajjasani could you please help review this PR ? Thank you ! This is an automated message from the Apache

[GitHub] [hbase] saintstack commented on pull request #2547: HBASE-25185 Remove the usage of MetaTableAccessor in hbase-balancer

2020-10-15 Thread GitBox
saintstack commented on pull request #2547: URL: https://github.com/apache/hbase/pull/2547#issuecomment-709568010 > What is the scope of the new hbase-tool module? We want to move all the classes under the tool package in hbase-server to this module in the future? Thanks for asking.

[GitHub] [hbase] Apache-HBase commented on pull request #2551: [HBASE-25179] Fix Assert format in HFilePerformanceEvaluation class.

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2551: URL: https://github.com/apache/hbase/pull/2551#issuecomment-709478303 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-15 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214880#comment-17214880 ] Andrew Kyle Purtell commented on HBASE-25183: - I am supportive of the high level idea of

[GitHub] [hbase] Apache-HBase commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-709492700 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2551: [HBASE-25179] Fix Assert format in HFilePerformanceEvaluation class.

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2551: URL: https://github.com/apache/hbase/pull/2551#issuecomment-709509623 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-15 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214955#comment-17214955 ] Michael Stack commented on HBASE-25183: --- (Ignoring comments on lack of 'respect' and accusations

[jira] [Created] (HBASE-25190) Create an hbase-tool module and move here standalone tools bundled with core

2020-10-15 Thread Michael Stack (Jira)
Michael Stack created HBASE-25190: - Summary: Create an hbase-tool module and move here standalone tools bundled with core Key: HBASE-25190 URL: https://issues.apache.org/jira/browse/HBASE-25190

[GitHub] [hbase] saintstack edited a comment on pull request #2547: HBASE-25185 Remove the usage of MetaTableAccessor in hbase-balancer

2020-10-15 Thread GitBox
saintstack edited a comment on pull request #2547: URL: https://github.com/apache/hbase/pull/2547#issuecomment-709568010 > What is the scope of the new hbase-tool module? We want to move all the classes under the tool package in hbase-server to this module in the future? Thanks for

[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica

2020-10-15 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215031#comment-17215031 ] Michael Stack commented on HBASE-18070: --- Just set this to fix version 2.4.0. I set the priority

[jira] [Updated] (HBASE-18070) Enable memstore replication for meta replica

2020-10-15 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-18070: -- Priority: Critical (was: Major) > Enable memstore replication for meta replica >

[jira] [Commented] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215079#comment-17215079 ] Duo Zhang commented on HBASE-25183: --- [~apurtell] I’ve been harassed privately on slack about the

[jira] [Comment Edited] (HBASE-25183) Move more balancer related classes to hbase-balancer

2020-10-15 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214955#comment-17214955 ] Michael Stack edited comment on HBASE-25183 at 10/15/20, 8:56 PM: --

[jira] [Commented] (HBASE-25190) Create an hbase-tool module and move here standalone tools bundled with core

2020-10-15 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215052#comment-17215052 ] Michael Stack commented on HBASE-25190: --- Poking around, other candidates easy to move:  * Bulk

[GitHub] [hbase] saintstack opened a new pull request #2552: HBASE-25190 Create an hbase-tool module and move here standalone tool…

2020-10-15 Thread GitBox
saintstack opened a new pull request #2552: URL: https://github.com/apache/hbase/pull/2552 …s bundled with core Creates new hbase-tool module that depends on hbase-server. Moves the preupgrade validator tool here from hbase-server.

[GitHub] [hbase] Apache-HBase commented on pull request #2552: HBASE-25190 Create an hbase-tool module and move here standalone tool…

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2552: URL: https://github.com/apache/hbase/pull/2552#issuecomment-709622689 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-709774402 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Reidddddd commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1

2020-10-15 Thread GitBox
Reidd commented on a change in pull request #2312: URL: https://github.com/apache/hbase/pull/2312#discussion_r506055382 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java ## @@ -0,0 +1,154 @@ +/* + * + * Licensed to the

[GitHub] [hbase] Reidddddd commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1

2020-10-15 Thread GitBox
Reidd commented on a change in pull request #2312: URL: https://github.com/apache/hbase/pull/2312#discussion_r506057237 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1401,6 +1401,22 @@ */ public static final int

[GitHub] [hbase] Reidddddd commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1

2020-10-15 Thread GitBox
Reidd commented on a change in pull request #2312: URL: https://github.com/apache/hbase/pull/2312#discussion_r506056833 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java ## @@ -0,0 +1,154 @@ +/* + * + * Licensed to the

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2020-10-15 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215197#comment-17215197 ] Sandeep Guggilam commented on HBASE-25032: -- Sure [~apurtell] . I am currently working on

[jira] [Updated] (HBASE-25191) JVMMetrics tag.processName regression between hbase-1.3 and hbase-2.x+ versions

2020-10-15 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-25191: --- Summary: JVMMetrics tag.processName regression between hbase-1.3 and

[jira] [Created] (HBASE-25191) JVMMetrics tag.processName regression between hbase1.3 and hbase-2+ versions

2020-10-15 Thread ramkrishna.s.vasudevan (Jira)
ramkrishna.s.vasudevan created HBASE-25191: -- Summary: JVMMetrics tag.processName regression between hbase1.3 and hbase-2+ versions Key: HBASE-25191 URL: https://issues.apache.org/jira/browse/HBASE-25191

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-709739452 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase commented on pull request #2552: HBASE-25190 Create an hbase-tool module and move here standalone tool…

2020-10-15 Thread GitBox
Apache-HBase commented on pull request #2552: URL: https://github.com/apache/hbase/pull/2552#issuecomment-709739838 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Reidddddd commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1

2020-10-15 Thread GitBox
Reidd commented on a change in pull request #2312: URL: https://github.com/apache/hbase/pull/2312#discussion_r506056833 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java ## @@ -0,0 +1,154 @@ +/* + * + * Licensed to the

[jira] [Commented] (HBASE-25130) Masters in-memory serverHoldings map is not cleared during hbck repair

2020-10-15 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215200#comment-17215200 ] Sandeep Guggilam commented on HBASE-25130: -- [~apurtell] Didn't get time to go over the full

[jira] [Assigned] (HBASE-25130) Masters in-memory serverHoldings map is not cleared during hbck repair

2020-10-15 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Guggilam reassigned HBASE-25130: Assignee: (was: Sandeep Guggilam) > Masters in-memory serverHoldings map is

[jira] [Updated] (HBASE-25191) JVMMetrics tag.processName regression between hbase-1.3 and hbase-2.x+ versions

2020-10-15 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-25191: --- Affects Version/s: (was: 2.0.1) 2.0.0 > JVMMetrics

[jira] [Commented] (HBASE-25191) JVMMetrics tag.processName regression between hbase-1.3 and hbase-2.x+ versions

2020-10-15 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215204#comment-17215204 ] ramkrishna.s.vasudevan commented on HBASE-25191: I think now even if we fix the

[jira] [Assigned] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2020-10-15 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Guggilam reassigned HBASE-24972: Assignee: (was: Sandeep Guggilam) > Wait for connection attempt to succeed

  1   2   >