[GitHub] [kafka] bob-barrett opened a new pull request #9302: KAFKA-10149: Allow auto preferred leader election when partitions are reassigning

2020-09-17 Thread GitBox
bob-barrett opened a new pull request #9302: URL: https://github.com/apache/kafka/pull/9302 This patch removes the check for reassigning partitions when determining whether to trigger automatic leader election. This check can cause problems during long-running reassignments because a

[GitHub] [kafka] abbccdda commented on a change in pull request #8725: KAFKA-9608: Transaction Event Simulation Test

2020-09-17 Thread GitBox
abbccdda commented on a change in pull request #8725: URL: https://github.com/apache/kafka/pull/8725#discussion_r490713327 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionSimulationCoordinator.java ## @@ -0,0 +1,316 @@ +/* + *

[GitHub] [kafka] ijuma commented on pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed

2020-09-17 Thread GitBox
ijuma commented on pull request #9218: URL: https://github.com/apache/kafka/pull/9218#issuecomment-694648140 Can you please rebase so that we get the new CI running? This is an automated message from the Apache Git Service.

[GitHub] [kafka] ijuma commented on a change in pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
ijuma commented on a change in pull request #9294: URL: https://github.com/apache/kafka/pull/9294#discussion_r490699517 ## File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java ## @@ -273,22 +273,21 @@ public void

[GitHub] [kafka] ijuma commented on pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
ijuma commented on pull request #9294: URL: https://github.com/apache/kafka/pull/9294#issuecomment-694647346 Have we cherry picked this to older branches? It seems like they will be broken otherwise. This is an automated

[jira] [Resolved] (KAFKA-10495) Fix spelling mistake

2020-09-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 欧阳能达 resolved KAFKA-10495. -- Resolution: Won't Fix > Fix spelling mistake > > > Key: KAFKA-10495 >

[jira] [Commented] (KAFKA-10495) Fix spelling mistake

2020-09-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198095#comment-17198095 ] 欧阳能达 commented on KAFKA-10495: -- [~showuon] you are right! > Fix spelling mistake > >

[GitHub] [kafka] ouyangnengda closed pull request #9297: KAFKA-10495:Fix spelling mistake

2020-09-17 Thread GitBox
ouyangnengda closed pull request #9297: URL: https://github.com/apache/kafka/pull/9297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] showuon opened a new pull request #9301: KAFKA-10482: fix initialConnectionCount variable race condition issue

2020-09-17 Thread GitBox
showuon opened a new pull request #9301: URL: https://github.com/apache/kafka/pull/9301 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] showuon commented on pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-17 Thread GitBox
showuon commented on pull request #9202: URL: https://github.com/apache/kafka/pull/9202#issuecomment-694592201 Merge the latest trunk so that the flaky tests (addressed in https://github.com/apache/kafka/pull/9294) can be fixed.

[GitHub] [kafka] hachikuji commented on a change in pull request #8725: KAFKA-9608: Transaction Event Simulation Test

2020-09-17 Thread GitBox
hachikuji commented on a change in pull request #8725: URL: https://github.com/apache/kafka/pull/8725#discussion_r490627471 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionEventSimulationTest.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [kafka] hachikuji commented on a change in pull request #9300: KAFKA-10491: Check authorizations first in KafkaApis

2020-09-17 Thread GitBox
hachikuji commented on a change in pull request #9300: URL: https://github.com/apache/kafka/pull/9300#discussion_r490604721 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1732,45 +1732,57 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490594335 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -618,9 +682,9 @@ class Partition(val topicPartition: TopicPartition, // since

[GitHub] [kafka] hachikuji commented on a change in pull request #9299: MINOR: Use `Map.foreachKv` to avoid tuple allocation in Scala 2.13

2020-09-17 Thread GitBox
hachikuji commented on a change in pull request #9299: URL: https://github.com/apache/kafka/pull/9299#discussion_r490586608 ## File path: core/src/main/scala/kafka/utils/Implicits.scala ## @@ -46,4 +47,21 @@ object Implicits { } + /** + * Exposes `foreachKv` which

[GitHub] [kafka] hachikuji merged pull request #9279: MINOR: Fix common struct `JsonConverter` and `Schema` generation

2020-09-17 Thread GitBox
hachikuji merged pull request #9279: URL: https://github.com/apache/kafka/pull/9279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe commented on pull request #9279: MINOR: Fix common struct `JsonConverter` and `Schema` generation

2020-09-17 Thread GitBox
cmccabe commented on pull request #9279: URL: https://github.com/apache/kafka/pull/9279#issuecomment-694510055 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] hachikuji commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-17 Thread GitBox
hachikuji commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-694503921 @chia7712 Can you take a look at DynamicConnectionsQuotaTest? Looks like this patch is causing it to fail.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490562630 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -920,7 +986,7 @@ class Partition(val topicPartition: TopicPartition, * is

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490561028 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -920,7 +986,7 @@ class Partition(val topicPartition: TopicPartition, * is

[GitHub] [kafka] mumrah commented on pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
mumrah commented on pull request #9294: URL: https://github.com/apache/kafka/pull/9294#issuecomment-694490391 Thanks for the patch @jolshan! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mumrah merged pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
mumrah merged pull request #9294: URL: https://github.com/apache/kafka/pull/9294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490530496 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1763,6 +1768,143 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490542749 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -200,9 +241,11 @@ class Partition(val topicPartition: TopicPartition, // defined

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490527627 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1246,6 +1364,50 @@ class Partition(val topicPartition: TopicPartition, } }

[jira] [Created] (KAFKA-10499) 4 Unit Tests are breaking after addition of a new A record to "apache.org"

2020-09-17 Thread Prateek Agarwal (Jira)
Prateek Agarwal created KAFKA-10499: --- Summary: 4 Unit Tests are breaking after addition of a new A record to "apache.org" Key: KAFKA-10499 URL: https://issues.apache.org/jira/browse/KAFKA-10499

[GitHub] [kafka] abbccdda commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-17 Thread GitBox
abbccdda commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r490509357 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -2496,46 +2501,81 @@ public void

[GitHub] [kafka] abbccdda commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-17 Thread GitBox
abbccdda commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r490507674 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -2496,46 +2501,81 @@ public void

[GitHub] [kafka] abbccdda commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-17 Thread GitBox
abbccdda commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r490506434 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3732,41 +3734,43 @@ public void testListOffsets()

[GitHub] [kafka] abbccdda commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-17 Thread GitBox
abbccdda commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r490504884 ## File path: clients/src/main/resources/common/message/ListOffsetResponse.json ## @@ -48,7 +48,7 @@ "about": "The timestamp associated with

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490464756 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -157,6 +158,44 @@ case class OngoingReassignmentState(addingReplicas: Seq[Int],

[GitHub] [kafka] abbccdda commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-17 Thread GitBox
abbccdda commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-694430943 @mimaison Sorry was on the vacation, will take another look. This is an automated message from the Apache Git

[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-09-17 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-694425788 @omkreddy I fixed a failing test. The rest look unrelated. Could you trigger the build again please? This is

[GitHub] [kafka] jolshan commented on a change in pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
jolshan commented on a change in pull request #9294: URL: https://github.com/apache/kafka/pull/9294#discussion_r490461933 ## File path: clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java ## @@ -102,20 +102,20 @@ public void testResolveUnknownHostException()

[GitHub] [kafka] dajac commented on pull request #8897: MINOR; Use the automated protocol for the Consumer Protocol's subscriptions and assignments

2020-09-17 Thread GitBox
dajac commented on pull request #8897: URL: https://github.com/apache/kafka/pull/8897#issuecomment-694410433 @hachikuji @chia7712 FYI This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-10497) Convert group/transaction coordinator metadata schemas to use generated protocol

2020-09-17 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197885#comment-17197885 ] David Jacot commented on KAFKA-10497: - [~hachikuji] [~chia7712] FYI > Convert group/transaction

[jira] [Commented] (KAFKA-10497) Convert group/transaction coordinator metadata schemas to use generated protocol

2020-09-17 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197881#comment-17197881 ] David Jacot commented on KAFKA-10497: - I already have a PR for the consumer protocol part:

[GitHub] [kafka] dongjinleekr commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-17 Thread GitBox
dongjinleekr commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r490449947 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -910,6 +903,11 @@ class DynamicListenerConfig(server: KafkaServer)

[GitHub] [kafka] rondagostino opened a new pull request #9300: KAFKA-10491: Check authorizations first in KafkaApis

2020-09-17 Thread GitBox
rondagostino opened a new pull request #9300: URL: https://github.com/apache/kafka/pull/9300 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Updated] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2020-09-17 Thread Pedro Gontijo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pedro Gontijo updated KAFKA-10493: -- Affects Version/s: (was: 2.3.0) > Ktable out-of-order updates are not being ignored >

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-17 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-694377628 @dongjinleekr done. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jolshan commented on a change in pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
jolshan commented on a change in pull request #9294: URL: https://github.com/apache/kafka/pull/9294#discussion_r490423860 ## File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java ## @@ -273,22 +273,21 @@ public void

[GitHub] [kafka] mumrah commented on a change in pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
mumrah commented on a change in pull request #9294: URL: https://github.com/apache/kafka/pull/9294#discussion_r490417685 ## File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java ## @@ -273,22 +273,21 @@ public void

[jira] [Created] (KAFKA-10498) Consumer should do offset/epoch validation through `Fetch` when possible

2020-09-17 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10498: --- Summary: Consumer should do offset/epoch validation through `Fetch` when possible Key: KAFKA-10498 URL: https://issues.apache.org/jira/browse/KAFKA-10498

[jira] [Assigned] (KAFKA-10283) Consolidate client-level and consumer-level assignment within ClientState

2020-09-17 Thread highluck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] highluck reassigned KAFKA-10283: Assignee: highluck > Consolidate client-level and consumer-level assignment within ClientState >

[GitHub] [kafka] chia7712 commented on a change in pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-17 Thread GitBox
chia7712 commented on a change in pull request #9262: URL: https://github.com/apache/kafka/pull/9262#discussion_r490405191 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -280,7 +280,7 @@ synchronized void

[jira] [Created] (KAFKA-10497) Convert group/transaction coordinator metadata schemas to use generated protocol

2020-09-17 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10497: --- Summary: Convert group/transaction coordinator metadata schemas to use generated protocol Key: KAFKA-10497 URL: https://issues.apache.org/jira/browse/KAFKA-10497

[GitHub] [kafka] chia7712 commented on pull request #9296: MINOR: remove unused scala files from core module

2020-09-17 Thread GitBox
chia7712 commented on pull request #9296: URL: https://github.com/apache/kafka/pull/9296#issuecomment-694355722 @dongjinleekr thanks for review! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dongjinleekr commented on a change in pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-17 Thread GitBox
dongjinleekr commented on a change in pull request #9266: URL: https://github.com/apache/kafka/pull/9266#discussion_r490383726 ## File path: core/src/test/scala/kafka/utils/LoggingTest.scala ## @@ -58,4 +60,20 @@ class LoggingTest extends Logging {

[jira] [Assigned] (KAFKA-10491) Check authorizations before other criteria in KafkaApis

2020-09-17 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino reassigned KAFKA-10491: - Assignee: Ron Dagostino > Check authorizations before other criteria in KafkaApis >

[jira] [Updated] (KAFKA-10372) [JAVA 11] Unrecognized VM option PrintGCDateStamps

2020-09-17 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10372: --- Fix Version/s: (was: 2.6.1) > [JAVA 11] Unrecognized VM option PrintGCDateStamps >

[jira] [Updated] (KAFKA-10496) Create an in-memory DNS server for ClientUtilsTest and ClusterConnectionStatesTest

2020-09-17 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-10496: --- Description: ClientUtilsTest and ClusterConnectionStatesTest currently use an external DNS

[jira] [Updated] (KAFKA-10496) Create an in-memory DNS server for ClientUtilsTest and ClusterConnectionStatesTest

2020-09-17 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-10496: --- Description: ClientUtilsTest and ClusterConnectionStatesTest currently use an external DNS

[jira] [Created] (KAFKA-10496) Create an in-memory DNS server for ClientUtilsTest and ClusterConnectionStatesTest

2020-09-17 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-10496: -- Summary: Create an in-memory DNS server for ClientUtilsTest and ClusterConnectionStatesTest Key: KAFKA-10496 URL: https://issues.apache.org/jira/browse/KAFKA-10496

[GitHub] [kafka] jolshan commented on pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
jolshan commented on pull request #9294: URL: https://github.com/apache/kafka/pull/9294#issuecomment-694325685 Also created the issue https://issues.apache.org/jira/browse/KAFKA-10496 This is an automated message from the

[GitHub] [kafka] jolshan commented on pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
jolshan commented on pull request #9294: URL: https://github.com/apache/kafka/pull/9294#issuecomment-694319833 I also like @dajac's suggestion. I've updated the PR so that the tests assert more than 1 address as @mumrah said.

[GitHub] [kafka] mimaison commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-09-17 Thread GitBox
mimaison commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r490344407 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -201,26 +213,24 @@ public void

[GitHub] [kafka] ijuma commented on a change in pull request #9299: MINOR: Use `Map.foreachKv` to avoid tuple allocation in Scala 2.13

2020-09-17 Thread GitBox
ijuma commented on a change in pull request #9299: URL: https://github.com/apache/kafka/pull/9299#discussion_r490344276 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -133,7 +133,7 @@ object GetOffsetShell { } } -

[GitHub] [kafka] ijuma opened a new pull request #9299: MINOR: Use `Map.foreachKv` to avoid tuple allocation in Scala 2.13

2020-09-17 Thread GitBox
ijuma opened a new pull request #9299: URL: https://github.com/apache/kafka/pull/9299 `foreachKv` invokes `foreachEntry` in Scala 2.13 and falls back to `foreach` in Scala 2.12. This change requires a newer version of scala-collection-compat, so update it to the latest version

[GitHub] [kafka] edoardocomar commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-09-17 Thread GitBox
edoardocomar commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r490335096 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -283,49 +296,140 @@ public void

[GitHub] [kafka] ouyangnengda commented on pull request #9297: KAFKA-10495:Fix spelling mistake

2020-09-17 Thread GitBox
ouyangnengda commented on pull request #9297: URL: https://github.com/apache/kafka/pull/9297#issuecomment-694282470 ok This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-10313) Out of range offset errors leading to offset reset

2020-09-17 Thread Varsha Abhinandan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197722#comment-17197722 ] Varsha Abhinandan commented on KAFKA-10313: --- The issue mentioned in KAFKA-9543 seems to

[jira] [Comment Edited] (KAFKA-10313) Out of range offset errors leading to offset reset

2020-09-17 Thread Varsha Abhinandan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197722#comment-17197722 ] Varsha Abhinandan edited comment on KAFKA-10313 at 9/17/20, 2:26 PM: -

[GitHub] [kafka] showuon commented on pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-17 Thread GitBox
showuon commented on pull request #9202: URL: https://github.com/apache/kafka/pull/9202#issuecomment-694267556 @ijuma , thanks for the comments. I've updated in this commit: https://github.com/apache/kafka/pull/9202/commits/97fe0a53d450d103e25dae0669c3ac803d7afe40. Thank you!

[GitHub] [kafka] showuon commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-17 Thread GitBox
showuon commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r490283148 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1139,6 +1139,7 @@ object GroupMetadataManager { private

[GitHub] [kafka] cadonna commented on a change in pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-17 Thread GitBox
cadonna commented on a change in pull request #9262: URL: https://github.com/apache/kafka/pull/9262#discussion_r490189904 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -306,40 +306,55 @@ public synchronized void

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-17 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-694255418 Many thanks @ijuma all fixed. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ijuma commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-17 Thread GitBox
ijuma commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r490262817 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1139,6 +1139,7 @@ object GroupMetadataManager { private val

[GitHub] [kafka] ijuma commented on a change in pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-17 Thread GitBox
ijuma commented on a change in pull request #9266: URL: https://github.com/apache/kafka/pull/9266#discussion_r490260948 ## File path: core/src/test/scala/kafka/utils/LoggingTest.scala ## @@ -58,4 +60,22 @@ class LoggingTest extends Logging {

[GitHub] [kafka] ijuma commented on a change in pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-17 Thread GitBox
ijuma commented on a change in pull request #9266: URL: https://github.com/apache/kafka/pull/9266#discussion_r490259458 ## File path: core/src/main/scala/kafka/utils/Log4jController.scala ## @@ -29,6 +29,24 @@ import scala.jdk.CollectionConverters._ object Log4jController {

[jira] [Commented] (KAFKA-10495) Fix spelling mistake

2020-09-17 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197699#comment-17197699 ] Luke Chen commented on KAFKA-10495: --- *if and only if* (shortened as *iff*) , fyi

[GitHub] [kafka] dongjinleekr commented on pull request #9297: KAFKA-10495:Fix spelling mistake

2020-09-17 Thread GitBox
dongjinleekr commented on pull request #9297: URL: https://github.com/apache/kafka/pull/9297#issuecomment-694245811 Hi @ouyangnengda, I think it is not a problem. 'iff' means 'if and only if'. Please see [here](https://www.oxfordlearnersdictionaries.com/definition/english/iff).

[GitHub] [kafka] ijuma commented on a change in pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-17 Thread GitBox
ijuma commented on a change in pull request #9266: URL: https://github.com/apache/kafka/pull/9266#discussion_r490256227 ## File path: core/src/test/scala/kafka/utils/LoggingTest.scala ## @@ -58,4 +60,20 @@ class LoggingTest extends Logging {

[GitHub] [kafka] ijuma commented on a change in pull request #9223: KAFKA-10438 Lazy initialization of record header to reduce memory usa…

2020-09-17 Thread GitBox
ijuma commented on a change in pull request #9223: URL: https://github.com/apache/kafka/pull/9223#discussion_r490246634 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/record/RecordBatchBenchmarkSuite.java ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] ijuma opened a new pull request #9298: MINOR: Replace Java 14 with Java 15 in the README

2020-09-17 Thread GitBox
ijuma opened a new pull request #9298: URL: https://github.com/apache/kafka/pull/9298 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[GitHub] [kafka] ouyangnengda opened a new pull request #9297: KAFKA-10495:Fix spelling mistake

2020-09-17 Thread GitBox
ouyangnengda opened a new pull request #9297: URL: https://github.com/apache/kafka/pull/9297 The iff is wrong word.I fixed it to if. This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (KAFKA-10494) Streams: enableSendingOldValues should not call parent if node is itself materialized

2020-09-17 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10494: Description: Calling `enableSendingOldValues` on many nodes, e.g. `KTableFilter`, is

[GitHub] [kafka] mumrah commented on pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
mumrah commented on pull request #9294: URL: https://github.com/apache/kafka/pull/9294#issuecomment-694216516 Agreed with @dajac's suggestion. Maybe for this change we could have the assertion as > 1 rather than equalling a specific value

[jira] [Updated] (KAFKA-10494) Streams: enableSendingOldValues should not call parent if node is itself materialized

2020-09-17 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10494: Description: Calling `enableSendingOldValues` on many nodes, e.g. `KTableFilter`, is

[jira] [Updated] (KAFKA-10494) Streams: enableSendingOldValues should not call parent if node is itself materialized

2020-09-17 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10494: Description: Calling `enableSendingOldValues` on many nodes, e.g. `KTableFilter`, is

[GitHub] [kafka] big-andy-coates commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-17 Thread GitBox
big-andy-coates commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-694203001 @mjsax - ready for another review. - boolean `onlyIfMaterialized` is now flipped to `forceMaterialization`. - `KTableFilter` constructor initialized internal

[jira] [Created] (KAFKA-10495) Fix spelling mistake

2020-09-17 Thread Jira
欧阳能达 created KAFKA-10495: Summary: Fix spelling mistake Key: KAFKA-10495 URL: https://issues.apache.org/jira/browse/KAFKA-10495 Project: Kafka Issue Type: Improvement Components: clients,

[jira] [Updated] (KAFKA-10494) Streams: enableSendingOldValues should not call parent if node is itself materialized

2020-09-17 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10494: Description: Calling `enableSendingOldValues` on many nodes, e.g. `KTableFilter`, is

[jira] [Updated] (KAFKA-10494) Streams: enableSendingOldValues should not call parent if node is itself materialized

2020-09-17 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10494: Description: Calling `enableSendingOldValues` on many nodes, e.g. `KTableFilter`, is

[jira] [Commented] (KAFKA-10488) Adding cluster with ssl to kafka-manager

2020-09-17 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197622#comment-17197622 ] Mickael Maison commented on KAFKA-10488: Hi [~vodevops], This looks like a question about CMAK

[GitHub] [kafka] big-andy-coates commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-17 Thread GitBox
big-andy-coates commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r487060524 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableFilterTest.java ## @@ -295,12 +295,39 @@ public void

[GitHub] [kafka] big-andy-coates commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-17 Thread GitBox
big-andy-coates commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r490154341 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableAbstractJoin.java ## @@ -39,9 +39,15 @@ }

[jira] [Updated] (KAFKA-10494) Streams: enableSendingOldValues should not call parent if node is itself materialized

2020-09-17 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10494: Description: Calling `enableSendingOldValues` on many nodes, e.g. `KTableFilter`, is

[GitHub] [kafka] big-andy-coates commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-17 Thread GitBox
big-andy-coates commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r490152263 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java ## @@ -182,6 +182,8 @@ public String

[jira] [Created] (KAFKA-10494) Streams: enableSendingOldValues should not call parent if node is itself materialized

2020-09-17 Thread Andy Coates (Jira)
Andy Coates created KAFKA-10494: --- Summary: Streams: enableSendingOldValues should not call parent if node is itself materialized Key: KAFKA-10494 URL: https://issues.apache.org/jira/browse/KAFKA-10494

[jira] [Updated] (KAFKA-10494) Streams: enableSendingOldValues should not call parent if node is itself materialized

2020-09-17 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10494: Description: Calling `enableSendingOldValues` on many nodes, e.g. `KTableFilter`, is

[GitHub] [kafka] big-andy-coates commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-17 Thread GitBox
big-andy-coates commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r490152263 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java ## @@ -182,6 +182,8 @@ public String

[GitHub] [kafka] big-andy-coates commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-17 Thread GitBox
big-andy-coates commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r490147517 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableAggregate.java ## @@ -47,8 +47,10 @@ } @Override

[GitHub] [kafka] cadonna commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-17 Thread GitBox
cadonna commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r490101377 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsAssignmentScaleTest.java ## @@ -0,0 +1,256 @@ +/* + * Licensed to

[GitHub] [kafka] dajac commented on pull request #9294: MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

2020-09-17 Thread GitBox
dajac commented on pull request #9294: URL: https://github.com/apache/kafka/pull/9294#issuecomment-694131412 Netty used a in-memory DNS server for such tests: https://github.com/netty/netty/blob/master/resolver-dns/src/test/java/io/netty/resolver/dns/TestDnsServer.java. I suppose that we

[GitHub] [kafka] omkreddy commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-09-17 Thread GitBox
omkreddy commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-694129604 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vgvineet4 commented on pull request #9254: KAFKA-10462: Added support to pass headers in producerPerformance script

2020-09-17 Thread GitBox
vgvineet4 commented on pull request #9254: URL: https://github.com/apache/kafka/pull/9254#issuecomment-69400 @wcarlson5 please have a look This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2020-09-17 Thread Pedro Gontijo (Jira)
Pedro Gontijo created KAFKA-10493: - Summary: Ktable out-of-order updates are not being ignored Key: KAFKA-10493 URL: https://issues.apache.org/jira/browse/KAFKA-10493 Project: Kafka Issue

[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-09-17 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-693954974 @mimaison @omkreddy could one of you do the build again? This is an automated message from the Apache Git

[GitHub] [kafka] tombentley commented on pull request #9252: KAFKA-10241: Add test for message compatibility

2020-09-17 Thread GitBox
tombentley commented on pull request #9252: URL: https://github.com/apache/kafka/pull/9252#issuecomment-693953116 @abbccdda or perhaps @cmccabe or @dajac any chance one of you could take a look? This is an automated message

[jira] [Commented] (KAFKA-6791) Add a CoordinatorNodeProvider in KafkaAdminClient

2020-09-17 Thread Jeff Widman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197411#comment-17197411 ] Jeff Widman commented on KAFKA-6791: Should this be closed as "wontfix"? The associated PR was

  1   2   >