stan-confluent commented on pull request #9933:
URL: https://github.com/apache/kafka/pull/9933#issuecomment-765879109
Thanks for review and backport! Changes to ducktape were simply a bugfix to
move a bunch of code into the `finally` block to make sure it executes, so they
shouldn't
stan-confluent commented on pull request #9932:
URL: https://github.com/apache/kafka/pull/9932#issuecomment-765879093
Thanks for review and backport! Changes to ducktape were simply a bugfix to
move a bunch of code into the `finally` block to make sure it executes, so they
shouldn't
kkonstantine commented on pull request #9932:
URL: https://github.com/apache/kafka/pull/9932#issuecomment-765865709
Merged to 2.6 and backported up to 2.0.
This is an automated message from the Apache Git Service.
To
kkonstantine merged pull request #9932:
URL: https://github.com/apache/kafka/pull/9932
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kkonstantine commented on pull request #9932:
URL: https://github.com/apache/kafka/pull/9932#issuecomment-765864346
Few flaky failures. Green builds otherwise on jdk8 and jdk11
This is an automated message from the Apache
kkonstantine merged pull request #9933:
URL: https://github.com/apache/kafka/pull/9933
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kkonstantine commented on pull request #9933:
URL: https://github.com/apache/kafka/pull/9933#issuecomment-765864083
A few flaky test failures are not relevant to the changes.
Merging to `trunk` and `2.7`
This is an
hachikuji opened a new pull request #9952:
URL: https://github.com/apache/kafka/pull/9952
A few small cleanups in `GroupCoordinator` and related classes.
- Remove redundant `groupId` field from `MemberMetadata`
- Remove redundant val `isStaticMember` from `MemberMetadata`
- Fix
abbccdda commented on a change in pull request #9579:
URL: https://github.com/apache/kafka/pull/9579#discussion_r563003389
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1110,82 +1098,39 @@ class KafkaApis(val requestChannel: RequestChannel,
abbccdda commented on a change in pull request #9579:
URL: https://github.com/apache/kafka/pull/9579#discussion_r563002911
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1084,24 +1087,9 @@ class KafkaApis(val requestChannel: RequestChannel,
mjsax commented on pull request #9948:
URL: https://github.com/apache/kafka/pull/9948#issuecomment-765801515
Merged to `trunk` and cherry-picked to `2.7` and `2.6` branches.
This is an automated message from the Apache Git
mjsax commented on pull request #9948:
URL: https://github.com/apache/kafka/pull/9948#issuecomment-765788406
@showuon -- I just see you comment now after merging. Did not add you as
reviewer in the commit message. Sorry about that.
mjsax merged pull request #9948:
URL: https://github.com/apache/kafka/pull/9948
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
guozhangwang commented on pull request #9836:
URL: https://github.com/apache/kafka/pull/9836#issuecomment-765738281
Yup, I think we are on the same page for:
1) `ConsumerRecords#isEmpty`: I was not pointing that it may not return true
even if only metadata changed, I meant that if
wcarlson5 commented on a change in pull request #9863:
URL: https://github.com/apache/kafka/pull/9863#discussion_r562929843
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -612,11 +612,22 @@ public void
wcarlson5 commented on a change in pull request #9863:
URL: https://github.com/apache/kafka/pull/9863#discussion_r562929843
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -612,11 +612,22 @@ public void
dajac commented on a change in pull request #9949:
URL: https://github.com/apache/kafka/pull/9949#discussion_r562897068
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -183,8 +182,7 @@ public long brokerEpoch() {
ableegoldman merged pull request #9863:
URL: https://github.com/apache/kafka/pull/9863
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ableegoldman edited a comment on pull request #9863:
URL: https://github.com/apache/kafka/pull/9863#issuecomment-765658341
Two unrelated fail tests:
```
org.apache.kafka.clients.consumer.internals.FetcherTest.testEarlierOffsetResetArrivesLate()
ableegoldman commented on pull request #9863:
URL: https://github.com/apache/kafka/pull/9863#issuecomment-765658341
Two unrelated fail tests:
```
org.apache.kafka.clients.consumer.internals.FetcherTest.testEarlierOffsetResetArrivesLate()
ableegoldman commented on a change in pull request #9863:
URL: https://github.com/apache/kafka/pull/9863#discussion_r562882284
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -612,11 +612,22 @@ public void
hachikuji edited a comment on pull request #9819:
URL: https://github.com/apache/kafka/pull/9819#issuecomment-765642062
@dengziming Thanks for the updates. I think we're on the right track. I
thought of a few potential simplifications. Take a look here:
hachikuji commented on pull request #9819:
URL: https://github.com/apache/kafka/pull/9819#issuecomment-765642062
@dengziming Thanks for the updates. I think we're on the right track. I
thought of a few potential potential simplifications. Take a look here:
bbejeck commented on pull request #9738:
URL: https://github.com/apache/kafka/pull/9738#issuecomment-765610892
@mdespriee Thanks for your patience; I'm taking a look today
This is an automated message from the Apache Git
vvcephei commented on pull request #9836:
URL: https://github.com/apache/kafka/pull/9836#issuecomment-765602186
Thanks @guozhangwang . I share that concern.
It's a little different than what you pointed out, but to call attention to
it: I actually didn't change the definition of
wcarlson5 commented on a change in pull request #9253:
URL: https://github.com/apache/kafka/pull/9253#discussion_r562823698
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedDeserializer.java
##
@@ -33,22 +33,22 @@
*/
public class
wcarlson5 commented on a change in pull request #9863:
URL: https://github.com/apache/kafka/pull/9863#discussion_r562819243
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -612,11 +612,22 @@ public void
ableegoldman commented on a change in pull request #9863:
URL: https://github.com/apache/kafka/pull/9863#discussion_r562815151
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -612,11 +612,22 @@ public void
guozhangwang commented on pull request #9836:
URL: https://github.com/apache/kafka/pull/9836#issuecomment-765592268
Hey @vvcephei I was concerned about not the tests actually, it just rang to
me if we should be paranoid about any side-effects for a tighter consumer loop
in user code like:
ableegoldman commented on a change in pull request #9863:
URL: https://github.com/apache/kafka/pull/9863#discussion_r562813288
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -249,20 +249,31 @@ public boolean isValidTransition(final State
ableegoldman commented on pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#issuecomment-765590053
Merged to trunk
This is an automated message from the Apache Git Service.
To respond to the message, please
ableegoldman merged pull request #9848:
URL: https://github.com/apache/kafka/pull/9848
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ableegoldman commented on pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#issuecomment-765588975
One unrelated test failure in `SocketServerTest.testConnectionRatePerIp`
This is an automated message from
vvcephei commented on pull request #9836:
URL: https://github.com/apache/kafka/pull/9836#issuecomment-765574234
Thanks @guozhangwang ,
I considered that, but I think for this work, we actually do want to return
the metadata if we have fetched some. Since the semantics of
abbccdda commented on a change in pull request #9579:
URL: https://github.com/apache/kafka/pull/9579#discussion_r562792214
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1370,55 +1345,164 @@ class KafkaApis(val requestChannel: RequestChannel,
cadonna commented on a change in pull request #9863:
URL: https://github.com/apache/kafka/pull/9863#discussion_r562774792
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -249,20 +249,31 @@ public boolean isValidTransition(final State
guozhangwang commented on pull request #9836:
URL: https://github.com/apache/kafka/pull/9836#issuecomment-765552356
> I ran the PlaintextConsumerTest a bunch more times, and also searched
through the trunk build logs. I think this PR did make the test more flaky, and
I suspect the reason
[
https://issues.apache.org/jira/browse/KAFKA-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270267#comment-17270267
]
shiqihao commented on KAFKA-10762:
--
The key is whether this edge use case is worth solving. Maybe
[
https://issues.apache.org/jira/browse/KAFKA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270261#comment-17270261
]
shiqihao commented on KAFKA-12228:
--
I hava encountered similar SSL problems when using openjdk.
vvcephei commented on pull request #9836:
URL: https://github.com/apache/kafka/pull/9836#issuecomment-765507001
Thanks, @guozhangwang !
I ran the PlaintextConsumerTest a bunch more times, and also searched
through the trunk build logs. I think this PR did make the test more flaky,
lct45 edited a comment on pull request #9951:
URL: https://github.com/apache/kafka/pull/9951#issuecomment-765498392
@mjsax @wcarlson5 @JimGalasyn for review
This is an automated message from the Apache Git Service.
To
lct45 commented on pull request #9951:
URL: https://github.com/apache/kafka/pull/9951#issuecomment-765498392
@mjsax @wcarlson5 for review
This is an automated message from the Apache Git Service.
To respond to the message,
lct45 opened a new pull request #9951:
URL: https://github.com/apache/kafka/pull/9951
Adding docs for KIP-689 / KAFKA-9126 which added `withLoggingEnabled()` and
`withLoggingDisabled()` to `StreamJoined`
### Committer Checklist (excluded from commit message)
- [ ] Verify design
ijuma commented on pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#issuecomment-765497872
It definitely requires analysis on a case by case basis. However, having
helpers that do conversion lazily also have performance issues if the method
gets called repeatedly, unless
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270228#comment-17270228
]
Michael G. Noll commented on KAFKA-8930:
I submitted a PR for the user-facing documentation
chia7712 commented on pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#issuecomment-765494602
> You don't know how things will change over time ahead of time.
You are right. However, it seems to me it is hard to apply “single” solution
to all auto-generated data.
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270225#comment-17270225
]
ASF GitHub Bot commented on KAFKA-8930:
---
miguno opened a new pull request #324:
URL:
lct45 commented on a change in pull request #9253:
URL: https://github.com/apache/kafka/pull/9253#discussion_r562709184
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowedDeserializerTest.java
##
@@ -56,4 +57,23 @@ public void
ijuma commented on pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#issuecomment-765474499
It's the nature of protocol evolution. You don't know how things will change
over time ahead of time.
This is an
lct45 commented on a change in pull request #9253:
URL: https://github.com/apache/kafka/pull/9253#discussion_r562699939
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java
##
@@ -235,25 +235,27 @@ public void
lct45 commented on a change in pull request #9253:
URL: https://github.com/apache/kafka/pull/9253#discussion_r562698730
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java
##
@@ -327,7 +329,7 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shiqihao updated KAFKA-10762:
-
Attachment: (was: image-2021-01-22-18-12-52-323.png)
> alter the backoff in
sknop opened a new pull request #9950:
URL: https://github.com/apache/kafka/pull/9950
Cast SMT transformation for bytes -> string.
Without this fix, the conversion becomes
ByteBuffer.toString(), which always gives one of these useless results:
"java.nio.HeapByteBuffer[pos=0
cadonna commented on pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#issuecomment-765306203
@ableegoldman @guozhangwang, could someone of you merge this PR since it
seems there are no further open question.
cadonna commented on a change in pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#discussion_r562531849
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/KAFKA-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shiqihao updated KAFKA-10762:
-
Attachment: image-2021-01-22-18-12-52-323.png
> alter the backoff in `KafkaConsumer.pollForFetches`
>
dengziming commented on a change in pull request #9819:
URL: https://github.com/apache/kafka/pull/9819#discussion_r562516704
##
File path:
raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java
##
@@ -53,13 +54,13 @@ public long sizeInBytes() throws
rajinisivaram commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r562511974
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1190,8 +1192,31 @@ class KafkaApis(val requestChannel: RequestChannel,
val
g1geordie commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r562502128
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##
@@ -66,25 +65,38 @@ public String toString() {
chia7712 opened a new pull request #9949:
URL: https://github.com/apache/kafka/pull/9949
as title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
wilkinsona commented on pull request #9947:
URL: https://github.com/apache/kafka/pull/9947#issuecomment-765256033
Thanks for the reviews. I've addressed the comments other than possibly
passing the `File` into the `configurePermissions` and `assertPermissions`
methods. Let me know which
wilkinsona commented on a change in pull request #9947:
URL: https://github.com/apache/kafka/pull/9947#discussion_r562482975
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -109,16 +109,27 @@ public
chia7712 commented on pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#issuecomment-765246731
It look like a bad pattern if we have to "contort" a bunch of data from
auto-generated protocol when processing.
ijuma commented on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-765241792
I removed the @FunctionalInterface annotation from `Invariant`. I don't
think this interfaces are used as functional interfaces and they make the
system more strongly typed.
chia7712 commented on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-765241389
> What are you suggesting instead of Validation and Invariant? Runnable?
Runnable
This is an automated
ijuma commented on a change in pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#discussion_r562472766
##
File path: raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java
##
@@ -59,6 +60,7 @@
import static
ijuma edited a comment on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-765239810
@chia7712 What are you suggesting instead of `Validation` and `Invariant`?
`Runnable`?
This is an automated
ijuma commented on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-765239810
@chia7712 What are you suggesting instead of `Validation` and `Invariant`?
This is an automated message from the
wilkinsona commented on a change in pull request #9947:
URL: https://github.com/apache/kafka/pull/9947#discussion_r562467953
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
##
@@ -115,22 +115,29 @@ public void
wilkinsona commented on a change in pull request #9947:
URL: https://github.com/apache/kafka/pull/9947#discussion_r562467278
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -109,16 +109,27 @@ public
wilkinsona commented on a change in pull request #9947:
URL: https://github.com/apache/kafka/pull/9947#discussion_r562466134
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -109,16 +109,27 @@ public
ijuma commented on pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#issuecomment-765233789
Like Jason said, I think the main challenge is how to deal with protocol
evolution. It's typically possible to deal with, but it can require quite a lot
of contortion.
wilkinsona commented on a change in pull request #9947:
URL: https://github.com/apache/kafka/pull/9947#discussion_r562464755
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -109,16 +109,27 @@ public
[
https://issues.apache.org/jira/browse/KAFKA-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-10740.
-
Fix Version/s: 2.8.0
Resolution: Fixed
> Replace
[
https://issues.apache.org/jira/browse/KAFKA-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-10851.
-
Fix Version/s: 2.8.0
Resolution: Fixed
> Add Cluster Describe API
>
[
https://issues.apache.org/jira/browse/KAFKA-12212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-12212.
-
Fix Version/s: 2.8.0
Resolution: Fixed
> Bump Metadata API version to remove
dajac merged pull request #9945:
URL: https://github.com/apache/kafka/pull/9945
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac commented on pull request #9945:
URL: https://github.com/apache/kafka/pull/9945#issuecomment-765218202
Failed tests are not related:
* Build / JDK 8 /
org.apache.kafka.clients.consumer.KafkaConsumerTest.testCloseWithTimeUnit()
* Build / JDK 8 /
78 matches
Mail list logo
