[PR] Fixed typo [kafka]

2025-02-14 Thread via GitHub
srihari-sridharan-tw opened a new pull request, #18913: URL: https://github.com/apache/kafka/pull/18913 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summa

Re: [PR] KAFKA-18784: Fix ConsumerWithLegacyMessageFormatIntegrationTest [kafka]

2025-02-14 Thread via GitHub
FrankYang0529 commented on code in PR #18889: URL: https://github.com/apache/kafka/pull/18889#discussion_r1957057125 ## core/src/test/scala/integration/kafka/api/ConsumerWithLegacyMessageFormatIntegrationTest.scala: ## @@ -80,12 +114,12 @@ class ConsumerWithLegacyMessageFormatIn

Re: [PR] KAFKA-18784: Fix ConsumerWithLegacyMessageFormatIntegrationTest [kafka]

2025-02-14 Thread via GitHub
FrankYang0529 commented on code in PR #18889: URL: https://github.com/apache/kafka/pull/18889#discussion_r1957057125 ## core/src/test/scala/integration/kafka/api/ConsumerWithLegacyMessageFormatIntegrationTest.scala: ## @@ -80,12 +114,12 @@ class ConsumerWithLegacyMessageFormatIn

Re: [PR] MINOR: Align assertFutureThrows method signature with JUnit conventions [kafka]

2025-02-14 Thread via GitHub
Parkerhiphop commented on PR #18825: URL: https://github.com/apache/kafka/pull/18825#issuecomment-2660723112 > @Parkerhiphop Please can you investigate why the tests timed out. @AndrewJSchofield Thanks for reminding. I resolve it by merging the latest changes . -- This is an automa

Re: [PR] MINOR: remove duplicate code on ByteUtilsBenchmark.java [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] closed pull request #17531: MINOR: remove duplicate code on ByteUtilsBenchmark.java URL: https://github.com/apache/kafka/pull/17531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-17572: Clear build scan PR status when re-running the tests [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] closed pull request #17489: KAFKA-17572: Clear build scan PR status when re-running the tests URL: https://github.com/apache/kafka/pull/17489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] commented on PR #17571: URL: https://github.com/apache/kafka/pull/17571#issuecomment-2660698514 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-16966:Allow offset commit fetch to reuse previous request if partitions are a subset [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] commented on PR #17584: URL: https://github.com/apache/kafka/pull/17584#issuecomment-2660698526 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-17824: Upgrade protobuf-java version to 4.28.2 [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] closed pull request #17533: KAFKA-17824: Upgrade protobuf-java version to 4.28.2 URL: https://github.com/apache/kafka/pull/17533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-17824: Upgrade protobuf-java version to 4.28.2 [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] commented on PR #17533: URL: https://github.com/apache/kafka/pull/17533#issuecomment-2660698498 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: remove duplicate code on ByteUtilsBenchmark.java [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] commented on PR #17531: URL: https://github.com/apache/kafka/pull/17531#issuecomment-2660698476 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17682 Refactor RaftClusterInvocationContext to eliminate test-common-api dependencies [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] closed pull request #17357: KAFKA-17682 Refactor RaftClusterInvocationContext to eliminate test-common-api dependencies URL: https://github.com/apache/kafka/pull/17357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-17572: Clear build scan PR status when re-running the tests [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] commented on PR #17489: URL: https://github.com/apache/kafka/pull/17489#issuecomment-2660698454 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17682 Refactor RaftClusterInvocationContext to eliminate test-common-api dependencies [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] commented on PR #17357: URL: https://github.com/apache/kafka/pull/17357#issuecomment-2660698440 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Fix an incorrect assignment in StreamsUncaughtExceptionHandlerIntegrationTest [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] commented on PR #18837: URL: https://github.com/apache/kafka/pull/18837#issuecomment-2660685432 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-02-14 Thread via GitHub
github-actions[bot] commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2660685441 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-14 Thread via GitHub
frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1956990747 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -1539,6 +1548,8 @@ public void testGroupIdNotNullAndValid() {

[PR] [WIP] JWT bearer grant type support [kafka]

2025-02-14 Thread via GitHub
kirktrue opened a new pull request, #18912: URL: https://github.com/apache/kafka/pull/18912 Do not merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-14 Thread via GitHub
frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1956982304 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java: ## @@ -595,18 +540,20 @@ public void testAutocommitEnsureOnlyOneI

Re: [PR] MINOR Don't discard thread dumps [kafka]

2025-02-14 Thread via GitHub
mumrah merged PR #18909: URL: https://github.com/apache/kafka/pull/18909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-17125 Add integration test for StreamsGroup in Admin API [kafka]

2025-02-14 Thread via GitHub
aliehsaeedii commented on code in PR #18911: URL: https://github.com/apache/kafka/pull/18911#discussion_r1956972281 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -270,7 +285,7 @@ private void printOffsets(StreamsGroupDescription descripti

[PR] KAFKA-17125 Add integration test for StreamsGroup in Admin API [kafka]

2025-02-14 Thread via GitHub
aliehsaeedii opened a new pull request, #18911: URL: https://github.com/apache/kafka/pull/18911 Integration test for both `--list` and `--describe` commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] add output formatting options for DumpLogSegments [kafka]

2025-02-14 Thread via GitHub
jrmcclurg opened a new pull request, #18910: URL: https://github.com/apache/kafka/pull/18910 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* Currently the out

Re: [PR] MINOR: add output formatting options for DumpLogSegments [kafka]

2025-02-14 Thread via GitHub
jrmcclurg commented on PR #18910: URL: https://github.com/apache/kafka/pull/18910#issuecomment-2660569677 @dajac @mimaison I see you are the most recent contributors to this code (hopefully it's okay to tag you directly). -- This is an automated message from the Apache Git Service. To res

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-14 Thread via GitHub
ahuang98 commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1956915603 ## raft/src/test/java/org/apache/kafka/raft/InvalidMemoryRecordsProvider.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] MINOR Don't discard thread dumps [kafka]

2025-02-14 Thread via GitHub
mumrah commented on PR #18909: URL: https://github.com/apache/kafka/pull/18909#issuecomment-2660482053 Noticed that PRs like https://github.com/apache/kafka/actions/runs/13323530395/job/37212415483?pr=18901 had a timeout, but we discarded the thread dumps. cc @mjsax -- This is an

[PR] MINOR Don't discard thread dumps [kafka]

2025-02-14 Thread via GitHub
mumrah opened a new pull request, #18909: URL: https://github.com/apache/kafka/pull/18909 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[jira] [Assigned] (KAFKA-18803) The acls would appear at the wrong level of the metadata shell "tree"

2025-02-14 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-18803: - Assignee: Jhen-Yung Hsu (was: Chia-Ping Tsai) > The acls would appear at the wrong lev

[jira] [Commented] (KAFKA-18803) The acls would appear at the wrong level of the metadata shell "tree"

2025-02-14 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927297#comment-17927297 ] Jhen-Yung Hsu commented on KAFKA-18803: --- I'm working on this, thank :) > The acls

[jira] [Assigned] (KAFKA-18803) The acls would appear at the wrong level of the metadata shell "tree"

2025-02-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18803: -- Assignee: Chia-Ping Tsai > The acls would appear at the wrong level of the metadata s

Re: [PR] HOTFIX: StoreChangelogReader should require stable consumer group [kafka]

2025-02-14 Thread via GitHub
mjsax commented on PR #18901: URL: https://github.com/apache/kafka/pull/18901#issuecomment-2660371175 \cc @dajac -- would like to cherry-pick this to `4.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-14 Thread via GitHub
chia7712 commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1956777095 ## metadata/src/main/java/org/apache/kafka/image/node/MetadataNode.java: ## @@ -53,7 +53,8 @@ default void print(MetadataNodePrinter printer) { for (String na

Re: [PR] HOTFIX: StoreChangelogReader should require stable consumer group [kafka]

2025-02-14 Thread via GitHub
mjsax commented on PR #18901: URL: https://github.com/apache/kafka/pull/18901#issuecomment-2660370049 Java 23 passed. Java 17: ``` Found 1 test failures: FAILED ❌ CooperativeConsumerCoordinatorTest > testOutdatedCoordinatorAssignment() Found 3 flaky test failures: FLAKY

[jira] [Created] (KAFKA-18803) The acls would appear at the wrong level of the metadata shell "tree"

2025-02-14 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18803: -- Summary: The acls would appear at the wrong level of the metadata shell "tree" Key: KAFKA-18803 URL: https://issues.apache.org/jira/browse/KAFKA-18803 Project: Ka

Re: [PR] MINOR: fix Kafka Streams "smoke test" pass criteria [kafka]

2025-02-14 Thread via GitHub
mjsax commented on code in PR #18835: URL: https://github.com/apache/kafka/pull/18835#discussion_r1956772003 ## tests/kafkatest/tests/streams/streams_smoke_test.py: ## @@ -109,5 +109,7 @@ def test_streams(self, processing_guarantee, crash, metadata_quorum): if crash

Re: [PR] KAFKA-18023: Enforcing Explicit Naming for Kafka Streams Internal Topics [kafka]

2025-02-14 Thread via GitHub
ableegoldman commented on code in PR #18233: URL: https://github.com/apache/kafka/pull/18233#discussion_r1956770352 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -2289,4 +2298,45 @@ public WrappedProcessorSupplier wra

Re: [PR] KAFKA-18023: Enforcing Explicit Naming for Kafka Streams Internal Topics [kafka]

2025-02-14 Thread via GitHub
ableegoldman commented on code in PR #18233: URL: https://github.com/apache/kafka/pull/18233#discussion_r1956770352 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -2289,4 +2298,45 @@ public WrappedProcessorSupplier wra

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-14 Thread via GitHub
mumrah commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1956762973 ## metadata/src/main/java/org/apache/kafka/image/node/MetadataNode.java: ## @@ -53,7 +53,8 @@ default void print(MetadataNodePrinter printer) { for (String name

Re: [PR] MINOR: fix Kafka Streams "smoke test" pass criteria [kafka]

2025-02-14 Thread via GitHub
mjsax commented on code in PR #18835: URL: https://github.com/apache/kafka/pull/18835#discussion_r1956762792 ## streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java: ## @@ -521,13 +521,16 @@ private static boolean verify(final PrintStream resultStream,

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (2/N) [kafka]

2025-02-14 Thread via GitHub
mjsax merged PR #18882: URL: https://github.com/apache/kafka/pull/18882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (2/N) [kafka]

2025-02-14 Thread via GitHub
mjsax commented on PR #18882: URL: https://github.com/apache/kafka/pull/18882#issuecomment-2660331326 Java 23 passed. Java 17: ``` Found 1 test failures: FAILED ❌ Tls13SelectorTest > testCloseOldestConnection() Found 3 flaky test failures: FLAKY ⚠️ PlaintextConsumerPoll

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (1/N) [kafka]

2025-02-14 Thread via GitHub
mjsax merged PR #18881: URL: https://github.com/apache/kafka/pull/18881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (1/N) [kafka]

2025-02-14 Thread via GitHub
mjsax commented on code in PR #18881: URL: https://github.com/apache/kafka/pull/18881#discussion_r1956753925 ## streams/src/main/java/org/apache/kafka/streams/kstream/BranchedKStream.java: ## @@ -16,54 +16,58 @@ */ package org.apache.kafka.streams.kstream; +import org.apach

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (1/N) [kafka]

2025-02-14 Thread via GitHub
mjsax commented on code in PR #18881: URL: https://github.com/apache/kafka/pull/18881#discussion_r1956753771 ## streams/src/main/java/org/apache/kafka/streams/kstream/BranchedKStream.java: ## @@ -16,54 +16,58 @@ */ package org.apache.kafka.streams.kstream; +import org.apach

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-14 Thread via GitHub
ahuang98 commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1956751434 ## core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala: ## @@ -108,12 +116,57 @@ final class KafkaMetadataLogTest { classOf[RuntimeException], () =

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-14 Thread via GitHub
lianetm commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1956606014 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java: ## @@ -386,38 +360,10 @@ public void testCommitAsync() { @Test

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-14 Thread via GitHub
ahuang98 commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1956727599 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1086,63 +1088,79 @@ class UnifiedLog(@volatile var logStartOffset: Long, var shallowOffsetOfMaxTimestamp

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-14 Thread via GitHub
ahuang98 commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1956724846 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1159,6 +1177,25 @@ class UnifiedLog(@volatile var logStartOffset: Long, validBytesCount, lastOffsetOfF

Re: [PR] KAFKA-18629: Delete share group state RPC group coordinator impl. [3/N] [kafka]

2025-02-14 Thread via GitHub
smjn commented on code in PR #18848: URL: https://github.com/apache/kafka/pull/18848#discussion_r1956713206 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -6280,6 +6286,48 @@ public void createGroupTombstoneRecords(

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-14 Thread via GitHub
ahuang98 commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1956707770 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1086,63 +1088,79 @@ class UnifiedLog(@volatile var logStartOffset: Long, var shallowOffsetOfMaxTimestamp

Re: [PR] KAFKA-18629: Delete share group state RPC group coordinator impl. [3/N] [kafka]

2025-02-14 Thread via GitHub
smjn commented on code in PR #18848: URL: https://github.com/apache/kafka/pull/18848#discussion_r1956698676 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -6280,6 +6286,48 @@ public void createGroupTombstoneRecords(

Re: [PR] KAFKA-18629: Delete share group state RPC group coordinator impl. [3/N] [kafka]

2025-02-14 Thread via GitHub
smjn commented on PR #18848: URL: https://github.com/apache/kafka/pull/18848#issuecomment-2660230440 > A couple of small comments remain. I know that this code is being reworked as once the `ShareGroupStatePartitionMetadataRecord` is introduced, so it's up to @smjn whether to address the co

Re: [PR] MINOR: Align assertFutureThrows method signature with JUnit conventions [kafka]

2025-02-14 Thread via GitHub
AndrewJSchofield commented on PR #18825: URL: https://github.com/apache/kafka/pull/18825#issuecomment-2660200395 @Parkerhiphop Please can you investigate why the tests timed out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] KAFKA-18755 Align timeout in kafka-share-groups.sh [kafka]

2025-02-14 Thread via GitHub
JimmyWang6 opened a new pull request, #18908: URL: https://github.com/apache/kafka/pull/18908 Align timeout in kafka-share-groups.sh with kafka-group.sh to 3ms. JIRA: [Align timeout in kafka-share-groups.sh with other group-related tools](https://issues.apache.org/jira/projects/KAFKA/

Re: [PR] KAFKA-18629: Delete share group state RPC group coordinator impl. [3/N] [kafka]

2025-02-14 Thread via GitHub
AndrewJSchofield commented on code in PR #18848: URL: https://github.com/apache/kafka/pull/18848#discussion_r1956632577 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -822,20 +831,27 @@ public CompletableFuture { -

Re: [PR] KAFKA-18790: Fix testCustomQuotaCallback [kafka]

2025-02-14 Thread via GitHub
chia7712 merged PR #18906: URL: https://github.com/apache/kafka/pull/18906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18790) testCustomQuotaCallback time out build failure

2025-02-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18790. Resolution: Fixed trunk: https://github.com/apache/kafka/commit/e828767062feb163ea0506ac8

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (1/N) [kafka]

2025-02-14 Thread via GitHub
bbejeck commented on code in PR #18881: URL: https://github.com/apache/kafka/pull/18881#discussion_r1956589582 ## streams/src/main/java/org/apache/kafka/streams/kstream/BranchedKStream.java: ## @@ -16,54 +16,58 @@ */ package org.apache.kafka.streams.kstream; +import org.apa

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-14 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1956608864 ## metadata/src/main/java/org/apache/kafka/image/node/MetadataNode.java: ## @@ -53,7 +53,8 @@ default void print(MetadataNodePrinter printer) { for (String name

Re: [PR] KAFKA-18790: Fix testCustomQuotaCallback [kafka]

2025-02-14 Thread via GitHub
chia7712 commented on PR #18906: URL: https://github.com/apache/kafka/pull/18906#issuecomment-2660072556 loop the test 100 times, all pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-18761: Complete listing of share group offsets [1/N] [kafka]

2025-02-14 Thread via GitHub
AndrewJSchofield merged PR #18894: URL: https://github.com/apache/kafka/pull/18894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18801 Remove ClusterGenerator and revise docs of ClusterTemplate [kafka]

2025-02-14 Thread via GitHub
JimmyWang6 commented on PR #18907: URL: https://github.com/apache/kafka/pull/18907#issuecomment-2660047665 cc @chia7712 PTAL, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] KAFKA-18801 Remove ClusterGenerator and revise docs of ClusterTemplate [kafka]

2025-02-14 Thread via GitHub
JimmyWang6 opened a new pull request, #18907: URL: https://github.com/apache/kafka/pull/18907 JIRA: [https://issues.apache.org/jira/browse/KAFKA-18801](https://issues.apache.org/jira/browse/KAFKA-18801) This PR aims to remove useless ClusterGenerator. ### Committer Checklist (excluded

[jira] [Created] (KAFKA-18802) Fix flaky QuorumControllerTest#testUncleanShutdownBrokerElrEnabled

2025-02-14 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18802: -- Summary: Fix flaky QuorumControllerTest#testUncleanShutdownBrokerElrEnabled Key: KAFKA-18802 URL: https://issues.apache.org/jira/browse/KAFKA-18802 Project: Kafka

Re: [PR] KAFKA-18790: Fix testCustomQuotaCallback [kafka]

2025-02-14 Thread via GitHub
chia7712 commented on PR #18906: URL: https://github.com/apache/kafka/pull/18906#issuecomment-2660034564 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-18802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16717 [1/2]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-02-14 Thread via GitHub
chia7712 merged PR #18819: URL: https://github.com/apache/kafka/pull/18819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-18801) Remove ClusterGenerator and revise docs of ClusterTemplate

2025-02-14 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Wang reassigned KAFKA-18801: -- Assignee: Jimmy Wang (was: Chia-Ping Tsai) > Remove ClusterGenerator and revise docs of Clus

[jira] [Commented] (KAFKA-18801) Remove ClusterGenerator and revise docs of ClusterTemplate

2025-02-14 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927216#comment-17927216 ] Jimmy Wang commented on KAFKA-18801: Hi [~chia7712] , I could help to handle this ti

[jira] [Created] (KAFKA-18801) Remove ClusterGenerator and revise docs of ClusterTemplate

2025-02-14 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18801: -- Summary: Remove ClusterGenerator and revise docs of ClusterTemplate Key: KAFKA-18801 URL: https://issues.apache.org/jira/browse/KAFKA-18801 Project: Kafka

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-14 Thread via GitHub
chia7712 commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1956525411 ## metadata/src/main/java/org/apache/kafka/image/node/MetadataNode.java: ## @@ -53,7 +53,8 @@ default void print(MetadataNodePrinter printer) { for (String na

[jira] [Updated] (KAFKA-18800) Deprecate Authorizer#aclCount

2025-02-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18800: --- Labels: need-kip (was: ) > Deprecate Authorizer#aclCount > - >

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-14 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1956516319 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataBatchLoader.java: ## @@ -100,7 +100,7 @@ public boolean hasSeenRecord() { */ public final void

[jira] [Created] (KAFKA-18800) Deprecate Authorizer#aclCount

2025-02-14 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18800: -- Summary: Deprecate Authorizer#aclCount Key: KAFKA-18800 URL: https://issues.apache.org/jira/browse/KAFKA-18800 Project: Kafka Issue Type: Improvement

[jira] [Assigned] (KAFKA-18799) Remove AdminUtils

2025-02-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18799: -- Assignee: kangning.li (was: Chia-Ping Tsai) > Remove AdminUtils > -

[jira] [Assigned] (KAFKA-18798) The replica placement policy used by ReassignPartitionsCommand is not aligned with kraft controller

2025-02-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18798: -- Assignee: kangning.li (was: Chia-Ping Tsai) > The replica placement policy used by R

[jira] [Commented] (KAFKA-18799) Remove AdminUtils

2025-02-14 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927178#comment-17927178 ] kangning.li commented on KAFKA-18799: - [~chia7712] cloud you assign it to me? > Rem

[jira] [Commented] (KAFKA-18798) The replica placement policy used by ReassignPartitionsCommand is not aligned with kraft controller

2025-02-14 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927177#comment-17927177 ] kangning.li commented on KAFKA-18798: - [~chia7712] cloud you assign it to me? > The

Re: [PR] MINOR: Update the list of collaborators based on the number of commit… [kafka]

2025-02-14 Thread via GitHub
chia7712 closed pull request #17787: MINOR: Update the list of collaborators based on the number of commit… URL: https://github.com/apache/kafka/pull/17787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (KAFKA-18799) Remove AdminUtils

2025-02-14 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18799: -- Summary: Remove AdminUtils Key: KAFKA-18799 URL: https://issues.apache.org/jira/browse/KAFKA-18799 Project: Kafka Issue Type: Sub-task Report

[jira] [Created] (KAFKA-18798) The replica placement policy used by ReassignPartitionsCommand is not aligned with kraft controller

2025-02-14 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18798: -- Summary: The replica placement policy used by ReassignPartitionsCommand is not aligned with kraft controller Key: KAFKA-18798 URL: https://issues.apache.org/jira/browse/KAFKA-

Re: [PR] MINOR: Add release notes for Transactions Server Side Defense (KIP-890) [kafka]

2025-02-14 Thread via GitHub
jolshan merged PR #18896: URL: https://github.com/apache/kafka/pull/18896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: TransactionManager logs the epoch bump less frequently. [kafka]

2025-02-14 Thread via GitHub
jolshan merged PR #18895: URL: https://github.com/apache/kafka/pull/18895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Mark IBP_4_0_IV3 as production ready! [kafka]

2025-02-14 Thread via GitHub
dajac merged PR #18902: URL: https://github.com/apache/kafka/pull/18902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Mark IBP_4_0_IV3 as production ready! [kafka]

2025-02-14 Thread via GitHub
dajac commented on code in PR #18902: URL: https://github.com/apache/kafka/pull/18902#discussion_r1956396281 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -95,10 +95,13 @@ public void testFromVersionString() { assertEquals

[jira] [Created] (KAFKA-18797) Flaky testLargeAssignmentAndGroupWithUniformSubscription

2025-02-14 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-18797: -- Summary: Flaky testLargeAssignmentAndGroupWithUniformSubscription Key: KAFKA-18797 URL: https://issues.apache.org/jira/browse/KAFKA-18797 Project: Kafka

Re: [PR] MINOR: Mark IBP_4_0_IV3 as production ready! [kafka]

2025-02-14 Thread via GitHub
jolshan commented on code in PR #18902: URL: https://github.com/apache/kafka/pull/18902#discussion_r1956393967 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -95,10 +95,13 @@ public void testFromVersionString() { assertEqua

Re: [PR] KAFKA-18310: Flaky AbstractCoordinatorTest [kafka]

2025-02-14 Thread via GitHub
lianetm commented on PR #18665: URL: https://github.com/apache/kafka/pull/18665#issuecomment-2659702572 Hey @FrankYang0529 ! I was about to take a look at this flaky test as it's top of the flaky ones, and found you have a PR already, great! I will take a look next week to help push it thro

[jira] [Commented] (KAFKA-16538) Support UpdateFeatures for kraft.version so we can go from static quorums to dynamic

2025-02-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927158#comment-17927158 ] José Armando García Sancio commented on KAFKA-16538: [~zheguang]  {q

Re: [PR] MINOR: Add KIP-848's metric to the doc [kafka]

2025-02-14 Thread via GitHub
dajac merged PR #18890: URL: https://github.com/apache/kafka/pull/18890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18773: Migrate the log4j1 config to log4j 2 for native image and README (wip) [kafka]

2025-02-14 Thread via GitHub
FrankYang0529 commented on PR #18872: URL: https://github.com/apache/kafka/pull/18872#issuecomment-2659644151 Hi @dajac, I may need more time on this. Currently, there is some error message like this. I'm still check where the log from. Thanks. ``` 2025-02-13T03:30:07.514257Z main

Re: [PR] KAFKA-18023: Enforcing Explicit Naming for Kafka Streams Internal Topics [kafka]

2025-02-14 Thread via GitHub
sebastienviale commented on PR #18233: URL: https://github.com/apache/kafka/pull/18233#issuecomment-2659644207 @lucasbru done all the changes except the log message in case the new config is false. I added some documentation, it may be improved. -- This is an automated message from

Re: [PR] MINOR: Add KIP-848's metric to the doc [kafka]

2025-02-14 Thread via GitHub
dajac commented on code in PR #18890: URL: https://github.com/apache/kafka/pull/18890#discussion_r1956327375 ## docs/ops.html: ## @@ -1789,6 +1774,133 @@ Group Coordinator Monitoring +The following set of metrics are available for monitoring the group coordinator: + + +

Re: [PR] MINOR: Add KIP-848's metric to the doc [kafka]

2025-02-14 Thread via GitHub
jeffkbkim commented on code in PR #18890: URL: https://github.com/apache/kafka/pull/18890#discussion_r1956314167 ## docs/ops.html: ## @@ -1789,6 +1774,133 @@ Group Coordinator Monitoring +The following set of metrics are available for monitoring the group coordinator: + + +

Re: [PR] KAFKA-18740: Remove BootstrapDirectory#ibp [kafka]

2025-02-14 Thread via GitHub
chia7712 commented on PR #18905: URL: https://github.com/apache/kafka/pull/18905#issuecomment-2659523078 the cleanup is included by #18845, so this PR should be pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Assigned] (KAFKA-18790) testCustomQuotaCallback time out build failure

2025-02-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18790: -- Assignee: Ming-Yen Chung (was: Chia-Ping Tsai) > testCustomQuotaCallback time out bu

[PR] KAFKA-18790: Fix testCustomQuotaCallback [kafka]

2025-02-14 Thread via GitHub
mingyen066 opened a new pull request, #18906: URL: https://github.com/apache/kafka/pull/18906 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

Re: [PR] KAFKA-18761: Complete listing of share group offsets [1/N] [kafka]

2025-02-14 Thread via GitHub
chia7712 commented on code in PR #18894: URL: https://github.com/apache/kafka/pull/18894#discussion_r1956203598 ## tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommand.java: ## @@ -250,7 +252,7 @@ TreeMap but I went with consistency. It's modelled on Lis

Re: [PR] KAFKA-18736: Add Streams group heartbeat request manager (1/N) [kafka]

2025-02-14 Thread via GitHub
cadonna commented on code in PR #18870: URL: https://github.com/apache/kafka/pull/18870#discussion_r1956184549 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -0,0 +1,387 @@ +/* + * Licensed to the Apache Softw

Re: [PR] KAFKA-18736: Add Streams group heartbeat request manager (1/N) [kafka]

2025-02-14 Thread via GitHub
cadonna commented on PR #18870: URL: https://github.com/apache/kafka/pull/18870#issuecomment-2659396955 @lucasbru @bbejeck I addressed your comments. Please re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-18736: Add Streams group heartbeat request manager (1/N) [kafka]

2025-02-14 Thread via GitHub
cadonna commented on code in PR #18870: URL: https://github.com/apache/kafka/pull/18870#discussion_r1956172903 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -0,0 +1,387 @@ +/* + * Licensed to the Apache Softw

  1   2   >