chia7712 commented on a change in pull request #10107:
URL: https://github.com/apache/kafka/pull/10107#discussion_r574286504
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -756,6 +756,11 @@ protected Node curNode() {
bob-barrett opened a new pull request #10109:
URL: https://github.com/apache/kafka/pull/10109
This patch changes the NetworkClient behavior to resolve the target node's
hostname after disconnecting from an established connection, rather than
waiting until the previously-resolved addresses
bob-barrett opened a new pull request #10108:
URL: https://github.com/apache/kafka/pull/10108
This patch changes the NetworkClient behavior to resolve the target node's
hostname after disconnecting from an established connection, rather than
waiting until the previously-resolved addresses
[
https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282875#comment-17282875
]
Goltseva Taisiia commented on KAFKA-10340:
--
And also I cannot understand, why we even have the
chia7712 commented on pull request #10024:
URL: https://github.com/apache/kafka/pull/10024#issuecomment-777221844
@dajac @hachikuji Could you please take a look? This issue causes trouble to
QA since it obstructs gradle from generating test reports.
kamalcph commented on pull request #10099:
URL: https://github.com/apache/kafka/pull/10099#issuecomment-777190206
@chia7712
Addressed your review comments. Please take another look.
This is an automated message from the
jsancio commented on pull request #10063:
URL: https://github.com/apache/kafka/pull/10063#issuecomment-777182668
@mumrah I found a few more issues on how we compute the needed sizes. I need
to fix one of the remaining issues and write tests for them. Let's assume that
this PR is still a
[
https://issues.apache.org/jira/browse/KAFKA-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-12284:
-
Assignee: Luke Chen
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282847#comment-17282847
]
Luke Chen commented on KAFKA-12284:
---
investigating
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-12182.
---
Resolution: Duplicate
> Kafka connector is failing due to ' OffsetStorageWriter is already
mjsax commented on a change in pull request #10072:
URL: https://github.com/apache/kafka/pull/10072#discussion_r574221154
##
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##
@@ -32,6 +33,7 @@
public final int topicGroupId;
/** The ID
mjsax commented on a change in pull request #10072:
URL: https://github.com/apache/kafka/pull/10072#discussion_r574219892
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
##
@@ -213,27 +214,26 @@ private void
hachikuji opened a new pull request #10107:
URL: https://github.com/apache/kafka/pull/10107
If the admin client is shutdown with some unfinished calls, we see messages
such as the following in the log:
```
2021-02-09 11:08:05.964 DEBUG [AdminClient clientId=adminclient-1]
jsancio commented on a change in pull request #10063:
URL: https://github.com/apache/kafka/pull/10063#discussion_r574215331
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -79,24 +80,69 @@ public BatchAccumulator(
}
/**
dengziming commented on a change in pull request #10097:
URL: https://github.com/apache/kafka/pull/10097#discussion_r574204983
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -126,9 +126,14 @@
*gracefully resign from the current epoch.
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Leslie updated KAFKA-12257:
Description:
In KAFKA-7738, caching of leader epochs (KIP-320) was added to o.a.k.c.Metadata
to
junrao merged pull request #10100:
URL: https://github.com/apache/kafka/pull/10100
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282822#comment-17282822
]
Matthias J. Sax commented on KAFKA-12272:
-
Bumping this to "blocker" as it's a regression.
>
[
https://issues.apache.org/jira/browse/KAFKA-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12272:
Priority: Blocker (was: Minor)
> Kafka Streams metric commit-latency-max and
mjsax commented on pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#issuecomment-777145424
Thanks @ableegoldman -- updated the PR. If there are no further concerns
raised, I'll merge after Jenkins passed and cherry-pick to `2.8` branch.
[
https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282820#comment-17282820
]
Matthias J. Sax commented on KAFKA-12283:
-
Failed again:
ableegoldman commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574187073
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
mjsax merged pull request #10104:
URL: https://github.com/apache/kafka/pull/10104
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax merged pull request #10103:
URL: https://github.com/apache/kafka/pull/10103
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574183054
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
jolshan commented on pull request #10100:
URL: https://github.com/apache/kafka/pull/10100#issuecomment-777128859
Test failures seem to be mostly known flakes. Tests that failed passed
locally.
https://issues.apache.org/jira/browse/KAFKA-9295
jolshan commented on pull request #10041:
URL: https://github.com/apache/kafka/pull/10041#issuecomment-777118068
@junrao https://github.com/apache/kafka/pull/10100
This is an automated message from the Apache Git
rondagostino commented on pull request #10093:
URL: https://github.com/apache/kafka/pull/10093#issuecomment-777114058
System test results:
```
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.1
session_id: 2021-02-10--001
run time: 509 minutes 34.017 seconds
[
https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282774#comment-17282774
]
Kin Siu commented on KAFKA-10383:
-
This will be a really useful feature, I am using foreignKey join in
junrao commented on pull request #10041:
URL: https://github.com/apache/kafka/pull/10041#issuecomment-777104678
@jolshan : It seems this PR can't be applied cleanly in 2.8. Could you
submit a separate PR for 2.8? Thanks.
junrao merged pull request #10041:
URL: https://github.com/apache/kafka/pull/10041
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cmccabe opened a new pull request #10106:
URL: https://github.com/apache/kafka/pull/10106
Add MetaLogListener, LocalLogManager, and related classes. These
classes are used by the KIP-500 controller and broker to interface with the
Raft log.
rondagostino opened a new pull request #10105:
URL: https://github.com/apache/kafka/pull/10105
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
soarez commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574130615
##
File path: shell/src/main/java/org/apache/kafka/shell/InteractiveShell.java
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe merged pull request #10069:
URL: https://github.com/apache/kafka/pull/10069
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cmccabe commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574122281
##
File path: shell/src/main/java/org/apache/kafka/shell/CatCommandHandler.java
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574115310
##
File path: metadata/src/main/resources/common/metadata/PartitionRecord.json
##
@@ -34,6 +34,8 @@
{ "name": "Leader", "type": "int32", "versions":
jolshan commented on pull request #10041:
URL: https://github.com/apache/kafka/pull/10041#issuecomment-777069233
Sure. Using the LeaderAndIsrBenchmark (and the async profiler)
[LISRbench.zip](https://github.com/apache/kafka/files/5961818/LISRbench.zip)
from
cmccabe merged pull request #10101:
URL: https://github.com/apache/kafka/pull/10101
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
junrao commented on pull request #10041:
URL: https://github.com/apache/kafka/pull/10041#issuecomment-777054798
@jolshan : Do you have any benchmark results that you want to share?
This is an automated message from the
mjsax opened a new pull request #10104:
URL: https://github.com/apache/kafka/pull/10104
Backporting #10102
\cc @ableegoldman
This is an automated message from the Apache Git Service.
To respond to the message, please
mjsax opened a new pull request #10103:
URL: https://github.com/apache/kafka/pull/10103
Backporting #10102
\cc @ableegoldman
This is an automated message from the Apache Git Service.
To respond to the message,
ableegoldman commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574090779
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
ableegoldman commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574090292
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
cmccabe commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574088810
##
File path: metadata/src/main/resources/common/metadata/IsrChangeRecord.json
##
@@ -28,6 +28,8 @@
{ "name": "Leader", "type": "int32", "versions":
[
https://issues.apache.org/jira/browse/KAFKA-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282729#comment-17282729
]
A. Sophie Blee-Goldman commented on KAFKA-5146:
---
I guess I would lean towards creating a
cmccabe commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574088270
##
File path: core/src/main/scala/kafka/server/Server.scala
##
@@ -29,6 +29,7 @@ trait Server {
}
object Server {
+ val metadataTopicName =
cmccabe commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574087864
##
File path: build.gradle
##
@@ -1351,6 +1351,50 @@ project(':tools') {
}
}
+project(':shell') {
Review comment:
Good point. Let's call
mjsax commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574086409
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
mjsax commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574086409
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
mjsax commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574085771
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
jsancio commented on a change in pull request #10097:
URL: https://github.com/apache/kafka/pull/10097#discussion_r574082327
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -126,9 +126,14 @@
*gracefully resign from the current epoch. This
cmccabe commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574082124
##
File path: shell/src/main/java/org/apache/kafka/shell/MetadataShell.java
##
@@ -0,0 +1,274 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574081130
##
File path: build.gradle
##
@@ -1351,6 +1351,50 @@ project(':tools') {
}
}
+project(':shell') {
+ archivesBaseName = "kafka-shell"
+
+
mjsax commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574079328
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
ableegoldman commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574078902
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
cmccabe commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574078790
##
File path: shell/src/main/java/org/apache/kafka/shell/SnapshotReader.java
##
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574078171
##
File path: shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java
##
@@ -0,0 +1,308 @@
+/*
+ * Licensed to the Apache Software Foundation
ableegoldman commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574075417
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -776,9 +776,10 @@ void runOnce() {
jsancio commented on a change in pull request #10063:
URL: https://github.com/apache/kafka/pull/10063#discussion_r574075250
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -79,24 +80,69 @@ public BatchAccumulator(
}
/**
jsancio commented on a change in pull request #10063:
URL: https://github.com/apache/kafka/pull/10063#discussion_r574069573
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -79,24 +80,69 @@ public BatchAccumulator(
}
/**
cmccabe merged pull request #10084:
URL: https://github.com/apache/kafka/pull/10084
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax opened a new pull request #10102:
URL: https://github.com/apache/kafka/pull/10102
Call for review @ableegoldman
Fixes a regression bug. Should be cherry-picked back to 2.6 branch.
This is an automated message
mumrah commented on a change in pull request #10094:
URL: https://github.com/apache/kafka/pull/10094#discussion_r574048761
##
File path: shell/src/main/java/org/apache/kafka/shell/MetadataShell.java
##
@@ -0,0 +1,274 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on a change in pull request #10084:
URL: https://github.com/apache/kafka/pull/10084#discussion_r574060464
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -3390,6 +3390,11 @@ class KafkaApis(val requestChannel: RequestChannel,
new
ijuma commented on a change in pull request #10084:
URL: https://github.com/apache/kafka/pull/10084#discussion_r574048714
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -3390,6 +3390,11 @@ class KafkaApis(val requestChannel: RequestChannel,
new
[
https://issues.apache.org/jira/browse/KAFKA-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282679#comment-17282679
]
Dejan Stojadinović commented on KAFKA-12293:
(i) Update: after some additional investigation
dejan2609 edited a comment on pull request #10056:
URL: https://github.com/apache/kafka/pull/10056#issuecomment-776939008
@ewencp thing is that JFrog (company behind JCenter repository) simply
decided to pull the plug on May 01st 2021. (a short notice decision, I dear to
say).
So,
cmccabe commented on a change in pull request #10084:
URL: https://github.com/apache/kafka/pull/10084#discussion_r574006888
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -3390,6 +3390,11 @@ class KafkaApis(val requestChannel: RequestChannel,
new
mumrah commented on a change in pull request #10101:
URL: https://github.com/apache/kafka/pull/10101#discussion_r574006200
##
File path:
core/src/main/scala/kafka/server/metadata/ClientQuotaMetadataManager.scala
##
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software
MarcoLotz edited a comment on pull request #10091:
URL: https://github.com/apache/kafka/pull/10091#issuecomment-776945708
@vcrfxia Nice one! I performed the suggested the changes. Thanks to your
test comments and the fact that now we perform the computation on maintainMs()
method, I could
MarcoLotz edited a comment on pull request #10091:
URL: https://github.com/apache/kafka/pull/10091#issuecomment-776945708
@vcrfxia Nice one! I performed the suggested the changes. Thanks to your
test comments and the fact that now we perform the computation on maintainMs()
method, I could
MarcoLotz commented on pull request #10091:
URL: https://github.com/apache/kafka/pull/10091#issuecomment-776945708
@vcrfxia Nice one! I performed the suggested the changes. Thanks to your
test comments and the fact that now we perform the computation on maintainMs()
method, I could change
cmccabe commented on a change in pull request #10101:
URL: https://github.com/apache/kafka/pull/10101#discussion_r574003841
##
File path:
core/src/main/scala/kafka/server/metadata/ClientQuotaMetadataManager.scala
##
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software
cmccabe commented on a change in pull request #10101:
URL: https://github.com/apache/kafka/pull/10101#discussion_r574001340
##
File path: core/src/main/scala/kafka/server/metadata/ClientQuotaCache.scala
##
@@ -0,0 +1,284 @@
+/**
+ * Licensed to the Apache Software Foundation
dejan2609 edited a comment on pull request #10056:
URL: https://github.com/apache/kafka/pull/10056#issuecomment-776939008
@ewencp thing is that JFrog (company behind JCenter repository) simply
decided to pull the plug on May 01st 2021. (a short notice decision, I dear to
say).
So,
[
https://issues.apache.org/jira/browse/KAFKA-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282639#comment-17282639
]
Matthias J. Sax edited comment on KAFKA-12322 at 2/10/21, 7:02 PM:
---
dejan2609 commented on pull request #10056:
URL: https://github.com/apache/kafka/pull/10056#issuecomment-776939008
@ewencp thing is that JFrog (company behind JCenter repository) simply
decided to pull the plug on May 01st 2021. (a short notice decision, I dear to
say).
So, it
[
https://issues.apache.org/jira/browse/KAFKA-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-12322.
-
Resolution: Not A Problem
> Why https://downloads.apache.org/kafka/ it doesnot
[
https://issues.apache.org/jira/browse/KAFKA-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282639#comment-17282639
]
Matthias J. Sax commented on KAFKA-12322:
-
You should check out the download section on the web
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573994221
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573992730
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573992299
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
mjsax commented on pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#issuecomment-776934773
@yeralin -- Sorry that I did not get to review your updates yet... I need to
finish #9744 first that is very close to get merged. Your PR is next in the
list... (Just trying to
mumrah opened a new pull request #10101:
URL: https://github.com/apache/kafka/pull/10101
This PR brings in the new broker metadata processor for handling
QuotaRecord-s coming from the metadata log. Also included is a new cache class
to allow for fast lookups of quotas on the broker for
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573984736
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573983344
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573980461
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573980461
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573981156
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573980461
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#issuecomment-776924564
Thanks for the reviews, @mumrah !
> One thing I don't love is how BrokerLifecycleManager can be instantiated
but some of the members are not initialized until start is
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573975606
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1497,6 +1509,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573975606
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1497,6 +1509,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573972923
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573972180
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573970076
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573953538
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573953538
##
File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
##
@@ -0,0 +1,457 @@
+/**
+ * Licensed to the Apache Software Foundation
jolshan opened a new pull request #10100:
URL: https://github.com/apache/kafka/pull/10100
I'm porting https://github.com/apache/kafka/pull/10041 to the 2.8 branch.
Currently the partition.metadata file is created when the log is created.
However, clusters with older inter-broker
1 - 100 of 160 matches
Mail list logo
