justinrlee commented on PR #12797:
URL: https://github.com/apache/kafka/pull/12797#issuecomment-1374119222
Give me a little bit, will add sample outputs for different scenarios
shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
michaeljmarshall commented on code in PR #13032:
URL: https://github.com/apache/kafka/pull/13032#discussion_r1063786426
##
clients/src/test/java/org/apache/kafka/common/protocol/DataOutputStreamWritableTest.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software
michaeljmarshall commented on PR #13032:
URL: https://github.com/apache/kafka/pull/13032#issuecomment-1374113532
Thanks for catching my mistake @viktorsomogyi. My mistake was trusting
IntelliJ to run the test.
--
This is an automated message from the Apache Git Service.
To respond to the
chia7712 commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063758284
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,63 @@ class ReplicaManagerTest {
chia7712 commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063756861
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063733019
##
core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala:
##
@@ -255,15 +259,28 @@ class ProducerStateManagerTest {
appendData(30L, 31L, secondAppend)
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063726604
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063725076
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -174,7 +174,8 @@ class LogCleaner(initialConfig: CleanerConfig,
}
override def
gharris1727 commented on PR #13087:
URL: https://github.com/apache/kafka/pull/13087#issuecomment-1374038135
@jolshan could you take a look at this as well? I didn't realize these two
tests were failing in a similar fashion.
--
This is an automated message from the Apache Git Service.
To
gharris1727 opened a new pull request, #13087:
URL: https://github.com/apache/kafka/pull/13087
The broker appears to be timing out the producer ID before the test can see
it.
Increase the timeouts to compensate for slower CI environments.
Similar to the fix applied in #13036
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063722024
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063720614
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java:
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063720614
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java:
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063714637
##
storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
ijuma commented on PR #13046:
URL: https://github.com/apache/kafka/pull/13046#issuecomment-1374023466
I have a few more comments on this PR, will get back to it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1063709428
##
storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochFileCache.java:
##
@@ -0,0 +1,380 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1063708632
##
core/src/main/scala/kafka/server/checkpoints/OffsetCheckpointFile.scala:
##
@@ -65,9 +65,14 @@ class OffsetCheckpointFile(val file: File,
logDirFailureChannel:
ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1063705498
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -995,11 +994,12 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
- def latestEpoch:
gharris1727 commented on PR #13086:
URL: https://github.com/apache/kafka/pull/13086#issuecomment-1374008851
The last people working in this area were @pprovenzano @omkreddy and
@soarez, if any of you have some time i'd appreciate a review on this test
which flakes ~10-20% of the time.
ijuma commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1063688608
##
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
gharris1727 opened a new pull request, #13086:
URL: https://github.com/apache/kafka/pull/13086
The ACL change methods (create, delete) are eventually consistent across a
Kafka cluster. As part of that, changes to the same resource made to different
brokers may be reordered. In this test, a
ijuma commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1063687740
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1249,12 +1249,10 @@ class UnifiedLog(@volatile var logStartOffset: Long,
isolation: FetchIsolation,
junrao commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063679649
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
satishd commented on PR #13043:
URL: https://github.com/apache/kafka/pull/13043#issuecomment-1373959751
Thanks @ijuma for the review. I address them in the code and replied to your
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
chia7712 commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063654698
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
chia7712 commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063654318
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
fvaleri commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1063631875
##
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ijuma commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1063613984
##
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ijuma commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1063613984
##
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
fvaleri commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1063609877
##
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ijuma commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1063598351
##
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
fvaleri commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1063594153
##
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
emilnkrastev commented on code in PR #11818:
URL: https://github.com/apache/kafka/pull/11818#discussion_r1063563770
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java:
##
@@ -69,14 +69,19 @@ public MirrorSourceTask() {}
// for testing
emilnkrastev commented on code in PR #11818:
URL: https://github.com/apache/kafka/pull/11818#discussion_r1063558786
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java:
##
@@ -81,15 +88,25 @@ public void testOffsetSync() {
emilnkrastev commented on code in PR #11818:
URL: https://github.com/apache/kafka/pull/11818#discussion_r1063558786
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java:
##
@@ -81,15 +88,25 @@ public void testOffsetSync() {
ijuma commented on code in PR #13085:
URL: https://github.com/apache/kafka/pull/13085#discussion_r1063544116
##
storage/src/main/java/org/apache/kafka/server/log/internals/FetchIsolation.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
fvaleri commented on PR #13085:
URL: https://github.com/apache/kafka/pull/13085#issuecomment-1373794678
@ijuma @satishd fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
fvaleri opened a new pull request, #13085:
URL: https://github.com/apache/kafka/pull/13085
Part of KAFKA-14470: Move log layer to storage module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vladimirdyuzhev commented on code in PR #13081:
URL: https://github.com/apache/kafka/pull/13081#discussion_r1063475320
##
clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java:
##
@@ -90,6 +91,7 @@ public void configure(Map configs, String
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063467329
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
calmera commented on PR #12742:
URL: https://github.com/apache/kafka/pull/12742#issuecomment-1373454834
I agree we need to have some tests for that but that will require a bit more
time and effort. I'll try to allocate some time to get that done, but if there
is someone else who wants to
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1063323844
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final
StoreBuilder storeBuilder,
tombentley merged PR #13071:
URL: https://github.com/apache/kafka/pull/13071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1063316877
##
docs/streams/developer-guide/processor-api.html:
##
@@ -396,6 +397,21 @@
+
+ReadOnly
ashwinpankaj opened a new pull request, #13084:
URL: https://github.com/apache/kafka/pull/13084
https://issues.apache.org/jira/browse/KAFKA-14598
ConnectRestApiTest sometimes fails with the message
```
ConnectRestError(404, '\n\n\nError 404 Not
Found\n\nHTTP ERROR 404 Not
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1063310192
##
docs/streams/developer-guide/processor-api.html:
##
@@ -396,6 +397,21 @@
+
+ReadOnly
rajinisivaram commented on code in PR #13081:
URL: https://github.com/apache/kafka/pull/13081#discussion_r1063281046
##
clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java:
##
@@ -90,6 +91,7 @@ public void configure(Map configs, String
rajinisivaram commented on PR #13081:
URL: https://github.com/apache/kafka/pull/13081#issuecomment-1373402351
@vladimirdyuzhev Thanks for the PR. Since this is a security-related change,
can we create a JIRA with the details from the PR description and include the
ticket in the PR title?
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1063273259
##
streams/src/test/java/org/apache/kafka/test/MockProcessor.java:
##
@@ -28,9 +29,11 @@
import java.util.List;
import java.util.Map;
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1063271295
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamBranchTest.java:
##
@@ -59,7 +59,7 @@ public void testKStreamBranch() {
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1063270375
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final
StoreBuilder storeBuilder,
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1063269411
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final
StoreBuilder storeBuilder,
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063066837
##
storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063066837
##
storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063147960
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063066837
##
storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063072191
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063071578
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerAppendInfo.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063070497
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063068193
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063067653
##
storage/src/main/java/org/apache/kafka/server/log/internals/LastRecord.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063067362
##
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##
@@ -354,9 +356,10 @@ class LogSegmentTest {
// recover again, but this time assuming the
satishd commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1063066837
##
storage/src/main/java/org/apache/kafka/server/log/internals/TxnMetadata.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
showuon commented on PR #13083:
URL: https://github.com/apache/kafka/pull/13083#issuecomment-1373098778
Happy new year! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ijuma commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063058965
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
ableegoldman merged PR #13083:
URL: https://github.com/apache/kafka/pull/13083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman opened a new pull request, #13083:
URL: https://github.com/apache/kafka/pull/13083
It's 2023 now y'all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ableegoldman closed pull request #7824: MINOR: flush only the evicted dirty
entry
URL: https://github.com/apache/kafka/pull/7824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jolshan commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063013207
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
jolshan commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063013207
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
jolshan commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063012777
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
junrao commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1063005106
##
core/src/test/scala/unit/kafka/server/epoch/LeaderEpochFileCacheTest.scala:
##
@@ -243,282 +245,287 @@ class LeaderEpochFileCacheTest {
//Given
val cache
chia7712 commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063007860
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
littlehorse-eng commented on code in PR #13082:
URL: https://github.com/apache/kafka/pull/13082#discussion_r1062979323
##
docs/streams/developer-guide/config-streams.html:
##
@@ -778,10 +778,21 @@ rack.aware.assignment.tagsmax.warmup.replicas
-
littlehorse-eng opened a new pull request, #13082:
URL: https://github.com/apache/kafka/pull/13082
Documentation only—Minor clarification on how max.warmup.replicas works;
specifically, that one "warmup replica" corresponds to a Task that is restoring
its state. Also clarifies how
chia7712 commented on PR #13075:
URL: https://github.com/apache/kafka/pull/13075#issuecomment-1372912104
> is this because the log's highwatermark is lower or higher than the
futureLog's?
higher, and thanks to @junrao for the great explanation.
--
This is an automated
vladimirdyuzhev commented on PR #13081:
URL: https://github.com/apache/kafka/pull/13081#issuecomment-1372892329
Some tests are failed, but apparently it has nothing to do with Kerberos:
```
testSendNonCompressedMessageWithCreateTime(String) >
jolshan commented on PR #13075:
URL: https://github.com/apache/kafka/pull/13075#issuecomment-1372876700
So the error occurs when the fetch offset is not the futureLog's log end
offset.
Just curious -- is this because the log's highwatermark is lower or higher
than the futureLog's?
jsancio commented on PR #13077:
URL: https://github.com/apache/kafka/pull/13077#issuecomment-1372724189
Same failure again:
mjsax commented on code in PR #13077:
URL: https://github.com/apache/kafka/pull/13077#discussion_r1062838773
##
streams/upgrade-system-tests-33/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
jsancio merged PR #13076:
URL: https://github.com/apache/kafka/pull/13076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vladimirdyuzhev opened a new pull request, #13081:
URL: https://github.com/apache/kafka/pull/13081
When keytab file is not used, and the necessary configuration data are
provided by the SASL callback handler, the Kerberos TGT renewal fails because
the code is not re-using the configured
philipnee commented on code in PR #13021:
URL: https://github.com/apache/kafka/pull/13021#discussion_r1062809110
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -0,0 +1,273 @@
+/*
+ * Licensed to the Apache Software
junrao commented on code in PR #13049:
URL: https://github.com/apache/kafka/pull/13049#discussion_r1062797781
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation
jsancio commented on PR #13077:
URL: https://github.com/apache/kafka/pull/13077#issuecomment-1372590378
Here are the system test results:
jsancio commented on PR #13076:
URL: https://github.com/apache/kafka/pull/13076#issuecomment-1372586923
Thanks for the review @ijuma. Here are the results:
gharris1727 commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1062744806
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -723,7 +752,11 @@ private void sendPrivileged(String key,
gharris1727 commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1062726003
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -712,8 +733,16 @@ KafkaBasedLog
mimaison opened a new pull request, #13080:
URL: https://github.com/apache/kafka/pull/13080
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062646329
##
metadata/src/main/java/org/apache/kafka/controller/MigrationControlManager.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062645398
##
metadata/src/main/java/org/apache/kafka/metadata/migration/BrokersRpcClient.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062640868
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -348,7 +345,7 @@ class KafkaServer(
time = time,
metrics = metrics,
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1062635407
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateEntry.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062634566
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -292,7 +292,7 @@ class BrokerLifecycleManager(
}
val data = new
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062634160
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -55,7 +55,7 @@ class BrokerLifecycleManager(
val config: KafkaConfig,
val time: Time,
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062628793
##
core/src/main/scala/kafka/server/BrokerEpochManager.scala:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062627093
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -51,7 +51,7 @@
},
{ "name": "Rack", "type": "string", "versions": "0+",
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1062611257
##
docs/streams/developer-guide/processor-api.html:
##
@@ -396,6 +397,21 @@
+
+ReadOnly
calmera commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1062606439
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final
StoreBuilder storeBuilder,
divijvaidya commented on code in PR #13078:
URL: https://github.com/apache/kafka/pull/13078#discussion_r1062290508
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -576,6 +576,13 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}, period =
701 - 800 of 51425 matches
Mail list logo
