Re: Review Request 128352: Include KDEInstallDirs in ECMGeneratePriFile

NSTALL_DIR` themselves. So I don't think this change should happen. However, it would be sensible to make the documentation clearer about the interaction between this module and KDEInstallDirs. - Alex Merry On July 3, 2016, 12:17 p.m., Antonio R

Re: Review Request 127694: Add a Find module for WaylandProtocols

It would be a bit nicer to use the same indenting style found later in the file (ie: put COMMAND on another line, intended 4 spaces, and adjust the other lines to suit). - Alex Merry On May 3, 2016, 10:34 a.m., Martin G

Re: Taking a (semi-)break

On 2016-02-22 22:01, Stephen Kelly wrote: Alex Merry wrote: Hi all, A combination of a serious illness in the family and some of the heated discussions taking place on other KDE mailing lists has led to me burning out on the KDE front. As a result, I'm taking a step back (some of you may

Taking a (semi-)break

Hi all, A combination of a serious illness in the family and some of the heated discussions taking place on other KDE mailing lists has led to me burning out on the KDE front. As a result, I'm taking a step back (some of you may have noticed this already). I expect to get back into the swing

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126711/#review91820 --- Ship it! Ship It! - Alex Merry On Jan. 26, 2016, 1:48

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

/ECMAddAppIconTest/CMakeLists.txt (lines 16 - 18) <https://git.reviewboard.kde.org/r/126711/#comment62530> This will fail on Linux, for example, where the macro essentially does nothing. Also, the message() command should be indented. - Alex Merry On Jan. 19, 2016, 10:05 p.m., Gleb

Re: Review Request 126303: ECMAddAppIconMacro: Add OUTFILE parameter

tps://git.reviewboard.kde.org/r/126303/#comment62451> Can we have a different parameter name, please? If I see OUTFILE, I expect it to be the actual file name (probably a full path), not a basename. OUTFILE_BASE would work, but I'm open to suggestions. - Alex Merry On Jan. 19, 2016, 9:

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

in the upgrade. Could you try re-uploading it? - Alex Merry On Jan. 13, 2016, 8:22 p.m., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

> On Jan. 11, 2016, 2:53 p.m., Alex Merry wrote: > > The commands that deal with the icons are run from CMAKE_CURRENT_SOURCE_DIR > > with the intention of making relative paths work. I take it this isn't > > sufficient? > > > > It would be nice to have test

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126711/#review90978 --- Ship it! Ship It! - Alex Merry On Jan. 10, 2016, 8 p.m

Re: Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

fail, and that it generated the files that it should, and updated the variable that was passed to it. Is this something you would be willing to look at? - Alex Merry On Jan. 10, 2016, 8 p.m., Gleb Popov wrote

Re: Review Request 126535: Silence CMP0063 warnings with KDECompilerSettings.

marked as submitted. Review request for Extra Cmake Modules and David Faure. Changes --- Submitted with commit 70f8c5f9efaae8f16874d8cfc551e8ae19558fba by Alex Merry to branch master. Repository: extra-cmake-modules Description --- We recommend including KDE "settings&quo

Re: Review Request 126546: Fix CMP0064 warning by setting policy CMP0054 to NEW.

of the policy stack is only needed because you only want it to apply to a single macro, rather than the whole file (and you could just as well put the policy settings outside the macro/endmacro calls). Not sure whether you were aware of that. - Alex Merry On Dec. 28, 2015, 2:34 p.m., David Faure

Re: Review Request 126185: Make the KAppTemplate CMake module global

in. kde-modules/KDEPackageAppTemplates.cmake (line 19) <https://git.reviewboard.kde.org/r/126185/#comment61779> New paragraph, please. - Alex Merry On Dec. 28, 2015, 9:37 a.m., Marco Martin wrote: > > --- > This is a

Re: Review Request 126185: Make the KAppTemplate CMake module global

y to install the template package to. In most cases you will want to use the variable KDE_INSTALL_KTEMPLATESDIR from :kde-module:`KDEInstallDirs`. And then put a blank line before the bit about TEMPLATES, so they're separate paragraphs. - Alex Merry On Dec. 18, 2015, 10:55 a.m., Marco

Re: setting policies centrally (was: cmCMakePolicyCommand: New PARENT_SCOPE argument)

On 2015-12-22 22:08, David Faure wrote: On Monday 17 August 2015 09:25:01 Brad King wrote: So, I think we are back to asking projects to explicitly allow an included module to set policies by using NO_POLICY_SCOPE. As much as I hate that solution, I was about to go ahead and do it, to

Review Request 126535: Silence CMP0063 warnings with KDECompilerSettings.

's include(KDECompilerSettings), which silenced the CMP0063 warnings. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 126414: CMake: Cleanup: Strip text from endif/else

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126414/#review89715 --- Ship it! Ship It! - Alex Merry On Dec. 18, 2015, 11:40

Re: Review Request 126368: Include with generated logging category file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126368/#review89727 --- Ship it! Ship It! - Alex Merry On Dec. 18, 2015, 9:53 p.m

Re: Review Request 126185: Make the KAppTemplate CMake module global

() to untar the installed tarball, and examine the contents. I highly recommend you look at ECMInstallIconsTest. - Alex Merry On Dec. 17, 2015, 11:15 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wro

Re: Review Request 126185: Make the KAppTemplate CMake module global

bad about the sheer number of changes I'm throwing at you! If you want to make me do some of the work, you can create a feature branch and point me at it, but I'm hoping this review is setting you up for an easy ride if you want to contribute something else to e-c-m in the future. - Alex Merry

Re: Review Request 126368: Include with generated logging category file

convenient seems sensible. It might be worth noting this addition in the documentation, though, as anyone depending on ECM versions earlier than 5.18 will have to include the QDebug header themselves. - Alex Merry On Dec. 15, 2015, 5:30 p.m., Martin Klapetek wrote

Re: Review Request 126185: Make the KAppTemplate CMake module global

/contents/ui/main.qml (lines 1 - 18) <https://git.reviewboard.kde.org/r/126185/#comment61372> BSD code only in extra-cmake-modules, please. Frankly, your app template can be complete rubbish, as long as it's packaged up properly. - Alex Merry On Dec. 16, 2015, 12:25 p.m., Marco Martin

Re: Review Request 126185: Make the KAppTemplate CMake module global

On Dec. 16, 2015, 7:14 p.m., Marco Martin wrote: > > You might want to generate the documentation and look at it (you need the > > Sphinx documentation tool installed, then you just build > > extra-cmake-modules, and look in docs/html in the build directory). In particular, you'll need to add

Re: Review Request 126185: Make the KAppTemplate CMake module global

might want to generate the documentation and look at it (you need the Sphinx documentation tool installed, then you just build extra-cmake-modules, and look in docs/html in the build directory). - Alex Merry On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote: > > --

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wro

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wro

Re: Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

Python3 issues? - Alex Merry On Dec. 14, 2015, 4:48 p.m., Raphael Kubo da Costa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126345/#review89506 --- Ship it! Ship It! - Alex Merry On Dec. 14, 2015, 4:48 p.m

Re: Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

> On Dec. 14, 2015, 6:24 p.m., Alex Merry wrote: > > Seems sensible to me. Are there any potential Python2 vs Python3 issues? > > Raphael Kubo da Costa wrote: > I don't think there are any -- the `.pyc/.pyo` files are installed with a > different name into a differe

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 52 > > <https://git.reviewboard.kde.org/r/126185/diff/4/?file=421458#file421458line52> > > > > Honestly, I'd just use ARG as the prefix - you're in a function, i

Re: Review Request 126185: Make the KAppTemplate CMake module global

with that if you find the idea of writing a CMake-based unit test daunting, but you can look in the tests directory for inspiration. - Alex Merry On Dec. 9, 2015, 12:12 p.m., Marco Martin wrote: > > --- > This is an automatically generat

Re: Review Request 126303: ECMAddAppIconMacro: Add OUTFILE parameter

> On Dec. 12, 2015, 3:39 p.m., Alex Merry wrote: > > I'm not going to make you write a unit test for this, since this module didn't have any to begin with, but if you *were* willing to write tests, I would be very grateful.

Re: Review Request 126185: Make the KAppTemplate CMake module global

it will package the templates and install them. But I'm not going to force your hand on this if you'd rather not do it that way. - Alex Merry On Dec. 9, 2015, 12:12 p.m., Marco Martin wrote: > > --

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

vague message about Python and Gettext being needed. If you're going to take this approach, I think you still need to define k18n_install_ts_files in the else() branch, but make it spit out an error about exactly what package(s) are missing. - Alex Merry On Dec. 4, 2015, 12:

Re: Review Request 126185: Make the KAppTemplate CMake module global

r passing in the install destination as an argument, or at least allowing that as a possibility. The actual directory could (should?) be put into KDEInstallDirs.cmake as an extra variable. - Alex Merry On Dec. 3, 2015, 12:34

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 3, 2015, 11:49 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateMacro.cmake, line 1 > > > > > > You might want to add documentation. > > > > You can get inspired with > >

Re: [plasma-framework] /: Add KDETemplateMacro.cmake so I can remove it from ecm for now.

that this commit will break kapptemplate itself as well since was >going >to not have its own macro as well) > >On Thursday 03 December 2015, Alex Merry wrote: >> Git commit 2d814f049b496542dde17b4049679b8a0b7e1d9d by Alex Merry. >> Committed on 03/12/2015 at 10:02. >

Re: [plasma-framework] /: Add KDETemplateMacro.cmake so I can remove it from ecm for now.

On 3 December 2015 12:35:59 GMT+00:00, Marco Martin <notm...@gmail.com> wrote: >On Thursday 03 December 2015, Alex Merry wrote: >> Sorry, I did reply to your commit email directly, but didn't get a >response >> from you, and then ran out of time. I have no objection to ec

Re: Review Request 126000: Make sure we load translations on the main thread.

marked as submitted. Review request for Extra Cmake Modules and David Faure. Changes --- Submitted with commit fb4d91996affdbcd3ffc19c7646fbf77b96bf1e5 by Alex Merry to branch master. Bugs: 346188 http://bugs.kde.org/show_bug.cgi?id=346188 Repository: extra-cmake-modules

Re: Review Request 126183: Add a FindPoppler module to ECM

and KBibTex projects are happy to use it. - Alex Merry On Nov. 28, 2015, 12:43 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126183: Add a FindPoppler module to ECM

_CONFIG? find-modules/FindPoppler.cmake (lines 117 - 118) <https://git.reviewboard.kde.org/r/126183/#comment60891> You used SKIP_PKG_CONFIG, so I doubt this comment is accurate. If you could give us the Okular diff as Albert requested, that would be good, too. - Alex Merry On Nov. 27, 201

Re: Review Request 126000: Make sure we load translations on the main thread.

the world (all the default frameworks stuff) with kdesrc-build. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 126000: Make sure we load translations on the main thread.

issed that takes a function pointer. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126000/#review88733 ------- O

Re: Review Request 126075: Overhaul the ECM build system.

marked as submitted. Review request for Extra Cmake Modules and David Faure. Changes --- Submitted with commit c941061aa989bba945e296aad47df22f9c8ddd5f by Alex Merry to branch master. Repository: extra-cmake-modules Description --- It should now be easier to read, and more

Re: Review Request 126000: Make sure we load translations on the main thread.

-build. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 126090: Make it easy to enable clazy on our build directories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126090/#review88498 --- Ship it! - Alex Merry On Nov. 17, 2015, 12:32 a.m., Aleix

Re: Review Request 125935: Do not find XCB's XINPUT library by default.

marked as submitted. Review request for Extra Cmake Modules and Martin Gräßlin. Changes --- Submitted with commit 7d6915b482820e53c46b3a68ac27d2ef8485a248 by Alex Merry to branch master. Repository: extra-cmake-modules Description --- The XINPUT library is unlikely to be available

Re: Review Request 125935: Do not find XCB's XINPUT library by default.

Merry On Nov. 3, 2015, 6:39 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125935/ > --

Re: Review Request 126090: Make it easy to enable clazy on our build directories

This is the wrong version. It should be 5.17.0 by now. Needs a URL - the documentation makes no sense if you don't already know what clazy is. - Alex Merry On Nov. 16, 2015, 5:11 p.m., Aleix Pol Gonzalez wrote: > > --- > Thi

Review Request 126075: Overhaul the ECM build system.

and python3 versions) and qcollectiongenerator (Qt4 and Qt5 versions) installed or not. All seem to work sensibly. Generated HTML documentation checked by eye. sphinx-build 1.2.2 (used by api.kde.org) *not* tested. Thanks, Alex Merry ___ Kde-buildsystem

Re: Review Request 126075: Overhaul the ECM build system.

ategory module, and for some tests of the KDEInstallDirs module. -- Configuring done -- Generating done -- Build files have been written to: /home/kde-devel/src/extra-cmake-modules/build Thanks, Alex Merry ___ Kde-buildsystem mailing

Re: Review Request 125999: Fix multiple calls to ecm_create_qm_loader.

marked as submitted. Review request for Extra Cmake Modules. Changes --- Submitted with commit 55c55808298986d13ca461d571069f4214d8174d by Alex Merry to branch master. Repository: extra-cmake-modules Description --- Multiple ecm_create_qm_loader() with different catalog names would

Re: Review Request 125999: Fix multiple calls to ecm_create_qm_loader.

quot;. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125999/#review88356 --- On Nov. 9, 2015, 3:40 p.m., Alex Merry wrote: &

Re: Review Request 126000: Make sure we load translations on the main thread.

-CREATION Diff: https://git.reviewboard.kde.org/r/126000/diff/ Testing (updated) --- Extended unit tests, which pass. Built the world (all the default frameworks stuff) with kdesrc-build. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde

Review Request 125999: Fix multiple calls to ecm_create_qm_loader.

/diff/ Testing --- Extended unit tests, which pass. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

[extra-cmake-modules] /: Revert "Make sure we load translations on the main thread."

Git commit 6745bd7e4796560959bb67e33b7c7f86f96a5a94 by Alex Merry. Committed on 08/11/2015 at 19:29. Pushed by alexmerry into branch 'master'. Revert "Make sure we load translations on the main thread." This broke the build for projects which used ecm_create_qm_loader in unusual ways

Re: Review Request 126000: Make sure we load translations on the main thread.

--- Extended unit tests, which pass. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Review Request 126000: Make sure we load translations on the main thread.

9ab02e72c4f5aa740c04116e824a54c61fe8bda8 tests/ECMPoQmToolsTest/tr_thread_test.cpp PRE-CREATION tests/ECMPoQmToolsTest/tr_thread_test_module.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126000/diff/ Testing --- Extended unit tests, which pass. Thanks, Alex Merry

Re: Review Request 126000: Make sure we load translations on the main thread.

-CREATION Diff: https://git.reviewboard.kde.org/r/126000/diff/ Testing --- Extended unit tests, which pass. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 125960: Fix build of some projects using ecm_create_qm_loader()

the files are added to. Although I haven't looked at analitza's source code to be sure. - Alex Merry On Nov. 5, 2015, 2:36 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 125935: Do not find XCB's XINPUT library by default.

--- On Nov. 3, 2015, 6:39 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125935/ > --- &g

Re: Review Request 125931: Warn instead of error if ecm_install_icons finds no icons.

marked as submitted. Review request for Extra Cmake Modules. Changes --- Submitted with commit 21629f651a6a5d9d977be03fd9f98417c4fa27ae by Alex Merry to branch master. Repository: extra-cmake-modules Description --- The V1 syntax of ecm_install_icons searched for icons by globbing

Re: Review Request 123726: Make sure we load translations on the main thread.

marked as submitted. Review request for Extra Cmake Modules, Aurélien Gâteau and Chusslove Illich. Changes --- Submitted with commit 009c480413910e8c1a18f4d1420f4a517ea606e6 by Alex Merry to branch master. Bugs: 346188 http://bugs.kde.org/show_bug.cgi?id=346188 Repository: extra

Review Request 125931: Warn instead of error if ecm_install_icons finds no icons.

/125931/diff/ Testing --- Extended unit test, which passes, and ksirk now successfully configures. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Review Request 125935: Do not find XCB's XINPUT library by default.

, but with a warning. kwin configures without a warning. Modified kwindowsystem to call find_package(XCB), and that also configures without a warning. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 125631: Fix ECMInstallIconsTest.

and commit this to get the tests working again. - Alex Merry On Oct. 14, 2015, 11:16 a.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125631: Fix ECMInstallIconsTest.

marked as submitted. Review request for Extra Cmake Modules and Volker Krause. Changes --- Submitted with commit fb7b8eea7d91772f989d5b060c86df20f2ebdb66 by Alex Merry to branch master. Repository: extra-cmake-modules Description --- ECMInstallIcons now updates the theme cache

Re: Review Request 123726: Make sure we load translations on the main thread.

------- On May 11, 2015, 10:42 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123726/ > --

Re: CMake questions (add_definition, CMP0063)

On 2015-10-05 14:30, Frederik Schwarzer wrote: Am Samstag, 3. Oktober 2015, 00:30:04 schrieben Sie: On Fri, Oct 2, 2015 at 11:09 PM, Frederik Schwarzer wrote: > while looking through some make files, I found two things that I > do > not understand. > > 1)

Re: Review Request 123726: Make sure we load translations on the main thread.

://git.reviewboard.kde.org/r/123726/diff/ Testing (updated) --- Added test for basic functionality. Threaded stuff not tested yet (ie: the test doesn't check that this patch fixes things, but it does check that it doesn't break the already-working case). Thanks, Alex Merry

Re: Review Request 123726: Make sure we load translations on the main thread.

bject::invokeMethod(Qt::QueueConnection). > > > > IMHO, everything in this test doesn't need QTimer, > > QMetaObject::invokeMethod is enough. > > Alex Merry wrote: > Huh, I hadn't realised that > QMetaObject::invokeMethod(Qt::QueuedConnection) queued up an event on the

Re: Review Request 123726: Make sure we load translations on the main thread.

/tr_thread_test.cpp PRE-CREATION tests/ECMPoQmToolsTest/tr_thread_test_module.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123726/diff/ Testing --- Added tests for basic functionality and for loading a module on a thread. Both pass. Thanks, Alex Merry

Re: Review Request 123726: Make sure we load translations on the main thread.

. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 123726: Make sure we load translations on the main thread.

he documentation does say that). So you're right, QTimer is unnecessary. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123726/#review86861 ------

Review Request 125631: Fix ECMInstallIconsTest.

/expected-tree/v1-icons/crystalsvg/icon-theme.cache PRE-CREATION tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/icon-theme.cache PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125631/diff/ Testing --- `make test` now reports 100% tests passed. Thanks, Alex Merry

Re: Review Request 125375: Move FindAlsa from attic to find-modules

that needs it, I would suggest just shipping it directly in that project. ECM follows the "two or more users" rule in general - there needs to be two or more downstream users to justify shipping it in ECM. - Alex Merry On Sept. 24, 2015, 3:21 p.m., Boudhayan G

Re: Review Request 125163: Disable X11,XCB etc. detection on OS X

; wouldn't check for X11 on Windows. > > Martin Gräßlin wrote: > > @martin, can you share that list ? It could help speed things up to > build a full KDE on OS X > > sorry, I don't track them and wouldn't know how to find it quickly. In > the end I don't thi

Re: Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.

frozen to some degree. - Alex Merry On Sept. 15, 2015, 8:59 a.m., Raphael Kubo da Costa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125163: Disable X11,XCB etc. detection on OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125163/#review85403 --- Ship it! Ship It! - Alex Merry On Sept. 14, 2015, 8:21

Re: Review Request 125163: Disable X11,XCB etc. detection on OS X

. There's a month before the next release, so we can revisit the default setting if something comes up in the next few weeks, but I'm happy to have it in in the meantime. - Alex Merry On Sept. 12, 2015, 9:19 p.m., Samuel Gaist wrote

Re: Review Request 125163: Disable X11,XCB etc. detection on OS X

> On Sept. 14, 2015, 6:43 p.m., Alex Merry wrote: > > OK, consensus seems to be overwhelmingly positive. There's a month before > > the next release, so we can revisit the default setting if something comes > > up in the next few weeks, but I'm happy to have it in in the

Re: Review Request 125163: Disable X11,XCB etc. detection on OS X

> On Sept. 13, 2015, 9:52 a.m., Martin Gräßlin wrote: > > I'm in favor of the approach as this solves the problem that again and > > again [1] we have attempts of OSX-specific disabling of X11 in various > > frameworks and applications. > > > > The big problem on OSX seems to be that one

Re: Review Request 125139: Do not find XINPUT in FindXCB.cmake

> On Sept. 10, 2015, 5:42 p.m., Alex Merry wrote: > > I'm wary about this change as it technically breaks module compatibility. > > Specifically, upgrading e-c-m could cause packages that formerly built to > > suddenly stop building, and they wouldn't eve

Input from OS X developers wanted

Could OS X developers please give input on https://git.reviewboard.kde.org/r/125163/ ? I'm particularly interested in knowing whether building KF5-based software with X11 support on OS X (via homebrew or macports) is a thing people do. Alex ___

Re: Review Request 125163: Disable X11,XCB etc. detection on OS X

> On Sept. 12, 2015, 11:08 a.m., Alex Merry wrote: > > The new option needs documenting at the top of the file. > > > > I'd like to have other Mac users / porters providing some input, if > > possible. In what circumstances would it be useful to use the new option?

Re: Review Request 125163: Disable X11,XCB etc. detection on OS X

n the option/behaviour change was? You probably want to make this a list, as in: # - Uninstall target functionality since 1.7.0 # - ``APPLE_FORCE_X11`` option since 5.14.0 (detecting X11 was previously the default behaviour) - Alex Merry On Sept. 12, 2015, 8:44 p.m., Samuel

Re: Review Request 125139: Do not find XINPUT in FindXCB.cmake

> On Sept. 10, 2015, 5:42 p.m., Alex Merry wrote: > > I'm wary about this change as it technically breaks module compatibility. > > Specifically, upgrading e-c-m could cause packages that formerly built to > > suddenly stop building, and they wouldn't eve

Re: Review Request 125163: Disable X11,XCB etc. detection on OS X

of this)? - Alex Merry On Sept. 11, 2015, 2:45 p.m., Samuel Gaist wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125139: Do not find XINPUT in FindXCB.cmake

is not explicitly specifying components, then they are optional by default, so such a project will already need to cope in some way with XINPUT not being found (unless they are just letting `feature_summary` enforce the requirement). - Alex Merry On Sept. 10, 2015, 2:52 p.m., Martin Gräßlin wrote

Re: Review Request 125031: Disable -Wno-gnu-zero-variadic-macro-arguments when using clang

-modules/KDEFrameworkCompilerSettings.cmake (line 51) <https://git.reviewboard.kde.org/r/125031/#comment58810> Add a comment noting why we're disabling the warning. - Alex Merry On Sept. 2, 2015, 4:27 p.m., Alex Richardson

Re: Review Request 125031: Disable -Wno-gnu-zero-variadic-macro-arguments when using clang

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125031/#review85022 --- Ship it! Ship It! - Alex Merry On Sept. 2, 2015, 4:27 p.m

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

to the reviewers (or someone else familiar with Linux library packaging) to confirm that it won't cause compatilibity issues? - Alex Merry On Aug. 23, 2015, 1:02 p.m., Hanspeter Niederstrasser wrote: --- This is an automatically generated e-mail

Re: Review Request 124595: Add macro to generate logging category declarations for Qt5.

marked as submitted. Review request for Extra Cmake Modules and David Faure. Changes --- Submitted with commit 9bffa7a202cad3a29103f3e9a8b50b9a61277310 by Alex Merry to branch master. Repository: extra-cmake-modules Description --- This makes life a bit easier for developers who

Re: Review Request 124762: KDEFrameworkCompilerSettings: only enable strict iterators in debug mode

that it will now also apply to MSVC. - Alex Merry On Aug. 15, 2015, 11:17 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124762

Re: Review Request 124763: Add -pedantic for KF5 code (when using gcc or clang)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124763/#review83863 --- Ship it! Ship It! - Alex Merry On Aug. 15, 2015, 11:20

Re: Review Request 124595: Add macro to generate logging category declarations for Qt5.

--- On Aug. 3, 2015, 10:06 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124595/ --- (Updated Aug. 3, 2015

Re: Review Request 124595: Add macro to generate logging category declarations for Qt5.

/ECMQtDeclareLoggingCategory.rst PRE-CREATION modules/ECMQtDeclareLoggingCategory.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124595/diff/ Testing --- Added unit test runs and passes. Documentation builds and looks sane. Thanks, Alex Merry ___ Kde

Re: Review Request 124595: Add macro to generate logging category declarations for Qt5.

. Documentation builds and looks sane. Thanks, Alex Merry ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

  1   2   3   4   5   >