Re: Review Request: Make Dr.Konqi remember and showuse the time when the crash happend

2013-01-02 Thread George Kiagiadakis
://git.reviewboard.kde.org/r/107775/#comment18814 I am slightly worried about date time being in this fixed order and without any proper context for the translators. I'd at least put some context about %5 and %6 in the context comment (@info). Apart from that, everything else is fine. - George Kiagiadakis

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-23 Thread George Kiagiadakis
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/ --- (Updated Dec. 10, 2012, 8:16 a.m.) Review request for kde-workspace and George Kiagiadakis

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-10 Thread George Kiagiadakis
the bug reporting dialog using a saved backtrace file as input. Of course, it could be done in steps (first implement the logic to save the bt and exit, later implement the dialogs...); it would still be better than the current situation. - George Kiagiadakis On Dec. 10, 2012, 8:16 a.m

Re: Extra KDE Telepathy modules moving to Extragear

2012-04-29 Thread George Kiagiadakis
On Sun, Apr 29, 2012 at 2:34 PM, Sune Vuorela nos...@vuorela.dk wrote: On 2012-04-28, George Kiagiadakis kiagiadakis.geo...@gmail.com wrote: No, the classes that wrap GObjects do not need a d-pointer. All the calls are forwarded to the underlying GObject and if for any reason we ever need

Moving kxmlrpcclient to kdelibs

2012-04-29 Thread George Kiagiadakis
Hi, As I am about to commit [1] for 4.9, I'd like to conclude with what to do about the kxmlrpcclient library. As discussed on that review request, it looks like a good idea to move this library from kdepimlibs to kdelibs. Other options are to make kde-runtime depend on kdepimlibs or bundle

Re: Extra KDE Telepathy modules moving to Extragear

2012-04-28 Thread George Kiagiadakis
On Thu, Apr 26, 2012 at 11:07 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 25 d'abril de 2012, a les 18:15:00, David Edmundson va escriure: We would like to move 2 more KDE Telepathy modules to Extragear, to join our existing code. KTp Call UI [1] Provides a GUI for making video

Re: Exposing KSSL in KIO

2012-04-07 Thread George Kiagiadakis
On Sat, Apr 7, 2012 at 5:54 PM, Thiago Macieira thi...@kde.org wrote: On sábado, 7 de abril de 2012 14.25.10, Sune Vuorela wrote: On 2012-04-06, Thiago Macieira thi...@kde.org wrote: On sexta-feira, 6 de abril de 2012 01.14.34, David Edmundson wrote: I don't think so. The classes are likely

Re: Review Request: Fix Drkonqi to work with bugzilla 4 (partial port to xml-rpc)

2012-03-13 Thread George Kiagiadakis
on kdepimlibs and be done with it. David Faure wrote: You mean kdelibs-4.8, not 4.7. But 4.8.0 and 4.8.1 have been released already, so IMHO this is something for 4.9. Meanwhile we can use the duplication solution from this patch. George Kiagiadakis wrote: Yes, as I said I

Re: Review Request: Fix Drkonqi to work with bugzilla 4 (partial port to xml-rpc)

2012-03-09 Thread George Kiagiadakis
, visit: http://git.reviewboard.kde.org/r/104200/#review11252 --- On March 9, 2012, 12:45 a.m., George Kiagiadakis wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request: Fix Drkonqi to work with bugzilla 4 (partial port to xml-rpc)

2012-03-09 Thread George Kiagiadakis
On March 9, 2012, 11:31 a.m., George Kiagiadakis wrote: When there are no objections, I suggest to apply this to master to get more testing. Crash reporting does not work right now, so there is nothing that could break. If possible, this should also be committed to 4.7 branch later

Review Request: Fix Drkonqi to work with bugzilla 4 (partial port to xml-rpc)

2012-03-08 Thread George Kiagiadakis
/show_bug.cgi?id=294820 https://bugs4.kde.org/show_bug.cgi?id=294821 The duplicate search also seems to be working fine. Thanks, George Kiagiadakis

Re: KNotify-considerations for frameworks

2011-09-24 Thread George Kiagiadakis
On Fri, Sep 23, 2011 at 7:21 PM, Lubos Lunak l.lu...@suse.cz wrote: On Friday 23 of September 2011, George Kiagiadakis wrote: I agree with parts of this plan, but not all of them. I think we need to study more the use cases. Let's consider a few examples. ... 2) Your music player informs you

Re: KNotify-considerations for frameworks

2011-09-23 Thread George Kiagiadakis
On Fri, Sep 23, 2011 at 2:01 AM, Sune Vuorela nos...@vuorela.dk wrote: On 2011-09-22, Sune Vuorela nos...@vuorela.dk wrote: Currently, it is a quite complex framework that is hard to debug for the users of knotify (the application developers). It seems a bit overengineered, at least compared

Re: Review Request: DrKonqi uses a more flexible way to retrieve the version

2011-09-01 Thread George Kiagiadakis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102497/#review6206 --- Ship it! I like this. Html parsing-- :D

Re: Git migration status (Was: Re: Where is kmix hidden?)

2011-08-21 Thread George Kiagiadakis
On Sun, Aug 21, 2011 at 4:05 PM, Lukas Appelhans l.appelh...@gmx.de wrote: Hey! Cool... I see you go for a split up of kdenetwork (makes sense imo). The problem I see at the moment you have to build all applications together in kdenetwork, otherwise they fail to compile. So this is a first

Re: Review Request: Pass KAboutData::productName() to DrKonqi

2011-08-06 Thread George Kiagiadakis
/ --- (Updated Aug. 5, 2011, 11:24 p.m.) Review request for KDE Runtime, kdelibs, George Kiagiadakis, and Darío Andrés Rodríguez. Summary --- Some applications, such as muon and Calligra apps, specify a bugzilla product/component via the KAboutData

Re: Review Request: Show Version Fixed In if available, for reports marked as FIXED

2011-04-23 Thread George Kiagiadakis
: http://git.reviewboard.kde.org/r/101200/ --- (Updated April 23, 2011, 12:27 p.m.) Review request for KDE Runtime and George Kiagiadakis. Summary --- Use the Version Fixed In bugzilla field if it is available Diffs

Re: Review Request: Implement a dialog to show unhandled Bugzilla errors

2011-02-19 Thread George Kiagiadakis
and George Kiagiadakis. Summary --- Initial patch I created a dialog that will show the RAW Bugzilla HTML output when the response can't be parsed by DrKonqi. The user is encouraged to perform the action again later or save the HTML data to submit a DrKonqi bug. This function