Re: "Logout Screen" only shows shutdown when pressing the power button

Hi, I guess that’s the same issue I had where I had a leftover “default logout option” in settings, so the “Leave” screen defaulted to that option (e.g. only Shutdown) without the other options. Cheers Kai uwe Am 15.07.24 um 00:22 schrieb Nate Graham: That's not what's supposed to be happeni

Re: what to do with phonon & why aren't you using it?

Hi, like Android for which the traditional linux-based multimedia platforms like gstreamer or vlc don't work, or are very hard to get working properly. GStreamer seems the most comprehensive QML-capable framework on Android, too. At least I recall Eike having to use GStreamer for Kirogi (dro

Re: KJournald in KDE-Review

Hi, > in the left side filter area, there are tooltips, do you mean others? Oh, indeed, maybe I was too impatient with my mouse, I can see them now :) > Do you have a hint how to do this best? 😄 Since we should not use contextProperties anymore, I do not directly see how to avoid a proxy class.

Re: KJournald in KDE-Review

Hi, nice work! Here's some comments, nitpicks, etc on the code (might apply to other files than the one mentioned, too): * bootmodel.cpp: I don't think you need to call beginResetModel() when you populate it in the constructor * bootmodel.cpp: QAbstractListModel is a flat list with a single

Where to put Solid device action macro expander?

Hi everyone, Plasma's Device Notifier applet offers actions for devices, such as "open in file manager", "download images", "format partition" provided through Solid actions. Those are basically special desktop files with a predicate that Solid runs against your drives to determine whether the

Re: Git merge workflow: reverse it?

Hi, can we get an update on this? Plasma is full on cherry-pick now but in KDE Gear it's inconsistent and frustrating when some projects use cherry-pick (e.g. Kate) and some don't (e.g. Dolphin). I don't really mind what the outcome is but I need it to be consistent and predictable where to

Regression in remote thumbnail generation in KIO

Hi, I suggest we hold back the release briefly, revert [1] and respin KIO as to not release a version with a severe regression. Cheers Kai Uwe [1] https://invent.kde.org/frameworks/kio/-/merge_requests/617

Adding a MimeType without breaking existing associations

Hi everyone, the other day I noticed that Engrampa (MATE's archive viewer) could open some Windows EXE files so I could pull out self-extracting archive contents without running the executable. I found that this actually came from libarchive and was curious if flipping a switch in Ark could a

Re: Retiring

Hi Christoph, thank you so much for enduring work! I sometimes imagined me calling you on the phone Sunday morning at 5 am asking about some bug report that I vaguely remembered seeing but couldn't find and you immediately knew what I was talking about, spat out the 6 digit bug report number,

Re: Type=FSDevice desktop files

Hi, > Would it be OK if we dropped support for desktop files that represent devices? > This was a KDE1/KDE2/KDE3? feature, you'd write/ship a desktop file with Type=FSDevice and Dev=/dev/sdc and this would give you Mount and Unmount in the context menu. I believe macOS to this day automatica

Re: Urgent(ish) Contract KDE Developer availability?

Hi Bernard, Bug 418906 is actually already being worked on right now and should be fixed soon. See https://phabricator.kde.org/D28476 and https://phabricator.kde.org/D28488 Cheers Kai Uwe

Re: binary compatibility and qwidget::event

To avoid situations like [1] and [2] [1] https://cgit.kde.org/kiconthemes.git/commit/?id=1e9af6c54470e890597739f8f2189b0743a00b6f [2] https://cgit.kde.org/kiconthemes.git/commit/?id=083bb8a80fd5941e6fcbaf1ec12a08d8f8c881a5 Am 12.07.19 um 11:14 schrieb Harald Sitter: Hey our binary compatibi

Re: Tipping the apple cart?

Hi James, thanks for the info, that sounds great! I think the lack of context and bulk review are really my main issues. Other than that I can't think of any right now. I also only just now realized the filename shown in the mail is actually a deep-link to the actual comment. Cheers Kai Uwe

Re: Tipping the apple cart?

Hi, What are you missing? The description of the change (Review Board had that, Phabricator doesn't, so I got used to it, I guess...), the context of the comment (i.e. the code snippet a comment was added to), so I don't need to open GitLab to figure out what's going on. On Phabricator yo

Re: Tipping the apple cart?

Hi, > In our move to Gitlab, we can do better. Given Gitlab emails contain even less information and context than Phabricator which themselves contained even less information and context than Reviewboard back then, I don't see how this will change or improve anything. > Phab sends out an em

Re: liquidshell in kdereview

Hi, AppMenu.cxx: * You can use NoDotAndDotDot flag in entryInfoList() to already skip those * You seem to be using KFileItem and the url you generate just for isDesktopFile(), you could use KDesktopFile::isDesktopFile(), also the isDir() check could come before, a folder cannot be a desktop file

Re: Review Request 113587: Add support for x-gvfs style options in fstab

landed a long time ago. Itook your patch and ported it to Frameworks 5, please see the review at https://phabricator.kde.org/D5034 - Kai Uwe Broulik On Juni 22, 2014, 1:39 vorm., Stefan Brüns wrote: > > --- > This is an auto

Re: Review Request 128305: [KFind] Use KIO::highlightInFileManager

marked as submitted. Review request for KDE Base Apps. Changes --- Submitted with commit 5997228c0a129ea75dad1dd5264c681386793015 by Kai Uwe Broulik to branch frameworks. Repository: kde-baseapps Description --- This has the file manager open the parent folder(s), scroll to and

Review Request 128305: [KFind] Use KIO::highlightInFileManager

xcept that it'll result in just one file manager window now. Thanks, Kai Uwe Broulik

Re: web server for appstream metadata screenshots

Hi, I thought we agreed to keep artwork in SVN due to the penalty you get in Git when storing large blobs. However given Breeze stuff is entirely in Git now, ... Cheers,  Kai Uwe 

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

marked as submitted. Review request for KDE Base Apps and KDE Usability. Changes --- Submitted with commit 7d94f8ce772b04fb26d3d8c03c71d7770fcba45c by Kai Uwe Broulik to branch frameworks. Repository: kde-baseapps Description --- While searching the entire tab widget got disabled so

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

i Uwe Broulik On Mai 2, 2016, 7:04 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

/2016/05/02/d7d22fb6-c326-41c3-836a-4fa3bce8cc76__kfindafter.png Thanks, Kai Uwe Broulik

Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

s Before https://git.reviewboard.kde.org/media/uploaded/files/2016/05/02/7dfbde66-ded8-4881-b7d4-86ba253afae4__kfindbefore.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/05/02/d7d22fb6-c326-41c3-836a-4fa3bce8cc76__kfindafter.png Thanks, Kai Uwe Broulik

Re: [Kde-pim] Qt 4 Builds

Hi,> gwenview depends on baloo as well isn't Gwenview already released as kf5? At least I've been running it for years almost without a problem. Cheers, Kai Uwe 

Re: Open Folder and select file

Hi, I've been working on something exactly like this: https://git.reviewboard.kde.org/r/127004/ I want it to support Windows and OS X eventually, too. Haven't found the time lately to finish it yet, though.  Cheers,  Kai Uwe 

Re: KDE file dialog

Hi, > Distributions set up distribution-wide "Sans", "Serif" and "Monospace" > aliases for a reason. The fonts are carefully selected by the distribution > based on a variety of criteria, including glyph coverage We tried to keep font decisions to distributions before Plasma 5 and it always ma

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

> On Jan. 23, 2016, 1:22 nachm., Kai Uwe Broulik wrote: > > id isn't particularly better either as that's also a reserved QML keyword. > > > > Also, you can access any role with a name clash by accessing it through > > "model", ie. model.index

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

7;s also a reserved QML keyword. Also, you can access any role with a name clash by accessing it through "model", ie. model.index - Kai Uwe Broulik On Jan. 23, 2016, 1:14 nachm., Daniel Faust wrote: > > --- > This is an autom

Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls

inwindow.cpp (line 747) <https://git.reviewboard.kde.org/r/126627/#comment61929> .value(); app/mainwindow.cpp (line 760) <https://git.reviewboard.kde.org/r/126627/#comment61931> setArguments({mScreenSaverInhibitionCookie}) - Kai Uwe Broulik On Jan. 4, 2016, 8:07 nachm

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

> On Dez. 30, 2015, 2:52 nachm., Kai Uwe Broulik wrote: > > kdeui/notifications/knotificationrestrictions.cpp, line 50 > > <https://git.reviewboard.kde.org/r/125910/diff/2/?file=414354#file414354line50> > > > > Note that this string can be shown t

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

) <https://git.reviewboard.kde.org/r/125910/#comment61813> Note that this string can be shown to the user (we do this in Battery Monitor), so it should be a translatable proper string. - Kai Uwe Broulik On Dez. 29, 2015, 8:54 nachm., Johannes Stefan

Re: Review Request 102149: Improve Calculate/Stop buttons when folder Size is being calculated

s - kio/kfile/kpropertiesdialog.cpp ba56f18 Diff: https://git.reviewboard.kde.org/r/102149/diff/ Testing --- Compiles and the buttons toggle (and react) fine. Screenshots --- Screenshot of the dialog while it is calculating https://git.reviewboard.kde.org/r/102149/s/213/ Thanks, Kai Uwe Broulik

Re: Review Request 108442: [High-dpi issues] Fix KIconButton initial icon size and its occurence in KPropertiesDialog

size and font scales perfectly and looks good. See screenshot. File Attachments KPropertiesDialog with Retina settings https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png Thanks, Kai Uwe Broulik

Re: Review Request 110266: Cleanp Places Panel context menu

hments Comparison (left old, right new) https://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/kdelibsplaces.png Thanks, Kai Uwe Broulik

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

media/uploaded/files/2013/01/16/colorbigsizeafter.png Thanks, Kai Uwe Broulik

Re: Review Request 126204: kdialog: Implement new password dialog

tps://git.reviewboard.kde.org/r/126204/#comment60899> Don't abbreviate those - Kai Uwe Broulik On Nov. 30, 2015, 8:51 vorm., Andrew Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

AW: folder icons where should they be set

Hi, Aren't these XDG standard dirs you can even configure? Just show the folder at XDG images with a pictures folder icon and so on.  If you use different folders without telling the system, it's your own fault ;) Cheers,  Kai Uwe‎

Re: Review Request 124253: Resurrect dead code and fix two memory leaks

> On Juli 4, 2015, 4:18 nachm., Kai Uwe Broulik wrote: > > daemon/backends/upower/login1suspendjob.cpp, line 83 > > <https://git.reviewboard.kde.org/r/124253/diff/1/?file=383152#file383152line83> > > > > If you're at it, please change this to the new co

Re: Review Request 124253: Resurrect dead code and fix two memory leaks

/login1suspendjob.cpp (line 81) <https://git.reviewboard.kde.org/r/124253/#comment56401> If you're at it, please change this to the new connect syntax: connect(watcher, &QDBusPendingCallWatcher::finished, this, &Login1SuspendJob::sendResult); - Kai Uwe Broulik On Juli 4, 2015,

Re: Review Request 123806: [klipper] Ignore empty / blank entries

> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other option

Re: Review Request 123806: [klipper] Ignore empty / blank entries

tps://git.reviewboard.kde.org/r/123806/#comment55182> You could probably simplify that to m_ui.kcfg_WhitespacesAsSymbols->setEnabled(m_ui.kcfg_AllowWhitespaces->isChecked()); - Kai Uwe Broulik On Mai 16, 2015, 12:40 nachm., Patrick Eig

Re: Review Request 123806: [klipper] Ignore empty / blank entries

ld try to implement an option for this, > although I've never done this before and I would surely need some > assistance... > > Kai Uwe Broulik wrote: > I also sometimes copy whitespace but then I immediately paste it in, so I > wouldn't need it in the history, its

Re: Review Request 123806: [klipper] Ignore empty / blank entries

> On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: > > thanks for rebasing! > > > > I just had a look at the bug report and have to agree with comment #1: I do > > from time to time copy on purpose whitespaces (yes I'm weird). I also tend > > to copy newlines and I do want to have them in t

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

against plasma-workspace ;) - Kai Uwe Broulik On Mai 15, 2015, 6:33 nachm., Patrick Eigensatz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

tps://git.reviewboard.kde.org/r/123797/#comment55163> use .isEmpty() rather than string comparison plasma-workspace/klipper/historyitem.cpp (line 89) <https://git.reviewboard.kde.org/r/123797/#comment55164> return nullptr; - Kai Uwe Broulik On Mai 15, 2015, 2:24 nachm., Patri

Re: Distros and QtWebEngine

‎Note that QtQuick Text never uses RichText unless told, AutoText only enables StyledText when it finds something that looks like a tag before the first line break.    Originalnachricht   Von: Thomas Lübking Gesendet: Montag, 20. April 2015 23:27 An: Jeremy Whiting Cc: kdelibs Betreff: Re: Distr

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/#review79171 --- Please use the kdeframeworks group, kdelibs is 4.x - Kai Uwe

Re: Review Request 123169: Show percentage value beside brightness level slider

> On März 29, 2015, 6:34 nachm., Kai Uwe Broulik wrote: > > Thank you for this patch! > > > > However, we chose to remove the percentage from the brightness sliders in > > the battery monitor since you basically change the brightness to your > > liking a

Re: Review Request 123169: Show percentage value beside brightness level slider

percentage from the brightness sliders in the battery monitor since you basically change the brightness to your liking and not to some odd percentage, so adding them back in the PowerDevil settings doesn't make sense. - Kai Uwe Broulik On März 29, 2015, 9:42 vorm., Siddhartha Sahu

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

ttons and other elements do). File Attachments KPageDialog icon adapted https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconding.png Thanks, Kai Uwe Broulik

Re: Review Request 108312: Use view-certificate for SSL settings KCM

icon. Diffs - kio/kssl/kcm/kcm_ssl.desktop c1cebd6 Diff: https://git.reviewboard.kde.org/r/108312/diff/ Testing --- kbuildsycoca4 doesn't complain :-) Thanks, Kai Uwe Broulik

Re: Review Request 110084: Make ftp error messages prettier

/04/19/ftpmsgafter.png Thanks, Kai Uwe Broulik

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review73975 --- Ping? - Kai Uwe Broulik On Feb. 28, 2014, 1:53 nachm

Re: Review Request 121191: Use properly rounded brightness values in OSD

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121191/#review70709 --- There does not seem to be a patch applied. - Kai Uwe Broulik

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

out and then Ship it. Thanks! - Kai Uwe Broulik On Feb. 28, 2014, 1:53 nachm., Joschi Brauchle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 116522: Make KAboutDialog looks better under OSX

tps://git.reviewboard.kde.org//r/116522/#fcomment161> There is no way to send an E-Mail anymore? Mabye use a text link instead for all platforms and get rid of that misused toolbar button altogether. - Kai Uwe Broulik On March 1, 2014, 11:06 p.m., Yue Liu

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

Please always enclose, even one-liners, in curly braces: if (state == 1) { and below a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp <https://git.reviewboard.kde.org/r/116481/#comment36394> if (…) { - Kai Uwe Broulik On Feb. 28, 2014, 1:53 p.m.

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

tps://git.reviewboard.kde.org/r/115408/#comment34408> It also helped a lot if the icon size adjusted to pixel density of the screen / font dpi - Kai Uwe Broulik On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote: > > --- > This is a

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

> On Dec. 13, 2013, 2:27 p.m., Frank Reininghaus wrote: > > Thanks for looking into this, Dawit! I greatly appreciate this effort. > > > > > > Two questions come to my mind: > > > > 1. Why should these dialogs be modal at all? Everything that KIO does is > > asynchronous, so it could very wel

Re: Review Request 113885: 3 types of blur

ttp://git.reviewboard.kde.org/r/113885/#comment31524> Add a doxygen comment about the blurBehindEffect param tier1/kwindowsystem/src/kwindoweffects_x11.cpp <http://git.reviewboard.kde.org/r/113885/#comment31523> Unused include? - Kai Uwe Broulik On Nov. 15, 2013, 2:54 p.m., Marco

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

nt31041> Not needed, you're not scaling or transforming the images - Kai Uwe Broulik On Nov. 4, 2013, 8:22 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-

Re: Review Request 104222: Display recent documents in places bookmark by default

> On Oct. 27, 2013, 7:09 p.m., Kai Uwe Broulik wrote: > > Note that this needs similar adjustments in Dolphin [kde-baseapps] > > dolphin/src/panels/places/placesitemmodel.cpp then. Belay that, I guess showing "Recent places" in Dolphin isn't that needed. Sor

Re: Review Request 104222: Display recent documents in places bookmark by default

-baseapps] dolphin/src/panels/places/placesitemmodel.cpp then. - Kai Uwe Broulik On Oct. 27, 2013, 7:07 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

sample message http://git.reviewboard.kde.org/r/105304/s/606/ Thanks, Kai Uwe Broulik

Re: Review Request 108312: Use view-certificate for SSL settings KCM

- kio/kssl/kcm/kcm_ssl.desktop c1cebd6 Diff: http://git.reviewboard.kde.org/r/108312/diff/ Testing --- kbuildsycoca4 doesn't complain :-) Thanks, Kai Uwe Broulik

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

sample message http://git.reviewboard.kde.org/r/105304/s/606/ Thanks, Kai Uwe Broulik

Re: Review Request 113175: Always use an external viewer application to view files

. - Kai Uwe Broulik On Oct. 8, 2013, 3:13 p.m., Sven Brauch wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 112529: By default hide SMB shares that end with $

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/#review39399 --- There seems to be no patch attached - Kai Uwe Broulik On

Re: Review Request 111480: Notifications are shown multiple times

you could tell it to show the currently played track again. Imho this should somehow be fixed in Amarok, it is the only app I know that has this issue. - Kai Uwe Broulik On July 16, 2013, 12:01 p.m., Cedric Bellegarde wrote: > > ---

Re: Review Request 111480: Notifications are shown multiple times

ssage when working on a remote file won't appear anymore after the first save progress. - Kai Uwe Broulik On July 11, 2013, 1:54 p.m., Cedric Bellegarde wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

hould highlight the categories with new applications and the applications themselves, so, after they might drop out of the recently installed menu, the user already knows where to find them. - Kai Uwe Broulik On May 19, 2013, 9:41 p.m., Wolfgang Bauer

Re: Review Request 108442: [High-dpi issues] Fix KIconButton initial icon size and its occurence in KPropertiesDialog

e and font scales perfectly and looks good. See screenshot. File Attachments KPropertiesDialog with Retina settings http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png Thanks, Kai Uwe Broulik

Re: Review Request 110084: Make ftp error messages prettier

is > is "Error #421" or similar. > > More 2¢: > For more visual appeal i'd suggest to emphasize the upper (main) line (h2 > or maybe just b), get rid of the empty line(s? - trailing one) and ideally > get the close button top aligned (esp. since it almo

Re: Review Request 110084: Make ftp error messages prettier

is > is "Error #421" or similar. > > More 2¢: > For more visual appeal i'd suggest to emphasize the upper (main) line (h2 > or maybe just b), get rid of the empty line(s? - trailing one) and ideally > get the close button top aligned (esp. since it almo

Re: Review Request 110327: KMessageWidget: Remove decoration icon

> On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: > > The patch itself is fine and most likely does not introduce regressions in > > terms of misbehavior. > > > > Still, is never showing an icon the way to go? Another way to work around > > this by default would be an additional function ca

Re: Review Request 110084: Make ftp error messages prettier

:) File Attachments Before http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png After http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png Thanks, Kai Uwe Broulik

Re: Review Request 110266: Cleanp Places Panel context menu

trash' and 'removable media' should be moved into a > different panel Umm … Trash is something that's hard to access otherwise because it's not a really "physical" folder. Have you had a look at Dolphin's Places bar? There is a clear separation betw

Re: Review Request 110266: Cleanp Places Panel context menu

g/r/110266/#comment23765> Forgot to remove the label argument everywhere. (Wouldn't i18n normally spawn an I18N_EXCESS_ARGUMENTS then? weird.) - Kai Uwe Broulik On May 2, 2013, 8:05 a.m., Kai Uwe Broulik wrote: > > ---

Review Request 110266: Cleanp Places Panel context menu

file/kfileplacesview.cpp 117a9ed Diff: http://git.reviewboard.kde.org/r/110266/diff/ Testing --- Tested in the Open File dialog of Kolourpaint. Looks nice, works. File Attachments Comparison (left old, right new) http://git.reviewboard.kde.org/media/uploaded/files/20

Places panel context menu cleanup

Hi there, I've written a patch for Dolphin that de-clutters the Places panel context menu entries. Most entries redundandly contain the item's name and there are also menu entries that affect the general Panel behavior/look and feel (such as Icon Size) which are not available on the generic men

Re: Review Request 110084: Make ftp error messages prettier

ly, visit: http://git.reviewboard.kde.org/r/110084/#review31289 --- On April 19, 2013, 1:08 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. T

Review Request 110084: Make ftp error messages prettier

:) File Attachments Before http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png After http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png Thanks, Kai Uwe Broulik

Re: Review Request 108442: [High-dpi issues] Fix KIconButton initial icon size and its occurence in KPropertiesDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108442/#review27639 --- Ping? - Kai Uwe Broulik On Jan. 16, 2013, 6:18 p.m., Kai

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

> On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: > > instead of maintoolbar (which could be 128px on even a netbook) maybe > > relate it to the font height? (what seems to be the idea behind 22px) > > Kai Uwe Broulik wrote: > Main toolbar icon size is onl

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

> On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: > > instead of maintoolbar (which could be 128px on even a netbook) maybe > > relate it to the font height? (what seems to be the idea behind 22px) > > Kai Uwe Broulik wrote: > Main toolbar icon size is onl

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

> On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: > > instead of maintoolbar (which could be 128px on even a netbook) maybe > > relate it to the font height? (what seems to be the idea behind 22px) > > Kai Uwe Broulik wrote: > Main toolbar icon size is onl

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

> On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: > > instead of maintoolbar (which could be 128px on even a netbook) maybe > > relate it to the font height? (what seems to be the idea behind 22px) > > Kai Uwe Broulik wrote: > Main toolbar icon size is onl

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

> On July 12, 2012, 4:17 p.m., David Faure wrote: > > Looks good. For master only, though, given feature+message freeze in 4.9. > > Kai Uwe Broulik wrote: > Totally forgot to commit this :( Will do for master (4.10) once my ssh > key for my new notebook got imported. &

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

g/r/108504/#comment19799> I should've googl'd a bit more thorougly. Using q->setInitialSize works here :) - Kai Uwe Broulik On Jan. 20, 2013, 11:15 a.m., Kai Uwe Broulik wrote: > > --- > This is an automa

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

onfigurable icon sizes to > > "remotely" related views. > > That might be correct and intended, but it's also a behavioral change > > and this time, desktop icons /can/ be assigned to 256px through the GUI - > > even on a 72dpi screen - and that's unli

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108504/#review25844 --- On Jan. 20, 2013, 11:15 a.m., Kai Uwe Broulik wrote: > >

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

------ On Jan. 20, 2013, 11:15 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108504/ > ---

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

e minimumHeight to 4 rows and done. File Attachments Icon Dialog with 200dpi http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog.png Icon Dialog with 200dpi (without patch) http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog2.png T

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

g/r/108504/#comment19726> Didn't help here - Kai Uwe Broulik On Jan. 20, 2013, 11:13 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Review Request 108504: [High-dpi issues] Fix KIconDialog

ttachments Icon Dialog with 200dpi http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog.png Icon Dialog with 200dpi (without patch) http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog2.png Thanks, Kai Uwe Broulik

Review Request 108442: [High-dpi issues] Fix KIconButton initial icon size and its occurence in KPropertiesDialog

ialog with Retina settings http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png Thanks, Kai Uwe Broulik

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

> On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: > > instead of maintoolbar (which could be 128px on even a netbook) maybe > > relate it to the font height? (what seems to be the idea behind 22px) > > Kai Uwe Broulik wrote: > Main toolbar icon size is onl

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

ax'd in every row > > as well) > > > > ultimately in a second pass set all row heights, while probably even > > setting one would be sufficient > > Kai Uwe Broulik wrote: > minHeight is calculated by the Varies button which is the biggest element &

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

, 48, .. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108434/#review25636 --- On Jan. 16, 2013, 1:34 a.m., K

  1   2   >