D23348: force applicationDirPath into first position when finding plugins

sitter created this revision. sitter added reviewers: mpyne, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY applicationDirPath technically is already part of libraryPaths BUT it's position

D23344: assert slave command finality

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this changes existing qwarnings in state verification logic to be assertive in order

D23262: disable autouic again - it breaks builds

sitter added a comment. https://gitlab.kitware.com/cmake/cmake/issues/19615 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23262 To: sitter, apol, nicolasfella, cullmann Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D23262: disable autouic again - it breaks builds

This revision was automatically updated to reflect the committed changes. Closed by commit R240:557e5d898bf9: disable autouic again - it breaks builds (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23262?vs=64039=64042

D22805: set autorcc and autouic by default

sitter abandoned this revision. sitter added a comment. D23262 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol, nicolasfella Cc: cullmann, nicolasfella, cgiboudeaux, vkrause, kossebau, apol,

D23262: disable autouic again - it breaks builds

sitter created this revision. sitter added reviewers: apol, nicolasfella, cullmann. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY autouic (like automoc) assumes that

D22805: set autorcc and autouic by default

This revision was automatically updated to reflect the committed changes. Closed by commit R240:60ca1a27e539: set autorcc and autouic by default (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=64033=64037 REVISION

D22805: set autorcc and autouic by default

sitter updated this revision to Diff 64033. sitter added a comment. typo-- REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=64032=64033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 AFFECTED FILES

D22805: set autorcc and autouic by default

sitter updated this revision to Diff 64032. sitter added a comment. bump version again REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=62838=64032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 AFFECTED FILES

Re: Possible to move some KF5 frameworks to invent?

On Tue, Aug 13, 2019 at 12:54 PM Ben Cooksley wrote: > > On Mon, Aug 12, 2019 at 11:48 PM David Faure wrote: > > > > On lundi 12 août 2019 13:04:29 CEST Ben Cooksley wrote: > > > On Mon, Aug 12, 2019 at 10:54 PM Albert Vaca Cintora > > > > > > wrote: > > > > On Mon, Aug 12, 2019, 18:46 Ben

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. Well, we *could* land it, I am also not sure if that is a net-improvement though. As David said we are playing ping-pong with bugs and all of them are symptoms of the larger issue that error handling is done inconsistently, which in turn is why fixing one bug causes

Re: Possible to move some KF5 frameworks to invent?

On Mon, Aug 12, 2019 at 12:23 AM David Faure wrote: > > On dimanche 11 août 2019 22:14:19 CEST Albert Astals Cid wrote: > > without having your own fork of a repository, that is annoying for various > > reasons > > If creating a fork can be scripted, then that could be a fallback solution > (to

D20078: fix race on kcrash auto-restarts

This revision was automatically updated to reflect the committed changes. Closed by commit R271:5bf091ee07ac: fix race on kcrash auto-restarts (authored by sitter). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20078?vs=62840=63344 REVISION DETAIL

Re: KCrash crash racing

On Wed, Aug 7, 2019 at 7:17 PM Albert Astals Cid wrote: > > El dimecres, 7 d’agost de 2019, a les 16:36:31 CEST, Harald Sitter va > escriure: > > On Mon, Aug 5, 2019 at 10:58 PM Albert Astals Cid wrote: > > > > I am fairly out of ideas :/ > > > >

Re: KCrash crash racing

On Mon, Aug 5, 2019 at 10:58 PM Albert Astals Cid wrote: > > I am fairly out of ideas :/ > > Tried looking at what breakpad does? Breakpad does mostly what we do, technically, functionally it's not an "interactive" crash report while drkonqi is. Our simplified process: crash -> handler ->

Re: KCrash crash racing

On Mon, Aug 5, 2019 at 4:47 PM Aleix Pol wrote: > My impression is that relying on core handlers makes a lot of sense, > there would be some questions to answer such as "what happens when > running on other systems". Maybe for now we could try doing an > in-between? Handling cores on plasma and

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. In D22528#507373 , @dfaure wrote: > Is your work on a proper two-classes solution not ready? Nope, I haven't made any progress on it beyond what I posted. I briefly looked at a testing setup to make sure stuff

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

sitter removed a reviewer: sitter. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D19514 To: jpalecek Cc: bruns, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D15675: [sftp] Reformat sftpProtocol::GetRequest::GetRequest()

This revision was automatically updated to reflect the committed changes. Closed by commit R320:9890674aa265: [sftp] Reformat sftpProtocol::GetRequest::GetRequest() (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15675?vs=42243=63164#toc REPOSITORY R320 KIO Extras

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. @dfaure are we ok to land this for now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: rikmills, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D20078: fix race on kcrash auto-restarts

sitter added a comment. Yeah, was thinking the same thing :) REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20078 To: sitter, davidedmundson Cc: davidedmundson, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D20078: fix race on kcrash auto-restarts

sitter retitled this revision from "RFC fix race on kcrash auto-restarts" to "fix race on kcrash auto-restarts". sitter edited the test plan for this revision. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D20078 To: sitter Cc: davidedmundson, broulik,

D20078: RFC fix race on kcrash auto-restarts

sitter updated this revision to Diff 62840. sitter added a comment. clean up a bit REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20078?vs=54930=62840 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20078 AFFECTED FILES

D22805: set autorcc by default

sitter updated this revision to Diff 62838. sitter added a comment. document behavior and when it was introduced, also enable autouic REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=62729=62838 BRANCH master REVISION DETAIL

D22805: set autorcc and autouic by default

sitter retitled this revision from "set autorcc by default" to "set autorcc and autouic by default". sitter edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: vkrause, kossebau, apol,

KCrash crash racing

Moin Moin! I've been haunting down a nasty backtrace problem in drkonqi where it entirely fails to create a backtrace and am now fairly confident this is in fact a design flaw with kcrash, but I have no awesome ideas on how to solve this properly. Long story short: there is a space of time

D22805: set autorcc by default

sitter added a comment. Indeed, both good points. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22805: set autorcc by default

sitter added inline comments. INLINE COMMENTS > kossebau wrote in KDECMakeSettings.cmake:243 > Not sure if anyone is using cmake < 3.0 these days, but if, this will be a > surprise box to them, as with some biulds things work (where cmake >= 3.0) > and with some builds not. > > This needs

D22805: set autorcc by default

sitter edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22805: set autorcc by default

sitter created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY I couldn't find any pertinent discussion on the topic but some reviews I stumbled over did

D22687: KService: remove broken concept of global sycoca database

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Ohh that makes sense. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22687 To: dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron,

D22759: Fix infinite recursion when using a dummy DB because ksycoca is inaccessible

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22759 To: dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22687: KService: remove broken concept of global sycoca database

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. 1 ?? 0x770c0593 2 ??

D22687: KService: remove broken concept of global sycoca database

sitter added a comment. Mh, ksycocatest actually regressed for me. 2: * Start testing of KSycocaTest * 2: Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0) 2: QDEBUG :

D22687: KService: remove broken concept of global sycoca database

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22687 To: dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

Re: kbuildsycoca global in a modern world

On Sun, Jul 21, 2019 at 5:38 PM David Faure wrote: > > On mardi 16 juillet 2019 13:08:02 CEST Harald Sitter wrote: > > I was wondering if kbuildsycoca's global code still has a reason to exist. > > I wondered the same when I redesigned most of ksycoca some time ago, >

D22645: [Busy Indicator] Match duration of QQC2-desktop-style version

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH match-duration (branched from master) REVISION DETAIL https://phabricator.kde.org/D22645 To: ngraham, sitter, #vdg Cc: kde-frameworks-devel, cfeck, LeGast00n, sbergeron,

D22618: remove dangling remote widgets code

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a965fa4cb802: remove dangling remote widgets code (authored by sitter). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22618?vs=62210=62267

D22618: remove dangling remote widgets code

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY can't be enabled anywhere + not actually doing anything as there is no backing for it

D21795: [KAuth] Add support for action details in Polkit1 backend.

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. The way details are enumerated needs changing IMO. And this effectively bumps the required polkitqt version through exactly one call, so maybe an #if conditional to not have the

D22551: expose new KBusyIndicatorWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R298:92785f974d65: expose new KBusyIndicatorWidget (authored by sitter). REPOSITORY R298 KDesignerPlugin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22551?vs=62039=62157 REVISION DETAIL

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. Something like this https://phabricator.kde.org/P439 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. Hm. I've had a quick look and I think the intent was that only the slavebase overridden functions call error or finished. So technically all internal functions that can have an error need to set an iError or return one so that the "public" function can then issue

D22551: expose new KBusyIndicatorWidget

sitter created this revision. sitter added a reviewer: alexmerry. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY recently added to kwidgetsaddons TEST PLAN - shows up in desinger - can be added

D17595: Upstream Dolphin's file rename dialog

sitter added inline comments. INLINE COMMENTS > renamefiledialog.h:72 > +protected: > +void showEvent(QShowEvent* event) override; > + You'll also want to override `event` as per https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > renamefiledialog.h:75 >

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Looks good to me. The slave indeed must issue an exit state there. What email address would you like to have associated with the git commit? REPOSITORY R241 KIO REVISION DETAIL

Re: Meson logo

On Thu, Jul 18, 2019 at 12:38 PM Daniel Mensinger wrote: > > On Thu, 18 Jul 2019 12:18:43 +0200 > Harald Sitter wrote: > > > On Thu, Jul 18, 2019 at 8:46 AM Christophe Giboudeaux > > wrote: > > > > > > Hi, > > > > > > On mercredi 17 j

Re: Fw: Meson logo

On Thu, Jul 18, 2019 at 8:46 AM Christophe Giboudeaux wrote: > > Hi, > > On mercredi 17 juillet 2019 23:09:13 CEST Daniel Mensinger wrote: > > Hi, > > > > I am forwarding my original question about the meson trademark / > > license to kde-devel because I was told that more people with > >

Re: binary compatibility and qwidget::event

That makes sense. Thanks all! :) On Fri, Jul 12, 2019 at 1:09 PM Volker Krause wrote: > > On Friday, 12 July 2019 11:24:35 CEST Harald Sitter wrote: > > But why was that BIC to begin with? Which of the "don'ts" did it violate? > > IIUC re-implementing a virt

kbuildsycoca global in a modern world

Hey! I was wondering if kbuildsycoca's global code still has a reason to exist. The way I read the code a local kbuildsycoca would only reuse the global sycoca iff languages, prefixes and signatures are a match. But prefixes are not ever the same in any "default" or even reasonable scenario.

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

This revision was automatically updated to reflect the committed changes. Closed by commit R236:2631be903f94: new class KBusyIndicatorWidget similar to QtQuicks BusyIndicator (authored by sitter). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter updated this revision to Diff 61789. sitter added a comment. typos-- REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22375?vs=61659=61789 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22375 AFFECTED FILES

D22421: generate list of data files on the fly

This revision was automatically updated to reflect the committed changes. Closed by commit R264:a46504bdfcb3: generate list of data files on the fly (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22421?vs=61658=61781#toc REPOSITORY R264 KApiDox CHANGES SINCE

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter updated this revision to Diff 61659. sitter added a comment. - add simple example code + image - add @since tag - override event REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22375?vs=61603=61659 BRANCH master REVISION DETAIL

D22421: generate list of data files on the fly

sitter added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D22421 To: sitter, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, sbergeron, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D22421: generate list of data files on the fly

sitter created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous list was woefully insufficent and not including half the things necessary

Re: binary compatibility and qwidget::event

b0743a00b6f > [2] > https://cgit.kde.org/kiconthemes.git/commit/?id=083bb8a80fd5941e6fcbaf1ec12a08d8f8c881a5 > > Am 12.07.19 um 11:14 schrieb Harald Sitter: > > Hey > > > > our binary compatibility page [1] states that one should > > > > "reimplement event in QObjec

binary compatibility and qwidget::event

Hey our binary compatibility page [1] states that one should "reimplement event in QObject-derived classes, even if the body for the function is just calling the base class' implementation." Does anyone know the reason this helps maintain BC? [1]

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter updated this revision to Diff 61603. sitter added a comment. get rid of need for decl_hidden and extend the test to play with visiblity REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22375?vs=61522=61603 BRANCH master REVISION DETAIL

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter added inline comments. INLINE COMMENTS > broulik wrote in kbusyindicatorwidget.cpp:62 > Is that legal in the C++ standard allowed by frameworks? Well, it builds at least under c++11 which is what kf5 is compatible with. According to this page

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter updated this revision to Diff 61522. sitter marked 14 inline comments as done. sitter added a comment. - running property gone since we have no use case + simplified code since we no longer account for it - dropped superfluous virtual keywords - bumped duration to 1.5s - moved to

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter added inline comments. INLINE COMMENTS > broulik wrote in kbusyindicatorwidget.cpp:111 > How about `PM_LargeIconSize` Oh, that would work! > cfeck wrote in kbusyindicatorwidget.h:48 > Why is this property needed? If the (parent) widget is no longer busy, this > spinner needs to be

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter added inline comments. INLINE COMMENTS > broulik wrote in kbusyindicatorwidget.cpp:111 > Does this widget need a `sizeHint` of a button or default icon size or > something? I was thinking about it, and honestly I am not sure. I don't think we have access to anything to do with icon

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter created this revision. sitter added a reviewer: cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this mimics QQC's BusyIndicator and more specifically our styling of it. KBIW loads

D21894: set the focusPolicy of kpasswordlineedit to the policy of its proxy

This revision was automatically updated to reflect the committed changes. Closed by commit R236:1772904c2980: set the focusPolicy of kpasswordlineedit to the policy of its proxy (authored by sitter). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D21894: set the focusPolicy of kpasswordlineedit to the policy of its proxy

sitter created this revision. sitter added a reviewer: cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this is entirely the same kind of change as done in

D21780: Add X-Flatpak-RenamedFrom as recognized key

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM. I do not actually know why we need the type definition to begin with though, it occurs to me sycoca could/should just contain all keys it found in the desktop file since they

Re: KAuth helper in flatpak - was - Re: Smb4K flatpak build fails due to KAuth helper

On Mon, Jun 3, 2019 at 2:13 AM Stefan Brüns wrote: > SMB4K is a quite lowlevel system tool. There are tools which are too lowlevel > to package as flatpak/snap/appimage/whatever in a useful way That is not true. Certainly not for appimage and snap anyway, both offer operation without/limited

D21526: Add help-donate-[currency] icons

sitter accepted this revision. REPOSITORY R266 Breeze Icons BRANCH donate-currency (branched from master) REVISION DETAIL https://phabricator.kde.org/D21526 To: ndavis, #vdg, sitter, broulik, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21305: Add the FreeBSD default-path for os-release.

sitter added a comment. I do wonder if we couldn't just move the freebsd path to the end of the list and drop the ifdef. As far as linux is concerned we still obey the lookup order but simply have an additional path where we may look (and where the file should not ever exist on linux).

D21099: Use locale currency for donate icon

sitter added a comment. For obvious reasons I'd recommend only going for the major currencies :) I've had a quick look at a part of our website visits and the following currencies would be the most relevant based on that: 1. EUR 2. USD (this is actually the default icon so it's

D21100: don't glob everything and the kitchen sink

This revision was automatically updated to reflect the committed changes. Closed by commit R266:009608ce8e5d: dont glob everything and the kitchen sink (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21100?vs=57808=57809 REVISION

D21099: Use locale currency for donate icon

sitter added a comment. LGTM REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D21099 To: broulik, #frameworks, #vdg Cc: sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D21100: don't glob everything and the kitchen sink

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY we have two themes. glob the two themes and nothing else. otherwise when keeping the build directory in ./build/

D21079: make sure to also assert ScaledDirectories

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7e974fd48e0d: make sure to also assert ScaledDirectories (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21079?vs=57753=57754 REVISION

D21079: make sure to also assert ScaledDirectories

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY Directories and ScaledDirectories do the same thing, the latter is however used for backwards compatibility with old

D20955: use actually existing breeze icon for the new file Program.desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b127112914df: use actually existing breeze icon for the new file Program.desktop (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20955: use actually existing breeze icon for the new file Program.desktop

sitter edited the summary of this revision. sitter added reviewers: VDG, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20955 To: sitter, #vdg, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20955: use actually existing breeze icon for the new file Program.desktop

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the Icon entry in there was a legacy name that no longer exists. this resulted in the default new program having

D20092: New class KOSRelease - a parser for os-release files

This revision was automatically updated to reflect the committed changes. Closed by commit R244:1bedee3ca534: New class KOSRelease - a parser for os-release files (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20092?vs=55338=56813#toc REPOSITORY R244 KCoreAddons

D20693: Remove pixelated border

sitter added a comment. In D20693#454750 , @leinir wrote: > So yes, in principle i'd certainly like there to be some kind of background or outline to suggest clickability, but the current state (and any other generic rectangular background we

D20693: Remove pixelated border

sitter added a comment. LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion. @leinir lxr says a similar thumb is also used for some of the KAboutPerson stuff in kxmlgui. it may be prudent to also remove the thumb there, I expect it

D20225: use more appropriate plasma-specific icon for plasma category

This revision was automatically updated to reflect the committed changes. Closed by commit R252:bf27abdb08eb: use more appropriate plasma-specific icon for plasma category (authored by sitter). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D20092: New class KOSRelease - a parser for os-release files

sitter updated this revision to Diff 55338. sitter added a comment. - defaultFilePath is now static in the cpp only, the public ctor defaults to QString() for the filePath, which gets checked in the private ctor and diverted to defaultFilePath if necessary - Private ctor now copies

D20176: make start-here-kde also available start-here-kde-plasma

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9ff7e4658ded: make start-here-kde also available start-here-kde-plasma (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D20225: use more appropriate plasma-specific icon for plasma category

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY with D20176 landed we can now use the more appropriate icon variant for plasma

D20092: New class KOSRelease - a parser for os-release files

sitter added a subscriber: davidedmundson. sitter added a comment. The only relevant change in the history not from me is from @davidedmundson it seems. Dave, are you ok with changing the license from GPL to LGPL? https://phabricator.kde.org/R102:65e55f0b090247263bb3ba2b45615fa3b2ff1320

D20172: use plasma icon as icon for plasma notification category

This revision was automatically updated to reflect the committed changes. Closed by commit R252:8ce99b1637ef: use plasma icon as icon for plasma notification category (authored by sitter). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D20176: make start-here-kde also available start-here-kde-plasma

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the latter offers a less ambiguous name when we want to refer to something plasma specific. a recent example is D20172

D20172: use plasma icon as icon for plasma notification category

sitter added a comment. Oh, on a related note, I actually do wonder if we should symlink start-here-kde in breeze to start-here-kde-plasma and use that instead to differentiate? As per the spec on !breeze icon themes start-here-kde-plasma would fall back to start-here-kde if the plasma icon

D20172: use plasma icon as icon for plasma notification category

sitter retitled this revision from "use the plasma icon as plasma icon" to "use plasma icon as icon for plasma notification category". REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D20172 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham,

D20172: use the plasma icon as plasma icon

sitter added a comment. before F6742443: Screenshot_20190401_173503.png after F6742444: Screenshot_20190401_173529.png REPOSITORY R252 Framework Integration REVISION DETAIL

D20172: use the plasma icon as plasma icon

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY kde is the kde logo, start-here-kde is our app menu icon which is the plasma icon

D20092: New class KOSRelease - a parser for os-release files

sitter updated this revision to Diff 54993. sitter added a comment. - doc wording - disable cctor. no real use case for copy at this point REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20092?vs=54985=54993 BRANCH master REVISION DETAIL

Re: CI system maintainability

On Thu, Mar 28, 2019 at 3:57 PM David Jarvie wrote: > I agree. Mandatory reviews might work if there is a team of active people > working on a project, but if there is only one person with real knowledge of > the code We do have common ownership of code, so if there is only one person with

Re: CI system maintainability

On Thu, Mar 28, 2019 at 3:57 PM David Jarvie wrote: > I agree. Mandatory reviews might work if there is a team of active people > working on a project, but if there is only one person with real knowledge of > the code We do have common ownership of code, so if there is only one person with

Re: CI system maintainability

On Thu, Mar 28, 2019 at 3:57 PM David Jarvie wrote: > I agree. Mandatory reviews might work if there is a team of active people > working on a project, but if there is only one person with real knowledge of > the code We do have common ownership of code, so if there is only one person with

D20092: New class KOSRelease - a parser for os-release files

sitter added a reviewer: apol. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY Imported form KInfoCenter along with test case. This also includes a license change from GPL to LGPL. When working

D19850: Make AppStream generation opt-in

sitter added a comment. LGTM technically. Also looks crazy scary invasive though from a packaging POV :O What if a third party user of kpackage actively relied on the appstream data being auto-generated? Wouldn't this change in behavior essentially break backwards compatibility?

<    1   2   3   4   5   6   7   8   9   10   >