D13885: taglibextractor: Restore extracting audio props without tags existing

astippich updated this revision to Diff 37205. astippich added a comment. -fix the no-meta test case REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13885?vs=37148=37205 BRANCH fix_empty_tags REVISION DETAIL https://phabricator.kde.org/D13885

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich commandeered this revision. astippich edited reviewers, added: kossebau; removed: astippich. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13885 To: astippich, mgallien, michaelh, kossebau Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich added a comment. Sorry for causing the regressions and thanks for the fix! I just checked all the no-meta files. The reason that they did not cause the tests to fail is that they still have at least one tag defined that is not read (encoder settings for example). I think it

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. working fine here, but someone more qualified should have a look at the code REPOSITORY R244 KCoreAddons BRANCH d13583 REVISION DETAIL https://phabricator.kde.org/D13583 To:

D13700: implement reading of the replaygain tags

astippich added a comment. baloo handles floats actually just fine REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 36901. astippich added a comment. - use floats to store the replaygain tags REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=36571=36901 BRANCH replaygain REVISION DETAIL

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

astippich added a comment. Unfortunately it does not apply here because the base commit cannot be found. Also, may I already add an request? It would be great if the unit Hertz is included since it is used in baloo-widgets REPOSITORY R244 KCoreAddons REVISION DETAIL

D13700: implement reading of the replaygain tags

astippich added a comment. In D13700#282253 , @bruns wrote: > "dB" is nothing more than deci-Bel, i.e. 0.1 Bel. You can convert the value to e.g. mB or uB. This looks unfamiliar, but is e.g. also used by the CRDA WiFi compliance tool. I

D13700: implement reading of the replaygain tags

astippich retitled this revision from "implement the replaygain tags" to "implement reading of the replaygain tags". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D13700: implement the replaygain tags

astippich added a comment. I decided to store the values as string, including the "dB" unit. Another possibility would be to store them as floats, but this would require adjustments to baloo first. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To:

D13700: implement the replaygain tags

astippich created this revision. astippich added reviewers: mgallien, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the ability to read the

D13460: implement the lyrics tag for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:535de62bec16: implement the lyrics tag for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13460?vs=35941=36476

D12320: add ability to read embedded cover files

astippich added a comment. sorry for the caused inconvenience REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: bcooksley, dfaure, anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh,

D12320: add ability to read embedded cover files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:885616cee7a0: add ability to read embedded cover files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=35940=36219 REVISION

D13460: implement the lyrics tag for taglibextractor

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the ability to read the

D12320: add ability to read embedded cover files

astippich updated this revision to Diff 35940. astippich added a comment. - rebase again after test data changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=35934=35940 BRANCH cover_read REVISION DETAIL

D11874: change 24px view-media-artist icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:5218c83647ca: change 24px view-media-artist icon (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11874?vs=31124=35939 REVISION DETAIL

D12156: implement reading of rating tag

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0b0f2d2eb36d: implement reading of rating tag (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=35242=35938 REVISION DETAIL

D11874: change 24px view-media-artist icon

astippich added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874 To: astippich, #vdg, andreask Cc: kde-frameworks-devel, michaelh, ngraham, bruns,

D12320: add ability to read embedded cover files

astippich retitled this revision from "[RFC] add ability to read embedded cover files" to "add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni,

D12320: [RFC] add ability to read embedded cover files

astippich marked 8 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 35934. astippich added a comment. - implement feedback - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=34829=35934 BRANCH cover_read REVISION DETAIL https://phabricator.kde.org/D12320

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. Sorry, I meant Kf 5.47, so deadline on Saturday. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh,

D12156: implement reading of rating tag

astippich updated this revision to Diff 35242. astippich added a comment. - update comments REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=34398=35242 BRANCH rating REVISION DETAIL https://phabricator.kde.org/D12156 AFFECTED FILES

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. any more comments? would be nice to ship it with Kf 5.48 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov,

D12992: New elisa icon

astippich added a comment. In D12992#266673 , @mgallien wrote: > In D12992#266288 , @alex-l wrote: > > > F5863162: image.png > > > > ^ I'm for this one

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 34829. astippich added a comment. - simplify code REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=34012=34829 BRANCH cover_read REVISION DETAIL https://phabricator.kde.org/D12320 AFFECTED FILES

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. any more comments? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12156: implement reading of rating tag

astippich added a comment. any comments on the previous discussion? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12156: implement reading of rating tag

astippich updated this revision to Diff 34398. astippich added a comment. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. - rebase on master - implement rating tag for m4a REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12950: add test which checks the property types

astippich created this revision. astippich added reviewers: mgallien, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Check the type of the

D12932: handle string lists as input

This revision was automatically updated to reflect the committed changes. Closed by commit R293:03ab297f2512: handle string lists as input (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34323=34395 REVISION DETAIL

D12932: handle string lists as input

astippich added a comment. with D11365 applied (e.g. multiple entries are string lists) and using a file with multiple artists balooshow -x testmultiple.opus Bitrate: 67000 Channels: 1 Duration: 1 Genre:

D12932: handle string lists as input

astippich updated this revision to Diff 34323. astippich added a comment. - fix mistakes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34318=34323 BRANCH string_lists REVISION DETAIL https://phabricator.kde.org/D12932 AFFECTED FILES

D12932: handle string lists as input

astippich marked 4 inline comments as done. astippich added a comment. Thanks, and sorry, copied and pasted too quickly without thinking this through REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo,

D12932: handle string lists as input

astippich updated this revision to Diff 34318. astippich added a comment. - incorporate feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34314=34318 BRANCH string_lists REVISION DETAIL https://phabricator.kde.org/D12932 AFFECTED FILES

D12932: handle string lists as input

astippich added a comment. Unfortunately I couldn't find tests that execute this code path. Do we have test for this somewhere? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D12932: handle string lists as input

astippich created this revision. astippich added a reviewer: bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY handles string lists as inputs for

D12800: split tests for better readability

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0c738df2c2b7: split tests for better readability (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12800?vs=33935=34059 REVISION

D12801: search for album artist and albumartist tags in taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5b6caa0b118b: search for album artist and albumartist tags in taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. @anthonyfieroni The preview is actually working perfectly fine, my configuration was wrong. I swear I checked it before :) sorry for the noise REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien,

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. In D12320#260789 , @anthonyfieroni wrote: > In D12320#260768 , @astippich wrote: > > > Unfortunately, found it only after I wrote all that myself :/ > > > Sorry i

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 34012. astippich added a comment. - add an AllImages flag - add simple documentation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=33955=34012 BRANCH cover_read REVISION DETAIL

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. In D12320#260761 , @anthonyfieroni wrote: > I do *same* thing in KIO-Extras https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/audiocreator.cpp Yeah, I found that when I was looking into

D12320: [RFC] add ability to read embedded cover files

astippich marked 4 inline comments as done. astippich added a comment. Thanks a lot! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich,

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 33955. astippich added a comment. - fix usage of qflags - use unique_ptr REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=33934=33955 BRANCH cover_read REVISION DETAIL

D12801: search for album artist and albumartist tags in taglibextractor

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY album artist and albumartist tags

D12800: split tests for better readability

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY create separate test functions

D12320: [RFC] add ability to read embedded cover files

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > mgallien wrote in embeddedimagedata.h:40 > You should be using a std::unique_ptr instead of a raw pointer. You also > should take care of either forbidding copy (operator= and copy constructor) > or

D12320: [RFC] add ability to read embedded cover files

astippich retitled this revision from "{RFC] add ability to read embedded cover files" to "[RFC] add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo,

D12320: {RFC] add ability to read embedded cover files

astippich updated this revision to Diff 33934. astippich added a comment. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. - adjust to feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D11874: change 24px view-media-artist icon

astippich added a comment. ping @andreask REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874 To: astippich, #vdg, andreask Cc: #frameworks, michaelh, ngraham, bruns

D12156: implement reading of rating tag

astippich added a comment. I agree, there are several problems coming from the fact that we basically have two sources for the same property, which can potentially conflict. Btw, we already have the same issue with the comment property. In D12156#257888

D12156: implement reading of rating tag

astippich added a comment. ping @mgallien REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12320: {RFC] add ability to read embedded cover files

astippich added a comment. So, this is a next attempt trying to create a solution that works for everyone. It is not yet perfect, but I'd like to get some feedback if such an approach is favorable. A new class is created that will handle the cover art. This way, there won't be any

D12320: {RFC] add ability to read embedded cover files

astippich retitled this revision from "add ability to read embedded cover files" to "{RFC] add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov,

D12320: add ability to read embedded cover files

astippich updated this revision to Diff 33375. astippich added a comment. - new reader for embedded image data REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=32493=33375 BRANCH cover_read REVISION DETAIL

D12156: implement reading of rating tag

astippich added a comment. In D12156#252575 , @mgallien wrote: > If I have correctly understood the ideas behind the conception of Baloo, we should probably prefer to store the rating with a "native" solution instead of the xattr one that is

D12320: add ability to read embedded cover files

astippich added a comment. In D12320#249982 , @michaelh wrote: > -2 > https://cgit.kde.org/ffmpegthumbs.git/ should be useable, not sure though. It is also disqualified by the fact that it is not in frameworks. I think a nice solution

D12156: implement reading of rating tag

astippich added a comment. In D12156#249977 , @michaelh wrote: > In D12156#249971 , @astippich wrote: > > > In D12156#249951 , @michaelh wrote: > > >

D12156: implement reading of rating tag

astippich added a comment. In D12156#249951 , @michaelh wrote: > It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable? It will be used as a fallback when there is no

D12156: implement reading of rating tag

astippich added a comment. Those formulas didn't work with newly added tests with values from Winamp, Windows Media Player and MediaMonkey. I calculated a linear regression line and this one seems to work with some special case handling REPOSITORY R286 KFileMetaData REVISION DETAIL

D12156: implement reading of rating tag

astippich updated this revision to Diff 32591. astippich added a comment. - simplify REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=32587=32591 BRANCH rating REVISION DETAIL https://phabricator.kde.org/D12156 AFFECTED FILES

D12156: implement reading of rating tag

astippich added a comment. code didn't get prettier, but that's the de-facto standard REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12156: implement reading of rating tag

astippich updated this revision to Diff 32587. astippich added a comment. - implement reading of half star ratings for mp3 and add tests REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=31987=32587 BRANCH rating REVISION DETAIL

D12156: implement reading of rating tag

astippich added a comment. In D12156#249223 , @mgallien wrote: > Thanks. > Fix one issue and we should be good to go. > Another nice thing is that we should have a portable way to have ratings in Elisa that could be read or write somewhere

D12320: add ability to read embedded cover files

astippich added a comment. This revision is only one possibility and is mainly there to start the discussion again on how to read the embedded picture data from e.g. audio files. Before this can land, Baloo has to be patched in order to cope with binary data. I think for Baloo there are

D12320: add ability to read embedded cover files

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY read the embedded image of audio files

D11874: change 24px view-media-artist icon

astippich added a reviewer: andreask. astippich added a comment. ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874 To: astippich, #vdg, andreask Cc: #frameworks, michaelh, ngraham, bruns

D11820: Handle properties with multiple values

astippich added a comment. Seems to work just fine, see screenshot: F5808864: Screenshot_20180415_181027.png I did a little bit more testing, and in case you didn't already know: It looks like baloo outputs properties with multiple values as a

D11820: Handle properties with multiple values

astippich added a comment. Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with baloo-widgets, only with baloo itself. If there are still changes required in baloo-widgets, I

D12156: implement reading of rating tag

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12156: implement reading of rating tag

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY allows to read the rating stored in the

D10803: handle more tags in taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7f9de32eedff: handle more tags in taglibextractor (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10803?vs=30956=31950#toc REPOSITORY R286 KFileMetaData CHANGES

D10803: handle more tags in taglibextractor

astippich added a comment. ping. Can I push? I'm asking again because I don't want to mess up anything before the frameworks release, and this one contains string changes REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To:

D10803: handle more tags in taglibextractor

astippich added a comment. @mgallien this should be safe to land now since KF 5.45 has been tagged, right? REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure, michaelh,

D10803: handle more tags in taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, spoorun, bruns,

D11874: change 24px view-media-artist icon

astippich added a comment. Before F5781105: Screenshot_20180401_222839.png After F5781107: Screenshot_20180401_222817.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874

D11874: change 24px view-media-artist icon

astippich created this revision. astippich added a reviewer: VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY the 24px version of the view-media-artist icon is the only

D11365: also test for value types in taglibextractortest and fix errors

astippich planned changes to this revision. astippich added a comment. In D11365#236274 , @michaelh wrote: > This patch should be split. > > 1. Test more properties > 2. Change return types of ... > > Also 'fix errors' in the title is

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30956. astippich added a comment. - remove duplicate genre property for mp3 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30955=30956 BRANCH enhance_taglib REVISION DETAIL

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30955. astippich marked an inline comment as done. astippich added a comment. - fix formatting issues during rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30951=30955 BRANCH enhance_taglib

D10803: handle more tags in taglibextractor

astippich marked 3 inline comments as done. astippich added a comment. In D10803#237133 , @michaelh wrote: > Except for the white space stuff I'm still fine with this. Oops, sorry, messed that up during rebase. INLINE COMMENTS >

D10803: handle more tags in taglibextractor

astippich added a comment. Okay, I changed my mind, I rebased on top of master. Since the other revision needs more time and the new properties behave like the old ones, I'd like to end this long journey and land this revision if no-one objects :) REPOSITORY R286 KFileMetaData BRANCH

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30951. astippich added a comment. - update value types REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30950=30951 BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30950. astippich added a comment. - rebase on top of master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=28467=30950 BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803

D11461: rename 64 px icons added for elisa

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0f7c93f1b7e8: rename 64 px icons added for elisa (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11461?vs=29851=30869#toc REPOSITORY R266 Breeze Icons CHANGES SINCE

D10292: change 32px icons for playlist shuffle and repeat

This revision was automatically updated to reflect the committed changes. Closed by commit R266:f0a96f5f85cb: change 32px icons for playlist shuffle and repeat (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10292?vs=29110=30868

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Thanks a lot! REPOSITORY R266 Breeze Icons BRANCH playlist_shuffle_repeat REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: bcooksley, andreask, ngraham, #frameworks, michaelh

D11365: also test for value types in taglibextractortest and fix errors

astippich added inline comments. INLINE COMMENTS > mgallien wrote in taglibextractor.cpp:363 > Is it really needed to push directly a list ? > You are ignoring the fact that the original developer intended add to be > called once for each value. I would prefer to keep doing that until we can be

D10803: handle more tags in taglibextractor

astippich added a comment. All of a sudden :) I've been quiet about this because I'd like to resolve the issues regarding strings/stringlists first, so if you have some spare time, please have a look at D11365 . I will rebase after this one landed

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. It's just testing each file for all available properties, one after another. This revision just adds missing bits to the existing test. Refactoring should be done separately imho INLINE COMMENTS > michaelh wrote in propertyinfo.cpp:98 > Looks unrelated to me.

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. any feedback on this? I would like to land this and then get going with D10803 again REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Can I land this? phabricator doesn't show it as accepted though REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: andreask, ngraham, #frameworks, michaelh

D11461: rename 64 px icons added for elisa

astippich added a comment. any feedback here? would be great to resolve this for frameworks 5.45 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11461 To: astippich, #breeze, #vdg, andreask Cc: #frameworks, michaelh, ngraham

D11365: also test for value types in taglibextractortest and fix errors

astippich added reviewers: mgallien, michaelh. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11461: rename 64 px icons added for elisa

astippich created this revision. astippich added reviewers: Breeze, VDG, andreask. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY see D10492

D11457: decrease bitrate precision for display

This revision was automatically updated to reflect the committed changes. Closed by commit R824:e9f00ca876a2: decrease bitrate precision for display (authored by astippich). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11457?vs=29840=29849 REVISION

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. In D11365#227241 , @michaelh wrote: > Just in case you didn't use data-driven tests on purpose: https://doc.qt.io/qt-5/qttestlib-tutorial2-example.html Thanks for the hint, that's new for me. Anyways, there are

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. ping @andreask REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: andreask, ngraham, #frameworks, michaelh

<    4   5   6   7   8   9   10   >