Re: KDEReview for kio-s3

On 20/09/22 23:55, Albert Astals Cid wrote: El dimarts, 20 de setembre de 2022, a les 0:17:52 (CEST), Elvis Angelaccio va escriure: Hi all, I think kio-s3 [1] is now ready to go through the KDEReview process and get a first release. dfaure and sitter did a first code review in the original MR

Re: KDEReview for kio-s3

El dimarts, 20 de setembre de 2022, a les 0:17:52 (CEST), Elvis Angelaccio va escriure: > Hi all, > I think kio-s3 [1] is now ready to go through the KDEReview process and > get a first release. > > dfaure and sitter did a first code review in the original MR against > kio-extras [1]. The code

Re: kdereview Telly Skout

El dimarts, 10 de maig de 2022, a les 20:02:07 (CEST), Plata va escriure: > Hi, > > > thanks for the feedback. Please keep kde-core-devel in CC > > Yes, I've generally planned to support multiple sources (not only TV > Spielfilm). Do you have a particular one you'd like to have? Not

Re: kdereview Telly Skout

El dilluns, 9 de maig de 2022, a les 18:38:05 (CEST), Plata va escriure: > Hi, > > > after my TV guide application Telly Skout has been moved to > https://invent.kde.org/plasma-mobile/telly-skout, I'm asking for > kdereview (according to >

[DONE] Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

Hi, Am Samstag, 15. August 2020, 19:20:53 CEST schrieb Friedrich W. H. Kossebau: > what is markdownpart you ask? A KParts plugin allowing to view markdown > documents rendered e.g. in Kate's preview plugin, Ark, Krusader or > Konqueror, being mainly a wrapper around QTextDocument::setMarkdown & >

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

Am Samstag, 15. August 2020, 19:20:53 CEST schrieb Friedrich W. H. Kossebau: > Note: for now Qt 5.15-only, 5.14 possible but untested. BTW, thanks to feedback the min dependencies are now lowered to Qt 5.14 & KF 5.66. > I would like to propose markdownpart for a move into community maintenance

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

Am Freitag, 21. August 2020, 23:34:03 CEST schrieb Albert Astals Cid: > El dilluns, 17 d’agost de 2020, a les 23:04:44 CEST, Friedrich W. H. Kossebau va escriure: > > But not my call, after all I offer this to KDE community for adoption, sou > > your choice. > > I'm a bit concerned about this

Re: KDEReview for Kontrast

Le jeudi, juillet 30, 2020 11:16 AM, Carl Schwan a écrit : > Hi, > I would like to move Kontrast, a contrast checker application, to KDEReview. > Kontrast can check if two colors pass the WCAG 2.0 specification and save > some user's favorite color combinations. > > Some screenshots of the

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

El dilluns, 17 d’agost de 2020, a les 23:04:44 CEST, Friedrich W. H. Kossebau va escriure: > But not my call, after all I offer this to KDE community for adoption, sou > your choice. I'm a bit concerned about this being "abandonware" from birth, but seems there's relative interest from the

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

Ivan Čukić wrote: > markdownpartfactory.cpp:45 > > Personal preference - use `auto` when you have `= new Something(:::)` on > the right - no need for `Something` to be written twice: > Something* p = new Something(...) > > The variable part can even go away - just return new MarkdownPart. >

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

On 15/08/20 19:20, Friedrich W. H. Kossebau wrote: > Hi, > > what is markdownpart you ask? A KParts plugin allowing to view markdown > documents rendered e.g. in Kate's preview plugin, Ark, Krusader or Konqueror, > being mainly a wrapper around QTextDocument::setMarkdown & QTextBrowser. >

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

On 17/08/20 23:04, Friedrich W. H. Kossebau wrote: > Hi Elvis, > > Am Montag, 17. August 2020, 22:43:37 CEST schrieb Elvis Angelaccio: >> On 15/08/20 19:20, Friedrich W. H. Kossebau wrote: >>> Hi, >>> >>> what is markdownpart you ask? A KParts plugin allowing to view markdown >>> documents

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

Hi Elvis, Am Montag, 17. August 2020, 22:43:37 CEST schrieb Elvis Angelaccio: > On 15/08/20 19:20, Friedrich W. H. Kossebau wrote: > > Hi, > > > > what is markdownpart you ask? A KParts plugin allowing to view markdown > > documents rendered e.g. in Kate's preview plugin, Ark, Krusader or > >

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

Hi Ivan, Am Sonntag, 16. August 2020, 17:00:23 CEST schrieb Ivan Čukić: > Hi Friedrich, > > Very nice, thanks for doing this! Glad to see people liking it, so my time was more worth it :) And thank you for review. > These are the few nit-picks (feel free to ignore them) I have: Nitpicks are

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

Hi Friedrich, Very nice, thanks for doing this! These are the few nit-picks (feel free to ignore them) I have: markdownview.cpp:55 The `hasSelection` variable makes the code look much more complex than it is. It can be removed and the last argument of the `Q_EMIT contextMenuRequested` call

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

Am Sonntag, 16. August 2020, 00:03:53 CEST schrieb David Faure: > The code looks fine to me. Thanks for review. > The only thing I saw was case-insensitive comparison of the result of > QUrl::scheme() which is unnecessary, it always returns lowercase. Ah, was not aware (and missed the

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

On samedi 15 août 2020 19:20:53 CEST Friedrich W. H. Kossebau wrote: > Hi, > > what is markdownpart you ask? A KParts plugin allowing to view markdown > documents rendered e.g. in Kate's preview plugin, Ark, Krusader or > Konqueror, being mainly a wrapper around QTextDocument::setMarkdown & >

Re: KDEReview for Kontrast

The odd naming is a flatpac requirement if you want the icon auto extracted. Otherwise flatpac will have to be told explicitly to rename the icon. On Tue, Aug 11, 2020, 3:38 AM Christophe Giboudeaux wrote: > On lundi 3 août 2020 23:12:25 CEST Albert Astals Cid wrote: > > > I added the icon and

Re: KDEReview for Kontrast

Le lundi, août 3, 2020 11:12 PM, Albert Astals Cid a écrit : > El dilluns, 3 d’agost de 2020, a les 4:26:25 CEST, Carl Schwan va escriure: > > > Le dimanche, août 2, 2020 6:20 PM, Albert Astals Cid aa...@kde.org a écrit : > > > > > El dijous, 30 de juliol de 2020, a les 11:16:25 CEST, Carl

Re: KDEReview for Kontrast

On lundi 3 août 2020 23:12:25 CEST Albert Astals Cid wrote: > > I added the icon and I hope I installed it to the correct location: > > https://invent.kde.org/accessibility/kontrast/-/commit/8a008c1387c0234d5e > > 1d537bdd331007d7b1ff07. It was already stored in breeze-icons but I guess > > it is

Re: KDEReview for Kontrast

El dilluns, 3 d’agost de 2020, a les 4:26:25 CEST, Carl Schwan va escriure: > Le dimanche, août 2, 2020 6:20 PM, Albert Astals Cid a écrit : > > > El dijous, 30 de juliol de 2020, a les 11:16:25 CEST, Carl Schwan va > > escriure: > > > > > Hi, > > > I would like to move Kontrast, a contrast

Re: KDEReview for Kontrast

Le dimanche, août 2, 2020 6:20 PM, Albert Astals Cid a écrit : > El dijous, 30 de juliol de 2020, a les 11:16:25 CEST, Carl Schwan va escriure: > > > Hi, > > I would like to move Kontrast, a contrast checker application, to KDEReview > > Kontrast can check if two colors pass the WCAG 2.0

Re: KDEReview for Kontrast

Le dimanche, août 2, 2020 2:58 PM, Nate Graham a écrit : > Hello Carl, > This looks very useful! Overall I'd say the UI is good. One thing I find > myself missing while playing around is the ability to test system > colorschemes though. That would be a really nice addition. I'm not sure this

Re: KDEReview for Kontrast

Carl Schwan https://carlschwan.eu ‐‐‐ Original Message ‐‐‐ Le dimanche, août 2, 2020 3:36 PM, Nicolas Fella a écrit  : > Hi Carl, > > a couple of nitpicks, otherwise looks neat. > > - your CMakeLists.txt does not specify a minimum Qt/KF5 version. Also > ECM 0.0.8 is likely

Re: KDEReview for Kontrast

On 8/2/20 8:29 PM, Carl Schwan wrote: Le dimanche, août 2, 2020 2:58 PM, Nate Graham a écrit : Hello Carl, This looks very useful! Overall I'd say the UI is good. One thing I find myself missing while playing around is the ability to test system colorschemes though. That would be a really

Re: KDEReview for Kontrast

El dijous, 30 de juliol de 2020, a les 11:16:25 CEST, Carl Schwan va escriure: > Hi, > I would like to move Kontrast, a contrast checker application, to KDEReview > Kontrast can check if two colors pass the WCAG 2.0 specification and save > some user's favorite color combinations. > > Some

Re: KDEReview for Kontrast

Hi Carl, a couple of nitpicks, otherwise looks neat. - your CMakeLists.txt does not specify a minimum Qt/KF5 version. Also ECM 0.0.8 is likely quite old and a bit optimistic - Setting CMAKE_CXX_STANDARD to 11 is implicitly done by ECM, no need to do that manually. It also contradicts the

Re: KDEReview for Kontrast

Hello Carl, This looks very useful! Overall I'd say the UI is good. One thing I find myself missing while playing around is the ability to test system colorschemes though. That would be a really nice addition. Nate On 7/30/20 3:16 AM, Carl Schwan wrote: Hi, I would like to move Kontrast, a

Re: kdereview - qtcurve

​> For the record, I also asked Yichao to have a look at a comment one of our This issue has been resolved. At which point, I think we're good to move? Any final objections?

Re: kdereview

On 28 September 2016 at 10:17, Ben Cooksley wrote: > On Wed, Sep 28, 2016 at 8:20 AM, Burkhard Lück wrote: >> Am Mittwoch, 21. September 2016, 11:01:18 CEST schrieb Allen Winter: >>> I suggest we remove bodega-client, kdev-perforce, kdots, kor and kpeg

Re: kdereview - qtcurve

On Wed, Jun 21, 2017 at 5:06 PM, Jonathan Riddell wrote: > On 16 June 2017 at 16:07, Yichao Yu wrote: > > QtCurve is now in kdereview with the intention of being in extragear/base > > You should set the stable branch to 1.9 in repo-metadata and ask >

Re: kdereview - qtcurve

-- Forwarded message -- From: "David Edmundson" <da...@davidedmundson.co.uk> Date: 4 Jul 2017 08:23 Subject: Re: kdereview - qtcurve To: "Albert Astals Cid" <aa...@kde.org> Cc: > Not fixed for me https://paste.kde.org/pzgvpred2 > > Th

Re: kdereview - qtcurve

El dijous, 22 de juny de 2017, a les 16:07:01 CEST, David Edmundson va escriure: > On Mon, Jun 19, 2017 at 11:42 PM, Albert Astals Cid wrote: > > El divendres, 16 de juny de 2017, a les 11:07:19 CEST, Yichao Yu va > > > > escriure: > > > QtCurve is now in kdereview with the

Re: kdereview - qtcurve

El divendres, 16 de juny de 2017, a les 11:07:19 CEST, Yichao Yu va escriure: > QtCurve is now in kdereview with the intention of being in extragear/base For the record, I also asked Yichao to have a look at a comment one of our translators did in the i18n mailing list (via a CC'ing), haven't

Re: kdereview - qtcurve

On Mon, Jun 19, 2017 at 11:42 PM, Albert Astals Cid wrote: > El divendres, 16 de juny de 2017, a les 11:07:19 CEST, Yichao Yu va > escriure: > > QtCurve is now in kdereview with the intention of being in extragear/base > > By default it assumes i want a Qt4 build and then fails

Re: kdereview - qtcurve

On 16 June 2017 at 16:07, Yichao Yu wrote: > QtCurve is now in kdereview with the intention of being in extragear/base You should set the stable branch to 1.9 in repo-metadata and ask translator admins to make a stable branch for translations Jonathan

Re: kdereview - qtcurve

> What do you need kdelibs4support for in the qt5 code? Nothing that couldn't be ported long term, but it does currently use KMimeData, KStandardDirs and KFileDialog.

Re: kdereview - qtcurve

El divendres, 16 de juny de 2017, a les 11:07:19 CEST, Yichao Yu va escriure: > QtCurve is now in kdereview with the intention of being in extragear/base By default it assumes i want a Qt4 build and then fails because i don't have the necessary packages. Maybe it could be a bit gentler and just

Re: kdereview: qqc2-desktop-style

On Thu, May 18, 2017 at 11:08 AM, Marco Martin wrote: > Hi all, > I'm anouncing the QtQuickControls2 desktop style in kdereview, repo name is > qqc2-desktop-style > > It is intended to be a small style written in QML for QtQuickControls2 that is > intended to be used by default

Re: kdereview: ksmtp

Hi Rolf, thanks for the review, sorry it took me so long to get to you. On Tuesday, May 16, 2017 8:05:17 PM CEST Rolf Eike Beer wrote: > Am Donnerstag, 11. Mai 2017, 17:03:01 schrieb Daniel Vrátil: > > Hi, > > > > please review ksmtp, which is now in kdereview. > > -the CMakeLists.txt has a

Re: kdereview: qqc2-desktop-style

On Sun, May 21, 2017 at 7:16 PM, Albert Astals Cid wrote: > if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_BINARY_DIR}") >message(FATAL_ERROR "climbinggrades bla bla bla.") > endif() > > This is not climbinggrades ;) thanks, fixed -- Marco Martin

Re: kdereview: qqc2-desktop-style

El dijous, 18 de maig de 2017, a les 11:08:42 CEST, Marco Martin va escriure: > Hi all, > I'm anouncing the QtQuickControls2 desktop style in kdereview, repo name is > qqc2-desktop-style > > It is intended to be a small style written in QML for QtQuickControls2 that > is intended to be used by

Re: kdereview: ksmtp

Am Donnerstag, 11. Mai 2017, 17:03:01 schrieb Daniel Vrátil: > Hi, > > please review ksmtp, which is now in kdereview. -the CMakeLists.txt has a mix of spaces inside () or not -in loginjob, line 173, you check for code 25. Should this be 250? Or is that 25*? Where is ServerResponse actually

Re: kdereview: ksmtp

On Thursday, May 11, 2017 11:11:11 PM CEST Albert Astals Cid wrote: > El dijous, 11 de maig de 2017, a les 17:03:01 CEST, Daniel Vrátil va escriure: > > Hi, > > > > please review ksmtp, which is now in kdereview. > > Are tests supposed to pass? > > 2: QFATAL : SmtpTest::testLoginJob(Plain auth

Re: kdereview - xdg-desktop-portal-kde

Hi, thank you so much for the review!! On pátek 12. května 2017 13:21:00 CEST Lamarque Souza wrote: > Hi, > > My review: > > . there are several code style inconsistencies, like "QDialog* parent" and > "Ui::AppChooserDialog * m_dialog". In some places you use app_id while in > other places you

Re: kdereview - xdg-desktop-portal-kde

Hi, My review: . there are several code style inconsistencies, like "QDialog* parent" and "Ui::AppChooserDialog * m_dialog". In some places you use app_id while in other places you use appId. . you use 0 in same places that you should use nullptr. . there is no doxygen documentation at all. .

Re: kdereview - xdg-desktop-portal-kde

Hi, it's been now three weeks and nobody either looked at the code or found any problem and raised objections. Can we proceed next and move this to place where is the rest of Plasma repositories? Or is there a longer period for which I have to wait until this can move on? Regards, Jan On

Re: kdereview: ksmtp

El dijous, 11 de maig de 2017, a les 17:03:01 CEST, Daniel Vrátil va escriure: > Hi, > > please review ksmtp, which is now in kdereview. Are tests supposed to pass? 2: QFATAL : SmtpTest::testLoginJob(Plain auth ok) Received signal 11 Cheers, Albert > > KSMTP is a small simple library with

Re: kdereview: ksmtp

Thanks, totally forgot to run clazy/krazy on the codebase. On Thursday, May 11, 2017 10:25:36 PM CEST Allen Winter wrote: > ran clazy level2 . no hits > > ran krazy checks and it found: > . Check for C++ ctors that should be declared 'explicit' [explicit]... 1 > issue found

Re: kdereview - xdg-desktop-portal-kde

On mercoledì 3 maggio 2017 13:11:26 CEST Jan Grulich wrote: > On středa 3. května 2017 11:28:45 CEST Elvis Angelaccio wrote: > > On mercoledì 3 maggio 2017 07:00:14 CEST Jan Grulich wrote: > > > > > > > Do you have xdg-desktop-portal installed? > > > > > > > > > > > > Yes. > > > > > > > > > >

Re: kdereview - xdg-desktop-portal-kde

On mercoledì 3 maggio 2017 07:00:14 CEST Jan Grulich wrote: > > > > > > > > > > Do you have xdg-desktop-portal installed? > > > > > > > > Yes. > > > > > > Make sure that xdg-desktop-portal is running, it should be started > > > automatically by flatpak, but you never know. > > > > How do I

Re: kdereview - xdg-desktop-portal-kde

On martedì 2 maggio 2017 17:26:41 CEST Jan Grulich wrote: > On úterý 2. května 2017 15:22:23 CEST Elvis Angelaccio wrote: > > On Tue, May 2, 2017 at 3:09 PM, Jan Grulich wrote: > > > On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote: > > >> On Tue, May 2, 2017 at

Re: kdereview - xdg-desktop-portal-kde

On středa 3. května 2017 11:28:45 CEST Elvis Angelaccio wrote: > On mercoledì 3 maggio 2017 07:00:14 CEST Jan Grulich wrote: > > > > > > Do you have xdg-desktop-portal installed? > > > > > > > > > > Yes. > > > > > > > > Make sure that xdg-desktop-portal is running, it should be started > > > >

Re: kdereview - xdg-desktop-portal-kde

On úterý 2. května 2017 23:58:20 CEST you wrote: > On martedì 2 maggio 2017 17:26:41 CEST Jan Grulich wrote: > > On úterý 2. května 2017 15:22:23 CEST Elvis Angelaccio wrote: > > > On Tue, May 2, 2017 at 3:09 PM, Jan Grulich wrote: > > > > On úterý 2. května 2017 14:19:04

Re: kdereview - xdg-desktop-portal-kde

On Tue, May 2, 2017 at 3:09 PM, Jan Grulich wrote: > On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote: >> On Tue, May 2, 2017 at 12:36 PM, Jan Grulich wrote: >> > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote: >> >> On Tue, May 2,

Re: kdereview - xdg-desktop-portal-kde

On Tue, May 2, 2017 at 12:36 PM, Jan Grulich wrote: > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote: >> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid wrote: >> > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va > escriure: >> >>

Re: kdereview - xdg-desktop-portal-kde

On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote: > On Tue, May 2, 2017 at 12:36 PM, Jan Grulich wrote: > > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote: > >> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid wrote: > >> > El dimarts, 2

Re: kdereview - xdg-desktop-portal-kde

On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote: > On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid wrote: > > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va escriure: > >> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote: > >> > El

Re: kdereview - xdg-desktop-portal-kde

On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid wrote: > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va escriure: >> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote: >> > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va >>

Re: kdereview - xdg-desktop-portal-kde

El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va escriure: > On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote: > > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va > > escriure: > > > Hi, > > > > > > I would like to request review of

Re: kdereview - xdg-desktop-portal-kde

On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote: > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va escriure: > > Hi, > > > > I would like to request review of xdg-desktop-portal-kde [1]. We would > > like > > to make it part of Plasma releases, see [2]. > >

Re: kdereview - xdg-desktop-portal-kde

El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va escriure: > Hi, > > I would like to request review of xdg-desktop-portal-kde [1]. We would like > to make it part of Plasma releases, see [2]. > > What is xdg-desktop-portal-kde: > It's a KDE implementation of Flatpak portals

Re: kdereview

Ben Cooksley ha scritto: > On Sat, Oct 1, 2016 at 10:49 AM, Albert Astals Cid wrote: >> El divendres, 30 de setembre de 2016, a les 21:17:56 CEST, Ben Cooksley va >> escriure: >>> On Fri, Sep 30, 2016 at 11:27 AM, Albert Astals Cid wrote: El dimecres, 21 de

Re: kdereview

On Sat, Oct 1, 2016 at 10:49 AM, Albert Astals Cid wrote: > El divendres, 30 de setembre de 2016, a les 21:17:56 CEST, Ben Cooksley va > escriure: >> On Fri, Sep 30, 2016 at 11:27 AM, Albert Astals Cid wrote: >> > El dimecres, 21 de setembre de 2016, a les 11:01:18

Re: kdereview

El divendres, 30 de setembre de 2016, a les 21:17:56 CEST, Ben Cooksley va escriure: > On Fri, Sep 30, 2016 at 11:27 AM, Albert Astals Cid wrote: > > El dimecres, 21 de setembre de 2016, a les 11:01:18 CEST, Allen Winter va > > > > escriure: > >> kwave is now moved to

Re: kdereview

On Fri, Sep 30, 2016 at 11:27 AM, Albert Astals Cid wrote: > El dimecres, 21 de setembre de 2016, a les 11:01:18 CEST, Allen Winter va > escriure: >> kwave is now moved to kdemultimedia. > > Why did that happen? It was moved at the request of it's maintainer and Allen. > > Did i

Re: kdereview

El dimecres, 21 de setembre de 2016, a les 11:01:18 CEST, Allen Winter va escriure: > kwave is now moved to kdemultimedia. Why did that happen? Did i miss the emails to k-c-d about reviewing it? Cheers, Albert > No response from anyone else. > > I suggest we remove bodega-client,

Re: kdereview

On Wed, Sep 28, 2016 at 9:06 AM, Allen Winter wrote: > On Tuesday, September 27, 2016 09:20:32 PM Burkhard Lück wrote: >> Am Mittwoch, 21. September 2016, 11:01:18 CEST schrieb Allen Winter: >> > I suggest we remove bodega-client, kdev-perforce, kdots, kor and kpeg from >> >

Re: kdereview

Il 27 settembre 2016 22:06:35 CEST, Allen Winter ha scritto: >On Tuesday, September 27, 2016 09:20:32 PM Burkhard Lück wrote: >> Am Mittwoch, 21. September 2016, 11:01:18 CEST schrieb Allen Winter: >> > I suggest we remove bodega-client, kdev-perforce, kdots, kor and >kpeg from >>

Re: kdereview

On Tuesday, September 27, 2016 09:20:32 PM Burkhard Lück wrote: > Am Mittwoch, 21. September 2016, 11:01:18 CEST schrieb Allen Winter: > > I suggest we remove bodega-client, kdev-perforce, kdots, kor and kpeg from > > kde_projects.xml and virtually move them into scratch. > > Any objections to

Re: kdereview

Morten Volden ha scritto: > Hi Allen > > Sorry for the late reply. > > kdev-perforce has already been moved to into kdevplatform (So I guess that > qualifies as it passing review.). Does it mean that the code was merged inside the kdevplatform repository? But then you did not add the

Re: kdereview

On Wednesday, 21 September 2016 11:01:18 CEST Allen Winter wrote: > kwave is now moved to kdemultimedia. > No response from anyone else. > > I suggest we remove bodega-client, kdev-perforce, kdots, kor and kpeg from > kde_projects.xml and virtually move them into scratch. More than "remove",

Re: kdereview

kwave is now moved to kdemultimedia. No response from anyone else. I suggest we remove bodega-client, kdev-perforce, kdots, kor and kpeg from kde_projects.xml and virtually move them into scratch. On Sunday, September 18, 2016 12:08:41 PM Allen Winter wrote: > Howdy, > > there's some stuff

Re: KDEReview: Nepomuk-Controller QML

I guess which icons are shown in the system tray is a setting of the system tray applet, no? Yes but I have now a proper plasma update script, so this issue should be solved now. The script will be installed by default so any user should be updated correctly

Re: KDEReview: Nepomuk-Controller QML

I'd say the Messages.sh pot filename are wrong for both the dataengine and the applet. Please confirm with the plasma developers what's the catalog name that will be loaded but yours doesn't seem to follow the pattern. I see, the i18n techbase article says every qml app needs plasma_applet_

Re: KDEREVIEW: StackFolder plasma applet

On Wed, Dec 12, 2012 at 5:30 PM, Jos Poortvliet j...@opensuse.org wrote: On Wednesday 07 November 2012 13:24:30 Ural Mullabaev wrote: Hello all! Let me introduce you our applet - StackFolder. It has been moved to kdereview to get into kdeplasma-addons. StackFolder is a plasmoid that provides

Re: KDEReview: Nepomuk-Controller QML

On Wednesday, 2013-03-27, Jörg Ehrichs wrote: Assuming this setting is stored in some KConfig based file, wouldn't it be possible to migrate it using kconf_update? Good question. The config is saved in plasma-desktop-appletsrc and I need to add:

Re: KDEReview: Nepomuk-Controller QML

Assuming this setting is stored in some KConfig based file, wouldn't it be possible to migrate it using kconf_update? Good question. The config is saved in plasma-desktop-appletsrc and I need to add: [Containments][3][Applets][25][Configuration][Applets][36] geometry=0,0,24,24

Re: KDEReview: Nepomuk-Controller QML

The minor version upgrade process all throughout the KDE/Plasma 4 releases started off as a fairly steady source of minor nits and irritants for users. The Nepomuk controls themselves are already fairly well-known so it's even more important IMO that if they are deprecated that they don't

Re: KDEReview: Nepomuk-Controller QML

On Tuesday, March 26, 2013 11:42:46 Jörg Ehrichs wrote: One detail though is missing, the old systray was able give a number of indexer file resources. This number is missing from my QML approach. Not sure how important this number is, as it isn't really a good measure or even a measure at

Re: KDEReview: Nepomuk-Controller QML

On Sat, Mar 23, 2013 at 8:12 PM, Jörg Ehrichs joerg.ehri...@gmx.de wrote: So after a first introduction in plasma, I like to get this thing into SC. The Nepomuk-Controller aims to replace the current system tray Nepomuk applet. This one allows to suspend/resume and show information for all

Re: KDEReview: Nepomuk-Controller QML

On Monday, March 25, 2013 16:46:10 Vishesh Handa wrote: On Sat, Mar 23, 2013 at 8:12 PM, Jörg Ehrichs joerg.ehri...@gmx.de wrote: The dataengine as well as the applet is only installed if Nepomuk-Core/Soprano is found as build dependency. This would deprecate:

Re: KDEReview: Nepomuk-Controller QML

El Dissabte, 23 de març de 2013, a les 15:42:33, Jörg Ehrichs va escriure: So after a first introduction in plasma, I like to get this thing into SC. The Nepomuk-Controller aims to replace the current system tray Nepomuk applet. This one allows to suspend/resume and show information for all

Re: KDEReview: Nepomuk-Controller QML

Why workspace when you are deprecating something in runtime? All other Plasma::DataEngines and applets (battery, network) are in workspace too. While runtime/plasma has only some generic stuff. So in general it felt like the better place. In addition I think this service info tool is not a

Re: KDEREVIEW: share like connect and plasmate

On Thu, Jan 31, 2013 at 12:47 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, January 31, 2013 10:43:29 Ben Cooksley wrote: as it has been mentioned plasmate is ready to go into the extragear. Can you move it to the extragear? Where precisely in Extragear is Plasmate SDK and

Re: KDEREVIEW: share like connect and plasmate

On Wed, Jan 30, 2013 at 11:23 PM, Giorgos Tsiapaliokas terie...@gmail.com wrote: Hello, Hi Giorgos, as it has been mentioned plasmate is ready to go into the extragear. Can you move it to the extragear? Where precisely in Extragear is Plasmate and Share-Like-Connect headed? They are both

Re: KDEREVIEW: share like connect and plasmate

On Thursday, January 31, 2013 10:43:29 Ben Cooksley wrote: as it has been mentioned plasmate is ready to go into the extragear. Can you move it to the extragear? Where precisely in Extragear is Plasmate SDK and Share-Like-Connect headed? Base thanks :) -- Aaron J. Seigo

Re: KDEREVIEW: Mangonel

On Wed, Jan 23, 2013 at 7:13 PM, Martin Sandsmark martin.sandsm...@kde.org wrote: Distinguished Sirs and Madams, On Tue, Jan 08, 2013 at 09:08:11PM +0100, Martin Sandsmark wrote: Mangonel has just been moved to KDE Review. The KDE Review process is set to be two weeks, and if Mangonel

Re: KDEREVIEW: Mangonel

Distinguished Sirs and Madams, On Tue, Jan 08, 2013 at 09:08:11PM +0100, Martin Sandsmark wrote: Mangonel has just been moved to KDE Review. The KDE Review process is set to be two weeks, and if Mangonel calculator isn't completely wrong, that period is now up. Since all the issues raised are

Re: KDEREVIEW: Mangonel

On Wed, Jan 09, 2013 at 09:07:13PM +0200, Yuri Chornoivan wrote: If there is no Help button and no desktop file, there is not much sense in making docbooks. I agree. I propose just add an item to UserBase launchers list [1] and some tiny page based on README.md. I'll be sure to market it

Re: Re: KDEREVIEW: Mangonel

Hello List, On Tuesday 08 January 2013 23:12:01 Albert Astals Cid wrote: El Dimarts, 8 de gener de 2013, a les 21:08:11, Martin Sandsmark va escriure: Dear Sirs and Madams, Mangonel has just been moved to KDE Review. Mangonel is a simple and lightweight application launcher in the

Re: KDEREVIEW: Mangonel

On 2013年01月09日 08:09, Martin Sandsmark wrote: Any reason not to use bugs.kde.org? Fixed. Hi, I see you made the change : -aboutData-setBugAddress(QByteArray(bugs.mango...@tarmack.eu)); +aboutData-setBugAddress(QByteArray(https://bugs.kde.org/;)); Hmm, that is not going to work.

Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 08:56:25 Jekyll Wu wrote: If you plan to use bugs.kde.org as the tracker, then you don't need to call setBugAddress() at all. The default value just works. Fixed. And don't forget to ask sysadmins to create a mangonel product on bugs.kde.org :) Done.

Re: Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 18:35:49 Martin Sandsmark wrote: On Tuesday 08 January 2013 19:30:45 Allen Winter wrote: No docbook manual I guess I'll to contact the doc team for this? Do you want apidox generated? if so you also need a Mainpage.dox No need for that (yet, at least, we

Re: KDEREVIEW: Mangonel

El Dimecres, 9 de gener de 2013, a les 01:09:28, Martin Sandsmark va escriure: Hi, thanks for the review! On Tuesday 08 January 2013 23:12:01 Albert Astals Cid wrote: Which is its intended destination extragear-something? Yes, sorry, I forgot to mention, it is destined for extragear/base.

Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 19:49:36 Albert Astals Cid wrote: You should probably make it look like i18nc(some context of what stuff is, (%1), application.type) Just in case someone needs to do something different with the parenthesis. Okay, fixed. Thanks :-) -- Martin Sandsmark KDE

Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 19:45:27 Martin Gräßlin wrote: There is one mail already on the list, so it is already spread. Okay, so the proverbial cat's out of the bag I guess, so I just added his email to the license headers. -- Martin Sandsmark KDE

Re: KDEREVIEW: Mangonel

написане Wed, 09 Jan 2013 19:35:49 +0200, Martin Sandsmark martin.sandsm...@kde.org: On Tuesday 08 January 2013 19:30:45 Allen Winter wrote: No docbook manual I guess I'll to contact the doc team for this? If there is no Help button and no desktop file, there is not much sense in making

Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 09:07:13 PM Yuri Chornoivan wrote: написане Wed, 09 Jan 2013 19:35:49 +0200, Martin Sandsmark martin.sandsm...@kde.org: On Tuesday 08 January 2013 19:30:45 Allen Winter wrote: No docbook manual I guess I'll to contact the doc team for this? If there is

Re: KDEREVIEW: Mangonel

El Dimarts, 8 de gener de 2013, a les 21:08:11, Martin Sandsmark va escriure: Dear Sirs and Madams, Mangonel has just been moved to KDE Review. Mangonel is a simple and lightweight application launcher in the vein of Katapult from ye olde KDE 3 days, kind of reminiscent of the task

  1   2   >