D22868: Revamp Kirigami.AboutPage

leinir accepted this revision. leinir added a comment. While swapping out the card for straight up a rowlayout might[1] effectively look like a workaround for the weirdness in that bit... this really just looks better anyway ;) Go for it :D [1] to someone who's tried to fix that bit befo

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62850. leinir added a comment. - Parent the QuickQuestionAsker to qApp - Add in a QuestionAsker on NewStuffList REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62846&id=62850 BRANCH knsquick-feature-parity

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62846. leinir added a comment. - Fix up the NewStuffItem installer busy indicator a bit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62844&id=62846 BRANCH knsquick-feature-parity-with-kns (branched from m

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62844. leinir added a comment. - Add in a getter for category displaynames - Add category/filter/sort dropdowns to NewStuffList - A bit of minor prettification for NewStuffItem REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62785. leinir added a comment. - Actually request a downloaditem in NewStuffItem when install/updating REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62049&id=62785 BRANCH knsquick-feature-parity-with-kns (

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62049. leinir added a comment. - Refactor the naming of components etc a touch (and hide private bits) - Fix a few bits of stray naming in the docs REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=61905&id=620

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61905. leinir added a comment. - Don't use outdated code (e.g. the Kirigami Label component) - Update NewStuffList to the new model API - Explicit operator= implementations (for less warnings) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE htt

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61638. leinir added a comment. - A small spacer item for the entry details page - Documentation++ - Show a passive notification in the dialog when messages are posted REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61500. leinir added a comment. - Add a downloaditemssheet to the entry details page REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=61341&id=61500 BRANCH knsquick-feature-parity-with-kns (branched from maste

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61341. leinir added a comment. - Put the NewStuff.Author component to use on the details page as well REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=61340&id=61341 BRANCH knsquick-feature-parity-with-kns (b

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61340. leinir added a comment. - Add the user ID to the author class - Expose the entry author id through the qtquick item model - Rename the entryAuthor property to entryAuthorId, as that's what it is - Add a bit more info to the author - Add a copy

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61331. leinir added a comment. Thanks kbroulik! - allowedByKiosk should be a CONSTANT property, as it's... constant - Postpone engine initialisation until Button is clicked REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61065. leinir added a comment. - Add profile page to the author classes - Add a spacer item to the CommentsPage listview - A touch of visual cleaning in the comment delegate - Type-safe comparisons are good - Throttle the fetch calls just a touch, no

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60920. leinir added a comment. - Uncrash the author hash (don't use const QString references as key...) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=60781&id=60920 BRANCH knsquick-feature-parity-with-kns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60781. leinir added a comment. Bunch of work on the comments (especially avatar stuff). In progress, of course, but the concept is there - Add an Author component to the QtQuick bits - Add Providers functionality for fetching person data - Add avat

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60729. leinir added a comment. - Work on the comments delegate's look some REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=60689&id=60729 BRANCH knsquick-feature-parity-with-kns (branched from master) REVIS

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60689. leinir added a comment. - Fill the width in the dialog's sidebar with Button - Use the knsrc file's Name attr for title (already translated) - Indent the comments by their depth (this is imperfect, but...) REPOSITORY R304 KNewStuff CHANGES SIN

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60214. leinir added a comment. Address anthonyfieroni's comment about manual memory management in the comments fetching system - Switch to a shared_ptr list for comments (less manual memory mgmnt) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDAT

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60204. leinir added a comment. - Sort the default sizing on the Dialog to be more pleasant - Rejig the Dialog's button implementation, so it's now got shortcuts - Set the default column width of the test dialog REPOSITORY R304 KNewStuff CHANGES SINCE

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60181. leinir added a comment. - A pile of style cleaning - Implement the adoptItem function in KNSQuick::ItemsModel REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=60052&id=60181 BRANCH knsquick-feature-p

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60052. leinir marked 2 inline comments as done. leinir added a comment. Address pino's comments about BIC (and some documentation) - Don't mark functions virtual which should not be virtual - Apply the signal/slot virt func workaround for improved BIC

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > pino wrote in engine.h:471 > BIC change, you cannot add virtual functions in a public class That shouldn't be virtual anyway, not sure why i did that... > pino wrote in provider.h:148 > BIC change, you can

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60021. leinir added a comment. Highlights: NewStuffButton, basic Kiosk support (needs more clever and user-facing mention of why the thing they just tried to do didn't happen/do anything), various fixing, cleanup, and sanity work. - Fix logic for canF

D21778: Add some documentation for PlatformDependent

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good :) REPOSITORY R235 Attica BRANCH bshah/docs REVISION DETAIL https://phabricator.kde.org/D21778 To: bshah, leinir Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, b

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#478676 , @ngraham wrote: > Could the new one be API compatible so we wouldn't need to wait for KF6? Also it's always nice to avoid breaking API if you don't have to. Not entirely sure we can do that, the

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#478241 , @ngraham wrote: > Thanks! I think we should definitely aim to replace the old QWidgets-based one. Otherwise we're signing up for an increased maintenance burden with no real advantages IMO. Consider tha

Re: KNewStuff problem - GSOC 2019

Dear Ferencz, If you've got downloading working (that is, if you can initialise a KNSCore::Engine or KNewStuff::Button or the like with a knsrc file with the appropriate categories without an error), then your category should be working fine. If your category does not alredy exist on the KDE

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#477397 , @ngraham wrote: > How does one test this? By running the khotnewstuff-dialog application and passing a knsrc file to it (though i would point to the first line in the summary for the moment befor

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Basic KNewStuffQuick dialog for testing purposes Actually return the number of comments, not the rating Change t

D21183: search in the new location for knsrc files

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In the words of the interwebs whenever someone days a certain number: nice :) REPOSITORY R252 Framework Integration BRANCH phab/newlocation REVISION DETAIL https://phabricator.kde.or

D21183: search in the new location for knsrc files

leinir requested changes to this revision. leinir added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:49 > > -const auto knsname = > QStandardPaths::locate(QStandardPaths::GenericConfigLocation, url.host()); > +auto knsname = > QStandardPat

D20986: Don't call click on the delegate, when we just want it to become current item

leinir added a comment. In D20986#460112 , @broulik wrote: > -1 > > Most KCMs actually use `onClicked` to update the selected plugin and other bits. They don't actually set `currentIndex` on the `ListView` directly but have it updated based

D20986: Don't call click on the delegate, when we just want it to become current item

leinir created this revision. leinir added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY If you have any actions in your GridDelegate, activating them would previously cause t

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

leinir added inline comments. INLINE COMMENTS > ngraham wrote in GridDelegate.qml:147 > This was a deliberate choice, to make sure that the delegate got selected > when one of its buttons got clicked. But yeah selected may not necessarily > require clicked, so maybe it wasn't the best way of do

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

leinir added inline comments. INLINE COMMENTS > GridDelegate.qml:147 > +onClicked: { > +delegate.clicked() > +modelData.trigger() Just came across having both a function called on clicking the thumbnail (

D20693: Remove pixelated border

This revision was automatically updated to reflect the committed changes. Closed by commit R304:e1f5782a8518: Remove pixelated border (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20693?vs=56794&id=56952 REVISION DETAIL https://phab

D20693: Remove pixelated border

leinir added a comment. That does indeed look good, and not a huge departure from what we have already, which i'm sure will make people feel quite at home in the new version :) I do wonder if we'd want to, at some point, make it look closer to Discover, but certainly for now this seems a muc

D20693: Remove pixelated border

leinir added a comment. In D20693#454874 , @ngraham wrote: > To show that a thumbnail clickable, switching to the pointing hand cursor when hovering over a thumbnail could work. > > However I notice that the actual list delegates in the brows

D20693: Remove pixelated border

leinir added a comment. In D20693#454799 , @sitter wrote: > In D20693#454750 , @leinir wrote: > > > So yes, in principle i'd certainly like there to be some kind of background or outline to suggest c

D20693: Remove pixelated border

leinir added a comment. In D20693#454783 , @sitter wrote: > LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion. > > @leinir lxr says a similar thumb is also used for some of the KAboutPe

D20693: Remove pixelated border

leinir added a comment. In D20693#454733 , @ndavis wrote: > +1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked. The problem as described in my comment where i added

D20693: Remove pixelated border

leinir added a reviewer: VDG. leinir added a comment. Adding VDG because this is a visual change. To the visual commenters: This is intended as a first step, removing the old drop-shadow method (see also the related bug for a more severe version of that drop-shadow being shown very incorrect

D20761: Remove pixelated border

leinir added a reviewer: VDG. leinir added a comment. Adding VDG because this is a visual change. To the visual commenters: This is intended as a first step, removing the old drop-shadow method (see also the related bug for a more severe version

D20693: Remove pixelated border

leinir added a comment. Before patch: F6788195: image.png After patch: F6788193: image.png REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D20693 To: leinir, #knewstuff, ngraham, sitt

D20693: Remove pixelated border

leinir added a comment. In D20693#454173 , @ngraham wrote: > This patch doesn't apply: > >INFO Base commit is not in local repository; trying to fetch. > Created and checked out branch arcpatch-D20693. > Checking patch src/ui/imag

D20693: Remove pixelated border

leinir updated this revision to Diff 56794. leinir added a comment. Attempt to use arcanist, hopefully with less data loss this time REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20693?vs=56613&id=56794 BRANCH no-pixelated-border (branched from master

D20761: Remove pixelated border

leinir abandoned this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D20761 To: leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20761: Remove pixelated border

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In the before-times, drop shadows were considered vitally important on everything, and so it was introduced to KNewStu

D20693: Remove pixelated border

leinir created this revision. leinir added reviewers: KNewStuff, ngraham, sitter. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In the before-times, drop shadows w

D20077: Accept any HTTP status between 100 and 199 as benign

This revision was automatically updated to reflect the committed changes. Closed by commit R235:7e988d655db2: Accept any HTTP status between 100 and 199 as benign (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20077?vs=54928&id=54972 REVI

D19990: Switch URLs to https

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. LGTM, as long as all the various sites being pointed at there actually resolve on https, which i'm guessing (going by your summary) you've checked? :) REPOSITORY R304 KNewStuff BRANCH

D20077: Accept any HTTP status between 100 and 199 as benign

leinir updated this revision to Diff 54928. leinir retitled this revision from "Accept HTTP status 103 as benign" to "Accept any HTTP status between 100 and 199 as benign". leinir edited the summary of this revision. leinir added a comment. Just accept any informational status as benign, rathe

D20077: Accept HTTP status 103 as benign

leinir added a comment. In D20077#439290 , @apol wrote: > And why are 101 and 102 bad? > Should we just accept between 100 and 200? Hmm... You're probably right, yes, 100 is supposed to be all benign status type stuff, so... yeah, i'll

D20077: Accept HTTP status 103 as benign

leinir created this revision. leinir added reviewers: KNewStuff, Frameworks. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In December 2017, a new status code was

D19917: Additions for ProviderManager documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R235:533b31b5d6f9: Additions for ProviderManager documentation (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19917?vs=54422&id=54426 REVISION DETA

D19917: Additions for ProviderManager documentation

leinir added inline comments. INLINE COMMENTS > apol wrote in providermanager.h:50 > You can use @see so doxygen creates a link? It's supposed to pick those up automatically, i thought? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D19917 To: leinir, #frameworks, #kne

D19917: Additions for ProviderManager documentation

leinir created this revision. leinir added reviewers: Frameworks, KNewStuff. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Someone attempting to work on an Attica

D19900: Set category on Attica entries

This revision was automatically updated to reflect the committed changes. Closed by commit R304:88ffd3cce725: Set category on Attica entries (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19900?vs=54368&id=54375 REVISION DETAIL https

D19900: Set category on Attica entries

leinir created this revision. leinir added reviewers: KNewStuff, apol. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this patch, we had forgotten to set t

D19858: Handle unsupported OCS commands, and don't over-vote

This revision was automatically updated to reflect the committed changes. Closed by commit R304:2a40085fc3d2: Handle unsupported OCS commands, and don't over-vote (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19858?vs=54235&id=54238 R

D19858: Handle unsupported OCS commands, and don't over-vote

leinir added a comment. In D19858#433788 , @ngraham wrote: > Thanks! Makes sense, and fixes the bug. :) > > Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it

D19858: Handle unsupported OCS commands, and don't over-vote

leinir updated this revision to Diff 54235. leinir marked an inline comment as done. leinir added a comment. Copypasta error... thanks Nate :) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19858?vs=54233&id=54235 REVISION DETAIL https://phabricator.kd

D19858: Handle unsupported OCS commands, and don't over-vote

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > ngraham wrote in itemsviewdelegate.cpp:287 > Why do we need to do this twice? ehrm... we don't, we need to undo it, and i forgot to swap that true for a false ;) Thanks! REPOSITORY R304 KNewStuff REVISI

D19858: Handle unsupported OCS commands, and don't over-vote

leinir created this revision. leinir added reviewers: KNewStuff, ronaldv, ngraham. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY When the server does not support c

D19338: New location for KNSRC files

This revision was automatically updated to reflect the committed changes. Closed by commit R304:be0412024a46: New location for KNSRC files (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19338?vs=53117&id=53869 REVISION DETAIL https:/

D19338: New location for KNSRC files

leinir added a comment. Quick ping, be good to get this in sometime before it becomes late again... :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraha

D19683: autotests: use new signal failedToLoad in ProviderTest

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. This does seem very much sensible, yes, well thought :) REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D19683 To: dfaure, leinir Cc: kde-frameworks

D19672: [knewstuff] make it compile without foreach

leinir accepted this revision. leinir added a comment. Looks good to me... None of the scary ones that'll trigger various nasty side effects as far as i can tell. REPOSITORY R304 KNewStuff BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.or

D19338: New location for KNSRC files

leinir updated this revision to Diff 53117. leinir added a comment. Since 5.57, not 5.56 REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19338?vs=52607&id=53117 REVISION DETAIL https://phabricator.kde.org/D19338 AFFECTED FILES KF5NewStuffCoreConfig.c

D19387: Remove deprecated QSignalMapper

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Much simpler code run, there, lgtm :) REPOSITORY R235 Attica BRANCH remove_deprecated_qsignalmapper (branched from master) REVISION DETAIL https://phabricator.kde.org/D19387 To: mla

D19338: New location for KNSRC files

leinir added a comment. In D19338#420303 , @apol wrote: > +1 cool stuff! > > this opens the possibility for files being both in /usr and /etc, can you make sure hell doesn't break loose when that happens? > > Was these files look up was d

D19338: New location for KNSRC files

leinir added a dependent revision: D19340: Search new knsrc locations. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19338: New location for KNSRC files

leinir created this revision. leinir added reviewers: KNewStuff, apol, ngraham, fvogt. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This introduces a cmake variab

D18813: Filter out invalid content in lists

This revision was automatically updated to reflect the committed changes. Closed by commit R304:1f4e1a6db756: Filter out invalid content in lists (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18813?vs=51169&id=51501 REVISION DETAIL

D18813: Filter out invalid content in lists

leinir updated this revision to Diff 51169. leinir marked an inline comment as done. leinir added a comment. Swap the logic around a bit, makes for an easier to read patch and whatnot. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18813?vs=51099&id=51169

D18813: Filter out invalid content in lists

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in atticaprovider.cpp:277 > Maybe it would be easier to read if we had a `if (!content.isValid()) > continue; ...`. Hmm... the patch certainly would, i'll swap that around a bit. Generally don't

D18813: Filter out invalid content in lists

leinir created this revision. leinir added a reviewer: KNewStuff. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this change, if the ocs server being queri

D18038: Fix semantics for ghns_exclude

This revision was automatically updated to reflect the committed changes. Closed by commit R304:301fe73569ba: Fix semantics for ghns_exclude (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18038?vs=48859&id=49339 REVISION DETAIL https

D18038: Fix semantics for ghns_exclude

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D18038 To: leinir, ronaldv, #kde_store, ngraham Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starb

D18038: Fix semantics for ghns_exclude

leinir added a comment. In D18038#391684 , @ngraham wrote: > Thanks, in addition to the testing tool working, this patch seems to actually fix the issue in production (e.g. "Tree on Island" is no longer visible in the wallpaper downloader), and

D18038: Fix semantics for ghns_exclude

leinir added a comment. In D18038#390748 , @ngraham wrote: > What is the test tool? Can you help a total n00b like me learn how to test KNewStuff patches like these? The test tool is khotnewstuff_test in tests/. It's not installed, but on

D18038: Fix semantics for ghns_exclude

leinir added a reviewer: ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D18038 To: leinir, ronaldv, #kde_store, ngraham Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck

D18038: Fix semantics for ghns_exclude

leinir created this revision. leinir added reviewers: ronaldv, KDE Store. leinir added projects: KNewStuff, KDE Store. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY After much discussion on the topi

D17593: Notify if a default provider failed to download

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Hm, definitely yes. Frankly i thought this already happened, goes to show what assumptions make of us, eh? ;) REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricato

D17594: Notify about the provider not being loaded

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Oh wow, ouch, yes that should definitely be happening. Well caught, thank you! :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D17594 To: apo

D17334: Export enum into qobject for easier debugging

leinir added inline comments. INLINE COMMENTS > CMakeLists.txt:14 > xmlloader.cpp > +errorcode.cpp > Sorry, might've been a little premature on the ol' shipit button there - there's no such file... unless you forgot to add it :) REPOSITORY R304 KNewStuff REVISION DETAIL https:/

D17334: Export enum into qobject for easier debugging

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Good call there, yup :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D17334 To: apol, #frameworks, leinir Cc: kde-frameworks-devel, michaelh,

D17079: Provide a qqc2/kirigami-based about page

leinir added a comment. Basically what Nate said, this is a great idea :) Thinking that having this is already an improvement, but also perhaps that having it as a scrollable page would indeed feel more natural here rather than tabs... Thinking this seems like a good place to use the fact th

R134:7f6caf385809: Better error handling in KNewStuff backend

leinir added a subscriber: kde-frameworks-devel. leinir added a comment. Through pushing this patch, i have discovered there is no easily discoverable documentation regarding when Frameworks are updated for unstable builds. According to https://build.kde.org/job/Plasma/job/discover/job/kf5-q

D16665: Add programmaticaly useful error signalling

leinir added a dependent revision: D16776: Better error handling in KNewStuff backend. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16665 To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D16665: Add programmaticaly useful error signalling

leinir added a comment. In D16665#355578 , @apol wrote: > Maybe it would be good to produce the Discover patch before committing this to make sure the API is the one we want. Good idea, yes, i'll get that whipped together and submitted wi

D16665: Add programmaticaly useful error signalling

leinir updated this revision to Diff 45032. leinir marked an inline comment as done. leinir added a comment. Adjust the patch to address @apol's comment about deprecating the old error signal REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16665?vs=44855&

D16665: Add programmaticaly useful error signalling

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in engine.h:430 > I would include the error message here and deprecate `signalError`. Otherwise > it's going to be a mess matching both signals. Quite a good point, yes - i've done a bit of jiggl

D16665: Add programmaticaly useful error signalling

leinir created this revision. leinir added reviewers: KNewStuff, apol. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Previously, KNSCore only signalled errors usin

D6513: Add support for Attica tags support

This revision was automatically updated to reflect the committed changes. Closed by commit R304:158ba4e2420b: Add support for Attica tags support (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=42360&id=42657 REVISION DETAIL h

D6513: Add support for Attica tags support

leinir added a comment. Sorry for pinging again, but i'd really quite like to not have to wait (yet) another cycle for this to get out... REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, d

D6513: Add support for Attica tags support

leinir updated this revision to Diff 42360. leinir added a comment. Address @cfeck's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=41886&id=42360 REVISION DETAIL https://phabricator.kde.org/D6513 AFFECTED FILES autotests/knewstuffe

D6513: Add support for Attica tags support

leinir marked 3 inline comments as done. leinir added a comment. In D6513#332106 , @cfeck wrote: > Using a hash to map public to private class is a good idea. The only thing I'm not sure about is if there is a memory leak. I would think that havin

D6513: Add support for Attica tags support

leinir added a comment. Sorry for pinging again, but i'd quite like this to get in, bic fixed and all that, before the next release... REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfau

<    1   2   3   4   5   6   >