D29254: [RenameDialog] Add an arrow indicating direction from src to dest

hpereiradacosta added inline comments. INLINE COMMENTS > hpereiradacosta wrote in renamedialog.cpp:299 > dolphin --reverse > should run it in right-to-left mode > (or whatever the opposite of your current locale) you can use qApp->isRightToLeft() to check the rtl direction REPOSITORY R241

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

hpereiradacosta added inline comments. INLINE COMMENTS > ahmadsamir wrote in renamedialog.cpp:299 > @pino, right; dolphin isn't rtl-aware (or if it is, I couldn't find out how > to switch it to rtl). But I agree the code here should account for rtl anyway. > > @ngraham: I think we should stick

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a comment. > I'm not sure what you mean when you wonder how it would play with monochrome icons. It should have nothing to do with them unless you embed stylesheets in the SVGs to use the separator color in breeze icons. I meant: do the "light" (with window

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a comment. In D25814#574197 , @ndavis wrote: > In D25814#574160 , @davidedmundson wrote: > > > Can we clarify what separators we're referring to. > > > Frames around UI

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a comment. > So the background here is that we've gotten a new VDG designer who produced mockups of Breeze dark with dark separators, and some people absolutely fell in love with them, while other people hated them. We could not achieve consensus on moving to use

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a comment. Few more comments on this: - general: you will never be able to make all the opiniated people happy, and you have to draw a line (otherwise your code will become bloated, buggy, and unmaintainable) - regarding this specific case: many widget style will

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a subscriber: cfeck. hpereiradacosta added a comment. Would also be good to have the opinion of @cfeck on this. REPOSITORY R265 KConfigWidgets BRANCH separator-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis,

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a comment. Adding new entries to the kcolorscheme should be done with a lot of care, because it could be seen as some sort of API break for existing colorscheme, as soon as you start using this color in the widget style: you would need a fallback implementation, for

D22884: [RFC] Don't show title on page by default

hpereiradacosta added a comment. "KPageWidgetItems live in a multi-page KPageDialog" Is that really true ? Does it not leave also standalone when running e.g. kcmshell5 kwindecoration (or any other kcm ?) If yes, and at least in this case, the title has to stay, because there is no side

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. Hi Marco, Patch works like a charm in standard config dialogs. As a somewhat off topic remark though, it does not work in kcmultidialog (in framework kcmutils), even though it derives from kpageddialog. This shows up for instance in the "window

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. In D22083#491299 , @mart wrote: > code issues are fixed. > Now for removing the further margin around the whole window: > should that be done here or in breeze? > if done here, it may make it look bad on

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. Hi Marco, see https://phabricator.kde.org/D22138 (I also included the white background in there, because it turned out a bit tricky). REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22083 To: mart, #plasma, #frameworks,

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. ather simple and attached. Feel free to add this or something similar to any other modification you plan to do. F6938398: patch.diff > Thank you very much Hugo.. that pixel was driving me mad ;) > Do you want to

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. On the breeze side, asside from the layout margins/spacing issues, there is at least one hard-coded pixel in the frame rendering that must be removed. In fact I have this committed in my local breeze version already. The corresponding patch is rather simple

D13026: Open Schema toolbar button with normal click rather than click-and-hold

hpereiradacosta added a comment. Hello, I would appreciate that you rephrase the description for this patch (and others where the same comment appear): the dissapearing arrow with breeze is not a *bug* in breeze, but a (conscious) design choice, that is discussed in D13064

D7249: Return high-resolution line edit clear icon

hpereiradacosta added a comment. +1 from me. Sounds sensible. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D7249 To: broulik, kde-frameworks-devel, hpereiradacosta Cc: hpereiradacosta, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

hpereiradacosta added a comment. Hi, Thanks for the set of patches. in general, i am ok with the change but: - please re-add the screenshot from Review Board. (sorry I was not aware of this review request cause I was not in the list of reviewers, even though official maintainer

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

hpereiradacosta added a comment. > Also I tested it now with the Oxygen and United themes, and `QToolButton` has still the same flat frame line in highlight color around it in when hovered like in Breeze, so it seems to be independent of the theme in `QToolButton` as well. In the Oxygen

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

hpereiradacosta added a comment. + 1 for me. Looks good! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4797 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma Cc: ltoscano, broulik,

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

hpereiradacosta added a comment. Hi Roman, > Would you support the idea of using the KToolBar ToolButton design for the QML ToolButton aswell? It looks way better in my opinion and it would make the use of tool buttons more consistent. Yes, I would support this. It would be more

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

hpereiradacosta added a comment. Hello Roman, I disagree that the current toolbutton design "doesn't fit the overall design". It is (to me at least) consistent with the widget style (in e.g. toolbars), and all the other "squarish" elements of breeze. On the contrary, I would find the

Re: Review Request 128895: Return high-resolution line edit clear icon

described in https://git.reviewboard.kde.org/r/128630/ in the first place, this without the patch Changed the "small icon size" to 22, and dolphin still shows an unblurred icon. Changed scale factor to 2 and other things, still no luck. Am I missing something ? - Hugo Pereira Da Costa O

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

On 06/12/2016 07:51 PM, Albert Astals Cid wrote: Having KMessageBox "dontShowMeAgain" feature depend on an integration plugin is a very bad idea. Basically it means programs that use KMessageBox can never asusme it will work so basically they have to use alternative methods to have the

Re: LGPL for Breeze QStyle and qtquickcontrols?

On 06/06/2016 12:17 PM, Jaroslaw Staniek wrote: On 30 May 2016 at 17:11, Michael Pyne > wrote: On Mon, May 30, 2016 14:42:43 Martin Graesslin wrote: > On Saturday, May 28, 2016 11:24:52 PM CEST Michael Pyne wrote: > > On Sat, May 28, 2016

Re: LGPL for Breeze QStyle and qtquickcontrols?

On 05/30/2016 12:33 AM, Aleix Pol wrote: On Mon, May 23, 2016 at 9:38 AM, Martin Graesslin wrote: On Sunday, May 22, 2016 12:22:28 AM CEST Jaroslaw Staniek wrote: So we, in KDE, lack LGPL style code for our de-facto official look and feel. This is the crucial point.

Re: LGPL for Breeze QStyle and qtquickcontrols?

Hi, [snip] ​Architecturally, the eventual solution would be that breeze.git becomes layered, and routines beyond what QStyle defines are provided by an LGPL lib. It worked with libOxygen that is LGPL. The reason for liboxygen was that part of Oxygen was also used by KWin decoration. We fixed

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test th

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg > > Hugo Pereira Da Costa wrote: > Well, Ship it is a bit premature. > I could not test th

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

> On May 9, 2016, 10:22 p.m., Andreas Kainz wrote: > > I can't review the code but this is one of the best features in the past 2 > > years > > +1 from the vdg Well, Ship it is a bit premature. I could not test the patch but: it compiles and code looks sensible. However, there are probably

Re: Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

> On May 6, 2016, 2:09 p.m., Hugo Pereira Da Costa wrote: > > Thanks ! > > I tested it here. Looks fine. > > Although the diff is hard to read, new code looks good. > > > > Hugo PS: since oxygen does a lot of caching, there actually are many other places al

Re: Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

the diff is hard to read, new code looks good. Hugo - Hugo Pereira Da Costa On May 5, 2016, 12:23 a.m., Michael Pyne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On March 19, 2016, 1:22 p.m., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

é, QPushButton::SizeHint already include the size of the icon to be drawn in the size it calculates and passes to QStyle::sizeFromContents. So that you would need to either "undo" the size calculated by QPushButton in the sizeHint method (which sounds quite fragile I think), or indeed, patch QPushButton in some way ... Comments welcome (especially i

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

gt; > > "Fixing" that in deprecated KPushButton doesn't really fix anything. We'll > > face the mix we had, just that users of QPushButton were far less prone to > > pass them an icon in pre-KF5 times. > > > > Please also attach Hugo Pereira Da Costa. > >

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

gt; > > "Fixing" that in deprecated KPushButton doesn't really fix anything. We'll > > face the mix we had, just that users of QPushButton were far less prone to > > pass them an icon in pre-KF5 times. > > > > Please also attach Hugo Pereira Da Costa. > >

Re: Review Request 126241: [OS X] adapting KStyle (WIP)

only work for kstyle derived styles (oxygen, breeze), and not the QStyle based one. (QtCurve ?) ... not convinced. (but not strong objection either) - Hugo Pereira Da Costa On Dec. 4, 2015, 12:27 p.m., René J.V. Bertin wrote

Re: Review Request 125325: New widget KCollapsibleGroupBox

exactly like yours) since quite some time already - Hugo Pereira Da Costa On Sept. 20, 2015, 3:55 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125325: New widget KCollapsibleGroupBox

> On Sept. 24, 2015, 8:04 a.m., Hugo Pereira Da Costa wrote: > > +1 on the idea. > > Note that gtk has such a widget (which looks exactly like yours) since > > quite some time already Testing, there are some issues though. The fact for instance that mouse-over and focus a

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. Hugo Pereira Da Costa wrote: ok. Got it now. Thanks ! Hugo Pereira Da Costa

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. Hugo Pereira Da Costa wrote: ok. Got it now. Thanks ! Hugo Pereira Da Costa

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

/122168/diff/ Testing --- yes, with code not pushed yet in breeze decoration config. Before: crash (due to the above) After: no crash. Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. Hugo Pereira Da Costa wrote: ok. Got it now. Thanks ! Hugo Pereira Da Costa

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. Hugo Pereira Da Costa wrote: ok. Got it now. Thanks ! Stupid question: does

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

--- yes, with code not pushed yet in breeze decoration config. Before: crash (due to the above) After: no crash. Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

) After: no crash. Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/#review74403 --- On Jan. 20, 2015, 11:02 a.m., Hugo Pereira Da Costa wrote

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

/#review74399 --- On Jan. 20, 2015, 11:02 a.m., Hugo Pereira Da Costa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

On Jan. 20, 2015, 3:52 p.m., David Faure wrote: for the path yes, but there is no reason to remove that from the service name Hugo Pereira Da Costa wrote: mmm. Maybe I am confused with the comment. Still, I just checked that passing X-KDE-Library=kstyle_breeze_config.so

Re: Why so many QStyles

On 01/04/2015 02:54 PM, David Faure wrote: On Sunday 04 January 2015 13:51:15 David Faure wrote: 2) I can't think of a reason against passing qApp-style() to the KLineEditStyle ctor; the rest of the code in QProxyStyle::ensureBaseStyle is about the -style cmdline override (which qApp-style()

Review Request 121459: Fixed data type for _KDE_NET_WM_BLUR_BEHIND_REGION

, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

? At the very least one should deprecate the part of the API that allow apps to set the icon, since it is not honoured. I would honestly recommand to revert this commit. - Hugo Pereira Da Costa On Dec. 12, 2014, 11:04 a.m., Gregor Mi wrote

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: Seriously ! this is abusing review board. Silent consent ? At the very least one should deprecate the part of the API that allow apps to set the icon, since it is not honoured. I would honestly recommand to revert this commit

Re: Review Request 121459: Fixed data type for _KDE_NET_WM_BLUR_BEHIND_REGION

setting the property, via XCB. This however would break when running against kwin@kde4) Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Why so many QStyles

On 10/04/2014 12:37 PM, Dominik Haumann wrote: On Friday 03 October 2014 00:09:11 Aleix Pol wrote: On Thu, Oct 2, 2014 at 10:10 PM, Hugo Pereira Da Costa hugo.pere...@free.fr wrote: hi all, I guess its a question to Qt experts or possibly low level KF5 experts. When comparing debugging

Why so many QStyles

hi all, I guess its a question to Qt experts or possibly low level KF5 experts. When comparing debugging outputs when running app + style against Qt4 and Qt5, I've noticed the following significant difference. In Qt4, as far as I can tell, QStyle was only instanciated one per QApp, and

Re: Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/062cbcab-b184-4ed4-9cec-a94c503c0fa7__config-after.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/a8b7f663-7225-4f60-806b-833113583e67__config-after1.png Thanks, Hugo Pereira Da Costa

Re: Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

/f6a32555-148d-48a7-aabd-aea2a16f308f__config-after.png Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120360: force layout to zero when adding page to force alignment with title widget

://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/829ca21f-4d98-45aa-9f27-822ae09fbb17__config-before.png config-before.png https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/7b08ecab-77b1-496b-9172-8b3657f30e4f__config-before.png Thanks, Hugo Pereira Da Costa

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

/09/25/062cbcab-b184-4ed4-9cec-a94c503c0fa7__config-after.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/a8b7f663-7225-4f60-806b-833113583e67__config-after1.png Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

--- On Sept. 25, 2014, 12:33 p.m., Hugo Pereira Da Costa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/#review67446 --- On Sept. 25, 2014, 3:32 p.m., Hugo Pereira Da Costa wrote: --- This is an automatically

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

On Sept. 25, 2014, 7:17 p.m., Christoph Feck wrote: I reopened the issue Kai raised. Hugo Pereira Da Costa wrote: Why ? I did fix it I think, in the new uploaded diff. (and added comment that I can take out if you ask) ah crap forget it. I forgot the spaces after 'if' Will fix

Review Request 120277: Fix size hint and positioning of klineedit clear button in high dpi mode

before https://git.reviewboard.kde.org/media/uploaded/files/2014/09/19/72d0cc3d-c6d4-4e8d-a337-3e582446c67e__klineedit-old.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/09/19/570163fb-69d3-465f-a78b-9465126d446d__klineedit-new.png Thanks, Hugo Pereira Da Costa

Review Request 120278: Fixed size hint and positioning of icons in kpagelistview in high dpi mode

https://git.reviewboard.kde.org/media/uploaded/files/2014/09/19/464ef761-60e9-455b-8398-b2c71cef6468__kpageview-new.png Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 120277: Fix size hint and positioning of klineedit clear button in high dpi mode

-3e582446c67e__klineedit-old.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/09/19/570163fb-69d3-465f-a78b-9465126d446d__klineedit-new.png Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 120277: Fix size hint and positioning of klineedit clear button in high dpi mode

/09/19/570163fb-69d3-465f-a78b-9465126d446d__klineedit-new.png Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120278: Fixed size hint and positioning of icons in kpagelistview in high dpi mode

-new.png Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120278: Fixed size hint and positioning of icons in kpagelistview in high dpi mode

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120278/#review66924 --- On Sept. 19, 2014, 11:31 a.m., Hugo Pereira Da Costa wrote

Re: Review Request 120278: Fixed size hint and positioning of icons in kpagelistview in high dpi mode

/media/uploaded/files/2014/09/19/a01fec9f-06bc-43d6-8bd6-30390f4b5c74__kpageview-old.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/09/19/464ef761-60e9-455b-8398-b2c71cef6468__kpageview-new.png Thanks, Hugo Pereira Da Costa

Re: Review Request 119867: Fix CustomStyleElement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119867/#review66277 --- ping ? - Hugo Pereira Da Costa On Aug. 22, 2014, 11:27 a.m

Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

(oxygen) https://git.reviewboard.kde.org/media/uploaded/files/2014/09/11/1be8a8d2-053d-4002-9d83-ad2afd129042__kate-new-oxygen.png Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 119867: Fix CustomStyleElement

- src/kstyle/kstyle.cpp 2ff1031 Diff: https://git.reviewboard.kde.org/r/119867/diff/ Testing --- Compiles Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

/media/uploaded/files/2014/09/11/b9968e2b-9104-4022-ab7d-e89b2ce73116__kate-new-breeze.png after (oxygen) https://git.reviewboard.kde.org/media/uploaded/files/2014/09/11/1be8a8d2-053d-4002-9d83-ad2afd129042__kate-new-oxygen.png Thanks, Hugo Pereira Da Costa

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

Pereira Da Costa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/ --- (Updated Sept. 11, 2014, 9:24 p.m

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/#review66298 --- On Sept. 11, 2014, 9:25 p.m., Hugo Pereira Da Costa wrote

Re: Removing border and background from KPageView

On 09/09/2014 12:16 PM, Christoph Feck wrote: On Tuesday 09 September 2014 10:33:22 Albert Astals Cid wrote: El Dilluns, 8 de setembre de 2014, a les 23:31:52, Anton Kreuzkamp va escriure: Hi, on the VDG forum there has been a discussion about improving the design of

Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

On Aug. 26, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: +1 looks good to me. Maybe a before/after screenshot would help in these reviews. Hugo Pereira Da Costa wrote: sorry. Will add (being lazy) Ben Cooksley wrote: You may wish to examine System Settings, it has very

Review Request 119940: Use style primitive to render custom tooltip rather than custom code

ToolTips/ktooltipwindow_p.h a9ac30f Diff: https://git.reviewboard.kde.org/r/119940/diff/ Testing --- with oxygen, fusion, breeze Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

. To reply, visit: https://git.reviewboard.kde.org/r/119940/#review65279 --- On Aug. 26, 2014, 2:14 p.m., Hugo Pereira Da Costa wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/344a7dab-0dce-4a80-915b-8fccbd1b9f16__kinfocenter-before.png kinfocenter-after.png https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/dc2d618e-077f-4f49-ba02-11420927a068__kinfocenter-after.png Thanks, Hugo Pereira

Re: Review Request 119867: Fix CustomStyleElement

://git.reviewboard.kde.org/r/119867/diff/ Testing --- Compiles Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119867: Fix CustomStyleElement

://git.reviewboard.kde.org/r/119867/diff/ Testing --- Compiles Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119879: call style()-drawControl rather than drawItemText to handle button painting in kmultitabbar

://git.reviewboard.kde.org/r/119879/#review64971 --- On Aug. 21, 2014, 10:19 a.m., Hugo Pereira Da Costa wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119879: call style()-drawControl rather than drawItemText to handle button painting in kmultitabbar

to fix bug 296810 Diffs - src/kmultitabbar.cpp 7af343b Diff: https://git.reviewboard.kde.org/r/119879/diff/ Testing --- looks good with breeze, oxygen, fusion Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

. No more issues Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

confused about how this works in kf5 days ... PS2: I can try add screenshots if necessary Diffs - src/kmultitabbar.cpp 0420bec Diff: https://git.reviewboard.kde.org/r/119871/diff/ Testing --- With oxygen, breeze and fusion. No more issues Thanks, Hugo Pereira Da Costa

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

/diff/ Testing --- With oxygen, breeze and fusion. No more issues Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option-state settings

and fusion. No more issues Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Breeze widget style for KF5

On 08/12/2014 11:34 PM, Àlex Fiestas wrote: On Monday 11 August 2014 12:51:21 Milian Wolff wrote: a) what's the advantage of having a native widget style, compared to using QtCurve settings? Are there things missing / not implementable in QtCurve? We did some rought tests and QtCurve was

Breeze widget style for KF5

Hi all, For the last couple of weeks and after discussion with Nuno, Marco, Andrew and some others, I've worked on implementing most of the ideas from git://anongit.kde.org/breeze.git http://anongit.kde.org/breeze.git (more precisely from the QML demos at widgetstyles/qtquickcontrolsstyle)

Re: Breeze widget style for KF5

Hi Milian On Monday 11 August 2014 12:29:05 Hugo Pereira Da Costa wrote: Hi all, For the last couple of weeks and after discussion with Nuno, Marco, Andrew and some others, I've worked on implementing most of the ideas from git://anongit.kde.org/breeze.git http://anongit.kde.org/breeze.git

Re: Breeze widget style for KF5

On 08/11/2014 01:10 PM, Luigi Toscano wrote: On Monday 11 of August 2014 13:05:19 Hugo Pereira Da Costa wrote: Hi Milian As someone with no clue: a) what's the advantage of having a native widget style, compared to using QtCurve settings? None, except that you need someone working on qtcurve

Re: Review Request 116044: In kstyle: Use the iconSize from mainToolbar

--- Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116043: prevent crash when no widget is passed to KStyle::styleHint

Description --- see summary Diffs - src/kstyle/kstyle.cpp c0528b3 Diff: https://git.reviewboard.kde.org/r/116043/diff/ Testing --- tested. No crash Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 116043: prevent crash when no widget is passed to KStyle::styleHint

. Repository: frameworkintegration Description --- see summary Diffs - src/kstyle/kstyle.cpp c0528b3 Diff: https://git.reviewboard.kde.org/r/116043/diff/ Testing --- tested. No crash Thanks, Hugo Pereira Da Costa ___ Kde

  1   2   >