D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate marked an inline comment as done. jtamate added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kioexecd.cpp:129 > Maybe `constBegin()`/`constEnd()` here? I always thought const iterators were meant to be used when the whole container is considered ReadOnly, not only its ele

D6513: Add support for Attica tags support

mlaurent accepted this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, Zr

D15213: Provide icons for 2x scaling

ngraham accepted this revision. ngraham added a comment. So if I apply this patch, use a 2x scale factor, and launch Dolphin (from 18.08.2 or git master), I should see all line-art icons in my places panel, right? It works for 2x, and 1.5x, but at 1.7x and 1.3x I hit https://bugs.kde.org/sho

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

kossebau updated this revision to Diff 41078. kossebau added a comment. Dump update with some more changes (still TODOs left to handle) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8708?vs=40990&id=41078 BRANCH addAnnotationItemDelegate REVISION DE

D6513: Add support for Attica tags support

cfeck added a comment. @dfaure, @mlaurent okey? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knew

D6513: Add support for Attica tags support

cfeck accepted this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenB

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

ngraham added a comment. Any progress on this, @emateli? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure Cc: asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. @anemeth, any updates on this? Do you need a hand with anything? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 208 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/208/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 05 Sep 2018 19:23:17 + Build duration: 3 min 26 sec and counting JU

D15071: Don't draw frames and shadows around images with transparency

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck, abetts Cc: anthonyfieroni, markg, abetts, bruns, kde-frameworks-devel, michaelh, ngraham

D15180: kioexecd: watch for creations or modifications of the temporary files

elvisangelaccio accepted this revision. elvisangelaccio added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kioexecd.cpp:129 > +// check if the deleted (and not recreated) files where deleted 30s ago > or more > +for (auto it = m_deleted.begin(); it

D7010: KSqueezedTextLabel: call updateGeometry() when text changes

dhaumann added a subscriber: rkflx. dhaumann added a comment. @dfaure: writing "Henrik" when he already unsubscribeb will never reach him. Ping @rkflx REVISION DETAIL https://phabricator.kde.org/D7010 To: brauch, cfeck, dfaure Cc: rkflx, dfaure, dhaumann, aacid, #frameworks, michaelh, ngra

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate updated this revision to Diff 41066. jtamate added a comment. Use QDateTime::currentDateTimeUtc() instead of QDateTime::currentDateTime(). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15180?vs=41035&id=41066 REVISION DETAIL https://phabricator.kde.

D15074: [server] Do not try to create data offers without source

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH offerWithSourceOnly REVISION DETAIL https://phabricator.kde.org/D15074 To: romangg, #kwin, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with transparency

broulik accepted this revision. broulik added a comment. Alright let's go with this REPOSITORY R241 KIO BRANCH thumbnail-frame-refinement (branched from master) REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck, abetts Cc: anth

D15180: kioexecd: watch for creations or modifications of the temporary files

bruns added inline comments. INLINE COMMENTS > dfaure wrote in kioexecd.cpp:133 > Move the call to currentDateTime() outside of the loop, so it happens only > once. > It's much more costly than one might think (because of timezone conversion, > which uses tzset() etc.) makes me wonder, wouldn'

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate added a comment. May I commit or should I wait for @elvisangelaccio to accept the changes? This time I have read the arc message, that is usually something about non tracked files: Revision 'D15180 : kioexecd: watch for creations or modifications

D15283: Move SMB KCM to Network Settings category

ngraham accepted this revision as: VDG. ngraham added a comment. OK, for now let's move it to the proper place then. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15283 To: broulik, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15283: Move SMB KCM to Network Settings category

broulik added a comment. I investigated once but the SMB kio slave actually still reads these properties. Why it doesn't work, I have no idea. SMB browsing is completely broken in newer distros thanks to switch to SMB >= 2 .. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.o

D15283: Move SMB KCM to Network Settings category

ngraham added a comment. Makes sense, but can we just delete this KCM entirely instead? Apparently it doesn't, um, work. https://bugs.kde.org/show_bug.cgi?id=164283 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15283 To: broulik, #frameworks, #vdg Cc: ngraham, kde-fra

D15240: Create a default wallet when user refuses to do so

ngraham added a comment. In D15240#320867 , @bruns wrote: > Can't we use pam_kwallet to receive the password and automatically create the wallet when the user logs in for the first time? > > Of course, some caveats apply, passwordless login,

D15240: Create a default wallet when user refuses to do so

bruns added a comment. > In D15240#320224 , @abetts wrote: > >> I can see this argument as very valuable. I have also been a little startled by setting this up when you first start using Plasma or create your first password. I have not seen this

D15180: kioexecd: watch for creations or modifications of the temporary files

bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kioexecd.cpp:134 > Also for loop should looks like: > > for (it = begin(); it != end();) { > if () { > it = erase(it); > } else { > ++it; > } > } Even better use the std::remove_if/s

D15071: Don't draw frames and shadows around images with transparency

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH thumbnail-frame-refinement (branched from master) REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck, abetts Cc: anthonyfiero

D15071: Don't draw frames and shadows around images with transparency

bruns added a comment. +1 from me ... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: anthonyfieroni, markg, abetts, bruns, kde-frameworks-devel, michaelh, ngraham

D15240: Create a default wallet when user refuses to do so

McPain added a comment. In D15240#320542 , @ngraham wrote: > I would favor automatically creating a default wallet with the user's current password using a "good enough" cipher that we can hopefully all agree on. This would probably require chan

D15180: kioexecd: watch for creations or modifications of the temporary files

dfaure accepted this revision. dfaure added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15180 To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D15213: Provide icons for 2x scaling

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Alright, Dolphin patches merged to stable. This can go in now, thanks! REPOSITORY R266 Breeze Icons BRANCH 2xIcons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitell

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate updated this revision to Diff 41035. jtamate added a comment. Tested, dirty is not signaled when created (at least I didn't saw the dialog for uploading the modified file). Removed the header. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15180?vs=4

D6513: Add support for Attica tags support

leinir updated this revision to Diff 41034. leinir marked an inline comment as done. leinir added a comment. More codestyle fixes. I also notice some which were there before this work, but fixing that seems distinctly out of scope for this patch... REPOSITORY R304 KNewStuff CHANGES SINCE L

D6513: Add support for Attica tags support

leinir marked 16 inline comments as done. leinir added a comment. i guess uncrustify isn't a magic bullet either, eh? ;) Thanks for the findings! INLINE COMMENTS > cfeck wrote in khotnewstuff_test.cpp:66 > Any rationale for using `fromLocal8Bit()` for fixed strings? If, for whatever > reaso

D15180: kioexecd: watch for creations or modifications of the temporary files

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. No worries, that's what code review is for :-) Now this is starting to look good ;) INLINE COMMENTS > kioexecd.cpp:88 > + > +slotDirty(path); > +} Doesn't kdirwatch emit

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate updated this revision to Diff 41030. jtamate added a comment. Why the mutex? I interpreted that QTimer work as an interrumpt (wrong) instead of generating events in the event queue (right). So I've gone through all the possible mistakes one can do here: - Design mistakes - Sec

D15180: kioexecd: watch for creations or modifications of the temporary files

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kioexecd.cpp:36 > > +const int predefinedTimeout = 3; // 30s > + static const int... > kioexecd.cpp:86 > +{ > +m_deleted_mutex.lock(); > +m_del

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate updated this revision to Diff 41026. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Do not delete recursively. Do not delete the file after 30s (we know it is already deleted). REPOSITORY R241 KIO CHANGES SINCE

D7010: KSqueezedTextLabel: call updateGeometry() when text changes

brauch added a comment. For the record, I tried writing a test for this but didn't succeed and eventually put it aside, although the difference is easily visible in a test application. There must be a reason why the naive test case behaves differently from an interactive application ... I co

D15283: Move SMB KCM to Network Settings category

broulik created this revision. broulik added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The "Connectivity" category is empty and makes it show up on the root level a

D15180: kioexecd: watch for creations or modifications of the temporary files

anthonyfieroni added inline comments. INLINE COMMENTS > jtamate wrote in kioexecd.cpp:65 > There is a slightly problem: QStandardPaths::CacheLocation is application > dependent, and their values doesn't match here: > kioexec: /home/jtorres/.cache/kioexec/ > kioexecd: /home/jtorres/.cache/kiod5/

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kioexecd.cpp:65 > The problem with using `QDir::removeRecursively()` is that the folder we are > going to delete recursively is an input from dbus. What happens if some > malicious software calls `watch("~/dummy.txt")` ?

D15240: Create a default wallet when user refuses to do so

McPain added a comment. In D15240#320542 , @ngraham wrote: > Stuff that doesn't work with KWallet should be fixed. But the point would be moot if we create a default wallet in a more user-friendly manner... I never told that there are stu