Re: Review Request 115185: Integrate kf5dot

On Jan. 21, 2014, 6:16 p.m., Aurélien Gâteau wrote: > > Another option for merging histories is > > http://thread.gmane.org/gmane.comp.version-control.git/5126/ (with some > > modifications; in particular, git-*-cache is now git-*-index). But that > > depends on how much you care about preser

Re: Review Request 115185: Integrate kf5dot

> On Jan. 21, 2014, 6:16 p.m., Alex Merry wrote: > > - files should have licenses and encoding marks > > - "kf5dot" is not very descriptive as a name. I would call the module > > "dependencies" or "depdiags" or something like that, and the scripts > > something similar but with a k or kf5 pref

Re: Review Request 115185: Integrate kf5dot

> On Jan. 21, 2014, 6:16 p.m., Alex Merry wrote: > > src/kapidox/kf5dot/.gitignore, line 1 > > > > > > Unnecessary; kapidox has a top-level .gitignore that already does this Oups, left-over from the import. - Au

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, lines 166-172 > > > > > > These should *not* be renamed, as they are compatibility macros. > > However, they should probably be move

Re: Review Request 115190: Add unit test for KWindowInfo on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115190/ --- (Updated Jan. 22, 2014, 8:14 a.m.) Review request for KDE Frameworks and

Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/ --- Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctool

Re: Review Request 115190: Add unit test for KWindowInfo on X11

> On Jan. 21, 2014, 11:42 p.m., Ben Cooksley wrote: > > I'm afraid the test fails Martin. Guess KWin and Openbox behave differently > > in some areas. > > > > 5/9 Test #5: kwindowsystem-kwindowinfox11test ..***Failed9.96 sec > > * Start testing of KWindowInfoX11Test * >

Re: Split classes into separate files?

Hello, On Wednesday 22 January 2014 00:30:19 David Gil Oliva wrote: > I'm revising KCompletion and I have found that in kcompletion.h you can see > the declaration of KCompletionBase (which is defined in a separate file) > and KCompletionMatches (which is defined in kcompletion.cpp). > > I think

Re: Authors, maintainers and licenses in apidox

On Tuesday 21 January 2014 17:18:36 Alex Merry wrote: > Traditionally, the front pages of our apidox has included a list of > authors, the maintainer(s) and the license. This is obviously > duplicating/summarising information stored elsewhere, and is easy to let > get out of date. Yes... definite

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115210/ --- (Updated Jan. 22, 2014, 2:56 a.m.) Review request for Build System, Extra

Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Review Request 115211: Mark target created by ecm_add_test as non GUI by default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 115209: Fix KDoctools build on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115210/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > Thanks for working on apidox! Sorry for the large number of comments... Wow! You were ultra-fast, just 31 minutes for all this! :-) I will see one by one tomorrow (just wanted to comment about something I clearly don't agree). > On Jan. 2

Re: Review Request 115201: Use qplatformdefs.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/ --- (Updated Jan. 22, 2014, 12:15 a.m.) Status -- This change has been m

Re: Review Request 115201: Use qplatformdefs.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/#review47967 --- This review has been submitted with commit 7076a02f50b48904a0

Re: Review Request 115201: Use qplatformdefs.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/#review47968 --- This review has been submitted with commit 27aa98c3897af28763

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47966 --- This review has been submitted with commit 0971e8cc8daffc1101

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 22, 2014, 12:12 a.m.) Status -- This change has been m

Re: Review Request 115202: Allow building KConfigWidgets on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 22, 2014, 1:06 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review47964 --- Looks like a good idea to me. - Alex Merry On Jan. 21, 2014

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47963 --- Ship it! Works for me now. - Alex Merry On Jan. 21, 2014,

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review47962 --- Think that will make porting easier and avoids boiler plate co

Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 115132: Append 5 to preparetips script & manpage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115132/ --- (Updated Jan. 21, 2014, 11:36 p.m.) Status -- This change has been m

Re: Review Request 115132: Append 5 to preparetips script & manpage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115132/#review47961 --- This review has been submitted with commit 1ea6262185916ae453

Re: Review Request 115200: fix windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/ --- (Updated Jan. 21, 2014, 11:33 p.m.) Status -- This change has been m

Re: Review Request 115200: fix windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/#review47960 --- This review has been submitted with commit 8ea89457676104911e

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47959 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Jan. 21

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 22, 2014, 12:30 a.m.) Review request for KDE Frameworks.

Split classes into separate files?

Hi! I'm revising KCompletion and I have found that in kcompletion.h you can see the declaration of KCompletionBase (which is defined in a separate file) and KCompletionMatches (which is defined in kcompletion.cpp). I think I have seen that in other frameworks classes are being split into separate

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 22, 2014, 12:29 a.m.) Review request for KDE Frameworks.

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47957 --- cmake/FindSharedMimeInfo.cmake

Re: Review Request 115200: fix windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/#review47955 --- Ship it! Still compiles fine for me (Linux, gcc). - Alex Mer

Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115164: Keep tests together

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review47953 --- Seems sensible to me, but I would add Valentin Rusu to the rev

Re: Review Request 115202: Allow building KConfigWidgets on Windows

> On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: > > Jut to be sure, are the two changes (optional KDocTools and the > > not-iterator hack) unrelated? > > Alexander Richardson wrote: > two separate commits, however kdoctools is broken on windows so I made it > optional to allow buildin

Re: Review Request 115132: Append 5 to preparetips script & manpage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115132/#review47951 --- Ship it! Seems sensible to me. - Alex Merry On Jan. 19, 20

Re: Review Request 115099: Add function ecm_generate_pri_file() to provide qmake support. Make ECMSetupVersion set PROJECT_VERSION_*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/#review47948 --- modules/ECMGeneratePriFile.cmake

Re: Review Request 115202: Allow building KConfigWidgets on Windows

> On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote: > > Jut to be sure, are the two changes (optional KDocTools and the > > not-iterator hack) unrelated? > > Alexander Richardson wrote: > two separate commits, however kdoctools is broken on windows so I made it > optional to allow buildin

Re: Review Request 115202: Allow building KConfigWidgets on Windows

> On Jan. 21, 2014, 10:53 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 29 > > > > > > What's the problem with finding documentation on windows? Uh sorry, didn't see somebody went before me :). - Ale

Re: Review Request 115202: Allow building KConfigWidgets on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47947 --- CMakeLists.txt

Re: Review Request 115202: Allow building KConfigWidgets on Windows

> On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: > > Jut to be sure, are the two changes (optional KDocTools and the > > not-iterator hack) unrelated? > > Alexander Richardson wrote: > two separate commits, however kdoctools is broken on windows so I made it > optional to allow buildin

Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/#review47943 --- This review has been submitted with commit 749336963bbcddea2e

Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/ --- (Updated Jan. 21, 2014, 10:42 p.m.) Status -- This change has been m

Re: Review Request 115190: Add unit test for KWindowInfo on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115190/#review47945 --- I'm afraid the test fails Martin. Guess KWin and Openbox behav

Re: Review Request 115202: Allow building KConfigWidgets on Windows

> On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote: > > Jut to be sure, are the two changes (optional KDocTools and the > > not-iterator hack) unrelated? > > Alexander Richardson wrote: > two separate commits, however kdoctools is broken on windows so I made it > optional to allow buildin

Review Request 115203: Allow compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115203/ --- Review request for KDE Frameworks. Repository: kcrash Description -

Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/#review47942 --- Welp, since no-one seems to care, I'm gonna commit it. - Alex

Re: Review Request 115201: Use qplatformdefs.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/#review47940 --- Ship it! Looks good, still compiles fine here (Linux, gcc).

Re: Review Request 115202: Allow building KConfigWidgets on Windows

> On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: > > Jut to be sure, are the two changes (optional KDocTools and the > > not-iterator hack) unrelated? > > Alexander Richardson wrote: > two separate commits, however kdoctools is broken on windows so I made it > optional to allow buildin

Re: Review Request 115197: Allow compiling KTextEditor on Windows

> On Jan. 21, 2014, 11:24 p.m., Christoph Cullmann wrote: > > ++ for platformsdefs, still no idea why we need winsock, thought, need to > > look at that. gethostname is called, I am not familiar enough with the code to say whether that is necessary - Alexander -

Re: Review Request 115197: Allow compiling KTextEditor on Windows

> On Jan. 21, 2014, 10:24 p.m., Christoph Cullmann wrote: > > ++ for platformsdefs, still no idea why we need winsock, thought, need to > > look at that. > > Alexander Richardson wrote: > gethostname is called, I am not familiar enough with the code to say > whether that is necessary I se

Re: Review Request 115202: Allow building KConfigWidgets on Windows

> On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote: > > Jut to be sure, are the two changes (optional KDocTools and the > > not-iterator hack) unrelated? two separate commits, however kdoctools is broken on windows so I made it optional to allow building - Alexander --

Re: Review Request 115197: Allow compiling KTextEditor on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/ --- (Updated Jan. 21, 2014, 10:34 p.m.) Status -- This change has been m

Re: Review Request 115197: Allow compiling KTextEditor on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/#review47938 --- This review has been submitted with commit db925facd7a728753b

Review Request 115200: fix windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/ --- Review request for KDE Frameworks. Repository: kauth Description --

Re: Review Request 115197: Allow compiling KTextEditor on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/#review47934 --- ++ for platformsdefs, still no idea why we need winsock, thoug

Re: Review Request 115202: Allow building KConfigWidgets on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- Jut to be sure, are the two changes (optional KDocTools and th

Review Request 115202: Allow building KConfigWidgets on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Re: kf5options and qt5options manpages

On 21/01/14 18:38, Jonathan Riddell wrote: > > kdeoptions and qtoptions manpages listed the common options to applications > using kdelibs4 and qt4. > > These have just become kf5options and qt5options. There is also --license and --author (via KAboutData).

Review Request 115198: Fix KDE4Support compilation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115198/ --- Review request for KDE Frameworks and David Faure. Repository: kde4suppor

Review Request 115201: Use qplatformdefs.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/ --- Review request for KDE Frameworks. Repository: kbookmarks Description -

Re: kf5options and qt5options manpages

On 21/01/14 18:38, Jonathan Riddell wrote: >--nocrashhandler >Disable the crash handler, to get core dumps. Gone; use KDE_DEBUG=1 instead (see David Faure's email). ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org h

Review Request 115197: Allow compiling KTextEditor on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: kte

Review Request 115199: Fix detection of shared-mime-info on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: KCrash

On Sunday 19 January 2014 20:56:23 David Faure wrote: > On Sunday 19 January 2014 20:44:48 Kevin Ottens wrote: > > What about KCRASH_NO_CRASH_HANDLER ? It's long but it makes it at least > > descriptive. > > Except that it's not technically correct, a crash handler (= a function > called upon cras

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

> On Jan. 21, 2014, 2:57 p.m., David Faure wrote: > > Note that I fixed the "build failure with kdesrc-build" differently - I > > added a "ignore-modules kapidox" in kdesrc-build's include files. > > > > And I don't like that this will break when using a custom prefix and > > PYTHONPATH is not

Re: kf5options and qt5options manpages

Comments from dfaure on https://git.reviewboard.kde.org/r/115065/ >--caption caption >Use caption as name in the titlebar. "Still works with Qt5, but remove one dash. Testcase: kate -caption KATE_KF5 " >--config filename >Use the alternative configurat

kf5options and qt5options manpages

kdeoptions and qtoptions manpages listed the common options to applications using kdelibs4 and qt4. These have just become kf5options and qt5options. But which options are still true? >From qt5options: --display displayname Use the X-server display displayname. --ses

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47918 --- This review has been submitted with commit 84c78978a52cc49089

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/ --- (Updated Jan. 21, 2014, 6:35 p.m.) Status -- This change has been ma

Re: Review Request 114897: Make KDE_ENABLE_EXCEPTIONS a list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114897/ --- (Updated Jan. 21, 2014, 6:14 p.m.) Status -- This change has been di

Review Request 115190: Add unit test for KWindowInfo on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115190/ --- Review request for KDE Frameworks and Ben Cooksley. Repository: kwindowsy

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, lines 166-172 > > > > > > These should *not* be renamed, as they are compatibility macros. > > However, they should probably be move

Review Request 115189: rename dbus interface files for kstatusnotifier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115189/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: knotif

Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/#review47909 --- This review has been submitted with commit 8b055d7f229d6596cf

Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/ --- (Updated Jan. 21, 2014, 5:33 p.m.) Status -- This change has been ma

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/#review47905 --- This review has been submitted with commit a310819d576e267e54

Re: Review Request 115185: Integrate kf5dot

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115185/#review47903 --- - files should have licenses and encoding marks - "kf5dot" is

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/ --- (Updated Jan. 21, 2014, 5:17 p.m.) Status -- This change has been ma

Authors, maintainers and licenses in apidox

Traditionally, the front pages of our apidox has included a list of authors, the maintainer(s) and the license. This is obviously duplicating/summarising information stored elsewhere, and is easy to let get out of date. Do we still want this information? It would probably mean adding it to the R

Review Request 115186: rename dbus interface file for kjobviewer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/ --- Review request for KDE Frameworks. Repository: kjobwidgets Description

Review Request 115185: Integrate kf5dot

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115185/ --- Review request for KDE Frameworks and Alex Merry. Repository: kapidox D

Re: Review Request 115186: rename dbus interface file for kjobviewer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/#review47902 --- https://git.reviewboard.kde.org/r/115188/ kde-workspace updat

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

> On Jan. 21, 2014, 2:57 p.m., David Faure wrote: > > Note that I fixed the "build failure with kdesrc-build" differently - I > > added a "ignore-modules kapidox" in kdesrc-build's include files. > > > > And I don't like that this will break when using a custom prefix and > > PYTHONPATH is not

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/#review47899 --- Ship it! Ship It! - Jonathan Riddell On Jan. 21, 2014, 4:4

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/ --- (Updated Jan. 21, 2014, 4:43 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/#review47897 --- looks good, ksjcmd is just a developer binary so nothing else

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 4:24 p.m.) Status -- This change has been ma

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47894 --- This review has been submitted with commit fc7deb7e9d7a641495

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

> On Jan. 21, 2014, 3:57 p.m., David Faure wrote: > > Note that I fixed the "build failure with kdesrc-build" differently - I > > added a "ignore-modules kapidox" in kdesrc-build's include files. > > > > And I don't like that this will break when using a custom prefix and > > PYTHONPATH is not

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

> On Jan. 21, 2014, 2:57 p.m., David Faure wrote: > > Note that I fixed the "build failure with kdesrc-build" differently - I > > added a "ignore-modules kapidox" in kdesrc-build's include files. > > > > And I don't like that this will break when using a custom prefix and > > PYTHONPATH is not

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

> On Jan. 21, 2014, 3:23 p.m., Martin Gräßlin wrote: > > Ship It! Many thanks to Jonathan for working on this, and Martin for giving a green light! ;-) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://gi

Re: KF5 Update Meeting Minutes 2014-w4

On Tuesday 21 of January 2014 16:42:42 Kevin Ottens wrote: > * tosky found out that the validity of the qtoptions and kdeoptions man > pages is in need of review; > * he's also working with the doc team toward a switch to docbook 4.2; Quick patch: to docbook 4.5 (our documentation is based on 4.2

KF5 Update Meeting Minutes 2014-w4

Hello everyone, This is the minutes of the Week 3 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, arichardson, dfaure, mgraesslin, Riddell, tosky and myself. Announcement: * Come on people, we're still short on maintainers!

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

> On Jan. 21, 2014, 3:16 p.m., Martin Gräßlin wrote: > > something went wrong with the latest patch. CMake looks fine but it > > includes the renamed files. Maybe I'm going mad but I don't see any renamed files in it. Here's the same patch in a pastebin http://paste.ubuntu.com/6792111/ - Jo

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

> On Jan. 21, 2014, 4:16 p.m., Martin Gräßlin wrote: > > something went wrong with the latest patch. CMake looks fine but it > > includes the renamed files. > > Jonathan Riddell wrote: > Maybe I'm going mad but I don't see any renamed files in it. Here's the > same patch in a pastebin >

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47887 --- Ship it! Ship It! - Martin Gräßlin On Jan. 21, 2014, 4:10

  1   2   >