D11290: [UDevManager] Already filter for subsystem before querying

[Michael Pyne]

mpyne added a comment.


  Any reason not to close the bug 391738?  I can do so but wanted to make sure 
it wasn't intentionally left open.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: mpyne, ngraham, michaelh

D11298: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ImproveHlRules (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11298

To: dhaumann, vkrause, jpoelen
Cc: #frameworks, michaelh

D11298: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:cec763566ca4: Optimize highlighting Bash, Cisco, Clipper, 
Coffee, Gap, Haml, Haskell (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11298?vs=29432=29435

REVISION DETAIL
  https://phabricator.kde.org/D11298

AFFECTED FILES
  data/syntax/bash.xml
  data/syntax/cisco.xml
  data/syntax/clipper.xml
  data/syntax/coffee.xml
  data/syntax/gap.xml
  data/syntax/haml.xml

To: dhaumann, vkrause, jpoelen
Cc: #frameworks, michaelh

D10621: Highlighting Indexer: list of suggestions

[Dominik Haumann]

dhaumann added a comment.


  @jpoelen What would be interesting is to check which optimizations are really 
an improvement. Because we should either get a significant speed boost (e.g. 
RegExpr -> WordDetect), or at least reduce memory allocations (possibly 
StringDetect -> Detect2Chars and DetectChar).
  
  Did you do some testing here ?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: vkrause, #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, cullmann

D11298: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: vkrause, jpoelen.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
dhaumann requested review of this revision.

REVISION SUMMARY
  These are some of the optimizations of D10621 


TEST PLAN
  make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ImproveHlRules (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11298

AFFECTED FILES
  data/syntax/bash.xml
  data/syntax/cisco.xml
  data/syntax/clipper.xml
  data/syntax/coffee.xml
  data/syntax/gap.xml
  data/syntax/haml.xml

To: dhaumann, vkrause, jpoelen
Cc: #frameworks, michaelh

Re: D11193: Sonnet : use current hunspell API

[Ivan Čukić]

You should probably add the sonnet maintainer (or whoever committed
the most to the repository in recent months) as the reviewer.

Cheers,
Ivan

On Tue, Mar 13, 2018 at 10:26 AM, René J. V.  Bertin
 wrote:
> Silence means acceptance?
>



-- 
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3  45DF C9C5 77AF 0A37 240A

D10749: Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Questions had been:
  A) names of macro and arguments okay?
  B) other/similar/related use cases which should be covered?
  C) how to design argument passing for all the arg1, arg2, arg3? Is the 
currrent approach sane or how to support someone needing some arg5?
  
  No answers all the time mapped to: current approach okay :)
  
  For usage & purpose of this macro see D11294 
, D11295 
, D11296 

  
  Also related:
  
  - intermediate non-ecm-macro-based fixes for KF5 modules by D10733 
, D10732 
, D10724 

  - related CMake issue https://gitlab.kitware.com/cmake/cmake/issues/17750
  
  Would push Monday, March 19th if no-one objects or has some comment.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: michaelh

D10749: Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau retitled this revision from "[RFC] Add ECMSetupQtPluginMacroNames" to 
"Add ECMSetupQtPluginMacroNames".
kossebau edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: michaelh

D11296: Use ecm_setup_qtplugin_macro_names

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Avoids all the explicit boilerplate needed and allows
  code reusing.
  
  Depends on D10749 

TEST PLAN
  Still builds, generated and installed CMake Config file works
  as before.

REPOSITORY
  R290 KPackage

BRANCH
  useECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D11296

AFFECTED FILES
  CMakeLists.txt
  KF5PackageConfig.cmake.in

To: kossebau, #frameworks
Cc: michaelh

D10749: [RFC] Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau added a dependent revision: D11296: Use ecm_setup_qtplugin_macro_names.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: michaelh

D11295: Use ecm_setup_qtplugin_macro_names

[Aleix Pol Gonzalez]

apol added a comment.


  Looks much better! +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11295

To: kossebau, #plasma, #frameworks
Cc: apol, michaelh

D11295: Use ecm_setup_qtplugin_macro_names

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, Frameworks.
Restricted Application added a project: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Avoids all the explicit boilerplate needed and allows
  code reusing.
  
  Depends on D10749 

TEST PLAN
  Still builds, generated and installed CMake Config file works
  as before.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  useECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D11295

AFFECTED FILES
  CMakeLists.txt
  KF5PlasmaConfig.cmake.in

To: kossebau, #plasma, #frameworks
Cc: michaelh

D10749: [RFC] Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau added a dependent revision: D11295: Use ecm_setup_qtplugin_macro_names.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: michaelh

D10749: [RFC] Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau added a dependent revision: D11294: Use ecm_setup_qtplugin_macro_names.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: michaelh

D11294: Use ecm_setup_qtplugin_macro_names

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Avoids all the explicit boilerplate needed and allows
  code reusing.
  
  Depends on D10749 

TEST PLAN
  Still builds, generated and installed CMake Config file works
  as before.

REPOSITORY
  R244 KCoreAddons

BRANCH
  useECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D11294

AFFECTED FILES
  CMakeLists.txt
  KF5CoreAddonsConfig.cmake.in

To: kossebau, #frameworks
Cc: michaelh

D10749: [RFC] Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 29426.
kossebau added a comment.


  update with documentation completed

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10749?vs=27805=29426

BRANCH
  addECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D10749

AFFECTED FILES
  docs/module/ECMSetupQtPluginMacroNames.rst
  modules/ECMSetupQtPluginMacroNames.cmake

To: kossebau, #build_system, #frameworks
Cc: michaelh

D11290: [UDevManager] Already filter for subsystem before querying

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:3b642556c203: [UDevManager] Already filter for subsystem 
before querying (authored by broulik).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11290?vs=29416=29417

REVISION DETAIL
  https://phabricator.kde.org/D11290

AFFECTED FILES
  src/solid/devices/backends/udev/udevdevice.cpp
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson
Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

[Kai Uwe Broulik]

broulik updated this revision to Diff 29416.
broulik edited the summary of this revision.
broulik added a comment.


  - Check for usb subsystem also in queryDeviceInterface

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11290?vs=29412=29416

REVISION DETAIL
  https://phabricator.kde.org/D11290

AFFECTED FILES
  src/solid/devices/backends/udev/udevdevice.cpp
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson
Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

[Kai Uwe Broulik]

broulik added a comment.


  In D11290#224807 , @davidedmundson 
wrote:
  
  > If you can prove that property is only valid for USB subsystems, then you 
can ship it, otherwise, no.
  
  
  From udev code 
https://github.com/systemd/systemd/blob/master/src/login/70-uaccess.rules#L72
  
SUBSYSTEM=="usb", ENV{ID_MEDIA_PLAYER}=="?*", TAG+="uaccess"

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: ngraham, michaelh

D6313: WIP: Support device pixel ratio in icon loader and engine

[Andrew Crouthamel]

acrouthamel added a comment.


  Hey there, any movement on this? I've been submitting some patches to fix 
icon scaling in apps and have noticed how they switch from monochrome to 
colored (hires) versions when fixed. Getting the underlying issue fixed would 
be great as more people buy HiDPI/Retina displays and run with scaling.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11290: [UDevManager] Already filter for subsystem before querying

[David Edmundson]

davidedmundson added a comment.


  Copying our IRC chat:
  
  I tried something /very very/ similar 
https://phabricator.kde.org/D8495?vs=on=21368=ignore-most#toc 
which merges   queryDeviceInterface into the earlier query.  It didn't work.
  
  This patch is a bit different, it does a coarse filter, then still goes 
through queryDeviceInterface afterwards.
  
  My concern with this is that your filter query for PortableMediaPlayer 
doesn't match what queryDeviceInterface(PortableMediaPlayer) does. 
  That code does "devicesByProperty("ID_MEDIA_PLAYER", QVariant()"
  
  If you can prove that property is only valid for USB subsystems, then you can 
ship it, otherwise, no.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

[Nathaniel Graham]

ngraham added a comment.


  Cool! Any chance we can add an autotest? Solid's code seems somewhat fragile, 
judging by the regressions that were accidentally introduced in 
https://cgit.kde.org/solid.git/commit/?id=1384f275ab2f1ad1841753ee163af6d1b0bb952b

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

[Kai Uwe Broulik]

broulik added a comment.


  It brings the number of sys calls from 28000 down to 860 here using the first 
grep command in the comment, could have helped somewhat I guess but the second 
command is completely bogus for me. needs further investigation. It does give a 
significant speedup which is already worth it ;)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: ngraham, michaelh

D10078: Add separate lib KF5::DBusRunner

[David Edmundson]

davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  If the config modules and runner executables will always be written by the 
same dev and shipped together I don't think we gain much by trying to 
generic-ify it.
  
  The config writing and reading and syncing will all custom so they may as 
well do their own signalling. They can emit an anonymous DBus signal in the 
relevant config plugin ::save() if needed and watching for that in the search 
app. It'll be just 2 lines, and gives more granular control if needed.
  
  > As well as the need to develop multi-agent D-Bus krunner plugin support
  
  I had promised to do that. I'm just incredibly slow on my promises. I'll get 
to it unless you beat me to it.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D10078

To: davidedmundson, broulik, kossebau
Cc: michaelh, ngraham, #frameworks

D11290: [UDevManager] Already filter for subsystem before querying

[Nathaniel Graham]

ngraham added a comment.


  Any chance this fixes https://bugs.kde.org/show_bug.cgi?id=391738?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

To: broulik, #frameworks, davidedmundson
Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  This does some rough filtering in advance before creating our wrapper items 
with properties and all.
  It's quite unlikely for e.g. a CPU core to pose as a media player.

TEST PLAN
  Gives a significant speedup of Dolphin startup for me. Instead of 
KFilePlacesModel spending 120ms querying for Udev devices it only takes 30ms.
  
  My phone still shows up in Dolphin and unplugging and plugging it back in 
also works.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11290

AFFECTED FILES
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson
Cc: michaelh

D11282: less expensive findByUrl in KCoreDirListerCache

[Milian Wolff]

mwolff added a comment.


  have you considered using a hash map instead?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11282

To: jtamate, #frameworks, dfaure
Cc: mwolff, michaelh

D10078: Add separate lib KF5::DBusRunner

[Friedrich W . H . Kossebau]

kossebau added a comment.


  @davidedmundson Thanks for blowing new life into this patch :) The OO 
approach sounds nice and good to have, but no chance yet to look in detail.
  
  While I had started some local changes following your feedback/proposals, I 
had stalled further activity as I got stuck understanding how krunner currently 
supports signalling of plugin config changes (from what I found, currently the 
`Plasma::AbstractRunner::reloadConfiguration()` is not used, instead krunner 
app reloads all plugins on config change of one?) and also as I hit bug 
https://bugs.kde.org/show_bug.cgi?id=389611 ("Milou cancels/resets the search 
if there are no first result after 500 ms") without any direct clue what to do 
there. As well as the need to develop multi-agent D-Bus krunner plugin support. 
Too many road-blocks for my non-urgent needs, so had turned to drive other 
coding entertainment roads noted on my FUNTODO map with more promising quick 
ROI :P
  
  Given the use cases I had in mind for this dbus runner lib, I would like to 
have both things (config change signalling & multi-agent support) first sorted 
out and accordingly integrated into the API, before going public. With your 
active attention again, I will see to get active on this as well again, 
hopefully this or next week :)

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D10078

To: davidedmundson, broulik, kossebau
Cc: michaelh, ngraham, #frameworks

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

[Nathaniel Graham]

ngraham added a comment.


  So this is weird. I thought this patch fixes those KCMs, because I //can/ get 
them into a fixed state, but it doesn't persist afte4r a reboot. Steps to 
reproduce:
  
  - Start with no scale factor
  - Open System Settings > Display & Monitor > Display > Scale and turn on 1.3x 
scaling
  - Restart system settings (and optionally KWin, to get bigger titlebars
  - Navigate to L KCM. **It looks amazing!* F5752524: L looks amazing after 
restarting system settings, but not the whole machine.png 

  - Reboot the machine
  - Navigate to L KCM again.**Text is once again ugly and pixellated, boo!**
  
  Either way, that's probably a separate issue that I'll have to dig into later.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11244

To: ngraham, #plasma, davidedmundson
Cc: mart, broulik, #frameworks, michaelh

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11244

To: ngraham, #plasma, davidedmundson
Cc: mart, broulik, #frameworks, michaelh

D11213: balooctl: Introduce list command

[Michael Heidelbach]

michaelh abandoned this revision.
michaelh added a comment.


  Superseded by D11285  and D11287 


REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11213

To: michaelh, #baloo, #frameworks, smithjd
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11287: Introduce baloodb CLI tool

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: Baloo, Frameworks.
Restricted Application added projects: Frameworks, Baloo.
michaelh requested review of this revision.

REVISION SUMMARY
  This is the command line interface of database sanitizer

TEST PLAN
  Run on command line
  Example:
  
$ baloodb list --missing-only --device-id 2049 '/otto/'
command "list"
Listing database contents...
Missing: device: 2049 inode: 5053 url: /tmp/otto/A
Missing: device: 2049 inode: 9441 url: /tmp/otto/B
Missing: device: 2049 inode: 9464 url: /tmp/otto/B/B.txt
Found 3 matching items
Elapsed: 1.50824 secs

REPOSITORY
  R293 Baloo

BRANCH
  sanitize-cmd (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11287

AFFECTED FILES
  src/tools/CMakeLists.txt
  src/tools/baloodb/CMakeLists.txt
  src/tools/baloodb/Messages.sh
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11287: Introduce baloodb CLI tool

[Michael Heidelbach]

michaelh added a dependency: D11285: Introduce sanitizer class.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

[Nathaniel Graham]

ngraham updated this revision to Diff 29408.
ngraham added a comment.


  "You missed a spot"

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11244?vs=29366=29408

BRANCH
  arcpatch-D11244

REVISION DETAIL
  https://phabricator.kde.org/D11244

AFFECTED FILES
  examples/applets/testtheme/contents/ui/FontGizmo.qml
  src/declarativeimports/plasmacomponents/qml/Label.qml
  src/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmacomponents3/Label.qml
  src/declarativeimports/plasmacomponents3/TextArea.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmastyle/ComboBoxStyle.qml
  src/declarativeimports/plasmastyle/SpinBoxStyle.qml
  src/declarativeimports/plasmastyle/TextAreaStyle.qml
  src/declarativeimports/plasmastyle/TextFieldStyle.qml

To: ngraham, #plasma, davidedmundson
Cc: mart, broulik, #frameworks, michaelh

D11285: Introduce sanitizer class

[Michael Heidelbach]

michaelh added a dependent revision: D11287: Introduce baloodb CLI tool.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11285

To: michaelh, #baloo, #frameworks
Cc: smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11111: Only show supported schemes in KUrlNavigatorProtocolCombo

[Marco Martin]

mart added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D1

To: broulik, #frameworks
Cc: mart, michaelh

D11112: Hide KUrlNavigatorProtocolCombo if there is just one protocol supported

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D2

To: broulik, #frameworks, mart
Cc: michaelh

D11285: Introduce sanitizer class

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: Baloo, Frameworks.
Restricted Application added projects: Frameworks, Baloo.
michaelh requested review of this revision.

REVISION SUMMARY
  Due to device ids being inconstant duplicates are introduced to the database. 
I. e. multiple document ids pointing to the same entity.
  This class shall eventually sanitize the database. Currently it just displays 
the issues should there be any.

REPOSITORY
  R293 Baloo

BRANCH
  sanitize-class (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11285

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/documenturldb.cpp
  src/engine/transaction.h

To: michaelh, #baloo, #frameworks
Cc: smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 7 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/7/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 13 Mar 2018 13:36:35 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.completion_testFailed: TestSuite.vimode_completionFailed: TestSuite.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)88%
(298/337)88%
(298/337)66%
(32633/49317)49%
(16901/34204)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)90%
(4225/4670)48%
(2093/4386)autotests.src.vimode100%
(16/16)100%
(16/16)93%
(5120/5533)48%
(887/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion94%
(15/16)94%
(15/16)36%
(1125/3092)25%
(728/2907)src.completion.expandingtree100%
(5/5)100%
(5/5)9%
(40/454)3%
(9/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/242)src.document100%
(4/4)100%
(4/4)59%
(1887/3184)49%
(1715/3499)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)78%
(951/1220)67%
(631/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1502)1%
(6/731)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
   

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 51 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/51/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 13 Mar 2018 13:36:35 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.completion_testFailed: TestSuite.vimode_completionFailed: TestSuite.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)88%
(298/337)88%
(298/337)66%
(32631/49315)49%
(16899/34204)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)90%
(4224/4669)48%
(2093/4386)autotests.src.vimode100%
(16/16)100%
(16/16)93%
(5120/5533)48%
(887/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion94%
(15/16)94%
(15/16)36%
(1123/3092)25%
(726/2907)src.completion.expandingtree100%
(5/5)100%
(5/5)9%
(40/454)3%
(9/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/242)src.document100%
(4/4)100%
(4/4)59%
(1887/3184)49%
(1715/3499)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)78%
(951/1220)67%
(631/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1502)1%
(6/731)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 37 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/37/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Mar 2018 13:36:35 +
 Build duration:
7 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.completion_testFailed: TestSuite.vimode_completionFailed: TestSuite.vimode_keys

D11278: [KateCompletionWidget] Create configuration interface on demand

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:92e21fb03b7f: [KateCompletionWidget] Create configuration 
interface on demand (authored by broulik).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11278?vs=29382=29400

REVISION DETAIL
  https://phabricator.kde.org/D11278

AFFECTED FILES
  src/completion/katecompletionwidget.cpp

To: broulik, #ktexteditor, dhaumann, kfunk, cullmann
Cc: cullmann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, 
sars, dhaumann

D11190: Make sure we are taking into account hte size of the element when styling

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11190

To: apol, #frameworks, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11279: [FileIndexerConfig] Delay populating folders until actually used

[Michael Heidelbach]

michaelh accepted this revision.
michaelh added a comment.
This revision is now accepted and ready to land.


  Ha! Wonderful, this touches a question I raised on kde-devel ML recently. Say 
we wanted to test this patch. We would need some kind of mock drive, right? I'd 
very much appreciate if you would lay out your thought on this.
  Secondly this illustrates that my comprehension of ABI is still fragmentary. 
Obviously this is not breaking, but I thought it would.
  
  > Dolphin does not gray out sort options and additional roles for Baloo roles 
when disabled but that is a bug unrelated to this change
  
  Didn't see that.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11279

To: broulik, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

[Marco Martin]

mart added a comment.


  if they're somewhat related but not risolutive for some of those bugs, use 
CCBUG: instead

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11244

To: ngraham, #plasma, davidedmundson
Cc: mart, broulik, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 154 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/154/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Mar 2018 10:08:38 +
 Build duration:
1 hr 14 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/25/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 13 Mar 2018 09:53:45 +
 Build duration:
1 hr 20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31651/59675)38%
(18587/48926)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8591/9139)48%
(5248/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8417/14352)50%
(4903/9728)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7876)33%
(1636/4932)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D11282: less expensive findByUrl in KCoreDirListerCache

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  From O(n) in the worst case to at most Log2(n) + O(1) comparisons.
  Unfortunately, fetching the files in a directory is now a little more 
expensive.
  
  CCBUG: 320231

TEST PLAN
  findByUrl was slow, for example, renaming 50.000 small files, it has to go 
through a list of 50.000 items 50.000 times, so renaming that number of files 
takes more than an hour, now it takes less time, but baloo re-scanning and the 
dirlister re-scanning the directory doesn't help to reduce the time.
  
  Moving 50.000 small files from sftp://127.0.0.1/borrar to /borrar1, the first 
step, fetching data from the dirlister took more than 1 minute, now it is 
instantaneous.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11282

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

D11278: [KateCompletionWidget] Create configuration interface on demand

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  I think it is ok that way, too ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11278

To: broulik, #ktexteditor, dhaumann, kfunk, cullmann
Cc: cullmann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, 
sars, dhaumann

D11278: [KateCompletionWidget] Create configuration interface on demand

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  In D11278#224484 , @kfunk wrote:
  
  > Looks like you don't need the member at all? Otherwise late-init wouldn't 
work this way.
  >
  > `m_configWidget` seems only used in `showConfig()`. Let's remove the member 
altogether?
  
  
  Ah, disregard my comment.  If `showConfig()` is invoked multiple times then 
my approach would be slower.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11278

To: broulik, #ktexteditor, dhaumann, kfunk
Cc: kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, 
sars, dhaumann

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

[David Edmundson]

davidedmundson added a comment.


  You've added a load of bug reports about the kcms.
  This patch won't change them at all.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11244

To: ngraham, #plasma, davidedmundson
Cc: broulik, #frameworks, michaelh

D11279: [FileIndexerConfig] Delay populating folders until actually used

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  The folder inclusion/exclusion configuration queries Solid for external media 
to exclude them, this adds a significant overhead to using FileIndexerConfig.
  In most places it is merely used to check whether file indexing is enabled in 
general.

TEST PLAN
  Creating `DolphinViewActionHandler` which checks Baloo availability on 
Dolphin startup showed up as 3% cost in the profiler. After this change it is 
less than 0.4%.
  
  - Verified that Baloo file places disappeared when disabling it
  - Verified that Dolphin search still enabled and disabled additional search 
criteria depending on the folder you're searching in and that it is using 
`baloosearch` or `filenamesearch` accordingly; also verified that the folder 
cache is populated when this happens
  
  Dolphin does not gray out sort options and additional roles for Baloo roles 
when disabled but that is a bug unrelated to this change

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11279

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h

To: broulik, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 153 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/153/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Mar 2018 08:40:04 +
 Build duration:
1 hr 27 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 175 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/175/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 13 Mar 2018 09:32:46 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31584/59673)38%
(18567/48930)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8591/9139)48%
(5247/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8350/14350)50%
(4879/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3890/7876)33%
(1635/4932)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/24/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 13 Mar 2018 08:40:04 +
 Build duration:
1 hr 13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31667/59677)38%
(18590/48926)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8591/9139)49%
(5257/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8443/14354)50%
(4909/9728)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7876)33%
(1636/4932)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
 

D10918: taglibextractor: Refactor for better readability

[Michael Heidelbach]

michaelh added a comment.


  In D10918#224424 , @astippich 
wrote:
  
  > Btw, I'm not opposed anymore for merging before D10803 
, as I need some more time to think about 
the value types and probably also need to extend the tests. I will adapt to the 
changes afterwards.
  
  
  Good! (I always thought it would be easier to apply your patch on top of this 
one). There is no need for you to commandeer this patch anymore. You could 
review it instead ;-)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

Re: D11183: Sonnet: don't impose the default client

[René J . V . Bertin]

This introduces a subtle change in behaviour so I'd appreciate some feedback!

D10694: epubextractor: Handle multiple subjects better

[Michael Heidelbach]

michaelh added a comment.


  A Either I'm completely off-track here or `kfilemetadata` is not 
doing this correctly. 
  I see a lot of statements like `artist += ', ' + value` -> no list!
  `result->add` calls `QMap->addMulti().` This forces the client to iterate 
over the map, which is not necessary.
  In contrary
  
kfilemetadata/src/propertyinfo.cpp: 52
 case Property::AlbumArtist:
d->name = QStringLiteral("albumArtist");
d->displayName = i18nc("@label", "Album Artist");
d->valueType = QVariant::StringList;
break;
  
  The client can call `toVariantMap()` on the extraction result to get a 
`QVariantMap` but not a `QVariant::StringList`.
  I really, really, really do not understand why `kfilemetadata` is not 
delivering a string list. It is much more natural and consistent with the 
announced Property info.
  Also:
  
kfilemetadata/src/properties.h: 282
typedef QMap PropertyMap;
//In taglibextractor never a list --^`
  
  I'm confused.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, 
isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp

D11278: [KateCompletionWidget] Create configuration interface on demand

[Kevin Funk]

kfunk added a comment.


  Looks like you don't need the member at all? Otherwise late-init wouldn't 
work this way.
  
  `m_configWidget` seems only used in `showConfig()`. Let's remove the member 
altogether?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11278

To: broulik, #ktexteditor, dhaumann
Cc: kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, 
sars, dhaumann

Re: D11193: Sonnet : use current hunspell API

[René J . V . Bertin]

Silence means acceptance?

D11278: [KateCompletionWidget] Create configuration interface on demand

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: KTextEditor, dhaumann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  No need to create it immediately. Saves some cycles on startup.

TEST PLAN
  Compiles. I didn't find a way to actually trigger the config UI, though

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11278

AFFECTED FILES
  src/completion/katecompletionwidget.cpp

To: broulik, #ktexteditor, dhaumann
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 174 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/174/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 13 Mar 2018 08:40:04 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31585/59673)38%
(18562/48930)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8591/9139)48%
(5249/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8350/14350)50%
(4879/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7876)33%
(1636/4932)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D10694: epubextractor: Handle multiple subjects better

[Matthieu Gallien]

mgallien added a comment.


  In D10694#224465 , @michaelh wrote:
  
  > In D10694#224440 , @mgallien 
wrote:
  >
  > > Could you please update your diff and we can land it ? This is a useful 
improvement.
  >
  >
  > 1. We can't land it yet. baloo searching breaks with this patch. baloo has 
be adapted first.
  
  
  I trust you on this one but on some property the taglib extractor is already 
doing multiple adds of the same property. It means Baloo is already storing 
lists.
  I can help you but have not much time as usual.
  
  > 1. I don't know what to update. Please tell me once more what you want me 
to change.
  
  You can have a look at the taglib extractor. There are multiple examples of 
for loops adding multiple times the same property.
  
  > For this change concerted actions are needed. Let's discuss general 
questions here:  T8196 
  
  Thanks, this is a good idea.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, 
isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp

D10694: epubextractor: Handle multiple subjects better

[Michael Heidelbach]

michaelh added a comment.


  In D10694#224440 , @mgallien wrote:
  
  > Could you please update your diff and we can land it ? This is a useful 
improvement.
  
  
  1. We can't land it yet. baloo searching breaks with this patch. baloo has be 
adapted first.
  2. I don't know what to update. Please tell me once more what you want me to 
change.
  
  For this change concerted actions are needed. Let's discuss general questions 
here:  T8196 

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, 
isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias added a comment.


  In D1231#224441 , @jtamate wrote:
  
  > As I don't see anything related to security in this patch, I have two 
questions.
  >
  > Could anyone with access to server:port manage the server wayland sessions 
or just create a new session? 
  >  The access control should be done in the firewall?
  
  
  What port? This patch doesn't expose any port.
  No, nobody can manage server sessions with this protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1231: Add Remote Access interface to KWayland

[Jaime Torres Amate]

jtamate added a comment.


  As I don't see anything related to security in this patch, I have two 
questions.
  
  Could anyone with access to server:port manage the server wayland sessions or 
just create a new session? 
  The access control should be done in the firewall?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10694: epubextractor: Handle multiple subjects better

[Matthieu Gallien]

mgallien added a comment.


  In D10694#222674 , @michaelh wrote:
  
  > @mgallien: I think we have a beautiful misunderstanding here :-)
  >
  > In D10694#221719 , @michaelh 
wrote:
  >
  > > This is bad! ...
  >
  >
  > I was referring to baloo inablility to  handle string lists and not to this 
diff.
  >
  > In D10694#221734 , @mgallien 
wrote:
  >
  > > I believe this is quite the opposite. ...
  >
  >
  > I took your answer the wrong way completely. Let's rewind our conversation 
a little
  
  
  No problem from side. In fact this is quite the opposite given you made me 
better understand all this code. I have now to fix Elisa code to handle lists 
where I was expecting a single string.
  
  Could you please update your diff and we can land it ? This is a useful 
improvement.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, 
isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp

D10918: taglibextractor: Refactor for better readability

[Alexander Stippich]

astippich added a comment.


  Btw, I'm not opposed anymore for merging before D10803 
, as I need some more time to think about 
the value types and probably also need to extend the tests. I will adapt to the 
changes afterwards.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin