D16677: Add BrightScript syntax

2018-11-08 Thread Dominik Haumann
dhaumann added a comment.


  Unless you have a KDE commit account you can not commit yourself. 
Unfortunately we cannot see on Phabricator whether you have one or not. We can 
integrate this patch and then it will be in the next KDE Frameworks release, 
i.e. early next month.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D8912: Added a set of Game Folder icons

2018-11-08 Thread Andrey Orst
andreyorst added a comment.


  > @andreyorst, if you're still around, we can review this patch and land it 
once necessary changes are made.
  
  Yeah, I'm here! I'd like to make desired changes myself.
  
  > Nice job on the 64 px icons! However, I noticed that the 16 and 22 px icons 
use a different style and are blurry. Perhaps you should try making the styles 
more similar to the 64 px style and see if you can move, resize or remove any 
details that don't line up with pixels.
  
  So the reason behind this was, that with outline style for 16 and 22 px icons 
all elements like buttons were too small and looked really bad. I've tried lot 
of variants and decided to go for filled icon in the same way how it is done 
for `network-server` icon, which is using (sort of) outline for 64 px and solid 
for 22 px. However (the ticket is quite old) I've changed this somewhere during 
this year, and currently in my system all icons are using filled icons, since I 
feel that this fits more with original style of `applications-games` icon (and 
most of game controllers are black too). I'll submit updated patch this evening.
  
  > I noticed that the 16 and 22 px icons use a different style and are blurry
  
  What screen resolution do you have? Rightnow it looks fine on my system with 
1920x1080 screen. I'll check it at work with 2k screen and scaling turned off.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg
Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns


D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis added a subscriber: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg
Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns


D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16677: Add BrightScript syntax

2018-11-08 Thread Daniel Levin
dlevin added a comment.


  Just double checking whether any additional actions required from my side or 
'landing' a patch means it will be a part of the next release automatically.
  If so then where I could find a release roadmap?
  Thanks in advance!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Add an icon for people that like to have Root (`/`) as a Places bookmark

REPOSITORY
  R266 Breeze Icons

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

AFFECTED FILES
  icons-dark/places/16/folder-root.svg
  icons-dark/places/22/folder-root.svg
  icons-dark/places/32/folder-root.svg
  icons-dark/places/64/folder-root.svg
  icons/places/16/folder-root.svg
  icons/places/22/folder-root.svg
  icons/places/32/folder-root.svg
  icons/places/64/folder-root.svg
  icons/places/symbolic/folder-root-symbolic.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16770: [ftp kio-slave] Fix deletion of directory with non-latin parent path

2018-11-08 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  KRemoteEncoding::directory() returns the encoded path of the directpry,
  while Ftp::ftpFolder() takes the un-encoded version.
  The implicit casting from QByteArray via QString::fromUtf8 to the QString
  type for the Ftp::ftpFolder() arg blocked the compiler from complaining about
  that coding mismatch. Possibly also non-latin1 characters being rare with
  ftp server directory layouts prevented this bug being hit so far.

TEST PLAN
  No ftp server availble with deletion rights myself, so only theoretically
  a bug seen and fixed.

REPOSITORY
  R241 KIO

BRANCH
  fixFtpDirdelete

REVISION DETAIL
  https://phabricator.kde.org/D16770

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  If you do need to, you click on the Add Action... button that's above the 
comment text box and choose "Commandeer Revision"
  
  Anyway, I agree, let's wait for @andreyorst for a bit.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D15999: Add icons with added background to system.svgz

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  Ahh, much better! Reviewing...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment.


  In D8912#356508 , @ngraham wrote:
  
  > All right, let's wait then. You wanna keep an eye on this and make sure it 
doesn't get lost again?
  
  
  Sure. Is there anything special I have to do to commandeer it if he doesn't 
reply? Like an Arcanist or Git command or something?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  All right, let's wait then. You wanna keep an eye on this and make sure it 
doesn't get lost again?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment.


  In D8912#356470 , @ngraham wrote:
  
  > Now that I think about it, you can probably commandeer it and finish it up 
now, and once it's ready we can land it with @andreyorst's authorship 
information. Does that sound okay?
  
  
  Sure, but I saw this diff posted on Reddit here: 
https://old.reddit.com/r/linux/comments/9vaq3x/kde_plasma_5143_bugfix_release_for_november_with/e9b06iv/
  
  There's a decent chance he'll answer soon and I don't want to take over his 
project without giving him a chance to reply.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D16671: Refactor embedded image extractor for greater extensibility

2018-11-08 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> embeddedimagedata.cpp:204
> +TagLib::ByteVector pictureData = (*itApe).second.binaryData();
> +int dataPosition = pictureData.find('\0') + 1;
> +return QByteArray(pictureData.data() + dataPosition, 
> pictureData.size() - dataPosition);

I know you have only moved this code here ...

`TagLib::ByteVector::find` returns `-1` on not found, and we add 1, so this is 
safe here. But maybe we should return `QByteArray()` instead?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16671

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16617: fix extraction of GPS altitude for exif data

2018-11-08 Thread Stefan Brüns
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> exiv2extractor.cpp:285
> +if (it != data.end()) {
> +alt = it->value().toFloat();
> +it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef"));

According to:
https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/GPS.html
and
http://www.cipa.jp/std/documents/e/DC-008-Translation-2016-E.pdf

the absolute altitude value is a rational, like deg/min/sec.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16617

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  Now that I think about it, you can probably commandeer it and finish it up 
now, and once it's ready we can land it with @andreyorst's authorship 
information. Does that sound okay?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  In D15739#356449 , 
@elvisangelaccio wrote:
  
  > In D15739#356003 , @ngraham 
wrote:
  >
  > > This blows up the places tests; will fix them in this patch.
  >
  >
  > It will also break the test in dolphin :(
  
  
  I know, and I'll probably have to fix those with ifdefs :(

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, bruns, 
davidedmundson, abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, 
michaelh, ngraham


D16404: [Bookmarks Runner] Cleanup tests CMakeList

2018-11-08 Thread Stefan Brüns
bruns added a comment.


  Anyone?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16404

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Elvis Angelaccio
elvisangelaccio added a comment.


  In D15739#356003 , @ngraham wrote:
  
  > This blows up the places tests; will fix them in this patch.
  
  
  It will also break the test in dolphin :(

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, bruns, 
davidedmundson, abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, 
michaelh, ngraham


D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

2018-11-08 Thread Stefan Brüns
bruns removed a reviewer: pino.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

2018-11-08 Thread Stefan Brüns
bruns requested review of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

2018-11-08 Thread Stefan Brüns
bruns added a comment.


  @pino - you have not answered for a week.
  
  You have set this to "Needs Revision", which removes it from the "Needs 
Review" queue for everyone else.
  
  If you wan't to see an extractor based on libspectre, thats fine, but then 
**you** have to write it.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D15999: Add icons with added background to system.svgz

2018-11-08 Thread Phil Stefan
pstefan updated this revision to Diff 45137.
pstefan added a comment.


  - Hardcoded background color

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=44890=45137

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment.


  In D8912#356335 , @ngraham wrote:
  
  > Oh gosh, how did we miss this? Yikes, I'm very sorry about that.
  >
  > @andreyorst, if you're still around, we can review this patch and land it 
once  necessary changes are made. If not, maybe @ndavis should commandeer this 
revision and finish it up.
  
  
  If it's necessary, I would be fine with commandeering.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  Oh gosh, how did we miss this? Yikes, I'm very sorry about that.
  
  @andreyorst, if you're still around, we can review this patch and land it 
once  necessary changes are made. If not, maybe @ndavis should commandeer this 
revision and finish it up.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  The image in this patch is out of date since it was added before other 
changes were made; I need to update it and will do so later today.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham


D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  Nice job on the 64 px icons! However, I noticed that the 16 and 22 px icons 
use a different style and are blurry. Perhaps you should try making the styles 
more similar to the 64 px style and see if you can move, resize or remove any 
details that don't line up with pixels.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: kde-frameworks-devel, ndavis, michaelh, ngraham, bruns, #frameworks


D16466: [KSambaShare] Add unit test for "net usershare info" parser

2018-11-08 Thread Ben Cooksley
bcooksley added a comment.


  Thanks for sorting that out.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik, apol
Cc: kossebau, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns


D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Andrew Crouthamel
acrouthamel added a comment.


  In D15739#331468 , @broulik wrote:
  
  > +1 it's an entry I always hide when I setup someone's computer
  >
  > > you can still get to / on your machine in one click using the appropriate 
disk entry on the bottom of the Places panel.
  >
  > Which I think shouldn't be there, but I'm too afraid of touching Solid's 
ignore rules ever again.
  
  
  You advocate for
  
  In D15739#356313 , @Codezela wrote:
  
  > In D15739#356310 , @ndavis wrote:
  >
  > > In D15739#356309 , @Codezela 
wrote:
  > >
  > > > i know that the icons size is adjustable i mean make the default more 
bigger first time u run dolphin this icons is so small "out of the box 
experience"
  > > >  the other thing  i mean we may keep the root partion icon on the 
devices sections and make it fixed position above all other mounted drives so 
even any hd mounted the root icons still top
  > > >  i hope i explain well
  > > >  sorry i know my English is not so good
  > >
  > >
  > > It's ok, I understand now. Those seem like good ideas.
  >
  >
  > sorry but i added some picture after
  >
  > do u see this is my places section
  >  F6398445: Screenshot_20181108_203553.png 

  >  can u tell me where is my root
  >  and the phone icon is on top
  
  
  It will have a new icon as Nate linked to earlier.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham


D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Hazem Salem
Codezela added a comment.


  In D15739#356310 , @ndavis wrote:
  
  > In D15739#356309 , @Codezela 
wrote:
  >
  > > i know that the icons size is adjustable i mean make the default more 
bigger first time u run dolphin this icons is so small "out of the box 
experience"
  > >  the other thing  i mean we may keep the root partion icon on the devices 
sections and make it fixed position above all other mounted drives so even any 
hd mounted the root icons still top
  > >  i hope i explain well
  > >  sorry i know my English is not so good
  >
  >
  > It's ok, I understand now. Those seem like good ideas.
  
  
  sorry but i added some picture after
  
  do u see this is my places section
  F6398445: Screenshot_20181108_203553.png 

  can u tell me where is my root
  and the phone icon is on top

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham


D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Noah Davis
ndavis added a comment.


  In D15739#356309 , @Codezela wrote:
  
  > In D15739#356269 , @ndavis wrote:
  >
  > > In D15739#356026 , @Codezela 
wrote:
  > >
  > > > maybe there is 2 alternatives
  > > >
  > > > 1. remove the icon from devices section and keep it in places section 
with some icon change in the top one
  > >
  > >
  > > You mean hide the root partition from Devices and keep the Root Places 
bookmark? That's what I currently do. I hide my `/` and `/home` partitions and 
use Places to get to those directories.
  > >
  > > > 2. keep it in the places section but change the label to root or system 
and it will always be top of all other hd with the lock emblem in it and remove 
the places one and we need to make the icons little bigger in this  side bar 
what do you think or i come oo late
  > >
  > > This confuses me. You say to keep it in Places, but remove it from 
Places? Keep what above other hard drives?
  > >
  > > BTW, the sidebar icons do have adjustable sizes. Perhaps it should be 
easier to find, but if you right click in an area without something selectable 
(e.g., a section label), you can go to "Icon Size" and change the size to 16, 
22, 32 or 48 px.
  >
  >
  > i know that the icons size is adjustable i mean make the default more 
bigger first time u run dolphin this icons is so small "out of the box 
experience"
  >  the other thing  i mean we may keep the root partion icon on the devices 
sections and make it fixed position above all other mounted drives so even any 
hd mounted the root icons still top
  >  i hope i explain well
  >  sorry i know my English is not so good
  
  
  It's ok, I understand now. Those seem like good ideas.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham


D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Hazem Salem
Codezela added a comment.


  In D15739#356269 , @ndavis wrote:
  
  > In D15739#356026 , @Codezela 
wrote:
  >
  > > maybe there is 2 alternatives
  > >
  > > 1. remove the icon from devices section and keep it in places section 
with some icon change in the top one
  >
  >
  > You mean hide the root partition from Devices and keep the Root Places 
bookmark? That's what I currently do. I hide my `/` and `/home` partitions and 
use Places to get to those directories.
  >
  > > 2. keep it in the places section but change the label to root or system 
and it will always be top of all other hd with the lock emblem in it and remove 
the places one and we need to make the icons little bigger in this  side bar 
what do you think or i come oo late
  >
  > This confuses me. You say to keep it in Places, but remove it from Places? 
Keep what above other hard drives?
  >
  > BTW, the sidebar icons do have adjustable sizes. Perhaps it should be 
easier to find, but if you right click in an area without something selectable 
(e.g., a section label), you can go to "Icon Size" and change the size to 16, 
22, 32 or 48 px.
  
  
  i know that the icons size is adjustable i mean make the default more bigger 
first time u run dolphin this icons is so small "out of the box experience"
  the other thing  i mean we may keep the root partion icon on the devices 
sections and make it fixed position above all other mounted drives so even any 
hd mounted the root icons still top
  i hope i explain well
  sorry i know my English is not so good

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham


D16466: [KSambaShare] Add unit test for "net usershare info" parser

2018-11-08 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  Only saw the note from @bcooksley now, pushed an intermediate disabling of 
the new test for windows, so the build at least passes: 
160df8ed7b49f68e74d30cf4343a6251ed4085d8 

  
  Seems some issue with KSambaShare having the KIOCORE_EXPORT macro set, while 
its source is also compiled into the test binary, where the macro resolves to 
import variant. No instant idea how to fix this best, so leaving to original 
code author/windows experts to sort out, sorry :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik, apol
Cc: kossebau, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 80 - Fixed!

2018-11-08 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/80/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 08 Nov 2018 17:40:41 +
 Build duration:
3 min 37 sec and counting

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 79 - Still Failing!

2018-11-08 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/79/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 08 Nov 2018 17:32:21 +
 Build duration:
4 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 589.99 KB...]kdesktopfileactions.cppdelegateanimationhandler.cpp[ 54%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurlrequester.cpp.obj[ 55%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/krun.cpp.objclipboardupdater.cpppastedialog.cppkabstractfileitemactionplugin.cppkbuildsycocaprogressdialog.cppkfileitemactions.cppkoverlayiconplugin.cppkfileitemdelegate.cppkurlrequester.cppkopenwithdialog.cpppaste.cppkrun.cpp[ 55%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurlpixmapprovider.cpp.obj[ 55%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/sslui.cpp.objkurlpixmapprovider.cppsslui.cpp[ 55%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/pixmaploader.cpp.objpixmaploader.cpp[ 55%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/thumbsequencecreator.cpp.objthumbsequencecreator.cpp[ 55%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/thumbcreator.cpp.obj[ 55%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kshellcompletion.cpp.objthumbcreator.cppkshellcompletion.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurlcompletion.cpp.obj[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurifilter.cpp.objkurlcompletion.cppkurifilter.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/dropjob.cpp.objdropjob.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/openfilemanagerwindowjob.cpp.objopenfilemanagerwindowjob.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/pastejob.cpp.objpastejob.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/previewjob.cpp.objpreviewjob.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/renamedialog.cpp.objC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\widgets\kurlrequester.cpp(432): warning C4996: 'KUrlRequester::fileDialog': was declared deprecatedc:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\widgets\kurlrequester.h(184): note: see declaration of 'KUrlRequester::fileDialog'renamedialog.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kdynamicjobtracker.cpp.objkdynamicjobtracker.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/skipdialog.cpp.objskipdialog.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/jobuidelegate.cpp.objjobuidelegate.cpp[ 56%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kdirlister.cpp.objkdirlister.cpp[ 57%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kdirmodel.cpp.obj[ 57%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/executablefileopendialog.cpp.objkdirmodel.cppexecutablefileopendialog.cpp[ 57%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/dndpopupmenuplugin.cpp.objdndpopupmenuplugin.cpp[ 57%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurifiltersearchprovideractions.cpp.objTODO: add KUser::allUserNames() with a std::function shouldTerminate parameterC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\widgets\previewjob.cpp(773): warning C4996: 'KIO::PreviewJob::PreviewJob': was declared deprecatedC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\widgets\previewjob.cpp(163): note: see declaration of 'KIO::PreviewJob::PreviewJob'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\widgets\previewjob.cpp(786): warning C4996: 'KIO::PreviewJob::PreviewJob': was declared deprecatedC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\widgets\previewjob.cpp(163): note: see declaration of 'KIO::PreviewJob::PreviewJob'kurifiltersearchprovideractions.cpp[ 57%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/krun_win.cpp.objkrun_win.cpp[ 57%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kio_widgets_debug.cpp.obj[ 57%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/KF5KIOWidgets_autogen/mocs_compilation.cpp.objmocs_compilation.cppkio_widgets_debug.cpp[ 57%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kpropertiesdialog.cpp.obj[ 57%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/ksslinfodialog.cpp.obj[ 58%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/ksslcertificatebox.cpp.objksslcertificatebox.cppksslinfodialog.cppkpropertiesdialog.cpp[ 58%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/qrc_kacleditwidget.cpp.obj[ 58%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/fileundomanager.cpp.objqrc_kacleditwidget.cppfileundomanager.cpp[ 58%] Building CXX object 

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham


KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 78 - Still Failing!

2018-11-08 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/78/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 08 Nov 2018 17:15:11 +
 Build duration:
3 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 421.39 KB...]C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(98): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(100): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(103): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(104): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(148): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(105): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(148): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\file\file_win.cpp(106): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\help\kio_help.cpp(314): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of dataC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\help\kio_help.cpp(314): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/main.cpp.obj[ 30%] Building CXX object src/ioslaves/trash/CMakeFiles/kio_trash.dir/kiotrashdebug.cpp.objmocs_compilation.cpp[ 30%] Building CXX object src/gui/CMakeFiles/KF5KIOGui.dir/favicons_debug.cpp.objfavicons_debug.cppmain.cpp[ 30%] Building CXX object src/ioslaves/remote/CMakeFiles/kio_remote.dir/kio_remote_autogen/mocs_compilation.cpp.objmain_ghelp.cpp[ 30%] Built target ktrash5[ 30%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.obj[ 31%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/xslt_help.cpp.objmocs_compilation.cpp[ 31%] Built target kio_http_cache_cleaner[ 31%] Linking CXX shared module ..\..\..\bin\kf5\kio\remote.dll[ 31%] Building CXX object src/ioslaves/trash/CMakeFiles/kio_trash.dir/kio_trash_autogen/mocs_compilation.cpp.objmocs_compilation.cpp[ 31%] Building CXX object src/gui/CMakeFiles/KF5KIOGui.dir/KF5KIOGui_autogen/mocs_compilation.cpp.objmocs_compilation.cpp[ 31%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.obj   Creating library ..\..\..\lib\remote.lib and object ..\..\..\lib\remote.expmocs_compilation.cpp[ 31%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_autogen/mocs_compilation.cpp.objC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(283): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(148): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(285): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(286): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(287): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(148): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(326): 

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 77 - Still Failing!

2018-11-08 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/77/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 08 Nov 2018 17:02:41 +
 Build duration:
2 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 253.35 KB...][  7%] Building CXX object autotests/http/CMakeFiles/httpheaderdispositiontest.dir/httpheaderdispositiontest_autogen/mocs_compilation.cpp.objhttpheaderdispositiontest.cpphttpheadertokenizetest.cppScanning dependencies of target kcookiejar5[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookiejar5_autogen/mocs_compilation.cpp.objmocs_compilation.cppScanning dependencies of target kded_kcookiejardes.cpp[  7%] Building CXX object autotests/http/CMakeFiles/httpheadertokenizetest.dir/httpheadertokenizetest_autogen/mocs_compilation.cpp.obj[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookiejar.cpp.objkcookiejar.cpp[  7%] Built target KF5KIOCore_autogen[  7%] Building CXX object autotests/http/CMakeFiles/httpfiltertest.dir/httpfiltertest.cpp.objhttpfiltertest.cpp[  7%] Building CXX object autotests/http/CMakeFiles/httpfiltertest.dir/__/__/src/ioslaves/http/httpfilter.cpp.obj[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/main.cpp.objmain.cpp[  7%] Linking CXX shared library ..\..\bin\KF5KIONTLM.dll[  7%] Linking CXX executable ..\..\bin\protocoltojson.exe   Creating library ..\..\lib\KF5KIONTLM.lib and object ..\..\lib\KF5KIONTLM.expmocs_compilation.cpp[  8%] Building CXX object autotests/http/CMakeFiles/httpfiltertest.dir/httpfiltertest_autogen/mocs_compilation.cpp.objmocs_compilation.cpp[  8%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookiewin.cpp.objmocs_compilation.cppC:\CI\WORKSP~1\FRAMEW~1\kio\KF5-QT~1.11\src\ioslaves\http\parsinghelpers.cpp(281): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data   Creating library ..\..\lib\KF5KIONTLM.lib and object ..\..\lib\KF5KIONTLM.exp[  8%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookieserverinterface.cpp.obj[  8%] Built target KF5KIONTLM[  8%] Generating klauncher_interface.cpp, klauncher_interface.h[  8%] Linking CXX executable ..\..\..\bin\ktelnetservice5.exeC:\CI\WORKSP~1\FRAMEW~1\kio\KF5-QT~1.11\src\ioslaves\http\parsinghelpers.cpp(281): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kded_kcookiejar_autogen/mocs_compilation.cpp.objC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\autotests\http\httpheadertokenizetest.cpp(107): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of dataC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\autotests\http\httpheadertokenizetest.cpp(165): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of dataC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\autotests\http\httpheadertokenizetest.cpp(195): warning C4551: function call missing argument listhttpfilter.cpp[  9%] Generating kpasswdserver_interface.cpp, kpasswdserver_interface.h[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookieserver.cpp.obj[  9%] Built target protocoltojson[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookieserveradaptor.cpp.obj[  9%] Linking CXX executable ..\..\bin\httpheaderdispositiontest.exe[  9%] Linking CXX executable ..\..\bin\httpheadertokenizetest.exekcookiewin.cppmocs_compilation.cppkcookieserver.cppkcookieserveradaptor.cpp[  9%] Generating klauncher_interface.moc[  9%] Generating kpasswdserver_interface.moc[  9%] Linking CXX executable ..\..\bin\httpfiltertest.exe[  9%] Built target ktelnetservice5kcookieserverinterface.cpp[  9%] Built target httpheadertokenizetest[  9%] Built target httpheaderdispositiontest[  9%] Built target httpfiltertest[  9%] Linking CXX executable ..\..\..\..\bin\kcookiejar5.exeScanning dependencies of target KF5KIOCore[  9%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/idleslave.cpp.obj[  9%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connectionbackend.cpp.obj[  9%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/klocalsocket.cpp.obj[ 10%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connection.cpp.obj[ 10%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connectionserver.cpp.obj[ 10%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/krecentdocument.cpp.obj[ 10%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/tcpslavebase.cpp.obj[ 10%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kfileitemlistproperties.cpp.objidleslave.cpp[ 10%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/directorysizejob.cpp.obj[ 10%] Built target kcookiejar5[ 

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Noah Davis
ndavis added a comment.


  In D15739#356026 , @Codezela wrote:
  
  > maybe there is 2 alternatives
  >
  > 1. remove the icon from devices section and keep it in places section with 
some icon change in the top one
  
  
  You mean hide the root partition from Devices and keep the Root Places 
bookmark? That's what I currently do. I hide my `/` and `/home` partitions and 
use Places to get to those directories.
  
  > 2. keep it in the places section but change the label to root or system and 
it will always be top of all other hd with the lock emblem in it and remove the 
places one and we need to make the icons little bigger in this  side bar what 
do you think or i come oo late
  
  This confuses me. You say to keep it in Places, but remove it from Places? 
Keep what above other hard drives?
  
  BTW, the sidebar icons do have adjustable sizes. Perhaps it should be easier 
to find, but if you right click in an area without something selectable (e.g., 
a section label), you can go to "Icon Size" and change the size to 16, 22, 32 
or 48 px.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham


D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Noah Davis
ndavis added a comment.


  In D15739#356254 , @ngraham wrote:
  
  > This argument doesn't make any sense to me. It's still there available via 
one click. I continue to fail to see how this change makes it not "easily 
accessible through Dolphin at all". You can literally get to / with a single 
click. Also, the Devices section only shows //internal// partitions so it's not 
like there will generally be 15 devices crowding the list. And the entire 
purpose of coming up with a new icon for the rood partition was to make it easy 
to pick out the root partition when there are multiple partitions in the list. 
That change was specifically requested as a precondition for doing this.
  
  
  I'm neutral on this change, but it can be argued that having Root next to all 
the other Places bookmarks makes it easier to reach. That seems rather weak 
though because it's easy to add back to the laces panel and people who might 
not want it in Places are currently unable to remove it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 179 - Fixed!

2018-11-08 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/179/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 08 Nov 2018 15:28:21 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5184/13179)29%
(2741/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1073/1117)51%
(555/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(750/2240)27%
(389/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1698/3504)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
(0/1)0%

D16742: Fix iconitemtest regression

2018-11-08 Thread José Manuel Santamaría Lema
joselema closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16742

To: joselema, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16742: Fix iconitemtest regression

2018-11-08 Thread José Manuel Santamaría Lema
joselema added a commit: R242:ed1724c63e9f: Summary: After this commit 
https://cgit.kde.org/plasma-framework.git/commit/?.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16742

To: joselema, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16733: Capture package metadata before install start

2018-11-08 Thread José Manuel Santamaría Lema
joselema removed a commit: R242:ed1724c63e9f: Summary: After this commit 
https://cgit.kde.org/plasma-framework.git/commit/?.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D16733

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 253 - Still Unstable!

2018-11-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/253/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 08 Nov 2018 15:28:21 +
 Build duration:
3 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13119)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3490)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Nathaniel Graham
ngraham added a comment.


  In D15739#356010 , @davidc wrote:
  
  > I do think changing the default label of `Root`'s mounted device would 
prevent the confusion of the one user who wanted it removed from Devices.
  
  
  Okay great, I will submit a patch to improve that too.
  
  > I think the most emotional respondents consider this change to be 
condescending. Painting `/` as "too dangerous" for the typical user
  
  Who did that? I didn't. In fact, it's the UI itself that currently portrays 
Root as dangerous by displaying it with a red icon. Red == dangerous in our 
design language. If anything, this change makes browsing / //less// dangerous. 
because it's no longer represented by an icon with a red color.
  
  > Removing the quick and easy Places link and relying on users to locate 
`Root` among their mounted physical devices gives the impression that we don't 
`/` to be easily accessible through Dolphin at all, even if people can't do 
anything once they get there.
  
  This argument doesn't make any sense to me. It's still there available via 
one click. I continue to fail to see how this change makes it not "easily 
accessible through Dolphin at all". You can literally get to / with a single 
click. Also, the Devices section only shows //internal// partitions so it's not 
like there will generally be 15 devices crowding the list. And the entire 
purpose of coming up with a new icon for the rood partition was to make it easy 
to pick out the root partition when there are multiple partitions in the list. 
That change was specifically requested as a precondition for doing this.
  
  > I'm also worried this could make things more confusing for truly novice 
users, who may not realize there is a directory structure beyond `Home` at all. 
This can create many problems when trying to understand what the system is 
doing, or when troubleshooting.
  
  "Truly novice users" don't have any desire to browse their computer's 
filesystem. The only people who are ever interested in that are technical 
experts, either actual or aspiring. I don't think this change will deter them 
in any way.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-08 Thread Shubham
shubham removed a reviewer: elvisangelaccio.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, elvisangelaccio
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham


D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis added a reviewer: Localization.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16751

To: snoordhuis, #vdg, #localization
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis reclaimed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16751

To: snoordhuis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16751

To: snoordhuis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis removed a dependent revision: D16749: Various grammar and 
capitalization fixes for UI consistency.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16751

To: snoordhuis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis added a dependent revision: D16749: Various grammar and 
capitalization fixes for UI consistency.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16751

To: snoordhuis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis updated this revision to Diff 45106.
snoordhuis added a comment.


  Removed incorrect changes to MinimizeAll's main.js file

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16751?vs=45096=45106

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16751

AFFECTED FILES
  src/kcms/kio/cache.desktop
  src/kcms/kio/cookies.desktop
  src/kcms/kio/netpref.desktop
  src/kcms/kio/proxy.desktop
  src/kcms/kio/smb.desktop
  src/kcms/kio/useragent.desktop
  src/kcms/webshortcuts/webshortcuts.desktop

To: snoordhuis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-08 Thread Laurent Montel
mlaurent accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns


D16466: [KSambaShare] Add unit test for "net usershare info" parser

2018-11-08 Thread Ben Cooksley
bcooksley added a comment.


  This change broke the build of KIO on Windows - can someone please take a 
look and correct this?
  
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/71/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik, apol
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns


D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis created this revision.
snoordhuis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
snoordhuis requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16751

AFFECTED FILES
  src/kcms/kio/cache.desktop
  src/kcms/kio/cookies.desktop
  src/kcms/kio/netpref.desktop
  src/kcms/kio/proxy.desktop
  src/kcms/kio/smb.desktop
  src/kcms/kio/useragent.desktop
  src/kcms/webshortcuts/webshortcuts.desktop

To: snoordhuis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Hazem Salem
Codezela added a comment.


  there is 2 alternatives
  
  1. remove the icon from devices section and keep it in places section with 
some icon change in the top one
  2. keep it in the places section but change the label to root or system and 
it will always be top of all other hd
  
  with the lock emblem in it and remove the places one

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham