Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

nt32426> it might be a good moment to remove this comment- kioslave/smb/kio_smb_internal.cpp <http://git.reviewboard.kde.org/r/112463/#comment32427> Does it really need QDir::separator()? It seems to me like everything should be '/'. - Aleix Pol Gonzal

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: > > kioslave/smb/kio_smb_auth.cpp, line 76 > > <http://git.reviewboard.kde.org/r/112463/diff/3/?file=222937#file222937line76> > > > > A > > > > xD > > Maybe

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45520 --- Ship it! - Aleix Pol Gonzalez On Dec. 10, 2013, 6:51 p.m

Re: Review Request 114447: Split Frameworks only definitions to a new file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114447/#review45683 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 14, 2013, 3

Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/#review45802 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 16, 2013, 5

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45801 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Dec. 16

Re: Review Request 114683: Clean up target_link_libraries for KF5Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114683/#review46193 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 27, 2013

Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/#review46422 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 29, 2013

Re: Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114917/#review47090 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 8, 2014

Re: Review Request 114937: port kconfig_compiler_kf5 to QCommandLineParser

tps://git.reviewboard.kde.org/r/114937/#comment33590> directoryName is not used now? - Aleix Pol Gonzalez On Jan. 10, 2014, 4:03 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 115016: Make KJob usable from QML

https://git.reviewboard.kde.org/r/115016/diff/ Testing --- Everything still builds, shouldn't be a big deal. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115016: Make KJob usable from QML

nerated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/#review47395 ------- On Jan. 14, 2014, 8:16 p.m., Aleix Pol Gonzalez wrote: > > --- > This is

Review Request 115030: Install public headers for KJsEmbed

now defunct Kross KJS support). https://git.reviewboard.kde.org/r/115027/ Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115016: Make KJob usable from QML

L and check if it succeeded. Diffs - src/lib/jobs/kjob.h 24dbaec Diff: https://git.reviewboard.kde.org/r/115016/diff/ Testing --- Everything still builds, shouldn't be a big deal. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel ma

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

tps://git.reviewboard.kde.org/r/115049/#comment33759> This limits the cwd. Maybe you can pass it as a preprocess definition? aka with add_definitions(-DKTRANSCRIPT_PATH=${blah}) ). - Aleix Pol Gonzalez On Jan. 16, 2014, 11:07 a.m., Aurélien Gâteau

Re: Review Request 115030: Install public headers for KJsEmbed

https://git.reviewboard.kde.org/r/115027/ Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115030: Install public headers for KJsEmbed

--- On Jan. 16, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115030/ > --

Re: Review Request 114699: Use enums instead of ints in method types

source compatibility, but then it improves the API considerably. - Aleix Pol Gonzalez On Jan. 16, 2014, 1:28 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 115030: Install public headers for KJsEmbed

src/kjsembed/pointer.h e25a5e4 Diff: https://git.reviewboard.kde.org/r/115030/diff/ Testing --- I ported the share dataengine to use it (it was using the now defunct Kross KJS support). https://git.reviewboard.kde.org/r/115027/ Thanks, Aleix Pol Gonzalez

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: > > KF5DocToolsMacros.cmake, lines 166-172 > > > > > > These should *not* be renamed, as they are compatibility macros. > > However, they should probably be move

Review Request 115198: Fix KDE4Support compilation

cation.cpp 5a7f4c8 Diff: https://git.reviewboard.kde.org/r/115198/diff/ Testing --- Builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

202/#comment33948> What's the problem with finding documentation on windows? - Aleix Pol Gonzalez On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 115202: Allow building KConfigWidgets on Windows

> On Jan. 21, 2014, 10:53 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 29 > > <https://git.reviewboard.kde.org/r/115202/diff/1/?file=235082#file235082line29> > > > > What's the problem with finding documentation on windows? Uh sor

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47959 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Jan

Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

e all ported because I ported them. OTOH, there will be non-ported applications, that's why we provide this warning. - Aleix Pol Gonzalez On Jan. 22, 2014, 7:01 a.m., David Narváez wrote: > > --- > This is an automatically g

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review47996 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014

Re: Review Request 115198: Fix KDE4Support compilation

. I'm unsure what's the best way though. Diffs - src/kdeui/kapplication.cpp 5a7f4c8 Diff: https://git.reviewboard.kde.org/r/115198/diff/ Testing --- Builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailin

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

> On Jan. 22, 2014, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Well, but frameworks are not only for frameworks. They're all ported > > because I ported them. > > > > OTOH, there will be non-ported applications, that's why we provide this > > warning.

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115213/#review48003 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

> On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: > > This seems sensible to me; however, I do wonder if ECM should also provide > > an ecm_mark_gui_executable function as well (I'm thinking of the case where > > most of the tests should be non-gui, but a handful want to display widgets). Well

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

ul want to display widgets). > > Aleix Pol Gonzalez wrote: > Well, we can't change the default, can we? > > Alex Merry wrote: > I don't understand what you mean. If we have a /mark as non gui/ function is because executables are /gui executables/ by default. Having a

Re: Review Request 115238: Bug in KDEPlatformFileDialogHelper(?) causes selectFile not to work in QFileDialog

tps://git.reviewboard.kde.org/r/115238/#comment34038> no need for this debug. Thanks for improving the test, will have to look into the implementation. :) - Aleix Pol Gonzalez On Jan. 22, 2014, 10:26 p.m., Gregor Mi wrote: > > ---

Re: Review Request 115028: Allow the building of deprecated code to be disabled

erign they already are deprecated in kdelibs 4. I don't really like disabling compilation of deprecated symbols, especially in this case we're not winning that much. - Aleix Pol Gonzalez On Jan. 15, 2014, 1:56 p.m., A

Re: Review Request 114997: Improve KAuth README.md

997/#comment34187> Need to use? link against? Also the "(or similar)" looks unsure. I would say: If you are using cmake, you can find KAuth by using: find_package(KF5Auth NO_MODULE) or finding KF5 with the Auth component, from your CMake scripts. - Aleix Pol G

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48326 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Jan

Re: Review Request 115316: Add demo for KRecentFileList

onstrating the developer that he did it right, but I wouldn't see it as documentation. I would rename it to KRecentFilesActionTest - Aleix Pol Gonzalez On Jan. 25, 2014, 10:56 p.m., Gregor Mi wrote: > > --- > This is an a

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

plication when it's initialized (and if it's an application KAboutData...). - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review48347 ---------

Re: Review Request 115361: use renamed kmailservice5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115361/#review48489 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 28, 2014

Re: Review Request 115362: Do not explicitly link against libc

it's really ugly to have -lc so +1 from me. - Aleix Pol Gonzalez On Jan. 28, 2014, 4:41 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 115376: KDE_SOURCE_FILES_ENABLE_EXCEPTIONS: Handle case where COMPILE_FLAGS is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115376/#review48528 --- Why would it be NOTFOUND? - Aleix Pol Gonzalez On Jan. 29

Re: Review Request 115380: Find QtGui when being consumed

nd it will be searched for already. - Aleix Pol Gonzalez On Jan. 29, 2014, 2:53 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 115382: Remove unused dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115382/#review48548 --- Ship it! Cool :) - Aleix Pol Gonzalez On Jan. 29, 2014, 3

Re: Review Request 115359: rename dbus interface files and .desktop files in kio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115359/#review48551 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 29, 2014

Re: Review Request 115411: Remove obsolete CMake code from pre-splitting

frameworks, actually. All this checking if it's being built out of kdelibs doesn't make sense anymore. - Aleix Pol Gonzalez On Jan. 31, 2014, 12:03 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 115421: Clean up the CMakeLists.txt files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/#review48815 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 1, 2014, 1

Re: Review Request 107791: move Sonnet out of KDEUI, port away from KDE classes.

named? Maybe you forgot some git mv? - Aleix Pol Gonzalez On Feb. 10, 2013, 8:40 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 109524: Remove some compile warnings

On April 7, 2013, 10:26 p.m., Miquel Canes Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109524/ > ---

Review Request 110674: Moving KToolBarSpacerAction to kde4support

PRE-CREATION staging/kde4support/src/kdeui/ktoolbarspaceraction.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110674/diff/ Testing --- Builds and installs fine. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

is is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/#review33247 --- On May 27, 2013, 10:48 p.m., Aleix Pol Gonzalez wrote: > > ---

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

/k3b-spaceraction.png Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

::addSeparator() http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png KToolBarSpacerAction http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

ion in lxr.kde.org > > seems to indicate that none of the apps set these things anyway, so maybe > > addSeparator is enough indeed. > > > > Anyway - please always add @deprecated since 5.0 and the suggested > > replacement, for the benefit of people porting the

Review Request 110815: Move KPassivePopup to KWidgetAddons

/src/kpassivepopup.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110815/diff/ Testing --- It builds fine Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

KToolBarSpacerAction http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110815: Move KPassivePopup to KWidgetAddons

de5e6e4 tier1/kwidgetsaddons/tests/kpassivepopuptest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110815/diff/ Testing --- It builds fine Thanks, Aleix Pol Gonzalez

Review Request 110820: Move KActionSelector to KWidgetAddons

--- Compiled, test seems to work fine. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 110825: Move KEditListWidget to KWidgetAddons

erything builds, the test seems to work Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 110826: Move KRatingPainter and KRatingWidget to KWidgetsAddons

s/src/kratingwidget.h PRE-CREATION tier1/kwidgetsaddons/src/kratingwidget.cpp PRE-CREATION tier1/kwidgetsaddons/tests/CMakeLists.txt bd00be8 tier1/kwidgetsaddons/tests/kratingwidgettest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110826/diff/ Testing --- Thanks, Aleix Pol Gon

Re: Review Request 110825: Move KEditListWidget to KWidgetAddons

.cpp 075bac3 kio/kfile/kurlrequester.h 0b07373 tier1/kwidgetsaddons/src/CMakeLists.txt 9802467 tier1/kwidgetsaddons/tests/CMakeLists.txt bd00be8 Diff: http://git.reviewboard.kde.org/r/110825/diff/ Testing --- everything builds, the test seems to work Th

Re: Review Request 110825: Move KEditListWidget to KWidgetAddons

PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110825/diff/ Testing --- everything builds, the test seems to work Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/

Re: Review Request 110826: Move KRatingPainter and KRatingWidget to KWidgetsAddons

xt 6e7b7ee Diff: http://git.reviewboard.kde.org/r/110826/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 110827: Move KCursor to KWidgetsAddons

/kwidgetsaddons/src/kcursor.cpp PRE-CREATION tier1/kwidgetsaddons/src/kcursor_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110827/diff/ Testing --- builds fine Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks

Review Request 110833: Remove KIconLoader dependency to KWidgets

staging/kiconthemes/src/kiconloader.h e4423eb staging/kiconthemes/src/CMakeLists.txt 82828dc staging/kiconthemes/src/kiconloader.cpp 795ec93 staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e Diff: http://git.reviewboard.kde.org/r/110833/diff/ Testing --- it builds Tha

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

3 staging/kwidgets/src/utils/kglobalsettings.h 5fb1d9b staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e Diff: http://git.reviewboard.kde.org/r/110833/diff/ Testing --- it builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel ma

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

ging/kiconthemes/src/kiconloader.cpp 795ec93 staging/kwidgets/src/utils/kglobalsettings.h 5fb1d9b staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e Diff: http://git.reviewboard.kde.org/r/110833/diff/ Testing --- it builds Thanks, Aleix Pol Gonzalez ___

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/#review33795 --- ping! - Aleix Pol Gonzalez On June 3, 2013, 4:08 p.m

Re: Review Request 110820: Move KActionSelector to KWidgetAddons

//git.reviewboard.kde.org/r/110820/#review33767 --- On June 5, 2013, 1:21 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 110820: Move KActionSelector to KWidgetAddons

tests/kactionselectortest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110820/diff/ Testing --- Compiled, test seems to work fine. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 110815: Move KPassivePopup to KWidgetAddons

s.txt af65f34 tier1/kwidgetsaddons/tests/CMakeLists.txt 85a8732 tier1/kwidgetsaddons/tests/kpassivepopuptest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110815/diff/ Testing --- It builds fine Thanks, Alei

Review Request 110838: Moved KColorCombo to KWidgetsAddons

/kwidgetsaddons/src/kcolorcombo.h PRE-CREATION tier1/kwidgetsaddons/src/CMakeLists.txt 1a2c3e7 Diff: http://git.reviewboard.kde.org/r/110838/diff/ Testing --- The test still runs, seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

s and installs fine. File Attachments ::addSeparator() http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png KToolBarSpacerAction http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png Thanks, Aleix Pol Gon

Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons

/diff/ Testing --- builds and the test seems to work Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons

ddons/tests/CMakeLists.txt 2bb9306 tier1/kwidgetsaddons/tests/kpixmapregionselectordialogtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110847/diff/ Testing --- builds and the test seems to work Thanks, Aleix Pol Gonzalez __

Re: Review Request 110858: Cleanup KDE development scripts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/ --- (Updated June 6, 2013, 11:44 p.m.) Review request for KDE Frameworks and D

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/#review33919 --- ping! - Aleix Pol Gonzalez On June 5, 2013, 3:11 p.m

Re: Review Request 110815: Move KPassivePopup to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110815/#review33920 --- ping! - Aleix Pol Gonzalez On June 5, 2013, 2:12 p.m

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

der.cpp 795ec93 staging/kiconthemes/src/CMakeLists.txt 82828dc staging/kiconthemes/src/kiconloader.h e4423eb Diff: http://git.reviewboard.kde.org/r/110833/diff/ Testing --- it builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel m

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

e.org/r/110833/#review34115 --- On June 10, 2013, 11:07 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

s in > > kde4support at some point). > > Aleix Pol Gonzalez wrote: > Well, then the KWidgets not depending on KIconItems contradicts this > review request, right? > > Kevin Ottens wrote: > Well, not really. Here it's more about removing the dependency on &g

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

akeLists.txt 2775463 staging/kwidgets/src/utils/kglobalsettings.h 5fb1d9b staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e Diff: http://git.reviewboard.kde.org/r/110833/diff/ Testing --- it builds Thanks, Aleix Pol Gonzalez ___ Kde-fram

Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

ATION staging/kwidgets/tests/kpagewidgettest.h PRE-CREATION staging/kwidgets/tests/kpagewidgettest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110997/diff/ Testing --- Everything builds, the test seems good. Thanks, Aleix Pol Gon

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

/git.reviewboard.kde.org/r/110997/#review34320 --- On June 13, 2013, 2:57 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

f173b80 Diff: http://git.reviewboard.kde.org/r/110997/diff/ Testing --- Everything builds, the test seems good. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

> On June 14, 2013, 7:02 a.m., Kevin Ottens wrote: > > OK, this one is way too big. Could you please upload that as two separate > > reviews? One containing the changes to the class (all the porting work you > > did), and one containing just the file moves with the corresponding > > CMakeLists

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/#review34475 --- ping... - Aleix Pol Gonzalez On June 14, 2013, 10:27 a.m

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

good. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111103: KPage* belongs to KWidgetsAddons

sting --- builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

. It's very hard to see the changes you did otherwise. - Aleix Pol Gonzalez On June 18, 2013, 9:38 p.m., Wojciech Kapuscinski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request 111106: Fix export marco in kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/06/#review34625 --- Ship it! Cleaning up! ^^ good stuff - Aleix Pol Gonzalez

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

figuration for > > titlebars will ultimately be unsupported. > > > > Until then, the change can imo not go in before KF5 anyway, because > > it's a very visible behavioral change for users of Laptop, Plastik, BII and > > some legacy decorations (you still

Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

ix Diffs - kdeui/dialogs/kswitchlanguagedialog_p.cpp 7f5fe95 staging/ki18n/src/CMakeLists.txt 8a40160 staging/ki18n/src/klocalizedstring.cpp f8b44b9 Diff: http://git.reviewboard.kde.org/r/78/diff/ Testing --- not much Thanks, Aleix Po

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

AGE? That's a problem because not only this button won't work, but we'll be losing quite some features, potentially... - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

ge, only works when in KDE Workspace > > Kevin Ottens wrote: > Well, obviously khelpmenu wouldn't show the entry in that case. > > Albert Astals Cid wrote: > To be honest, as a user I'd be wildly confused that a menu item is shown > or not shown depen

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

board.kde.org/r/78/diff/ Testing --- not much Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

meworks/Epics/kdelibs_cleanups - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/78/#review35151 --- On June 26, 2013,

Re: Review Request 111298: Add a URL handler for help:/// urls

lp code to call this. Diffs - staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp b8f5fa7 Diff: http://git.reviewboard.kde.org/r/111298/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-dev

Review Request 111298: Add a URL handler for help:/// urls

--- staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp b8f5fa7 Diff: http://git.reviewboard.kde.org/r/111298/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-deve

<    4   5   6   7   8   9   10   11   12   13   >