D25517: Add an option to extract image data and add front cover property

astippich added a comment. ping @bruns this has now been open and unanswered for month! Same for the dependent patches REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77

D25517: Add an option to extract image data and add front cover property

astippich updated this revision to Diff 77954. astippich added a comment. - fix label comment - tweaks - rename flag to ImageData - adress review comments - udpate since tag - update since tag REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Since I got one accept and no other response, I will merge on the weekend REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n

D25518: Extract front cover in the taglib extractor

astippich updated this revision to Diff 77956. astippich added a comment. - adapt to changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25518?vs=73098&id=77956 BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518

D25679: Implement writing of front cover in taglibwriter

astippich updated this revision to Diff 77959. astippich added a comment. - adapt to changes - use QMimeDatabase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25679?vs=73099&id=77959 BRANCH tagLibBinaryWrite REVISION DETAIL https://phabricato

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Due to the recent circumstances I will probably not implement the support in Elisa, so I won't land this unless @bruns explicitly is okay with it (I still think this is an improvement over the status quo). REPOSITORY R286 KFileMetaData REVISION DETAIL https://

D28682: export done signal in filecontentindexer

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Applications can subsribe for new files being indexed by baloo via

D28682: export done signal in filecontentindexer

astippich added a comment. > Quoted Text > >> ! In D28682#644412 , @mgallien wrote: > > This is the reason why it is so slow in Elisa? Do you mean slow for picking up changes in files? Then yes. This happens when a track is modified wh

D28682: export done signal in filecontentindexer

astippich added a comment. Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-deve

D28682: export done signal in filecontentindexer

astippich added a comment. How about committedBatch so that it's clear that they have been committed to the database? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00

D28682: export done signal in filecontentindexer

astippich updated this revision to Diff 79751. astippich added a comment. - rename signal REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28682?vs=79657&id=79751 BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 AFFECTED FILES src

D28682: rename and export done signal in filecontentindexer

astippich retitled this revision from "export done signal in filecontentindexer" to "rename and export done signal in filecontentindexer". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lo

D28682: rename and export done signal in filecontentindexer

astippich marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun,

D28682: rename and export done signal in filecontentindexer

astippich updated this revision to Diff 79904. astippich added a comment. - implement feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28682?vs=79751&id=79904 BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 AFFECTED FILES

D28682: rename and export newBatchTime signal in filecontentindexer

astippich added a comment. Thanks REPOSITORY R293 Baloo BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, ast

D28682: rename and export newBatchTime signal in filecontentindexer

astippich retitled this revision from "rename and export done signal in filecontentindexer" to "rename and export newBatchTime signal in filecontentindexer". astippich edited the summary of this revision. REPOSITORY R293 Baloo BRANCH exportSignal REVISION DETAIL https://phabricator.kde.o

D28682: rename and export newBatchTime signal in filecontentindexer

This revision was automatically updated to reflect the committed changes. Closed by commit R293:19e71b3e4a5f: rename and export newBatchTime signal in filecontentindexer (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28682?vs=79904&id=79

D25517: Add an option to extract image data and add front cover property

astippich abandoned this revision. astippich added a comment. Okay, since there seems to be no interest at all as even a short reply is not given, I am done here REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngra

D25518: Extract front cover in the taglib extractor

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25518 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, s

D25679: Implement writing of front cover in taglibwriter

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25679 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, s

D25515: Only extract lyrics when the plain text flag is set

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, s

D28980: Revert "add Baloo DBus signals for moved or removed files"

astippich removed a reviewer: astippich. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28980 To: bruns, #baloo, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngrah

D29199: honor the extractMetaData flag

astippich created this revision. astippich added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Metadata was extracted unconditionally before. Only do so

D29199: honor the extractMetaData flag

astippich added a dependent revision: D29200: test the extractNothing flag. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D29199 To: astippich, #baloo, bruns, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashapo

D29200: test the extractNothing flag

astippich created this revision. astippich added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Test that nothing is extracted when the corresponding flag

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81248. astippich marked 4 inline comments as done. astippich added a comment. - implement review REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81235&id=81248 BRANCH honorFlag REVISION DETAIL http

D29199: honor the extractMetaData flag

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:99 > when you add the flag check here, you can avoid the extra indentation below. > Likewise in some other places. true, that was still written with D25517 and D25515

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81253. astippich marked an inline comment as done. astippich added a comment. - more fixes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81248&id=81253 BRANCH honorFlag REVISION DETAIL https://ph

D29199: honor the extractMetaData flag

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in xmlextractor.cpp:103 > skipped, `if (!) { continue; }` sorry, that went lost somehow REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D29199 To: astip

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81257. astippich added a comment. - fix another stupid mistake REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81253&id=81257 BRANCH honorFlag REVISION DETAIL https://phabricator.kde.org/D29199 AF

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81258. astippich added a comment. - use continue REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81257&id=81258 BRANCH honorFlag REVISION DETAIL https://phabricator.kde.org/D29199 AFFECTED FILES

D29199: honor the extractMetaData flag

This revision was automatically updated to reflect the committed changes. Closed by commit R286:538c34b58057: honor the extractMetaData flag (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81258&id=81927 REVISION DETAIL

D29200: test the extractNothing flag

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5e1ed919bdf6: test the extractNothing flag (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29200?vs=81237&id=81928 REVISION DETAIL

D11461: rename 64 px icons added for elisa

astippich added a comment. any feedback here? would be great to resolve this for frameworks 5.45 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11461 To: astippich, #breeze, #vdg, andreask Cc: #frameworks, michaelh, ngraham

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Can I land this? phabricator doesn't show it as accepted though REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: andreask, ngraham, #frameworks, michaelh

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. any feedback on this? I would like to land this and then get going with D10803 again REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh Cc

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. It's just testing each file for all available properties, one after another. This revision just adds missing bits to the existing test. Refactoring should be done separately imho INLINE COMMENTS > michaelh wrote in propertyinfo.cpp:98 > Looks unrelated to me. It'

D10803: handle more tags in taglibextractor

astippich added a comment. All of a sudden :) I've been quiet about this because I'd like to resolve the issues regarding strings/stringlists first, so if you have some spare time, please have a look at D11365 . I will rebase after this one landed REPOS

D11365: also test for value types in taglibextractortest and fix errors

astippich added inline comments. INLINE COMMENTS > mgallien wrote in taglibextractor.cpp:363 > Is it really needed to push directly a list ? > You are ignoring the fact that the original developer intended add to be > called once for each value. I would prefer to keep doing that until we can be

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Thanks a lot! REPOSITORY R266 Breeze Icons BRANCH playlist_shuffle_repeat REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: bcooksley, andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

This revision was automatically updated to reflect the committed changes. Closed by commit R266:f0a96f5f85cb: change 32px icons for playlist shuffle and repeat (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10292?vs=29110&id=30868

D11461: rename 64 px icons added for elisa

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0f7c93f1b7e8: rename 64 px icons added for elisa (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11461?vs=29851&id=30869#toc REPOSITORY R266 Breeze Icons CHANGES SIN

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30950. astippich added a comment. - rebase on top of master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=28467&id=30950 BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30951. astippich added a comment. - update value types REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30950&id=30951 BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 AFFEC

D10803: handle more tags in taglibextractor

astippich added a comment. Okay, I changed my mind, I rebased on top of master. Since the other revision needs more time and the new properties behave like the old ones, I'd like to end this long journey and land this revision if no-one objects :) REPOSITORY R286 KFileMetaData BRANCH en

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30955. astippich marked an inline comment as done. astippich added a comment. - fix formatting issues during rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30951&id=30955 BRANCH enhance_taglib

D10803: handle more tags in taglibextractor

astippich marked 3 inline comments as done. astippich added a comment. In D10803#237133 , @michaelh wrote: > Except for the white space stuff I'm still fine with this. Oops, sorry, messed that up during rebase. INLINE COMMENTS > michaelh

D10803: handle more tags in taglibextractor

astippich updated this revision to Diff 30956. astippich added a comment. - remove duplicate genre property for mp3 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30955&id=30956 BRANCH enhance_taglib REVISION DETAIL https://phabricator.

D11365: also test for value types in taglibextractortest and fix errors

astippich planned changes to this revision. astippich added a comment. In D11365#236274 , @michaelh wrote: > This patch should be split. > > 1. Test more properties > 2. Change return types of ... > > Also 'fix errors' in the title is

D11874: change 24px view-media-artist icon

astippich created this revision. astippich added a reviewer: VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY the 24px version of the view-media-artist icon is the only on

D11874: change 24px view-media-artist icon

astippich added a comment. Before F5781105: Screenshot_20180401_222839.png After F5781107: Screenshot_20180401_222817.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874

D10803: handle more tags in taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, spoorun, bruns, a

D10803: handle more tags in taglibextractor

astippich added a comment. @mgallien this should be safe to land now since KF 5.45 has been tagged, right? REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure, michaelh, n

D10803: handle more tags in taglibextractor

astippich added a comment. ping. Can I push? I'm asking again because I don't want to mess up anything before the frameworks release, and this one contains string changes REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astipp

D10803: handle more tags in taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7f9de32eedff: handle more tags in taglibextractor (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10803?vs=30956&id=31950#toc REPOSITORY R286 KFileMetaData CHANGES S

D12156: implement reading of rating tag

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY allows to read the rating stored in the m

D12156: implement reading of rating tag

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11820: Handle properties with multiple values

astippich added a comment. Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with baloo-widgets, only with baloo itself. If there are still changes required in baloo-widgets, I

D11820: Handle properties with multiple values

astippich added a comment. Seems to work just fine, see screenshot: F5808864: Screenshot_20180415_181027.png I did a little bit more testing, and in case you didn't already know: It looks like baloo outputs properties with multiple values as a QVa

D11874: change 24px view-media-artist icon

astippich added a reviewer: andreask. astippich added a comment. ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874 To: astippich, #vdg, andreask Cc: #frameworks, michaelh, ngraham, bruns

D12320: add ability to read embedded cover files

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY read the embedded image of audio files as

D12320: add ability to read embedded cover files

astippich added a comment. This revision is only one possibility and is mainly there to start the discussion again on how to read the embedded picture data from e.g. audio files. Before this can land, Baloo has to be patched in order to cope with binary data. I think for Baloo there are tw

D12156: implement reading of rating tag

astippich added a comment. In D12156#249223 , @mgallien wrote: > Thanks. > Fix one issue and we should be good to go. > Another nice thing is that we should have a portable way to have ratings in Elisa that could be read or write somewhere

D12156: implement reading of rating tag

astippich updated this revision to Diff 32587. astippich added a comment. - implement reading of half star ratings for mp3 and add tests REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=31987&id=32587 BRANCH rating REVISION DETAIL https:/

D12156: implement reading of rating tag

astippich added a comment. code didn't get prettier, but that's the de-facto standard REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12156: implement reading of rating tag

astippich updated this revision to Diff 32591. astippich added a comment. - simplify REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=32587&id=32591 BRANCH rating REVISION DETAIL https://phabricator.kde.org/D12156 AFFECTED FILES autote

D12156: implement reading of rating tag

astippich added a comment. Those formulas didn't work with newly added tests with values from Winamp, Windows Media Player and MediaMonkey. I calculated a linear regression line and this one seems to work with some special case handling REPOSITORY R286 KFileMetaData REVISION DETAIL http

D12156: implement reading of rating tag

astippich added a comment. In D12156#249951 , @michaelh wrote: > It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable? It will be used as a fallback when there is no xattr

D12156: implement reading of rating tag

astippich added a comment. In D12156#249977 , @michaelh wrote: > In D12156#249971 , @astippich wrote: > > > In D12156#249951 , @michaelh wrote: > > > >

D12320: add ability to read embedded cover files

astippich added a comment. In D12320#249982 , @michaelh wrote: > -2 > https://cgit.kde.org/ffmpegthumbs.git/ should be useable, not sure though. It is also disqualified by the fact that it is not in frameworks. I think a nice solution

D12156: implement reading of rating tag

astippich added a comment. In D12156#252575 , @mgallien wrote: > If I have correctly understood the ideas behind the conception of Baloo, we should probably prefer to store the rating with a "native" solution instead of the xattr one that is not

D12320: add ability to read embedded cover files

astippich updated this revision to Diff 33375. astippich added a comment. - new reader for embedded image data REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=32493&id=33375 BRANCH cover_read REVISION DETAIL https://phabricator.kde.org/D

D12320: {RFC] add ability to read embedded cover files

astippich retitled this revision from "add ability to read embedded cover files" to "{RFC] add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, mic

D12320: {RFC] add ability to read embedded cover files

astippich added a comment. So, this is a next attempt trying to create a solution that works for everyone. It is not yet perfect, but I'd like to get some feedback if such an approach is favorable. A new class is created that will handle the cover art. This way, there won't be any interfer

D12156: implement reading of rating tag

astippich added a comment. ping @mgallien REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12156: implement reading of rating tag

astippich added a comment. I agree, there are several problems coming from the fact that we basically have two sources for the same property, which can potentially conflict. Btw, we already have the same issue with the comment property. In D12156#257888

D11874: change 24px view-media-artist icon

astippich added a comment. ping @andreask REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874 To: astippich, #vdg, andreask Cc: #frameworks, michaelh, ngraham, bruns

D12320: {RFC] add ability to read embedded cover files

astippich updated this revision to Diff 33934. astippich added a comment. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. - adjust to feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs

D12320: [RFC] add ability to read embedded cover files

astippich retitled this revision from "{RFC] add ability to read embedded cover files" to "[RFC] add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo, br

D12320: [RFC] add ability to read embedded cover files

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > mgallien wrote in embeddedimagedata.h:40 > You should be using a std::unique_ptr instead of a raw pointer. You also > should take care of either forbidding copy (operator= and copy constructor) > or i

D12800: split tests for better readability

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY create separate test functions for

D12801: search for album artist and albumartist tags in taglibextractor

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY album artist and albumartist tags

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 33955. astippich added a comment. - fix usage of qflags - use unique_ptr REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=33934&id=33955 BRANCH cover_read REVISION DETAIL https://phabricator.kde.o

D12320: [RFC] add ability to read embedded cover files

astippich marked 4 inline comments as done. astippich added a comment. Thanks a lot! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spo

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. In D12320#260761 , @anthonyfieroni wrote: > I do *same* thing in KIO-Extras https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/audiocreator.cpp Yeah, I found that when I was looking into what

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 34012. astippich added a comment. - add an AllImages flag - add simple documentation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=33955&id=34012 BRANCH cover_read REVISION DETAIL https://phabr

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. In D12320#260789 , @anthonyfieroni wrote: > In D12320#260768 , @astippich wrote: > > > Unfortunately, found it only after I wrote all that myself :/ > > > Sorry i do

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. @anthonyfieroni The preview is actually working perfectly fine, my configuration was wrong. I swear I checked it before :) sorry for the noise REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh

D12801: search for album artist and albumartist tags in taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5b6caa0b118b: search for album artist and albumartist tags in taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12801?vs

D12800: split tests for better readability

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0c738df2c2b7: split tests for better readability (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12800?vs=33935&id=34059 REVISION DET

D12932: handle string lists as input

astippich created this revision. astippich added a reviewer: bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY handles string lists as inputs for ba

D12932: handle string lists as input

astippich added a comment. Unfortunately I couldn't find tests that execute this code path. Do we have test for this somewhere? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astipp

D12932: handle string lists as input

astippich updated this revision to Diff 34318. astippich added a comment. - incorporate feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34314&id=34318 BRANCH string_lists REVISION DETAIL https://phabricator.kde.org/D12932 AFFECTED FILE

D12932: handle string lists as input

astippich marked 4 inline comments as done. astippich added a comment. Thanks, and sorry, copied and pasted too quickly without thinking this through REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhni

D12932: handle string lists as input

astippich updated this revision to Diff 34323. astippich added a comment. - fix mistakes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34318&id=34323 BRANCH string_lists REVISION DETAIL https://phabricator.kde.org/D12932 AFFECTED FILES src/

D12932: handle string lists as input

astippich added a comment. with D11365 applied (e.g. multiple entries are string lists) and using a file with multiple artists balooshow -x testmultiple.opus Bitrate: 67000 Channels: 1 Duration: 1 Genre: Genre

D12932: handle string lists as input

This revision was automatically updated to reflect the committed changes. Closed by commit R293:03ab297f2512: handle string lists as input (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34323&id=34395 REVISION DETAIL https://

D12950: add test which checks the property types

astippich created this revision. astippich added reviewers: mgallien, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Check the type of the proper

D12156: implement reading of rating tag

astippich updated this revision to Diff 34398. astippich added a comment. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. - rebase on master - implement rating tag for m4a REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https:

D12156: implement reading of rating tag

astippich added a comment. any comments on the previous discussion? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

  1   2   3   4   5   6   7   8   9   10   >