D11880: Add firewalld icons

2018-04-29 Thread Noah Davis
ndavis added a comment. Can someone review this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze Cc: #frameworks, michaelh, bruns

D11863: Add virt-manager icons

2018-04-29 Thread Noah Davis
ndavis added a reviewer: Breeze. REPOSITORY R266 Breeze Icons BRANCH virt-manager_icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg, ngraham, andreaska, andreask, #breeze Cc: ngraham, andreaska, #frameworks, michaelh, bruns

D11880: Add firewalld icons

2018-04-29 Thread Noah Davis
ndavis added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze Cc: #frameworks, michaelh, bruns

D11863: Add virt-manager icons

2018-04-29 Thread Noah Davis
ndavis added a comment. Since I don't have a developer account, can someone land this for me? REPOSITORY R266 Breeze Icons BRANCH virt-manager_icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg, ngraham, andreaska, andreask Cc: ngraham,

D11863: Add virt-manager icons

2018-04-01 Thread Noah Davis
ndavis added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11863: Add virt-manager icons

2018-04-01 Thread Noah Davis
ndavis added a comment. Screenshot of how they look in use F5780916: Screenshot_20180401_120901.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11863: Add virt-manager icons

2018-04-01 Thread Noah Davis
ndavis created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ndavis requested review of this revision. REVISION SUMMARY 48px color and 22px, 16px monochrome icons for the system tray REPOSITORY R266 Breeze Icons

D11880: Add firewalld icons

2018-04-02 Thread Noah Davis
ndavis added a comment. I did not mean to post this and I have no idea how to delete it REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

2018-04-02 Thread Noah Davis
ndavis edited the summary of this revision. ndavis added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

2018-04-02 Thread Noah Davis
ndavis added a comment. firewall-applet-panic in use F5781583: Screenshot_20180402_041120.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

2018-04-02 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

2018-04-02 Thread Noah Davis
ndavis added a comment. Screenshot of the icons in use F5781576: Screenshot_20180402_035312.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

2018-04-02 Thread Noah Davis
ndavis created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH firewalld_icons (branched from master) REVISION DETAIL

D11880: Add firewalld icons

2018-04-02 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11863: Add virt-manager icons

2018-04-03 Thread Noah Davis
ndavis added a comment. In D11863#238210 , @ngraham wrote: > Looks good to me! Nice use of the Breeze icon style. @andreaska? Thank! If the other reviewer takes a long time to respond, do I still have to wait for their permission to land

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis updated this revision to Diff 42621. ndavis added a comment. Fix stylesheet REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15853?vs=42591=42621 BRANCH new-harddisk-icons (branched from master) REVISION DETAIL

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis added a comment. In D15853#334455 , @ngraham wrote: > In D15853#334425 , @ndavis wrote: > > > Ouch, I was not aware of this. All of the other monochrome icons I made that have been committed

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis added a comment. In D15853#334415 , @pstefan wrote: > In the monochrome icons (size 16px and 22px) you forgot to add the stylesheet. Without it, the monochrome icons won't be able to adapt to a changing color scheme. > You will have

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-08 Thread Noah Davis
ndavis added a comment. @ngraham @broulik Do you have any objections or questions about this commit? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-08 Thread Noah Davis
ndavis added a comment. In D15934#339276 , @ngraham wrote: > I have no objection to the concept, but I like to test patches before I approve them, and I'm still not sure how I would satisfactorily test this without taking up an afternoon

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis added a comment. In D16421#348347 , @ngraham wrote: > Wow, these are truly excellent. I think you've done an amazing job! Thanks! > One thing I'd like to discuss is whether or not we want the `emblem-remove` icon to be red.

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Added outlines to 16 and 22 px icons Improved the legibility of 8px icons Added new 8,

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-24 Thread Noah Davis
ndavis added a comment. In D16421#348363 , @ngraham wrote: > Yeah I understand. I'm not the hugest fan of the orange either, and now that I think about it, semantically it's not really accurate either since that color is for warning or unusual

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348857 , @bruns wrote: > In D16421#348826 , @ndavis wrote: > > > I could, but then I'm running into this issue: T9898 > > >

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348866 , @bruns wrote: > In D16421#348860 , @ndavis wrote: > > > The other issue with using a font based question mark is I also have to use that for the 8px icon

D16421: Improve emblem contrast, legibility and consistency

2018-10-29 Thread Noah Davis
ndavis updated this revision to Diff 44410. ndavis added a comment. Add emblem-readonly REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44313=44410 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-29 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old package-* icons were hard to read and straddled the line between being symbols

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44210. ndavis added a comment. Change style of emblem-symbolic-link REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44201=44210 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44211. ndavis added a comment. Change style of emblem-symbolic-link at 22px REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44210=44211 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348506 , @ngraham wrote: > In D16421#348502 , @ndavis wrote: > > > F6350185: Screenshot_20181025_093827.png > > F6350193:

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348513 , @bruns wrote: > The center link looks slightly too heavy, but imho still better. Might be possible to shave off 1/2 pixel from the link top/bottom. As its a solid area, it should not make it too fuzzy.

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. Something just occurred to me: Why do we use emblems as if they were action buttons in Dolphin? Would it be so bad if Dolphin used `list-add` and `list-remove` instead of `emblem-added` and `emblem-remove`? REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349081 , @ngraham wrote: > This would all require some additional changes in Dolphin and Folder view, of course. So should I change `emblem-added` and `emblem-remove` back to their original colors? It

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349075 , @bruns wrote: > @ndavis - can you upload the `git format-patch -1` output somewhere (temporary)? https://hastebin.com/egepiwurab.diff > There may also be a conceptual issue here -

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349083 , @ngraham wrote: > In D16421#349082 , @ndavis wrote: > > > In D16421#349081 , @ngraham wrote: > > > > > This

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis updated this revision to Diff 44304. ndavis added a comment. Improve arrow visibility on vcs emblems Add emblem-encrypted-locked Change emblem-locked back to orange REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44248=44304 BRANCH

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis updated this revision to Diff 44308. ndavis added a comment. Add dark versions of previous change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44304=44308 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis updated this revision to Diff 44313. ndavis added a comment. Add 16 and 22 px versions of previous change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44308=44313 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis added a comment. In D16421#349331 , @ngraham wrote: > Thanks for the updates. I know it's a PITA, but would you mind updating the image in the Summary section? Done. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis updated this revision to Diff 44736. ndavis added a comment. Removed broken symlink. It was already copied to the emblems/16 directory, but I forgot to remove the old copy. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16588?vs=44713=44736

D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis added a comment. In D16633#353308 , @ngraham wrote: > Thank you! Two comments: > > - I'm not sure using the negative color is appropriate here. That color is used for dangerous operations or error conditions, neither of which apply to

D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG: 399307 I did not add `drive-harddisk-home` in this commit because it was simply too

D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis added a comment. In D16633#353510 , @ngraham wrote: > Hmm, you're right. > > Maybe we could use a slash for the 16px version, and the plasma logo for the larger ones? That would cause confusion though. The meaning of a forward

D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis updated this revision to Diff 44797. ndavis added a comment. Change color of forward slash to grey REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16633?vs=44759=44797 BRANCH drive-harddisk-root_and_home (branched from master) REVISION

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis added a comment. In D16588#352554 , @ngraham wrote: > These are pretty darn good. They no longer have package-related iconography, but maybe that's okay and they never needed it in the first place. I can see how it would actually get in

D16588: Change package manager icons to emblems

2018-11-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis added a comment. In D16588#352847 , @valorie wrote: > Could not Muon be updated in this way as well? It now uses a package icon for all packages which seems a waste of space. Perhaps, and that would be great, but that would have

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44230. ndavis added a comment. Make emblem-question symbol thicker REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44211=44230 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348609 , @ngraham wrote: > JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348702 , @ngraham wrote: > Does this problem still happen after you delete your icon cache? (`rm ~/.cache/icon-cache.kcache`) Yes. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348594 , @ngraham wrote: > Now that I stare at the summary graphics again, the white question mark looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? Other than that, everything looks

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348487 , @bruns wrote: > Can you try the following: > > - Make the center link solid and narower (e.g. 2px height for the 16px one) > - Reduce the height of the right and left links Like this?

D16514: Re-add monochrome link icon as action

2018-10-29 Thread Noah Davis
ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Some action icons were symlinks to `emblem-symbolic-link`. When the new emblem style was applied to

D16514: Re-add monochrome link icon as action

2018-10-29 Thread Noah Davis
ndavis added reviewers: VDG, Breeze. ndavis added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16514 To: ndavis, #vdg, #breeze Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348825 , @bruns wrote: > In D16421#348664 , @ndavis wrote: > > > In D16421#348594 , @ngraham wrote: > > > > > Now

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis updated this revision to Diff 44248. ndavis added a comment. Widen the circular portion of 16/22 px emblem-question icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44230=44248 BRANCH emblem-outlines (branched from master)

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. Slight change to make the 16 and 22 px icons look more like the 8px icon: F6363210: Screenshot_20181026_072203.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc:

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44201. ndavis added a comment. Change emblem-remove color to Plasma Blue, Change style of emblem-symbolic-link REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44194=44201 BRANCH emblem-outlines

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. Here are what the changes look like: 8px symlink emblem, 16px emblem-remove: F6349477: Screenshot_20181025_041309.png Pretty crowded. 16px symlink emblem, 16px emblem-remove: F6349480:

D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis added a comment. In D16772#357086 , @ngraham wrote: > Makes sense to me. Now that I see them all together, I agree that /_ is a bit better. It seems much better for the folder, and at least no worse (and probably a bit better) for the

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Noah Davis
ndavis added a comment. In D15739#356309 , @Codezela wrote: > In D15739#356269 , @ndavis wrote: > > > In D15739#356026 , @Codezela wrote: > > > > >

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Nice job on the 64 px icons! However, I noticed that the 16 and 22 px icons use a different style and are blurry. Perhaps you should try making the styles more similar to the 64 px style and

D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis updated this revision to Diff 45208. ndavis added a comment. Update commit message to more accurately describe the changes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16772?vs=45196=45208 BRANCH folder-root (branched from master)

D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment. In D8912#357074 , @ngraham wrote: > In D8912#357052 , @ndavis wrote: > > > F6403963: Screenshot_20181109_154449.png > > > > Ah,

D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment. In D8912#357072 , @bruns wrote: > Try making the buttons somewhat larger. A 1px circle ends up as light gray square. Think that's perfectly fine. If they were larger, they would completely dominate the icon and

D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment. F6403963: Screenshot_20181109_154449.png Ah, that's much better. The buttons and D-pad are much easier to see. Try making the sides straight since the angle is pretty small for that size already. Kind of like this:

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. In D8912#356470 , @ngraham wrote: > Now that I think about it, you can probably commandeer it and finish it up now, and once it's ready we can land it with @andreyorst's authorship information. Does that sound okay?

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. In D8912#356335 , @ngraham wrote: > Oh gosh, how did we miss this? Yikes, I'm very sorry about that. > > @andreyorst, if you're still around, we can review this patch and land it once necessary changes are made. If

D8912: Added a set of Game Folder icons

2018-11-10 Thread Noah Davis
ndavis added a comment. In D8912#357376 , @ngraham wrote: > @ndavis can help with this, but yeah, we really need to add this information to https://hig.kde.org/style/icon.html. Noah, since you know how to do that, would you mind submitting a HIG

D8912: Added a set of Game Folder icons

2018-11-10 Thread Noah Davis
ndavis added a comment. In D8912#357374 , @andreyorst wrote: > I've thought that that's why we have separate breeze and breeze-dark icons. I don't know how to make it dynamic in Inkscape. Is there's any guide for this? It's a PITA, but to

D8912: Added a set of Game Folder icons

2018-11-10 Thread Noah Davis
ndavis added a comment. Now for some feedback about the latest changes to the icon: Much better! The area around the joysticks could use some cleaning up though. At 100% size, it's not possible to see the joysticks. My suggestion would be to remove the joysticks, but keep the bumps that

D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add an icon for people that like to have Root (`/`) as a Places bookmark REPOSITORY R266

D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. In D8912#356508 , @ngraham wrote: > All right, let's wait then. You wanna keep an eye on this and make sure it doesn't get lost again? Sure. Is there anything special I have to do to commandeer it if he doesn't

D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis added reviewers: Breeze, Plasma. ndavis added projects: VDG, Breeze, Plasma. ndavis added a subscriber: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk,

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot,

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot,

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis, ZrenBot,

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The current colorschemes included in the breeze-light and breeze-dark Plasma themes do not

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis,

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis,

D16810: Update breeze-light and breeze-dark colorschemes

2018-11-10 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16810 To: ndavis, #vdg, #breeze, #plasma Cc: #vdg, kde-frameworks-devel, ggrysuk, alexde, IohannesPetros, ragreen, Pitel, michaelh, crozbo, ndavis,

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I got an error when I tried to land this patch: remote: Audit failure - Commit 5fa9283264f511edf5678cfd09185a16296c7e71 - Non-full name: Rafael I know it might seem

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R266 Breeze Icons BRANCH fix-sublime REVISION DETAIL https://phabricator.kde.org/D16815 To: trickyricky26, #vdg, ndavis Cc: ndavis,

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread Noah Davis
ndavis added a comment. In D16815#357570 , @ngraham wrote: > I know this is a bugfix, but... > > IMHO it's really bad form to design a Breeze version of an app icon that has a totally different visual style from the original--especially if

  1   2   3   4   5   6   7   8   9   10   >