D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. In D11569#245900 , @rkflx wrote: > In D11569#235002 , @ngraham wrote: > > > I'll leave the string the way it is for now so this can go into Frameworks 5.45, and change it af

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. I'll submit some more patches tomorrow. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyf

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. In D11569#235002 , @ngraham wrote: > I'll leave the string the way it is for now so this can go into Frameworks 5.45, and change it after the string freeze. @ngraham Are you still planning to do this? Or should I op

D11569: Improve consistency of "Open With" UI by always showing top app inline

elvisangelaccio added a comment. I didn't notice that this change also affects the context menu of folders. That doesn't make much sense and just clutters the menu, imho. Why would I want an "Open with Gwenview" action if 99% of my folders do not contain pictures? REPOSITORY R241 KIO

D11569: Improve consistency of "Open With" UI by always showing top app inline

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3f5c18e7afd8: Improve consistency of "Open With" UI by always showing top app inline (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=3094

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. Good catch @dfaure, the test does indeed fail after this is patch deployed. I've submitted a fix for the failing test: D11836 , and marked this as a dependency. If and when D11836 is accepted, c

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a dependent revision: D11836: Fix test failure when D11569 lands. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmu

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. Sure, I'll check that out later today. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmustac, davide

D11569: Improve consistency of "Open With" UI by always showing top app inline

dfaure accepted this revision. dfaure added a comment. Looks good to me. Can you just make sure that kde/applications/konqueror/libkonq/autotests/konqpopupmenutest.cpp still passes after these changes? REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAI

D11569: Improve consistency of "Open With" UI by always showing top app inline

abetts accepted this revision. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmustac, davidedmundson, broulik, dfaure, elvisangel

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. Any remaining objections, or can I land this? REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: mmustac, davided

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham marked an inline comment as done. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: mmustac, davidedmundson, broulik, dfaure, elvisan

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham updated this revision to Diff 30940. ngraham added a comment. Implement review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=30584&id=30940 BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kd

D11569: Improve consistency of "Open With" UI by always showing top app inline

elvisangelaccio added a comment. +1 from me, other than the inline comment. INLINE COMMENTS > kfileitemactions.cpp:654 > +// Always show the top app inline > +QAction *act = d->createAppAction(offers.takeFirst(), menu); > +menu->addAction(act); Please use

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. I'll leave the string the way it is for now so this can go into Frameworks 5.45, and change it after the string freeze. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. In D11569#234901 , @ngraham wrote: > I rather prefer Open With > Other Application... myself, and can change it back if folks prefer (I thought you wanted it this way, sorry!). That's what I reckoned, and even recom

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. I rather prefer Open With > Other Application... myself, and can change it back if folks prefer (I thought you wanted it this way, sorry!). REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. You probably had your reasons for also changing back Open With > Other Application…, but I guess this way it's fine too. Accepting for now. If there are no further objections until Thursd

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ngrah

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ng

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham updated this revision to Diff 30584. ngraham added a comment. Remove excessive wordiness REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=30233&id=30584 BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.k

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. The names are determined entirely by the distro packaging. Ubuntu tends to lengthen the names, e.g. "Firefox Web Browser" instead of just "Firefox". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #do

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. In D11569#232567 , @abetts wrote: > the long names that our applications have. @ngraham I don't see that on my system. Is this a custom Kubuntu patch changing some default again in your screenshot? For Open With the

D11569: Improve consistency of "Open With" UI by always showing top app inline

abetts added a comment. This may be different than this patch is intending to address. Let me know if that's the case. Another thing that adds more characters to the menus are the long names that our applications have. Firefox Web Browser Gwenview Image Editor GIMP Image Editor

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. Looked at this now: The first iterations with the long list of apps and the header were not all that great (in particular for folders the list got much too long), but after @anthonyfieroni's idea I guess the current version is quite good. Showing the default app again

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. In D11569#231663 , @mmustac wrote: > I have two questions regarding this "open with" topic. > Is the displayed app the one which is also set as default for this file type or the first alternative (2nd app) ? If it's th

D11569: Improve consistency of "Open With" UI by always showing top app inline

mmustac added a comment. I have two questions regarding this "open with" topic. Is the displayed app the one which is also set as default for this file type or the first alternative (2nd app) ? If it's the default one why should someone make a right click on a file to open it with his/her d

D11569: Improve consistency of "Open With" UI by always showing top app inline

davidedmundson added a comment. +1 looks good REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

broulik added a comment. "Open With..." are quite memorable labels used in Windows, I fear "Open With Application" will take away the recognizability of "Öffnen mit …" in German to "Mit Anwendung öffnen". But I won't object. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.or

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. @ngraham Thanks for setting me as a reviewer, I try to have a look before Frameworks string freeze on saturday. Focussing on on Apps string freeze today ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #framework

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham retitled this revision from "Improve consistency of "Open With" UI" to "Improve consistency of "Open With" UI by always showing top app inline". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangel

D11569: Improve consistency of "Open With" UI

anthonyfieroni added reviewers: dfaure, elvisangelaccio. anthonyfieroni added subscribers: elvisangelaccio, dfaure. anthonyfieroni added a comment. +1 @dfaure and @elvisangelaccio can have other objections. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngra

D11569: Improve consistency of "Open With" UI

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

ngraham updated this revision to Diff 30233. ngraham added a comment. Use `takeFirst()` to avoid a separate `remove()` invocation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=30227&id=30233 BRANCH open-with-usability (branched from master) REVISI

D11569: Improve consistency of "Open With" UI

anthonyfieroni added inline comments. INLINE COMMENTS > kfileitemactions.cpp:654 > +// Always show the top app inline > +QAction *act = d->createAppAction(offers.first(), menu); > +menu->addAction(act); Use offers.takeFirst(), it will get and remove. > kfilei

D11569: Improve consistency of "Open With" UI

abetts added a comment. +1 on this! Easy access to apps! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

ngraham updated this revision to Diff 30227. ngraham added a comment. Add a separator to the top menu when there's a submenu REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=30226&id=30227 BRANCH open-with-usability (branched from master) REVISION DE

D11569: Improve consistency of "Open With" UI

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

ngraham retitled this revision from "Improve usability of "Open With" UI" to "Improve consistency of "Open With" UI". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngrah