D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY More convenient than having to construct a proper escaped commandline.

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. KProcessRunner::KProcessRunner(QString cmd) calls KProcess::setShellCommand(cmd) which ... has two modes. Either KShell::splitArgs()[0] finds an executable that exists (checking that there

D28513: smb: use prettyname.local for hostname of wsdiscoveries

sitter created this revision. sitter added reviewers: ngraham, meven. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously we simply used the ip address. this is fairly

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir marked 4 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > meven wrote in jobtest.cpp:1530 > If you want to avoid doing this you can remove fields asked from statDetails > `KIO::StatBasic | KIO::StatUser | KIO::StatInode` for instance. > And have a more

D28513: smb: use prettyname.local for hostname of wsdiscoveries

sitter added a comment. Competes with D27902 While this diff runs the risk of not being able to resolve 100% of the time (sans ip address fallback in listDir) it has the huge advantage that discovery isn't getting super slow when multiple wsd hosts are

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79133. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. - Less stat details, in that unit test we're interested in Inode stuff - In the test, return early if we can't find two separate partitions REPOSITORY R241 KIO CHANGES

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik added a comment. Ok, makes sense. Just realized: do I need to `quoteArgs` the `executable`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28498: [xdgoutput] Explicitly set version of server interface

zzag added inline comments. INLINE COMMENTS > display.h:297 > + */ > +XdgOutputManagerInterface *createXdgOutputManager(const > XdgOutputInterfaceVersion , QObject *parent = nullptr); > + You can't introduce another createXdgOutputManager() because it's not overloaded. You probably

Re: Problems in KWayland causes by API and ABI compatibility promises

Kevin, thanks for your input. I think there's a general feeling towards forking the server completely. But we need to decide something concrete, and this ML is dying down. I propose we have a voice/video chat with the objective of agreeing on a concrete plan both short term and for KF6 and then

D28528: UDSEntry: add constructor variant with std::initializer_list

kossebau added inline comments. INLINE COMMENTS > apol wrote in udsentry.h:127 > I'm not sure, it skips the constructor/destructor, but then when it's a > string we need to do a memcopy. Are you sure this is faster than the > refcounting? Do you mean deep-copy by memcopy? There should be no

D28506: [QueryParser] Fix broken detection of end quote

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6be616f64b13: [QueryParser] Fix broken detection of end quote (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28506?vs=79114=79171 REVISION

D28501: [SearchStore] Use categorized logging

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D28501 To: bruns, #baloo, ngraham Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas,

D28504: [EngineQuery] Remove unused position member, extend tests

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a6112063b9fa: [EngineQuery] Remove unused position member, extend tests (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28504?vs=79112=79169

D28503: [Term] Make debug output more compact and nicer to read

This revision was automatically updated to reflect the committed changes. Closed by commit R293:36803b7199f9: [Term] Make debug output more compact and nicer to read (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28503?vs=79111=79168

D28505: [EngineQuery] Provide toString(Term) overload for QTest

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1f9ed1db7e27: [EngineQuery] Provide toString(Term) overload for QTest (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28505?vs=79113=79170

D28528: UDSEntry: add constructor variant with std::initializer_list

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY For entries with fixed set of fields having an initializer list

D28528: UDSEntry: add constructor variant with std::initializer_list

apol added inline comments. INLINE COMMENTS > udsentry.h:127 > +// holds either the numeric or the string value > +// done to avoid unneeded QString constructor & destructor in case of > numeric value > +union U { I'm not sure, it skips the constructor/destructor, but then when

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

kossebau added a comment. D28528 now up additionally, for those cases where a init list could be used instead. Having challenged myself, I even found some pattern for doing a union with non-trivial constructors, which is a bit ugly, but makes one

D28501: [SearchStore] Use categorized logging

bruns updated this revision to Diff 79172. bruns added a comment. . REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28501?vs=79108=79172 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28501 AFFECTED FILES src/lib/searchstore.cpp To:

D28355: Introduce function ecm_install_configured_file

davidedmundson updated this revision to Diff 79176. davidedmundson added a comment. extra escape Not needed for the tests, yet weirdly threw an error in plasma... REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28355?vs=79115=79176 BRANCH

D28470: WIP: IconItem: Refactor source handling for different types

cblack added a comment. Splitting into multiple classes seems like a good idea, but "strategy"? Seems like an odd choice of name to me. INLINE COMMENTS > iconitem.cpp:58 > + > +class NullStategy : public IconItemStrategy > +{ Is this class necessary? I feel like this class's behaviour

D28528: UDSEntry: add constructor variant with std::initializer_list

apol added a comment. +1 Makes sense, the code looks a bit fiddly but should allow cleaner code. INLINE COMMENTS > kossebau wrote in udsentry.h:127 > Do you mean deep-copy by memcopy? There should be no such, the > `UDSEntryInitListEntry(uint field, const QString )` constructor does a >

D28397: Replace Vokoscreen with VokoscreenNG

harogaston updated this revision to Diff 79185. harogaston added a comment. Removed unnesessary changes to .desktop as indicated REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28397?vs=78778=79185 BRANCH update-vokoscreen-url (branched from master)

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 236 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/236/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 Apr 2020 03:26:23 + Build duration: 56 sec and counting CONSOLE OUTPUT [...truncated 619

D28501: [SearchStore] Use categorized logging

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6a0be3910727: [SearchStore] Use categorized logging (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28501?vs=79172=79186 REVISION DETAIL

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/50/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 03 Apr 2020 03:26:22 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.14 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.14/15/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 03 Apr 2020 03:26:26 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated 657

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/23/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 03 Apr 2020 03:26:22 + Build duration: 2 min 28 sec and counting CONSOLE OUTPUT

D28295: Introduce KNotificationJobUiDelegate

broulik added a comment. Is this good now? But I think I'll wait until after tagging, it's not really urgent to get it in REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To: broulik, #frameworks, nicolasfella, dfaure Cc: kossebau, kde-frameworks-devel,

D28510: [kprocessrunner] Escape hyphen characters in scope names

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28510 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28494: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R275:8696ae59a274: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D28498: [xdgoutput] Explicitly set version of server interface

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in display.h:296 > I can't make it explicit. It's not a constructor Passing an enum as const& is wrong although it doesn't make much of a difference in practice. `You can't introduce another createXdgOutputManager() because

D28513: smb: use prettyname.local for hostname of wsdiscoveries

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I like this much better too! Stable branch? REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513 To: sitter, ngraham, meven

D28488: [Fstab] Ensure uniqueness for all filesystem types

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. Good idea, we should fix this once and for all. Two points though about udi form : 1/ Nfs udi would no be great. For instance the source for nfs is usually of the form :

D28488: [Fstab] Ensure uniqueness for all filesystem types

meven added a reviewer: sitter. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28498: [xdgoutput] Explicitly set version of server interface

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Implication being that when v2 is used name and description will

D28295: Introduce KNotificationJobUiDelegate

This revision was automatically updated to reflect the committed changes. Closed by commit R289:3dafde9c61b9: Introduce KNotificationJobUiDelegate (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28295?vs=78839=79104 REVISION

D28500: [PhraseAndIteratorTest] Cleanup, use better variable names

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Instead of pi1...piN, use something better tractable. No functional

D28501: [SearchStore] Use categorized logging

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN no functional changes REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL

D28503: [Term] Make debug output more compact and nicer to read

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Do not print the property name if it is not specified (i.e. the default).

D28488: [Fstab] Ensure uniqueness for all filesystem types

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Fine REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel,

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. bruns added a comment. In D28488#639942 , @broulik wrote: > Wat. So maybe we need to add a hash of mount options to it? (Though I personally would call that pebkac) +1 INLINE COMMENTS > sitter

D28220: Switch to using Kirigami's ShadowedRectangle

This revision was automatically updated to reflect the committed changes. Closed by commit R304:aa29f344928e: Switch to using Kirigamis ShadowedRectangle (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78430=79109 REVISION

D28502: [baloosearch] Bail out early if specified folder is not valid

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN $> baloosearch -d /foo "test" /foo is not a valid directory REPOSITORY R293

D28504: [EngineQuery] Remove unused position member, extend tests

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The "pos" member is unused, remove it from the EngineQuery class. TEST PLAN

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > sitter wrote in fstabhandling.cpp:131 > mountpoints are not unique Of course they are - you can just mount one fs at a path at any time. REPOSITORY R245 Solid REVISION DETAIL

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > Of course they are - you can just mount one fs at a path at any time. λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o

D28488: [Fstab] Ensure uniqueness for all filesystem types

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28295: Introduce KNotificationJobUiDelegate

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I'm OK with this landing into 5.69 Feel free to emit a description from the two new jobs. Thanks, David. REPOSITORY R289 KNotifications REVISION DETAIL

D28499: [LauncherJobs] Emit description

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Provides for better error reporting. TEST PLAN Can't go in before tagging due

D28505: [EngineQuery] Provide toString(Term) overload for QTest

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Without the overload QTest only provides the generic "Compared values are

D28506: [QueryParser] Fix broken detection of end quote

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case the a closing quote was not followed by any term, but only

D28488: [Fstab] Ensure uniqueness for all filesystem types

broulik added a comment. Wat. So maybe we need to add a hash of mount options to it? (Though I personally would call that pebkac) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel,

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns added a comment. In D28488#639815 , @meven wrote: > Good idea, we should fix this once and for all. > Two points though about udi form : > > 1/ Nfs udi would no be great. > For instance the source for nfs is usually of the form :

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabhandling.cpp:131 > +// for different users. Make sure it is unique by appending the > +// mountpoint (which is unique). > +return source +

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28355: Introduce function ecm_install_configured_file

davidedmundson marked 3 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > kossebau wrote in ECMConfiguredInstall.cmake:62 > Actually, _configure_args could be a list (starting with empty, not "") and > one would do list(APPEND). And cmake would then properly

D28355: Introduce function ecm_install_configured_file

davidedmundson updated this revision to Diff 79115. davidedmundson marked an inline comment as done. davidedmundson added a comment. update REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28355?vs=78887=79115 BRANCH master REVISION DETAIL

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

dfaure added a comment. Good question. I haven't seen that done in most callers, but indeed, what if it's in a path with a space, like often happens on Windows? It sounds like the answer is yes, it should be quoted. The real answer is to write a CommandLauncherJob unittest for such a

D28503: [Term] Make debug output more compact and nicer to read

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28503 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28504: [EngineQuery] Remove unused position member, extend tests

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28504 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28521: Use more UDSEntry::reserve() calls to avoid reallocson multiple inserts

ahmadsamir added a comment. Typo in commit message "reallocson". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28521 To: kossebau, #frameworks, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28520: Fix lifetime of slot in KIO-MTP

feverfew created this revision. feverfew added reviewers: akrutzler, dfaure, elvisangelaccio. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY This slot was incorrectly made to

D28501: [SearchStore] Use categorized logging

ngraham added inline comments. INLINE COMMENTS > bruns wrote in searchstore.cpp:239 > Its hardly more than reformatting. But the commit message is about categorized logging, not reformatting. Just do the reformatting in a separate commit, no need for review I'd say REPOSITORY R293 Baloo

D28521: Use more UDSEntry::reserve() calls to avoid reallocson multiple inserts

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R241 KIO BRANCH moreudsentryreserve REVISION DETAIL

D28505: [EngineQuery] Provide toString(Term) overload for QTest

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28505 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28506: [QueryParser] Fix broken detection of end quote

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops! REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28506 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

kossebau retitled this revision from "Use more UDSEntry::reserve() calls to avoid reallocson multiple inserts" to "Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28521 To: kossebau, #frameworks,

D28502: [baloosearch] Bail out early if specified folder is not valid

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28502 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > You let the old comment pass without any further remarks, but now you start > nitpicking? > > From the acessibility viewpoint of the mount, it is unique. The previous comment was factually correct, it never

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 02 Apr 2020 10:22:23 + Build duration: 1 min 14 sec and counting JUnit Tests Name:

D28498: [xdgoutput] Explicitly set version of server interface

davidedmundson marked an inline comment as done. davidedmundson added inline comments. INLINE COMMENTS > apol wrote in display.h:287 > Should we deprecate the one without version? I'll add a doc. I don't want to waste time with the macro stuff given we know there's only one user. >

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > I got the impression you liked being lax. Guess only when the shoe is on the > other foot. I do like being lax! I literally gave you a ship it despite your comment being literally wrong. Picking on useless

D28501: [SearchStore] Use categorized logging

apol added inline comments. INLINE COMMENTS > searchstore.cpp:239 > else if (property == "includefolder") { > -const QByteArray folder = > QFile::encodeName(QFileInfo(value.toString()).canonicalFilePath()); > +const QFileInfo fi = QFileInfo(value.toString()); > +

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > sitter wrote in fstabhandling.cpp:131 > The comment is still wrong. You let the old comment pass without any further remarks, but now you start nitpicking? From the acessibility viewpoint of the mount, it

D28498: [xdgoutput] Explicitly set version of server interface

anthonyfieroni added inline comments. INLINE COMMENTS > display.h:296 > + */ > +XdgOutputManagerInterface *createXdgOutputManager(const > XdgOutputInterfaceVersion , QObject *parent = nullptr); > + explicit, also take enum class by value. REPOSITORY R127 KWayland REVISION DETAIL

D28510: [kprocessrunner] Escape hyphen characters in scope names

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Desktop names can be from the set "ASCII letters, digits, dash (U+002D HYPHEN-MINUS) and underscore

D28501: [SearchStore] Use categorized logging

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28501 To: bruns, #baloo, ngraham Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D28501: [SearchStore] Use categorized logging

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > apol wrote in searchstore.cpp:239 > This change is not related to what the commit message describes. Its hardly more than reformatting. REPOSITORY R293 Baloo REVISION DETAIL

D28488: [Fstab] Ensure uniqueness for all filesystem types

This revision was automatically updated to reflect the committed changes. Closed by commit R245:e468daf0d100: [Fstab] Ensure uniqueness for all filesystem types (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28488?vs=79067=79126 REVISION

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > sitter wrote in fstabhandling.cpp:131 > The previous comment was factually correct, it never claimed the same source > on the same mount would be differentiated. Your comment on the other hand > does and

D28498: [xdgoutput] Explicitly set version of server interface

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in display.h:296 > I agree it's weird to take a const&, but it's what the others do I can't make it explicit. It's not a constructor REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28498

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > The first mount is no longer visible, it is shadowed by the first one. You > can not read any files from it or write to it. You can not unmount it. The comment is still wrong. REPOSITORY R245 Solid

D28498: [xdgoutput] Explicitly set version of server interface

apol added a comment. Some concerns at the documentation level. Looks good overall. INLINE COMMENTS > display.h:287 > */ > XdgOutputManagerInterface *createXdgOutputManager(QObject *parent = > nullptr); > Should we deprecate the one without version? >

D28324: [Inotify] Remove dead/duplicate code

bruns marked 5 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28324 To: bruns, #baloo, ngraham Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D28502: [baloosearch] Bail out early if specified folder is not valid

This revision was automatically updated to reflect the committed changes. Closed by commit R293:04a0b6348c10: [baloosearch] Bail out early if specified folder is not valid (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28502?vs=79110=79123

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28498: [xdgoutput] Explicitly set version of server interface

davidedmundson updated this revision to Diff 79127. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28498?vs=79102=79127 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28498 AFFECTED FILES

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

meven added a comment. Just a few nitpicks in test and this is good IMHO INLINE COMMENTS > jobtest.cpp:1516 > +QVERIFY2(job->exec(), qPrintable(job->errorString())); > +// TODO set setSide > +const KIO::UDSEntry = job->statResult(); Can remove > jobtest.cpp:1530 > +#if 1 //

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

kossebau added a comment. Yes, I had also looked into adding a constructor with std::initializer_list for more code sugar, but found no way to deal with both QString & longlong where the overhead needed would be worth this. At least by the numbers the benchmark gave me And there are only

D28522: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL

This revision was automatically updated to reflect the committed changes. Closed by commit R304:d63e8bf49ce5: [QtQuick dialog] Port to UrlBUtton and hide when theres no URL (authored by ngraham). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

kossebau added a comment. Looking at kio-extras, seems there are quite some more cases where the number of values inserted is fixed. Okay, I will revive my std::initializer_list code again, in a separate patch, there are enough use-cases available, so at least the sugar code is nice to

D28522: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL

ngraham created this revision. ngraham added reviewers: leinir, KNewStuff, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Port from `linkButton` to `UrlButton` for links that open webpages, as

D28520: Fix lifetime of slot in KIO-MTP

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 To: feverfew, akrutzler, dfaure, elvisangelaccio,

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

apol added a comment. +1 Makes sense. Would it be possible to have a constructor such as this? const UDSEntry destUds = { { UDSEntry::UDS_NAME, d->dest.fileName()} , { UDSEntry::UDS_MODIFICATION_TIME, mtimeDest.toMSecsSinceEpoch() / 1000} ,

D28522: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH port-to-urlbutton (branched from master) REVISION DETAIL https://phabricator.kde.org/D28522 To: ngraham, leinir, #knewstuff, #vdg, apol Cc: kde-frameworks-devel, LeGast00n,