[COMMIT master] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6

2009-07-01 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Conflicts: fs/eventfd.c Signed-off-by: Avi Kivity a...@redhat.com -- To unsubscribe from this list: send the line unsubscribe kvm-commits in the body of a message to majord...@vger.kernel.org More majordomo info at

[COMMIT master] Disable msix save/load if msix is not supported

2009-07-01 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/hw/msix.c b/hw/msix.c index 4ab6da6..754531f 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -286,6 +286,10 @@ void msix_save(PCIDevice *dev, QEMUFile *f) { unsigned nentries = (pci_get_word(dev-config +

[COMMIT master] Fix KVMs GET_SUPPORTED_CPUID feature usage

2009-07-01 Thread Avi Kivity
From: Andre Przywara andre.przyw...@amd.com If we want to trim the user provided CPUID bits for KVM to be not greater than that of the host, we should a) not remove the bits _after_ we sent them to the kernel and b) not do the bitmangling on the original values while sending a copy This fixes

[COMMIT master] KVM: switch coalesced mmio changes to slots_lock

2009-07-01 Thread Avi Kivity
From: Michael S. Tsirkin m...@redhat.com switch coalesced mmio slots_lock. slots_lock is already taken for read everywhere, so we only need to take it for write when changing zones. This is in preparation to removing in_range and kvm-lock around it. Signed-off-by: Michael S. Tsirkin

[COMMIT master] KVM: document locking for kvm_io_device_ops

2009-07-01 Thread Avi Kivity
From: Michael S. Tsirkin m...@redhat.com slots_lock is taken everywhere when device ops are called. Document this as we will use this to rework locking for io. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/virt/kvm/iodev.h

[COMMIT master] KVM: switch pit creation to slots_lock

2009-07-01 Thread Avi Kivity
From: Michael S. Tsirkin m...@redhat.com switch pit creation to slots_lock. slots_lock is already taken for read everywhere, so we only need to take it for write when creating pit. This is in preparation to removing in_range and kvm-lock around it. Signed-off-by: Michael S. Tsirkin

[COMMIT master] KVM: remove in_range from io devices

2009-07-01 Thread Avi Kivity
From: Michael S. Tsirkin m...@redhat.com This changes bus accesses to use high-level kvm_io_bus_read/kvm_io_bus_write functions. in_range now becomes unused so it is removed from device ops in favor of read/write callbacks performing range checks internally. This allows aliasing (mostly for

[COMMIT master] KVM: document lock nesting rule

2009-07-01 Thread Avi Kivity
From: Michael S. Tsirkin m...@redhat.com Document kvm-lock nesting within kvm-slots_lock Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index db2a116..05b6bc7 100644 --- a/virt/kvm/kvm_main.c +++

[COMMIT master] KVM: Fix IA32e Windows can't boot issue

2009-07-01 Thread Avi Kivity
From: Sheng Yang sh...@linux.intel.com One typo in commit: KVM: convert custom marker based tracing to event traces caused: set_cr8: #GP, reserved bits 0x7f when try to boot up IA32e Windows guest. One value has been written to R8 instead of specific register, then the value of specific

[COMMIT master] KVM: fix lock imbalance

2009-07-01 Thread Avi Kivity
From: Jiri Slaby jirisl...@gmail.com There is a missing unlock on one fail path in ioapic_mmio_write, fix that. Signed-off-by: Jiri Slaby jirisl...@gmail.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c index e4deae0..124ecf7 100644 ---

[COMMIT master] KVM: Trace mmio

2009-07-01 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 18f5c93..6263991 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -37,6 +37,8 @@ #include linux/iommu.h #include linux/intel-iommu.h #include

[COMMIT master] KVM: Trace irq level and source id

2009-07-01 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h index 5e69489..0735b56 100644 --- a/include/trace/events/kvm.h +++ b/include/trace/events/kvm.h @@ -9,18 +9,23 @@ #if defined(__KVM_HAVE_IOAPIC)

[COMMIT master] KVM: Ignore PCI ECS I/O enablement

2009-07-01 Thread Avi Kivity
From: Andre Przywara andre.przyw...@amd.com Linux guests will try to enable access to the extended PCI config space via the I/O ports 0xCF8/0xCFC on AMD Fam10h CPU. Since we (currently?) don't use ECS, simply ignore write and read attempts. Signed-off-by: Andre Przywara andre.przyw...@amd.com

Re: Exception handling between QEMU and KVM

2009-07-01 Thread Alexander Graf
On 01.07.2009, at 05:28, Christoffer Dall wrote: Hi all. We are still working on our ARM port of KVM and we are managing to let the guest decompress the kernel image and run from relocated address and we can support enabling MMU before this. Howver, to debug relocated micro-hypervisor for

KVM and 32-bit hosts -- still supposed to work?

2009-07-01 Thread Duck
I'm on 32-bit Linux, kernel 2.6.27.7-smp. When I moved from kvm-83 to kvm-87 plus kvm-kmod-devel-87, my Linux host VMs ran fine. But my XP0 host simply ran too slowly to be useable at all, and my Windows 7 host wouldn't boot -- just crashed and restarted early in the boot process. Seeing the

[PATCH] qemu-kvm: remove CPUID host hacks

2009-07-01 Thread Andre Przywara
KVM provides an in-kernel feature to disable CPUID bits that are not present in the current host. So there is no need here to duplicate this work. Additionally allows 3DNow! on capable processors, since the restriction seems to apply to QEMU/TCG only. Signed-off-by: Andre Przywara

Re: [PATCH] qemu-kvm: remove CPUID host hacks

2009-07-01 Thread Alexander Graf
On 01.07.2009, at 09:22, Andre Przywara wrote: KVM provides an in-kernel feature to disable CPUID bits that are not present in the current host. So there is no need here to duplicate this work. Additionally allows 3DNow! on capable processors, since the restriction seems to apply to

Re: pci_stub and kvm

2009-07-01 Thread Avi Kivity
On 07/01/2009 07:18 AM, Yinghai Lu wrote: [ 1966.343286] [ 1966.343288] === [ 1966.356756] [ INFO: possible circular locking dependency detected ] [ 1966.356759] 2.6.31-rc1-tip-00978-g99123e5-dirty #438 [ 1966.356761]

[PATCH] KVM: Fix IA32e Windows can't boot issue

2009-07-01 Thread Sheng Yang
One typo in commit: KVM: convert custom marker based tracing to event traces caused: set_cr8: #GP, reserved bits 0x7f when try to boot up IA32e Windows guest. One value has been written to R8 instead of specific register, then the value of specific register can be invalid as CR8. Guest RMW it,

Re: [PATCHv5 0/6] kvm: locking and API rework for iosignalfd

2009-07-01 Thread Avi Kivity
On 06/29/2009 10:23 PM, Michael S. Tsirkin wrote: This series switches kvm_io_device to slots_lock from kvm-lock mutex, and uses that to rework io bus API. This takes less locks on data path, and uses less lines of code. These changes will also be useful to serve as basis for Greg's iosignalfd

Re: kvm-87 static build failure: cannot find -lpci

2009-07-01 Thread Antoine Martin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Michael Tokarev wrote: Antoine Martin wrote: [] LINK x86_64-softmmu/qemu-system-x86_64 /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.2/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lpci What gives? Is it your system or who's? Why the

Re: [PATCH] KVM: fix lock imbalance

2009-07-01 Thread Avi Kivity
On 06/29/2009 07:05 PM, Jiri Slaby wrote: There is a missing unlock on one fail path in ioapic_mmio_write, fix that. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH] KVM: Fix IA32e Windows can't boot issue

2009-07-01 Thread Avi Kivity
On 07/01/2009 11:07 AM, Sheng Yang wrote: One typo in commit: KVM: convert custom marker based tracing to event traces caused: set_cr8: #GP, reserved bits 0x7f when try to boot up IA32e Windows guest. One value has been written to R8 instead of specific register, then the value of specific

Re: [PATCH] KVM: Fix IA32e Windows can't boot issue

2009-07-01 Thread Sheng Yang
On Wednesday 01 July 2009 16:21:13 Avi Kivity wrote: On 07/01/2009 11:07 AM, Sheng Yang wrote: One typo in commit: KVM: convert custom marker based tracing to event traces caused: set_cr8: #GP, reserved bits 0x7f when try to boot up IA32e Windows guest. One value has been written

Re: [PATCH v3] enable x2APIC without interrupt remapping under KVM

2009-07-01 Thread Avi Kivity
On 06/30/2009 10:36 PM, Eric W. Biederman wrote: The short version is I don't know what work arounds we will ultimately decide to deploy to work with real hardware. I have been seriously contemplating causing a cpu hot-unplug request to fail if we are in ioapic mode and we have irqs routed to

Re: Newbie, struggling with graphics and qemu monitor

2009-07-01 Thread Avi Kivity
On 06/30/2009 09:33 PM, Michael Jinks wrote: In an attempt to get past unrelated interference I just set up an X session with only an xterm, used that to launch VNC connecting to my KVM test host, and tried to launch my test guest again. Same behavior: Ctl-Alt patterns are ignored, as are any

Re: [KVM PATCH v7 0/5] irqfd fixes and enhancements

2009-07-01 Thread Avi Kivity
On 06/29/2009 09:28 PM, Gregory Haskins wrote: (Applies to kvm.git/master:4631e094) The following is the latest attempt to fix the races in irqfd/eventfd, as well as restore DEASSIGN support. For more details, please read the patch headers. I've restored the slow-work variant of the logic as

Re: Exception handling between QEMU and KVM

2009-07-01 Thread Avi Kivity
On 07/01/2009 06:28 AM, Christoffer Dall wrote: Hi all. We are still working on our ARM port of KVM and we are managing to let the guest decompress the kernel image and run from relocated address and we can support enabling MMU before this. Howver, to debug relocated micro-hypervisor for

Re: KVM and 32-bit hosts -- still supposed to work?

2009-07-01 Thread Avi Kivity
On 07/01/2009 08:57 AM, Duck wrote: I'm on 32-bit Linux, kernel 2.6.27.7-smp. When I moved from kvm-83 to kvm-87 plus kvm-kmod-devel-87, my Linux host VMs ran fine. But my XP0 host simply ran too slowly to be useable at all, and my Windows 7 host wouldn't boot -- just crashed and restarted

Re: [KVM PATCH v7 0/5] irqfd fixes and enhancements

2009-07-01 Thread Michael S. Tsirkin
On Wed, Jul 01, 2009 at 11:53:26AM +0300, Avi Kivity wrote: On 06/29/2009 09:28 PM, Gregory Haskins wrote: (Applies to kvm.git/master:4631e094) The following is the latest attempt to fix the races in irqfd/eventfd, as well as restore DEASSIGN support. For more details, please read the patch

Re: BUG Report: config KVM selects PREEMPT_NOTIFIERS, but it should also select PREEMPT (Vanilla Kernel 2.6.30)

2009-07-01 Thread Avi Kivity
On 06/29/2009 06:18 PM, Walther Maldonado wrote: Good day, Today when attempting to compile and install the KVM module (kernel 2.6.30), inserting the module would error with a number of unresolved symbols such as preempt_notifier_register() not found. Some code-browsing revealed that, even

Re: [KVM PATCH v6 3/4] KVM: Fix races in irqfd using new eventfd_kref_get interface

2009-07-01 Thread Avi Kivity
On 06/29/2009 07:52 PM, Gregory Haskins wrote: One idea I had to make it even clearer was to have a shutdown list of irqfds per-kvm, together with the items list, and make work_struct for shutdown global, not per-irqfd. We can then unconditionally do list_move + schedule_work to shut down

Re: [PATCH] qemu-kvm: fix KVMs GET_SUPPORTED_CPUID feature usage

2009-07-01 Thread Avi Kivity
On 06/25/2009 04:12 PM, Andre Przywara wrote: If we want to trim the user provided CPUID bits for KVM to be not greater than that of the host, we should a) not remove the bits _after_ we sent them to the kernel and b) not do the bitmangling on the original values while sending a copy This fixes

Re: [PATCH 3/4] ignore PCI ECS I/O enablement

2009-07-01 Thread Avi Kivity
On 06/24/2009 04:37 PM, Andre Przywara wrote: Linux guests will try to enable access to the extended PCI config space via the I/O ports 0xCF8/0xCFC on AMD Fam10h CPU. Since we (currently?) don't use ECS, simply ignore write and read attempts. Applied, thanks. -- error compiling

[PATCH] qemu-kvm: fix typo in configure

2009-07-01 Thread Michael S. Tsirkin
Kill extra \). Also escape ! for clarity and bourne shell compatibility. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- This patch fixes configure on next for me configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index

Re: KVM and 32-bit hosts -- still supposed to work?

2009-07-01 Thread Alexander Graf
On 01.07.2009, at 11:05, Avi Kivity a...@redhat.com wrote: On 07/01/2009 08:57 AM, Duck wrote: I'm on 32-bit Linux, kernel 2.6.27.7-smp. When I moved from kvm-83 to kvm-87 plus kvm-kmod-devel-87, my Linux host VMs ran fine. But my XP0 host simply ran too slowly to be useable at all, and

Re: [KVM-AUTOTEST PATCH] Adding iperf test

2009-07-01 Thread Alexey Eremenko
On Tue, Jun 30, 2009 at 11:52 AM, sudhir kumarsmalik...@gmail.com wrote: On Wed, Jun 17, 2009 at 2:59 AM, Lucas Meneghel Rodriguesl...@redhat.com wrote: Adding iperf network performance test. Basically it tests networking functionality, stability and performance of guest OSes. This test is

[PATCH 2/2] qemu: fix up load for msi-x

2009-07-01 Thread Michael S. Tsirkin
Add missing load of control vector in virtio Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 843be86..e9dd7a0 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -665,6 +665,9

[PATCH 1/2] fix segfault in msix_save

2009-07-01 Thread Michael S. Tsirkin
This fixes segfault reported by Kevin Wolf, and simplifies the code in msix_save. Reported-by: Kevin Wolf kw...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/msix.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/msix.c b/hw/msix.c

[PATCH 0/2] save/load fixes

2009-07-01 Thread Michael S. Tsirkin
Fixes a couple of save/load issues with qemu.git Michael S. Tsirkin (2): fix segfault in msix_save qemu: fix up load for msi-x hw/msix.c | 12 +++- hw/virtio.c |3 +++ 2 files changed, 10 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line

Re: [PATCHv5 0/6] kvm: locking and API rework for iosignalfd

2009-07-01 Thread Gregory Haskins
Avi Kivity wrote: On 06/29/2009 10:23 PM, Michael S. Tsirkin wrote: This series switches kvm_io_device to slots_lock from kvm-lock mutex, and uses that to rework io bus API. This takes less locks on data path, and uses less lines of code. These changes will also be useful to serve as basis

Re: [PATCH 1/2] fix segfault in msix_save

2009-07-01 Thread Michael S. Tsirkin
On Wed, Jul 01, 2009 at 02:50:14PM +0300, Michael S. Tsirkin wrote: This fixes segfault reported by Kevin Wolf, and simplifies the code in msix_save. Reported-by: Kevin Wolf kw...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com For qemu-kvm, this supercedes

Re: [PATCH 1/2] fix segfault in msix_save

2009-07-01 Thread Kevin Wolf
Michael S. Tsirkin schrieb: This fixes segfault reported by Kevin Wolf, and simplifies the code in msix_save. Reported-by: Kevin Wolf kw...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com I can confirm that this fixes the segfault for me. Kevin -- To unsubscribe from this

[PATCHv2 0/2] save/load fixes

2009-07-01 Thread Michael S. Tsirkin
Fixes a couple of save/load issues with qemu.git Changes since v2: Includes a better fix for virtio. Michael S. Tsirkin (2): fix segfault in msix_save qemu: remove control vector save hw/msix.c | 12 +++- hw/virtio.c |3 --- 2 files changed, 7 insertions(+), 8 deletions(-)

[PATCHv2 2/2] qemu: remove control vector save

2009-07-01 Thread Michael S. Tsirkin
control vector is saved/restored by virtio-pci, it does not belong in virtio. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 843be86..41e7ca2 100644 --- a/hw/virtio.c +++

[PATCHv2 1/2] fix segfault in msix_save

2009-07-01 Thread Michael S. Tsirkin
This fixes segfault reported by Kevin Wolf, and simplifies the code in msix_save. Reported-by: Kevin Wolf kw...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/msix.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/msix.c b/hw/msix.c

Re: BUG Report: config KVM selects PREEMPT_NOTIFIERS, but it should also select PREEMPT (Vanilla Kernel 2.6.30)

2009-07-01 Thread Walther Maldonado
Good day, Alright, my bad. After closer studying I realized I had misread where the defines were delimiting each function. :/ Sorry for the invalid report (and yes, I had other issues setting up and running the modules, but I was pretty sure the missing symbols were caused because of the

[PATCH v5] enable x2APIC without interrupt remapping under KVM

2009-07-01 Thread Gleb Natapov
KVM would like to provide x2APIC interface to a guest without emulating interrupt remapping device. The reason KVM prefers guest to use x2APIC is that x2APIC interface is better virtualizable and provides better performance than mmio xAPIC interface: - msr exits are faster than mmio (no page

Re: [PATCH v3] enable x2APIC without interrupt remapping under KVM

2009-07-01 Thread Eric W. Biederman
Avi Kivity a...@redhat.com writes: On 06/30/2009 10:36 PM, Eric W. Biederman wrote: The short version is I don't know what work arounds we will ultimately decide to deploy to work with real hardware. I have been seriously contemplating causing a cpu hot-unplug request to fail if we are in

Re: Newbie, struggling with graphics and qemu monitor

2009-07-01 Thread Michael Jinks
(Thanks Avi, and all. Sorry if my questions are basic. More of them below.) On Wed, Jul 1, 2009 at 3:43 AM, Avi Kivitya...@redhat.com wrote: On 06/30/2009 09:33 PM, Michael Jinks wrote: I've looked but haven't found any way to attach a monitor process to an already-running guest.  Is this

Re: Exception handling between QEMU and KVM

2009-07-01 Thread Christoffer Dall
OK, my question is this: If I want to tell QEMU to quit from within the KVM_RUN ioctl in a way that causes QEMU to exit gracefully (e.g. free any allocated memory etc.) what is the way to do that? I have tried setting EXIT_REASON to both KVM_EXIT_EXCEPTION and KVM_EXIT_SHUTDOWN, but QEMU stays

Re: [Autotest] Adding kvm_subprocess

2009-07-01 Thread Lucas Meneghel Rodrigues
Hi Michael, On Thu, 2009-06-18 at 11:27 -0400, Michael Goldish wrote: kvm_subprocess is a little weird in that it does two different things -- handling of both non-interactive subprocesses and SSH sessions. With this approach I don't think we need to write an SSH subclass of kvm_spawn because

VM config file

2009-07-01 Thread Zhang Qian
Hi, I'd like to know if there is a configuration file for each KVM virtual machine? I can define a domain by virsh define command, but where the configuraiton parameters are persisted for the VM? Thanks in advance! Regards, Qian -- To unsubscribe from this list: send the line unsubscribe kvm

Re: Newbie, struggling with graphics and qemu monitor

2009-07-01 Thread Avi Kivity
On 07/01/2009 04:56 PM, Michael Jinks wrote: (Thanks Avi, and all. Sorry if my questions are basic. More of them below.) On Wed, Jul 1, 2009 at 3:43 AM, Avi Kivitya...@redhat.com wrote: On 06/30/2009 09:33 PM, Michael Jinks wrote: I've looked but haven't found any way to attach a

Re: Exception handling between QEMU and KVM

2009-07-01 Thread Avi Kivity
On 07/01/2009 04:59 PM, Christoffer Dall wrote: OK, my question is this: If I want to tell QEMU to quit from within the KVM_RUN ioctl in a way that causes QEMU to exit gracefully (e.g. free any allocated memory etc.) what is the way to do that? Have KVM_RUN return -ESOMETHING, qemu should

Re: KVM and 32-bit hosts -- still supposed to work?

2009-07-01 Thread Avi Kivity
On 07/01/2009 02:38 PM, Alexander Graf wrote: kvm is supported on 32-bit hosts. Unfortunately since moving to kvm-autotest I no longer test on 32-bit, I'll try to improve the situation there. If someone has spare cycles and can run kvm-autotest on their hardware, that would improve kvm

Re: Device assignment hotplug broken

2009-07-01 Thread Markus Armbruster
Sheng Yang sh...@linux.intel.com writes: On Tuesday 30 June 2009 20:28:08 Markus Armbruster wrote: Sheng Yang sh...@linux.intel.com writes: On Friday 26 June 2009 01:24:03 Avi Kivity wrote: The impact of the hotplug changes on device assignment were too difficult for me to fix up during

[PATCH] Update registers after INIT/SIPI

2009-07-01 Thread Gleb Natapov
Load updated register into kernel after INIT/SIPI. Otherwise vcpu starts at the wrong address after SIPI. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c index 1eb147e..5d3025a 100644 --- a/qemu-kvm-x86.c +++ b/qemu-kvm-x86.c @@ -1578,8 +1578,10 @@

Re: [PATCH] Update registers after INIT/SIPI

2009-07-01 Thread Avi Kivity
On 07/01/2009 06:48 PM, Gleb Natapov wrote: Load updated register into kernel after INIT/SIPI. Otherwise vcpu starts at the wrong address after SIPI. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line

Re: [KVM-AUTOTEST PATCH] Adding iperf test

2009-07-01 Thread Lucas Meneghel Rodrigues
On Wed, 2009-07-01 at 14:43 +0300, Alexey Eremenko wrote: LMR: me too, hate putting binaries in source tree, but the alternative option is to provide separate *.tar.bz2 for all the binary utils, and I don't sure which way is better. Yes, I don't have a clear idea as well. It's currently under

[KVM PATCH v8 0/3] irqfd fixes and enhancements

2009-07-01 Thread Gregory Haskins
(Applies to kvm.git/master:beeaacd1) The following is the latest attempt to fix the races in irqfd/eventfd, as well as restore DEASSIGN support. For more details, please read the patch headers. As always, this series has been tested against the kvm-eventfd unit test and everything appears to be

[KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get interface

2009-07-01 Thread Gregory Haskins
eventfd currently emits a POLLHUP wakeup on f_ops-release() to generate a release callback. This lets eventfd clients know if the eventfd is about to go away and is very useful particularly for in-kernel clients. However, until recently it is not possible to use this feature of eventfd in a

[KVM PATCH v8 2/3] KVM: add irqfd DEASSIGN feature

2009-07-01 Thread Gregory Haskins
DEASSIGN allows us to optionally disassociate an IRQFD from its underlying eventfd without destroying the eventfd in the process. This is useful for conditions like live-migration which may have an eventfd associated with a device and an IRQFD. We need to be able to decouple the guest from the

[KVM PATCH v8 3/3] KVM: create irqfd-cleanup-wq on demand

2009-07-01 Thread Gregory Haskins
We currently create this wq on module_init, which may be wasteful if the host never creates a guest that uses irqfd. This patch changes the algorithm so that the workqueue is only created when at least one guest is using irqfd. The queue is cleaned up when the last guest using irqfd is shutdown.

Re: [Autotest] [KVM-AUTOTEST PATCH] Adding iperf test

2009-07-01 Thread Martin Bligh
On Wed, Jul 1, 2009 at 8:57 AM, Lucas Meneghel Rodriguesl...@redhat.com wrote: On Wed, 2009-07-01 at 14:43 +0300, Alexey Eremenko wrote: LMR: me too, hate putting binaries in source tree, but the alternative option is to provide separate *.tar.bz2 for all the binary utils, and I don't sure

[PATCH] Fix up device assignment hotplug and re-enable it

2009-07-01 Thread Markus Armbruster
Disabled in merge commit a3b371477e3. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/device-assignment.c | 11 +-- hw/pci.c |2 +- hw/pci.h |1 + 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/device-assignment.c

Re: VM config file

2009-07-01 Thread Charles Duffy
Zhang Qian wrote: I'd like to know if there is a configuration file for each KVM virtual machine? I can define a domain by virsh define command, but where the configuraiton parameters are persisted for the VM? virsh is not a part of kvm, but rather libvirt; you should ask for support for it

[PATCH] Fix up ipf.c for recent merges

2009-07-01 Thread Markus Armbruster
Commit 42f0a928 merged support for addr=... in option argument of -net nic, but failed to update ipf_init1(). Commit 7a8f3ed9 merged support for addr=... in option argument of -drive if=virtio, but failed to update ipf_init1(). Untested. Signed-off-by: Markus Armbruster arm...@redhat.com ---

[PATCH 3/3 v3] Add X2APIC support.

2009-07-01 Thread Gleb Natapov
Add x2apic string to extended features name array to be recognizable by -cpu cputype,+x2apic command line option. If kvm kernel module does not support x2apic the option will be trimmed from cpuid. Signed-off-by: Gleb Natapov g...@redhat.com --- target-i386/helper.c |2 +- 1 files changed, 1

[PATCH 0/3 v3] x2APIC emulation for kvm

2009-07-01 Thread Gleb Natapov
This patch series implements x2APIC emulation for kvm. x2APIC is an MSR interface to a local apic with performance/scalability enhancements. It brings 32 bit apic ids (ids 255 cannot be used without interrupt remapping since MSR/IOAPIC still support 8 bit destination IDs), 64bit ICR access,

[PATCH 1/3 v3] Add Directed EOI support to APIC emulation

2009-07-01 Thread Gleb Natapov
Directed EOI is specified by x2APIC, but is available even when lapic is in xAPIC mode. Signed-off-by: Gleb Natapov g...@redhat.com --- arch/x86/include/asm/apicdef.h |2 ++ arch/x86/kvm/lapic.c | 38 ++ arch/x86/kvm/lapic.h |1 +

[PATCH 2/3 v3] x2apic interface to lapic

2009-07-01 Thread Gleb Natapov
This patch implements MSR interface to local apic as defines by x2apic Intel specification. Signed-off-by: Gleb Natapov g...@redhat.com --- arch/x86/kvm/lapic.c | 193 ++ arch/x86/kvm/lapic.h |2 + arch/x86/kvm/x86.c |7 ++- 3 files

Re: [Autotest] [KVM-AUTOTEST PATCH] Adding iperf test

2009-07-01 Thread Martin Bligh
LMR: me too, hate putting binaries in source tree, but the alternative option is to provide separate *.tar.bz2 for all the binary utils, and I don't sure which way is better. Yes, I don't have a clear idea as well. It's currently under discussion... Is KVM x86_64 only? It's x86-64,

Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened

2009-07-01 Thread Andreas Färber
Am 30.06.2009 um 15:32 schrieb Anthony Liguori: Kevin Wolf wrote: Avi Kivity schrieb: The qcow block driver format is no longer maintained and likely contains serious data corruptors. Urge users to stay away for it, and advertise the new and improved replacement. Signed-off-by: Avi

Re: ESX on KVM requirements

2009-07-01 Thread Ben Sanders
Finally got it to work on a 32 bit OS (Ubuntu 9.04), both on the phenom 9950 and another machine. I haven't tried running any guests yet. I suppose the TSC patch doesn't work on 64 bit hosts. Thanks for all your help, Ben On Fri, Jun 26, 2009 at 1:38 AM, Alexander Grafag...@suse.de wrote:

[PATCH] Revert KVM: x86: check for cr3 validity in ioctl_set_sregs

2009-07-01 Thread Jan Kiszka
This reverts commit 6c20e1442bb1c62914bb85b7f4a38973d2a423ba. To my understanding, it became obsolete with the advent of the more robust check in mmu_alloc_roots (89da4ff17f). Moreover, it prevents the conceptually safe pattern 1. set sregs 2. register mem-slots 3. run vcpu by setting a

Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get interface

2009-07-01 Thread Gregory Haskins
Gregory Haskins wrote: + eventfd = eventfd_ctx_fileget(file); + if (IS_ERR(file)) { + ret = PTR_ERR(file); + goto fail; + } + + irqfd-eventfd = eventfd; + sigh Just noticed the typo (return eventfd but error-check file). Looks like I will

Re: [Autotest] [KVM-AUTOTEST PATCH] Adding iperf test

2009-07-01 Thread Lucas Meneghel Rodrigues
On Wed, 2009-07-01 at 10:16 -0700, Martin Bligh wrote: LMR: me too, hate putting binaries in source tree, but the alternative option is to provide separate *.tar.bz2 for all the binary utils, and I don't sure which way is better. Yes, I don't have a clear idea as well. It's currently

Re: [PATCH v5] enable x2APIC without interrupt remapping under KVM

2009-07-01 Thread Suresh Siddha
On Wed, 2009-07-01 at 06:30 -0700, Gleb Natapov wrote: KVM would like to provide x2APIC interface to a guest without emulating interrupt remapping device. The reason KVM prefers guest to use x2APIC is that x2APIC interface is better virtualizable and provides better performance than mmio xAPIC

Re: slow guest performance with build load, looking for ideas

2009-07-01 Thread Erik Jacobson
I wanted to post in to the thread the lastest test run. Avi Kivity provided some ideas to try. I had mixed luck. I'd like to try this again if we have any thoughts on the vpid/ept issue, or any other ideas for drilling down on this. Avi Kivity mentioned LVM in the thread. I continued to just

Re: [PATCH v3] enable x2APIC without interrupt remapping under KVM

2009-07-01 Thread Suresh Siddha
On Tue, 2009-06-30 at 12:36 -0700, Eric W. Biederman wrote: Dropped irqs.. Driver hangs because it is waiting for an irq. Hardware hangs because it is waiting for the cpu to process the irq. Potentially we get a level triggered irq that is never acked by the cpu that won't arm until the

Re: [PATCH] qemu-kvm: fix typo in configure

2009-07-01 Thread Dustin Kirkland
On Wed, Jul 1, 2009 at 4:27 AM, Michael S. Tsirkinm...@redhat.com wrote: Kill extra \). Also escape ! for clarity and bourne shell compatibility. Agreed. Looks like this one was introduced during the last merge from qemu. It bit me too. :-Dustin Signed-off-by: Michael S. Tsirkin

Re: pci_stub and kvm

2009-07-01 Thread Yinghai Lu
On Wed, Jul 1, 2009 at 12:49 AM, Avi Kivitya...@redhat.com wrote: On 07/01/2009 07:18 AM, Yinghai Lu wrote: [ 1966.343286] [ 1966.343288] === [ 1966.356756] [ INFO: possible circular locking dependency detected ] [ 1966.356759]

Re: [PATCH v3] enable x2APIC without interrupt remapping under KVM

2009-07-01 Thread Eric W. Biederman
Suresh Siddha suresh.b.sid...@intel.com writes: On Tue, 2009-06-30 at 12:36 -0700, Eric W. Biederman wrote: Dropped irqs.. Driver hangs because it is waiting for an irq. Hardware hangs because it is waiting for the cpu to process the irq. Potentially we get a level triggered irq that is

RE: [PATCH 1/2] KVM/PPC: Fix PPC KVM e500_tlb.c build error

2009-07-01 Thread Liu Yu-B13201
This fix is already accepted in kvm.git -Original Message- From: Yang Shi [mailto:yang@windriver.com] Sent: Thursday, July 02, 2009 10:55 AM To: Liu Yu-B13201; holl...@us.ibm.com; a...@redhat.com Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc-...@ozlabs.org

[PATCH 2/2] KVM/PPC: Fix kvm_main.c build error for PPC KVM

2009-07-01 Thread Yang Shi
With the latest kernel building KVM for PPC, got integer overflow error in kvm_main.c file. The root cause is that compiler consider KVM_PAGES_PER_HPAGE as signed long type, however it should be unsigned long type. So, change it to unsigned long type in include/asm/kvm_host.h Signed-off-by: Yang

[PATCH 1/2] KVM/PPC: Fix PPC KVM e500_tlb.c build error

2009-07-01 Thread Yang Shi
Since include/asm/mmu-fsl-booke.h was replaced by include/asm/mmu-book3e.h, fix e500_tlb.h to reflect the change and fix e500_tlb.c to align with the new page size macro definition in include/asm/mmu-book3e.h. Signed-off-by: Yang Shi yang@windriver.com --- arch/powerpc/kvm/e500_tlb.c |8

Re: [Autotest] [PATCH] Add a client-side test qemu_iotests

2009-07-01 Thread Martin Bligh
From: root r...@dhcp-66-70-57.nay.redhat.com Signed-off-by: root r...@dhcp-66-70-57.nay.redhat.com --- ;-) Can we get these signed off by a person please? Preferably with a real email address (see the DCO, in top level directory) -- To unsubscribe from this list: send the line unsubscribe kvm

Re: [Autotest] [PATCH] Add a client-side test qemu_iotests

2009-07-01 Thread Yolkfull Chow
On 07/02/2009 11:49 AM, Martin Bligh wrote: From: rootr...@dhcp-66-70-57.nay.redhat.com Signed-off-by: rootr...@dhcp-66-70-57.nay.redhat.com --- ;-) Can we get these signed off by a person please? Preferably with a real email address (see the DCO, in top level directory) -- To unsubscribe

Re: [Autotest] [PATCH] Add a client-side test qemu_iotests

2009-07-01 Thread Yolkfull Chow
On 07/02/2009 12:24 PM, sudhir kumar wrote: Please send the tarball as a separate attachment. Your email is scary. OK, I will resend the patch. Sorry for this scary email. :) -- Yolkfull Regards, -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

[PATCH] rev3: support colon in filenames

2009-07-01 Thread Ram Pai
Problem: It is impossible to feed filenames with the character colon because qemu interprets such names as a protocol. For example filename scsi:0, is interpreted as a protocol by name scsi. This patch allows user to escape colon characters. For example the above filename can now be expressed

Re: slow guest performance with build load, looking for ideas

2009-07-01 Thread Avi Kivity
On 07/02/2009 12:41 AM, Erik Jacobson wrote: I wanted to post in to the thread the lastest test run. Avi Kivity provided some ideas to try. I had mixed luck. I'd like to try this again if we have any thoughts on the vpid/ept issue, or any other ideas for drilling down on this. Avi Kivity

Re: Exception handling between QEMU and KVM

2009-07-01 Thread Alexander Graf
On 01.07.2009, at 05:28, Christoffer Dall wrote: Hi all. We are still working on our ARM port of KVM and we are managing to let the guest decompress the kernel image and run from relocated address and we can support enabling MMU before this. Howver, to debug relocated micro-hypervisor for

Re: Exception handling between QEMU and KVM

2009-07-01 Thread Christoffer Dall
OK, my question is this: If I want to tell QEMU to quit from within the KVM_RUN ioctl in a way that causes QEMU to exit gracefully (e.g. free any allocated memory etc.) what is the way to do that? I have tried setting EXIT_REASON to both KVM_EXIT_EXCEPTION and KVM_EXIT_SHUTDOWN, but QEMU stays

RE: [PATCH 1/2] KVM/PPC: Fix PPC KVM e500_tlb.c build error

2009-07-01 Thread Liu Yu-B13201
This fix is already accepted in kvm.git -Original Message- From: Yang Shi [mailto:yang@windriver.com] Sent: Thursday, July 02, 2009 10:55 AM To: Liu Yu-B13201; holl...@us.ibm.com; a...@redhat.com Cc: kvm-ppc@vger.kernel.org; k...@vger.kernel.org; linuxppc-...@ozlabs.org