Re: [libav-devel] [PATCH 6/6] lavr: Add x86-optimized function for flt to s32 conversion

2012-06-18 Thread Luca Barbato
On 06/06/2012 08:55 PM, Justin Ruggles wrote: --- libavresample/x86/audio_convert.asm| 42 libavresample/x86/audio_convert_init.c |7 + 2 files changed, 49 insertions(+), 0 deletions(-) Looks ok, but my x86 asm/yasm knowledge isn't that

Re: [libav-devel] [PATCH 1/2] lavr: add x86-optimized functions for mixing 1-to-2 fltp with flt coeffs

2012-06-18 Thread Luca Barbato
On 06/18/2012 04:05 AM, Justin Ruggles wrote: On 06/05/2012 01:43 PM, Justin Ruggles wrote: On 05/29/2012 04:41 PM, Justin Ruggles wrote: --- libavresample/x86/audio_mix.asm| 34 ++ libavresample/x86/audio_mix_init.c |9 + 2 files changed,

Re: [libav-devel] [PATCH 2/4] float_dsp: add x86-optimized functions for vector_fmac_scalar()

2012-06-18 Thread Christophe Gisquet
Hi, 2012/6/18 Justin Ruggles justin.rugg...@gmail.com: Removed ALIGN 16 before the loop. There was no measurable speed difference on x86-64 or x86-32. [...] ping. Fine for me (there was nothing really mattering anyway). Christophe ___ libav-devel

[libav-devel] [PATCH v2 1/5] Add support for iLBC decoding/encoding via the external library libilbc

2012-06-18 Thread Martin Storsjö
The library is 3-clause BSD licensed. --- Changelog |1 + configure |6 ++ doc/general.texi | 13 +++ libavcodec/Makefile|2 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h |1 + libavcodec/libilbc.c | 209

[libav-devel] [PATCH v2 2/5] mov: Support muxing/demuxing iLBC

2012-06-18 Thread Martin Storsjö
The packet size, signalled via block_align, has to be passed via the container. --- libavformat/isom.c |1 + libavformat/mov.c|1 + libavformat/movenc.c |3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/isom.c b/libavformat/isom.c index

[libav-devel] [PATCH v2 3/5] Implement the iLBC storage file format

2012-06-18 Thread Martin Storsjö
--- doc/general.texi |1 + libavformat/Makefile |2 + libavformat/allformats.c |1 + libavformat/ilbc.c | 140 ++ 4 files changed, 144 insertions(+) create mode 100644 libavformat/ilbc.c diff --git a/doc/general.texi

[libav-devel] [PATCH v2 4/5] rtpdec: Add a depacketizer for iLBC

2012-06-18 Thread Martin Storsjö
--- libavformat/Makefile |1 + libavformat/rtpdec.c |1 + libavformat/rtpdec_formats.h |1 + libavformat/rtpdec_ilbc.c| 62 ++ 4 files changed, 65 insertions(+) create mode 100644 libavformat/rtpdec_ilbc.c diff --git

[libav-devel] [PATCH v2 5/5] rtpenc: Support packetizing iLBC

2012-06-18 Thread Martin Storsjö
--- libavformat/rtpenc.c | 44 libavformat/sdp.c|6 ++ 2 files changed, 50 insertions(+) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 6752fb6..9ee9d09 100644 --- a/libavformat/rtpenc.c +++ b/libavformat/rtpenc.c @@

Re: [libav-devel] [PATCH] TCP: Use AI_PASSIVE flag when no address is set

2012-06-18 Thread Martin Storsjö
On Sun, 17 Jun 2012, Jordi Ortiz wrote: --- libavformat/tcp.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index 7e348f7..c9ff47a 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -65,7 +65,12 @@ static int

Re: [libav-devel] [PATCH] rtpenc: Allow requesting H264 RTP packetization mode 0

2012-06-18 Thread Luca Barbato
On 06/15/2012 01:32 PM, Martin Storsjö wrote: This requires all NAL units to fit within single RTP packets. It doesn't change the actual packetization for packets that fit, but errors out and gives a helpful hint if the NAL units would have to be split, and signals the right packetization mode

Re: [libav-devel] [PATCH v2 4/5] rtpdec: Add a depacketizer for iLBC

2012-06-18 Thread Luca Barbato
On 06/18/2012 10:40 AM, Martin Storsjö wrote: +static int ilbc_parse_fmtp(AVStream *stream, PayloadContext *data, + char *attr, char *value) +{ +if (!strcmp(attr, mode)) { +int mode = atoi(value); +switch (mode) { +case 20: +

Re: [libav-devel] [PATCH v2 4/5] rtpdec: Add a depacketizer for iLBC

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Luca Barbato wrote: On 06/18/2012 10:40 AM, Martin Storsjö wrote: +static int ilbc_parse_fmtp(AVStream *stream, PayloadContext *data, + char *attr, char *value) +{ +if (!strcmp(attr, mode)) { +int mode = atoi(value); +switch

Re: [libav-devel] [PATCH v2 5/5] rtpenc: Support packetizing iLBC

2012-06-18 Thread Luca Barbato
On 06/18/2012 10:40 AM, Martin Storsjö wrote: +case CODEC_ID_ILBC: +if (!st-codec-block_align) { +av_log(s1, AV_LOG_ERROR, No iLBC block size specified\n); +goto fail; +} who's setting this value? shall we check it is one of the two supported one?

Re: [libav-devel] [PATCH v2 5/5] rtpenc: Support packetizing iLBC

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Luca Barbato wrote: On 06/18/2012 10:40 AM, Martin Storsjö wrote: +case CODEC_ID_ILBC: +if (!st-codec-block_align) { +av_log(s1, AV_LOG_ERROR, No iLBC block size specified\n); +goto fail; +} who's setting this value? shall we

[libav-devel] [PATCH 4/5] rtpdec: Add a depacketizer for iLBC

2012-06-18 Thread Martin Storsjö
--- libavformat/Makefile |1 + libavformat/rtpdec.c |1 + libavformat/rtpdec_formats.h |1 + libavformat/rtpdec_ilbc.c| 73 ++ 4 files changed, 76 insertions(+) create mode 100644 libavformat/rtpdec_ilbc.c diff --git

[libav-devel] [PATCH 5/5] rtpenc: Support packetizing iLBC

2012-06-18 Thread Martin Storsjö
--- libavformat/rtpenc.c | 44 libavformat/sdp.c|6 ++ 2 files changed, 50 insertions(+) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 6752fb6..9cf1a16 100644 --- a/libavformat/rtpenc.c +++ b/libavformat/rtpenc.c @@

Re: [libav-devel] [PATCH] snow: remove a VLA.

2012-06-18 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/snowenc.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index

Re: [libav-devel] [PATCH 5/5] rtpenc: Support packetizing iLBC

2012-06-18 Thread Luca Barbato
On 06/18/2012 12:37 PM, Martin Storsjö wrote: --- libavformat/rtpenc.c | 44 libavformat/sdp.c|6 ++ 2 files changed, 50 insertions(+) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero

[libav-devel] [PATCH] rtmp: Add a new option 'rtmp_flush_interval', for setting the number of packets flushed in the same request

2012-06-18 Thread Samuel Pitoiset
This options is only needed for RTMPT. --- doc/protocols.texi |4 libavformat/rtmpproto.c |8 2 files changed, 12 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 0b4f1b1..e90d1b4 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@

Re: [libav-devel] [PATCH] rtmp: Add a new option 'rtmp_flush_interval', for setting the number of packets flushed in the same request

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Samuel Pitoiset wrote: This options is only needed for RTMPT. --- doc/protocols.texi |4 libavformat/rtmpproto.c |8 2 files changed, 12 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 0b4f1b1..e90d1b4 100644 ---

[libav-devel] [PATCH] rtmp: Add a new option 'rtmp_flush_interval', for setting the number of packets flushed in the same request

2012-06-18 Thread Samuel Pitoiset
This options is only needed for RTMPT. --- doc/protocols.texi |4 libavformat/rtmpproto.c |8 2 files changed, 12 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 0b4f1b1..e90d1b4 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@

[libav-devel] [PATCH] rtsp: Send mode=record instead of mode=receive

2012-06-18 Thread Martin Storsjö
This seems to be the correct mode to send, according to the original RTSP RFC, and matches the method RECORD which is sent later when starting to send data. Darwin Streaming Server works fine with either of them. --- libavformat/rtsp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [libav-devel] [PATCH] rtmp: Add a new option 'rtmp_flush_interval', for setting the number of packets flushed in the same request

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Samuel Pitoiset wrote: This options is only needed for RTMPT. --- doc/protocols.texi |4 libavformat/rtmpproto.c |8 2 files changed, 12 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 0b4f1b1..e90d1b4 100644 ---

Re: [libav-devel] [PATCH] Change all uses of restrict to use av_restrict instead.

2012-06-18 Thread Diego Biurrun
On Fri, Jun 15, 2012 at 06:02:11PM -0700, Ronald S. Bultje wrote: On Fri, Jun 15, 2012 at 5:41 PM, Måns Rullgård m...@mansr.com wrote: Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com Defining restrict results - for some compilers - in changing other

[libav-devel] [PATCH 0/7] More cherries from Ronald's MSVC patch

2012-06-18 Thread Mans Rullgard
These patches all look reasonable to me, though some more review can't hurt. Ronald S. Bultje (7): dirac: replace compound literal with normal initialiser Replace some #if/else in struct initialisers with conditional expressions mem: add support for _aligned_malloc() as found on Windows

[libav-devel] [PATCH 4/7] network: winsock2: protect EFOO error constant definitions with ifdefs

2012-06-18 Thread Mans Rullgard
From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/network.h |8 1 file changed, 8 insertions(+) diff --git a/libavformat/network.h b/libavformat/network.h index 72d01d2..5c70e2d 100644 --- a/libavformat/network.h +++ b/libavformat/network.h @@ -31,10 +31,18 @@ #include

[libav-devel] [PATCH 3/7] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Mans Rullgard
From: Ronald S. Bultje rsbul...@gmail.com --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure b/configure index a5d2787..f1f58a7 100755 --- a/configure +++ b/configure @@ -1049,6 +1049,7 @@ HAVE_LIST=

[libav-devel] [PATCH 2/7] Replace some #if/else in struct initialisers with conditional expressions

2012-06-18 Thread Mans Rullgard
From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/asfenc.c | 12 ++-- libavformat/avienc.c |6 +- libavformat/flvenc.c |6 +- libavformat/matroskaenc.c | 18 +++--- libavformat/movenc.c | 18 +++---

[libav-devel] [PATCH 5/7] attributes: add av_always_inline definition for msvc

2012-06-18 Thread Mans Rullgard
From: Ronald S. Bultje rsbul...@gmail.com --- libavutil/attributes.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/attributes.h b/libavutil/attributes.h index ef990a1..c0bac3f 100644 --- a/libavutil/attributes.h +++ b/libavutil/attributes.h @@ -35,6 +35,8 @@ #ifndef

[libav-devel] [PATCH 7/7] http: replace atoll() with strtoll()

2012-06-18 Thread Mans Rullgard
From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/http.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index a494193..8ccb649 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -309,15 +309,15 @@ static int

[libav-devel] [PATCH 1/7] dirac: replace compound literal with normal initialiser

2012-06-18 Thread Mans Rullgard
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/dirac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c index bf56088..07329e3 100644 --- a/libavcodec/dirac.c +++ b/libavcodec/dirac.c @@ -108,7 +108,7 @@ static const enum

[libav-devel] [PATCH 6/7] mpegts: remove unused (incomplete?) seeking code

2012-06-18 Thread Mans Rullgard
From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/mpegts.c | 96 -- 1 file changed, 96 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index ebc5f2c..5b44c0e 100644 --- a/libavformat/mpegts.c +++

Re: [libav-devel] [PATCH 1/7] dirac: replace compound literal with normal initialiser

2012-06-18 Thread Janne Grunau
On 2012-06-18 14:37:00 +0100, Måns Rullgård wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/dirac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c index bf56088..07329e3 100644 --- a/libavcodec/dirac.c +++

Re: [libav-devel] [PATCH 4/7] network: winsock2: protect EFOO error constant definitions with ifdefs

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/network.h |8 1 file changed, 8 insertions(+) diff --git a/libavformat/network.h b/libavformat/network.h index 72d01d2..5c70e2d 100644 --- a/libavformat/network.h +++

Re: [libav-devel] [PATCH 7/7] http: replace atoll() with strtoll()

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/http.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index a494193..8ccb649 100644 --- a/libavformat/http.c +++

Re: [libav-devel] [PATCH 5/7] attributes: add av_always_inline definition for msvc

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavutil/attributes.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/attributes.h b/libavutil/attributes.h index ef990a1..c0bac3f 100644 --- a/libavutil/attributes.h +++

Re: [libav-devel] [PATCH 2/7] Replace some #if/else in struct initialisers with conditional expressions

2012-06-18 Thread Kostya Shishkov
On Mon, Jun 18, 2012 at 02:37:01PM +0100, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/asfenc.c | 12 ++-- libavformat/avienc.c |6 +- libavformat/flvenc.c |6 +- libavformat/matroskaenc.c | 18 +++---

Re: [libav-devel] [PATCH 3/7] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure b/configure index a5d2787..f1f58a7 100755 --- a/configure +++ b/configure @@

Re: [libav-devel] [PATCH 3/7] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Kostya Shishkov
On Mon, Jun 18, 2012 at 02:37:02PM +0100, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) probably OK ___ libav-devel

Re: [libav-devel] [PATCH 6/7] mpegts: remove unused (incomplete?) seeking code

2012-06-18 Thread Kostya Shishkov
On Mon, Jun 18, 2012 at 02:37:05PM +0100, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/mpegts.c | 96 -- 1 file changed, 96 deletions(-) LGTM ___ libav-devel

Re: [libav-devel] [PATCH 3/7] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: On Mon, 18 Jun 2012, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [libav-devel] [PATCH 6/7] mpegts: remove unused (incomplete?) seeking code

2012-06-18 Thread Måns Rullgård
Mans Rullgard m...@mansr.com writes: From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/mpegts.c | 96 -- 1 file changed, 96 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index ebc5f2c..5b44c0e 100644 ---

Re: [libav-devel] [PATCH] MS Screen 1 decoder

2012-06-18 Thread Martin Storsjö
diff --git a/libavcodec/mss1.c b/libavcodec/mss1.c new file mode 100644 index 000..ba1a613 --- /dev/null +++ b/libavcodec/mss1.c @@ -0,0 +1,846 @@ +/* + * Microsoft Screen 1 (aka Windows Media Video V7 Screen) decoder + * Copyright (c) 2012 Konstantin Shishkov + * + * This file is part of

Re: [libav-devel] [PATCH 3/7] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Janne Grunau
On 2012-06-18 14:37:02 +0100, Måns Rullgård wrote: From: Ronald S. Bultje rsbul...@gmail.com --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure b/configure index a5d2787..f1f58a7 100755 --- a/configure

Re: [libav-devel] [PATCH 3/7] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: On Mon, 18 Jun 2012, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH 3/7] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Sean McGovern
On Monday, June 18, 2012, Måns Rullgård m...@mansr.com wrote: Martin Storsjö mar...@martin.st writes: On Mon, 18 Jun 2012, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1

Re: [libav-devel] [PATCH 6/7] mpegts: remove unused (incomplete?) seeking code

2012-06-18 Thread Diego Elio Pettenò
Il 18/06/2012 15:48, Måns Rullgård ha scritto: Does anyone know what this code was intended for and why it was disabled? It does remind me of something that is/was also in xine but I don't know for sure.. -- Diego Elio Pettenò — Flameeyes flamee...@flameeyes.eu — http://blog.flameeyes.eu/

Re: [libav-devel] [PATCH 3/7] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Måns Rullgård
Janne Grunau janne-li...@jannau.net writes: On 2012-06-18 14:37:02 +0100, Måns Rullgård wrote: From: Ronald S. Bultje rsbul...@gmail.com --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure b/configure

[libav-devel] [PATCH 2/2] rtmp: Reduce the number of idle posts sent by sleeping 50ms

2012-06-18 Thread Samuel Pitoiset
--- libavformat/rtmphttp.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/rtmphttp.c b/libavformat/rtmphttp.c index fdcff50..7c58f2b 100644 --- a/libavformat/rtmphttp.c +++ b/libavformat/rtmphttp.c @@ -24,6 +24,8 @@ * RTMP HTTP protocol */ +#include unistd.h

Re: [libav-devel] [PATCH] MS Screen 1 decoder

2012-06-18 Thread Kostya Shishkov
On Mon, Jun 18, 2012 at 04:48:43PM +0300, Martin Storsjö wrote: diff --git a/libavcodec/mss1.c b/libavcodec/mss1.c new file mode 100644 index 000..ba1a613 --- /dev/null +++ b/libavcodec/mss1.c @@ -0,0 +1,846 @@ +/* + * Microsoft Screen 1 (aka Windows Media Video V7 Screen) decoder + *

Re: [libav-devel] [PATCH 2/2] rtmp: Reduce the number of idle posts sent by sleeping 50ms

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Samuel Pitoiset wrote: --- libavformat/rtmphttp.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/rtmphttp.c b/libavformat/rtmphttp.c index fdcff50..7c58f2b 100644 --- a/libavformat/rtmphttp.c +++ b/libavformat/rtmphttp.c @@ -24,6 +24,8 @@ *

Re: [libav-devel] [PATCH] MS Screen 1 decoder

2012-06-18 Thread Christophe Gisquet
Hi, +typedef struct Model { +    int cum_prob[MODEL_MAX_SYMS + 1]; +    int weights[MODEL_MAX_SYMS + 1]; +    int idx2sym[MODEL_MAX_SYMS + 1]; +    int sym2idx[MODEL_MAX_SYMS + 1]; +    int num_syms; +    int thr_weight, threshold; +} Model; How high are the weights typically? Same for

[libav-devel] [PATCH] flvdec: remove incomplete, disabled seeking code

2012-06-18 Thread Mans Rullgard
From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/flvdec.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index f04f4fe..8e9759b 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -749,33

Re: [libav-devel] [PATCH] MS Screen 1 decoder

2012-06-18 Thread Kostya Shishkov
On Mon, Jun 18, 2012 at 04:16:01PM +0200, Christophe Gisquet wrote: Hi, +typedef struct Model { +    int cum_prob[MODEL_MAX_SYMS + 1]; +    int weights[MODEL_MAX_SYMS + 1]; +    int idx2sym[MODEL_MAX_SYMS + 1]; +    int sym2idx[MODEL_MAX_SYMS + 1]; +    int num_syms; +    int

Re: [libav-devel] [PATCH] flvdec: remove incomplete, disabled seeking code

2012-06-18 Thread Kostya Shishkov
On Mon, Jun 18, 2012 at 03:22:56PM +0100, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavformat/flvdec.c | 30 -- 1 file changed, 30 deletions(-) LGTM ___ libav-devel mailing list

Re: [libav-devel] [PATCH v2 1/5] Add support for iLBC decoding/encoding via the external library libilbc

2012-06-18 Thread Justin Ruggles
On 06/18/2012 04:39 AM, Martin Storsjö wrote: The library is 3-clause BSD licensed. --- Changelog |1 + configure |6 ++ doc/general.texi | 13 +++ libavcodec/Makefile|2 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h |1 +

Re: [libav-devel] [PATCH] MS Screen 1 decoder

2012-06-18 Thread Christophe Gisquet
2012/6/18 Kostya Shishkov kostya.shish...@gmail.com: How high are the weights typically? Same for the LUT values of idx2sym and sym2idx. num_syms seems to be set to 8 or 2, but there is probably something I missed in between. There's one model for all pixel values (i.e. 256 symbols).

Re: [libav-devel] [PATCH v2 3/5] Implement the iLBC storage file format

2012-06-18 Thread Justin Ruggles
On 06/18/2012 04:40 AM, Martin Storsjö wrote: --- doc/general.texi |1 + libavformat/Makefile |2 + libavformat/allformats.c |1 + libavformat/ilbc.c | 140 ++ 4 files changed, 144 insertions(+) create mode

Re: [libav-devel] [PATCH v2 2/5] mov: Support muxing/demuxing iLBC

2012-06-18 Thread Justin Ruggles
On 06/18/2012 04:40 AM, Martin Storsjö wrote: The packet size, signalled via block_align, has to be passed via the container. --- libavformat/isom.c |1 + libavformat/mov.c|1 + libavformat/movenc.c |3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH] MS Screen 1 decoder

2012-06-18 Thread Kostya Shishkov
On Mon, Jun 18, 2012 at 04:34:04PM +0200, Christophe Gisquet wrote: 2012/6/18 Kostya Shishkov kostya.shish...@gmail.com: How high are the weights typically? Same for the LUT values of idx2sym and sym2idx. num_syms seems to be set to 8 or 2, but there is probably something I missed in

[libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Martin Storsjö
From: Ronald S. Bultje rsbul...@gmail.com The check uses check_func_header, since this function is conditionally available depending on the targeted MSVCRT version. --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: From: Ronald S. Bultje rsbul...@gmail.com The check uses check_func_header, since this function is conditionally available depending on the targeted MSVCRT version. --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: From: Ronald S. Bultje rsbul...@gmail.com The check uses check_func_header, since this function is conditionally available depending on the targeted MSVCRT version. --- configure |4 +++-

Re: [libav-devel] [PATCH] flvdec: remove incomplete, disabled seeking code

2012-06-18 Thread Diego Biurrun
On Mon, Jun 18, 2012 at 03:22:56PM +0100, Mans Rullgard wrote: --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -749,33 +749,6 @@ static int flv_read_seek(AVFormatContext *s, int stream_index, -#if 0 /* don't know enough to implement this */ -static int

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: On Mon, 18 Jun 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: From: Ronald S. Bultje rsbul...@gmail.com The check uses check_func_header, since this function is conditionally available depending on the targeted MSVCRT version.

Re: [libav-devel] [PATCH 05/12] flvdec: remove disabled code

2012-06-18 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: --- libavformat/flvdec.c | 30 -- 1 files changed, 0 insertions(+), 30 deletions(-) LGTM -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] rtsp: Send mode=record instead of mode=receive

2012-06-18 Thread Jordi Ortiz
2012/6/18 Martin Storsjö mar...@martin.st This seems to be the correct mode to send, according to the original RTSP RFC, and matches the method RECORD which is sent later when starting to send data. Darwin Streaming Server works fine with either of them. --- libavformat/rtsp.c |2 +-

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: On Mon, 18 Jun 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: From: Ronald S. Bultje rsbul...@gmail.com The check uses check_func_header, since this function is conditionally available

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: On Mon, 18 Jun 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: On Mon, 18 Jun 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: From: Ronald S. Bultje rsbul...@gmail.com The check uses check_func_header, since

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Diego Elio Pettenò
Il 18/06/2012 18:28, Måns Rullgård ha scritto: So what does this mean in terms of which systems a binary built with/without that flag will run on? As far as I can tell, even version 7 is compatible with 2k and later. I think it's 2010 that starts killing anything below XP. -- Diego Elio

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Måns Rullgård
Diego Elio Pettenò flamee...@flameeyes.eu writes: Il 18/06/2012 18:28, Måns Rullgård ha scritto: So what does this mean in terms of which systems a binary built with/without that flag will run on? As far as I can tell, even version 7 is compatible with 2k and later. If that's the case, we

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Alex Converse
On Mon, Jun 18, 2012 at 9:33 AM, Måns Rullgård m...@mansr.com wrote: Diego Elio Pettenò flamee...@flameeyes.eu writes: Il 18/06/2012 18:28, Måns Rullgård ha scritto: So what does this mean in terms of which systems a binary built with/without that flag will run on? As far as I can

Re: [libav-devel] [PATCH] Change all uses of restrict to use av_restrict instead.

2012-06-18 Thread Reinhard Tartler
On Mon, Jun 18, 2012 at 3:26 PM, Diego Biurrun di...@biurrun.de wrote: I wish to support a compiler that does not support c99. Shall we work together and make that happen or shall we just cry like little zealous babies while the real world passes by? Comments like this are not exactly

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Alex Converse wrote: On Mon, Jun 18, 2012 at 9:33 AM, Måns Rullgård m...@mansr.com wrote: Diego Elio Pettenò flamee...@flameeyes.eu writes: Il 18/06/2012 18:28, Måns Rullgård ha scritto: So what does this mean in terms of which systems a binary built with/without that

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Derek Buitenhuis
On 18/06/2012 1:35 PM, Martin Storsjö wrote: I'm not trying to advocate a particular position here, but here is a little bit of background on msvcrt vs versioned runtimes: http://msdn.microsoft.com/en-us/library/abx4dbyh(VS.71).aspx : What is the difference between msvcrt.dll and

Re: [libav-devel] [PATCH] dxva2: add missing dxva.h include.

2012-06-18 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Thu, Jun 14, 2012 at 4:09 PM, Jean-Baptiste Kempf j...@videolan.org wrote: On Thu, Jun 14, 2012 at 04:05:40PM -0700, Ronald S. Bultje wrote : This should break every mingw compilation. Why? Is the header un-mingw'y? AFAIK, no Mingw

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Måns Rullgård
Derek Buitenhuis derek.buitenh...@gmail.com writes: On 18/06/2012 1:35 PM, Martin Storsjö wrote: I'm not trying to advocate a particular position here, but here is a little bit of background on msvcrt vs versioned runtimes: http://msdn.microsoft.com/en-us/library/abx4dbyh(VS.71).aspx :

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Derek Buitenhuis
On 18/06/2012 2:41 PM, Måns Rullgård wrote: What does that do? Static msvcrt linkage (no reliance on msvcrXX.dll). - Derek ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Måns Rullgård
Derek Buitenhuis derek.buitenh...@gmail.com writes: On 18/06/2012 2:41 PM, Måns Rullgård wrote: What does that do? Static msvcrt linkage (no reliance on msvcrXX.dll). And how does that relate to the patch at hand? Does it magically provide one of the already supported memalign() variants?

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Måns Rullgård wrote: Derek Buitenhuis derek.buitenh...@gmail.com writes: On 18/06/2012 2:41 PM, Måns Rullgård wrote: What does that do? Static msvcrt linkage (no reliance on msvcrXX.dll). And how does that relate to the patch at hand? Does it magically provide one

Re: [libav-devel] [PATCH 3/7] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Luca Barbato
On 06/18/2012 03:57 PM, Måns Rullgård wrote: I was going to suggest dropping the ${malloc_prefix} here. This feature exists so the standard allocator can be replaced by a custom one, and there's no reason why a custom allocator can't use the standard interface. Makes sense. lu -- Luca

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Derek Buitenhuis
On 18/06/2012 2:57 PM, Martin Storsjö wrote: On Mon, 18 Jun 2012, Måns Rullgård wrote: Derek Buitenhuis derek.buitenh...@gmail.com writes: On 18/06/2012 2:41 PM, Måns Rullgård wrote: What does that do? Static msvcrt linkage (no reliance on msvcrXX.dll). And how does that relate to the

[libav-devel] [PATCH] mxfdec: replace right-shift by av_log2(foo) with division by foo

2012-06-18 Thread Mans Rullgard
From: Ronald S. Bultje rsbul...@gmail.com Since all operands involved are constants, the division can be computed at compile time whereas av_log2() cannot. --- libavformat/mxfdec.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c

Re: [libav-devel] [PATCH] mxfdec: replace right-shift by av_log2(foo) with division by foo

2012-06-18 Thread Luca Barbato
On 06/18/2012 09:18 PM, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com Since all operands involved are constants, the division can be computed at compile time whereas av_log2() cannot. --- libavformat/mxfdec.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [libav-devel] [PATCH] mxfdec: replace right-shift by av_log2(foo) with division by foo

2012-06-18 Thread Kostya Shishkov
On Mon, Jun 18, 2012 at 08:18:38PM +0100, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com Since all operands involved are constants, the division can be computed at compile time whereas av_log2() cannot. --- libavformat/mxfdec.c |4 ++-- 1 file changed, 2 insertions(+),

[libav-devel] [PATCH] mem: add support for __mingw_aligned_malloc()

2012-06-18 Thread Martin Storsjö
This function is like _aligned_malloc(), but part of the statically linked mingw runtime, so it's available regardless of the targeted MSVCRT version. --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure

Re: [libav-devel] [PATCH] mem: add support for __mingw_aligned_malloc()

2012-06-18 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: This function is like _aligned_malloc(), but part of the statically linked mingw runtime, so it's available regardless of the targeted MSVCRT version. --- configure |4 +++- libavutil/mem.c |6 ++ 2 files changed, 9 insertions(+),

Re: [libav-devel] [PATCH] mxfdec: replace right-shift by av_log2(foo) with division by foo

2012-06-18 Thread Måns Rullgård
Kostya Shishkov kostya.shish...@gmail.com writes: On Mon, Jun 18, 2012 at 08:18:38PM +0100, Mans Rullgard wrote: From: Ronald S. Bultje rsbul...@gmail.com Since all operands involved are constants, the division can be computed at compile time whereas av_log2() cannot. ---

Re: [libav-devel] [PATCH] mem: add support for __mingw_aligned_malloc()

2012-06-18 Thread Martin Storsjö
On Mon, 18 Jun 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: This function is like _aligned_malloc(), but part of the statically linked mingw runtime, so it's available regardless of the targeted MSVCRT version. --- configure |4 +++- libavutil/mem.c |6

Re: [libav-devel] [PATCH] mem: add support for __mingw_aligned_malloc()

2012-06-18 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: On Mon, 18 Jun 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: This function is like _aligned_malloc(), but part of the statically linked mingw runtime, so it's available regardless of the targeted MSVCRT version. --- configure

Re: [libav-devel] [PATCH] mem: add support for __mingw_aligned_malloc()

2012-06-18 Thread Derek Buitenhuis
On 18/06/2012 4:04 PM, Måns Rullgård wrote: Maybe it's time to drop win2k support. Does anyone actually still use it? I think we should. MS doesn't even support it anymore. If someone is using it, they're already using unpatched and unsupported software. - Derek

[libav-devel] [PATCH] lavc: Extend the documentation for avcodec_init_packet

2012-06-18 Thread Martin Storsjö
From: Simon A. Eugster simon...@gmail.com Add a note that pkt-data and pkt-size must be initialized. --- libavcodec/avcodec.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 94c2ed7..63f2fc8 100644 --- a/libavcodec/avcodec.h

Re: [libav-devel] [PATCH] mem: add support for __mingw_aligned_malloc()

2012-06-18 Thread Sean McGovern
On Monday, June 18, 2012, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 18/06/2012 4:04 PM, Måns Rullgård wrote: Maybe it's time to drop win2k support. Does anyone actually still use it? I think we should. MS doesn't even support it anymore. If someone is using it, they're already

Re: [libav-devel] [PATCH] lavc: Extend the documentation for avcodec_init_packet

2012-06-18 Thread Justin Ruggles
On 06/18/2012 04:19 PM, Martin Storsjö wrote: From: Simon A. Eugster simon...@gmail.com Add a note that pkt-data and pkt-size must be initialized. --- libavcodec/avcodec.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h

[libav-devel] [PATCH 4/4] lavr: resampling: add support for s32p, fltp, and dblp internal sample formats

2012-06-18 Thread Justin Ruggles
Based partially on implementation by Michael Niedermayer michae...@gmx.at in libswresample in FFmpeg. See commits: 7f1ae79d38c4edba9dbd31d7bf797e525298ac55 24ab1abfb6d55bf330022df4b10d7aec80b3f116 --- Changed the RENAME macro to SET_TYPE per Diego's request. libavresample/resample.c |

Re: [libav-devel] [PATCH] af_amix: move per-input MixContext fields into a separate struct

2012-06-18 Thread Justin Ruggles
On 06/10/2012 05:50 PM, Justin Ruggles wrote: simplifies allocation --- Fixed a memleak in the previous patch. libavfilter/af_amix.c | 77 +++-- 1 files changed, 36 insertions(+), 41 deletions(-) ping. -Justin

[libav-devel] x32 status

2012-06-18 Thread Diego Elio Pettenò
Since Gentoo now has some kind of support for x32 I was able to get a system running with it. Seems like it's going to be a trainwreck: - sizeof(void*) == sizeof(long) == sizeof(sizeof(0)) == 4 which means we really have no way to find out whether this is 32-bit or 64-bit; - afaict yasm

Re: [libav-devel] x32 status

2012-06-18 Thread Måns Rullgård
Diego Elio Pettenò flamee...@flameeyes.eu writes: Since Gentoo now has some kind of support for x32 I was able to get a system running with it. Seems like it's going to be a trainwreck: - sizeof(void*) == sizeof(long) == sizeof(sizeof(0)) == 4 which means we really have no way to find

Re: [libav-devel] x32 status

2012-06-18 Thread Diego Elio Pettenò
Il 19/06/2012 01:53, Måns Rullgård ha scritto: Add to this that the inline asm probably doesn't even remotely work properly, if it even compiles, with the x32 ABI. Doesn't compile: the x86 asm is the wrong syntax; x86-64 the wrong size. -- Diego Elio Pettenò — Flameeyes flamee...@flameeyes.eu

Re: [libav-devel] x32 status

2012-06-18 Thread Jason Garrett-Glaser
On Mon, Jun 18, 2012 at 4:49 PM, Diego Elio Pettenò flamee...@flameeyes.eu wrote: Since Gentoo now has some kind of support for x32 I was able to get a system running with it. Seems like it's going to be a trainwreck:  - sizeof(void*) == sizeof(long) == sizeof(sizeof(0)) == 4   which means

  1   2   >