[libav-devel] [PATCH] h264: use proper PROLOGUE statement for a function using 8 registers.

2012-04-15 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Fixes crashes when using biweight on win64. --- libavcodec/x86/h264_weight_10bit.asm |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/h264_weight_10bit.asm b/libavcodec/x86/h264_weight_10bit.asm index c4b1298..dec9

[libav-devel] [PATCH] h264: use proper PROLOGUE statement for a function using 8 registers.

2012-04-15 Thread Ronald S. Bultje
See attachment. Fixes crashes when using biweight on win64. Ronald 0001-h264-use-proper-PROLOGUE-statement-for-a-function-us.patch Description: Binary data ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/liba

Re: [libav-devel] [PATCH] utvideo: Remove unused variable 'src_size'

2012-04-14 Thread Ronald S. Bultje
Hi, On Sat, Apr 14, 2012 at 2:28 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- >  libavcodec/utvideo.c |   12 >  1 file changed, 4 insertions(+), 8 deletions(-) OK. Ronald ___ libav-devel mailing list libav-devel@li

Re: [libav-devel] [PATCH 3/3] Add roqaudio regression test.

2012-04-14 Thread Ronald S. Bultje
Hi, On Sat, Apr 14, 2012 at 4:14 PM, Derek Buitenhuis wrote: > From: Reimar Döffinger > > Signed-off-by: Reimar Döffinger > --- >  tests/codec-regression.sh |    5 + >  tests/ref/acodec/roqaudio |    4 >  2 files changed, 9 insertions(+) >  create mode 100644 tests/ref/acodec/roqaudio

Re: [libav-devel] [PATCH] tta: prevents overflows for 32bit integers in header.

2012-04-14 Thread Ronald S. Bultje
Hi, On Sat, Mar 31, 2012 at 10:40 AM, Justin Ruggles wrote: > On 03/31/2012 01:25 PM, Måns Rullgård wrote: > >> Justin Ruggles writes: >> >>> On 03/31/2012 01:07 PM, Måns Rullgård wrote: >>> >>>> "Ronald S. Bultje" writes: >>

Re: [libav-devel] [PATCH] targa: Simplify using bytestream_get() functions.

2012-04-14 Thread Ronald S. Bultje
Hi, On Sat, Apr 14, 2012 at 5:43 AM, Diego Biurrun wrote: > On Sun, Jul 03, 2011 at 05:06:25PM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> >> > From: Reimar Döffinger >> > >> > Signed-off-by: Reimar Döffinger >> > Signed-off-by: Diego Biurrun >> > --- >> >  libavcodec/targa.c |  

Re: [libav-devel] WMA Lossless cleanup

2012-04-13 Thread Ronald S. Bultje
Hi, On Fri, Apr 13, 2012 at 2:00 PM, Mashiat Sarker Shakkhar wrote: > The following patch-series silences some gcc warnings about unused variables. > >    [PATCH 1/4] WMAL: Drop unused variable num_possible_block_size >    [PATCH 2/4] Skip seekable_frame_in_packet >    [PATCH 3/4] WMAL: Warn abou

Re: [libav-devel] [PATCH] swscale: round yuv422 output correctly.

2012-04-13 Thread Ronald S. Bultje
Hi, On Fri, Apr 13, 2012 at 2:55 PM, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > --- >  libswscale/output.c |   24 >  1 file changed, 12 insertions(+), 12 deletions(-) Scratch this one for now, I'm thinking if t

Re: [libav-devel] [PATCH] swscale: fix off-by-one in second coefficient in bilinear filters.

2012-04-13 Thread Ronald S. Bultje
Hi, On Fri, Apr 13, 2012 at 2:58 PM, Luca Barbato wrote: > On 13/04/12 14:37, Ronald S. Bultje wrote: >> From: "Ronald S. Bultje" >> >> If coefficient A is 12-bits xixed-point number "X", then the other > > fixed? > >

[libav-devel] [PATCH] swscale: round yuv422 output correctly.

2012-04-13 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- libswscale/output.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libswscale/output.c b/libswscale/output.c index b58bda9..ebe1f32 100644 --- a/libswscale/output.c +++ b/libswscale/output.c @@ -510,

[libav-devel] [PATCH] swscale: clip before assigning tables in RGB output functions.

2012-04-13 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- libswscale/output.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/libswscale/output.c b/libswscale/output.c index c0f9b36..b58bda9 100644 --- a/libswscale/output.c +++ b/libswscale/output.c @@ -1005,1

[libav-devel] [PATCH] swscale: fix off-by-one in second coefficient in bilinear filters.

2012-04-13 Thread Ronald S. Bultje
From: "Ronald S. Bultje" If coefficient A is 12-bits xixed-point number "X", then the other coefficient is (1 << 12) - X, not (1 << 12) - X - 1. --- libswscale/output.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libswscal

[libav-devel] [PATCH] dsputil: fix optimized emu_edge function on Win64.

2012-04-13 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Recent register allocation changes (x86inc.asm update) changed the register order and thus opcodes for the inner loops. One of them became >128bytes, which confuses other parts of this function where it jumps to fixed-offset positions to extend the edge by

Re: [libav-devel] [PATCH] swscale: K&R formatting cosmetics (part II)

2012-04-13 Thread Ronald S. Bultje
Hi, On Fri, Apr 13, 2012 at 12:04 AM, Diego Biurrun wrote: > Also adjust some comments including wording and typo fixes. > --- >  libswscale/swscale.c          |  567 + >  libswscale/swscale_internal.h |    8 +- >  libswscale/utils.c            | 1473 > +++---

Re: [libav-devel] [PATCH] swscale: mmx/sse2/ssse3/avx yuv2yuyv422_X vertical scaling/output functions.

2012-04-13 Thread Ronald S. Bultje
Hi, 2012/4/13 Måns Rullgård : > "Ronald S. Bultje" writes: > >> From: "Ronald S. Bultje" >> >> --- >>  libswscale/utils.c                |   41 >>  libswscale/x86/output.asm         |  185 >>

Re: [libav-devel] [PATCH] vp3: Assert on invalid filter_limit values.

2012-04-13 Thread Ronald S. Bultje
Hi, 2012/4/13 Måns Rullgård : > dalecur...@chromium.org writes: > >> From: Dale Curtis >> >> Signed-off-by: Dale Curtis >> --- >>  libavcodec/vp3.c |    1 + >>  1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c >> index e94264e..e146593 10064

Re: [libav-devel] [PATCH] Revert "matroskadec: don't set codec timebase."

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 10:05 PM, Luca Barbato wrote: > On 12/04/12 18:27, Dale Curtis wrote: >> @Luca: thanks for taking a look! > > Ok, so: > > current head, webm file freshly baked using the default settings from > avconv. [..] > Please tell me how to reproduce your issue better if you can

Re: [libav-devel] [PATCH] matroska: Fix leaking memory allocated for laces.

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 9:34 PM, Luca Barbato wrote: > On 12/04/12 21:28, Ronald S. Bultje wrote: >> On Thu, Apr 12, 2012 at 5:35 PM, Luca Barbato wrote: >>> On 12/04/12 17:14, dalecur...@chromium.org wrote: >>> Probably could be factored with a goto, beside that

Re: [libav-devel] [PATCH] vp3: Assert on invalid filter_limit values.

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 4:12 PM, Ronald S. Bultje wrote: > On Thu, Apr 12, 2012 at 4:07 PM,   wrote: >> From: Dale Curtis >> >> Signed-off-by: Dale Curtis >> --- >>  libavcodec/vp3.c |    1 + >>  1 files changed, 1 insertions(+), 0 deletions(-

Re: [libav-devel] [PATCH] pthread: Fix crash due to fctx->delaying not being cleared.

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 5:15 PM, Ronald S. Bultje wrote: > On Thu, Apr 12, 2012 at 5:12 PM,   wrote: >> From: Dale Curtis >> >> Reproducible with test case and ffplay -threads 2. Stack trace: >> http://pastebin.com/PexZ4Uc0 >> >> Test case: >

Re: [libav-devel] [PATCH] ac3dsp: call femms/emms at the end of float_to_fixed24() for 3DNow and SSE

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 8:34 PM, Justin Ruggles wrote: > On 04/12/2012 04:49 PM, Ronald S. Bultje wrote: >> On Thu, Apr 12, 2012 at 1:22 PM, Justin Ruggles >> wrote: >>> Fixes ac3-encode and eac3-encode FATE test failures with SSE2 disabled. >>> --- >

Re: [libav-devel] [PATCH] matroska: Fix leaking memory allocated for laces.

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 5:35 PM, Luca Barbato wrote: > On 12/04/12 17:14, dalecur...@chromium.org wrote: > Probably could be factored with a goto, beside that seems ok. Attached OK? Ronald 0001-matroska-Fix-leaking-memory-allocated-for-laces.patch Description: Binary data

Re: [libav-devel] [PATCH] pthread: Fix crash due to fctx->delaying not being cleared.

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 5:12 PM, wrote: > From: Dale Curtis > > Reproducible with test case and ffplay -threads 2. Stack trace: > http://pastebin.com/PexZ4Uc0 > > Test case: > http://commondatastorage.googleapis.com/dalecurtis-shared/crash.ogm > > Signed-off-by: Dale Curtis > --- >  libavc

Re: [libav-devel] [PATCH] swscale: K&R formatting cosmetics (part II)

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 1:36 AM, Diego Biurrun wrote: > On Fri, Apr 06, 2012 at 05:57:59PM +0200, Diego Biurrun wrote: >> On Thu, Apr 05, 2012 at 04:54:40PM -0700, Ronald S. Bultje wrote: >> > On Thu, Apr 5, 2012 at 4:52 AM, Diego Biurrun wrote: >> > > -      

Re: [libav-devel] [PATCH] vp3: Assert on invalid filter_limit values.

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 4:07 PM, wrote: > From: Dale Curtis > > Signed-off-by: Dale Curtis > --- >  libavcodec/vp3.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c > index e94264e..e146593 100644 > --- a/libavcodec/vp3.c >

Re: [libav-devel] [PATCH] swscale: mmx/sse2/ssse3/avx yuv2yuyv422_X vertical scaling/output functions.

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 3:54 PM, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > --- >  libswscale/utils.c                |   41 >  libswscale/x86/output.asm         |  185 > + >  libswscal

[libav-devel] [PATCH] swscale: mmx/sse2/ssse3/avx yuv2yuyv422_X vertical scaling/output functions.

2012-04-12 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- libswscale/utils.c| 41 libswscale/x86/output.asm | 185 + libswscale/x86/swscale_mmx.c | 43 + libswscale/x86/swscale_template.c | 44 - 4 files changed, 269

Re: [libav-devel] [PATCH] ac3dsp: call femms/emms at the end of float_to_fixed24() for 3DNow and SSE

2012-04-12 Thread Ronald S. Bultje
Hi, On Thu, Apr 12, 2012 at 1:22 PM, Justin Ruggles wrote: > Fixes ac3-encode and eac3-encode FATE test failures with SSE2 disabled. > --- >  libavcodec/x86/ac3dsp.asm |    6 -- >  1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/x86/ac3dsp.asm b/libavcodec/x86/ac3

[libav-devel] [PATCH] h264: fix 10bit biweight functions after recent x86inc.asm fixes.

2012-04-12 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- libavcodec/x86/h264_weight_10bit.asm |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/h264_weight_10bit.asm b/libavcodec/x86/h264_weight_10bit.asm index 481c7ca..c4b1298 100644 --- a/libavcodec/x86/h264_weight

Re: [libav-devel] [PATCH] vp3: Fix out of bounds write.

2012-04-11 Thread Ronald S. Bultje
Hi, On Wed, Apr 11, 2012 at 6:09 PM, wrote: > From: Dale Curtis > > On corrupt or malicious files, filter_limit can be >= 128 leading > to an out of bounds write. > > Signed-off-by: Dale Curtis > --- >  libavcodec/vp3.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --g

Re: [libav-devel] [PATCH] movenc: fix segfault with chapter tracks (cherrypick)

2012-04-10 Thread Ronald S. Bultje
Hi, On Tue, Apr 10, 2012 at 4:11 PM, Johan Andersson wrote: > Hallå. > > Cherry picked this fix from ffmpeg and it fixes bugreport 263 OK. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] h264: Split H.264 decoder off from H.264 common code.

2012-04-10 Thread Ronald S. Bultje
Hi, On Tue, Apr 10, 2012 at 1:49 PM, Diego Biurrun wrote: > On Tue, Apr 10, 2012 at 01:27:59PM -0700, Ronald S. Bultje wrote: >> On Tue, Apr 10, 2012 at 1:23 PM, Diego Biurrun wrote: >> > On Tue, Apr 10, 2012 at 12:49:20PM -0700, Ronald S. Bultje wrote: >> >> On

Re: [libav-devel] [PATCH] h264: Split H.264 decoder off from H.264 common code.

2012-04-10 Thread Ronald S. Bultje
Hi, On Tue, Apr 10, 2012 at 1:23 PM, Diego Biurrun wrote: > On Tue, Apr 10, 2012 at 12:49:20PM -0700, Ronald S. Bultje wrote: >> On Tue, Apr 10, 2012 at 12:40 PM, Diego Biurrun wrote: >> > On Tue, Apr 10, 2012 at 11:37:30AM -0700, Luca Barbato wrote: >> >> On 10/04

Re: [libav-devel] [PATCH] h264: Split H.264 decoder off from H.264 common code.

2012-04-10 Thread Ronald S. Bultje
Hi, On Tue, Apr 10, 2012 at 12:40 PM, Diego Biurrun wrote: > On Tue, Apr 10, 2012 at 11:37:30AM -0700, Luca Barbato wrote: >> On 10/04/12 09:24, Diego Biurrun wrote: >> > On Tue, Apr 10, 2012 at 07:30:30AM -0700, Ronald S. Bultje wrote: >> >> On Tue, Apr 10, 2012 at

Re: [libav-devel] [PATCH] interplayvideo: fix av_dlog parameter type mismatch

2012-04-10 Thread Ronald S. Bultje
Hi, On Tue, Apr 10, 2012 at 10:23 AM, Diego Biurrun wrote: > libavcodec/interplayvideo.c:909:13: warning: format ‘%p’ expects argument of > type ‘void *’, but argument 7 has type ‘GetByteContext’ [-Wformat] > --- >  libavcodec/interplayvideo.c |    5 +++-- >  1 files changed, 3 insertions(+), 2

Re: [libav-devel] [PATCH] rv40dsp: implement prescaled versions for biweight.

2012-04-10 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 4:15 PM, Ronald S. Bultje wrote: > On Thu, Apr 5, 2012 at 1:29 PM, Christophe Gisquet > wrote: >> 2012/4/5 Ronald S. Bultje : >>> This looks OK. Is there a performance benefit? I assume there isn't >>> anything measurable, bec

Re: [libav-devel] [PATCH] h264: Split H.264 decoder off from H.264 common code.

2012-04-10 Thread Ronald S. Bultje
Hi, On Tue, Apr 10, 2012 at 9:27 AM, Martin Storsjö wrote: > On Tue, 10 Apr 2012, Diego Biurrun wrote: > >> On Tue, Apr 10, 2012 at 07:30:30AM -0700, Ronald S. Bultje wrote: >>> >>> On Tue, Apr 10, 2012 at 7:12 AM, Diego Biurrun wrote: >>>> >>&g

Re: [libav-devel] [PATCH] interplayvideo: adjust av_dlog parameter type

2012-04-10 Thread Ronald S. Bultje
Hi, On Tue, Apr 10, 2012 at 9:19 AM, Diego Biurrun wrote: > libavcodec/interplayvideo.c:909:13: warning: format ‘%p’ expects argument of > type ‘void *’, but argument 7 has type ‘GetByteContext’ [-Wformat] > --- >  libavcodec/interplayvideo.c |    2 +- >  1 files changed, 1 insertions(+), 1 dele

Re: [libav-devel] [PATCH] h264: Split H.264 decoder off from H.264 common code.

2012-04-10 Thread Ronald S. Bultje
Hi, On Tue, Apr 10, 2012 at 7:12 AM, Diego Biurrun wrote: > On Fri, Mar 30, 2012 at 02:08:22AM +0200, Diego Biurrun wrote: >> --- >>  libavcodec/Makefile  |    2 +- >>  libavcodec/h264.c    |  358 >> +++--- >>  libavcodec/h264.h    |    5 + >>  libavco

Re: [libav-devel] [PATCH] swscale: Properly scale YUV

2012-04-09 Thread Ronald S. Bultje
Hi, On Mon, Apr 9, 2012 at 3:12 PM, Derek Buitenhuis wrote: > Only shift limited range luma, and always only shift chroma > for upconversion. Sorry, what does this mean? Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org

Re: [libav-devel] [PATCH] mem: Consistently return NULL for av_malloc(0)

2012-04-09 Thread Ronald S. Bultje
Hi, On Mon, Apr 9, 2012 at 12:10 PM, Martin Storsjö wrote: > Plain POSIX malloc(0) is allowed to return either NULL or a > non-NULL pointer. The calling code should be ready to handle > a NULL return as a correct return (instead of a failure) if the size > to allocate was 0 - this makes sure the

Re: [libav-devel] [PATCH 2/2] ppc: Add/remove a number of const qualifiers to fix related warnings.

2012-04-09 Thread Ronald S. Bultje
Hi, On Mon, Apr 9, 2012 at 11:14 AM, Diego Biurrun wrote: > On Mon, Apr 02, 2012 at 07:03:30PM +0200, Diego Biurrun wrote: >> --- >>  libavcodec/ppc/gmc_altivec.c     |    2 +- >>  libavcodec/ppc/int_altivec.c     |    3 ++- >>  libswscale/ppc/yuv2rgb_altivec.c |   10 +- >>  3 files chang

Re: [libav-devel] [PATCH] mem: Consistently return NULL for av_malloc(0)

2012-04-09 Thread Ronald S. Bultje
Hi, On Mon, Apr 9, 2012 at 10:34 AM, Martin Storsjö wrote: > On Mon, 9 Apr 2012, Ronald S. Bultje wrote: >> On Mon, Apr 9, 2012 at 4:50 AM, Martin Storsjö wrote: >>> On Sun, 8 Apr 2012, Martin Storsjö wrote: >>>> Plain POSIX malloc(0) is allowed to return either N

Re: [libav-devel] [PATCH] mem: Consistently return NULL for av_malloc(0)

2012-04-09 Thread Ronald S. Bultje
Hi, On Mon, Apr 9, 2012 at 4:50 AM, Martin Storsjö wrote: > On Sun, 8 Apr 2012, Martin Storsjö wrote: > >> Plain POSIX malloc(0) is allowed to return either NULL or a >> non-NULL pointer. The calling code should be ready to handle >> a NULL return as a correct return (instead of a failure) if the

Re: [libav-devel] [PATCH] avutil: use align == 0 for default alignment in audio sample buffer functions

2012-04-08 Thread Ronald S. Bultje
Hi, On Sun, Apr 8, 2012 at 5:00 PM, Justin Ruggles wrote: > --- >  libavutil/avutil.h    |    2 +- >  libavutil/samplefmt.c |    4 >  libavutil/samplefmt.h |    5 +++-- >  3 files changed, 8 insertions(+), 3 deletions(-) LGTM. Ronald ___ libav-de

Re: [libav-devel] [PATCH 03/11] lavc doxy: fix formatting of AV_PKT_DATA_{PARAM_CHANGE, H263_MB_INFO}

2012-04-08 Thread Ronald S. Bultje
Hi, On Sun, Apr 8, 2012 at 5:09 AM, Anton Khirnov wrote: > --- >  libavcodec/avcodec.h |    4 >  1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 09f1b81..ee6cb9f 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcod

Re: [libav-devel] [PATCH 06/11] lavc doxy: replace \ with /

2012-04-08 Thread Ronald S. Bultje
Hi, On Sun, Apr 8, 2012 at 5:09 AM, Anton Khirnov wrote: > It's the more proper symbol to use and it prevents doxygen from thinking > it's a command. > --- >  libavcodec/avcodec.h |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avco

Re: [libav-devel] [PATCH] Convert vector_fmul to yasm and add AVX

2012-04-07 Thread Ronald S. Bultje
Hi, On Sat, Apr 7, 2012 at 4:15 PM, Kieran Kunhya wrote: >> Doesn't x86inc.asm already abstract these? So that you could use mulps >> in both cases and end up with exactly what you have there? > > I tried that and it didn't work. mulps appears to be setup correctly > as an avx instruction in x86i

Re: [libav-devel] [PATCH] Convert vector_fmul to yasm and add AVX

2012-04-07 Thread Ronald S. Bultje
Hi, On Sat, Apr 7, 2012 at 3:56 PM, Kieran Kunhya wrote: > $subj > > I'll probably convert the rest of the vector_fmul functions if my use > of x264asm for floats is considered ok. Not that I care much, but you are dropping the 3dnow implementation, is that intentional? Ronald _

Re: [libav-devel] [PATCH] cosmetics: Fix indentation

2012-04-07 Thread Ronald S. Bultje
Hi, On Sat, Apr 7, 2012 at 1:47 PM, Martin Storsjö wrote: > --- >  libavformat/rtpdec_xiph.c |    2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) OK. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listi

Re: [libav-devel] [PATCH] rtsp: Don't expose the MS-RTSP RTX data stream to the caller

2012-04-07 Thread Ronald S. Bultje
Hi, On Sat, Apr 7, 2012 at 1:48 PM, Martin Storsjö wrote: > This avoids exposing a dummy AVStream which won't get any data > and which will make avformat_find_stream_info wait for info about > this stream. > --- >  libavformat/rtpdec.c       |    2 +- >  libavformat/rtpdec_amr.c   |    3 +++ >  l

Re: [libav-devel] [PATCH 1/4] avutil: allow NULL linesize in av_samples_fill_arrays() and av_samples_alloc()

2012-04-07 Thread Ronald S. Bultje
Hi, On Sat, Apr 7, 2012 at 11:55 AM, Justin Ruggles wrote: > On 04/07/2012 02:16 PM, Ronald S. Bultje wrote: >> On Thu, Apr 5, 2012 at 4:13 PM, Justin Ruggles >> wrote: >>> --- >>>  libavutil/samplefmt.c |    9 ++--- >>>  libavutil/samplefmt.h |  

Re: [libav-devel] [PATCH 1/4] avutil: allow NULL linesize in av_samples_fill_arrays() and av_samples_alloc()

2012-04-07 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 4:13 PM, Justin Ruggles wrote: > --- >  libavutil/samplefmt.c |    9 ++--- >  libavutil/samplefmt.h |    4 ++-- >  2 files changed, 8 insertions(+), 5 deletions(-) Why? Are there particular cases where passing NULL saves code or cycles? Ronald

Re: [libav-devel] [PATCH 3/4] avcodec: use align == 0 for default alignment in avcodec_fill_audio_frame()

2012-04-07 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 4:13 PM, Justin Ruggles wrote: > Use default alignment in audio_get_buffer() > --- >  libavcodec/avcodec.h |    2 +- >  libavcodec/utils.c   |    4 ++-- >  libavcodec/version.h |    2 +- >  3 files changed, 4 insertions(+), 4 deletions(-) LGTM. Ronald

Re: [libav-devel] [PATCH 4/4] avconv: use default alignment for audio buffer

2012-04-07 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 4:13 PM, Justin Ruggles wrote: > --- >  avconv.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/avconv.c b/avconv.c > index 1c97c80..f87962e 100644 > --- a/avconv.c > +++ b/avconv.c > @@ -1030,7 +1030,7 @@ static int alloc_audio_output_bu

Re: [libav-devel] [PATCH 2/4] avutil: use align == 0 for default alignment in audio sample buffer functions

2012-04-07 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 4:13 PM, Justin Ruggles wrote: > +    /* auto-select alignment if not specified */ > +    if (!align) { > +        if (planar) > +            align = 32; > +        else > +            align = 32 * FFMIN(nb_channels, 32); > +    } Why 2*n_channels? Isn't 32 enough? >

Re: [libav-devel] [PATCH] rtsp: Don't expose the MS-RTSP RTX data stream to the caller

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 3:00 PM, Martin Storsjö wrote: > This avoids exposing a dummy AVStream which won't get any data > and which will make avformat_find_stream_info wait for info about > this stream. > --- >  libavformat/rtpdec.c     |    2 +- >  libavformat/rtpdec_asf.c |    2 ++ >  libavf

Re: [libav-devel] [PATCH 1/2] asfdec: Add an option for not searching for the packet markers

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 2:56 PM, Martin Storsjö wrote: > On Fri, 6 Apr 2012, Ronald S. Bultje wrote: >> On Fri, Apr 6, 2012 at 2:45 PM, Ronald S. Bultje >> wrote: >>> On Fri, Apr 6, 2012 at 7:57 AM, Martin Storsjö wrote: >>>> On Fri, 6 Apr 2012, Ronald

Re: [libav-devel] [PATCH 1/2] asfdec: Add an option for not searching for the packet markers

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 2:45 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Apr 6, 2012 at 7:57 AM, Martin Storsjö wrote: >> On Fri, 6 Apr 2012, Ronald S. Bultje wrote: >>> On Fri, Apr 6, 2012 at 7:03 AM, Martin Storsjö wrote: >>>> >>>> Some s

Re: [libav-devel] [PATCH 1/2] asfdec: Add an option for not searching for the packet markers

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 7:57 AM, Martin Storsjö wrote: > On Fri, 6 Apr 2012, Ronald S. Bultje wrote: >> On Fri, Apr 6, 2012 at 7:03 AM, Martin Storsjö wrote: >>> >>> Some streams don't contain these. >>> --- >>> I also tried changing the cod

Re: [libav-devel] [PATCH] nellymoserenc: fix crash due to memsetting the wrong area.

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 11:00 AM, Martin Storsjö wrote: > From: Reimar Döffinger > > Signed-off-by: Reimar Döffinger > --- >  libavcodec/nellymoserenc.c |    2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/nellymoserenc.c b/libavcodec/nellymoserenc.c > index

Re: [libav-devel] [PATCH] cosmetics: Convert mimic.c to utf-8

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 10:57 AM, Martin Storsjö wrote: > --- >  libavcodec/mimic.c |    2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mimic.c b/libavcodec/mimic.c > index 33c5f7b..18f552d 100644 > --- a/libavcodec/mimic.c > +++ b/libavcodec/mimic.c > @@ -1,

Re: [libav-devel] [PATCH 1/2] libavformat: Don't require a codec to be set for data streams

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 8:29 AM, Martin Storsjö wrote: > On Fri, 6 Apr 2012, Ronald S. Bultje wrote: >> On Fri, Apr 6, 2012 at 7:13 AM, Martin Storsjö wrote: >>> >>> This avoids blocking for a long time in >>> avformat_find_stream_info while waiting for a

Re: [libav-devel] [PATCH] mpeg12: Do not change frame_pred_frame_dct flag and demote error into a warning.

2012-04-06 Thread Ronald S. Bultje
Hi, On Wed, Apr 4, 2012 at 1:55 PM, Anne X wrote: > On Wed, Apr 4, 2012 at 12:29 PM, Ronald S. Bultje > wrote: >> I see. Do you mind if I ask for a real name so we can attribute it to >> you personally? > > Sure, > Anne Aaron Pushed by Martin - th

Re: [libav-devel] [PATCH 2/2] Fix up our asm to work with new x86inc.asm.

2012-04-06 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 4:57 PM, Ronald S. Bultje wrote: > On Wed, Apr 4, 2012 at 2:03 PM, Ronald S. Bultje wrote: >> From: "Ronald S. Bultje" >> >> --- >>  libavcodec/x86/dsputil_yasm.asm    |   36 - >>  libavcodec/x86/fft_mmx.a

Re: [libav-devel] [PATCH 2/2] libavformat: Only require first packet to be known for audio/video streams

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 7:13 AM, Martin Storsjö wrote: > From: Joakim Plate > > It can take a long time before subtitles or data streams show up, > so we shouldn't wait for those before assuming we have all info > for streams. > --- > This also is required for MS-RTSP streams not to stay wait

Re: [libav-devel] [PATCH 1/2] asfdec: Add an option for not searching for the packet markers

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 7:03 AM, Martin Storsjö wrote: > Some streams don't contain these. > --- > I also tried changing the code in ff_asf_get_packet to seek back > and try to restart with the assumption that there isn't any start > marker (the code with a FIXME remark), but it broke in vario

Re: [libav-devel] [PATCH 1/2] libavformat: Don't require a codec to be set for data streams

2012-04-06 Thread Ronald S. Bultje
Hi, On Fri, Apr 6, 2012 at 7:13 AM, Martin Storsjö wrote: > This avoids blocking for a long time in > avformat_find_stream_info while waiting for a codec to be set > for data streams in MS-RTSP streams, where the codec won't > ever be set. > > This is an adaptation of one part of commit 4c0504297

[libav-devel] [PATCH] swscale: handle last pixel if lines have an odd width.

2012-04-05 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Fixes bug 270. --- libswscale/output.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libswscale/output.c b/libswscale/output.c index f1acf9e..5bc25fc 100644 --- a/libswscale/output.c +++ b/libswscale/output.c

Re: [libav-devel] [PATCH 2/2] Fix up our asm to work with new x86inc.asm.

2012-04-05 Thread Ronald S. Bultje
Hi, On Wed, Apr 4, 2012 at 2:03 PM, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > --- >  libavcodec/x86/dsputil_yasm.asm    |   36 - >  libavcodec/x86/fft_mmx.asm         |   25 +++--- >  libavcodec/x86/fmtconvert.asm      |    6 +- >  libavcodec

Re: [libav-devel] [PATCH] swscale: K&R formatting cosmetics (part II)

2012-04-05 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 4:52 AM, Diego Biurrun wrote: > -        for (j = 0; j < filterSize; j++) { > +        for (j = 0; j < filterSize; j++) >             val += src[srcPos + j] * filter[filterSize * i + j]; > -        } Didn't we just have a discussion over that? Ronald _

Re: [libav-devel] [PATCH] rv40dsp: implement prescaled versions for biweight.

2012-04-05 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 1:29 PM, Christophe Gisquet wrote: > 2012/4/5 Ronald S. Bultje : >> This looks OK. Is there a performance benefit? I assume there isn't >> anything measurable, because the overhead is relatively low? > > Yes, the split between prescaled/non-

Re: [libav-devel] [PATCH] rv34dsp x86: implement MMX2 inverse transform

2012-04-05 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 1:07 PM, Christophe Gisquet wrote: > 2012/4/5 Ronald S. Bultje : >> That's ... quite a non-standard IDCT, generally you do a 1D IDCT, >> transpose, then another 1D IDCT, right? I don't quite see that here. >> Am I misunderstanding it? &

Re: [libav-devel] [PATCH] rv34dsp x86: implement MMX2 inverse transform

2012-04-05 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 12:32 PM, Christophe Gisquet wrote: > Hi, > > 2012/4/5 Derek Buitenhuis : >> I think you actually forgot to attach the patch. :P > > Here it is. That's ... quite a non-standard IDCT, generally you do a 1D IDCT, transpose, then another 1D IDCT, right? I don't quite see

Re: [libav-devel] [PATCH] rv40dsp: implement prescaled versions for biweight.

2012-04-05 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 8:01 AM, Christophe Gisquet wrote: > while the asm part is not very readable, this patch can be summarized > as having 2 sets of bi-weight functions depending on whether weight > fractions can be simplified. This trick was also used in the SSSE3 x86 > implementation, bu

Re: [libav-devel] [PATCH] h264: Factorize declaration of mb_sizes array.

2012-04-05 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 7:24 AM, Diego Biurrun wrote: > --- >  libavcodec/h264.c       |    5 +++-- >  libavcodec/h264.h       |    1 + >  libavcodec/h264_cabac.c |    4 ++-- >  libavcodec/h264_cavlc.c |    4 ++-- >  4 files changed, 8 insertions(+), 6 deletions(-) Ok. Ronald ___

Re: [libav-devel] [PATCH] dsputil x86: remove deprecated parameter from scalarproduct_int16 prototype

2012-04-05 Thread Ronald S. Bultje
Hi, On Thu, Apr 5, 2012 at 2:10 AM, Benjamin Larsson wrote: > On 04/04/2012 07:49 PM, Christophe Gisquet wrote: >> >> Seems a hunk slipped by. >> >> Christophe > > > OK Sorry, I already pushed this, forgot to notify ML. Ronald ___ libav-devel mailing

[libav-devel] [PATCH 2/2] Fix up our asm to work with new x86inc.asm.

2012-04-04 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- libavcodec/x86/dsputil_yasm.asm| 36 - libavcodec/x86/fft_mmx.asm | 25 +++--- libavcodec/x86/fmtconvert.asm |6 +- libavcodec/x86/h264_chromamc.asm | 48 ++- libavcodec/x86/h264_deblock.asm

[libav-devel] [PATCH 1/2] x86inc improvements for 64-bit

2012-04-04 Thread Ronald S. Bultje
From: Henrik Gramner Add support for all x86-64 registers Prefer caller-saved register over callee-saved on WIN64 Support up to 15 function arguments Signed-off-by: Ronald S. Bultje --- libavutil/x86/x86inc.asm | 218 -- 1 file changed, 114

Re: [libav-devel] [PATCH] mpeg12: Do not change frame_pred_frame_dct flag and demote error into a warning.

2012-04-04 Thread Ronald S. Bultje
Hi, On Wed, Apr 4, 2012 at 12:27 PM, Anne X wrote: > On Wed, Apr 4, 2012 at 11:37 AM, Ronald S. Bultje > wrote: >> On Wed, Apr 4, 2012 at 11:36 AM, Funxion X wrote: >> > Patch for >> > http://lists.libav.org/pipermail/libav-devel/2012-March/025163.html >>

Re: [libav-devel] [PATCH] mpeg12: Do not change frame_pred_frame_dct flag and demote error into a warning.

2012-04-04 Thread Ronald S. Bultje
Hi, On Wed, Apr 4, 2012 at 11:36 AM, Funxion X wrote: > Patch for http://lists.libav.org/pipermail/libav-devel/2012-March/025163.html > > --- >  libavcodec/mpeg12.c |    3 +-- >  1 files changed, 1 insertions(+), 2 deletions(-) OK. Should we attribute this patch to the original reporter (David R

Re: [libav-devel] [PATCH] msrle: convert MS RLE decoding function to bytestream2.

2012-04-04 Thread Ronald S. Bultje
Hi, On Sat, Mar 31, 2012 at 11:10 AM, Ronald S. Bultje wrote: > --- >  libavcodec/aasc.c     |   12 + >  libavcodec/bmp.c      |    4 +- >  libavcodec/msrle.c    |    4 +- >  libavcodec/msrledec.c |  129 > + >  libavco

[libav-devel] [PATCH] swscale: handle complete dimensions for monoblack/white.

2012-04-04 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Fixes bug 269. --- libswscale/input.c |6 -- libswscale/output.c | 10 +++--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/libswscale/input.c b/libswscale/input.c index e636eac..b485509 100644 --- a/libswscale/input.c +++ b/

Re: [libav-devel] [PATCH] swscale: K&R formatting cosmetics (part II)

2012-04-04 Thread Ronald S. Bultje
Hi, On Sun, Apr 1, 2012 at 4:55 AM, Diego Biurrun wrote: > diff --git a/libswscale/utils.c b/libswscale/utils.c [..] > @@ -170,261 +172,301 @@ const char *sws_format_name(enum PixelFormat format) >         return "Unknown format"; >  } (TODO: remove this in favour of av_get_pix_fmt_name().) > -

Re: [libav-devel] [PATCH] swscale: K&R formatting cosmetics (part II)

2012-04-04 Thread Ronald S. Bultje
Hi, On Wed, Apr 4, 2012 at 9:56 AM, Diego Biurrun wrote: > There's still another file in need of review from that patch.  Anyway, I > want to get this in, so I'll send an updated patch, braces be damned... I'll get to it ... Haven't I reviewed all the other patches also? Ronald

Re: [libav-devel] [PATCH] vp8dsp x86: perform rounding shift with a single instruction

2012-04-04 Thread Ronald S. Bultje
Hi, On Wed, Apr 4, 2012 at 9:25 AM, Christophe Gisquet wrote: > 2012/4/4 Ronald S. Bultje : >> Yeah, I'm just wondering if it makes sense to describe the data, not >> its use, since the same data could be used for multiple things. > > Indeed, this hides it from a grep

Re: [libav-devel] [PATCH] vp8dsp x86: perform rounding shift with a single instruction

2012-04-04 Thread Ronald S. Bultje
Hi, On Wed, Apr 4, 2012 at 8:16 AM, Christophe Gisquet wrote: > 2012/4/4 Ronald S. Bultje : >>> +pw_rnd7:  times 8 dw 1 << (16 - 8) >> >> (You can just call this pw_256 if you want.) > > As the symbol does not exist elsewhere, I thought this would be more &g

Re: [libav-devel] [PATCH] h264: Factorize declaration of mb_sizes array.

2012-04-04 Thread Ronald S. Bultje
Hi, On Apr 4, 2012 7:43 AM, "Måns Rullgård" wrote: > > "Ronald S. Bultje" writes: > > > Hi, > > > > On Wed, Apr 4, 2012 at 6:49 AM, Diego Biurrun wrote: > >> --- > >> libavcodec/h264.c |2 ++ > >&

Re: [libav-devel] [PATCH] h264: Factorize declaration of mb_sizes array.

2012-04-04 Thread Ronald S. Bultje
Hi, On Wed, Apr 4, 2012 at 6:49 AM, Diego Biurrun wrote: > --- >  libavcodec/h264.c       |    2 ++ >  libavcodec/h264.h       |    1 + >  libavcodec/h264_cabac.c |    4 ++-- >  libavcodec/h264_cavlc.c |    4 ++-- >  4 files changed, 7 insertions(+), 4 deletions(-) Why not (like all other tables

Re: [libav-devel] [PATCH] vp8dsp x86: perform rounding shift with a single instruction

2012-04-04 Thread Ronald S. Bultje
Hi, On Wed, Apr 4, 2012 at 6:03 AM, Christophe Gisquet wrote: > there are numerous places with SSSE3 code using padd(s)w+psraw > instructions instead of the pmulhrsw one, which adds about 1 cycle per > iteration. > > vp8 MC is one of them. General concept looks good. > +pw_rnd7: times 8 dw 1 <

Re: [libav-devel] [PATCH] w32threads: Make pthread_cond_wait follow POSIX

2012-04-03 Thread Ronald S. Bultje
Hi, On Tue, Apr 3, 2012 at 2:48 PM, Derek Buitenhuis wrote: > pthread_cond_wait is supposed to return an integer, > and indeed does sometimes. Fix its function declaration > to match its behavior and POSIX. > > Signed-off-by: Derek Buitenhuis > --- >  libavcodec/w32pthreads.h |    4 ++-- >  1 fi

Re: [libav-devel] [PATCH] swscale: K&R formatting cosmetics (part II)

2012-04-03 Thread Ronald S. Bultje
Hi, On Tue, Apr 3, 2012 at 2:14 PM, Diego Biurrun wrote: > On Tue, Apr 03, 2012 at 07:23:50AM -0700, Ronald S. Bultje wrote: >> On Mon, Apr 2, 2012 at 12:57 PM, Diego Biurrun wrote: >> > On Mon, Apr 02, 2012 at 12:47:47PM -0700, Ronald S. Bultje wrote: >> >> O

Re: [libav-devel] [PATCH] swscale: K&R formatting cosmetics (part II)

2012-04-03 Thread Ronald S. Bultje
Hi, On Mon, Apr 2, 2012 at 12:57 PM, Diego Biurrun wrote: > On Mon, Apr 02, 2012 at 12:47:47PM -0700, Ronald S. Bultje wrote: >> On Mon, Apr 2, 2012 at 12:44 PM, Diego Biurrun wrote: >> > On Mon, Apr 02, 2012 at 10:13:50AM -0700, Ronald S. Bultje wrote: >> >>

Re: [libav-devel] [PATCH 1/1 v2] Unscaled Planar RGB -> RGB support in swscale.

2012-04-02 Thread Ronald S. Bultje
Hi, On Mon, Apr 2, 2012 at 4:20 PM, Diego Biurrun wrote: > On Mon, Apr 02, 2012 at 06:52:38PM -0400, Derek Buitenhuis wrote: >> >> --- a/libswscale/swscale_internal.h >> +++ b/libswscale/swscale_internal.h >> @@ -627,6 +627,14 @@ const char *sws_format_name(enum PixelFormat format); >>      (av_p

Re: [libav-devel] [PATCH] h264: fix 4:2:2 PCM-macroblocks decoding

2012-04-02 Thread Ronald S. Bultje
Hi, On Mon, Apr 2, 2012 at 1:43 PM, Diego Biurrun wrote: > On Mon, Apr 02, 2012 at 01:40:28PM -0700, Ronald S. Bultje wrote: >> >> quoted from IRC: >> >> On Mon, Apr 2, 2012 at 10:19 AM, Kostya Shishkov >> wrote: >> > On Mon, Apr 02, 2012 at 09:25:19AM

Re: [libav-devel] [PATCH] h264: fix 4:2:2 PCM-macroblocks decoding

2012-04-02 Thread Ronald S. Bultje
Hi, 2012/4/2 Måns Rullgård : > "Ronald S. Bultje" writes: >> quoted from IRC: >> >> On Mon, Apr 2, 2012 at 10:19 AM, Kostya Shishkov >> wrote: >>> On Mon, Apr 02, 2012 at 09:25:19AM -0700, Ronald S. Bultje wrote: >>>> From: Anton Mi

Re: [libav-devel] [PATCH] h264: fix 4:2:2 PCM-macroblocks decoding

2012-04-02 Thread Ronald S. Bultje
Hi, quoted from IRC: On Mon, Apr 2, 2012 at 10:19 AM, Kostya Shishkov wrote: > On Mon, Apr 02, 2012 at 09:25:19AM -0700, Ronald S. Bultje wrote: >> From: Anton Mitrofanov >> >> Fixes bug 239. >> >> Signed-off-by: Ronald S. Bultje >> --- >>  liba

Re: [libav-devel] [PATCH] swscale: K&R formatting cosmetics (part II)

2012-04-02 Thread Ronald S. Bultje
Hi, On Mon, Apr 2, 2012 at 12:44 PM, Diego Biurrun wrote: > On Mon, Apr 02, 2012 at 10:13:50AM -0700, Ronald S. Bultje wrote: >> >> On Sun, Apr 1, 2012 at 4:55 AM, Diego Biurrun wrote: >> > -        for (j = 0; j < filterSize; j++) { >> > +

Re: [libav-devel] [PATCH] Unscaled Planar RGB -> RGB support in swscale.

2012-04-02 Thread Ronald S. Bultje
Hi, On Mon, Apr 2, 2012 at 10:07 AM, Derek Buitenhuis wrote: > On 02/04/2012 12:46 PM, Ronald S. Bultje wrote: >> New macro, isPackedRGB and isPlanarRGB. >> >> #define isPlanarRGB(x) ((av_pix_fmt_descriptors[x].flags & >> (PIX_FMT_PLANAR | PIX_FMT_RGB)) =

Re: [libav-devel] [PATCH] swscale: K&R formatting cosmetics (part II)

2012-04-02 Thread Ronald S. Bultje
Hi, On Sun, Apr 1, 2012 at 4:55 AM, Diego Biurrun wrote: >  DECLARE_ALIGNED(8, const uint8_t, dither_8x8_128)[8][8] = { > -{  36, 68, 60, 92, 34, 66, 58, 90,}, > -{ 100,  4,124, 28, 98,  2,122, 26,}, > -{  52, 84, 44, 76, 50, 82, 42, 74,}, > -{ 116, 20,108, 12,114, 18,106, 10,}, > -{  32, 64, 56,

<    5   6   7   8   9   10   11   12   13   14   >