Re: [libav-devel] [PATCH] bink: Cast runtime-generated quant tables to const

2017-06-22 Thread Diego Biurrun
On Thu, Jun 22, 2017 at 11:24:50PM +0300, Rémi Denis-Courmont wrote: > On jeudi 22 juin 2017 21:12:00 EEST Diego Biurrun wrote: > > On Wed, Jun 21, 2017 at 07:10:55PM +0300, Rémi Denis-Courmont wrote: > > > Le keskiviikkona 21. kesäkuuta 2017, 18.07.05 EEST Diego Biurrun a écri

Re: [libav-devel] [PATCH] bink: Cast runtime-generated quant tables to const

2017-06-22 Thread Diego Biurrun
On Wed, Jun 21, 2017 at 07:10:55PM +0300, Rémi Denis-Courmont wrote: > Le keskiviikkona 21. kesäkuuta 2017, 18.07.05 EEST Diego Biurrun a écrit : > > On Wed, Jun 21, 2017 at 07:05:45PM +0300, Rémi Denis-Courmont wrote: > > > Le keskiviikkona 21. kesäkuuta 2017, 13.10.42 EEST Die

Re: [libav-devel] [PATCH] bink: Cast runtime-generated quant tables to const

2017-06-21 Thread Diego Biurrun
On Wed, Jun 21, 2017 at 07:05:45PM +0300, Rémi Denis-Courmont wrote: > Le keskiviikkona 21. kesäkuuta 2017, 13.10.42 EEST Diego Biurrun a écrit : > > Some of the quant tables used by Bink are generated at runtime and therefore > > not const while some others are stored in the binar

Re: [libav-devel] [PATCH] configure: Automatically add -isysroot for darwin if --sysroot is specified

2017-06-21 Thread Diego Biurrun
On Wed, Jun 21, 2017 at 04:58:45PM +0300, Martin Storsjö wrote: > --- a/configure > +++ b/configure > @@ -3981,6 +3981,10 @@ case $target_os in > { check_cflags -mdynamic-no-pic && add_asflags -mdynamic-no-pic; > } > check_header dispatch/dispatch.h && >

[libav-devel] [PATCH] bink: Cast runtime-generated quant tables to const

2017-06-21 Thread Diego Biurrun
Some of the quant tables used by Bink are generated at runtime and therefore not const while some others are stored in the binary and therefore are const. read_dct_coeffs() takes a const pointer to a quant table as parameter, cast that parameter to const for the runtime-generated tables.

[libav-devel] [PATCH] build: Add an option for passing linker flags to the shared library build

2017-06-20 Thread Diego Biurrun
From: Janne Grunau Also employ this mechanism to pass $libdir to the runtime library search path if rpath is enabled. This fixes underlinking of some test binaries on some systems. --- avbuild/library.mak | 2 +- configure | 11 ++- 2 files changed, 11

Re: [libav-devel] [PATCH 1/2] tls_openssl: Readd support for nonblocking operation

2017-06-20 Thread Diego Biurrun
On Mon, Jun 19, 2017 at 03:52:45PM +0300, Martin Storsjö wrote: > The rtmp protocol uses nonblocking reads, to poll for incoming > messages from the server while publishing a stream. Prior to > 94599a6de3822b13c94096d764868128f388ba28 and > d13b124eaf452b267480074b2e6946538ed03a6e, the tls

Re: [libav-devel] [PATCH 2/2] tls_gnutls: Readd support for nonblocking operation

2017-06-20 Thread Diego Biurrun
On Mon, Jun 19, 2017 at 03:52:46PM +0300, Martin Storsjö wrote: > The rtmp protocol uses nonblocking reads, to poll for incoming > messages from the server while publishing a stream. Prior to > 94599a6de3822b13c94096d764868128f388ba28 and > d13b124eaf452b267480074b2e6946538ed03a6e, the tls

Re: [libav-devel] build dependency resolution fixes

2017-06-17 Thread Diego Biurrun
On Tue, Jun 13, 2017 at 11:26:16AM +0200, Diego Biurrun wrote: > Here's a set of patches that address all (currently) known issues with > dependency resolution in the build system. I've tested it extensively > by a script that builds every single component in Libav standalone. > 7/7

Re: [libav-devel] [PATCH] hwcontext: Mark read-only table static

2017-06-14 Thread Diego Biurrun
On Tue, Jun 13, 2017 at 10:30:37PM +0100, Mark Thompson wrote: > --- > libavutil/hwcontext.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK > --- a/libavutil/hwcontext.c > +++ b/libavutil/hwcontext.c > @@ -50,7 +50,7 @@ static const HWContextType * const hw_table[] = { > > -const

Re: [libav-devel] [PATCH] d3d11va: Link directly to dxgi.dll and d3d11.dll functions if LoadLibrary is unavailable

2017-06-13 Thread Diego Biurrun
On Tue, Jun 13, 2017 at 02:55:34PM +0200, Diego Biurrun wrote: > On Tue, Jun 13, 2017 at 03:31:12PM +0300, Martin Storsjö wrote: > > --- a/configure > > +++ b/configure > > @@ -5159,6 +5159,10 @@ esac > > > > enabled asm || { arch=c; disable $ARCH_LIST $ARCH

Re: [libav-devel] [PATCH] d3d11va: Link directly to dxgi.dll and d3d11.dll functions if LoadLibrary is unavailable

2017-06-13 Thread Diego Biurrun
On Tue, Jun 13, 2017 at 03:31:12PM +0300, Martin Storsjö wrote: > When targeting the UWP API subset, the LoadLibrary function is not > available (and the fallback, LoadPackagedLibrary, can't be used to > load system DLLs). In these cases, link directly to the functions > in the DLLs instead of

[libav-devel] [PATCH] mmal: Add missing .item_name to AVClass declaration

2017-06-13 Thread Diego Biurrun
--- libavcodec/mmaldec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index e64ddba..023ebe8 100644 --- a/libavcodec/mmaldec.c +++ b/libavcodec/mmaldec.c @@ -817,6 +817,7 @@ static const AVOption options[]={ #define FFMMAL_DEC_CLASS(NAME) \

[libav-devel] [PATCH 7/7] configure: Fix handling of _select dependencies

2017-06-13 Thread Diego Biurrun
The handling of _select dependencies had two issues: 1) extralibs from _select dependencies of a component were not added to the list of extralibs for that component. 2) extralibs from dependencies were only added to the extralibs of a component if the component was enabled. This led to

[libav-devel] [PATCH 5/7] configure: Factorize qsv dependencies

2017-06-13 Thread Diego Biurrun
--- configure | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/configure b/configure index 9959280..39157b6 100755 --- a/configure +++ b/configure @@ -2253,6 +2253,7 @@ wmv3_vdpau_hwaccel_select="vc1_vdpau_hwaccel" nvenc_deps_any="libdl LoadLibrary" omx_deps="libdl

[libav-devel] [PATCH 6/7] build: Adjust dependencies for faan(i)dct components

2017-06-13 Thread Diego Biurrun
--- configure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 39157b6..4450ce4 100755 --- a/configure +++ b/configure @@ -1961,8 +1961,10 @@ threads_if_any="$THREADS_LIST" dct_select="rdft" dirac_parse_select="golomb"

[libav-devel] [PATCH 1/7] build: Add missing mpeg4audio dependency for RTP muxer

2017-06-13 Thread Diego Biurrun
--- libavcodec/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index a1bb4b5..240f7d8 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -669,6 +669,7 @@ OBJS-$(CONFIG_MATROSKA_AUDIO_MUXER)+= mpeg4audio.o

[libav-devel] [PATCH 3/7] configure: Add x86 dependency for mmx_internal

2017-06-13 Thread Diego Biurrun
This ensures that mmx_internal is only ever enabled on x86. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 50ae309..c99b397 100755 --- a/configure +++ b/configure @@ -1915,7 +1915,7 @@ fma4_deps="avx" avx2_deps="avx"

[libav-devel] [PATCH 2/7] build: Add missing idctdsp dependency for clearvideo

2017-06-13 Thread Diego Biurrun
--- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 7e38f0d..50ae309 100755 --- a/configure +++ b/configure @@ -1991,6 +1991,7 @@ bink_decoder_select="blockdsp hpeldsp" binkaudio_dct_decoder_select="mdct rdft dct sinewin wma_freqs"

[libav-devel] [PATCH 4/7] configure: Add missing arch dependencies for arch extensions

2017-06-13 Thread Diego Biurrun
--- configure | 12 1 file changed, 12 insertions(+) diff --git a/configure b/configure index c99b397..9959280 100755 --- a/configure +++ b/configure @@ -1889,10 +1889,22 @@ vfpv3_deps="vfp" map 'eval ${v}_inline_deps=inline_asm' $ARCH_EXT_LIST_ARM altivec_deps="ppc"

[libav-devel] build dependency resolution fixes

2017-06-13 Thread Diego Biurrun
Here's a set of patches that address all (currently) known issues with dependency resolution in the build system. I've tested it extensively by a script that builds every single component in Libav standalone. 7/7 is the core logic fix. Looks deceptively simple now in its 5th or 6th iteration ...

Re: [libav-devel] [PATCH 1/2] ppc: Drop support for Apple GCC

2017-06-13 Thread Diego Biurrun
On Mon, Jun 12, 2017 at 09:52:04PM +0200, Diego Biurrun wrote: > Apple GCC has not been a thing anymore on PowerPC since many years. > --- > configure| 10 +++--- > libavutil/ppc/util_altivec.h | 5 + > 2 files changed, 4 insertions(+), 11 deletion

Re: [libav-devel] [PATCH 2/2] log: const correctness for av_log()

2017-06-13 Thread Diego Biurrun
On Mon, Jun 12, 2017 at 04:06:40PM +0200, Hendrik Leppkes wrote: > On Mon, Jun 12, 2017 at 3:29 PM, Diego Biurrun <di...@biurrun.de> wrote: > > On Sun, Jun 11, 2017 at 11:49:45PM +0200, Hendrik Leppkes wrote: > >> On Sun, Jun 11, 2017 at 11:45 PM, Diego Biurrun

[libav-devel] [PATCH] af_bs2b: Add missing casts to complex pointer assignments

2017-06-12 Thread Diego Biurrun
Fixes several warnings of the type: libavfilter/af_bs2b.c:171:22: warning: assignment from incompatible pointer type --- libavfilter/af_bs2b.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/af_bs2b.c b/libavfilter/af_bs2b.c index 25e7867..0468333

Re: [libav-devel] [PATCH 2/2] configure: Simplify AltiVec/VSX check with a helper function

2017-06-12 Thread Diego Biurrun
On Mon, Jun 12, 2017 at 04:15:27PM -0400, Sean McGovern wrote: > On Jun 12, 2017 3:53 PM, "Diego Biurrun" <di...@biurrun.de> wrote: > --- a/configure > +++ b/configure > @@ -4458,29 +4458,19 @@ elif enabled ppc; then > # check if our compiler

[libav-devel] [PATCH] h264: Add missing casts to complex pointer assignments

2017-06-12 Thread Diego Biurrun
Fixes several warnings of the type: libavcodec/h264_direct.c:326:11: warning: assignment from incompatible pointer type --- libavcodec/h264_direct.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/h264_direct.c b/libavcodec/h264_direct.c index

[libav-devel] [PATCH 2/2] configure: Simplify AltiVec/VSX check with a helper function

2017-06-12 Thread Diego Biurrun
--- configure | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/configure b/configure index e8ecf30..46859b7 100755 --- a/configure +++ b/configure @@ -4458,29 +4458,19 @@ elif enabled ppc; then check_cflags -maltivec -mabi=altivec #

[libav-devel] [PATCH 1/2] ppc: Drop support for Apple GCC

2017-06-12 Thread Diego Biurrun
Apple GCC has not been a thing anymore on PowerPC since many years. --- configure| 10 +++--- libavutil/ppc/util_altivec.h | 5 + 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/configure b/configure index ed04952..e8ecf30 100755 --- a/configure +++

Re: [libav-devel] [PATCH 2/2] log: const correctness for av_log()

2017-06-12 Thread Diego Biurrun
On Sun, Jun 11, 2017 at 11:49:45PM +0200, Hendrik Leppkes wrote: > On Sun, Jun 11, 2017 at 11:45 PM, Diego Biurrun <di...@biurrun.de> wrote: > > On Sun, Jun 11, 2017 at 11:27:07PM +0200, Hendrik Leppkes wrote: > >> On Sun, Jun 11, 2017 at 11:22 PM, Diego Biurrun

Re: [libav-devel] [PATCH 2/8] dxva: fix some warnings

2017-06-12 Thread Diego Biurrun
On Mon, Jun 12, 2017 at 11:39:30AM +0200, wm4 wrote: > On Sat, 10 Jun 2017 23:44:32 +0200 > Hendrik Leppkes <h.lepp...@gmail.com> wrote: > > > On Sat, Jun 10, 2017 at 3:58 PM, Diego Biurrun <di...@biurrun.de> wrote: > > > On Fri, Jun 09, 2017 at 04:27:35PM

Re: [libav-devel] [PATCH 2/8] dxva: fix some warnings

2017-06-12 Thread Diego Biurrun
On Sat, Jun 10, 2017 at 11:44:32PM +0200, Hendrik Leppkes wrote: > On Sat, Jun 10, 2017 at 3:58 PM, Diego Biurrun <di...@biurrun.de> wrote: > > On Fri, Jun 09, 2017 at 04:27:35PM +0200, wm4 wrote: > >> The cast in get_surface() is silly, but unless we change the av_log

Re: [libav-devel] [PATCH 2/2] log: const correctness for av_log()

2017-06-11 Thread Diego Biurrun
On Sun, Jun 11, 2017 at 11:27:07PM +0200, Hendrik Leppkes wrote: > On Sun, Jun 11, 2017 at 11:22 PM, Diego Biurrun <di...@biurrun.de> wrote: > > On Sun, Jun 11, 2017 at 10:52:18AM +0200, Hendrik Leppkes wrote: > >> On Sat, Jun 10, 2017 at 4:47 PM, Diego Biurrun

Re: [libav-devel] [PATCH 2/2] log: const correctness for av_log()

2017-06-11 Thread Diego Biurrun
On Sun, Jun 11, 2017 at 10:52:18AM +0200, Hendrik Leppkes wrote: > On Sat, Jun 10, 2017 at 4:47 PM, Diego Biurrun <di...@biurrun.de> wrote: > > @@ -222,7 +222,7 @@ void av_log_set_level(int level); > > * @param callback A logging function with a compatible signatur

Re: [libav-devel] [PATCH 1/2] Convert all AVClass struct declarations to designated initializers.

2017-06-11 Thread Diego Biurrun
On Sat, Jun 10, 2017 at 11:36:17PM -0400, Vittorio Giovara wrote: > On Sat, Jun 10, 2017 at 10:47 AM, Diego Biurrun <di...@biurrun.de> wrote: > > --- > > libavcodec/aacenc.c | 8 > > libavcodec/ac3enc_fixed.c | 9 +++-- > >

[libav-devel] [PATCH 2/2] log: const correctness for av_log()

2017-06-10 Thread Diego Biurrun
--- avtools/cmdutils.c | 2 +- avtools/cmdutils.h | 2 +- libavcodec/options.c | 5 +++-- libavfilter/avfilter.c | 4 ++-- libavfilter/vf_delogo.c| 2 +- libavfilter/vf_drawtext.c | 2 +- libavfilter/vsrc_movie.c | 2 +- libavfilter/vsrc_testsrc.c | 4 ++--

[libav-devel] [PATCH 1/2] Convert all AVClass struct declarations to designated initializers.

2017-06-10 Thread Diego Biurrun
--- libavcodec/aacenc.c | 8 libavcodec/ac3enc_fixed.c | 9 +++-- libavcodec/ac3enc_float.c | 9 +++-- libavcodec/dnxhdenc.c | 8 libavcodec/eac3enc.c| 9 +++-- libavcodec/flacenc.c| 8 libavcodec/libfdk-aacdec.c | 5 -

Re: [libav-devel] [PATCH 2/8] dxva: fix some warnings

2017-06-10 Thread Diego Biurrun
On Fri, Jun 09, 2017 at 04:27:35PM +0200, wm4 wrote: > The cast in get_surface() is silly, but unless we change the av_log > function signature, or all callers of ff_dxva2_get_surface_index(), it's > needed to remove the const warning. Constifying av_log() seems like the correct solution. > ---

[libav-devel] [PATCH] lavu: add new D3D11 pixfmt and hwcontext

2017-06-07 Thread Diego Biurrun
From: wm4 To be used with the new d3d11 hwaccel decode API. With the new hwaccel API, we don't want surfaces to depend on the decoder (other than the required dimension and format). The old D3D11VA pixfmt uses ID3D11VideoDecoderOutputView pointers, which include the

[libav-devel] [PATCH 5/5] dxva: add support for new dxva2 and d3d11 hwaccel APIs

2017-06-07 Thread Diego Biurrun
This also adds support to avconv (which is trivial due to the new hwaccel API being generic enough). The new decoder setup code in dxva2.c is significantly based on work by Steve Lhomme , but with heavy changes/rewrites. --- Changelog | 1 + avtools/Makefile

[libav-devel] [PATCH 2/5] lavc: set avctx->hwaccel before init

2017-06-07 Thread Diego Biurrun
From: wm4 So a hwaccel can access avctx->hwaccel in init for whatever reason. This is for the new d3d hwaccel API. We could create separate entrypoints for each of the 3 hwaccel types (dxva2, d3d11va, new d3d11va), but this seems nicer. --- libavcodec/decode.c | 4 ++-- 1

[libav-devel] [PATCH 1/5] lavu: add new D3D11 pixfmt and hwcontext

2017-06-07 Thread Diego Biurrun
From: wm4 To be used with the new d3d11 hwaccel decode API. With the new hwaccel API, we don't want surfaces to depend on the decoder (other than the required dimension and format). The old D3D11VA pixfmt uses ID3D11VideoDecoderOutputView pointers, which include the

[libav-devel] [PATCH 4/5] dxva: move d3d11 locking/unlocking to functions

2017-06-07 Thread Diego Biurrun
From: wm4 I want to make it non-mandatory to set a mutex in the D3D11 device context, and replacing it with user callbacks seems like the best solution. This is preparation for it. Also makes the code slightly more readable. --- libavcodec/dxva2.c | 46

[libav-devel] [PATCH 3/5] dxva: preparations for new hwaccel API

2017-06-07 Thread Diego Biurrun
From: wm4 The actual hwaccel code will need to access an internal context instead of avctx->hwaccel_context, so add a new DXVA_CONTEXT() macro, that will dispatch between the "old" external and the new internal context. Also, the new API requires a new D3D11 pixfmt, so

[libav-devel] [v4] New D3D hwaccel API stuff

2017-06-07 Thread Diego Biurrun
The last set from wm4 with some, mostly small, changes. The build system are slightly modified and shifted to the right patch in the set, 5/6 and 6/6 from the previous set are squashed together. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH v3 5/6] dxva: add support for new dxva2 and d3d11 hwaccel APIs

2017-06-07 Thread Diego Biurrun
On Wed, Jun 07, 2017 at 04:50:43PM +0200, wm4 wrote: > On Wed, 7 Jun 2017 16:41:21 +0200 Diego Biurrun <di...@biurrun.de> wrote: > > > On Tue, Jun 06, 2017 at 06:51:11PM +0200, wm4 wrote: > > > --- a/configure > > > +++ b/configure > > > @@ -4673,6 +46

Re: [libav-devel] [PATCH v3 5/6] dxva: add support for new dxva2 and d3d11 hwaccel APIs

2017-06-07 Thread Diego Biurrun
On Tue, Jun 06, 2017 at 06:51:11PM +0200, wm4 wrote: > --- a/configure > +++ b/configure > @@ -4673,6 +4682,7 @@ check_builtin stdatomic_h stdatomic.h "atomic_int foo; > atomic_store(, 0)" > check_lib shell32 "windows.h shellapi.h" CommandLineToArgvW -lshell32 > check_lib wincrypt "windows.h

Re: [libav-devel] [PATCH v3 1/6] lavu: add new D3D11 pixfmt and hwcontext

2017-06-07 Thread Diego Biurrun
On Wed, Jun 07, 2017 at 01:52:58PM +0200, Hendrik Leppkes wrote: > On Wed, Jun 7, 2017 at 1:28 PM, Diego Biurrun <di...@biurrun.de> wrote: > > On Wed, Jun 07, 2017 at 01:18:19PM +0200, wm4 wrote: > >> On Wed, 7 Jun 2017 13:09:15 +0200 Diego Biurrun <di...@biurrun.de>

Re: [libav-devel] [PATCH v3 1/6] lavu: add new D3D11 pixfmt and hwcontext

2017-06-07 Thread Diego Biurrun
On Wed, Jun 07, 2017 at 01:18:19PM +0200, wm4 wrote: > On Wed, 7 Jun 2017 13:09:15 +0200 > Diego Biurrun <di...@biurrun.de> wrote: > > > On Tue, Jun 06, 2017 at 06:51:07PM +0200, wm4 wrote: > > > --- a/configure > > > +++ b/configure > > &g

Re: [libav-devel] [PATCH v3 6/6] avconv: remove old avconv_dxva2

2017-06-07 Thread Diego Biurrun
On Tue, Jun 06, 2017 at 06:51:12PM +0200, wm4 wrote: > This is done by the generic code now. It was not removed earlier to > reduce the diff in the commit adding the new code. IMO this should be squashed, at least on commit. Diego ___ libav-devel

Re: [libav-devel] [PATCH v3 3/6] dxva: preparations for new hwaccel API

2017-06-07 Thread Diego Biurrun
On Tue, Jun 06, 2017 at 06:51:09PM +0200, wm4 wrote: > --- a/libavcodec/dxva2.c > +++ b/libavcodec/dxva2.c > @@ -301,3 +301,12 @@ end: > + > +int ff_dxva2_is_d3d11(const AVCodecContext *avctx) > +{ > +#if CONFIG_D3D11VA > +return avctx->pix_fmt == AV_PIX_FMT_D3D11VA_VLD; > +#else > +return

Re: [libav-devel] [PATCH v3 1/6] lavu: add new D3D11 pixfmt and hwcontext

2017-06-07 Thread Diego Biurrun
On Wed, Jun 07, 2017 at 01:09:15PM +0200, Diego Biurrun wrote: > On Tue, Jun 06, 2017 at 06:51:07PM +0200, wm4 wrote: > > --- a/configure > > +++ b/configure > > @@ -4877,6 +4877,10 @@ if enabled libxcb; then > > check_pkg_config libxcb_xfi

Re: [libav-devel] [PATCH v3 1/6] lavu: add new D3D11 pixfmt and hwcontext

2017-06-07 Thread Diego Biurrun
On Tue, Jun 06, 2017 at 06:51:07PM +0200, wm4 wrote: > --- a/configure > +++ b/configure > @@ -2166,7 +2166,7 @@ zmbv_encoder_deps="zlib" > > # hardware accelerators > d3d11va_deps="d3d11_h dxva_h ID3D11VideoDecoder" > -dxva2_deps="dxva2api_h DXVA2_ConfigPictureDecode" >

Re: [libav-devel] [PATCH 2/2] configure: Fix handling of _select dependencies

2017-06-06 Thread Diego Biurrun
On Fri, May 26, 2017 at 01:50:12PM +0200, Diego Biurrun wrote: > The handling of _select dependencies had two issues: > > 1) extralibs from _select dependencies of a component were not added to >the list of extralibs for that component. > 2) Previously, _select components wer

Re: [libav-devel] [PATCH] libfdk-aacdec: Correct buffer_size parameter

2017-06-06 Thread Diego Biurrun
On Tue, Jun 06, 2017 at 01:33:31PM +0300, Martin Storsjö wrote: > From: Michael Niedermayer > > The timeDataSize argument to aacDecoder_DecodeFrame() seems undocumented > and until 2016 04 (203e3f28fbebec7011342017fafc2a0bda0ce530) unused. > After that commit

Re: [libav-devel] [PATCH 2/2] configure: Fix handling of _select dependencies

2017-06-04 Thread Diego Biurrun
On Fri, May 26, 2017 at 01:50:12PM +0200, Diego Biurrun wrote: > The handling of _select dependencies had two issues: > > 1) extralibs from _select dependencies of a component were not added to >the list of extralibs for that component. > 2) Previously, _select components wer

Re: [libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

2017-06-04 Thread Diego Biurrun
On Fri, May 26, 2017 at 01:50:11PM +0200, Diego Biurrun wrote: > Both libraries provide similar functionality and cannot be used together. > When both are enabled one is used and the other ignored arbitrarily. Error > out instead and have the user choose which library to use. > ---

Re: [libav-devel] [PATCH] tls: Hide backend implementation details from users

2017-06-02 Thread Diego Biurrun
On Fri, Jun 02, 2017 at 12:12:05PM +0300, Martin Storsjö wrote: > On Fri, 2 Jun 2017, wm4 wrote: > > >On Fri, 2 Jun 2017 10:43:58 +0200 > >Diego Biurrun <di...@biurrun.de> wrote: > > > >>TLS is currently implemented over either OpenSSL or GnuTLS,

[libav-devel] [PATCH] tls: Hide backend implementation details from users

2017-06-02 Thread Diego Biurrun
TLS is currently implemented over either OpenSSL or GnuTLS, with more backends likely to appear in the future. Currently, those backend libraries are part of the protocol names used during e.g. the configure stage of a build. Hide those details behind a generically-named declaration for the TLS

Re: [libav-devel] [PATCH v2] avutil/md5: fix misaligned reads

2017-06-02 Thread Diego Biurrun
On Thu, Jun 01, 2017 at 07:36:48PM -0400, Sean McGovern wrote: > --- a/libavutil/md5.c > +++ b/libavutil/md5.c > @@ -99,18 +99,14 @@ static const uint32_t T[64] = { // T[i]= > fabs(sin(i+1)<<32) > static void body(uint32_t ABCD[4], uint32_t X[16]) > { > int t; > -int i av_unused; >

[libav-devel] [PATCH] build: Skip generating .version files when reconfiguring

2017-06-01 Thread Diego Biurrun
The .version files are only relevant during an actual build. --- Amended the log message according to Anton's request. avbuild/library.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avbuild/library.mak b/avbuild/library.mak index 227e4d5..2095f61 100644 ---

Re: [libav-devel] [PATCH] avutil/md5: fix misaligned reads

2017-06-01 Thread Diego Biurrun
On Wed, May 31, 2017 at 08:16:28PM -0400, Sean McGovern wrote: > --- a/libavutil/md5.c > +++ b/libavutil/md5.c > @@ -105,11 +105,6 @@ static void body(uint32_t ABCD[4], uint32_t X[16]) > unsigned int c = ABCD[1]; > unsigned int d = ABCD[0]; > > -#if HAVE_BIGENDIAN > -for (i = 0; i

[libav-devel] [PATCH] [RFC] [v4] tls: Hide backend implementation details from users

2017-05-31 Thread Diego Biurrun
TLS is currently implemented over either OpenSSL or GnuTLS, with more backends likely to appear in the future. Currently, those backend libraries are part of the protocol names used during e.g. the configure stage of a build. Hide those details behind a generically-named declaration for the TLS

Re: [libav-devel] [PATCH 2/2] os_support: Remove the dynamic loading of getaddrinfo from the fallback getaddrinfo

2017-05-31 Thread Diego Biurrun
On Wed, May 31, 2017 at 01:21:43PM +0300, Martin Storsjö wrote: > If we for some unexplicable reason didn't pick up getaddrinfo > at configure, the default, IPv4-only, fallback should be good enough. > > This effectively reverts 6023d84a2b7. > --- > libavformat/os_support.c | 31

Re: [libav-devel] [PATCH 1/2] configure: Default to _WIN32_WINNT=0x0501 as minimum, for legacy mingw

2017-05-31 Thread Diego Biurrun
On Wed, May 31, 2017 at 01:21:42PM +0300, Martin Storsjö wrote: > This makes the getaddrinfo functions visible, which aren't normally > by default on legacy mingw. > > We already force __MSVCRT_VERSION__ to an XP version. > --- > configure | 2 ++ > 1 file changed, 2 insertions(+) probably OK

Re: [libav-devel] [PATCH] configure: Fix the msvcrt version check for mingw

2017-05-31 Thread Diego Biurrun
On Wed, May 31, 2017 at 12:56:24PM +0300, Martin Storsjö wrote: > This was actually broken when committed in 46e3936fb04; the > test never succeeded, and thus, _aligned_malloc wasn't actually > used on legacy mingw. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Doh

[libav-devel] [PATCH] [RFC] [v3] tls: Hide backend implementation details from users

2017-05-31 Thread Diego Biurrun
TLS is currently implemented over either OpenSSL or GnuTLS, with more backends likely to appear in the future. Currently, those backend libraries are part of the protocol names used during e.g. the configure stage of a build. Hide those details behind a generically-named declaration for the TLS

[libav-devel] [PATCH] smacker: Check that the data size is a multiple of a sample vector

2017-05-31 Thread Diego Biurrun
Coldwind Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> (cherry picked from commit 4a9af07a49295e014b059c1ab624c40345af5892) Signed-off-by: Diego Biurrun <di...@biurrun.de> --- Fixed error message wording and error check placement. libavcodec/smacker.c | 5 + 1 file ch

[libav-devel] [PATCH 2/2] smacker: Improve error handling

2017-05-30 Thread Diego Biurrun
Return sensible error values and forward error codes. --- libavcodec/smacker.c | 47 --- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c index 4111c3b..c71ced9 100644 --- a/libavcodec/smacker.c

[libav-devel] [PATCH 1/2] smacker: Check that the data size is a multiple of a sample vector

2017-05-30 Thread Diego Biurrun
Coldwind Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> (cherry picked from commit 4a9af07a49295e014b059c1ab624c40345af5892) Signed-off-by: Diego Biurrun <di...@biurrun.de> --- libavcodec/smacker.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/smacker.c

Re: [libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
On Mon, May 29, 2017 at 09:46:08PM +0300, Martin Storsjö wrote: > On Mon, 29 May 2017, Diego Biurrun wrote: > >On Mon, May 29, 2017 at 12:44:21PM +0200, wm4 wrote: > >>On Mon, 29 May 2017 12:39:12 +0200 > >>Diego Biurrun <di...@biurrun.de> wrote: > >>>

Re: [libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
On Mon, May 29, 2017 at 12:44:21PM +0200, wm4 wrote: > On Mon, 29 May 2017 12:39:12 +0200 > Diego Biurrun <di...@biurrun.de> wrote: > > On Mon, May 29, 2017 at 12:18:22PM +0200, wm4 wrote: > > > On Mon, 29 May 2017 12:03:26 +0200 > > > Diego Biurrun <di...@b

Re: [libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
On Mon, May 29, 2017 at 12:18:22PM +0200, wm4 wrote: > On Mon, 29 May 2017 12:03:26 +0200 > Diego Biurrun <di...@biurrun.de> wrote: > > On Mon, May 29, 2017 at 11:32:49AM +0200, wm4 wrote: > > > On Mon, 29 May 2017 10:56:36 +0200 > > > Di

[libav-devel] [PATCH] cmdutils: Mark conditionally used variable as av_unused

2017-05-29 Thread Diego Biurrun
Fixes the following warning with swscale disabled: avtools/cmdutils.c:1234:28: warning: unused variable ‘pix_fmt’ [-Wunused-variable] --- avtools/cmdutils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/avtools/cmdutils.c b/avtools/cmdutils.c index b0445eb..727e283 100644

Re: [libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
*PLEASE* do not bottom-post. On Mon, May 29, 2017 at 11:32:49AM +0200, wm4 wrote: > On Mon, 29 May 2017 10:56:36 +0200 > Diego Biurrun <di...@biurrun.de> wrote: > > --- > > > > Log message still not perfect. > > > > No longer tries to ded

[libav-devel] [PATCH] [RFC] [v2] tls: Hide backend implementation details from users

2017-05-29 Thread Diego Biurrun
TLS is currently implemented over either OpenSSL or GnuTLS, with more backends likely to appear in the future. Currently, those backend libraries are part of the protocol names used during e.g. the configure stage of a build. Hide those details behind a generically-named declaration for the TLS

Re: [libav-devel] [PATCH] [RFC] Disentangle TLS protocol

2017-05-26 Thread Diego Biurrun
On Fri, May 26, 2017 at 03:12:43PM +0300, Martin Storsjö wrote: > On Fri, 26 May 2017, Diego Biurrun wrote: > >--- > >TLS is not handled like other protocols. Instead the implementation details > >of which crypto library is used get exposed to the user. Hiding those > >

Re: [libav-devel] [PATCH] configure: Do not check for the __builtin_vec_vsx_ld

2017-05-26 Thread Diego Biurrun
On Wed, May 10, 2017 at 05:20:29PM +0200, Luca Barbato wrote: > --- a/configure > +++ b/configure > @@ -4452,7 +4452,14 @@ EOF > > if enabled vsx; then > check_cflags -mvsx && > -check_builtin vec_vsx_ld "altivec.h" "__builtin_vec_vsx_ld" || > disable vsx > +

Re: [libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

2017-05-26 Thread Diego Biurrun
On Fri, May 26, 2017 at 02:06:02PM +0200, Luca Barbato wrote: > On 5/26/17 1:50 PM, Diego Biurrun wrote: > > Both libraries provide similar functionality and cannot be used together. > > When both are enabled one is used and the other ignored arbitrarily. Error > > out inst

Re: [libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

2017-05-26 Thread Diego Biurrun
On Fri, May 26, 2017 at 02:06:04PM +0200, wm4 wrote: > On Fri, 26 May 2017 13:50:11 +0200 > Diego Biurrun <di...@biurrun.de> wrote: > > Both libraries provide similar functionality and cannot be used together. > > When both are enabled one is used and the other ignored ar

[libav-devel] [PATCH] [RFC] Disentangle TLS protocol

2017-05-26 Thread Diego Biurrun
--- TLS is not handled like other protocols. Instead the implementation details of which crypto library is used get exposed to the user. Hiding those details allows simplifying and refactoring some code and avoiding the special-casing of TLS. This should get a slightly more elaborate log message

[libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

2017-05-26 Thread Diego Biurrun
Both libraries provide similar functionality and cannot be used together. When both are enabled one is used and the other ignored arbitrarily. Error out instead and have the user choose which library to use. --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure

[libav-devel] [PATCH 2/2] configure: Fix handling of _select dependencies

2017-05-26 Thread Diego Biurrun
The handling of _select dependencies had two issues: 1) extralibs from _select dependencies of a component were not added to the list of extralibs for that component. 2) Previously, _select components were enabled after checking dependencies for that component. However, extralibs for each

Re: [libav-devel] [PATCH 001/200] Add a new channel layout API

2017-05-24 Thread Diego Biurrun
On Mon, May 22, 2017 at 04:08:53PM -0400, Vittorio Giovara wrote: > On Sat, May 20, 2017 at 7:18 AM, wm4 wrote: > > On Fri, 19 May 2017 11:25:59 -0400 > > Vittorio Giovara wrote: > > > >> >> > Also, why is this only 1 byte per channel? Seems a

[libav-devel] [PATCH 2/3] build: Add missing zlib dependencies for several protocols

2017-05-22 Thread Diego Biurrun
--- configure | 9 + 1 file changed, 9 insertions(+) diff --git a/configure b/configure index d6c44cf..0704a05 100755 --- a/configure +++ b/configure @@ -2445,8 +2445,11 @@ ffrtmphttp_protocol_conflict="librtmp_protocol" ffrtmphttp_protocol_select="http_protocol"

[libav-devel] [PATCH 3/3] configure: Move x86 assembler sanity check into assembler probe function

2017-05-22 Thread Diego Biurrun
This allows for more graceful fallback from NASM to Yasm if the available NASM version is too old. --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0704a05..32f8dbf 100755 --- a/configure +++ b/configure @@ -4504,13 +4504,15 @@

Re: [libav-devel] [PATCH 2/4] h264_sei: parse the picture timing SEIs correctly

2017-05-19 Thread Diego Biurrun
On Fri, May 19, 2017 at 11:13:26AM -0300, James Almer wrote: > On 5/19/2017 10:47 AM, Anton Khirnov wrote: > > --- a/libavcodec/h264_sei.c > > +++ b/libavcodec/h264_sei.c > > @@ -54,21 +55,22 @@ void ff_h264_sei_uninit(H264SEIContext *h) > > > > -static int

Re: [libav-devel] [PATCH] h264_refs: validate the SPS pointer in ff_h264_execute_ref_pic_marking()

2017-05-09 Thread Diego Biurrun
On Sun, May 07, 2017 at 06:22:47PM -0400, Sean McGovern wrote: > --- a/libavcodec/h264_refs.c > +++ b/libavcodec/h264_refs.c > @@ -557,6 +557,12 @@ int ff_h264_execute_ref_pic_marking(H264Context *h) > int current_ref_assigned = 0, err = 0; > H264Picture *av_uninit(pic); > > +

Re: [libav-devel] [PATCH 196/200] aac: Allow pass-through transcoding of ambisonic audio

2017-05-09 Thread Diego Biurrun
On Mon, May 08, 2017 at 12:28:47PM -0400, Vittorio Giovara wrote: > --- a/libavcodec/libfdk-aacenc.c > +++ b/libavcodec/libfdk-aacenc.c > @@ -418,6 +425,11 @@ static const AVChannelLayout aac_ch_layouts[16] = { > AV_CHANNEL_LAYOUT_7POINT1, > #endif > +{ > +.order =

Re: [libav-devel] [PATCH] arm: Avoid using .dn register aliases

2017-05-09 Thread Diego Biurrun
On Tue, May 09, 2017 at 10:41:18AM +0300, Martin Storsjö wrote: > clang now (in the upcoming 5.0 version) is capable of building our > arm assembly without relying on gas-preprocessor. The VC1 MC assembly > was only built and used if the chosen assembler supported the .dn > directives though. This

Re: [libav-devel] [PATCH 5/5] dxva: add support for new dxva2 and d3d11 hwaccel APIs

2017-05-05 Thread Diego Biurrun
On Fri, May 05, 2017 at 02:13:01PM +0200, wm4 wrote: > On Fri, 5 May 2017 14:00:34 +0200 Diego Biurrun <di...@biurrun.de> wrote: > > On Thu, May 04, 2017 at 08:44:08AM +0200, wm4 wrote: > > > --- a/configure > > > +++ b/configure > > > @@

Re: [libav-devel] [PATCH 5/5] dxva: add support for new dxva2 and d3d11 hwaccel APIs

2017-05-05 Thread Diego Biurrun
On Thu, May 04, 2017 at 08:44:08AM +0200, wm4 wrote: > --- a/configure > +++ b/configure > @@ -2168,7 +2168,7 @@ zmbv_encoder_deps="zlib" > # hardware accelerators > d3d11va_deps="d3d11_h dxva_h ID3D11VideoDecoder" > d3d11va_lib_deps="d3d11va" > -dxva2_deps="dxva2api_h

Re: [libav-devel] [PATCH 1/5] lavu: add new D3D11 pixfmt and hwcontext

2017-05-05 Thread Diego Biurrun
On Thu, May 04, 2017 at 08:44:04AM +0200, wm4 wrote: > --- a/configure > +++ b/configure > @@ -1712,6 +1712,7 @@ HAVE_LIST=" > $THREADS_LIST > $TOOLCHAIN_FEATURES > $TYPES_LIST > +d3d11va_lib > dos_paths > dxva2_lib > libc_msvcrt > @@ -2166,6 +2167,7 @@

Re: [libav-devel] [PATCH] configure: rename hevc_ps to hevcparse

2017-05-03 Thread Diego Biurrun
On Tue, May 02, 2017 at 06:06:52PM -0300, James Almer wrote: > Build h2645_parse.o with it, as every hevc_ps dependency also needs it. > This is more in line with h264's h264parse module. > > Signed-off-by: James Almer > --- > configure | 10 +- >

Re: [libav-devel] [PATCH] aac: turn off SBR after an overread occurs

2017-05-02 Thread Diego Biurrun
On Tue, May 02, 2017 at 05:52:36PM -0400, Sean McGovern wrote: > On May 2, 2017 17:35, "Hendrik Leppkes" wrote: > On Tue, May 2, 2017 at 11:25 PM, Sean McGovern wrote: > > I'm not super happy with my patch subject though. Anyone have a better > >

[libav-devel] [PATCH] aac: Split function to parse ADTS header data into public and private part

2017-05-02 Thread Diego Biurrun
This makes the currently semi-public avpriv_aac_parse_header() function private to libavcodec and adds a proper public API function to return the parts of the ADTS header required in libavformat. --- Added AV_-prefix to AAC_ADTS_HEADER_SIZE constant since it now lives in an installed header

Re: [libav-devel] [PATCH] mpeg4audio: make avpriv_copy_pce_data() inline

2017-04-27 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 09:55:26PM +0200, Diego Biurrun wrote: > --- a/libavcodec/mpeg4audio.c > +++ b/libavcodec/mpeg4audio.c > @@ -145,43 +145,3 @@ int avpriv_mpeg4audio_get_config(MPEG4AudioConfig *c, > const uint8_t *buf, > -static av_always_inline unsigned int copy_bits(Pu

[libav-devel] [PATCH] aac: Split function to parse ADTS header data into public and private part

2017-04-27 Thread Diego Biurrun
This makes the currently semi-public avpriv_aac_parse_header() function private to libavcodec and adds a proper public API function to return the parts of the ADTS header required in libavformat. --- Renamed stuff from aacadts_ to adts_, partly according to James' suggestion. configure

Re: [libav-devel] [PATCH] ac3enc: Drop unneeded extern qualifier

2017-04-27 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 06:24:08PM -0400, Vittorio Giovara wrote: > libavcodec/ac3enc.c:103:30: warning: 'extern' variable > has an initializer [-Wextern-initializer] > --- > libavcodec/ac3enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK Diego

[libav-devel] [PATCH] mpeg4audio: make avpriv_copy_pce_data() inline

2017-04-26 Thread Diego Biurrun
untime dependency completely. Signed-off-by: Diego Biurrun <di...@biurrun.de> --- - Dropped a stray comment line. - avpriv_ -> ff_ libavcodec/aac_adtstoasc_bsf.c | 2 +- libavcodec/mpeg4audio.c| 40 libavcodec/mpeg4audi

Re: [libav-devel] [PATCH 2/3] vp9_superframe_bsf: convert to the new bitstream reader

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 09:35:00PM +0200, Luca Barbato wrote: > On 4/26/17 8:36 PM, Diego Biurrun wrote: > > On Wed, Apr 26, 2017 at 12:35:17PM +0200, Diego Biurrun wrote: > >> On Wed, Apr 26, 2017 at 11:41:49AM +0200, Anton Khirnov wrote: > >>> @@

<    1   2   3   4   5   6   7   8   9   10   >