[Libreoffice-bugs] [Bug 53501] Wrong line spacing when mixing large fonts with small ones near a box
https://bugs.documentfoundation.org/show_bug.cgi?id=53501 --- Comment #6 from Ingo Ruhnke--- Bug is still present in 5.1.4.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102305] Rotation of AutoLayout textboxes not applied
https://bugs.documentfoundation.org/show_bug.cgi?id=102305 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Aron Budea --- Confirmed with v5.2.1.2 / Windows 7. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102343] Unable to undo text formatting in textbox edit mode
https://bugs.documentfoundation.org/show_bug.cgi?id=102343 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@caesar.elte.hu Version|4.2.8.2 release |4.2.0.4 release Ever confirmed|0 |1 --- Comment #1 from Aron Budea --- Reproduced with as early as 4.2.0.4 / Windows 7. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102282] Crash at start
https://bugs.documentfoundation.org/show_bug.cgi?id=102282 Julien Nabetchanged: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WORKSFORME |--- --- Comment #8 from Julien Nabet --- Ok let's put this one to UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102282] Crash at start
https://bugs.documentfoundation.org/show_bug.cgi?id=102282 --- Comment #7 from Julien Nabet--- Comment on attachment 127566 --> https://bugs.documentfoundation.org/attachment.cgi?id=127566 log file No stack here too -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102282] Crash at start
https://bugs.documentfoundation.org/show_bug.cgi?id=102282 Julien Nabetchanged: What|Removed |Added Attachment #127565|0 |1 is obsolete|| --- Comment #6 from Julien Nabet --- Comment on attachment 127565 --> https://bugs.documentfoundation.org/attachment.cgi?id=127565 log file No stack here -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101898] Saving a presentation on Ubuntu 16.04 hangs (regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=101898 --- Comment #25 from Ofir--- Two more reports of the same issue: https://ask.libreoffice.org/en/question/71554/when-i-save-odp-file-as-pptx-libreoffice-freeze/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101898] Saving a presentation on Ubuntu 16.04 hangs (regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=101898 --- Comment #24 from Ofir--- I have this issue with a daily build of Ubuntu 16.10 installed as a VirtualBox guest. It has LibreOffice 5.2.1-rc2 installed by default. I didn't install or change anything. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101898] Saving a presentation on Ubuntu 16.04 hangs (regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=101898 --- Comment #23 from E. Wayne Johnson--- My first encounter with the Save odp in Impress bug was when I upgraded my slackware64 to the latest version of current which included a kernel upgrade to 4.4.20. 5.3.x dev version was already on that machine and started to blow up immediately after the upgrade. I had a 4.4.19 on a different partition and it worked fine with all 5.2 and 5.3 LO that I tried. I couldnt go back to 5.1.x easily on the machine with the 4.4.20 kernel because too many deps were upgraded. Reinstalling LO on a completely clean Slackware64 -current 4.4.20 kernel version failed to clear up the problem. After that Cor stated it looked like an Ubuntu ppa problem to him (and I imagined it would be a Slackware problem next), I ablated the 4.19 Slackware partition and installed Arch Linux with the latest cutting edge everything and the 4.7.4 kernel. In LO 5.2.1.2 there is the error. It is absent from 5.1.5. Yes I am motivated to try to slice the 5.2's until i find the version where the change occured. I am not running any special software like SharePoint or any other CMIS. On Archlinux I only installed Fluxbox and KDE Plasma and SDDM (display manager tool) and then LO-fresh which Archlinux pacman installed with its deps. When LO-fresh showed the bug, I removed it and installed LO-stll 5.1.5 which seems ok. I'll try to install an early 5.2 to see if the problem persists and read the bibisection procedure. Thanks for your continued interest. Meanwhile I am trying to roll back to 5.1.5 on my Slackware64-current. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 53 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 53 defect(s) ** CID 1373353: Uninitialized members (UNINIT_CTOR) /sc/qa/unit/tiledrendering/tiledrendering.cxx: 392 in ::ViewCallback::ViewCallback()() *** CID 1373353: Uninitialized members (UNINIT_CTOR) /sc/qa/unit/tiledrendering/tiledrendering.cxx: 392 in ::ViewCallback::ViewCallback()() 386 ViewCallback() 387 : m_bOwnCursorInvalidated(false), 388 m_bViewCursorInvalidated(false), 389 m_bTextViewSelectionInvalidated(false), 390 m_bViewLock(false) 391 { >>> CID 1373353: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_bGraphicViewSelection" is not initialized in >>> this constructor nor in any functions that it calls. 392 } 393 394 static void callback(int nType, const char* pPayload, void* pData) 395 { 396 static_cast(pData)->callbackImpl(nType, pPayload); 397 } ** CID 1373352: Uninitialized members (UNINIT_CTOR) /filter/source/msfilter/svdfppt.cxx: 4363 in PPTStyleSheet::PPTStyleSheet(const DffRecordHeader &, SvStream &, SdrPowerPointImport &, const PPTTextParagraphStyleAtomInterpreter &, const PPTTextSpecInfo &)() *** CID 1373352: Uninitialized members (UNINIT_CTOR) /filter/source/msfilter/svdfppt.cxx: 4363 in PPTStyleSheet::PPTStyleSheet(const DffRecordHeader &, SvStream &, SdrPowerPointImport &, const PPTTextParagraphStyleAtomInterpreter &, const PPTTextSpecInfo &)() 4357 if ( eNumRuleType == SvxNumRuleType::PRESENTATION_NUMBERING ) 4358 aRule.SetLevel( 0, aNumberFormat ); 4359 } 4360 } 4361 mpNumBulletItem[ i ] = new SvxNumBulletItem( aRule, EE_PARA_NUMBULLET ); 4362 } >>> CID 1373352: Uninitialized members (UNINIT_CTOR) >>> Non-static class member field "mpNumBulletItem.detail_values" is not >>> initialized in this constructor nor in any functions that it calls. 4363 } 4364 4365 PPTStyleSheet::~PPTStyleSheet() 4366 { 4367 for ( auto i : o3tl::enumrange() ) 4368 { ** CID 1373351: Null pointer dereferences (FORWARD_NULL) /sw/source/core/frmedt/fetab.cxx: 703 in SwFEShell::SetTabRows(const SwTabCols &, bool)() *** CID 1373351: Null pointer dereferences (FORWARD_NULL) /sw/source/core/frmedt/fetab.cxx: 703 in SwFEShell::SetTabRows(const SwTabCols &, bool)() 697 SET_CURR_SHELL( this ); 698 StartAllAction(); 699 700 do 701 { 702 pBox = pBox->GetUpper(); >>> CID 1373351: Null pointer dereferences (FORWARD_NULL) >>> Comparing "pBox" to null implies that "pBox" might be null. 703 } while (pBox && !pBox->IsCellFrame()); 704 705 GetDoc()->SetTabRows( rNew, bCurColOnly, static_cast (pBox) ); 706 EndAllActionAndCall(); 707 } 708 ** CID 1371313: Low impact quality (MISSING_MOVE_ASSIGNMENT) /include/unotools/confignode.hxx: 46 in () *** CID 1371313: Low impact quality (MISSING_MOVE_ASSIGNMENT) /include/unotools/confignode.hxx: 46 in () 40 41 class OConfigurationTreeRoot; 42 /** a small wrapper around a configuration node. 43 Nodes in the terminology used herein are inner nodes of a configuration 44 tree, which means no leafs. 45 */ >>> CID 1371313: Low impact quality (MISSING_MOVE_ASSIGNMENT) >>> Class "utl::OConfigurationNode" may benefit from adding a move >>> assignment operator. See other events which show the copy assignment >>> operator being applied to rvalue(s), where a move assignment may be faster. 46 class UNOTOOLS_DLLPUBLIC OConfigurationNode : public ::utl::OEventListenerAdapter 47 { 48 private: 49 css::uno::Reference< css::container::XHierarchicalNameAccess > 50 m_xHierarchyAccess; /// accessing children grandchildren (mandatory interface of our UNO object) 51 css::uno::Reference< css::container::XNameAccess > ** CID 1371312: Low impact quality (MISSING_MOVE_ASSIGNMENT) /include/svtools/transfer.hxx: 266 in () *** CID 1371312: Low impact quality
[Libreoffice-bugs] [Bug 73797] Allow rotation of images in Writer by any angle / degree ( currently only 90° s =?UTF-8?Q?teps=20possible?=), w/options for non-destructive handling of source image
https://bugs.documentfoundation.org/show_bug.cgi?id=73797 --- Comment #16 from Luke--- To clarify, this was a feature request of OpenOffice 1.1 with 24 votes[1] and many duplicates. Multiple OOo and LO developers have been unable to resolve[2], so I thought we might need to approach it from a different angle. Miklos, Do you think your DOCX Image object could be extended to be used as the default image container for native Writer files too? [1] https://bz.apache.org/ooo/show_bug.cgi?id=12909 [2] Bug 34423 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73797] Allow rotation of images in Writer by any angle / degree ( currently only 90° s =?UTF-8?Q?teps=20possible?=), w/options for non-destructive handling of source image
https://bugs.documentfoundation.org/show_bug.cgi?id=73797 Lukechanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=73 ||796 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73796] Rotation of images in Writer: Allow rotation of inserted SVG vector graphics
https://bugs.documentfoundation.org/show_bug.cgi?id=73796 Lukechanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=73 ||797 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73797] Allow rotation of images in Writer by any angle / degree ( currently only 90° s =?UTF-8?Q?teps=20possible?=), w/options for non-destructive handling of source image
https://bugs.documentfoundation.org/show_bug.cgi?id=73797 Lukechanged: What|Removed |Added See Also||https://bz.apache.org/ooo/s ||how_bug.cgi?id=3545 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101898] Saving a presentation on Ubuntu 16.04 hangs (regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=101898 Aron Budeachanged: What|Removed |Added Keywords||dataLoss, haveBacktrace Component|Impress |framework --- Comment #22 from Aron Budea --- So far only the two of you have this issue, it's impossible for anyone else to bibisect it. However, knowing 5.1 was fine is still important discovery, thanks for checking earlier versions. The aforementioned rules that cause the infinite loop seem to be coming from some kind of Sharepoint configuration. Do you have anything like that set up in the system? Or maybe it's related to CMIS integration in general? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102377] FILESAVE: Saving as XLSX resulted in Corrupted file
https://bugs.documentfoundation.org/show_bug.cgi?id=102377 Lukechanged: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100119] Korean Autocorrect does not work in OS X 10.11
https://bugs.documentfoundation.org/show_bug.cgi?id=100119 --- Comment #5 from Jeehyun--- After upgrade to 10.12 sierra, OpenOffice does not have autocorrect issue any more. LibreOffice and NeoOffice still have same problem. But OpenOffice still cannot change Korean word to Hanja character. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102377] New: FILESAVE: Saving as XLSX resulted in Corrupted file
https://bugs.documentfoundation.org/show_bug.cgi?id=102377 Bug ID: 102377 Summary: FILESAVE: Saving as XLSX resulted in Corrupted file Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lukebe...@hotmail.com User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36 Build Identifier: a3504b128c752c8fccd55bfc7e2db24f1db53337 Recent builds of Calc are generated corrupt files that need to be repaired to open in Excel 2013. Reproducible: Always Steps to Reproduce: 1. With a recent build of Calc type some text in a cell 2. Save as XLSX 3. Open In Excel Actual Results: Excel says "We found a problem with some contents in xxx.xlsx. Do you want us to try to recovered as much as we can?" Then "Repaired Records: Font from /xl/styles.xml part (Styles)" Expected Results: Open without error. This is a regression. Earlier builds such as Build ID: cf31f48acca45396588aa410ddbe613b92f9fbce generated valid XLSX files that opened in Excel without errors. Reset User Profile? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99697] Add UNO and drop-down icon for Formatting Aids Display options
https://bugs.documentfoundation.org/show_bug.cgi?id=99697 Yousuf Philips (jay)changed: What|Removed |Added Keywords|needsUXEval | CC||tietze.he...@gmail.com --- Comment #6 from Yousuf Philips (jay) --- We understand what you are asking for and dont feel it is a worthy enhancement that we would encourage a developer to work on, as it would solve an issue that would have very limited usage/benefit. This doesnt mean that if a you or an interested developer wanted to work on it and submit a patch for it that we would oppose its addition. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101556] Move some (?) settings from Options > Calc > View to menu bar View
https://bugs.documentfoundation.org/show_bug.cgi?id=101556 Yousuf Philips (jay)changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |er...@redhat.com |.freedesktop.org| --- Comment #7 from Yousuf Philips (jay) --- @Eike: Any thoughts of what view options are worth easy access to toggle in the view menu? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101556] Move some (?) settings from Options > Calc > View to menu bar View
https://bugs.documentfoundation.org/show_bug.cgi?id=101556 Yousuf Philips (jay)changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |er...@redhat.com |.freedesktop.org| --- Comment #7 from Yousuf Philips (jay) --- @Eike: Any thoughts of what view options are worth easy access to toggle in the view menu? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 102282] Crash at start
https://bugs.documentfoundation.org/show_bug.cgi?id=102282 --- Comment #5 from Hector Acevedo--- Created attachment 127566 --> https://bugs.documentfoundation.org/attachment.cgi?id=127566=edit log file The installation of soffice-common partially resolved the problem and several writer documents could be opened, edited and saved with apparent normality. However, if the main window is opened and a file from the list is not selected immediately, after some time moving the cursor over the window will again blank the screen and reboot the system. I am adding gdbtrace.log as an attachment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102282] Crash at start
https://bugs.documentfoundation.org/show_bug.cgi?id=102282 --- Comment #4 from Hector Acevedo--- Created attachment 127565 --> https://bugs.documentfoundation.org/attachment.cgi?id=127565=edit log file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101556] Move some (?) settings from Options > Calc > View to menu bar View
https://bugs.documentfoundation.org/show_bug.cgi?id=101556 Yousuf Philips (jay)changed: What|Removed |Added CC||philip...@hotmail.com Blocks||86899, 102187 --- Comment #6 from Yousuf Philips (jay) --- Hi lukas, By default value highlighting and formulas are the only two that arent on by default in the options dialog and a value highlighting entry has always been in the view menu since 3.3 and I added a show formulas entry in master some time ago, so it will be available in the 5.3 release. So just like Cor's request, are there any other ones that are highly toggled on and off that warrant addition into the view menu, as i tried them and dont see any. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86899 [Bug 86899] [META] Requests for the addition of UNO commands https://bugs.documentfoundation.org/show_bug.cgi?id=102187 [Bug 102187] [META] Options dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101556] Move some (?) settings from Options > Calc > View to menu bar View
https://bugs.documentfoundation.org/show_bug.cgi?id=101556 Yousuf Philips (jay)changed: What|Removed |Added CC||philip...@hotmail.com Blocks||86899, 102187 --- Comment #6 from Yousuf Philips (jay) --- Hi lukas, By default value highlighting and formulas are the only two that arent on by default in the options dialog and a value highlighting entry has always been in the view menu since 3.3 and I added a show formulas entry in master some time ago, so it will be available in the 5.3 release. So just like Cor's request, are there any other ones that are highly toggled on and off that warrant addition into the view menu, as i tried them and dont see any. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86899 [Bug 86899] [META] Requests for the addition of UNO commands https://bugs.documentfoundation.org/show_bug.cgi?id=102187 [Bug 102187] [META] Options dialog bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 86899] [META] Requests for the addition of UNO commands
https://bugs.documentfoundation.org/show_bug.cgi?id=86899 Yousuf Philips (jay)changed: What|Removed |Added Depends on||101556 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101556 [Bug 101556] Move some (?) settings from Options > Calc > View to menu bar View -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102187] [META] Options dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102187 Yousuf Philips (jay)changed: What|Removed |Added Depends on||101556 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101556 [Bug 101556] Move some (?) settings from Options > Calc > View to menu bar View -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/DocumentBroker.hpp
loolwsd/DocumentBroker.cpp | 31 +-- loolwsd/DocumentBroker.hpp |2 ++ 2 files changed, 27 insertions(+), 6 deletions(-) New commits: commit 342125b8ead18ac79dd644063e58496afd5d7d38 Author: Ashod NakashianDate: Thu Sep 22 17:48:37 2016 -0400 bccu#2018 - Missing tiles when finished typing aka: don't save invalidated tiles into cache Tiles that are rendered when invalidation is recieved are outdated. What we do is remember the last tile version when we get an invalidation. This tile version, and any preceding it, is out of date and should not get saved in the tile cache. This fixes a race between rendering and invalidation, which happens in the following scenario. 1. Tile requested for rendering. 2. User inputs key. 3. While tile is rendering, the tile is invalidated in Core (the shared lock between rendering and processing input doesn't include parsing tile request or preparing the payload back). 4. Once the tile rendering is done, but before it's encoded and sent back, the invalidation is received on the callback. 5. Tile cache is cleared of that tile. 6. The outdated tile is received on its way to the client, saved in cache. 7. Client requests the tile anew upon getting the invalidation. 8. The tile is served from the cache, which is outdated, therefore missing the last key input form the user. The fix is in #3 to remember the version number of the tile being rendered. Then in #6 we forward the tile to the client, but we do not store it in cache. In #8 the tile request results in a new rendering, since the cache will not have the tile. Only this last rendering of the tile is saved in cache for future requests. Change-Id: I0b0a3c2b917906c0d0c9046e3e6d3d4d354a Reviewed-on: https://gerrit.libreoffice.org/29209 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp index c241594..f55f3ed 100644 --- a/loolwsd/DocumentBroker.cpp +++ b/loolwsd/DocumentBroker.cpp @@ -112,7 +112,8 @@ DocumentBroker::DocumentBroker() : _cursorHeight(0), _isLoaded(false), _isModified(false), -_tileVersion(0) +_tileVersion(0), +_invalidatedTileVersion(0) { Log::info("Empty DocumentBroker (marked to destroy) created."); } @@ -135,7 +136,8 @@ DocumentBroker::DocumentBroker(const Poco::URI& uriPublic, _cursorHeight(0), _isLoaded(false), _isModified(false), -_tileVersion(0) +_tileVersion(0), +_invalidatedTileVersion(0) { assert(!_docKey.empty()); assert(!_childRoot.empty()); @@ -470,8 +472,9 @@ void DocumentBroker::invalidateTiles(const std::string& tiles) // Remove from cache. _tileCache->invalidateTiles(tiles); -//TODO: Re-issue the tiles again to avoid races. - +// Any older tile than this (inclusive) is not to be trusted. +_invalidatedTileVersion = _tileVersion; +Log::trace("Last invalidated tile version: " + std::to_string(_invalidatedTileVersion)); } void DocumentBroker::handleTileRequest(TileDesc& tile, @@ -588,6 +591,14 @@ void DocumentBroker::handleTileResponse(const std::vector& payload) { auto tile = TileDesc::parse(firstLine); +bool cache = true; +if (_invalidatedTileVersion > 0 && tile.getVersion() <= _invalidatedTileVersion) +{ +// Drop from the cache, but forward to clients nontheless. +Log::info() << "Dropping potentially invalidated tile (cutoff " +<< _invalidatedTileVersion << "): " << firstLine << Log::end; +cache = false; +} const auto length = payload.size(); if (firstLine.size() < static_cast(length) - 1) @@ -595,7 +606,7 @@ void DocumentBroker::handleTileResponse(const std::vector& payload) const auto buffer = payload.data(); tileCache().notifySubscribers( tile, buffer + firstLine.size() + 1, -length - firstLine.size() - 1, true); +length - firstLine.size() - 1, cache); } else { @@ -621,6 +632,14 @@ void DocumentBroker::handleTileCombinedResponse(const std::vector& payload { auto tileCombined = TileCombined::parse(firstLine); +bool cache = true; +if (_invalidatedTileVersion > 0 && tileCombined.getVersion() <= _invalidatedTileVersion) +{ +// Drop from the cache, but forward to clients nontheless. +Log::info() << "Dropping potentially invalidated tile (cutoff " +<< _invalidatedTileVersion << "): " << firstLine << Log::end; +cache = false; +} const auto length = payload.size(); if (firstLine.size() <
[Libreoffice-commits] online.git: loolwsd/TileCache.cpp
loolwsd/TileCache.cpp |1 - 1 file changed, 1 deletion(-) New commits: commit 1f207290f044c90f03be2304f5150737aaacca4e Author: Ashod NakashianDate: Thu Sep 22 17:48:11 2016 -0400 loolwsd: don't assert if we can't find subscribers to forget Change-Id: Ic860eb58f17d1d7c8341881be2991d0bd8712a14 Reviewed-on: https://gerrit.libreoffice.org/29208 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/TileCache.cpp b/loolwsd/TileCache.cpp index acaf18b..6924e30 100644 --- a/loolwsd/TileCache.cpp +++ b/loolwsd/TileCache.cpp @@ -121,7 +121,6 @@ void TileCache::forgetTileBeingRendered(const TileDesc& tile) Util::assertIsLocked(_tilesBeingRenderedMutex); -assert(_tilesBeingRendered.find(cachedName) != _tilesBeingRendered.end()); _tilesBeingRendered.erase(cachedName); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/test loolwsd/TileCache.cpp loolwsd/TileCache.hpp
loolwsd/DocumentBroker.cpp | 20 +++- loolwsd/TileCache.cpp | 15 +-- loolwsd/TileCache.hpp |2 +- loolwsd/test/TileCacheTests.cpp |2 +- 4 files changed, 22 insertions(+), 17 deletions(-) New commits: commit 01718c5c68bad8d324dfcc1b93d3c49055c90873 Author: Ashod NakashianDate: Thu Sep 22 17:47:12 2016 -0400 loolwsd: TileCache is told to save or not before notifying subscribers Change-Id: Ibe24bbe9b4bf6fbaae7c9fcea5f919f7091d299e Reviewed-on: https://gerrit.libreoffice.org/29207 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp index 989e056..c241594 100644 --- a/loolwsd/DocumentBroker.cpp +++ b/loolwsd/DocumentBroker.cpp @@ -587,14 +587,15 @@ void DocumentBroker::handleTileResponse(const std::vector& payload) try { auto tile = TileDesc::parse(firstLine); -const auto buffer = payload.data(); -const auto length = payload.size(); + +const auto length = payload.size(); if (firstLine.size() < static_cast(length) - 1) { -tileCache().saveTileAndNotify( +const auto buffer = payload.data(); +tileCache().notifySubscribers( tile, buffer + firstLine.size() + 1, -length - firstLine.size() - 1); +length - firstLine.size() - 1, true); } else { @@ -619,21 +620,22 @@ void DocumentBroker::handleTileCombinedResponse(const std::vector& payload try { auto tileCombined = TileCombined::parse(firstLine); -const auto buffer = payload.data(); -const auto length = payload.size(); -auto offset = firstLine.size() + 1; + +const auto length = payload.size(); if (firstLine.size() < static_cast(length) - 1) { +const auto buffer = payload.data(); +auto offset = firstLine.size() + 1; for (const auto& tile : tileCombined.getTiles()) { -tileCache().saveTileAndNotify(tile, buffer + offset, tile.getImgSize()); +tileCache().notifySubscribers(tile, buffer + offset, tile.getImgSize(), true); offset += tile.getImgSize(); } } else { -Log::error() << "Render request failed for " << firstLine << Log::end; +Log::debug() << "Render request declined for " << firstLine << Log::end; std::unique_lock tileBeingRenderedLock(tileCache().getTilesBeingRenderedLock()); for (const auto& tile : tileCombined.getTiles()) { diff --git a/loolwsd/TileCache.cpp b/loolwsd/TileCache.cpp index d13400e..acaf18b 100644 --- a/loolwsd/TileCache.cpp +++ b/loolwsd/TileCache.cpp @@ -143,7 +143,7 @@ std::unique_ptr TileCache::lookupTile(const TileDesc& tile) return nullptr; } -void TileCache::saveTileAndNotify(const TileDesc& tile, const char *data, const size_t size) +void TileCache::notifySubscribers(const TileDesc& tile, const char *data, const size_t size, const bool save) { std::unique_lock lock(_tilesBeingRenderedMutex); @@ -152,11 +152,14 @@ void TileCache::saveTileAndNotify(const TileDesc& tile, const char *data, const // Save to disk. const auto cachedName = (tileBeingRendered ? tileBeingRendered->getCacheName() : cacheFileName(tile)); -const auto fileName = _cacheDir + "/" + cachedName; -Log::trace() << "Saving cache tile: " << fileName << Log::end; -std::fstream outStream(fileName, std::ios::out); -outStream.write(data, size); -outStream.close(); +if (save) +{ +const auto fileName = _cacheDir + "/" + cachedName; +Log::trace() << "Saving cache tile: " << fileName << Log::end; +std::fstream outStream(fileName, std::ios::out); +outStream.write(data, size); +outStream.close(); +} // Notify subscribers, if any. if (tileBeingRendered) diff --git a/loolwsd/TileCache.hpp b/loolwsd/TileCache.hpp index fc0210b..206603b 100644 --- a/loolwsd/TileCache.hpp +++ b/loolwsd/TileCache.hpp @@ -47,7 +47,7 @@ public: std::unique_ptr lookupTile(const TileDesc& tile); -void saveTileAndNotify(const TileDesc& tile, const char *data, const size_t size); +void notifySubscribers(const TileDesc& tile, const char *data, const size_t size, const bool save); std::string getTextFile(const std::string& fileName); diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp index f2d7f3d..9081675 100644 --- a/loolwsd/test/TileCacheTests.cpp +++ b/loolwsd/test/TileCacheTests.cpp @@ -167,7 +167,7 @@ void TileCacheTests::testSimple() // Cache Tile const auto size = 1024; const auto data =
[Libreoffice-bugs] [Bug 43544] FILEOPEN: Calc extremely slow when opening some XLSX files
https://bugs.documentfoundation.org/show_bug.cgi?id=43544 Aron Budeachanged: What|Removed |Added Keywords||filter:xlsx CC||ba...@caesar.elte.hu Whiteboard|BSA |BSA interoperability -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77369] Calc borders only show one line style
https://bugs.documentfoundation.org/show_bug.cgi?id=77369 Aron Budeachanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=79 ||788 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79788] XLSX/XLS dotted/ dashed cell borders are showing as normal line in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=79788 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=77 ||369 --- Comment #6 from Aron Budea --- Note that in 4.2.0.4 the border is dashed, and not a solid line. That still isn't correct, but the solid line is shown because of bug 77369, which is a different issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101945] Display information about LibreOffice during install
https://bugs.documentfoundation.org/show_bug.cgi?id=101945 --- Comment #17 from Aron Budea--- Just a note on installation time: upgrading on Windows actually takes several minutes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101945] Display information about LibreOffice during install
https://bugs.documentfoundation.org/show_bug.cgi?id=101945 --- Comment #17 from Aron Budea--- Just a note on installation time: upgrading on Windows actually takes several minutes. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 102376] New: Arrow of the Cell Comment does not move with, when cell is moved
https://bugs.documentfoundation.org/show_bug.cgi?id=102376 Bug ID: 102376 Summary: Arrow of the Cell Comment does not move with, when cell is moved Product: LibreOffice Version: unspecified Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rue...@web.de User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/602.1.50 (KHTML, like Gecko) Version/10.0 Safari/602.1.50 Build Identifier: LibreOffice 4.4.6.3 A comment is set to a cell. Then the cell is moved to another place in the worksheet. When the comment is shown after that, the arrow points to the initial place of the cell, but not to the now valid place. It will not help to close the comment and reopen it. Reproducible: Always Steps to Reproduce: 1. Edit a cell wether with text or with numbers, 2. edit a comment and make it permanently visible, 3. move the cell to another place in the worksheet. Actual Results: The arrow from the comment points to the place where the cell was created Expected Results: The arrow should point to the actual place of the cell [Information automatically included from LibreOffice] Locale: de Module: SpreadsheetDocument [Information guessed from browser] OS: Mac OS X (All) OS is 64bit: no Reset User Profile?No -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101599] [EDITING] Inserting certain Unicode combining characters causes text in paragraph to appear corrupted.
https://bugs.documentfoundation.org/show_bug.cgi?id=101599 Michael von Preußenchanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from Michael von Preußen --- Version: 5.2.1.2 Build ID: 31dd62db80d4e60af04904455ec9c9219178d620 CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; Locale: en-US (en_US); Calc: group I initially encountered the bug in version 5.2.0.4 (which is what I filed this bug under); it has persisted with my upgrade to version 5.2.1.2. I am adjusting the status back to UNCONFIRMED per the recommendation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94172] Docked toolbars use “gen” VCL plugin’s gradient instead of KDE theme color
https://bugs.documentfoundation.org/show_bug.cgi?id=94172 Heiko Tietzechanged: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94172] Docked toolbars use “gen” VCL plugin’s gradient instead of KDE theme color
https://bugs.documentfoundation.org/show_bug.cgi?id=94172 Heiko Tietzechanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Heiko Tietze --- This issue has been fixed. Thanks a lot! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94112] Unreadable non accesible entries in menu with kde dark theme
https://bugs.documentfoundation.org/show_bug.cgi?id=94112 Heiko Tietzechanged: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94112] Unreadable non accesible entries in menu with kde dark theme
https://bugs.documentfoundation.org/show_bug.cgi?id=94112 Heiko Tietzechanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Heiko Tietze --- Issue is fixed, thanks a lot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97721] Checkboxes and radio buttons are displayed oddly in the menu ( with KDE)
https://bugs.documentfoundation.org/show_bug.cgi?id=97721 --- Comment #7 from Heiko Tietze--- Created attachment 127562 --> https://bugs.documentfoundation.org/attachment.cgi?id=127562=edit Close but no cigar Much better but now one or two pixels to the left are missing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: What's the use of core/*/qa/unoapi/knownissues.xcl files?
Hi, On Thu, Sep 22, 2016 at 09:43:54PM +0200, Maarten Bosmans wrote: > I could not find where these files are actually used. A simple "git grep knownissues" tells otherwise: $ git grp knownissues chart2/JunitTest_chart2_unoapi.mk: -Dorg.openoffice.test.arg.xcl=$(SRCDIR)/chart2/qa/unoapi/knownissues.xcl \ ... 35 more lines ... > Should they be removed? Once you fixed all the historically broken/unstable tests on all platforms, yes. ;D But better not earlier: these files lists the tests that should be skipped. > On a related note: The issue numbers in those files look like: i84702. > [...] > Is there any way of accessing the descriptions of these old bugs? e.g. https://bz.apache.org/ooo/show_bug.cgi?id=84702 Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: writing attribute style:background-transparency
Hi Armin, Armin Le Grand schrieb: Hi Regina, tried, but could not create one (tried frames in SW, too). Might have to do with the change of SW FillStyle/Transparency attributes to the full Draw ItemSet. These get written with the same attributes as for draw objects, but before the change that attribute might have been used. It would be loaded and converted at import, though. Thus, might be if you use an older version which had not that change and insert a frame and set transparency, but no guarantees Direct hit :) AOO 3.4.1 writes a style:background-transparency for a Writer frame with background color and transparency. LibreOffice 5.3 writes style:background-transparency too, but in addition it writes draw:fill, draw:fill-color and draw:opacity. LibreOffice writes draw:fill, draw:fill-color and draw:opacity too in style:page-layout-properties, however there without style:background-transparency. But for draw:fill, draw:fill-color and draw:opacity it is the same problem as for style:background-transparency: It is not allowed in style:page-layout-properties. So my conclusion is, that a transparent property for page background is indeed needed. But I would suggest not to extend the style:background-transparency, but the draw:xyz attributes, because they are richer and already used in LibreOffice. Kind regards Regina HTH! ALG Am 21.09.2016 um 19:36 schrieb Regina Henschel: Hi all, the ODF TC is going to discuss issue OFFICE-3770 [1], which is about the attribute style:background-transparency. I'm trying to generate a document by LibreOffice, in which this attribute is used. But in all my tries I always get draw:opacity or draw:opacity-name (in case of gradient). Do you know a situation where LibreOffice writes the attribute style:background-transparency ? Kind regards Regina [1] https://issues.oasis-open.org/browse/OFFICE-3770 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 94247] Export to DOCX: List numbering continues on other list in specific ODT
https://bugs.documentfoundation.org/show_bug.cgi?id=94247 xuanngo2...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94247] Export to DOCX: List numbering continues on other list in specific ODT
https://bugs.documentfoundation.org/show_bug.cgi?id=94247 --- Comment #6 from xuanngo2...@yahoo.com --- @Timur I no longer remember how this doc is created. I'm therefore closing this bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/docshell/impex.cxx | 43 sc/source/ui/inc/impex.hxx |1 2 files changed, 44 insertions(+) New commits: commit 854254c36f4c4804bb5c8fcde2edef444baed25c Author: Eike RathkeDate: Thu Sep 22 23:50:57 2016 +0200 attempt to fix build, ScImportExport( ScDocument*, const OUString& ) ... is not unused but only in ifdef _WIN32 commit c4cd079b8f613084a99a83b95c3968b65cbd8900 Date: Thu Sep 22 15:08:42 2016 +0200 loplugin:unusedmethods in sc..vcl Change-Id: I36c8d57fddfffe8c99cf40ae514270f445388d08 diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx index 930c794..85efd9a 100644 --- a/sc/source/ui/docshell/impex.cxx +++ b/sc/source/ui/docshell/impex.cxx @@ -136,6 +136,49 @@ ScImportExport::ScImportExport( ScDocument* p, const ScRange& r ) aRange.aEnd.SetTab( aRange.aStart.Tab() ); } +// Evaluate input string - either range, cell or the whole document (when error) +// If a View exists, the TabNo of the view will be used. +ScImportExport::ScImportExport( ScDocument* p, const OUString& rPos ) +: pDocSh( dynamic_cast< ScDocShell* >(p->GetDocumentShell()) ), pDoc( p ), + nSizeLimit( 0 ), cSep( '\t' ), cStr( '"' ), + bFormulas( false ), bIncludeFiltered( true ), + bAll( false ), bSingle( true ), bUndo( pDocSh != nullptr ), + bOverflowRow( false ), bOverflowCol( false ), bOverflowCell( false ), + mbApi( true ), mbImportBroadcast(false), mbOverwriting( false ), + mExportTextOptions() +{ +pUndoDoc = nullptr; +pExtOptions = nullptr; + +SCTAB nTab = ScDocShell::GetCurTab(); +aRange.aStart.SetTab( nTab ); +OUString aPos( rPos ); +// Named range? +ScRangeName* pRange = pDoc->GetRangeName(); +if (pRange) +{ +const ScRangeData* pData = pRange->findByUpperName(ScGlobal::pCharClass->uppercase(aPos)); +if (pData) +{ +if( pData->HasType( ScRangeData::Type::RefArea ) +|| pData->HasType( ScRangeData::Type::AbsArea ) +|| pData->HasType( ScRangeData::Type::AbsPos ) ) +{ +pData->GetSymbol(aPos); +} +} +} +formula::FormulaGrammar::AddressConvention eConv = pDoc->GetAddressConvention(); +// Range? +if (aRange.Parse(aPos, pDoc, eConv) & ScRefFlags::VALID) +bSingle = false; +// Cell? +else if (aRange.aStart.Parse(aPos, pDoc, eConv) & ScRefFlags::VALID) +aRange.aEnd = aRange.aStart; +else +bAll = true; +} + ScImportExport::~ScImportExport() { delete pUndoDoc; diff --git a/sc/source/ui/inc/impex.hxx b/sc/source/ui/inc/impex.hxx index b5b69f6..b0be3ef 100644 --- a/sc/source/ui/inc/impex.hxx +++ b/sc/source/ui/inc/impex.hxx @@ -89,6 +89,7 @@ class ScImportExport public: ScImportExport( ScDocument* ); // the whole document +ScImportExport( ScDocument*, const OUString& ); // Range/cell input ScImportExport( ScDocument*, const ScAddress& ); ScImportExport( ScDocument*, const ScRange& ); ~ScImportExport(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 16 commits - config_host.mk.in configure.ac external/harfbuzz RepositoryExternal.mk vcl/headless vcl/inc vcl/Library_vcl.mk vcl/quart
Rebased ref, commits from common ancestor: commit eae33101ca93533a22ae7b972356e37ae02a42ec Author: Khaled HosnyDate: Thu Sep 22 14:04:50 2016 -0700 Fix building HarfBuzz with Graphite on Mac A very ugly hack as We donât have pkg-config on Mac, so search for graphite2 always fails even though we set GRAPHITE2_LIBS etc. Change-Id: I0b663a4d0a2534c72b7317ec08d1656e3ce311e0 diff --git a/external/harfbuzz/ExternalProject_harfbuzz.mk b/external/harfbuzz/ExternalProject_harfbuzz.mk index 5e98f9e..514132d 100644 --- a/external/harfbuzz/ExternalProject_harfbuzz.mk +++ b/external/harfbuzz/ExternalProject_harfbuzz.mk @@ -39,6 +39,7 @@ $(call gb_ExternalProject_get_state_target,harfbuzz,build) : $(if $(verbose),--disable-silent-rules,--enable-silent-rules) \ $(if $(CROSS_COMPILING),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \ $(if $(filter LINUX,$(OS)),CXXFLAGS="$(CXXFLAGS) -fvisibility=hidden") \ + $(if $(filter MACOSX,$(OS)),PKG_CONFIG=true) \ && (cd $(EXTERNAL_WORKDIR)/src && $(MAKE) lib) \ ) commit 5f7a2b8cfac1cf57e24d8c5a416339d1056f0cac Author: Khaled Hosny Date: Thu Sep 22 07:57:04 2016 -0700 Build HarfBuzz with Core Text on Mac To enable support for AAT fonts. Change-Id: Ifcc7d1672e98f8c067482400b7e45226bed4dbf1 diff --git a/external/harfbuzz/ExternalProject_harfbuzz.mk b/external/harfbuzz/ExternalProject_harfbuzz.mk index f6a2d49..5e98f9e 100644 --- a/external/harfbuzz/ExternalProject_harfbuzz.mk +++ b/external/harfbuzz/ExternalProject_harfbuzz.mk @@ -35,6 +35,7 @@ $(call gb_ExternalProject_get_state_target,harfbuzz,build) : --with-cairo=no \ --with-glib=no \ --with-graphite2=yes \ + $(if $(filter MACOSX,$(OS)),--with-coretext=yes) \ $(if $(verbose),--disable-silent-rules,--enable-silent-rules) \ $(if $(CROSS_COMPILING),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \ $(if $(filter LINUX,$(OS)),CXXFLAGS="$(CXXFLAGS) -fvisibility=hidden") \ commit abdc37266fcf6acc3340d1f3edbb2f22337dffdd Author: Khaled Hosny Date: Thu Sep 22 19:48:10 2016 +0200 Always pass BCP 47 tags to HarfBuzz This is what it is expecting anyway, no need to special case it for Chinese. Change-Id: I6732412375d19816b599005d78abd796f67599ee diff --git a/vcl/source/gdi/CommonSalLayout.cxx b/vcl/source/gdi/CommonSalLayout.cxx index ea4e5f9..8cb1dc9 100644 --- a/vcl/source/gdi/CommonSalLayout.cxx +++ b/vcl/source/gdi/CommonSalLayout.cxx @@ -379,7 +379,7 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs) aHbScript = it->maScript; // hb_language_from_string() accept ISO639-3 language tag except for Chinese. LanguageTag = rArgs.maLanguageTag; -OString sLanguage = OUStringToOString( MsLangId::isChinese(rTag.getLanguageType()) ? rTag.getBcp47():rTag.getLanguage() , RTL_TEXTENCODING_UTF8 ); +OString sLanguage = OUStringToOString(rTag.getBcp47(), RTL_TEXTENCODING_ASCII_US); int nHbFlags = HB_BUFFER_FLAGS_DEFAULT; if (nMinRunPos == 0) commit c4501793fd2d2b224ea1eb6dff568e2ce983f01a Author: Khaled Hosny Date: Thu Sep 22 19:45:23 2016 +0200 Always build Graphite everywhere It is no longer an optional feature on any platform. The --enable-graphite stuff is kept as it controls the old Graphite integration code and it should be removed without. Change-Id: Ib4d76bba782a1439f02f93411b22d237a1987ea5 diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index e0f1337..64eeacf 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -1357,8 +1357,6 @@ endef endif # SYSTEM_FONTCONFIG -ifeq ($(ENABLE_GRAPHITE),TRUE) - ifneq ($(SYSTEM_GRAPHITE),) define gb_LinkTarget__use_graphite @@ -1386,12 +1384,6 @@ endef endif # SYSTEM_GRAPHITE -else # !ENABLE_GRAPHITE - -gb_LinkTarget__use_graphite := - -endif # ENABLE_GRAPHITE - ifneq ($(SYSTEM_ICU),) gb_LinkTarget__use_icu_headers:= diff --git a/configure.ac b/configure.ac index be56b53..51a51d1 100644 --- a/configure.ac +++ b/configure.ac @@ -9231,19 +9231,20 @@ AC_SUBST(ICU_LIBS) dnl === dnl Graphite dnl === +libo_CHECK_SYSTEM_MODULE([graphite],[GRAPHITE],[graphite2 >= 0.9.3],["-I${WORKDIR}/UnpackedTarball/graphite/include"],["-L${WORKDIR}/LinkTarget/StaticLibrary -lgraphite"]) +if test "$with_system_graphite" = "yes"; then +libo_MINGW_CHECK_DLL([libgraphite2]) +fi +if test "$COM" = "MSC"; then # override the above +
[Libreoffice-bugs] [Bug 80944] 'print to file' setting gets reset after restart
https://bugs.documentfoundation.org/show_bug.cgi?id=80944 --- Comment #5 from MM--- Bug is still present in v5.2.1.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 5 commits - configure.ac external/harfbuzz RepositoryExternal.mk vcl/inc vcl/Library_vcl.mk vcl/source
Rebased ref, commits from common ancestor: commit 7697ef88cba36f6397693126fc2091a72e7b9821 Author: Khaled HosnyDate: Thu Sep 22 14:09:29 2016 -0700 Add missing override Change-Id: I6a309715e30eef1c99c390e95c91f81cc9d75d04 diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx index 179eee88..89214d4 100644 --- a/vcl/inc/CommonSalLayout.hxx +++ b/vcl/inc/CommonSalLayout.hxx @@ -66,6 +66,6 @@ public: virtual voidDrawText( SalGraphics& ) const override; std::shared_ptr CreateTextLayoutCache(OUString const&) const override; -virtual boolGetCharWidths(DeviceCoordinate* pCharWidths) const; -virtual voidApplyDXArray(ImplLayoutArgs&); +virtual boolGetCharWidths(DeviceCoordinate* pCharWidths) const override; +virtual voidApplyDXArray(ImplLayoutArgs&) override; }; diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h index 5313903..f7e5156 100644 --- a/vcl/inc/quartz/salgdi.h +++ b/vcl/inc/quartz/salgdi.h @@ -410,7 +410,7 @@ public: virtual SalLayout* GetTextLayout( ImplLayoutArgs&, int nFallbackLevel ) override; virtual voidDrawSalLayout( const CommonSalLayout& ) override; -virtual voidDrawServerFontLayout( const GenericSalLayout&, const ServerFont& ) {}; +virtual voidDrawServerFontLayout( const GenericSalLayout&, const ServerFont& ) override {}; virtual boolsupportsOperation( OutDevSupportType ) const override; #ifdef MACOSX commit b712562a0f9325db188f72e5b035763d95b92dcc Author: Khaled Hosny Date: Thu Sep 22 14:04:50 2016 -0700 Fix building HarfBuzz with Graphite on macOS A very ugly hack as We donât have pkg-config on macOS, so search for graphite2 always fails even though we set GRAPHITE2_LIBS etc. Change-Id: I0b663a4d0a2534c72b7317ec08d1656e3ce311e0 diff --git a/external/harfbuzz/ExternalProject_harfbuzz.mk b/external/harfbuzz/ExternalProject_harfbuzz.mk index 5e98f9e..514132d 100644 --- a/external/harfbuzz/ExternalProject_harfbuzz.mk +++ b/external/harfbuzz/ExternalProject_harfbuzz.mk @@ -39,6 +39,7 @@ $(call gb_ExternalProject_get_state_target,harfbuzz,build) : $(if $(verbose),--disable-silent-rules,--enable-silent-rules) \ $(if $(CROSS_COMPILING),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \ $(if $(filter LINUX,$(OS)),CXXFLAGS="$(CXXFLAGS) -fvisibility=hidden") \ + $(if $(filter MACOSX,$(OS)),PKG_CONFIG=true) \ && (cd $(EXTERNAL_WORKDIR)/src && $(MAKE) lib) \ ) commit 1e07723351cef08186a3c3397a10ebe18dc183a6 Author: Khaled Hosny Date: Thu Sep 22 07:57:04 2016 -0700 Build HarfBuzz with Core Text on Mac To enable support for AAT fonts. Change-Id: Ifcc7d1672e98f8c067482400b7e45226bed4dbf1 diff --git a/external/harfbuzz/ExternalProject_harfbuzz.mk b/external/harfbuzz/ExternalProject_harfbuzz.mk index f6a2d49..5e98f9e 100644 --- a/external/harfbuzz/ExternalProject_harfbuzz.mk +++ b/external/harfbuzz/ExternalProject_harfbuzz.mk @@ -35,6 +35,7 @@ $(call gb_ExternalProject_get_state_target,harfbuzz,build) : --with-cairo=no \ --with-glib=no \ --with-graphite2=yes \ + $(if $(filter MACOSX,$(OS)),--with-coretext=yes) \ $(if $(verbose),--disable-silent-rules,--enable-silent-rules) \ $(if $(CROSS_COMPILING),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \ $(if $(filter LINUX,$(OS)),CXXFLAGS="$(CXXFLAGS) -fvisibility=hidden") \ commit 41c2d077d34352172edc5533d8f2f21afd2192ef Author: Khaled Hosny Date: Thu Sep 22 19:48:10 2016 +0200 Always pass BCP 47 tags to HarfBuzz This is what it is expecting anyway, no need to special case it for Chinese. Change-Id: I6732412375d19816b599005d78abd796f67599ee diff --git a/vcl/source/gdi/CommonSalLayout.cxx b/vcl/source/gdi/CommonSalLayout.cxx index ea4e5f9..8cb1dc9 100644 --- a/vcl/source/gdi/CommonSalLayout.cxx +++ b/vcl/source/gdi/CommonSalLayout.cxx @@ -379,7 +379,7 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs) aHbScript = it->maScript; // hb_language_from_string() accept ISO639-3 language tag except for Chinese. LanguageTag = rArgs.maLanguageTag; -OString sLanguage = OUStringToOString( MsLangId::isChinese(rTag.getLanguageType()) ? rTag.getBcp47():rTag.getLanguage() , RTL_TEXTENCODING_UTF8 ); +OString sLanguage = OUStringToOString(rTag.getBcp47(), RTL_TEXTENCODING_ASCII_US); int nHbFlags = HB_BUFFER_FLAGS_DEFAULT; if (nMinRunPos == 0) commit
[Libreoffice-commits] core.git: include/desktop
include/desktop/crashreport.hxx |4 1 file changed, 4 insertions(+) New commits: commit 853a63997aaae1e54b638432b1b1391c070f4e2b Author: Michael StahlDate: Thu Sep 22 23:19:32 2016 +0200 desktop: that wasn't unused, just rarely used Change-Id: I87c0fb287aa0b3fc5ad0216d8007772de3d03b2f diff --git a/include/desktop/crashreport.hxx b/include/desktop/crashreport.hxx index b97dadc..e58e387 100644 --- a/include/desktop/crashreport.hxx +++ b/include/desktop/crashreport.hxx @@ -49,6 +49,10 @@ public: static void storeExceptionHandler(google_breakpad::ExceptionHandler* pExceptionHandler); +// when we create the ExceptionHandler we have no access to the user +// profile yet, so update when we have access +static void updateMinidumpLocation(); + private: static osl::Mutex maMutex; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl
include/vcl/salnativewidgets.hxx |1 + 1 file changed, 1 insertion(+) New commits: commit a84f4d266d01ddc085772e9a839d05c267a9fe67 Author: Eike RathkeDate: Thu Sep 22 23:21:42 2016 +0200 attempt to fix build, reintroduce TabitemValue::isLast() commit 7419057e3ec4365748fa6456e207f40fd9e09c62 Date: Thu Sep 22 16:34:14 2016 +0200 loplugin:unusedmethods in chart2..svx removed that but vcl/unx/kde/salnativewidgets-kde.cxx needs it. Change-Id: I1ddc98ffafb1f6a1a22642a9a83cc58085cb4271 diff --git a/include/vcl/salnativewidgets.hxx b/include/vcl/salnativewidgets.hxx index 673341c..5d5bd1c 100644 --- a/include/vcl/salnativewidgets.hxx +++ b/include/vcl/salnativewidgets.hxx @@ -420,6 +420,7 @@ class VCL_DLLPUBLIC TabitemValue : public ImplControlValue bool isBothAligned() const { return isLeftAligned() && isRightAligned(); } bool isNotAligned() const { return !(mnAlignment & (TabitemFlags::LeftAligned | TabitemFlags::RightAligned)); } bool isFirst() const{ return bool(mnAlignment & TabitemFlags::FirstInGroup); } +bool isLast() const { return bool(mnAlignment & TabitemFlags::LastInGroup); } const Rectangle& getContentRect() const { return maContentRect; } }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/null
vcl/null/printerinfomanager.cxx |5 - 1 file changed, 5 deletions(-) New commits: commit d519232369c3dca7a3ad8011dcabc52479fa518f Author: Eike RathkeDate: Thu Sep 22 23:08:17 2016 +0200 attempt to fix build, PrinterInfoManager::changePrinterInfo() gone commit 7419057e3ec4365748fa6456e207f40fd9e09c62 Date: Thu Sep 22 16:34:14 2016 +0200 loplugin:unusedmethods in chart2..svx removed that from include/vcl/printerinfomanager.hxx vcl/unx/generic/printer/printerinfomanager.cxx but not the empty base class implementation from vcl/null/printerinfomanager.cxx Change-Id: I9bfd1c77490c70b9bf7a69c93d34bd0249cce64f diff --git a/vcl/null/printerinfomanager.cxx b/vcl/null/printerinfomanager.cxx index 8be70af..833152f 100644 --- a/vcl/null/printerinfomanager.cxx +++ b/vcl/null/printerinfomanager.cxx @@ -76,11 +76,6 @@ const PrinterInfo& PrinterInfoManager::getPrinterInfo( const OUString& /* rPrint return aEmptyInfo; } -void PrinterInfoManager::changePrinterInfo( const OUString& /* rPrinter */, const PrinterInfo& /* rNewInfo */ ) -{ - -} - bool PrinterInfoManager::writePrinterConfig() { return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 102345] [META] Formatting marks (aka Non-printing characters) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102345 Yousuf Philips (jay)changed: What|Removed |Added Depends on||102249 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102249 [Bug 102249] VIEWING: Add View-> Non-printing Characters for textboxes Draw/Impress -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 102249] VIEWING: Add View-> Non-printing Characters for textboxes Draw/Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=102249 Yousuf Philips (jay)changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists | |.freedesktop.org| Blocks||102345 --- Comment #15 from Yousuf Philips (jay) --- (In reply to Armin Le Grand (CIB) from comment #9) > I personally use non-printing characters as blanks and CR in my code editor, > and it would be possible to do this for EditEngine, too, but - the question > is - where is the win? I would assume that it would be a win in writer for a setting that affects all text of the document to also affect text in shapes and textboxes, else it feels like broken functionality. > Of course one glance on the EditView compared with > klicking in it and using the cursor keys to travel over the parts in > question, but really quite some work to be done to do this and to guarantee > that this is only shown in the EditViews. Well using the cursor key wont tell you if a space is a regular space or a non-breaking space, or with soft hyphens appearing as if something is between the two characters, but a user unfamiliar with it wouldnt know what it was and possibly would delete it. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102345 [Bug 102345] [META] Formatting marks (aka Non-printing characters) bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 102249] VIEWING: Add View-> Non-printing Characters for textboxes Draw/Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=102249 Yousuf Philips (jay)changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists | |.freedesktop.org| Blocks||102345 --- Comment #15 from Yousuf Philips (jay) --- (In reply to Armin Le Grand (CIB) from comment #9) > I personally use non-printing characters as blanks and CR in my code editor, > and it would be possible to do this for EditEngine, too, but - the question > is - where is the win? I would assume that it would be a win in writer for a setting that affects all text of the document to also affect text in shapes and textboxes, else it feels like broken functionality. > Of course one glance on the EditView compared with > klicking in it and using the cursor keys to travel over the parts in > question, but really quite some work to be done to do this and to guarantee > that this is only shown in the EditViews. Well using the cursor key wont tell you if a space is a regular space or a non-breaking space, or with soft hyphens appearing as if something is between the two characters, but a user unfamiliar with it wouldnt know what it was and possibly would delete it. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102345 [Bug 102345] [META] Formatting marks (aka Non-printing characters) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102375] New: Conditional Formatting is corrupted after two saves
https://bugs.documentfoundation.org/show_bug.cgi?id=102375 Bug ID: 102375 Summary: Conditional Formatting is corrupted after two saves Product: LibreOffice Version: unspecified Hardware: x86 (IA32) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jiminle...@gmail.com Conditional Formatting is corrupted after doing two saves. No longer works. Comparing two cells for "less than". The target cell to the right of the "Less than" is corrupted after doing two saves. The Sheet information is destroyed. Cell column and row is ok. Cell should be 'sheetname'.E4 and appears as $#REF!.E5. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion
Hi Alex, Eike, *, On Thu, Sep 22, 2016 at 9:07 PM, Eike Rathkewrote: > On Thursday, 2016-09-22 13:33:42 +0100, Alex Kempshall wrote: >> On 16/09/16 11:05, Stephan Bergmann wrote: >> > Turns out, the relevant GCC switches are >> > >> > -mfpmath=sse -msse2 >> >> On this basis I ran >> >>make clean && make ENVCFLAGS="-mfpmath=sse -msse2" >>ENVCFLAGSCXX="-mfpmath=sse -msse2" && make sc.check >> >> The compile and tests all completed successfully on an up to date 32-bit >> Lubuntu 14.04 and 32-bit Slackware-Current from November 2015. I haven't >> pulled any new code since 1st September so haven't inadvertently picked up >> the work around. but also not the mod.fods or other test files... Can you try whether this also works if you checkout current master and just change the line ifneq ($(PLATFORMID),linux_x86) to ifneq ($(PLATFORMID),linux_x86foobar) in sc/Module_sc.mk to enable the test (disable skipping of the tests)? > Good news and thank you! Interestingly you also didn't encounter > a failure with sc/qa/unit/data/functions/fods/mod.fods which one of our > tinderbox builds had a problem with. yeah, however now prompted to look at git log, it likely is a unrelated problem, as the revert of the file already happened in July with 9dc3356f1499a2b90078be86ca7470eb2e96aba8 so when you reintroduced that, you maybe got a little too far back in time :-) unfortunately the commit doesn't mention *why* the document was removed (maybe because it spammed people because of the failure on 32bit) There even is a comment on the initial gerrit changeset that added the file, mentioning it got reverted, but also doesn't list a reason there. > @Cloph: > Was that reproducible, any insights inspecting the document on that > platform? Needed the box for the release builds, so no further insight right now, but should have another build tomorrow.. But if Alex' tree really is from September 1st, then it doesn't have the test files - you did revert the removal of the testfiles on Sept 16, but removed them already mid August... So unfortunately Alex' result are non-telling, as the problematic test files are not part of the checkout then. ciao Christian -- Christian Lohmaier, Release Engineer Tel: +49 30 5557992-60 | IRC: cloph on Freenode The Document Foundation, Kurfürstendamm 188, 10707 Berlin, DE Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts Legal details: http://www.documentfoundation.org/imprint ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 102374] New: Find & Replace - Regular Expressions not recognized in Replace field
https://bugs.documentfoundation.org/show_bug.cgi?id=102374 Bug ID: 102374 Summary: Find & Replace - Regular Expressions not recognized in Replace field Product: LibreOffice Version: 5.2.1.2 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: shcoth...@zoho.com Is similar to 37494 and I agree with 38261 but this is specific to Writer and using a regular expression in the Replace field. I am trying to change the end of paragraph (reg exp $) with a tab (\t) It finds the end of paragraph just fine when I put the $ into the Find field and have regular expression checkbox on. I put \t into the Replace field and it changes the end of paragraph to a slash and a t.I have tried different regular expressions in the Find field and all that I have tried seem to work. I have tried \t, \n, \u0009, \x09 in the Replace field and each time I get the characters, as if the regular expression box was not checked. I read another post that said that Replace ALL worked when Replace did not. I tried that also but still got characters. O a;sp tried copying a tab from somewhere else in the document and pasting it into the Replace field. Did not work. Did finally find a workaround but it does not eliminate the bug. Workaround: 1. Manually place a Tab in the document. 2. Select and Copy that Tab. 3. Select area to be searched. 4. open Find and Replace dialog box. 5. Type in $ in Find field. 6. Make sure Current Selection and Regular Expression boxes are checked. 7. Click FIND ALL. 8. CTRL-V to paste the copied Tab into all the Find All places. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102373] New: Add "Insert > Field > More Fields..." to Draw as in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=102373 Bug ID: 102373 Summary: Add "Insert > Field > More Fields..." to Draw as in Writer Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: chaw...@zoho.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0 Build Identifier: 5.2.1 In Writer, there are many options to insert automatic fields. These options are much restricted in Draw. The same fields should be offered in both applications. Adding the "Insert > Field > More Fields..." options found in Writer to Draw would fix this. Reproducible: Always Steps to Reproduce: 1. Open a Draw document 2. In "Insert" menu, select "Field" 3. There is no "More Fields..." option (as in Writer) Reset User Profile?No -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102315] EDITING: Increase/ Decrease Font Size do not work reliable in Table selections
https://bugs.documentfoundation.org/show_bug.cgi?id=102315 roumanetchanged: What|Removed |Added CC||go...@free.fr --- Comment #1 from roumanet --- Created attachment 127561 --> https://bugs.documentfoundation.org/attachment.cgi?id=127561=edit Increase/decrease font size in a table (impress) Work Around : first time there is the bug, next clics are OK... at th end, select first cell and decrease one time. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66914] EDITING Writer does not recognize fields as part of a sentence and applies autocorrection (capitalize first letter)
https://bugs.documentfoundation.org/show_bug.cgi?id=66914 Buovjagachanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||658 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92658] AutoCorrect does not replace end quote with smart quote when it is preceded by a field
https://bugs.documentfoundation.org/show_bug.cgi?id=92658 Buovjagachanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=66 ||914 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36582] "Find and replace" finds/replaces text deleted with "record/ track changes"
https://bugs.documentfoundation.org/show_bug.cgi?id=36582 --- Comment #15 from Gerry--- Bug still present in Version: 5.1.4.2 Build-ID: 1:5.1.4-0ubuntu1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101844] Bugs of 5.2 libre. Lapses using Writer and Cursor direction in Hebrew
https://bugs.documentfoundation.org/show_bug.cgi?id=101844 Buovjagachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #2 from Buovjaga --- Not using OpenGL (mentioned in Help - About)? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93863] Can not disable Autoupdate via Group Policy
https://bugs.documentfoundation.org/show_bug.cgi?id=93863 Andras Timarchanged: What|Removed |Added Keywords|needsDevEval| Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |tima...@gmail.com |desktop.org | --- Comment #7 from Andras Timar --- If you want to disable Online Update for your users, why do you install it in the first place? It is an optional component. If you want to disable it, you'd better to disable the entire page, so it won't appear in Tools - Options tree. [HKEY_LOCAL_MACHINE\Policies\LibreOffice\org.openoffice.Office.OptionsDialog\OptionsDialogGroups\ProductName/#fuse\Pages\OnlineUpdate/#fuse\Hide] "Value"="true" The crash and UI lockdown was handled in this patch: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e58bd7a00eba8d2fd0f1db2e8121c81077a3101d -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37731] EDITING Writer: Paste "HTML without comments" not available on Unix/Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=37731 Gerrychanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from Gerry --- Tested in Version: 5.1.4.2 and it seems to work now without problems. Build-ID: 1:5.1.4-0ubuntu1 Therefore I set this bug to FIXED -> WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 82535] EDITING: Allow hot editing of OLE objects like charts and formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=82535 --- Comment #8 from Francisco--- (In reply to Yousuf Philips (jay) from comment #7) > Yes this same thing was discussed on friday in the design session for > revamping charts that it would be useful to not have to go into edit mode to > manipulate the chart, as all other office suites have it in this manner. > > The image capabilities that Sophie mentions wouldnt have to be lost. One additional comment: My idea in this bug report covered also Math Equations, not only charts. Just for if it wasn't clear Regards -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 101971] FILEOPEN - Impress crash (Flash elements)
https://bugs.documentfoundation.org/show_bug.cgi?id=101971 --- Comment #10 from Caolán McNamara--- https://gerrit.libreoffice.org/#/c/29199/ does indeed work to allow this document to load under windows 10 (32bit) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82535] EDITING: Allow hot editing of OLE objects like charts and formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=82535 --- Comment #8 from Francisco--- (In reply to Yousuf Philips (jay) from comment #7) > Yes this same thing was discussed on friday in the design session for > revamping charts that it would be useful to not have to go into edit mode to > manipulate the chart, as all other office suites have it in this manner. > > The image capabilities that Sophie mentions wouldnt have to be lost. One additional comment: My idea in this bug report covered also Math Equations, not only charts. Just for if it wasn't clear Regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 5 commits - loleaflet/src
loleaflet/src/control/Permission.js |1 - loleaflet/src/core/Socket.js | 13 + loleaflet/src/layer/marker/ProgressOverlay.js |3 +-- loleaflet/src/layer/tile/TileLayer.js | 10 +- loleaflet/src/map/Map.js | 16 +--- 5 files changed, 16 insertions(+), 27 deletions(-) New commits: commit 56d92527c2c3457c0578814216a678d1c7e7592c Author: Pranav KantDate: Fri Sep 23 01:21:43 2016 +0530 loleaflet: Kill this troublesome editlock related code This code throws sometimes. Rather than investigating what makes it actually throw, lets kill it because we don't want any editlock functionality anyways now. Change-Id: I8a484ba9e3a658ca739122bb6d2d0c92c4180ff5 diff --git a/loleaflet/src/layer/tile/TileLayer.js b/loleaflet/src/layer/tile/TileLayer.js index f4158d1..122028c 100644 --- a/loleaflet/src/layer/tile/TileLayer.js +++ b/loleaflet/src/layer/tile/TileLayer.js @@ -198,17 +198,9 @@ L.TileLayer = L.GridLayer.extend({ this); map.on('updatepermission', function(e) { - // {En,Dis}able selection handles - for (var key in this._selectionHandles) { - this._selectionHandles[key].setDraggable(e.perm === 'edit'); - } - - // we want graphic selection handles to appear - // when in editmode, and dissappear when in view mode if (e.perm !== 'edit') { - this._graphicSelection = null; + this._clearSelections(); } - this._onUpdateGraphicSelection(); }, this); for (var key in this._selectionHandles) { commit afe14df0476835b49d4d12a56e263a52c86dbd9b Author: Pranav Kant Date: Fri Sep 23 00:25:32 2016 +0530 loleaflet: Start spinner when added to map ... otherwise we see a non-rotating spinner after first initialization. Change-Id: Idf6e259634607249e3411bf772a55fee768f925a diff --git a/loleaflet/src/layer/marker/ProgressOverlay.js b/loleaflet/src/layer/marker/ProgressOverlay.js index 91785e9..a6f7e35 100644 --- a/loleaflet/src/layer/marker/ProgressOverlay.js +++ b/loleaflet/src/layer/marker/ProgressOverlay.js @@ -20,6 +20,7 @@ L.ProgressOverlay = L.Layer.extend({ this.update(); } + this._spinnerInterval = L.LOUtil.startSpinner(this._spinnerCanvas, this.options.spinnerSpeed); this._map.on('moveend', this.update, this); }, @@ -56,8 +57,6 @@ L.ProgressOverlay = L.Layer.extend({ this._container.style.width = this._size.x + 'px'; - this._spinnerInterval = L.LOUtil.startSpinner(this._spinnerCanvas, this.options.spinnerSpeed); - L.DomEvent .disableClickPropagation(this._progress) .disableScrollPropagation(this._container); commit 460ca57dab5aae99f10439dd0f66e7ebe89396c3 Author: Pranav Kant Date: Thu Sep 22 23:42:11 2016 +0530 loleaflet: Smooth reconnection of documents Change-Id: Id8e2b02ee47e163f046c81949d3d2ce75f330542 diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js index 2c45d8e..3971f3e 100644 --- a/loleaflet/src/core/Socket.js +++ b/loleaflet/src/core/Socket.js @@ -74,13 +74,10 @@ L.Socket = L.Class.extend({ // TODO: Move the version number somewhere sensible. this._doSend('loolclient ' + this.ProtocolVersionNumber); - var reconnecting = false; var msg = 'load url=' + this._map.options.doc; if (this._map._docLayer) { // we are reconnecting after a lost connection - reconnecting = true; msg += ' part=' + this._map.getCurrentPartNumber(); - this._map.fire('statusindicator', {statusType : 'reconnected'}); } if (this._map.options.timestamp) { msg += ' timestamp=' + this._map.options.timestamp; @@ -101,10 +98,6 @@ L.Socket = L.Class.extend({ } this._msgQueue = []; - if (reconnecting) { - this._map.setPermission(this._map.options.permission); - } - this._map._activate(); }, @@ -274,6 +267,11 @@ L.Socket = L.Class.extend({ this._map._docLayer = docLayer; this._map.addLayer(docLayer); this._map.fire('doclayerinit'); + } else if (textMsg.startsWith('status:')) { + // we are reconnecting ... +
[Libreoffice-bugs] [Bug 101841] MAILMERGE: First Record Incorrect When Printing Selected Records to File
https://bugs.documentfoundation.org/show_bug.cgi?id=101841 Buovjagachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Buovjaga --- There has been a lot of work put into mail-merge recently and I'm not sure, if all of it is in 5.2.0. You could try with a fresh dev build: http://dev-builds.libreoffice.org/daily/master/Win-x86@42/current/ It installs in parallel. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37903] EDITING: Moving object using ALT - cursor keys also moves the object behind it
https://bugs.documentfoundation.org/show_bug.cgi?id=37903 --- Comment #8 from Gerry--- Bug still present in Version: 5.1.4.2 Build-ID: 1:5.1.4-0ubuntu1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90106] FORMATTING: Page bitmap background resets when switching back to Area tab in Page Style dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=90106 Madschanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from Mads --- Tested it again with libreoffice-5.2.0.4 on gentoo (64 bit), it seems to stick now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101971] FILEOPEN - Impress crash (Flash elements)
https://bugs.documentfoundation.org/show_bug.cgi?id=101971 --- Comment #9 from Caolán McNamara--- Not an ordinary try/except anyway. I see we do have precedent of using __try/__except already. Maybe this is sufficiently miserable already that we could try that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102372] Background image of a inserted slide from file is not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=102372 --- Comment #1 from Francisco--- One last comment: I have uncompressed the file resulted from steps 4-6, and only 2 background images are found in folder Pictures. There's a third small white square also, but it seems to be there always. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102372] New: Background image of a inserted slide from file is not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=102372 Bug ID: 102372 Summary: Background image of a inserted slide from file is not saved Product: LibreOffice Version: 3.5.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: franciscoadriansanc...@gmail.com Created attachment 127560 --> https://bugs.documentfoundation.org/attachment.cgi?id=127560=edit File 3 Inserting the File 2 in File 1 will result in the lost of the File 2's background of the resulting file. This happens allways with this 2 files. It could probably happen with some other files. However, I haven been able to reproduce this bug using a third file over File 1 or File 2. Steps to reproduce: 0) Download File 1 and 2 from bug 102371 (they are already attached there) 1) Open attached file no. 1, "TesisPortada.otp" 2) Goto "Insert" -> "File", and select the 2nd attached file, "TesisContenido1.otp" The background from File 2 won't be shown. One have to go through right click to Slide style, and then click to accept all changes (none so far, but it doesn't matters). The background should appear (see bug 102371 for details). 3) Save the file, exit LibreOffice, and open it again. Result: both slides has the same background (File 1). 4) Restarts a new file, starting from Step 1. 5) Insert now File 3, "TesisContenido2.otp". (It has a different background than File 1 and File 2). 6) Save the file, exit LibreOffice, and open it again. Result: Slides 1 and 2 have the background of File 1. Slide 3's background has correctly the background of File 3. The problem is the same either one open first File 2 and then insert File 1. Moreover, If steps 1 to 3 are repeated using Files 1 and 3 or 2 and 3, the bug doesn't appear. Furthermore, I have been able to reproduce this bug with LibreOffice 3.5.7, 4.4.7, 5.0.6, and 5.2.1. I think it could be inherited from OpenOffice.org. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/svdmodel.hxx |1 - svx/source/svdraw/svdmodel.cxx |3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) New commits: commit 261113b5c78eaa93beed7e5961bca5fe8e1339b7 Author: Stephan BergmannDate: Thu Sep 22 21:59:41 2016 +0200 -Werror,-Wunused-private-field Change-Id: I88df0a06482a04609eb0c394dc7d9a023fc7e921 diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx index 14299d2..e07d8e7 100644 --- a/include/svx/svdmodel.hxx +++ b/include/svx/svdmodel.hxx @@ -126,7 +126,6 @@ private: SdrHintKind meHint; const SdrObject*mpObj; const SdrPage* mpPage; -Rectangle maRectangle; public: explicit SdrHint(SdrHintKind eNewHint); diff --git a/svx/source/svdraw/svdmodel.cxx b/svx/source/svdraw/svdmodel.cxx index 95bcaedb2..4bfb71b 100644 --- a/svx/source/svdraw/svdmodel.cxx +++ b/svx/source/svdraw/svdmodel.cxx @@ -2089,8 +2089,7 @@ SdrHint::SdrHint(SdrHintKind eNewHint) SdrHint::SdrHint(SdrHintKind eNewHint, const SdrObject& rNewObj) : meHint(eNewHint), mpObj(), -mpPage(rNewObj.GetPage()), -maRectangle(rNewObj.GetLastBoundRect()) +mpPage(rNewObj.GetPage()) { } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 89082] FORMATTING: improving text+frames flow
https://bugs.documentfoundation.org/show_bug.cgi?id=89082 Buovjagachanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 89082] FORMATTING: improving text+frames flow
https://bugs.documentfoundation.org/show_bug.cgi?id=89082 Buovjagachanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/basic
include/basic/sbxvar.hxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit e0e8d0fbcf018ac172865af5a3070f30b06d1df5 Author: Noel GrandinDate: Thu Sep 22 21:55:58 2016 +0200 fix windows build by reverting part of commit commit 7419057e3ec4365748fa6456e207f40fd9e09c62 Author: Noel Grandin Date: Thu Sep 22 16:34:14 2016 +0200 loplugin:unusedmethods in chart2..svx Change-Id: I72515c9b5f3739f57d4b63a724a9fa32075b2612 Reviewed-on: https://gerrit.libreoffice.org/29197 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/include/basic/sbxvar.hxx b/include/basic/sbxvar.hxx index 0ad7169..60ab190 100644 --- a/include/basic/sbxvar.hxx +++ b/include/basic/sbxvar.hxx @@ -119,6 +119,8 @@ public: const SbxValues& GetValues_Impl() const { return aData; } bool Put( const SbxValues& ); +SbxValues * data() { return } + sal_Unicode GetChar() const; sal_Int16 GetInteger() const; sal_Int32 GetLong() const; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 101517] UI: Improvement to the Find & Replace dialog with Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=101517 Buovjagachanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101517] UI: Improvement to the Find & Replace dialog with Special Characters dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=101517 Buovjagachanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 101599] [EDITING] Inserting certain Unicode combining characters causes text in paragraph to appear corrupted.
https://bugs.documentfoundation.org/show_bug.cgi?id=101599 Buovjagachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Buovjaga --- Can you copy and paste to a comment the contents of your Help - About LibreOffice? Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the information. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101764] constantly crashing while typing
https://bugs.documentfoundation.org/show_bug.cgi?id=101764 Buovjagachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #4 from Buovjaga --- (In reply to Julien Nabet from comment #3) > Would it be possible you follow advice from > https://wiki.documentfoundation.org/QA/FirstSteps ? Set to NEEDINFO. Change back to UNCONFIRMED after you have done what was requested. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101763] All previous documents became "read only" and I could not unlock them.
https://bugs.documentfoundation.org/show_bug.cgi?id=101763 Buovjagachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Buovjaga --- Would you be willing to try with 5.2.1? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: export-validation in tests by default causing 32 bit Ubuntu to crash
The error "- failed to execute: sh /core/bin/officeotron.sh /tmp/lu16851plw1cl.tmp > /tmp/lu16851plw1cn.tmp" along with an apport crash report of openjdk 8, led me to believe this was a java issue. Here are a summary of my results: Ubuntu 16.04 64-bit - builds successfully Ubuntu 16.04 32-bit - fails ww8export.test Ubuntu 14.04 32-bit - builds successfully with Open JDK 7 I build an Ubuntu 16.04 32-bit with the export tests disabled. Then I opened all of the SdImportTest::testDocumentLayout tests and resaved and reloaded them. No problems. What else can I do to try to help you track this issue down? -- View this message in context: http://nabble.documentfoundation.org/export-validation-in-tests-by-default-causing-32-bit-Ubuntu-to-crash-tp4192925p4194512.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
What's the use of core/*/qa/unoapi/knownissues.xcl files?
Hi devs, Some qa subdirs have a unoapi/knownissues.xcl in it, e.g. http://opengrok.libreoffice.org/xref/core/sc/qa/unoapi/knownissues.xcl It seems that it contains a list of issues/bugs related to classes. I could not find where these files are actually used. Should they be removed? On a related note: The issue numbers in those files look like: i84702. I presume this references some old OpenOffice bugtracker. Is there any way of accessing the descriptions of these old bugs? I was looking for the history of a function in LO and it dated back to the OO era (2008). The commit message was quite non-descriptive of the reasons for the change, it just mentioned such a bug number. It would be useful to have the bug info for exploring the code in its context. Maarten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/FilterConfigCache.cxx |7 +++ vcl/source/filter/FilterConfigCache.hxx |1 + 2 files changed, 8 insertions(+) New commits: commit 39293397dd4438f62d989a6bd390ac8396b6ca17 Author: Noel GrandinDate: Thu Sep 22 21:39:48 2016 +0200 fix windows build by reverting part of commit c4cd079b8f613084a99a83b95c3968b65cbd8900 Author: Noel Grandin Date: Thu Sep 22 15:08:42 2016 +0200 loplugin:unusedmethods in sc..vcl Change-Id: I4d925532369b37e13d97edd907c12f59a350e6ea Reviewed-on: https://gerrit.libreoffice.org/29196 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/vcl/source/filter/FilterConfigCache.cxx b/vcl/source/filter/FilterConfigCache.cxx index 8a0678f..33f0aa9 100644 --- a/vcl/source/filter/FilterConfigCache.cxx +++ b/vcl/source/filter/FilterConfigCache.cxx @@ -370,6 +370,13 @@ OUString FilterConfigCache::GetImportFormatName( sal_uInt16 nFormat ) return OUString(""); } +OUString FilterConfigCache::GetImportFormatMediaType( sal_uInt16 nFormat ) +{ +if( nFormat < aImport.size() ) +return aImport[ nFormat ].sMediaType; +return OUString(""); +} + OUString FilterConfigCache::GetImportFormatShortName( sal_uInt16 nFormat ) { if( nFormat < aImport.size() ) diff --git a/vcl/source/filter/FilterConfigCache.hxx b/vcl/source/filter/FilterConfigCache.hxx index 0a6c537..eb32218 100644 --- a/vcl/source/filter/FilterConfigCache.hxx +++ b/vcl/source/filter/FilterConfigCache.hxx @@ -86,6 +86,7 @@ public: OUStringGetImportFilterName( sal_uInt16 nFormat ); OUStringGetImportFormatName( sal_uInt16 nFormat ); OUStringGetImportFormatExtension( sal_uInt16 nFormat, sal_Int32 nEntry = 0); +OUStringGetImportFormatMediaType( sal_uInt16 nFormat ); OUStringGetImportFormatShortName( sal_uInt16 nFormat ); OUStringGetImportWildcard( sal_uInt16 nFormat, sal_Int32 nEntry ); OUStringGetImportFilterType( sal_uInt16 nFormat ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91312] Anomalies applying conditional formatting (follow-on Bug 91229 )
https://bugs.documentfoundation.org/show_bug.cgi?id=91312 --- Comment #11 from Buovjaga--- gmarco: Markus very recently did a lot of work on conditional formatting. Some fixes went in just 2 days ago. So I decided to test with a fresh build and I can't reproduce the problems anymore. I see the full list of conditional formats and I do not get a warning from editing C3 condition. I see only a different issue: changing the condition (eg. from 5 to 6) for C3 does not update the cell display. You could try with a fresh 5.3 build: http://dev-builds.libreoffice.org/daily/master/Win-x86@42/current/ You could also test your bug 91229 with 5.3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102371] Background an inserted slide from file is not shown automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=102371 --- Comment #3 from Francisco--- Created attachment 127558 --> https://bugs.documentfoundation.org/attachment.cgi?id=127558=edit Screenshot 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102371] Background an inserted slide from file is not shown automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=102371 --- Comment #4 from Francisco--- Created attachment 127559 --> https://bugs.documentfoundation.org/attachment.cgi?id=127559=edit Screenshot 3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102371] Background an inserted slide from file is not shown automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=102371 --- Comment #2 from Francisco--- Created attachment 127557 --> https://bugs.documentfoundation.org/attachment.cgi?id=127557=edit Screenshot 1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102371] Background an inserted slide from file is not shown automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=102371 --- Comment #1 from Francisco--- Created attachment 127556 --> https://bugs.documentfoundation.org/attachment.cgi?id=127556=edit File 2 TesisContenido1.otp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102371] New: Background an inserted slide from file is not shown automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=102371 Bug ID: 102371 Summary: Background an inserted slide from file is not shown automatically Product: LibreOffice Version: 3.5.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: franciscoadriansanc...@gmail.com Created attachment 127555 --> https://bugs.documentfoundation.org/attachment.cgi?id=127555=edit File 1 After inserting one slide from a different file, the its background is not automatically shown, but one has to go to the context menu of the slide design to make it to appear. Steps: 0) Download both attachments, and open them with Impress: both have their corresponding image background, in white and bright blue with a thin gold line in between. 1) Open attached file no. 1, "TesisPortada.otp" 2) Goto "Insert" -> "File", and select the 2nd attached file, "TesisContenido1.otp". Result: The new slide hasn't any background image. Although all the text styles and position of its text boxes are placed ok. This is shown in screenshot 1. Workaround: 4) Right click over the new slide, and select "Slide" -> "Slide style". A window showing the master slides in the file appears. There are 2 of them, one has its corrosponding background, but the other is still white. This is shown in screenshot 2. 5) Exit the window clicking in the accepting the changes (even if we haven't made any). The slide now show its background. This is shown in screenshot 3 I have been able to reproduce this bug using LibreOffice 3.5.7, 4.4.7 and 5.2.1. It's probably inherited from OpenOffice.org. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102370] New: Exponent without sign can be exported to Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=102370 Bug ID: 102370 Summary: Exponent without sign can be exported to Excel Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jumbo4...@yahoo.fr User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0 Build Identifier: 5.0.4 Resolution of bug 95677 was not correct: actually Excel does support exponent without sign (for positive exponent) with minus sign instead of plus sign. For instance, format 0.00E-00 represents PI() as 3.14E00 Reproducible: Always Steps to Reproduce: 1. Format > Cells > Number > Scientific 2. Remove sign in exponent, for instance 0.00E00 3. Export to Excel format 4. File > Reload Actual Results: Format is changed to 0.00E+00 Expected Results: Format should remain without sign in exponent Format 0.00E-00 is correctly interpreted during import of Excel file, but fails during export to ODF: it is modified in 0.00E+00 Reset User Profile?No -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91584] Navigationbar in forms show different (both wrong) values, if it's a formcontrol or a toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=91584 rob...@familiegrosskopf.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from rob...@familiegrosskopf.de --- Have tested again. It is fixed by the same commit as bug 82591 since LO 5.0. See comment 6. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svl/source
svl/source/inc/poolio.hxx | 13 +++-- svl/source/items/poolio.cxx | 10 ++ 2 files changed, 21 insertions(+), 2 deletions(-) New commits: commit c30fbfba96ab2d8d6229d7f4010718bd2b3c97d9 Author: Jochen NitschkeDate: Thu Sep 22 13:27:55 2016 +0200 tdf#75757 remove inheritance from std::vector Change-Id: Ief06d3ea0288e8ebf34f2f67f3d1dfc9405b6d49 Reviewed-on: https://gerrit.libreoffice.org/29180 Reviewed-by: Jochen Nitschke Tested-by: Jochen Nitschke diff --git a/svl/source/inc/poolio.hxx b/svl/source/inc/poolio.hxx index 627fd6b..0dd561e 100644 --- a/svl/source/inc/poolio.hxx +++ b/svl/source/inc/poolio.hxx @@ -68,11 +68,12 @@ typedef std::shared_ptr< SfxPoolVersion_Impl > SfxPoolVersion_ImplPtr; * often search linearly to ensure uniqueness. If they are * non-poolable we maintain an (often large) list of pointers. */ -struct SfxPoolItemArray_Impl: public SfxPoolItemArrayBase_Impl +struct SfxPoolItemArray_Impl { typedef std::vector FreeList; typedef std::unordered_map PoolItemPtrToIndexMap; - +private: +std::vector maPoolItemVector; public: /// Track list of indices into our array that contain an empty slot FreeList maFree; @@ -80,6 +81,14 @@ public: PoolItemPtrToIndexMap maPtrToIndex; SfxPoolItemArray_Impl () {} +SfxPoolItem*& operator[](size_t n) {return maPoolItemVector[n];} +std::vector ::iterator begin() {return maPoolItemVector.begin();} +std::vector ::iterator end() {return maPoolItemVector.end();} +/// clear array of PoolItem variants after all PoolItems are deleted +/// or all ref counts are decreased +void clear(); +size_t size() const {return maPoolItemVector.size();} +void push_back(SfxPoolItem* pItem) {maPoolItemVector.push_back(pItem);} /// re-build the list of free slots and hash from clean void SVL_DLLPUBLIC ReHash(); diff --git a/svl/source/items/poolio.cxx b/svl/source/items/poolio.cxx index ec23690..43e401d 100644 --- a/svl/source/items/poolio.cxx +++ b/svl/source/items/poolio.cxx @@ -30,6 +30,16 @@ #include #include +/// clear array of PoolItem variants +/// after all PoolItems are deleted +/// or all ref counts are decreased +void SfxPoolItemArray_Impl::clear() +{ +maPoolItemVector.clear(); +maFree.clear(); +maPtrToIndex.clear(); +} + /** * Returns the that is being saved. * This should only be used in very exceptional cases e.g. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source
svl/source/inc/poolio.hxx |4 +++- svl/source/items/itempool.cxx |4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) New commits: commit b0eecd2d3ba4a1a424a2d52cccf64fe6fc09c34b Author: Noel GrandinDate: Thu Sep 22 21:12:59 2016 +0200 Revert "remove SfxPoolItemArrayBase_Impl typedef" This reverts commit d141d5b3bd11ba6154b5d064fb69900405724b13. seems like I pushed it too soon, it depends on other commits not in yet. diff --git a/svl/source/inc/poolio.hxx b/svl/source/inc/poolio.hxx index ec3ec83..627fd6b 100644 --- a/svl/source/inc/poolio.hxx +++ b/svl/source/inc/poolio.hxx @@ -58,6 +58,8 @@ struct SfxPoolVersion_Impl {} }; +typedef std::vector SfxPoolItemArrayBase_Impl; + typedef std::shared_ptr< SfxPoolVersion_Impl > SfxPoolVersion_ImplPtr; /** @@ -110,7 +112,7 @@ struct SfxItemPool_Impl boolmbPersistentRefCounts; SfxItemPool_Impl( SfxItemPool* pMaster, const OUString& rName, sal_uInt16 nStart, sal_uInt16 nEnd ) -: maPoolItems(nEnd - nStart + 1) +: maPoolItems(nEnd - nStart + 1, static_cast (nullptr)) , aName(rName) , maPoolDefaults(nEnd - nStart + 1) , ppStaticDefaults(nullptr) diff --git a/svl/source/items/itempool.cxx b/svl/source/items/itempool.cxx index 7a38d45..6f4a6f2 100644 --- a/svl/source/items/itempool.cxx +++ b/svl/source/items/itempool.cxx @@ -646,7 +646,7 @@ const SfxPoolItem& SfxItemPool::Put( const SfxPoolItem& rItem, sal_uInt16 nWhich pItemArr = pImpl->maPoolItems[nIndex]; } -std::vector ::iterator ppFree; +SfxPoolItemArrayBase_Impl::iterator ppFree; bool ppFreeIsSet = false; // Is this a 'poolable' item - ie. should we re-use and return @@ -693,7 +693,7 @@ const SfxPoolItem& SfxItemPool::Put( const SfxPoolItem& rItem, sal_uInt16 nWhich // Unconditionally insert; check for a recently freed place if (pItemArr->maFree.size() > 0) { -auto itr = pItemArr->begin(); +SfxPoolItemArrayBase_Impl::iterator itr = pItemArr->begin(); sal_uInt32 nIdx = pItemArr->maFree.back(); pItemArr->maFree.pop_back(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source
svl/source/inc/poolio.hxx |4 +--- svl/source/items/itempool.cxx |4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) New commits: commit d141d5b3bd11ba6154b5d064fb69900405724b13 Author: Jochen NitschkeDate: Thu Sep 22 13:58:14 2016 +0200 remove SfxPoolItemArrayBase_Impl typedef Change-Id: Id4d3f80b3906395838afaffb2b0d00437d17f6dd Reviewed-on: https://gerrit.libreoffice.org/29182 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/svl/source/inc/poolio.hxx b/svl/source/inc/poolio.hxx index 627fd6b..ec3ec83 100644 --- a/svl/source/inc/poolio.hxx +++ b/svl/source/inc/poolio.hxx @@ -58,8 +58,6 @@ struct SfxPoolVersion_Impl {} }; -typedef std::vector SfxPoolItemArrayBase_Impl; - typedef std::shared_ptr< SfxPoolVersion_Impl > SfxPoolVersion_ImplPtr; /** @@ -112,7 +110,7 @@ struct SfxItemPool_Impl boolmbPersistentRefCounts; SfxItemPool_Impl( SfxItemPool* pMaster, const OUString& rName, sal_uInt16 nStart, sal_uInt16 nEnd ) -: maPoolItems(nEnd - nStart + 1, static_cast (nullptr)) +: maPoolItems(nEnd - nStart + 1) , aName(rName) , maPoolDefaults(nEnd - nStart + 1) , ppStaticDefaults(nullptr) diff --git a/svl/source/items/itempool.cxx b/svl/source/items/itempool.cxx index 6f4a6f2..7a38d45 100644 --- a/svl/source/items/itempool.cxx +++ b/svl/source/items/itempool.cxx @@ -646,7 +646,7 @@ const SfxPoolItem& SfxItemPool::Put( const SfxPoolItem& rItem, sal_uInt16 nWhich pItemArr = pImpl->maPoolItems[nIndex]; } -SfxPoolItemArrayBase_Impl::iterator ppFree; +std::vector ::iterator ppFree; bool ppFreeIsSet = false; // Is this a 'poolable' item - ie. should we re-use and return @@ -693,7 +693,7 @@ const SfxPoolItem& SfxItemPool::Put( const SfxPoolItem& rItem, sal_uInt16 nWhich // Unconditionally insert; check for a recently freed place if (pItemArr->maFree.size() > 0) { -SfxPoolItemArrayBase_Impl::iterator itr = pItemArr->begin(); +auto itr = pItemArr->begin(); sal_uInt32 nIdx = pItemArr->maFree.back(); pItemArr->maFree.pop_back(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits