Jenkins user and sending mails in gerrit

2018-03-14 Thread d . ostrovsky
I just saw mail from Christian, where he is claiming that Jenkins user can send mail to reviewers (I said the opposite), and is referencing this mail from his mailbox: X-Gerrit-ChangeURL: he got from Jenkins, where he is claiming he got the mail, even

Re: How to solve the libreoffice build error?

2014-07-09 Thread d . ostrovsky
On Wed Jul 9 06:19:04 PDT 2014, Zhen Anddavid wrote: I'm trying to build the LibreOffice 4.2.4.2 source. [...] --without-junit --disable-activex --disable-directx --enable-dbgutil Remove --disable-activex and it should work. David ___ LibreOffice

BuildBot BUG

2014-02-28 Thread d . ostrovsky
On Thu Feb 27 08:49:36 PST 2014, Alexandre Vicenzi wrote: Hi folks, The buildbot is adding broken links in the history. It's aways showing this link: https://ci.libreoffice.org/job/buildbot/0 Can someone take a look? Short story: we have found the problem and hope to solve it today. Long

Re: junit autogen error?

2013-11-19 Thread d . ostrovsky
On Tue Nov 19 00:11:49 PST 2013 Stephan Bergmann wrote: The best fix probably is to use javac with -classpath junit.jar for the check. You can use javap to check the existence of java classes in a JAR: $javap -classpath /Users/davido/Downloads/junit4.11/junit-4.11.jar org.hamcrest.Matcher

Re: Can't access logerrit buildbot logs

2013-10-07 Thread d . ostrovsky
Zitat von Florian Effenberger flo...@documentfoundation.org: Quick update from IRC: thanks for fixing that. Buildbot-Log@Jenkins is reachable again. [...] [2:01pm] floeff: that being said, CI is still marked as testing VM in our intranet. That's because Buildbot-logs deployment on VM4

Why not to use Gerrit patch set verification? -- was build failure in [build GAL] arrows

2013-06-17 Thread d . ostrovsky
On 17 June 2013, Matúš Kukan wrote: Indeed, sorry for this, there was missing dependency hopefully fixed with [...] it was broken for me too, while it was easy to fix with --without-galleries option, i wonder why you don't use Gerrit? Note: mmeeks knows how to schedule a build now and is

Re: Different Gerrit workflows -- was Master branch now requires liborcus 0.5.0 or higher.

2013-04-24 Thread d . ostrovsky
Quoting Norbert Thiebaud nthieb...@gmail.com: On Wed, Apr 24, 2013 at 2:02 AM, David Ostrovsky d.ostrov...@gmx.de wrote: On Tue Apr 23 18:19:55 PDT 2013, Norbert Thiebaud wrote: If you think that that list is missing someone(s) that are very present on IRC and could help cover the request,

Different Gerrit workflows

2013-04-23 Thread d . ostrovsky
On Tue Apr 23 05:43:20 PDT 2013, Stephan Bergmann wrote: On 04/21/2013 01:04 PM, David Ostrovsky wrote: So back to your use case: the content of your feature branch can be put on Gerrit for *only* verification (not wasting days or weeks but only 2 hours) with *one* command: git push logerrit

Re: Trouble creating logerrit account

2013-04-18 Thread d . ostrovsky
On Thu Apr 18 08:53:05 PDT 2013, Wols Lists wrote: How do I find out what name gerrit thinks I'm using, and how do I change it? RTFM: https://wiki.documentfoundation.org/Development/gerrit/setup#Setting_yourself_up_for_gerrit_-_the_easy_way see (even with link): 2. You must set your username

Re: claims of python unit test un-debugability considered somewhat exaggerated

2013-04-09 Thread d . ostrovsky
Quoting Michael Meeks michael.me...@suse.com: Michael - as/when a python unit test fails - can we make the magic environment variables that are listed include some debugging instructions that include the py-bt detail etc. so that everything needed is in the failure message ? when we're

Re: new gerrit-builds unit tests ...

2013-04-05 Thread d . ostrovsky
Quoting Norbert Thiebaud nthieb...@gmail.com: On Thu, Apr 4, 2013 at 4:27 PM, David Ostrovsky d.ostrov...@gmx.de wrote: * manual submit, currently only gerrit admin team can trigger it [4] the limiting factor being windows that take ~2 hours for a successful build, the 2 others take about 15

Re: gerrit's mail when adding a reviewer

2013-03-28 Thread d . ostrovsky
Quoting Stephan Bergmann sberg...@redhat.com: On 03/28/2013 10:22 AM, Bjoern Michaelsen wrote: On Wed, Mar 27, 2013 at 01:28:18PM +0100, Stephan Bergmann wrote: Just noticed that when I add a reviewer to somebody else's change, gerrit sends a mail taking on my identity (Stephan Bergmann (via

Re: Trouble building master with ccache on Windows

2013-03-20 Thread d . ostrovsky
Quoting Kohei Yoshida kohei.yosh...@gmail.com: On Tue, Mar 19, 2013 at 6:51 PM, David Ostrovsky d.ostrov...@idaia.de wrote: Anyway gcc-wrapper should work with ccache enabled now: https://gerrit.libreoffice.org/#/c/2857/ Yup, I confirm that it works now. :-) After thinking about it i

Re: make error

2013-03-20 Thread d . ostrovsky
Quoting Michael Stahl mst...@redhat.com: that is very odd, your javac does not understand -source and -target parameters. [...] that is not odd at all: http://linux.die.net/man/1/gcj the arguments are different there -fsource -ftarget and because it is not the first time someone fails into

Re: rtl::OUString::compareToAscii is dangerous

2013-03-20 Thread d . ostrovsky
Quoting Stephan Bergmann sberg...@redhat.com: On 03/19/2013 06:37 PM, Stephan Bergmann wrote: I apologize in advance for any remaining occurrences that my build didn't catch. (Where is the gerrit tinderbox trigger when one needs them?) Currently only gerrit admins can schedule gerrit

Re: make error

2013-03-20 Thread d . ostrovsky
Quoting Rene Engelhard r...@debian.org: On Wed, Mar 20, 2013 at 12:22:59PM +0100, d.ostrov...@idaia.de wrote: But why do we still stick to 1.5 source and target version of bytecode anyway? Wven when we didn't, you need to use =1.6 (if you built with java7) Which bring me to the question

Re: [PATCH libreoffice-4-0] fdo#55814 SwDoc::UpdateExpFlds: hiding the last section may ...

2013-03-20 Thread d . ostrovsky
Hi, Quoting Miklos Vajna (via Code Review) ger...@gerrit.libreoffice.org: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2876 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/2876/1 fdo#55814 SwDoc::UpdateExpFlds:

Re: cross-compiling and python

2013-03-05 Thread d . ostrovsky
On Tue Mar 5 Matus Kukan wrote: But I don't think we need to get rid ourselves of python-build-time dependency. Surely, at least on Linux and Windows, it is available. +1 Mac OS X 10.7.5 here: david@wizball python --version Python 2.7.1 so, i would say, just drop that feature of using

Re: moz module gbuildification?

2013-02-26 Thread d . ostrovsky
On Mon Feb 25, Andras Timar wrote: Did you try it on Windows with --enable-win-mozab-driver? For me the build failed, moz headers were not in place when connectivity module needed them. should be fixed now. David ___ LibreOffice mailing list

Re: issue building master: new dependency ?

2013-02-25 Thread d . ostrovsky
On Mon, Feb 25 Jean-Baptiste Faure wrote I do not think so: I get the same error after a ./g pull -r and a complete build (make clean make dev-install) i suspect this commit: 1baeaec3c98987fbedb6d02200fc4a95478adafb MinGW seems also to suffer here:

pending gbuild patches

2013-02-22 Thread d . ostrovsky
these pending gbuild patches [1], [2] move the location of main targets. Which actions should be taken (other then making it compile on windows ;-) prior to merging it, like uploading nightly build, odk publishing, etc.? [1] https://gerrit.libreoffice.org/#/c/2242/ [2]

mingw build is currently broken

2013-02-15 Thread d . ostrovsky
Hi, mingw build is seems to be broken on master: [...] [info ALL] LinkTarget Library/libbasebmplo.so not defined: Assuming headers to be there! 2774 NEXT /local/home/tinderbox/master-mingw/solenv/gbuild/Package.mk:44: *** gb_Deliver_deliver: file does not exist in solver, and cannot

Re: [Libreoffice-commits] core.git: 2 commits - setup_native/CustomTarget_scripts.mk

2013-02-11 Thread d . ostrovsky
Hi Thorsten, ah well, it was trying blind to fix it (hadn't access to a system with rpm package machinery), but somehow i wasn't sure in the end... ;-) David Zitat von Thorsten Behrens t...@documentfoundation.org: Hi David, both the below fixes are needed for a build to pass here - what

Re: Minutes of ESC call, January 31, 2012

2013-02-06 Thread d . ostrovsky
[...] + Unix / LDAP addressbook support disappeared: + https://bugs.freedesktop.org/show_bug.cgi?id=57417 + close that wontfix release-note it ? done: address book wizard dialog cleaned up, fdo#57417 closed wontfix, release notes updated:

Re: fdo#51004: some progress and 10 years old bug pending

2012-11-22 Thread d . ostrovsky
Quoting Mat M m...@gmx.fr: Le Wed, 21 Nov 2012 17:33:20 +0100, d.ostrov...@idaia.de a écrit: Quoting Stephan Bergmann sberg...@redhat.com: Further clean-up of all the Mozilla-related configure switches (--enable-mozilla, --disable-build-mozilla, --with-mozilla-toolkit,

Re: fdo#51004: some progress and 10 years old bug pending

2012-11-21 Thread d . ostrovsky
Quoting Stephan Bergmann sberg...@redhat.com: Further clean-up of all the Mozilla-related configure switches (--enable-mozilla, --disable-build-mozilla, --with-mozilla-toolkit, --with-system-mozilla, --with-mozilla-build) and config_host.mk.in variables (BUILD_MOZAB,

Re: cppumaker crash ...

2012-11-13 Thread d . ostrovsky
Hi Michael, Quoting Michael Meeks michael.me...@suse.com: On Tue, 2012-11-13 at 11:49 +0100, Michael Stahl wrote: I guess some include flags changed somewhere :-) still chasing. boost was added to tail_build recently, so it could possibly be caused by a missing dependency, i.e.

Re: fdo#51004: some progress and 10 years old bug pending

2012-11-09 Thread d . ostrovsky
Quoting Stephan Bergmann sberg...@redhat.com: On 11/09/2012 08:48 AM, David Ostrovsky wrote: * deprecate moz shipping as it may be needed for some extensions. That why Stephan reverted my patch: don't compile moz module on all non windows platforms Which commit are you talking about here?

Change in core[master]: restore --enable-symbols option again -- was FYI: Cleanup of debug options

2012-11-07 Thread d . ostrovsky
[bringing the discussion to ML as it related to other thread on this topic] Quoting Lubos Lunák (via Code Review) ger...@gerrit.libreoffice.org: Lubos Lunák has posted comments on this change. Change subject: restore --enable-symbols option again

Re: no functional TinderBox for master/3-7 full Windows builds

2012-10-31 Thread d . ostrovsky
Zitat von V Stuart Foote vstuart.fo...@utsa.edu: I know every body's busy, but any chance that one of the three TinderBox's for Windows master/3-7 can be brought back on line? TB 16 doesn't build the full Windows bundle. can't help you with tinderboxes, but i am doing irregularly windows

RE: no functional TinderBox for master/3-7 full Windows builds

2012-10-31 Thread d . ostrovsky
Quoting V Stuart Foote vstuart.fo...@utsa.edu: Thanks David! you are welcome! So, I gave the Win2008 VC10 0build a go, but it seems like java support may not be in your build either. Or at least Tools - Options - Advanced - Java Options is not detecting the installed JRE. It is

gbuildification of expat

2012-10-24 Thread d . ostrovsky
Hi, during gbuildification of expat special treatment is needed to produce 64 bit libs for windows, because 64 bit expat is used there for 64 bit shell extensions: https://gerrit.libreoffice.org/#/c/867/ To test it we need 64 bit OS and VS Professional. While i tested gbuildified expat

Re: ndtbl.cxx unused?

2012-10-23 Thread d . ostrovsky
Hi, Quoting David Tardon dtar...@redhat.com: Hi, On Tue, Oct 23, 2012 at 10:05:48AM +0200, Miklos Vajna wrote: Hi David, On Tue, Oct 23, 2012 at 07:01:36AM +0200, David Tardon dtar...@redhat.com wrote: If a source file really contained only unused functions, it would likely have been

Re: Error on rebuild in Windows cp: missing destination file operand after

2012-10-16 Thread d . ostrovsky
Hi, Quoting David Tardon dtar...@redhat.com: Basically it seems that in the command: cp $W/Extension/report-builder/root it's missing the first operand It is a use case that nobody has ever tried before, because en-US is the default language. The line comes from

Re: Error on rebuild in Windows cp: missing destination file operand after

2012-10-16 Thread d . ostrovsky
Hi, Quoting David Tardon dtar...@redhat.com: Hi, On Tue, Oct 16, 2012 at 11:38:28AM +0200, Stephan Bergmann wrote: On 10/16/2012 11:14 AM, d.ostrov...@idaia.de wrote: the easiest way to sort this out would be to add a check in configure.in for that: if --with-lang=en-US then fail or unset

Re: fdo#51004: some progress and 10 years old bug pending

2012-10-09 Thread d . ostrovsky
Hi Michael, Quoting Michael Meeks michael.me...@suse.com: Of course - it would be -lovely- to have a native C++ unit test in dbaccess/qa/extras/ that we could use to do a few queries on a sample mork file and add that to our regression test suite :-) having more native-code dbaccess/ tests as

Re: Beanshell and Javascript extensions not registered in master build

2012-10-08 Thread d . ostrovsky
Hi, Quoting Alexander Thurgood alex.thurg...@gmail.com: Le 07/10/12 22:59, Alex Thurgood a écrit : I used the --enable-ext switches on both OSX and Linux 32bit - same result, no functional beanshell or javascript extensions loaded, however the build doesn't report any errors, even if I make

gerrit is missing work in progress feature -- was Re: Change in core[master]: WORK IN PROGRESS gbuildification of jfreereport

2012-10-04 Thread d . ostrovsky
Quoting Norbert Thiebaud (via Code Review) ger...@gerrit.libreoffice.org: Norbert Thiebaud has posted comments on this change. Change subject: WORK IN PROGRESS gbuildification of jfreereport .. Patch Set 1: please to not

Re: gerrit is missing work in progress feature -- was Re: Change in core[master]: WORK IN PROGRESS gbuildification of jfreereport

2012-10-04 Thread d . ostrovsky
Quoting Norbert Thiebaud nthieb...@gmail.com: On Thu, Oct 4, 2012 at 4:30 AM, d.ostrov...@idaia.de wrote: as already discussed on IRC is review -1/-2 completely wrong here (well from my point of view!). Actualy gerrit is missing that WORK IN PROGRESS (WIP) feature. Fine, when gerrit acquire

Re: bundled saxon considered harmful

2012-10-04 Thread d . ostrovsky
Hi, Quoting David Tardon dtar...@redhat.com: It would be the committer's responsibility to build the extension and continue maintaining the code (if there is anything to maintain there :-) I suppose that unfortunate maintainer is going to be me, unless we decide to put the code in a repo under

Re: bundled saxon considered harmful

2012-10-04 Thread d . ostrovsky
Hi Norbert, Quoting Norbert Thiebaud nthieb...@gmail.com: On Thu, Oct 4, 2012 at 7:37 AM, d.ostrov...@idaia.de wrote: Hi, Quoting David Tardon dtar...@redhat.com: It would be the committer's responsibility to build the extension and continue maintaining the code (if there is anything to

Re: bundled saxon considered harmful

2012-10-04 Thread d . ostrovsky
Hi, Quoting David Tardon dtar...@redhat.com: Note that it is possible it will never be needed by anyone. I have already said I do not know of any existing XSLT filter that uses XSLT 2.0. But there was demand for it back in OO.o times and it was one of the reasons for switch from xerces to

Re: Drop support for Java 5?

2012-10-02 Thread d . ostrovsky
Hi Michael, Zitat von Michael Meeks michael.me...@suse.com: On Tue, 2012-10-02 at 14:53 +0200, Michael Stahl wrote: Mac OSX 10.4 only comes with 1.5. what about to drop support for Mac OS X 10.4 then? that is on the LO4 todo list :) Worth adding to the wiki page so we don't

Re: --with-lang build failure

2012-09-25 Thread d . ostrovsky
Quoting Andras Timar tima...@gmail.com: I had the same problem today. In workdir\unxlngx6.pro\CustomTarget\translations\translate\sdf-l10n\ directory language sdf files were 0 bytes long. When I rebuilt translations module alone, the problem disappeared. I suspect that it will come back after

new mork driver: regex match logic is required

2012-09-21 Thread d . ostrovsky
Hi, regex match logic is required in the new mork driver. In the old one it was done in xpcom seamonkey backend. For now it is not implemented: http://cgit.freedesktop.org/libreoffice/core/tree/connectivity/source/drivers/mork/MQueryHelper.cxx#n330 Any help (or patch) is highly appreciated ;-)

preventing gerrit changes from being merged

2012-09-20 Thread d . ostrovsky
Hi, recently some gerrit changes were accidentally merged into master through gerrit UI. While there are ways to prevent it, like voting -2 for a change or prefixing the commit message with work in progress, please don't merge or something like that, I want to share with you the gerrit

Re: sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-19 Thread d . ostrovsky
Quoting Stephan Bergmann sberg...@redhat.com: On 09/18/2012 12:14 AM, Norbert Thiebaud wrote: [...] for 2/ I propose to create a file 'lo.h', in solenv/inc/ for now... and start to bring all source code in conformance... [...] I'm not sure such a lo.h combining inclusion of multiple other

Re: sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-19 Thread d . ostrovsky
Hi Noel, Quoting Noel Grandin n...@peralex.com: On 2012-09-19 15:27, d.ostrov...@idaia.de wrote: --disable-cve-tests CVE unit tests still prevent me from be able to compile LO on windows with activated antivirus. Someone wanted implement it? Who was it? Mat M. or me? ;-) Note: once we

Re: feature/gbuild_ure needs testing

2012-09-19 Thread d . ostrovsky
Hi David, Quoting David Tardon dtar...@redhat.com: [...] I do not suppose I am going to get any more testers for the branch, so I am going to merge it to master in a couple of days (most probably on Saturday). Thanks everyone involved (especially Matus) for testing! clean build on mingw

fdo#51004: some progress and 10 years old bug pending

2012-09-17 Thread d . ostrovsky
Hi, there is some progress with that issue: https://bugs.freedesktop.org/show_bug.cgi?id=51004 Note: the situation on debian/ubuntu is really serious, because they are not shipping somehow strange hacked mozilla version at all. You can find some funny comments on that 10 year old bug:

Re: git review

2012-08-09 Thread d . ostrovsky
Quoting Norbert Thiebaud nthieb...@gmail.com: On Thu, Aug 9, 2012 at 7:04 AM, Bjoern Michaelsen Thinking a bit about this, another possibility would be to do with git-review as we do with other external stuff: Downloading and installing a local copy in ./download. That would ensure it

Re: mingw build broken

2012-07-31 Thread d . ostrovsky
Hey Kendy, thank you for your response. Yeah, my wine-* packages were outdated (1.4.*, we could check it in configure). After upgrading winegcc is working again, and after ccache -C (@David tnank you for that hint) LO even compiles, but ... cd /tmp/xfUNKMLKsY_temp.11871; tar -cf - . | gzip

Re: [PATCH] set WINEGCC only when cross compiling

2012-07-27 Thread d . ostrovsky
Hey Kendy, np, i had to do something, because my (native) build on Ubuntu was failing with the error: building msi package failed ;-) it turned out that msi was trying to build, because WINEGCC was unconditionally set during configuration process. That why i fixed it in that way. I hope,

Gerrit: branch libreoffice-3-6-0 is out of sync -- was Re: [REVIEW][3-6-0] Re: [PATCH] Change in core[libreoffice-3-6]: fdo#39812: Writer: fix collapsing merged table border painti...

2012-07-24 Thread d . ostrovsky
Hi Michael, Quoting Michael Stahl mst...@redhat.com: i'm trying to push this to gerrit libreoffice-3-6-0, but git-review warns me that it wants to push not 1 but ~10 patches; apparently the libreoffice-3-6-0 branch on gerrit is not automatically updated? indeed, as you can see here

Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review

2012-06-21 Thread d . ostrovsky
Zitat von Bjoern Michaelsen bjoern.michael...@canonical.com: Something like: - a short dialy digest of changes to keep reviewers in the loop - _one_ mail once a change goes in with all the comments/revisions and back-and-forth for this change in context in it or something completely

Re: feature/gbuild_merge needs testing

2012-05-25 Thread d . ostrovsky
Hi Noel, thank you for your help! [ build ECH ] CustomTarget/testtools/bridgetest/bridgetest_server.bat make[2]: *** No rule to make target `D:/workdir/wntmsci12.pro/CustomTarget/testtools/bridgetest/bridgetest_javaserver.bat', needed by

Re: building master against mac 10.7.4 using the 10.6 SDK

2012-05-22 Thread d . ostrovsky
Hej Christian, Zitat von Christian Lohmaier lohmaier+libreoff...@googlemail.com: HI Jonathan, *, On Tue, May 22, 2012 at 11:39 AM, Jonathan Aquilina eagles051...@gmail.com wrote: I am trying to build master on my mac using clang. The topic doesn't make any sense, you cannot build

Re: Branch 'feature/gbuild_testtools' - win mac test request

2012-05-21 Thread d . ostrovsky
Zitat von Norbert Thiebaud nthieb...@gmail.com: On Mon, May 21, 2012 at 1:52 AM, David Ostrovsky david.ostrov...@gmx.de wrote: Hi, with help of David T. Stephan and Matúš this branch can be merged to master. It would be really nice, if some of you with win mac could test it. If we do not

Re: [PATCH] make, use mixed paths on cygwin, remove ugly paths conversion

2012-05-09 Thread d . ostrovsky
Hi, +1 for this. This simplify enormously the whole build. The only question is, can we require, that all Windows build machines have make 3.82 installed? Ciao David Zitat von Noel Grandin n...@peralex.com: Hi Any chance we can get this in so I can get my tinderbox running on a

Re: help with windows tinbuild and symlinks

2012-05-04 Thread d . ostrovsky
Zitat von Noel Grandin n...@peralex.com: Thanks. With your patch and Michael's hack patch, I can get as far as building l10ntools, where it seems to be failing because of the recent gbuild-ification. Could you please provide error log? Ciao David

Re: help with windows tinbuild and symlinks

2012-05-04 Thread d . ostrovsky
Zitat von Noel Grandin n...@peralex.com: On 2012-05-04 14:11, d.ostrov...@idaia.de wrote: Could you please provide error log? Error looks like the isatty() definition is missing somehow? Perhaps an include path thing? Could you please compile idlc module (with make verbose=t to see

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread d . ostrovsky
Zitat von Lubos Lunak l.lu...@suse.cz: On Tuesday 24 of April 2012, Stephan Bergmann wrote: On 04/23/2012 06:17 PM, Petr Mladek wrote: I am not sure but I think that strip reduces size of binaries even when you build without -g. It just removes something less important. strip removes the

Re: make check problem in libtest_smoketest building master

2012-04-12 Thread d . ostrovsky
Zitat von Michael Stahl mst...@redhat.com: On 12/04/12 12:32, Noel Grandin wrote: On 2012-04-12 11:51, Stephan Bergmann wrote: What is the output of readelf -d workdir/unxlngx6.pro/LinkTarget/CppunitTest/libtest_smoketest.so for you? Output attached. 0x0001 (NEEDED)