[libvirt] [PATCH v1 4/4] xlconfigtest: add test for channel conversion

Signed-off-by: Joao Martins --- tests/xlconfigdata/test-channel-pty.cfg | 13 tests/xlconfigdata/test-channel-pty.xml | 33 +++ tests/xlconfigdata/test-channel-unix.cfg | 13

[libvirt] [PATCH v1 0/4] libxl: channels support

Hey, Channels have been on xen toolstack since Xen 4.5 and this small series adds support for it, including xenconfig conversion and appropriate tests. After this series it's possible to do this: (assuming correct configuration of qemu agent in the guest) $ cat domain.xml | grep -a1 channel |

[libvirt] [PATCH v1 3/4] xenconfig: channels conversion support

Add support for formating/parsing libxl channels. Syntax on xen libxl goes as following: channel=["connection=pty|socket,path=/path/to/socket,name=XXX",...] Signed-off-by: Joao Martins --- src/xenconfig/xen_xl.c | 176 +

[libvirt] [PATCH v1 2/4] libxl: channels support

And allow libxl to handle channel element which creates a Xen console visible to the guest as a low-bandwitdh communication channel. If type is PTY we also fetch the tty after boot using libxl_channel_getinfo to fetch the tty path. Since support for libxl channels only came on Xen >= 4.5 we

[libvirt] [PATCH v1 1/4] conf: add xen type for channels

So far only guestfwd and virtio were supported. Add an additional for Xen as libxl channels create Xen console visible to the guest. Signed-off-by: Joao Martins --- docs/schemas/domaincommon.rng | 11 +++ src/conf/domain_conf.c| 18 ++

Re: [libvirt] [PATCH 1/2] libxl: add support for PVH

On Fri, Sep 16, 2016 at 04:39:23PM -0600, Jim Fehlig wrote: > On 08/05/2016 12:05 PM, Marek Marczykowski-Górecki wrote: > > Since this is something between PV and HVM, it makes sense to put the > > setting in place where domain type is specified. > > To enable it, use It is > > also included

Re: [libvirt] [PATCH 2/2] libxl: set shadow memory for any guest type, not only HVM

On 08/05/2016 12:05 PM, Marek Marczykowski-Górecki wrote: > Otherwise starting PVH guest will result in "arch_setup_bootlate: > mapping shared_info failed (pfn=..., rc=-1, errno: 12): Internal error". > > After this change the behaviour is the same as in `xl`. > > Signed-off-by: Marek

Re: [libvirt] [PATCH 1/2] libxl: add support for PVH

On 08/05/2016 12:05 PM, Marek Marczykowski-Górecki wrote: > Since this is something between PV and HVM, it makes sense to put the > setting in place where domain type is specified. > To enable it, use It is > also included in capabilities.xml, for every supported HVM guest type - it > doesn't

Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities

On 09/12/2016 04:50 AM, Michal Privoznik wrote: > On 20.07.2016 21:08, Joao Martins wrote: >> Hey, >> >> This small series implements host cpu description in caps, by getting >> topology and xen hwcaps parsing done, followed by having >> cpu-{compare,baseline} APIs implemented. Last thing missing

Re: [libvirt] [PATCH][RFC] enable modification of xml in case of a restore forthe combination of xen/libvirt

On 09/12/2016 04:47 AM, guido.rossmuel...@gdata.de wrote: > Hello everybody, Hi, thanks for the patch! But I'm sorry to report that your mailer has mangled it. Please use 'git send-email' for sending patches. Refer to the contributors guideline for more info http://libvirt.org/hacking.html > >

Re: [libvirt] xen/libvirt freeze while attching network-device to vm´s - question about provided patches

On 09/09/2016 09:43 AM, Andrea Bolognani wrote: > On Thu, 2016-09-08 at 14:04 +, guido.rossmuel...@gdata.de wrote: >> Hello everybody, >> >> a colleague of me described last november a problem that we have with >> libvirt and xen >> >>

Re: [libvirt] [PATCH] qemu-migration: Disallow migration of read only disk

On 09/14/2016 10:40 AM, Daniel P. Berrange wrote: On Wed, Sep 14, 2016 at 10:37:07AM -0400, Corey S. McQuay wrote: Currently Libvirt allows attempts to migrate read only disks. Qemu cannot handle this as read only disks cannot be written to on the destination system. The end result is a

Re: [libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

2016-09-16 21:06 GMT+02:00 Matthias Bolte : > [please don't top-post] > > 2016-09-16 20:11 GMT+02:00 Jason Miesionczek : >> Not sure I understand what you mean by ‘not adding the string table’. Could >> you please elaborate? >> >> I

Re: [libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

[please don't top-post] 2016-09-16 20:11 GMT+02:00 Jason Miesionczek : > Not sure I understand what you mean by ‘not adding the string table’. Could > you please elaborate? > > I understand what you are saying about splitting things up into more logical > chunks, by

Re: [libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

Not sure I understand what you mean by ‘not adding the string table’. Could you please elaborate? I understand what you are saying about splitting things up into more logical chunks, by topic, so i will do that for the patches going forward. Thanks for your feedback, i’m still pretty new to C

Re: [libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

2016-09-16 18:35 GMT+02:00 Jason Miesionczek : > Second round of patches based on recently complete code review. Going > to submit patches in much smaller chunks, starting with this one. Future > patches will be submitted as each previous patch is reviewed and merged.

Re: [libvirt] [PATCH 07/16] hyperv: implement ability to send xml soap requests

2016-08-09 14:39 GMT+02:00 Jason Miesionczek : > also added ability to get/set auto start > --- > src/hyperv/hyperv_driver.c | 101 +++ > src/hyperv/hyperv_wmi.c| 670 > - > src/hyperv/hyperv_wmi.h| 58 >

Re: [libvirt] [PATCH] hyperv: add new WMI classes and improve generator

2016-09-16 18:35 GMT+02:00 Jason Miesionczek : > --- > src/hyperv/hyperv_wmi_generator.input | 485 > ++ > src/hyperv/hyperv_wmi_generator.py| 57 +++- > 2 files changed, 539 insertions(+), 3 deletions(-) > I've already pushed a

[libvirt] [PATCH v2a] HyperV: Improve 2008, introduce 2012

Second round of patches based on recently complete code review. Going to submit patches in much smaller chunks, starting with this one. Future patches will be submitted as each previous patch is reviewed and merged. Jason Miesionczek (1): hyperv: add new WMI classes and improve generator

[libvirt] [PATCH] hyperv: add new WMI classes and improve generator

--- src/hyperv/hyperv_wmi_generator.input | 485 ++ src/hyperv/hyperv_wmi_generator.py| 57 +++- 2 files changed, 539 insertions(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_wmi_generator.input b/src/hyperv/hyperv_wmi_generator.input index

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On Fri, 2016-09-16 at 16:59 +0200, Laszlo Ersek wrote: > > The solution would be simple, there is no need to add a new video > > model 'virtio-gpu', we will use the existing model 'virtio', but > > depending on architecture and also whether it's primary or > > secondary video device we will use

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On 09/16/16 15:44, Andrea Bolognani wrote: > On Fri, 2016-09-16 at 15:20 +0200, Pavel Hrdina wrote: >>> There is something I wanted to clarify with Laszlo: is >>> virtio-gpu-pci ever going to be usable on other architectures >>> such as x86_64? Maybe it already is? Because if that's the >>> case,

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On 09/16/16 15:32, Martin Kletzander wrote: > On Fri, Sep 16, 2016 at 03:20:16PM +0200, Pavel Hrdina wrote: >> On Fri, Sep 16, 2016 at 03:06:18PM +0200, Andrea Bolognani wrote: >>> On Fri, 2016-09-16 at 14:43 +0200, Pavel Hrdina wrote: >>> > On Fri, Sep 16, 2016 at 09:30:23AM +0200, Laszlo Ersek

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On Fri, Sep 16, 2016 at 03:44:34PM +0200, Andrea Bolognani wrote: > On Fri, 2016-09-16 at 15:20 +0200, Pavel Hrdina wrote: > > > There is something I wanted to clarify with Laszlo: is > > > virtio-gpu-pci ever going to be usable on other architectures > > > such as x86_64? Maybe it already is?

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On 09/16/16 15:20, Pavel Hrdina wrote: > On Fri, Sep 16, 2016 at 03:06:18PM +0200, Andrea Bolognani wrote: >> On Fri, 2016-09-16 at 14:43 +0200, Pavel Hrdina wrote: >>> On Fri, Sep 16, 2016 at 09:30:23AM +0200, Laszlo Ersek wrote: Most of QEMU's PCI display device models, such as: >>> >>>

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On 09/16/16 15:06, Andrea Bolognani wrote: > On Fri, 2016-09-16 at 14:43 +0200, Pavel Hrdina wrote: >> On Fri, Sep 16, 2016 at 09:30:23AM +0200, Laszlo Ersek wrote: >>> Most of QEMU's PCI display device models, such as: >> >> Pushed, thanks. Thanks Pavel! > Ouch, you were too fast! ;) > >

Re: [libvirt] [PATCH v3 1/8] vsh: Fix NULL dereference leading to SIGSEGV if a command is missing '.info'

On 16/09/16 14:19, Ján Tomko wrote: > On Fri, Sep 16, 2016 at 12:50:38PM +0200, Erik Skultety wrote: >> Signed-off-by: Erik Skultety >> --- >> tools/vsh.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Is there a use-case for a command without info? > > I

Re: [libvirt] [PATCH v2 3/5] qemu: Add vhost-scsi string for -device parameter

On 09/13/2016 04:55 PM, John Ferlan wrote: [...] diff --git a/src/util/virscsi.c b/src/util/virscsi.c index 4843367..290b692 100644 --- a/src/util/virscsi.c +++ b/src/util/virscsi.c @@ -105,6 +105,32 @@ virSCSIDeviceGetAdapterId(const char *adapter, return -1; } +int

Re: [libvirt] [PATCH 00/20] 20 crazy IVSHMEM patches you won't believe compile

On Fri, Sep 16, 2016 at 15:17:34 +0200, Martin Kletzander wrote: > On Fri, Sep 16, 2016 at 02:22:19PM +0200, Peter Krempa wrote: > >On Thu, Sep 15, 2016 at 18:14:25 +0200, Martin Kletzander wrote: > >> Let's see if the subject works if one is in need of reviews =) > >> > >> Yet another qemu

Re: [libvirt] [PATCH 09/20] qemu: Save various defaults for shmem

On Fri, Sep 16, 2016 at 10:32:48AM +0200, Peter Krempa wrote: On Thu, Sep 15, 2016 at 18:14:34 +0200, Martin Kletzander wrote: When we change the device used for the shared memory, it should not change the settings, so rather save them upfront then having problems later. The only thing we are

Re: [libvirt] [PATCH v3 4/8] vsh: Extract vshCmddefCheckInternals from vshCmddefOptParse

On 16/09/16 13:58, Ján Tomko wrote: > On Fri, Sep 16, 2016 at 12:50:41PM +0200, Erik Skultety wrote: >> Originally introduced by commit 2432521e which correctly split >> vshCmddefOptParse into command's options validation and options parsing. >> However, command's 'internals' are not tied solely

Re: [libvirt] [PATCH 00/16] Hyper-V: Improve 2008, Introduce 2012

Thank you very much for your review and your excellent suggestions. I will revisit the code, clean things up as best I can and submit much smaller patches that can be reviewed and merged one at a time. Thanks again! Best, Jason Miesionczek > On Sep 15, 2016, at 5:56 PM, John Ferlan

Re: [libvirt] [PATCH 10/20] qemu: Disable migration for shmem with peer role

On Fri, Sep 16, 2016 at 10:16:31AM +0200, Peter Krempa wrote: On Thu, Sep 15, 2016 at 18:14:35 +0200, Martin Kletzander wrote: Such migration wouldn't work anyway with QEMU, we just haven't checked for it before. Signed-off-by: Martin Kletzander ---

Re: [libvirt] [PATCH] test driver: File test_driver.c was splitted into smaller files.

On 09/16/2016 08:30 AM, Daniel P. Berrange wrote: > On Fri, Sep 16, 2016 at 03:06:27PM +0200, Tomáš Ryšavý wrote: >> Because the file had over 7000 lines. Now its splitted into 5 >> smaller files. It looks clearer and it's better for reading the code. >> >> Signed-off-by: Tomáš Ryšavý

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On Fri, 2016-09-16 at 15:20 +0200, Pavel Hrdina wrote: > > There is something I wanted to clarify with Laszlo: is > > virtio-gpu-pci ever going to be usable on other architectures > > such as x86_64? Maybe it already is? Because if that's the > > case, we'll want to be able to choose between

Re: [libvirt] [PATCH 07/20] qemu: Add newer shmem models

On Fri, Sep 16, 2016 at 09:48:12AM +0200, Peter Krempa wrote: On Thu, Sep 15, 2016 at 18:14:32 +0200, Martin Kletzander wrote: The old ivshmem is deprecated in QEMU, so let's use the better ivshmem-{plain,doorbell} variants instead. Signed-off-by: Martin Kletzander ---

[libvirt] [PATCH 1/2] build: update to latest gnulib

In particular, pull in gnulib's fix for the broken AC_HEADER_MAJOR macro in autoconf. Signed-off-by: Eric Blake --- * .gnulib a2a3943...a512e04 (42): > sys_types: avoid glibc 2.25 warnings about major() > mountlist: include sysmacros.h for glibc > extensions: port to

[libvirt] [PATCH 0/2] Rawhide fix for major() in sys/types.h

Now that autoconf and gnulib have worked around the glibc 2.25 issue, we don't need our hack any more. I'll probably push in 24 hours under the gnulib-maintenance rule, if I don't get a review first. Eric Blake (2): build: update to latest gnulib Revert "configure: Check for major() more

[libvirt] [PATCH 2/2] Revert "configure: Check for major() more strictly"

This reverts commit d53fa838e18d8c192296487ff40c3a37420b6d06, which is no longer needed now that gnulib does the job. Signed-off-by: Eric Blake --- configure.ac | 3 --- 1 file changed, 3 deletions(-) diff --git a/configure.ac b/configure.ac index f322c4a..f6076bd 100644 ---

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On Fri, Sep 16, 2016 at 03:32:59PM +0200, Martin Kletzander wrote: > On Fri, Sep 16, 2016 at 03:20:16PM +0200, Pavel Hrdina wrote: > >On Fri, Sep 16, 2016 at 03:06:18PM +0200, Andrea Bolognani wrote: > >> On Fri, 2016-09-16 at 14:43 +0200, Pavel Hrdina wrote: > >> > On Fri, Sep 16, 2016 at

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On Fri, Sep 16, 2016 at 03:20:16PM +0200, Pavel Hrdina wrote: On Fri, Sep 16, 2016 at 03:06:18PM +0200, Andrea Bolognani wrote: On Fri, 2016-09-16 at 14:43 +0200, Pavel Hrdina wrote: > On Fri, Sep 16, 2016 at 09:30:23AM +0200, Laszlo Ersek wrote: > > Most of QEMU's PCI display device models,

Re: [libvirt] [PATCH] test driver: File test_driver.c was splitted into smaller files.

On Fri, Sep 16, 2016 at 03:06:27PM +0200, Tomáš Ryšavý wrote: > Because the file had over 7000 lines. Now its splitted into 5 > smaller files. It looks clearer and it's better for reading the code. > > Signed-off-by: Tomáš Ryšavý > --- > po/POTFILES.in

Re: [libvirt] [PATCH] test driver: File test_driver.c was splitted into smaller files.

On Fri, Sep 16, 2016 at 03:06:27PM +0200, Tomáš Ryšavý wrote: Because the file had over 7000 lines. Now its splitted into 5 smaller files. It looks clearer and it's better for reading the code. Similar to that, this patch has over .5 MiB, it could've been split into multiple patches. Not

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On Fri, Sep 16, 2016 at 03:06:18PM +0200, Andrea Bolognani wrote: > On Fri, 2016-09-16 at 14:43 +0200, Pavel Hrdina wrote: > > On Fri, Sep 16, 2016 at 09:30:23AM +0200, Laszlo Ersek wrote: > > > Most of QEMU's PCI display device models, such as: > >  > > Pushed, thanks. > > Ouch, you were too

Re: [libvirt] [PATCH 00/20] 20 crazy IVSHMEM patches you won't believe compile

On Fri, Sep 16, 2016 at 02:22:19PM +0200, Peter Krempa wrote: On Thu, Sep 15, 2016 at 18:14:25 +0200, Martin Kletzander wrote: Let's see if the subject works if one is in need of reviews =) Yet another qemu device, right? We even have an existing device for that, right? That should be pretty

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On Fri, 2016-09-16 at 14:43 +0200, Pavel Hrdina wrote: > On Fri, Sep 16, 2016 at 09:30:23AM +0200, Laszlo Ersek wrote: > > Most of QEMU's PCI display device models, such as: >  > Pushed, thanks. Ouch, you were too fast! ;) There is something I wanted to clarify with Laszlo: is virtio-gpu-pci

Re: [libvirt] [PATCH 41/41] Move CMT feature filtering to QEMU driver

On Tue, Aug 30, 2016 at 18:06:36 -0400, John Ferlan wrote: > > > On 08/12/2016 09:33 AM, Jiri Denemark wrote: > > It really doesn't belong to the generic CPU driver. > > > > Signed-off-by: Jiri Denemark > > --- > > src/cpu/cpu_x86.c| 16 ++-- > >

Re: [libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On Fri, Sep 16, 2016 at 09:30:23AM +0200, Laszlo Ersek wrote: > Most of QEMU's PCI display device models, such as: Pushed, thanks. Pavel -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 00/20] 20 crazy IVSHMEM patches you won't believe compile

On Thu, Sep 15, 2016 at 18:14:25 +0200, Martin Kletzander wrote: > Let's see if the subject works if one is in need of reviews =) > > Yet another qemu device, right? We even have an existing device for > that, right? That should be pretty straight-forward and easy, right? > Well, let's see...

Re: [libvirt] [PATCH 20/20] qemu: Add support for hot/cold-(un)plug of shmem devices

On Thu, Sep 15, 2016 at 18:14:45 +0200, Martin Kletzander wrote: > This is needed in order to migrate with ivshmem role='peer' as that is > not allowed to migrate. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_driver.c | 39 +++- >

Re: [libvirt] [PATCH v3 1/8] vsh: Fix NULL dereference leading to SIGSEGV if a command is missing '.info'

On Fri, Sep 16, 2016 at 12:50:38PM +0200, Erik Skultety wrote: Signed-off-by: Erik Skultety --- tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Is there a use-case for a command without info? I think all the commands should have a description and we

Re: [libvirt] [PATCH v3 8/8] virt-admin: Replace the (now) aliases with new command names in the man page

On Fri, Sep 16, 2016 at 12:50:45PM +0200, Erik Skultety wrote: Since the old command names are being shadowed by the new ones in the code as well as in the help messages, update the man page accordingly. Signed-off-by: Erik Skultety --- tools/virt-admin.pod | 30

Re: [libvirt] [PATCH v3 6/8] virt-admin: Tweak command parsing logic so that aliases point to new commands

On Fri, Sep 16, 2016 at 12:50:43PM +0200, Erik Skultety wrote: Change the logic in a way, so that VSH_CMD_FLAG_ALIAS behaves similarly to how VSH_OT_ALIAS for command options, i.e. there is no need for code duplication for the alias and the aliased command structures. Along with that change,

Re: [libvirt] [PATCH v3 7/8] virt-admin: Add some command aliases to provide syntax sugar over ugly commands

On Fri, Sep 16, 2016 at 12:50:44PM +0200, Erik Skultety wrote: Make use of the new recently introduced alias handling for virt-admin srv-* commands. Signed-off-by: Erik Skultety --- tools/virt-admin.c | 24 1 file changed, 24 insertions(+) ACK

Re: [libvirt] [PATCH 19/20] conf: Add some shmem helpers for future use

On Thu, Sep 15, 2016 at 18:14:44 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/conf/domain_conf.c | 75 > > src/conf/domain_conf.h | 9 ++ > src/libvirt_private.syms | 5 > 3

Re: [libvirt] [PATCH 18/20] qemu: Add qemuAssignDeviceShmemAlias and use it

On Thu, Sep 15, 2016 at 18:14:43 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_alias.c | 32 +++- > src/qemu/qemu_alias.h | 4 > 2 files changed, 35 insertions(+), 1 deletion(-) ACK -- libvir-list

Re: [libvirt] [PATCH 17/20] qemu: Support newer ivshmem device variants

On Thu, Sep 15, 2016 at 18:14:42 +0200, Martin Kletzander wrote: > QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are > reworked varians of legacy ivshmem that are compatible from the guest > POV, but not from host's POV and have sane specification and handling. > > Details

Re: [libvirt] [PATCH v3 5/8] vsh: discard vshCmddefOptFill and move its body to vshCmddefOptParse

On Fri, Sep 16, 2016 at 12:50:42PM +0200, Erik Skultety wrote: Recent changes extracted the command internals validation routine from vshCmddefOptParse method which now just calls vshCmddefOptFill. Therefore, make vshCmddefOptFill the new vshCmddefOptParse and drop the unnecessary name.

Re: [libvirt] [PATCH v3 4/8] vsh: Extract vshCmddefCheckInternals from vshCmddefOptParse

On Fri, Sep 16, 2016 at 12:50:41PM +0200, Erik Skultety wrote: Originally introduced by commit 2432521e which correctly split vshCmddefOptParse into command's options validation and options parsing. However, command's 'internals' are not tied solely to .options, rather it should be about the

Re: [libvirt] [PATCH v3 3/8] vsh: vshCmddefHelp: Retrieve command info after we know the command is non-NULL

On Fri, Sep 16, 2016 at 12:50:40PM +0200, Erik Skultety wrote: Recent changes discarded an unnecessary 'else' block from vshCmddefHelp. However, that also moved some var declarations as well as definitions to the beginning of the function block and now we're trying to retrieve command's .info

Re: [libvirt] [PATCH v3 2/8] vsh: vshCmddefHelp: Drop the unnecessary 'else' branch

On Fri, Sep 16, 2016 at 12:50:39PM +0200, Erik Skultety wrote: If the initial check is true the function immediately returns so there's no need to enclose the code following the check within an 'else' block. Also, by removing the 'else' block, the declarations need to be moved to beginning of

Re: [libvirt] [PATCH 40/41] qemu: Update guest CPU def in live XML

On Tue, Aug 30, 2016 at 17:58:56 -0400, John Ferlan wrote: ... > > @@ -3267,14 +3267,8 @@ qemuDomainDefFormatBuf(virQEMUDriverPtr driver, > > /* Update guest CPU requirements according to host CPU */ > > if ((flags & VIR_DOMAIN_XML_UPDATE_CPU) && > > def->cpu && > > -

Re: [libvirt] [PATCH 16/20] qemu: Rename qemuBuildShmemBackendStr to qemuBuildShmemBackendChrStr

On Thu, Sep 15, 2016 at 18:14:41 +0200, Martin Kletzander wrote: > There will be more backends in the future so let's not complicate it. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_command.c | 16 > 1 file changed, 8 insertions(+), 8

Re: [libvirt] [PATCH 15/20] qemu: Abstract shmem socket path preparation

On Thu, Sep 15, 2016 at 18:14:40 +0200, Martin Kletzander wrote: > Put it into qemuDomainPrepareShmemChardev() so it can be used later. This also adds a condition when the unix socket path is not generated when not required. You should mention this fix here. > > Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 14/20] qemu: Reorder shmem params nicely

On Thu, Sep 15, 2016 at 18:14:39 +0200, Martin Kletzander wrote: > Always format id first so that we don't need to do that twice in > different code paths. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_command.c| 6 -- >

[libvirt] [PATCH v3 8/8] virt-admin: Replace the (now) aliases with new command names in the man page

Since the old command names are being shadowed by the new ones in the code as well as in the help messages, update the man page accordingly. Signed-off-by: Erik Skultety --- tools/virt-admin.pod | 30 +++--- 1 file changed, 15 insertions(+), 15

[libvirt] [PATCH v3 5/8] vsh: discard vshCmddefOptFill and move its body to vshCmddefOptParse

Recent changes extracted the command internals validation routine from vshCmddefOptParse method which now just calls vshCmddefOptFill. Therefore, make vshCmddefOptFill the new vshCmddefOptParse and drop the unnecessary name. Signed-off-by: Erik Skultety --- tools/vsh.c | 25

[libvirt] [PATCH v3 4/8] vsh: Extract vshCmddefCheckInternals from vshCmddefOptParse

Originally introduced by commit 2432521e which correctly split vshCmddefOptParse into command's options validation and options parsing. However, command's 'internals' are not tied solely to .options, rather it should be about the overall structure, therefore the validation should be extracted from

[libvirt] [PATCH v3 7/8] virt-admin: Add some command aliases to provide syntax sugar over ugly commands

Make use of the new recently introduced alias handling for virt-admin srv-* commands. Signed-off-by: Erik Skultety --- tools/virt-admin.c | 24 1 file changed, 24 insertions(+) diff --git a/tools/virt-admin.c b/tools/virt-admin.c index

[libvirt] [PATCH v3 1/8] vsh: Fix NULL dereference leading to SIGSEGV if a command is missing '.info'

Signed-off-by: Erik Skultety --- tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index 4ee472c..3772d92 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -695,7 +695,7 @@ vshCmddefHelp(vshControl *ctl, const char

[libvirt] [PATCH v3 0/8] Introduce aliases for virt-admin's srv-* commands

the original version: https://www.redhat.com/archives/libvir-list/2016-September/msg00312.html v2: https://www.redhat.com/archives/libvir-list/2016-September/msg00380.html Since this series (compared to v2) does a tiny bit of refactor (tweaking might be a better word in this case) as well, I was

[libvirt] [PATCH v3 2/8] vsh: vshCmddefHelp: Drop the unnecessary 'else' branch

If the initial check is true the function immediately returns so there's no need to enclose the code following the check within an 'else' block. Also, by removing the 'else' block, the declarations need to be moved to beginning of the function block to conform with our guidelines. Signed-off-by:

[libvirt] [PATCH v3 3/8] vsh: vshCmddefHelp: Retrieve command info after we know the command is non-NULL

Recent changes discarded an unnecessary 'else' block from vshCmddefHelp. However, that also moved some var declarations as well as definitions to the beginning of the function block and now we're trying to retrieve command's .info element before actually checking whether we got a valid command or

[libvirt] [PATCH v3 6/8] virt-admin: Tweak command parsing logic so that aliases point to new commands

Change the logic in a way, so that VSH_CMD_FLAG_ALIAS behaves similarly to how VSH_OT_ALIAS for command options, i.e. there is no need for code duplication for the alias and the aliased command structures. Along with that change, switch any existing VSH_CMD_FLAG_ALIAS occurrences to this new

Re: [libvirt] [PATCH 39/41] cpu: Rework cpuCompare* APIs

On Tue, Aug 30, 2016 at 17:57:01 -0400, John Ferlan wrote: ... > > - * cpuCompareXML: > > + * virCPUCompareXML: > > * > > + * @arch: CPU architecture > > * @host: host CPU definition > > * @xml: XML description of either guest or host CPU to be compared with > > @host > > Existing,

[libvirt] [PATCH 5/5] qemu: agent: give better error messages whe agent monitor is down

We can receive NULL as sync reply in two situations. First is garbage sync reply and this situation is handled by resending sync message. Second is different cases of rebooting guest, destroing domain etc and we can give more meaningful error message. Actually we have this error message in

[libvirt] [PATCH 0/5] enforce and simplify qga interactions

First 2 patches fix bugs of libvirt - qga communication. They deal with the channel pecularities described in http://wiki.qemu.org/Features/QAPI/GuestAgent. First patch address https://bugzilla.redhat.com/show_bug.cgi?id=1090551 bug. Next 3 patches hide details of channel pecularities from

[libvirt] [PATCH 4/5] qemu: agent: reissue sync on garbage sync reply

We can easily handle receiving garbage on sync. We don't have to make client deal with this situation. We just need to resend sync command but this time garbage is not be possible. --- src/qemu/qemu_agent.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git

[libvirt] [PATCH 2/5] qemu: agent: ignore garbage while waiting for sync reply

After sync is sent we can receive garbare and this is not error. Consider next regular case: 1. libvirtd sends sync 2. qga sends partial sync reply and die 3. libvirtd sends sync 4. qga sends sync reply 5. libvirtd receives garbage (half of first reply and second reply together) We should

[libvirt] [PATCH 1/5] qemu: agent: ignore delayed reply when unsynced

Errors in qemuAgentIOProcessLine stop agent IO processing just like any regular IO error, however some of current errors that this functions spawns are false positives. Consider next case for example: 1. send sync (unsynced state) 2. receive sync reply (sync established) 3. command send, but

[libvirt] [PATCH 3/5] qemu: agent: skip outdated sync replies

When we wait for sync reply we can receive delayed reply to syncs or commands that were sent erlier. We can safely skip them until we receive sync reply with correct id. There is no much sense report this situation to client. Actually with a bit of "luck" if we involve client into this the play

Re: [libvirt] [PATCH 13/20] qemu: Move common checks outside qemuBuildShmemDevLegacyStr

On Thu, Sep 15, 2016 at 18:14:38 +0200, Martin Kletzander wrote: > Some checks will need to be performed for newer device types as well, so > let's not duplicate them. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_command.c | 54 >

Re: [libvirt] [PATCH 3/3] docs: drop todo.html

On Wed, 2016-08-03 at 18:30 +0200, Ján Tomko wrote: > There is little information value in: >   Todo list unavailable: no config file >  > Drop the file completely along with the script generating it. > --- >  .gitignore|   1 - >  docs/Makefile.am  |  34 ++ >  

Re: [libvirt] [PATCH 12/20] qemu: Rename qemuBuildShmemDevStr to qemuBuildShmemDevLegacyStr

On Thu, Sep 15, 2016 at 18:14:37 +0200, Martin Kletzander wrote: > This will make sense after adding support for newer device types. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_command.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) ACK --

Re: [libvirt] [PATCH 11/20] qemu: Make qemuBuildShmemDevStr static

On Thu, Sep 15, 2016 at 18:14:36 +0200, Martin Kletzander wrote: > It isn't used anywhere else. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_command.c | 2 +- > src/qemu/qemu_command.h | 4 > 2 files changed, 1 insertion(+), 5 deletions(-) ACK --

Re: [libvirt] [PATCH 10/20] qemu: Disable migration for shmem with peer role

On Thu, Sep 15, 2016 at 18:14:35 +0200, Martin Kletzander wrote: > Such migration wouldn't work anyway with QEMU, we just haven't checked > for it before. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_migration.c | 13 + > 1 file changed, 13

Re: [libvirt] [PATCH 06/20] qemu: Add support for shmem role

On Fri, Sep 16, 2016 at 09:22:39 +0200, Peter Krempa wrote: > On Thu, Sep 15, 2016 at 18:14:31 +0200, Martin Kletzander wrote: > > Signed-off-by: Martin Kletzander > > --- > > src/libvirt_private.syms | 2 ++ > > src/qemu/qemu_command.c

Re: [libvirt] [PATCH 08/20] qemu: Add capabilities for ivshmem-{plain, doorbell}

On Thu, Sep 15, 2016 at 18:14:33 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_capabilities.c| 4 > src/qemu/qemu_capabilities.h| 2 ++ >

Re: [libvirt] [PATCH 07/20] qemu: Add newer shmem models

On Fri, Sep 16, 2016 at 09:48:12 +0200, Peter Krempa wrote: > On Thu, Sep 15, 2016 at 18:14:32 +0200, Martin Kletzander wrote: > > The old ivshmem is deprecated in QEMU, so let's use the better > > ivshmem-{plain,doorbell} variants instead. > > > > Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 07/20] qemu: Add newer shmem models

On Thu, Sep 15, 2016 at 18:14:32 +0200, Martin Kletzander wrote: > The old ivshmem is deprecated in QEMU, so let's use the better > ivshmem-{plain,doorbell} variants instead. > > Signed-off-by: Martin Kletzander > --- > docs/schemas/domaincommon.rng | 2 ++ >

Re: [libvirt] [PATCH 05/20] conf: Add support for shmem role

On Fri, Sep 16, 2016 at 09:20:16AM +0200, Peter Krempa wrote: On Thu, Sep 15, 2016 at 18:14:30 +0200, Martin Kletzander wrote: Role controls how the domain behaves on migration. Signed-off-by: Martin Kletzander --- docs/formatdomain.html.in | 10

Re: [libvirt] [PATCH 04/20] conf: Add support for shmem model

On Fri, Sep 16, 2016 at 09:34:31 +0200, Martin Kletzander wrote: > On Fri, Sep 16, 2016 at 09:12:23AM +0200, Peter Krempa wrote: > >On Thu, Sep 15, 2016 at 18:14:29 +0200, Martin Kletzander wrote: > >> Just the default one now, new ones will be added in following commits. > >> > >> Signed-off-by:

Re: [libvirt] [PATCH 04/20] conf: Add support for shmem model

On Fri, Sep 16, 2016 at 09:12:23AM +0200, Peter Krempa wrote: On Thu, Sep 15, 2016 at 18:14:29 +0200, Martin Kletzander wrote: Just the default one now, new ones will be added in following commits. Signed-off-by: Martin Kletzander --- docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On Fri, Sep 16, 2016 at 09:23:30AM +0200, Laszlo Ersek wrote: On 09/16/16 08:28, Martin Kletzander wrote: On Fri, Sep 16, 2016 at 06:04:46AM +0200, Laszlo Ersek wrote: Most of QEMU's PCI display device models, such as: libvirt video/model/@type QEMU -device -

[libvirt] [PATCH v2] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

Most of QEMU's PCI display device models, such as: libvirt video/model/@type QEMU -device - cirrus cirrus-vga vgaVGA qxlqxl-vga virtio virtio-vga come with a

Re: [libvirt] [PATCH] qemu: map "virtio" video model to "virt" machtype correctly (arm/aarch64)

On 09/16/16 08:28, Martin Kletzander wrote: > On Fri, Sep 16, 2016 at 06:04:46AM +0200, Laszlo Ersek wrote: >> Most of QEMU's PCI display device models, such as: >> >> libvirt video/model/@type QEMU -device >> - >> cirrus cirrus-vga >>

Re: [libvirt] [PATCH 06/20] qemu: Add support for shmem role

On Thu, Sep 15, 2016 at 18:14:31 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/libvirt_private.syms | 2 ++ > src/qemu/qemu_command.c| 4 > tests/qemuxml2argvdata/qemuxml2argv-shmem.args | 4

Re: [libvirt] [PATCH 05/20] conf: Add support for shmem role

On Thu, Sep 15, 2016 at 18:14:30 +0200, Martin Kletzander wrote: > Role controls how the domain behaves on migration. > > Signed-off-by: Martin Kletzander > --- > docs/formatdomain.html.in | 10 +- > docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH 04/20] conf: Add support for shmem model

On Thu, Sep 15, 2016 at 18:14:29 +0200, Martin Kletzander wrote: > Just the default one now, new ones will be added in following commits. > > Signed-off-by: Martin Kletzander > --- > docs/schemas/domaincommon.rng | 9 + > src/conf/domain_conf.c

[libvirt] [PATCH] util: Expose virHostCPUStatsAssign on non-Linux

There is nothing Linux-specific in that function. Also since commit 8c3b5bf48123783b812b97360db7ac51f1889e17 mingw build is broken due to the fact that this function is not compiled in the library. Signed-off-by: Martin Kletzander --- Pushed as trivial build-breaker fix.

  1   2   >