[PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Jesper Juhl
Function names and return types on same line - conform to established fs/cifs/ style. Patch is also available at: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-funct.patch Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- linux-2.6.12-rc2-mm2-orig/fs/cifs/md5.c

[PATCH 2/3] cifs: md5 cleanup - spaces

2005-04-11 Thread Jesper Juhl
clean up spacing, redundant blank lines etc. patch is also at: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-spaces.patch Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- linux-2.6.12-rc2-mm2/fs/cifs/md5.c.with_patch1 2005-04-09 10:36:44.0 +0200 +++

Re: [ACPI] [2.6.12-rc2][suspend] Suspending Thinkpad: drive bay light in S3 mode stays on

2005-04-11 Thread Matthew Garrett
On Mon, 2005-04-11 at 16:03 -0400, Shawn Starr wrote: I notice in Linux and in XP the drive bay light remains on while the laptop is in suspend-to-RAM. I know the ACPI thinkpad extras added to the kernel recently can turn this off. I wonder if we can/or need to write hooks to turn the light

[PATCH 3/3] cifs: md5 cleanup - comments

2005-04-11 Thread Jesper Juhl
clean up comments and make them conform to the style used in other cifs files. this patch can also be fetched from: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-comments.patch Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- linux-2.6.12-rc2-mm2/fs/cifs/md5.c.with_patch2

Re: [ACPI] [2.6.12-rc2][suspend] Suspending Thinkpad: drive bay light in S3 mode stays on

2005-04-11 Thread Shawn Starr
Sure, I suppose you can, but most suspend tools just echo stuff to /sys (or still /proc/acpi/sleep) which makes it harder to script it. Besides, when a laptop goes into suspend to RAM there should be no extra power on except a Moon or some other icon. That said, the ACPI thinkpad extras was

Re: [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU

2005-04-11 Thread Greg KH
On Sun, Apr 10, 2005 at 12:47:42PM -0400, Derek Cheung wrote: Enclosed please find the updated patch that incorporates changes for all the comments I received. You did not cc: the sensors mailing list, nor fix all of the coding style issues. The volatile declaration in the m528xsim.h is

Re: Do not misuse Coverity please

2005-04-11 Thread Pavel Machek
Hi! Jean Delvare [EMAIL PROTECTED] said: No, there is a third case: the pointer can be NULL, but the compiler happened to move the dereference down to after the check. Wow. Great point. I completely missed that possibility. In fact I didn't know that the compiler could

Re: [rfc] git: combo-blobs

2005-04-11 Thread Linus Torvalds
On Mon, 11 Apr 2005, Linus Torvalds wrote: bk changes -R bk changes -L You'd dowload all the sha1 objects (they don't actually do anything to _your_ state - they only show the possible other states), and then it's a simple thing to generate a full tree of your local HEAD

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Alexander Nyberg
Function names and return types on same line - conform to established fs/cifs/ style. -void -MD5Init(struct MD5Context *ctx) +void MD5Init(struct MD5Context *ctx) { ctx-buf[0] = 0x67452301; ctx-buf[1] = 0xefcdab89; @@ -60,8 +58,7 @@ MD5Init(struct MD5Context *ctx) *

[PATCH] redundant NULL checks before kfree should go away...

2005-04-11 Thread Jesper Juhl
(keeping me on CC when replying will be appreciated, thanks) kfree() checks for NULL pointers. Checking prior to calling it is reundant. This patch removes such redundant checks from arch/ppc64/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] diff -upr

Re: [ACPI] [2.6.12-rc2][suspend] Suspending Thinkpad: drive bay light in S3 mode stays on

2005-04-11 Thread Matthew Garrett
On Mon, 2005-04-11 at 16:17 -0400, Shawn Starr wrote: Sure, I suppose you can, but most suspend tools just echo stuff to /sys (or still /proc/acpi/sleep) which makes it harder to script it. Besides, when a laptop goes into suspend to RAM there should be no extra power on except a Moon or

Re: non-free firmware in kernel modules, aggregation and unclear copyright notice.

2005-04-11 Thread Raul Miller
On Sun, Apr 10, 2005 at 01:18:11PM -0700, David Schwartz wrote: You could do that be means of a contract, but I don't think you could it do by means of a copyright license. The problem is that there is no right to control the distribution of derivative works for you to withhold from me.

Re: non-free firmware in kernel modules, aggregation and unclear copyright notice.

2005-04-11 Thread Raul Miller
On Mon, Apr 11, 2005 at 12:31:53PM -0700, David Schwartz wrote: Perhaps you could cite the law that restricts to the copyright holder the right to restrict the distribution of derivative works. I can cite the laws that restrict all those other things and clearly *don't* mention

Re: 2.6.12-rc2-mm3

2005-04-11 Thread Martin J. Bligh
--On Monday, April 11, 2005 01:25:32 -0700 Andrew Morton [EMAIL PROTECTED] wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc2/2.6.12-rc2-mm3/ - The anticipatory I/O scheduler has always been fairly useless with SCSI disks which perform tagged command

Re: Linux 2.4.30-rc3 md/ext3 problems (ext3 gurus : please check)

2005-04-11 Thread Andrew Morton
Stephen C. Tweedie [EMAIL PROTECTED] wrote: Andrew, what was the exact illegal state of the pages you were seeing when fixing that recent leak? It looks like it's nothing more complex than dirty buffers on an anon page. Correct. I think that simply calling try_to_release_page() for

read failed EINVAL with O_DIRECT flag

2005-04-11 Thread Yves Crespin
Hello, Using O_DIRECT flag, read() failed and errno is EINVAL. kernel 2.4.22 Filesystem Ext3 mount on /home What's wrong ? Thanks Yves Crespin #gcc -Wall -D_GNU_SOURCE direct.c -o direct #cp direct d #./direct d #open failed [d] 040402 0666 errno 22 # /* --- start code --- */ #include stdio.h

[PATCH] parisc: kfree cleanup in arch/parisc/

2005-04-11 Thread Jesper Juhl
Get rid of redundant NULL pointer checks before kfree() in arch/parisc/ as well as a few blank lines. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] diff -upr linux-2.6.12-rc2-mm3-orig/arch/parisc/kernel/ioctl32.c linux-2.6.12-rc2-mm3/arch/parisc/kernel/ioctl32.c ---

Re: non-free firmware in kernel modules, aggregation and unclear copyright notice.

2005-04-11 Thread Marco Colombo
On Mon, 2005-04-11 at 18:25 +0200, Sven Luther wrote: On Mon, Apr 11, 2005 at 06:12:22PM +0200, Marco Colombo wrote: [...] A - is the Author (or rights owner) of the software (GPL'ed); B - is an user, who got the a copy of the software from A; C - is another user, who got a copy indirectly,

Re: [2.6.12-rc2][suspend] resume occuring twice before suspend to suspend-to-disk

2005-04-11 Thread Rafael J. Wysocki
Hi, On Monday, 11 of April 2005 21:31, Shawn Starr wrote: I've noticed that when I do a suspend to disk. The machine suspends PCI devices once (I notice this because the ipw2200 wireless card shows its suspending, then it locks/parks the HD heads, but then all PCI devices are woken up and

Re: [PATCH encrypted swsusp 1/3] core functionality

2005-04-11 Thread Rafael J. Wysocki
Hi, On Monday, 11 of April 2005 18:11, Andreas Steinmetz wrote: Pavel Machek wrote: Was it really neccessary to include union u? I don't like its name, Here comes the patch with this reverted. I'm now using casts when 'abusing' the space for encryption. Furthermore the iv set up in the tfm

Re: New SCM and commit list

2005-04-11 Thread Greg KH
On Sun, Apr 10, 2005 at 10:25:22PM -0500, James Bottomley wrote: On Sun, 2005-04-10 at 16:26 -0700, Linus Torvalds wrote: On Mon, 11 Apr 2005, Benjamin Herrenschmidt wrote: If yes, then I would appreciate if you could either keep the same list, or if you want to change the list name, keep

2.6.12-rc2-mm3: CONFIG_MODULES=n MTD compile error

2005-04-11 Thread Adrian Bunk
On Mon, Apr 11, 2005 at 01:25:32AM -0700, Andrew Morton wrote: ... Changes since 2.6.12-rc2-mm2: ... +remove-inter-module-mtd.patch Remove intermodule_foo() usage from mtd. ... This breaks the compilation with CONFIG_MODULES=n: -- snip -- ... CC drivers/mtd/devices/docprobe.o

Re: [PATCH encrypted swsusp 1/3] core functionality

2005-04-11 Thread Pavel Machek
Hi! I had no time to review your patch earlier, sorry. I'm inlining it so that I can comment it: @@ -72,6 +75,16 @@ #include power.h +#ifdef CONFIG_SWSUSP_ENCRYPT +#include linux/random.h +#include linux/crypto.h +#include asm/scatterlist.h +#endif + +#define

Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)

2005-04-11 Thread Jean Delvare
Hi Clemens, [PATCH] I2C rtc8564.c remove duplicate include Trivial fix: removes duplicate include line. Patch applies to: 2.6.11.x (This is my very first patch to the linux-kernel, so let me start with small things first...) Signed-off-by: Clemens Koller [EMAIL PROTECTED] Thanks for

Re: non-free firmware in kernel modules, aggregation and unclear copyright notice.

2005-04-11 Thread Sven Luther
On Mon, Apr 11, 2005 at 10:54:50PM +0200, Marco Colombo wrote: In this case, A is clearly the author (onwer of rights) of the firmware. D is fine on respect of the other A's, since their source is actually (and clearly) there. It's the missing source case we're considering and the number of

Re: [RFC][PATCH] Simple privacy enhancement for /proc/pid

2005-04-11 Thread Rene Scharfe
Bodo Eggert schrieb: On Sun, 10 Apr 2005, Rene Scharfe wrote: First, configuring via kernel parameters is sufficient. I don't remember: Would a mount option be equally easy to implement? (Kernel parameters are OK for me, too.) A mount option for procfs would be changable at remount,

Re: New SCM and commit list

2005-04-11 Thread Linus Torvalds
On Mon, 11 Apr 2005, Greg KH wrote: I have a feeling that the kernel.org mirror system is just going to _love_ us using it to store temporary git trees :) I don't think kernel.org mirrors the private home directories, so it you do _temporary_ trees, just make them readable in your private

Re: [PATCH] zero disk pages used by swsusp on resume

2005-04-11 Thread Rafael J. Wysocki
Hi, On Monday, 11 of April 2005 19:02, Andreas Steinmetz wrote: Rafael J. Wysocki wrote: Hi, On Monday, 11 of April 2005 12:37, Oliver Neukum wrote: Am Sonntag, 10. April 2005 22:14 schrieb Pavel Machek: Hi! Oliver Neukum wrote: What is the point in doing so after they've

Re: New SCM and commit list

2005-04-11 Thread James Bottomley
On Mon, 2005-04-11 at 14:26 -0700, Linus Torvalds wrote: I don't think kernel.org mirrors the private home directories, so it you do _temporary_ trees, just make them readable in your private home directory rather than in /pub/linux/kernel/people. For people with kernel.org accounts, we can

Re: [PATCH encrypted swsusp 1/3] core functionality

2005-04-11 Thread Rafael J. Wysocki
Hi, On Monday, 11 of April 2005 23:08, Pavel Machek wrote: Hi! ]--snip--[ @@ -130,6 +150,52 @@ static unsigned short swapfile_used[MAX_SWAPFILES]; static unsigned short root_swap; +#ifdef CONFIG_SWSUSP_ENCRYPT +static struct crypto_tfm *crypto_init(int mode) I think

[PATCH] net: remove redundant NULL pointer checks prior to kfree in drivers/net/slip.c

2005-04-11 Thread Jesper Juhl
kfree() checks for NULL. Checking prior to calling it is redundant. This patch removes these redundant checks from drivers/net/slip.c Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- slip.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) ---

Re: non-free firmware in kernel modules, aggregation and unclear copyright notice.

2005-04-11 Thread Raul Miller
On Sun, Apr 10, 2005 at 11:24:10AM +0200, Giuseppe Bilotta wrote: AFAIK software only refers to programs, not to arbitrary sequences of bytes. An MP3 file isn't software. Although it surely isn't hardware either. This point is a controversial point. Different people make different claims.

Re: [RFC] FUSE permission modell (Was: fuse review bits)

2005-04-11 Thread Jamie Lokier
Miklos Szeredi wrote: That is exactly the intended effect. If I'm at my work machine (where I'm not an admin unfortunately) and I mount my home machine with sshfs (because FUSE is installed fortunately :), then I bloody well don't want the sysadmin or some automated script of his to go

[PATCH] usb: kfree() cleanups in drivers/usb/core/devio.c

2005-04-11 Thread Jesper Juhl
Checking for NULL before calling kfree() is redundant. This patch removes these redundant checks and also makes a few tiny whitespace changes. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- devio.c | 32 1 files changed, 12 insertions(+), 20 deletions(-)

Re: 2.6.12-rc2-mm3

2005-04-11 Thread Borislav Petkov
On Monday 11 April 2005 11:43, Andrew Morton wrote: (Please do reply-to-all) J.A. Magallon [EMAIL PROTECTED] wrote: On 04.11, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-r c2/2.6.12-rc2-mm3/ Is this not needed anymore ? ---

[PATCH] ppc32: refactor FPU exception handling

2005-04-11 Thread Kumar Gala
Andrew, Moved common FPU exception handling code out of head.S so it can be used by several of the sub-architectures that might of a full PowerPC FPU. Also, uses new CONFIG_PPC_FPU define to fix alignment exception handling for floating point load/store instructions to only occur if we have

Re: [patch 4/5] sched: RCU sched domains

2005-04-11 Thread Paul E. McKenney
On Thu, Apr 07, 2005 at 05:58:40PM +1000, Nick Piggin wrote: Ingo Molnar wrote: * Nick Piggin [EMAIL PROTECTED] wrote: At a minimum i think we need the fix+comment below. Well if we say this is actually RCU, then yes. And we should probably change the preempt_{dis|en}ables in other

[PATCH] Fix SIGBUS handling

2005-04-11 Thread Russell King
ARM wasn't raising a SIGBUS with a siginfo structure. Fix __do_user_fault() to allow us to use it for SIGBUS conditions, and arrange for the sigbus path to use this. We need to prevent the siginfo code being called if we do not have a user space context to call it, so consolidate the user_mode()

[PATCH] Add comment about max_low_pfn/max_pfn

2005-04-11 Thread Russell King
Oddly, max_low_pfn/max_pfn end up being the number of pages in the system, rather than the maximum PFN on ARM. This doesn't seem to cause any problems, so just add a note about it. Signed-off-by: Russell King [EMAIL PROTECTED] diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x '*.orig' -x

[PATCH] Fix floppy disk dependencies

2005-04-11 Thread Russell King
Both the RiscPC and (optionally) EBSA285 have floppy disk support. Allow this option to be selected on these ARM platforms again. Signed-off-by: Russell King [EMAIL PROTECTED] diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x '*.orig' -x '*.rej' -r orig/drivers/block/Kconfig

Re: [PATCH] Priority Lists for the RT mutex

2005-04-11 Thread hui
On Mon, Apr 11, 2005 at 10:57:37AM +0200, Ingo Molnar wrote: * Perez-Gonzalez, Inaky [EMAIL PROTECTED] wrote: Let me re-phrase then: it is a must have only on PI, to make sure you don't have a loop when doing it. Maybe is a consequence of the algorithm I chose. -However- it should be

[PATCH] Fix comments in 8250.c

2005-04-11 Thread Russell King
Fix the formatting of some comments in 8250.c, and add a note that the register_serial / unregister_serial shouldn't be used in new code. We do this here in preference to adding to linux/serial.h, since that is used by a number of non-8250 drivers which pretend to be 8250. It is not known

Re: 2.6.12-rc2-mm3

2005-04-11 Thread Andrew Morton
Borislav Petkov [EMAIL PROTECTED] wrote: On Monday 11 April 2005 11:43, Andrew Morton wrote: (Please do reply-to-all) J.A. Magallon [EMAIL PROTECTED] wrote: On 04.11, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-r c2/2.6.12-rc2-mm3/

Re: [RFC] FUSE permission modell (Was: fuse review bits)

2005-04-11 Thread Daniel Jacobowitz
On Mon, Apr 11, 2005 at 09:56:29PM +0200, Miklos Szeredi wrote: Well the sanity check on the server side is always enforced. You can't trick sftp or ftp to not check permissions. So checking on the client side too (where the fuse daemon is running) makes no sense, does it? That argument

Re: Linux 2.4.30-rc3 md/ext3 problems (ext3 gurus : please check)

2005-04-11 Thread Stephen C. Tweedie
Hi, On Mon, 2005-04-11 at 21:46, Andrew Morton wrote: Stephen C. Tweedie [EMAIL PROTECTED] wrote: Andrew, what was the exact illegal state of the pages you were seeing when fixing that recent leak? It looks like it's nothing more complex than dirty buffers on an anon page. Correct.

Re: 2.6.12-rc2-mm3

2005-04-11 Thread Benoit Boissinot
On Apr 11, 2005 10:46 PM, Martin J. Bligh [EMAIL PROTECTED] wrote: --On Monday, April 11, 2005 01:25:32 -0700 Andrew Morton [EMAIL PROTECTED] wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc2/2.6.12-rc2-mm3/ - The anticipatory I/O scheduler has

[PATCH] Fix help text for ixdp465

2005-04-11 Thread Russell King
For some reason, this help text was missed when the file was last audited by the documentation referencing folk. Fix this incorrect documentation reference. Signed-off-by: Russell King [EMAIL PROTECTED] diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x '*.orig' -x '*.rej' -r

RE: [PATCH] Priority Lists for the RT mutex

2005-04-11 Thread Perez-Gonzalez, Inaky
From: Bill Huey (hui) [mailto:[EMAIL PROTECTED] On Mon, Apr 11, 2005 at 10:57:37AM +0200, Ingo Molnar wrote: * Perez-Gonzalez, Inaky [EMAIL PROTECTED] wrote: Let me re-phrase then: it is a must have only on PI, to make sure you don't have a loop when doing it. Maybe is a consequence of the

Call to atention about using hash functions as content indexers (SCM saga)

2005-04-11 Thread Pedro Larroy
Hi I had a quick look at the source of GIT tonight, I'd like to warn you about the use of hash functions as content indexers. As probably you are aware, hash functions such as SHA-1 are surjective not bijective (1-to-1 map), so they have collisions. Here one can argue about the low probability

[patch, I hope you like it better this way :-)] fix few remaining u32 vs. pm_message_t problems in -mm3

2005-04-11 Thread Pavel Machek
This fixes remaining u32 vs. pm_message_t confusions in -rc2-mm3. [There are usb changes, too; they went to Greg on his request.] Signed-off-by: Pavel Machek [EMAIL PROTECTED] --- clean-mm/drivers/macintosh/via-pmu.c2005-04-11 22:53:30.0 +0200 +++

Re: [PATCH 2/3] Keys: Use RCU to manage session keyring pointer

2005-04-11 Thread Paul E. McKenney
On Wed, Mar 23, 2005 at 08:55:46PM +, David Howells wrote: The attached patch uses RCU to manage the session keyring pointer in struct signal_struct. This means that searching need not disable interrupts and get a the sighand spinlock to access this pointer. Furthermore, by judicious use

Re: New SCM and commit list

2005-04-11 Thread Daniel Barkalow
On Sun, 10 Apr 2005, Linus Torvalds wrote: On Mon, 11 Apr 2005, Jeff Garzik wrote: But I hope that I can get non-conflicting merges done fairly soon, and maybe I can con James or Jeff or somebody to try out GIT then... I don't mind being a guinea pig as long as someone else does

Re: Call to atention about using hash functions as content indexers (SCM saga)

2005-04-11 Thread Petr Baudis
Dear diary, on Tue, Apr 12, 2005 at 12:40:21AM CEST, I got a letter where Pedro Larroy [EMAIL PROTECTED] told me that... Hi Hello, I had a quick look at the source of GIT tonight, I'd like to warn you about the use of hash functions as content indexers. As probably you are aware, hash

Re: Processes stuck on D state on Dual Opteron

2005-04-11 Thread Nick Piggin
Claudio Martins wrote: Right. I'm using two Seagate ATA133 disks (ide controler is AMD-8111) each with 4 partitions, so I get 4 md Raid1 devices. The first one, md0, is for swap. The rest are ~$ df -h FilesystemSize Used Avail Use% Mounted on /dev/md1 4.6G 1.9G

[PATCH 2/3] mm/Kconfig: hide Memory Model selection menu

2005-04-11 Thread Dave Hansen
I got some feedback from users who think that the new Memory Model menu is a little invasive. This patch will hide that menu, except when CONFIG_EXPERIMENTAL is enabled *or* when an individual architecture wants it. An individual arch may want to enable it because they've removed their

[PATCH 1/3] mm/Kconfig: kill unused ARCH_FLATMEM_DISABLE

2005-04-11 Thread Dave Hansen
This used to be used to disable FLATMEM selection, but I decided to change it to be done generically when DISCONTIG is enabled. The option is unused, so this kills it. Signed-off-by: Dave Hansen [EMAIL PROTECTED] --- memhotplug-dave/./arch/mips/Kconfig |4

[PATCH 3/3] mm/Kconfig: give DISCONTIG more help text

2005-04-11 Thread Dave Hansen
This gives DISCONTIGMEM a bit more help text to explain what it does, not just when to choose it. Signed-off-by: Dave Hansen [EMAIL PROTECTED] --- memhotplug-dave/mm/Kconfig | 10 ++ 1 files changed, 10 insertions(+) diff -puN mm/Kconfig~A2-mm-Kconfig-DISCONTIG-help-text mm/Kconfig

Re: [PATCH] Priority Lists for the RT mutex

2005-04-11 Thread hui
On Mon, Apr 11, 2005 at 03:31:41PM -0700, Perez-Gonzalez, Inaky wrote: If you are exposing the kernel locks to userspace to implement mutexes (eg POSIX mutexes), deadlock checking is a feature you want to have to complain with POSIX. According to some off the record requirements I've been

Re: [xfs-masters] swsusp vs. xfs [was Re: 2.6.12-rc2-mm1]

2005-04-11 Thread Nathan Scott
On Mon, Apr 11, 2005 at 12:57:59PM +0200, Pavel Machek wrote: Hi! No, XFS is my root filesystem. :( (Now that I think about it, would modularizing XFS and using an initrd be OK?) Yes, loading xfs from initrd should help. [At least it did during suse9.3 testing.] Once I

Re: Call to atention about using hash functions as content indexers (SCM saga)

2005-04-11 Thread Magnus Damm
On 4/12/05, Petr Baudis [EMAIL PROTECTED] wrote: (iv) You fail to propose a better solution. I would feel safer with back end storage filenames based on email and mtime together with an optional hash lookup that turns collisions into worse performance. But that's just me. / magnus - To

RE: [PATCH] Priority Lists for the RT mutex

2005-04-11 Thread Perez-Gonzalez, Inaky
From: Bill Huey (hui) [mailto:[EMAIL PROTECTED] On Mon, Apr 11, 2005 at 03:31:41PM -0700, Perez-Gonzalez, Inaky wrote: If you are exposing the kernel locks to userspace to implement mutexes (eg POSIX mutexes), deadlock checking is a feature you want to have to complain with POSIX. According to

[PATCH] LifeView FlyTV Platinum FM: Remote Control support

2005-04-11 Thread Peter Missel
Greetings! Subject says it ... this card's IR microcontroller design and attachment are compatible to the company's previous designs, so the patch was as simple as it gets. Note that this patch goes on top of the other one I posted yesterday, thank you very much. regards, Peter ---

[Bug?] Keyboard Problem

2005-04-11 Thread Manu
I'm currently using a 2.6.10 kernel (on a Debian Sarge, i386). I've compiled a 2.6.11.5 and a 2.6.11.7 kernels and my keyboard (a sweex SILVER MULTIMEDIA KEYBOARD, SW-23 -- PS/2 105 keys -- a classical keyboard) doesn't work with these kernels. I asked for help and one said me it is probably a

Re: Processes stuck on D state on Dual Opteron

2005-04-11 Thread Neil Brown
On Monday April 11, [EMAIL PROTECTED] wrote: Neil, have you had a look at the traces? Do they mean much to you? Just looked. bio_alloc_bioset seems implicated, as does sync_page_io. sync_page_io used to use a 'struct bio' on the stack, but Jens Axboe change it to use bio_alloc (don't know

Re: [discuss] [21/31] x86_64: Always use CPUID 80000008 to figure out MTRR address space size

2005-04-11 Thread Siddha, Suresh B
On Mon, Apr 11, 2005 at 08:00:01PM +0200, Andi Kleen wrote: On Sun, Apr 10, 2005 at 11:25:23PM -0700, Siddha, Suresh B wrote: We need to use the size_and_mask in set_mtrr_var_ranges(which is called while programming MTRR's for AP's Patch is ok for me. But how did you find this out? Did

Re: [xfs-masters] swsusp vs. xfs [was Re: 2.6.12-rc2-mm1]

2005-04-11 Thread Pavel Machek
Hi! No, XFS is my root filesystem. :( (Now that I think about it, would modularizing XFS and using an initrd be OK?) Yes, loading xfs from initrd should help. [At least it did during suse9.3 testing.] Once I modularized xfs and switched to using an initrd, the

Re: [patch 4/5] sched: RCU sched domains

2005-04-11 Thread Nick Piggin
Paul E. McKenney wrote: On Thu, Apr 07, 2005 at 05:58:40PM +1000, Nick Piggin wrote: OK thanks for the good explanation. So I'll keep it as is for now, and whatever needs cleaning up later can be worked out as it comes up. Looking forward to the split of synchronize_kernel() into

[PATCH] scripts/patch-kernel: EXTRAVERSION patches are not incremental

2005-04-11 Thread Randy.Dunlap
On Tue, 15 Mar 2005 16:15:54 + David Greaves wrote: | Old thread (!) but this is the last time I could find patch-kernel updated. I found a little time to update patch-kernel if anyone wants to use it. OTOH, using Matt Mackall's ketchup is OK too. I also use 'kcurrent' to keep up with the

Re: 2.6.12-rc2-mm3

2005-04-11 Thread Andrew Morton
Jindrich Makovicka [EMAIL PROTECTED] wrote: Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc2/2.6.12-rc2-mm3/ MPlayer randomly crashes in various pthread_* calls when using binary codecs. 2.6.12-rc2-mm2 was ok. I tried to reverse

Re: [PATCH] Priority Lists for the RT mutex

2005-04-11 Thread hui
On Mon, Apr 11, 2005 at 04:28:25PM -0700, Perez-Gonzalez, Inaky wrote: From: Bill Huey (hui) [mailto:[EMAIL PROTECTED] ... API than once upon a time was made multithreaded by just adding a bunch of pthread_mutex_[un]lock() at the API entry point... without realizing that some of the top level

Re: Processes stuck on D state on Dual Opteron

2005-04-11 Thread Claudio Martins
On Monday 11 April 2005 23:59, Nick Piggin wrote: OK, I'll try them in a few minutes and report back. I'm not overly hopeful. If they fix the problem, then it's likely that the real bug is hidden. Well, the thing is, they do fix the problem. Or at least they hide it very well ;-)

Re: Processes stuck on D state on Dual Opteron

2005-04-11 Thread Claudio Martins
On Tuesday 12 April 2005 00:46, Neil Brown wrote: On Monday April 11, [EMAIL PROTECTED] wrote: Neil, have you had a look at the traces? Do they mean much to you? Just looked. bio_alloc_bioset seems implicated, as does sync_page_io. sync_page_io used to use a 'struct bio' on the stack, but

Re: [PATCH][RFC][0/4] InfiniBand userspace verbs implementation

2005-04-11 Thread Andrew Morton
Roland Dreier [EMAIL PROTECTED] wrote: Troy Do we even need the mlock in userspace then? Yes, because the kernel may go through and unmap pages from userspace while trying to swap. Since we have the page locked in the kernel, the physical page won't go anywhere, but userspace might end

Re: [PATCH][RFC][0/4] InfiniBand userspace verbs implementation

2005-04-11 Thread Roland Dreier
Roland Yes, because the kernel may go through and unmap pages Roland from userspace while trying to swap. Since we have the Roland page locked in the kernel, the physical page won't go Roland anywhere, but userspace might end up with a different page Roland mapped at the same

Re: [xfs-masters] swsusp vs. xfs [was Re: 2.6.12-rc2-mm1]

2005-04-11 Thread Nathan Scott
On Tue, Apr 12, 2005 at 01:51:10AM +0200, Pavel Machek wrote: I should take some sleep now, so I can't test the patch, but I don't think it will help. If someone has PF_FREEZE set, he should be in refrigerator. OK, so if that doesn't help, here's an alternate approach - this lets xfsbufd track

RE: [PATCH] Priority Lists for the RT mutex

2005-04-11 Thread Perez-Gonzalez, Inaky
From: Bill Huey (hui) [mailto:[EMAIL PROTECTED] Quick fix: the usual. Enable deadlock detection and if it returns deadlock, assume it is locked already and proceed (or do a recursive mutex, or a trylock). You have to be joking me ? geez. ... This is way *more* common than you think--I've

Re: non-free firmware in kernel modules, aggregation and unclear copyright notice.

2005-04-11 Thread Marco Colombo
On Mon, 11 Apr 2005, Sven Luther wrote: On Mon, Apr 11, 2005 at 10:54:50PM +0200, Marco Colombo wrote: In this case, A is clearly the author (onwer of rights) of the firmware. D is fine on respect of the other A's, since their source is actually (and clearly) there. It's the missing source case

Re: Processes stuck on D state on Dual Opteron

2005-04-11 Thread Andrew Morton
Claudio Martins [EMAIL PROTECTED] wrote: I think I'm going to give a try to Neil's patch, but I'll have to apply some patches from -mm. Just this one if you're using 2.6.12-rc2: --- 25/drivers/md/md.c~avoid-deadlock-in-sync_page_io-by-using-gfp_noio Mon Apr 11 16:55:07 2005 +++

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Steve French
Alexander Nyberg [EMAIL PROTECTED] wrote on 04/11/2005 03:26:14 PM: Function names and return types on same line - conform to established fs/cifs/ style. -void -MD5Init(struct MD5Context *ctx) +void MD5Init(struct MD5Context *ctx) { ctx-buf[0] = 0x67452301; ctx-buf[1]

Re: [INFO] Kernel strict versioning

2005-04-11 Thread Franco \Sensei\
Adrian Bunk wrote: This has nothing to do with versioning. You are asking for ABI compatibility between different kernel versions. The problem is probably misunderstanding about what I intend by version. There is no stable ABI between different kernel versions and there will never be one. Please

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-11 Thread Greg Banks
On Tue, 2005-04-12 at 01:42, Jakob Oestergaard wrote: Yes, as far as I know - the Broadcom Tigeon3 driver does not have the option of enabling/disabling RX polling (if we agree that is what we're talking about), but looking in tg3.c it seems that it *always* unconditionally uses NAPI... I've

Re: [patch] sched: unlocked context-switches

2005-04-11 Thread David Mosberger
On Sun, 10 Apr 2005 08:43:24 +0200, Ingo Molnar [EMAIL PROTECTED] said: Ingo * David S. Miller [EMAIL PROTECTED] wrote: Yes, of course. The deadlock was due to context-switching, not switch_mm() per se. Hopefully someone else beats me to remembering the details before Monday.

Policy question (was Re: [2.6.12-rc1][ACPI][suspend] /proc/acpi/sleep vs /sys/power/state issue - 'standby' on a laptop)

2005-04-11 Thread Rob Landley
On Wednesday 06 April 2005 05:22 pm, Shawn Starr wrote: --- Pavel Machek [EMAIL PROTECTED] wrote: Hi! So nobody minds if I make this into a CONFIG option marked as Deprecated? :) Actually it should probably go through Documentation/feature-removal-schedule.txt ...and give

[PATCH 2.6.11.7 1/1] x86 reboot: Add reboot fixup for gx1/cs5530a

2005-04-11 Thread jayalk
Hi Peter, As per your suggestion, I switched do {} while(0) to ((void)(0)) for the dummy define, since it's an argumentless function. Please let me know if it's okay now. Thanks, Jaya Kumar --- I ran into a problem getting reboot working with 2.6.11 on an embedded board. The board has a

Re: Processes stuck on D state on Dual Opteron

2005-04-11 Thread Nick Piggin
On Tue, 2005-04-12 at 01:22 +0100, Claudio Martins wrote: On Monday 11 April 2005 23:59, Nick Piggin wrote: OK, I'll try them in a few minutes and report back. I'm not overly hopeful. If they fix the problem, then it's likely that the real bug is hidden. Well, the thing is,

Re: 2.6.12-rc2-mm3

2005-04-11 Thread Juergen Kreileder
Andrew Morton [EMAIL PROTECTED] writes: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc2/2.6.12-rc2-mm3/ I'm getting frequent lockups on my PowerMac G5 with rc2-mm3. 2.6.11-mm4 works fine but all 2.6.12 versions I've tried (all since -rc1-mm3) lock up randomly. The

Re: Policy question (was Re: [2.6.12-rc1][ACPI][suspend] /proc/acpi/sleep vs /sys/power/state issue - 'standby' on a laptop)

2005-04-11 Thread Shawn Starr
Well, of course. When I get around to figuring out the best way to do this. Since I don't want to bloat up sysfs ACPI stuff just to check if the echoed value is a number or string. We can just gradually phase it out by just marking it DEPRECATED and keep it ON in the Kbuild file so nobody

Re: Re: GIT license (Re: Re: Re: Re: Re: [ANNOUNCE] git-pasky-0.1)

2005-04-11 Thread Adam J. Richter
On Mon, 11 Apr 2005 20:45:38 +0200, Peter Baudis wrote: Hello, please do not trim the cc list so agressively. Sorry. I read the list from a web site that does not show the cc lists. I'll try to cc more people from the relevant discussions though. On the other hand, I've dropped Linus from

Re: Re: Re: GIT license (Re: Re: Re: Re: Re: [ANNOUNCE] git-pasky-0.1)

2005-04-11 Thread Petr Baudis
Dear diary, on Tue, Apr 12, 2005 at 03:20:18AM CEST, I got a letter where Adam J. Richter [EMAIL PROTECTED] told me that... Dear diary, on Mon, Apr 11, 2005 at 05:46:38PM CEST, I got a letter where Adam J. Richter [EMAIL PROTECTED] told me that... ..snip.. Graydon Hoare. (By the way, I would

Re: [INFO] Kernel strict versioning

2005-04-11 Thread Adrian Bunk
On Mon, Apr 11, 2005 at 08:02:55PM -0500, Franco Sensei wrote: Adrian Bunk wrote: This has nothing to do with versioning. You are asking for ABI compatibility between different kernel versions. The problem is probably misunderstanding about what I intend by version. There is no stable

Re: [patch] MAINTAINERS: remove obsolete ACP/MWAVE MODEM entry

2005-04-11 Thread Adrian Bunk
On Mon, Apr 11, 2005 at 05:39:32AM -0300, Marcelo Tosatti wrote: Adrian, Hi Marcelo, ./drivers/char/mwave/Makefile also references Paul's email address, at least in v2.4. I've given up on removing and correcting obsolete email addresses. This created more discussions than it was worth...

Re: [2.6 patch] drivers/block/ll_rw_blk.c: possible cleanups

2005-04-11 Thread Adrian Bunk
On Mon, Apr 11, 2005 at 08:12:34AM +0200, Jens Axboe wrote: On Sun, Apr 10 2005, Adrian Bunk wrote: This patch contains the following possible cleanups: - make needlessly global code static - remove the following unused global functions: - blkdev_scsi_issue_flush_fn Kill the function

Re: 2.6.12-rc2-mm3

2005-04-11 Thread Benjamin Herrenschmidt
On Tue, 2005-04-12 at 03:18 +0200, Juergen Kreileder wrote: Andrew Morton [EMAIL PROTECTED] writes: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc2/2.6.12-rc2-mm3/ I'm getting frequent lockups on my PowerMac G5 with rc2-mm3. 2.6.11-mm4 works fine but all 2.6.12

Re: [patch] sched: unlocked context-switches

2005-04-11 Thread Nick Piggin
On Mon, 2005-04-11 at 18:06 -0700, David Mosberger wrote: I had to refresh my memory with a quick Google search that netted [1] (look for Disable interrupts during context switch). Actually, it wasn't really a deadlock, but rather a livelock, since a CPU got stuck on an infinite

bkbits.net is down

2005-04-11 Thread Larry McVoy
Seems to have crashed, we don't know the cause yet. Is there anyone who is dependent on this tonight? If so I'll drive down and fix it (yeah, very lame of us, we moved it to a different rack which was too far away from our remote power so I can't power cycle it remotely. Our bad.) Let me know,

Re: [PATCH] ppc32: refactor FPU exception handling

2005-04-11 Thread Benjamin Herrenschmidt
On Mon, 2005-04-11 at 17:02 -0500, Kumar Gala wrote: Andrew, Moved common FPU exception handling code out of head.S so it can be used by several of the sub-architectures that might of a full PowerPC FPU. Also, uses new CONFIG_PPC_FPU define to fix alignment exception handling for

[ANNOUNCE] open-iscsi and linux-iscsi project teams have merged!

2005-04-11 Thread linux-iscsi development team
The linux-iscsi and open-iscsi developers would like to announce that they have combined forces on a single iSCSI initiator effort! This mail gives an overview of this combined effort and will be followed by a set of iSCSI patches the combined team submits for review as a candidate for inclusion

Re: [INFO] Kernel strict versioning

2005-04-11 Thread Franco \Sensei\
Adrian Bunk wrote: You say API but talk about ABI. As long as we want to guarantee abi, we must use the same names. Api names, not implementation should be the same. You can't substitute get_namei with get_my_own_namei_version_I_know... You said you've read stable_api_nonsense.txt .

Re: [Bug?] Keyboard Problem

2005-04-11 Thread Dmitry Torokhov
Hi, On Monday 11 April 2005 18:45, Manu wrote: I'm currently using a 2.6.10 kernel (on a Debian Sarge, i386). I've compiled a 2.6.11.5 and a 2.6.11.7 kernels and my keyboard (a sweex SILVER MULTIMEDIA KEYBOARD, SW-23 -- PS/2 105 keys -- a classical keyboard) doesn't work with these kernels.

USB on zx5405us

2005-04-11 Thread John Richard Moser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 USB isn't working on my zv5405us on a 2.6.10 ubuntu kernel. Or on gentoo. Or anything. It works in WindowsXP though. I can extract the error from dmesg. Here's ACPI first (ACPI works btw) Nvidia board detected. Ignoring ACPI timer override.

<    1   2   3   4   5   6   7   >