[PATCH v4 5/6] ipc: Clamp semmni to the real IPCMNI limit

2018-03-12 Thread Waiman Long
This patch clamps the semmni value (fourth element of sem_ctls[] array) to within the [0, IPCMNI] range and prints a warning message once when an out-of-range value is being written. Signed-off-by: Waiman Long --- ipc/ipc_sysctl.c | 13 - ipc/sem.c| 28 +++

[PATCH 1/3] drm/meson: Fix an un-handled error path in 'meson_drv_bind_master()'

2018-03-12 Thread Christophe JAILLET
'drm_vblank_init()' can fail. So handle this (unlikely) error. Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/meson/meson_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH 3/3] drm/meson: Fix some error handling paths in 'meson_drv_bind_master()'

2018-03-12 Thread Christophe JAILLET
If one of these functions fail, we whould free 'drm', as alreadry done in the other error handling paths, below and above. Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/meson/meson_drv.c | 24 --

[PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

2018-03-12 Thread Waiman Long
Checking code is added to check for invalid flags in the ctl_table and return error if an unknown flag is used. Signed-off-by: Waiman Long --- fs/proc/proc_sysctl.c | 12 1 file changed, 12 insertions(+) diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 493c975..67c0

Re: [pci PATCH v5 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-03-12 Thread Alexander Duyck
On Mon, Mar 12, 2018 at 11:23 AM, Keith Busch wrote: > On Mon, Mar 12, 2018 at 11:09:34AM -0700, Alexander Duyck wrote: >> On Mon, Mar 12, 2018 at 10:40 AM, Keith Busch wrote: >> > On Mon, Mar 12, 2018 at 10:21:29AM -0700, Alexander Duyck wrote: >> >> diff --git a/include/linux/pci.h b/include/li

[PATCH v4 4/6] ipc: Clamp msgmni and shmmni to the real IPCMNI limit

2018-03-12 Thread Waiman Long
A user can write arbitrary integer values to msgmni and shmmni sysctl parameters without getting error, but the actual limit is really IPCMNI (32k). This can mislead users as they think they can get a value that is not real. Enforcing the limit by failing the sysctl parameter write, however, can b

[PATCH v4 3/6] sysctl: Warn when a clamped sysctl parameter is set out of range

2018-03-12 Thread Waiman Long
Even with clamped sysctl parameters, it is still not that straight forward to figure out the exact range of those parameters. One may try to write extreme parameter values to see if they get clamped. To make it easier, a warning with the expected range will now be printed into the kernel ring buffe

[PATCH v4 6/6] test_sysctl: Add range clamping test

2018-03-12 Thread Waiman Long
Add a range clamping test for the msgmni sysctl parameter to verify that the input value will be clamped if it exceeds the builtin maximum or minimum value. Below is the expected test run result: Running test: sysctl_test_0006 - run #0 Checking range minimum clamping ... ok Checking range maximum

[PATCH v4 0/6] ipc: Clamp *mni to the real IPCMNI limit

2018-03-12 Thread Waiman Long
v3->v4: - Remove v3 patches 1 & 2 as they have been merged into the mm tree. - Change flags from uint16_t to unsigned int. - Remove CTL_FLAGS_OOR_WARNED and use pr_warn_ratelimited() instead. - Simplify the warning message code. - Add a new patch to fail the ctl_table registration with invalid

[PATCH v4 1/6] sysctl: Add flags to support min/max range clamping

2018-03-12 Thread Waiman Long
When minimum/maximum values are specified for a sysctl parameter in the ctl_table structure with proc_dointvec_minmax() handler, update to that parameter will fail with error if the given value is outside of the required range. There are use cases where it may be better to clamp the value of the s

[PATCH] proc: revalidate misc dentries

2018-03-12 Thread Alexey Dobriyan
If module removes proc directory while another process pins it by chdir'ing to it, then subsequent recreation of proc entry and all entries down the tree will not be visible to any process until pinning process unchdir from directory and unpins everything. Steps to reproduce: proc_mkdir("

Re: [GIT PULL] CRIS: Drop support for the CRIS-port

2018-03-12 Thread Arnd Bergmann
On Sun, Mar 11, 2018 at 12:05 PM, Jesper Nilsson wrote: > Hi Arnd, > > As promised, pull the below tag for the removal of the CRIS-port. > There are still a few references to the CRIS port left, and they > can be grouped into two categories: > > - Examples or references to the CRIS port as provena

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

2018-03-12 Thread Jacek Anaszewski
On 03/12/2018 04:45 PM, Matthias Schiffer wrote: > On 03/12/2018 04:28 PM, Greg KH wrote: >> On Mon, Mar 12, 2018 at 04:00:01PM +0100, Matthias Schiffer wrote: >>> On 02/06/2018 09:44 PM, Jacek Anaszewski wrote: On 02/06/2018 03:02 AM, Sasha Levin wrote: > On Sun, Feb 04, 2018 at 06:17:36P

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-12 Thread Darren Hart
On Mon, Mar 12, 2018 at 07:53:57PM +0100, Dominik Brodowski wrote: > Mario, > > unfortunately, my Dell Inc. XPS 13 9343/0TM99H, BIOS A11 12/08/2016 fails to > boot v4.16-rc5. More exactly, I could bisect it down to commit 25d47027e10 > ("platform/x86: dell-smbios: Link all dell-smbios-* modules to

Re: dcache: remove trylock loops (was Re: [BUG] lock_parent() breakage when used from shrink_dentry_list())

2018-03-12 Thread Eric W. Biederman
Al Viro writes: > On Tue, Feb 27, 2018 at 06:16:28AM +0100, John Ogness wrote: > >> If someone else has grabbed a reference, it shouldn't be added to the >> lru list. Only decremented. >> >> if (entry->d_lockref.count == 1) > > Nah, better handle that in retain_dentry() itself. See updated > #w

Re: [PATCH 2/3 v3] devpts: resolve devpts bind-mounts

2018-03-12 Thread Eric W. Biederman
Christian Brauner writes: > On Mon, Mar 12, 2018 at 02:52:53PM -0500, Eric W. Biederman wrote: >> Christian Brauner writes: >> >> > Most libcs will still look at /dev/ptmx when opening the master fd of a pty >> > device. When /dev/ptmx is a bind-mount of /dev/pts/ptmx and the TIOCGPTPEER >> > i

Re: [PATCH] platform/x86: dell_smbios: Resolve dependency error on ACPI_WMI

2018-03-12 Thread Darren Hart
On Mon, Mar 12, 2018 at 11:23:20AM +0200, Andy Shevchenko wrote: > On Sun, Mar 11, 2018 at 2:28 AM, Darren Hart wrote: > > Similarly to DCDBAS for DELL_SMBIOS_SMM, if DELL_SMBIOS_WMI is enabled, > > DELL_SMBIOS becomes dependent on ACPI_WMI. Update the depends line to > > prevent a configuration w

Re: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-03-12 Thread Joonas Kylmälä
Paul Kocialkowski: > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > new file mode 100644 > index ..88624035e0e3 > --- /dev/null > +++ b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > @@ -0,0 +1,313 @@ > +/*

Re: dcache: remove trylock loops (was Re: [BUG] lock_parent() breakage when used from shrink_dentry_list())

2018-03-12 Thread Al Viro
On Mon, Mar 12, 2018 at 08:05:41PM +, Al Viro wrote: > Does any of the d_find_alias() callers want those dentries? That is, > non-directories from d_obtain_alias() still not attached to a parent; > note that exportfs_decode_fh() is *not* one of such places - we don't > use d_find_alias() ther

[PATCH v2] platform/x86: dell-smbios: Resolve dependency error on ACPI_WMI

2018-03-12 Thread Darren Hart
Similarly to DCDBAS for DELL_SMBIOS_SMM, if DELL_SMBIOS_WMI is enabled, DELL_SMBIOS becomes dependent on ACPI_WMI. Update the depends lines to prevent a configuration where DELL_SMBIOS=y and either backend dependency =m. Update the comment accordingly. Cc: Mario Limonciello Cc: Andy Shevchenko C

Re: dcache: remove trylock loops (was Re: [BUG] lock_parent() breakage when used from shrink_dentry_list())

2018-03-12 Thread Al Viro
On Mon, Mar 12, 2018 at 03:23:44PM -0500, Eric W. Biederman wrote: > Of the two code paths you are concert about: > > For path path_connected looking at s_root is a heuristic to avoid > calling is_subdir every time we need to do that check. If the heuristic > fails we still have is_subdir which

linux-next: Signed-off-by missing for commit in the usb-gadget tree

2018-03-12 Thread Stephen Rothwell
Hi Felipe, Commit 969d58abe57d ("usb: dwc2: Enable LPM") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgpAiFs65avQ7.pgp Description: OpenPGP digital signature

Re: [PATCH v3 2/5] drm/i915: Only use one link bw config for MST topologies

2018-03-12 Thread Manasi Navare
On Fri, Mar 09, 2018 at 04:32:28PM -0500, Lyude Paul wrote: > When a DP MST link needs retraining, sometimes the hub will detect that > the current link bw config is impossible and will update it's RX caps in > the DPCD to reflect the new maximum link rate. Currently, we make the > assumption that

Re: [PATCH v4 1/6] sysctl: Add flags to support min/max range clamping

2018-03-12 Thread Luis R. Rodriguez
On Mon, Mar 12, 2018 at 04:15:39PM -0400, Waiman Long wrote: > When minimum/maximum values are specified for a sysctl parameter in > the ctl_table structure with proc_dointvec_minmax() handler, update > to that parameter will fail with error if the given value is outside > of the required range. >

Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

2018-03-12 Thread Luis R. Rodriguez
On Mon, Mar 12, 2018 at 04:15:40PM -0400, Waiman Long wrote: > Checking code is added to check for invalid flags in the ctl_table > and return error if an unknown flag is used. This should be merged with the first patch otherwise there are atomic points in time on the commit log history where inva

[PATCH 0/8] Implement get_multiple for ACCES and PC104 drivers

2018-03-12 Thread William Breathitt Gray
This patchset implements get_multiple callbacks for the PC104 GPIO drivers as well as the PCI-IDIO-16 and PCIe-IDIO-24 GPIO drivers. These devices all acquire the multiple input lines with a single read, so utilizing the get_multiple callback can provide improvement for those users who regularly ac

Re: [PATCH v4 1/6] sysctl: Add flags to support min/max range clamping

2018-03-12 Thread Waiman Long
On 03/12/2018 04:44 PM, Luis R. Rodriguez wrote: > On Mon, Mar 12, 2018 at 04:15:39PM -0400, Waiman Long wrote: >> When minimum/maximum values are specified for a sysctl parameter in >> the ctl_table structure with proc_dointvec_minmax() handler, update >> to that parameter will fail with error if

[PATCH 2/8] gpio: 104-idio-16: Implement get_multiple callback

2018-03-12 Thread William Breathitt Gray
The ACCES I/O 104-IDIO-16 series of devices provides 16 optically-isolated digital inputs accessed via two 8-bit ports. Since eight input lines are acquired on a single port input read, the 104-IDIO-16 GPIO driver may improve multiple input reads by utilizing a get_multiple callback. This patch imp

[PATCH 3/8] gpio: pci-idio-16: Implement get_multiple callback

2018-03-12 Thread William Breathitt Gray
The ACCES I/O PCI-IDIO-16 series of devices provides 16 optically-isolated digital inputs accessed via two 8-bit ports. Since eight input lines are acquired on a single port input read, the PCI-IDIO-16 GPIO driver may improve multiple input reads by utilizing a get_multiple callback. This patch imp

[PATCH 4/8] gpio: pcie-idio-24: Implement get_multiple callback

2018-03-12 Thread William Breathitt Gray
The ACCES I/O PCIe-IDIO-24 series of devices provides 24 optically-isolated digital inputs accessed via three 8-bit ports. Since eight input lines are acquired on a single port input read, the PCIe-IDIO-24 GPIO driver may improve multiple input reads by utilizing a get_multiple callback. This patch

[PATCH 1/8] iio: stx104: Implement get_multiple callback

2018-03-12 Thread William Breathitt Gray
The Apex Embedded Systems STX104 series of devices provides 4 TTL compatible lines of inputs accessed via a single 4-bit port. Since four input lines are acquired on a single port input read, the STX104 GPIO driver may improve multiple input reads by utilizing a get_multiple callback. This patch im

[PATCH 5/8] gpio: 104-dio-48e: Implement get_multiple callback

2018-03-12 Thread William Breathitt Gray
The ACCES I/O 104-DIO-48E series of devices contain two Programmable Peripheral Interface (PPI) chips of type 82C55, which each feature three 8-bit ports of I/O. Since eight input lines are acquired on a single port input read, the 104-DIO-48E GPIO driver may improve multiple input reads by utilizi

Re: [PATCH v4 3/6] sysctl: Warn when a clamped sysctl parameter is set out of range

2018-03-12 Thread Luis R. Rodriguez
On Mon, Mar 12, 2018 at 04:15:41PM -0400, Waiman Long wrote: > Even with clamped sysctl parameters, it is still not that straight > forward to figure out the exact range of those parameters. One may > try to write extreme parameter values to see if they get clamped. > To make it easier, a warning w

[PATCH 6/8] gpio: 104-idi-48: Implement get_multiple callback

2018-03-12 Thread William Breathitt Gray
The ACCES I/O 104-IDI-48 series of devices provides 48 optically-isolated inputs accessed via six 8-bit ports. Since eight input lines are acquired on a single port input read, the 104-IDI-48 GPIO driver may improve multiple input reads by utilizing a get_multiple callback. This patch implements th

[PATCH 8/8] gpio: ws16c48: Implement get_multiple callback

2018-03-12 Thread William Breathitt Gray
The WinSystems WS16C48 device provides 48 lines of digital I/O accessed via six 8-bit ports. Since eight input lines are acquired on a single port input read, the WS16C48 GPIO driver may improve multiple input reads by utilizing a get_multiple callback. This patch implements the ws16c48_gpio_get_mu

[PATCH 7/8] gpio: gpio-mm: Implement get_multiple callback

2018-03-12 Thread William Breathitt Gray
The Diamond Systems GPIO-MM series of devices contain two 82C55A devices, which each feature three 8-bit ports of I/O. Since eight input lines are acquired on a single port input read, the GPIO-MM GPIO driver may improve multiple input reads by utilizing a get_multiple callback. This patch implemen

Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

2018-03-12 Thread Andrew Morton
On Mon, 12 Mar 2018 16:15:40 -0400 Waiman Long wrote: > Checking code is added to check for invalid flags in the ctl_table > and return error if an unknown flag is used. Why? What's wrong with the old code, what value does this change add, etc.

Re: [PATCH v4 5/6] ipc: Clamp semmni to the real IPCMNI limit

2018-03-12 Thread Luis R. Rodriguez
On Mon, Mar 12, 2018 at 04:15:43PM -0400, Waiman Long wrote: > + if (clamped) > + pr_warn_once("sysctl: \"sem[3]\" was set out of range [%d, %d], > clamped to %d.\n", > + 0, IPCMNI, ns->sc_semmni); Why warn if the kernel already does that? If we can avoid

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

2018-03-12 Thread Rodrigo Rivas Costa
On Mon, Mar 12, 2018 at 03:30:43PM +0100, Clément VUCHENER wrote: > 2018-03-11 20:58 GMT+01:00 Rodrigo Rivas Costa : > > This patchset implements a driver for Valve Steam Controller, based on a > > reverse analysis by myself. > > > > Sorry, I've been out of town for a few weeks and couldn't keep up

[PATCH] tpm: add tpm_calc_ordinal_duration wrapper

2018-03-12 Thread Tomas Winkler
Add convenient wrapper for ordinal duration computation to remove boiler plate if else statement over TPM2. if (chip->flags & TPM_CHIP_FLAG_TPM2) tpm2_calc_ordinal_duration(chip, ordinal); else tpm1_calc_ordinal_duration(chip, ordinal); Signed-off-by: Tomas Winkler --- drivers/c

Re: [PATCH v4 6/6] test_sysctl: Add range clamping test

2018-03-12 Thread Luis R. Rodriguez
On Mon, Mar 12, 2018 at 04:15:44PM -0400, Waiman Long wrote: > Add a range clamping test for the msgmni sysctl parameter to verify No! We don't want to test production values, please add a new test entry which is similar but does *not* modify system production values! Luis

Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

2018-03-12 Thread Waiman Long
On 03/12/2018 04:46 PM, Luis R. Rodriguez wrote: > On Mon, Mar 12, 2018 at 04:15:40PM -0400, Waiman Long wrote: >> Checking code is added to check for invalid flags in the ctl_table >> and return error if an unknown flag is used. > This should be merged with the first patch otherwise there are atom

Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

2018-03-12 Thread Luis R. Rodriguez
On Mon, Mar 12, 2018 at 04:54:51PM -0400, Waiman Long wrote: > On 03/12/2018 04:46 PM, Luis R. Rodriguez wrote: > > On Mon, Mar 12, 2018 at 04:15:40PM -0400, Waiman Long wrote: > >> Checking code is added to check for invalid flags in the ctl_table > >> and return error if an unknown flag is used.

Re: [PATCH v4 5/6] ipc: Clamp semmni to the real IPCMNI limit

2018-03-12 Thread Waiman Long
On 03/12/2018 04:52 PM, Luis R. Rodriguez wrote: > On Mon, Mar 12, 2018 at 04:15:43PM -0400, Waiman Long wrote: >> +if (clamped) >> +pr_warn_once("sysctl: \"sem[3]\" was set out of range [%d, %d], >> clamped to %d.\n", >> + 0, IPCMNI, ns->sc_semmni); > Why w

Re: [PATCH v4 6/6] test_sysctl: Add range clamping test

2018-03-12 Thread Waiman Long
On 03/12/2018 04:53 PM, Luis R. Rodriguez wrote: > On Mon, Mar 12, 2018 at 04:15:44PM -0400, Waiman Long wrote: >> Add a range clamping test for the msgmni sysctl parameter to verify > No! We don't want to test production values, please add a new test > entry which is similar but does *not* modify

Re: [PATCH v4 3/6] sysctl: Warn when a clamped sysctl parameter is set out of range

2018-03-12 Thread Andrew Morton
On Mon, 12 Mar 2018 16:15:41 -0400 Waiman Long wrote: > Even with clamped sysctl parameters, it is still not that straight > forward to figure out the exact range of those parameters. One may > try to write extreme parameter values to see if they get clamped. > To make it easier, a warning with t

Re: [PATCH v3 1/5] drm/i915: Move DP modeset retry work into intel_dp

2018-03-12 Thread Ville Syrjälä
On Fri, Mar 09, 2018 at 04:32:27PM -0500, Lyude Paul wrote: > While having the modeset_retry_work in intel_connector makes sense with > SST, this paradigm doesn't make a whole ton of sense when it comes to > MST since we have to deal with multiple connectors. In most cases, it's > more useful to ju

Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

2018-03-12 Thread Waiman Long
On 03/12/2018 04:59 PM, Luis R. Rodriguez wrote: > On Mon, Mar 12, 2018 at 04:54:51PM -0400, Waiman Long wrote: >> On 03/12/2018 04:46 PM, Luis R. Rodriguez wrote: >>> On Mon, Mar 12, 2018 at 04:15:40PM -0400, Waiman Long wrote: Checking code is added to check for invalid flags in the ctl_tabl

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Ard Biesheuvel
On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: >> > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > ard.biesheu...@linaro.org> >> > wrote: >> > >> >> On 12 March 2018 at 17:01, Jere

Re: [PATCH v4 3/6] sysctl: Warn when a clamped sysctl parameter is set out of range

2018-03-12 Thread Waiman Long
On 03/12/2018 05:00 PM, Andrew Morton wrote: > On Mon, 12 Mar 2018 16:15:41 -0400 Waiman Long wrote: > >> Even with clamped sysctl parameters, it is still not that straight >> forward to figure out the exact range of those parameters. One may >> try to write extreme parameter values to see if they

Re: [PATCH v3 2/5] drm/i915: Only use one link bw config for MST topologies

2018-03-12 Thread Ville Syrjälä
On Fri, Mar 09, 2018 at 04:32:28PM -0500, Lyude Paul wrote: > When a DP MST link needs retraining, sometimes the hub will detect that > the current link bw config is impossible and will update it's RX caps in > the DPCD to reflect the new maximum link rate. Currently, we make the > assumption that

Re: [PATCH v4 3/6] sysctl: Warn when a clamped sysctl parameter is set out of range

2018-03-12 Thread Waiman Long
On 03/12/2018 04:50 PM, Luis R. Rodriguez wrote: > On Mon, Mar 12, 2018 at 04:15:41PM -0400, Waiman Long wrote: >> Even with clamped sysctl parameters, it is still not that straight >> forward to figure out the exact range of those parameters. One may >> try to write extreme parameter values to see

Re: [PATCH v3 5/5] drm/i915: Implement proper fallback training for MST

2018-03-12 Thread Ville Syrjälä
On Fri, Mar 09, 2018 at 04:32:31PM -0500, Lyude Paul wrote: > @@ -6266,25 +6368,98 @@ static bool intel_edp_init_connector(struct intel_dp > *intel_dp, > return false; > } > > +static void intel_dp_mst_retrain_link_work(struct work_struct *work) > +{ Why do we need another work for this?

Re: [RFC PATCH 04/35] syscalls: do not call sys_getpgid() within the kernel

2018-03-12 Thread Dominik Brodowski
On Mon, Mar 12, 2018 at 01:35:17AM -0700, Christoph Hellwig wrote: > The subject (and lack of description) for this and the following patches > is rather confusing. > > I'd expect something like: > > snip > Subject: kernel: add a do_getpgid helper > > And use it to avoid an in-kernel s

Re: [PATCH 3/3] dcache: account external names as indirectly reclaimable memory

2018-03-12 Thread Al Viro
On Mon, Mar 05, 2018 at 01:37:43PM +, Roman Gushchin wrote: > diff --git a/fs/dcache.c b/fs/dcache.c > index 5c7df1df81ff..a0312d73f575 100644 > --- a/fs/dcache.c > +++ b/fs/dcache.c > @@ -273,8 +273,16 @@ static void __d_free(struct rcu_head *head) > static void __d_free_external(struct rcu_h

Re: [PATCH v3 05/11] PCI/P2PDMA: Add P2P DMA driver writer's documentation

2018-03-12 Thread Logan Gunthorpe
On 3/12/2018 1:41 PM, Jonathan Corbet wrote: This all seems good, but...could we consider moving this documentation to driver-api/PCI as it's converted to RST? That would keep it together with similar materials and bring a bit more coherence to Documentation/ as a whole. Yup, I'll change this

Re: [PATCH v1 1/1] mm/ksm: fix interaction with THP

2018-03-12 Thread Andrew Morton
On Mon, 12 Mar 2018 17:42:17 +0100 Claudio Imbrenda wrote: > This patch fixes a corner case for KSM. When two pages belong or > belonged to the same transparent hugepage, and they should be merged, > KSM fails to split the page, and therefore no merging happens. > > This bug can be reproduced b

Re: [PATCH] ARM: bcm2835: Add the DPI hardware to the device tree.

2018-03-12 Thread Florian Fainelli
On 03/12/2018 10:45 AM, Stefan Wahren wrote: >> Eric Anholt hat am 10. März 2018 um 00:36 geschrieben: >> >> >> It's currently marked disabled, as it's not useful without a panel >> associated with it and the GPIO pins routed to ALT2. >> >> Signed-off-by: Eric Anholt >> --- >> > > FWIW, Acked-by

[PATCH] hwmon/sch5627: Use common error handling code in sch5627_probe()

2018-03-12 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 12 Mar 2018 22:15:59 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hwmon/sch5627.c | 60 +++

Re: [PATCH v3 3/5] drm/dp_mst: Add drm_dp_mst_topology_mgr_lower_link_rate()

2018-03-12 Thread Manasi Navare
On Fri, Mar 09, 2018 at 04:32:29PM -0500, Lyude Paul wrote: > Unlike SST, MST can have far more then a single display hooked up on a > single port. What this also means however, is that if the DisplayPort > link to the top-level MST branch device becomes unstable then every > single branch device a

Re: [PATCH 4/7] Protectable Memory

2018-03-12 Thread Igor Stoppa
On 12/03/18 21:13, Matthew Wilcox wrote: > On Wed, Feb 28, 2018 at 10:06:17PM +0200, Igor Stoppa wrote: >> struct gen_pool *pmalloc_create_pool(const char *name, >> int min_alloc_order); >> int is_pmalloc_object(const void *ptr, const unsigned long n); >> boo

Re: [PATCH v4 14/24] fpga: dfl: fme: add partial reconfiguration sub feature support

2018-03-12 Thread matthew . gerlach
On Mon, 12 Mar 2018, Wu Hao wrote: Hi Hao, Please see my two comments inline. Thanks, Matthew Gerlach On Sun, Mar 11, 2018 at 01:09:31PM -0700, matthew.gerl...@linux.intel.com wrote: On Mon, 5 Mar 2018, Alan Tull wrote: Hi Hao, I do think we should consider different hw implementation

Re: [RFC PATCH 00/35] remove in-kernel syscall invocations

2018-03-12 Thread Dominik Brodowski
On Sun, Mar 11, 2018 at 01:15:59PM -0700, Linus Torvalds wrote: > On Sun, Mar 11, 2018 at 3:55 AM, Dominik Brodowski > wrote: > > Here is a first set of patches which reduce the number of syscall > > invocations > > from within the kernel. > > This all looks ok to me. I think there may be some r

linux-next: manual merge of the qcom tree with the amlogic tree

2018-03-12 Thread Stephen Rothwell
Hi Andy, Today's linux-next merge of the qcom tree got a conflict in: arch/arm64/configs/defconfig between commit: 266c157de3b2 ("arm64: defconfig: enable MESON EFUSE") from the amlogic tree and commit: 52fe48c2b9bb ("arm64: defconfig: enable thermal sensor on QCOM platforms") from the

Re: [PATCH 2/3 v3] devpts: resolve devpts bind-mounts

2018-03-12 Thread Linus Torvalds
On Mon, Mar 12, 2018 at 1:10 PM, Christian Brauner wrote: >> >> So let's just change the behavior of devpts_mntget error if a mount with >> the pty underneath it can not be found. > > I'm sort of torn but I think I'd prefer changing the behavior too. The > /dev/ptmx, /dev/pts/ptmx schisma is reall

Re: [PATCH] device_handler: remove VLAs

2018-03-12 Thread Stephen Kitt
On Mon, 12 Mar 2018 15:41:26 +, Bart Van Assche wrote: > On Sat, 2018-03-10 at 14:14 +0100, Stephen Kitt wrote: > > The two patches I sent were supposed to be alternative solutions; see > > https://marc.info/?l=linux-scsi&m=152063671005295&w=2 for the > > introduction (I seem to have messed up

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

2018-03-12 Thread Mimi Zohar
On Fri, 2018-03-09 at 09:11 -0800, James Bottomley wrote: > On Thu, 2018-03-08 at 12:42 -0600, Jiandi An wrote: > [...] > > I'm no expert on IMA and its driver.  James, will you be kind enough > > to look into overhauling the IMA driver to not measure until after  > > initrd phase if that's the con

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

2018-03-12 Thread Jason Gunthorpe
On Mon, Mar 12, 2018 at 05:53:18PM -0400, Mimi Zohar wrote: > Using Kconfig to force the TPM to be builtin is not required, but > helpful.  Users interested in IMA-measurement could configure the TPM > as builtin themselves.  Without the TPM builtin, IMA goes into TPM- > bypass mode. This issues,

Re: [PATCH v3 5/5] drm/i915: Implement proper fallback training for MST

2018-03-12 Thread Manasi Navare
On Fri, Mar 09, 2018 at 04:32:31PM -0500, Lyude Paul wrote: > For a while we actually haven't had any way of retraining MST links with > fallback link parameters like we do with SST. While uncommon, certain > setups such as my Caldigit TS3 + EVGA MST hub require this since > otherwise, they end up

Re: [RFC v2] vfio iommu type1: improve memory pinning process for raw PFN mapping

2018-03-12 Thread Alex Williamson
On Sat, 3 Mar 2018 20:10:33 +0800 "Jason Cai (Xiang Feng)" wrote: > When using vfio to pass through a PCIe device (e.g. a GPU card) that > has a huge BAR (e.g. 16GB), a lot of cycles are wasted on memory > pinning because PFNs of PCI BAR are not backed by struct page, and > the corresponding VMA

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-12 Thread Dominik Brodowski
On Mon, Mar 12, 2018 at 01:23:19PM -0700, Darren Hart wrote: > On Mon, Mar 12, 2018 at 07:53:57PM +0100, Dominik Brodowski wrote: > > Mario, > > > > unfortunately, my Dell Inc. XPS 13 9343/0TM99H, BIOS A11 12/08/2016 fails to > > boot v4.16-rc5. More exactly, I could bisect it down to commit 25d47

Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

2018-03-12 Thread Waiman Long
On 03/12/2018 04:52 PM, Andrew Morton wrote: > On Mon, 12 Mar 2018 16:15:40 -0400 Waiman Long wrote: > >> Checking code is added to check for invalid flags in the ctl_table >> and return error if an unknown flag is used. > Why? What's wrong with the old code, what value does this change add, > et

Re: dcache: remove trylock loops (was Re: [BUG] lock_parent() breakage when used from shrink_dentry_list())

2018-03-12 Thread Thomas Gleixner
On Mon, 12 Mar 2018, Al Viro wrote: > On Tue, Feb 27, 2018 at 06:16:28AM +0100, John Ogness wrote: > What we get out of that is > a) much saner semantics for d_move() et.al. > b) saner behaviour of d_path() (see above) > c) dentry can be IS_ROOT only if it has been > such all alon

Re: [PATCH v3 5/5] drm/i915: Implement proper fallback training for MST

2018-03-12 Thread Lyude Paul
On Mon, 2018-03-12 at 15:05 -0700, Manasi Navare wrote: > On Fri, Mar 09, 2018 at 04:32:31PM -0500, Lyude Paul wrote: > > For a while we actually haven't had any way of retraining MST links with > > fallback link parameters like we do with SST. While uncommon, certain > > setups such as my Caldigit

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-12 Thread Linus Torvalds
On Mon, Mar 12, 2018 at 3:07 PM, Dominik Brodowski wrote: > > I'm awfully sorry, but this patch doesn't solve the issue. > CONFIG_ACPI_WMI=y was/is set, but still enabling CONFIG_DELL_SMBIOS_WMI=y > causes a very-early crash of v4.16-rc5. In fact, so early that the normal > boot messages never sho

Re: linux-4.16-rc5/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:1723]: (warning) Possible null pointer dereference: pipe_ctx

2018-03-12 Thread Andrey Grodzovsky
On 03/12/2018 06:22 AM, David Binderman wrote: hello there, Source code is     for (i = 0; i < dc->res_pool->pipe_count; i++) {     if (res_ctx->pipe_ctx[i].stream) {     pipe_ctx = &res_ctx->pipe_ctx[i];     *pipe_idx = i;     break;     }     } Inde

Re: Future of STACKLEAK plugin?

2018-03-12 Thread Linus Torvalds
On Mon, Mar 12, 2018 at 10:06 AM, Kees Cook wrote: > > I was curious, after the last week of discussion, what you thought of > the future of Alexander's port of the STACKLEAK plugin[0]. Given that > there is progress being made (by at least 8 people at last count) to > actually remove VLAs (and bo

[PATCH v5 0/2] x86/devicetree: Enable multiprocessing

2018-03-12 Thread Ivan Gorinov
Current x86 implementation of Device Tree does not support multiprocessing, and the bindings documentation describes the "reg" property as CPU number instead of hardware-assigned local APIC ID. Ivan Gorinov (2): of: Documentation: Specify local APIC ID in "reg" x86/devicetree: Use CPU descript

[PATCH v5 1/2] of: Documentation: Specify local APIC ID in "reg"

2018-03-12 Thread Ivan Gorinov
Set the "reg" property to the processor's local APIC ID. Local APIC ID is assigned by hardware and may differ from CPU number. Signed-off-by: Ivan Gorinov --- Documentation/devicetree/bindings/x86/ce4100.txt | 38 ++-- 1 file changed, 29 insertions(+), 9 deletions(-) diff --

Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

2018-03-12 Thread Rafael J. Wysocki
On Mon, Mar 12, 2018 at 8:49 PM, Pavel Machek wrote: > On Mon 2018-03-12 20:47:15, Pavel Machek wrote: >> Hi! >> >> Did something change recently with battery reporting? Yes, it did, and specifically for Thinkpads. >> Fully charged >> battery shows as empty battery with red "x" in Mate desktop.

[PATCH v5 2/2] x86/devicetree: Use CPU description from Device Tree

2018-03-12 Thread Ivan Gorinov
Current x86 Device Tree implementation does not support multiprocessing. Use new DT bindings to describe the processors. Signed-off-by: Ivan Gorinov --- arch/x86/kernel/devicetree.c | 42 +++--- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/a

Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430

2018-03-12 Thread Merlijn Wajer
Hi Bin, On 09/03/18 15:11, Bin Liu wrote: > Hi, > > On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote: >> This fixes an oops on unbind / module unload (on the musb omap2430 >> platform). >> >> musb_remove function now calls musb_platform_exit before disabling >> runtime pm. >> >> Sign

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

2018-03-12 Thread James Bottomley
On Mon, 2018-03-12 at 17:53 -0400, Mimi Zohar wrote: > On Fri, 2018-03-09 at 09:11 -0800, James Bottomley wrote: > > > > On Thu, 2018-03-08 at 12:42 -0600, Jiandi An wrote: > > [...] > > > > > > I'm no expert on IMA and its driver.  James, will you be kind > > > enough to look into overhauling th

Re: [PATCH 11/13] perf bpf: Add helper header files

2018-03-12 Thread Jiri Olsa
On Mon, Mar 12, 2018 at 04:25:51PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > > > right, I kept this way, because it was already there for kernel, > > so it was fast to write ;-) > > > > but it's true we could leave it symbol based and have some sort of > > dynamic loader behaviour.. but w

Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

2018-03-12 Thread Ognjen Galić
On Mon, Mar 12, 2018 at 11:29:56PM +0100, Rafael J. Wysocki wrote: > On Mon, Mar 12, 2018 at 8:49 PM, Pavel Machek wrote: > > On Mon 2018-03-12 20:47:15, Pavel Machek wrote: > >> Hi! > >> > >> Did something change recently with battery reporting? > > Yes, it did, and specifically for Thinkpads.

Re: [PATCH 3/3] dcache: account external names as indirectly reclaimable memory

2018-03-12 Thread Roman Gushchin
On Mon, Mar 12, 2018 at 09:17:42PM +, Al Viro wrote: > On Mon, Mar 05, 2018 at 01:37:43PM +, Roman Gushchin wrote: > > diff --git a/fs/dcache.c b/fs/dcache.c > > index 5c7df1df81ff..a0312d73f575 100644 > > --- a/fs/dcache.c > > +++ b/fs/dcache.c > > @@ -273,8 +273,16 @@ static void __d_free

RE: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-12 Thread Mario.Limonciello
> -Original Message- > From: Dominik Brodowski [mailto:li...@dominikbrodowski.net] > Sent: Tuesday, March 13, 2018 2:54 AM > To: dvh...@infradead.org; Limonciello, Mario > Cc: platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Dell Inc. XPS 13 9343/0TM99H fails

Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

2018-03-12 Thread Andrew Morton
On Mon, 12 Mar 2018 18:12:47 -0400 Waiman Long wrote: > On 03/12/2018 04:52 PM, Andrew Morton wrote: > > On Mon, 12 Mar 2018 16:15:40 -0400 Waiman Long wrote: > > > >> Checking code is added to check for invalid flags in the ctl_table > >> and return error if an unknown flag is used. > > Why? W

Re: [PATCH] ARM: dts: NSP: Switch to port 8 for CPU port

2018-03-12 Thread Florian Fainelli
On Tue, 27 Feb 2018 12:45:19 -0800, Florian Fainelli wrote: > Now that we have added support for pre-pended Broadcom tags with commit > 11606039604c ("net: dsa: b53: Support prepended Broadcom tags") we can > switch all the Northstar Plus reference boards to use port 8 for the CPU > port. This al

Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-12 Thread Gustavo A. R. Silva
Hi Borislav, On 03/10/2018 08:04 AM, Borislav Petkov wrote: On Fri, Mar 09, 2018 at 09:02:18PM -0600, Gustavo A. R. Silva wrote: In preparation to enabling -Wvla, remove VLA and replace it with a fixed-length array instead. Fixed as part of the directive to remove all VLAs from the kernel: htt

Re: [PATCH] ARM: BCM5301X: Fix NAND ECC parameters for Linksys Panamera

2018-03-12 Thread Florian Fainelli
On 03/11/2018 03:03 AM, Vivek Unune wrote: > Hi Rafał, > > On Sat, Mar 10, 2018 at 10:41:04PM +0100, Rafał Miłecki wrote: >> On 10 March 2018 at 18:12, Vivek Unune wrote: >>> Using BCH8 gives ecc errors and makes the router unsuable. >>> Switching to BCH1 fixes these errors. >> >> Can you provide

Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical

2018-03-12 Thread Stephen Boyd
Quoting Thierry Reding (2018-03-12 00:04:30) > On Fri, Mar 09, 2018 at 09:33:06AM -0800, Stephen Boyd wrote: > > > > Are you going to send us a PR at some point? > > Yes, I was going to let the patches cook a little in linux-next and send > a PR by the end of the week. Does that sound okay? > P

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-12 Thread Andrew Morton
On Fri, 9 Mar 2018 17:30:15 -0800 Kees Cook wrote: > > It's one reason why I wondered if simplifying the expression to have > > just that single __builtin_constant_p() might not end up working.. > > Yeah, it seems like it doesn't bail out as "false" for complex > expressions given to __builtin_c

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

2018-03-12 Thread Mimi Zohar
On Mon, 2018-03-12 at 15:59 -0600, Jason Gunthorpe wrote: > On Mon, Mar 12, 2018 at 05:53:18PM -0400, Mimi Zohar wrote: > > > Using Kconfig to force the TPM to be builtin is not required, but > > helpful.  Users interested in IMA-measurement could configure the TPM > > as builtin themselves.  With

Re: [PATCH v3] kconfig: make unmet dependency warnings readable

2018-03-12 Thread Eugeniu Rosca
Hi Masahiro, Some "final polishing" review comments. Feel free to pick/drop them at your will. On Sun, Mar 11, 2018 at 12:51:59AM +0900, Masahiro Yamada wrote: > Currently, the unmet dependency warnings end up with endlessly long > expressions, most of which are false positives. > > Here is test

Re: [PATCH] proc: reject "." and ".." as filenames

2018-03-12 Thread Andrew Morton
On Sat, 10 Mar 2018 03:12:23 +0300 Alexey Dobriyan wrote: > Various subsystems can create files and directories in /proc > with names directly controlled by userspace. > > Which means "/", "." and ".." are no-no. > > "/" split is already taken care of, do the other 2 prohibited names. > > ---

[PATCH net] net: dsa: Fix dsa_is_user_port() test inversion

2018-03-12 Thread Florian Fainelli
During the conversion to dsa_is_user_port(), a condition ended up being reversed, which would prevent the creation of any user port when using the legacy binding and/or platform data, fix that. Fixes: 4a5b85ffe2a0 ("net: dsa: use dsa_is_user_port everywhere") Signed-off-by: Florian Fainelli ---

Guidelines for Submitting an RFC PATCH

2018-03-12 Thread Joe Smith
Hi All, What are the guidelines for submitting an RFC patch? If a developer wants to get early input on a design is it fine to submit a patch that is in reasonable shape but does not fully meets the requirements of a regular patch, for example, the patch consists of a series of patches, it only co

Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

2018-03-12 Thread Pavel Machek
Hi! > > >> Fully charged > > >> battery shows as empty battery with red "x" in Mate desktop. After > > >> reboot to recent mainline problem goes away. Tooltip says "battery > > >> waiting to charge". > > >> > > For the MATE bug see: > https://github.com/mate-desktop/mate-power-manager/pull/251 >

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

2018-03-12 Thread Jason Gunthorpe
On Mon, Mar 12, 2018 at 06:58:45PM -0400, Mimi Zohar wrote: > On Mon, 2018-03-12 at 15:59 -0600, Jason Gunthorpe wrote: > > On Mon, Mar 12, 2018 at 05:53:18PM -0400, Mimi Zohar wrote: > > > > > Using Kconfig to force the TPM to be builtin is not required, but > > > helpful.  Users interested in IM

<    4   5   6   7   8   9   10   11   >