Hello

Good day dear, i hope this mail meets you well? I know this may seem inappropriate so i ask for your forgiveness but i wish to get to know you better, if I may be so bold. I consider myself an easy-going man, adventurous, honest and fun loving person but I am currently looking for a

Re: [PATCH] audit: add containerid support for IMA-audit

On 2018-03-08 13:02, Mimi Zohar wrote: > On Thu, 2018-03-08 at 06:21 -0500, Richard Guy Briggs wrote: > > On 2018-03-05 09:24, Mimi Zohar wrote: > > > On Mon, 2018-03-05 at 08:50 -0500, Richard Guy Briggs wrote: > > > > On 2018-03-05 08:43, Mimi Zohar wrote: > > > > > Hi Richard, > > > > > > > >

Re: [PATCH 2/2] watchdog: aspeed: Allow configuring for alternate boot

On Sat, Mar 10, 2018 at 8:28 AM, Eddie James wrote: > From: Milton Miller > > Allow the device tree to specify a watchdog to fallover to > the alternate boot source. > > The aspeeed watchdog can set a latch directing flash chip select 0 to > chip

[PATCH 1/2] big key: get rid of stack array allocation

We're interested in getting rid of all of the stack allocated arrays in the kernel [1]. This patch removes one in keys by switching to malloc/free. Note that we use kzalloc, to avoid leaking the nonce. I'm not sure this is really necessary, but extra paranoia seems prudent. Manually tested using

[PATCH 2/2] dh key: get rid of stack array allocation

Similarly to the previous patch, we would like to get rid of stack allocated arrays: https://lkml.org/lkml/2018/3/7/621 In this case, we can also use a malloc style approach to free the temporary buffer, being careful to also use kzfree to free them (indeed, at least one of these has a

[PATCH] arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

To enable UBSAN on arm, ARCH_HAS_UBSAN_SANITIZE_ALL is needed to be selected. Basic test has passed on Raspberry Pi2, Raspbian jessi lite with CONFIG_UBSAN_SANITIZE_ALL, CONFIG_UBSAN_NULL. Signed-off-by: Jinbum Park --- arch/arm/Kconfig | 1 +

Re: [PATCH] arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

On 03/13/2018 01:53 PM, Jinbum Park wrote: > To enable UBSAN on arm, ARCH_HAS_UBSAN_SANITIZE_ALL is needed to be selected. > > Basic test has passed on Raspberry Pi2, Raspbian jessi lite with > CONFIG_UBSAN_SANITIZE_ALL, CONFIG_UBSAN_NULL. > > Signed-off-by: Jinbum Park >

Re: [PATCH] arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

On 03/13/2018 01:53 PM, Jinbum Park wrote: > To enable UBSAN on arm, ARCH_HAS_UBSAN_SANITIZE_ALL is needed to be selected. > > Basic test has passed on Raspberry Pi2, Raspbian jessi lite with > CONFIG_UBSAN_SANITIZE_ALL, CONFIG_UBSAN_NULL. This patch had been already sent from Seungwoo.

Re: [PATCH 1/1] net: check dev->reg_state before deref of napi netdev_ops

On Mon, Mar 12, 2018 at 4:17 PM, Cong Wang wrote: > On Sun, Mar 11, 2018 at 12:22 PM, Josh Elsasser wrote: >> init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads >> to a NULL pointer dereference when sk_busy_loop fires against an

Re: [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

On 03/12/2018 10:32 PM, Josh Elsasser wrote: init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. Avoid this by ensuring

RE: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, March 12, 2018 4:37 PM > To: Razvan Stefanescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; Alexander

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

On Mon, Mar 12, 2018 at 05:53:18PM -0400, Mimi Zohar wrote: > Using Kconfig to force the TPM to be builtin is not required, but > helpful.  Users interested in IMA-measurement could configure the TPM > as builtin themselves.  Without the TPM builtin, IMA goes into TPM- > bypass mode. This

Re: [PATCH v3 5/5] drm/i915: Implement proper fallback training for MST

On Mon, 2018-03-12 at 15:05 -0700, Manasi Navare wrote: > On Fri, Mar 09, 2018 at 04:32:31PM -0500, Lyude Paul wrote: > > For a while we actually haven't had any way of retraining MST links with > > fallback link parameters like we do with SST. While uncommon, certain > > setups such as my

Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

On Mon, 12 Mar 2018 18:12:47 -0400 Waiman Long wrote: > On 03/12/2018 04:52 PM, Andrew Morton wrote: > > On Mon, 12 Mar 2018 16:15:40 -0400 Waiman Long wrote: > > > >> Checking code is added to check for invalid flags in the ctl_table > >> and return

RE: [PATCH v5 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver

Hi Sudeep, > -Original Message- > From: Sudeep Holla [mailto:sudeep.ho...@arm.com] > Sent: Thursday, March 08, 2018 4:19 AM > To: Jolly Shah ; michal.si...@xilinx.com > Cc: Sudeep Holla ; ard.biesheu...@linaro.org; > mi...@kernel.org;

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

On Mon, Mar 12, 2018 at 06:58:45PM -0400, Mimi Zohar wrote: > On Mon, 2018-03-12 at 15:59 -0600, Jason Gunthorpe wrote: > > On Mon, Mar 12, 2018 at 05:53:18PM -0400, Mimi Zohar wrote: > > > > > Using Kconfig to force the TPM to be builtin is not required, but > > > helpful.  Users interested in

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

On Mon, Mar 12, 2018 at 03:17:57PM -0700, Linus Torvalds wrote: > On Mon, Mar 12, 2018 at 3:07 PM, Dominik Brodowski > wrote: > > > > I'm awfully sorry, but this patch doesn't solve the issue. > > CONFIG_ACPI_WMI=y was/is set, but still enabling

Re: [PATCH 1/4] gpio: Remove VLA from gpiolib

On 03/12/2018 08:00 AM, Rasmus Villemoes wrote: On 2018-03-10 01:10, Laura Abbott wrote: /* collect all inputs belonging to the same chip */ first = i; - memset(mask, 0, sizeof(mask)); + memset(mask, 0, sizeof(*mask)); see below @@

Re: dcache: remove trylock loops (was Re: [BUG] lock_parent() breakage when used from shrink_dentry_list())

ebied...@xmission.com (Eric W. Biederman) writes: > Al Viro writes: > >> On Mon, Mar 12, 2018 at 03:23:44PM -0500, Eric W. Biederman wrote: >> >>> Of the two code paths you are concert about: >>> >>> For path path_connected looking at s_root is a heuristic to avoid >>>

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

On Mon, 12 Mar 2018 19:54:14 +0100 Jiri Olsa wrote: > On Mon, Mar 12, 2018 at 02:40:01PM -0400, Steven Rostedt wrote: > > On Mon, 12 Mar 2018 16:10:17 +0100 > > Jiri Olsa wrote: > > > > > got it crashed when clearing the filter via 'echo > filter' > > >

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

On Mon, 2018-03-12 at 19:30 -0400, Mimi Zohar wrote: > On Mon, 2018-03-12 at 15:30 -0700, James Bottomley wrote: > > > > On Mon, 2018-03-12 at 17:53 -0400, Mimi Zohar wrote: > [...] > > > > > > > > - This use case, when the TPM is not builtin and unavailable > > > before > > > IMA is

Re: [RFC] perf: a different approach to perf_rotate_context()

> On Mar 3, 2018, at 7:26 AM, Peter Zijlstra wrote: > > On Thu, Mar 01, 2018 at 11:53:21AM -0800, Song Liu wrote: > >> Second, flexible_groups in cpuctx->ctx and cpuctx->task_ctx now have >> exact same priority and equal chance to run. I am not sure whether this >> will

Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

On Tue, Mar 13, 2018 at 12:18:47AM +0100, Pavel Machek wrote: > Hi! > > > >> > >> Fully charged > > >> > >> battery shows as empty battery with red "x" in Mate desktop. After > > >> > >> reboot to recent mainline problem goes away. Tooltip says "battery > > >> > >> waiting to charge". > > >> > >>

Re: [PATCH v4 14/24] fpga: dfl: fme: add partial reconfiguration sub feature support

On Mon, 12 Mar 2018, Wu Hao wrote: Hi Hao, Please see my two comments inline. Thanks, Matthew Gerlach On Sun, Mar 11, 2018 at 01:09:31PM -0700, matthew.gerl...@linux.intel.com wrote: On Mon, 5 Mar 2018, Alan Tull wrote: Hi Hao, I do think we should consider different hw

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

On Mon, Mar 12, 2018 at 01:23:19PM -0700, Darren Hart wrote: > On Mon, Mar 12, 2018 at 07:53:57PM +0100, Dominik Brodowski wrote: > > Mario, > > > > unfortunately, my Dell Inc. XPS 13 9343/0TM99H, BIOS A11 12/08/2016 fails to > > boot v4.16-rc5. More exactly, I could bisect it down to commit

[PATCH v5 0/2] x86/devicetree: Enable multiprocessing

Current x86 implementation of Device Tree does not support multiprocessing, and the bindings documentation describes the "reg" property as CPU number instead of hardware-assigned local APIC ID. Ivan Gorinov (2): of: Documentation: Specify local APIC ID in "reg" x86/devicetree: Use CPU

[PATCH v5 1/2] of: Documentation: Specify local APIC ID in "reg"

Set the "reg" property to the processor's local APIC ID. Local APIC ID is assigned by hardware and may differ from CPU number. Signed-off-by: Ivan Gorinov --- Documentation/devicetree/bindings/x86/ce4100.txt | 38 ++-- 1 file changed, 29

[PATCH v5 2/2] x86/devicetree: Use CPU description from Device Tree

Current x86 Device Tree implementation does not support multiprocessing. Use new DT bindings to describe the processors. Signed-off-by: Ivan Gorinov --- arch/x86/kernel/devicetree.c | 42 +++--- 1 file changed, 31 insertions(+), 11

Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

On Mon, Mar 12, 2018 at 8:49 PM, Pavel Machek wrote: > On Mon 2018-03-12 20:47:15, Pavel Machek wrote: >> Hi! >> >> Did something change recently with battery reporting? Yes, it did, and specifically for Thinkpads. >> Fully charged >> battery shows as empty battery with red "x" in

Re: [RFC PATCH] MIPS: Provide cmpxchg64 for 32-bit builds

On Wed, Feb 14, 2018 at 09:36:33PM +, Keller, Jacob E wrote: > > -Original Message- > > From: Michael, Alice > > Sent: Wednesday, February 14, 2018 1:03 PM > > To: Guenter Roeck ; James Hogan ; > > Keller, Jacob E > >

[PATCH 3/3 v4] selftests: add devpts selftests

This adds tests to check: - bind-mounts from /dev/pts/ptmx to /dev/ptmx work - non-standard mounts of devpts work - bind-mounts of /dev/pts/ptmx to locations that do not resolve to a valid slave pty path under the originating devpts mount fail Signed-off-by: Christian Brauner

[PATCH 2/3 v4] devpts: resolve devpts bind-mounts

Most libcs will still look at /dev/ptmx when opening the master fd of a pty device. When /dev/ptmx is a bind-mount of /dev/pts/ptmx and the TIOCGPTPEER ioctl() is used to safely retrieve a file descriptor for the slave side of the pty based on the master fd, the /proc/self/fd/{0,1,2} symlinks will

[PATCH 1/3 v4] devpts: hoist out check for DEVPTS_SUPER_MAGIC

Hoist the check whether we have already found a suitable devpts filesystem out of devpts_ptmx_path() in preparation for the devpts bind-mount resolution patch. This is a non-functional change. Signed-off-by: Christian Brauner --- ChangeLog v3->v4: * patch unchanged

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got conflicts in: drivers/net/ethernet/mellanox/mlxsw/spectrum.h drivers/net/ethernet/mellanox/mlxsw/spectrum.c between commit: 663f1b26f9c1 ("mlxsw: spectrum: Prevent duplicate mirrors") from the net tree and commit: a629ef210d89

Re: [PATCH] scsi: eata: drop VLA in reorder()

Linus Torvalds wrote on 13/03/18 05:15: On Sun, Mar 11, 2018 at 8:08 PM, Tobin C. Harding wrote: I think we are going to see a recurring theme here. MAX_MAILBOXES==64 so this patch adds 1536 bytes to the stack on a 64 bit machine or 768 bytes on a 32 bit machine.

linux-next: manual merge of the drm tree with Linus' tree

Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c between commit: a0aaa03062be ("drm/amd/powerplay: fix power over limit on Fiji") from the Linus' and commit: a5278e511dce ("drm/amd/pp: Revert gfx/compute profile switch

[PATCH v2] iio:magnetometer: Remove duplications in iio_chan_spec

The magn_3d_channels array has multiple declarations of iio_chan_spec. Most of the iio_chan_spec are very similar, changing only by the .type and .channel2 field. This patch reduces the code duplication by adding a macro that can replace the iio_chan_spec repetitions in the magn_3d_channels

Re: [PATCH v3 08/11] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On 3/12/2018 3:35 PM, Logan Gunthorpe wrote: > - if (nvmeq->sq_cmds_io) I think you should keep the code as it is for the case where (!nvmeq->sq_cmds_is_io && nvmeq->sq_cmds_io) You are changing the behavior for NVMe drives with CMB buffers. You can change the if statement here with the

Re: [PATCH] ARM: bcm2835: Add the DPI hardware to the device tree.

On 03/12/2018 10:45 AM, Stefan Wahren wrote: >> Eric Anholt hat am 10. März 2018 um 00:36 geschrieben: >> >> >> It's currently marked disabled, as it's not useful without a panel >> associated with it and the GPIO pins routed to ALT2. >> >> Signed-off-by: Eric Anholt

[PATCH] hwmon/sch5627: Use common error handling code in sch5627_probe()

From: Markus Elfring Date: Mon, 12 Mar 2018 22:15:59 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [PATCH 4/7] Protectable Memory

On 12/03/18 21:13, Matthew Wilcox wrote: > On Wed, Feb 28, 2018 at 10:06:17PM +0200, Igor Stoppa wrote: >> struct gen_pool *pmalloc_create_pool(const char *name, >> int min_alloc_order); >> int is_pmalloc_object(const void *ptr, const unsigned long n); >>

Re: [RFC PATCH 00/35] remove in-kernel syscall invocations

On Sun, Mar 11, 2018 at 01:15:59PM -0700, Linus Torvalds wrote: > On Sun, Mar 11, 2018 at 3:55 AM, Dominik Brodowski > wrote: > > Here is a first set of patches which reduce the number of syscall > > invocations > > from within the kernel. > > This all looks ok to

Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

On Mon, Mar 12, 2018 at 11:29:56PM +0100, Rafael J. Wysocki wrote: > On Mon, Mar 12, 2018 at 8:49 PM, Pavel Machek wrote: > > On Mon 2018-03-12 20:47:15, Pavel Machek wrote: > >> Hi! > >> > >> Did something change recently with battery reporting? > > Yes, it did, and specifically

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

On Mon, 2018-03-12 at 17:05 -0600, Jason Gunthorpe wrote: > On Mon, Mar 12, 2018 at 06:58:45PM -0400, Mimi Zohar wrote: > > On Mon, 2018-03-12 at 15:59 -0600, Jason Gunthorpe wrote: > > > On Mon, Mar 12, 2018 at 05:53:18PM -0400, Mimi Zohar wrote: > > > > > > > Using Kconfig to force the TPM to

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

On Mon, 2018-03-12 at 15:30 -0700, James Bottomley wrote: > On Mon, 2018-03-12 at 17:53 -0400, Mimi Zohar wrote: [...] > > - This use case, when the TPM is not builtin and unavailable before > > IMA is initialized. > > > > I would classify this use case as an IMA testing/debugging > >

Re: [PATCH 4.4 13/36] ARM: dts: LogicPD Torpedo: Fix I2C1 pinmux

On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > -- > > From: Adam Ford > > commit 74402055a2d3ec998a1ded599e86185a27d9bbf4 upstream. > > The pinmuxing was missing

Re: dcache: remove trylock loops (was Re: [BUG] lock_parent() breakage when used from shrink_dentry_list())

Al Viro writes: > On Mon, Mar 12, 2018 at 03:23:44PM -0500, Eric W. Biederman wrote: > >> Of the two code paths you are concert about: >> >> For path path_connected looking at s_root is a heuristic to avoid >> calling is_subdir every time we need to do that check. If

[PATCH 0/3 v4] devpts: handle bind-mounts

Hey everyone, This is the fourth iteration of this patch. Relevant changes are. ChangeLog v3->v4: * small logical simplifications * add test that bind-mounts of /dev/pts/ptmx to locations that do not resolve to a valid slave pty path under the originating devpts mount fail ChangeLog v2->v3:

Re: [PATCH 1/3 v4] devpts: hoist out check for DEVPTS_SUPER_MAGIC

Christian Brauner writes: > Hoist the check whether we have already found a suitable devpts filesystem > out of devpts_ptmx_path() in preparation for the devpts bind-mount > resolution patch. This is a non-functional change. > > Signed-off-by: Christian Brauner

Re: [PATCH v5 06/36] drm/rockchip: Only wait for panel ACK on PSR entry

On 12/03/18 17:58, Heiko Stübner wrote: > Hi, > > the subject is misleading I think, as this is touching only the generic > bridge code and not anything Rockchip-related, so should probably > be "drm/bridge"? > Right, I'll fix this when I need to send another version, I'll wait, for now, a

Re: [PATCH] ARM: BCM5301X: Fix NAND ECC parameters for Linksys Panamera

Hi Florian, On Mon, Mar 12, 2018 at 03:52:27PM -0700, Florian Fainelli wrote: > On 03/11/2018 03:03 AM, Vivek Unune wrote: > > Hi Rafał, > > > > On Sat, Mar 10, 2018 at 10:41:04PM +0100, Rafał Miłecki wrote: > >> On 10 March 2018 at 18:12, Vivek Unune wrote: > >>> Using

Re: [tip:x86/mm] x86/tme: Detect if TME and MKTME is activated by BIOS

On Mon, 2018-03-12 at 05:21 -0700, tip-bot for Kirill A. Shutemov wrote: > Commit-ID: cb06d8e3d020c30fe10ae711c925a5319ab82c88 > Gitweb: https://git.kernel.org/tip/cb06d8e3d020c30fe10ae711c925a5 > 319ab82c88 > Author: Kirill A. Shutemov > AuthorDate: Mon,

Re: [RFC v2] vfio iommu type1: improve memory pinning process for raw PFN mapping

On Sat, 3 Mar 2018 20:10:33 +0800 "Jason Cai (Xiang Feng)" wrote: > When using vfio to pass through a PCIe device (e.g. a GPU card) that > has a huge BAR (e.g. 16GB), a lot of cycles are wasted on memory > pinning because PFNs of PCI BAR are not backed by struct

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

On Mon, Mar 12, 2018 at 3:07 PM, Dominik Brodowski wrote: > > I'm awfully sorry, but this patch doesn't solve the issue. > CONFIG_ACPI_WMI=y was/is set, but still enabling CONFIG_DELL_SMBIOS_WMI=y > causes a very-early crash of v4.16-rc5. In fact, so early that the

Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430

Hi Bin, On 09/03/18 15:11, Bin Liu wrote: > Hi, > > On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote: >> This fixes an oops on unbind / module unload (on the musb omap2430 >> platform). >> >> musb_remove function now calls musb_platform_exit before disabling >> runtime pm. >> >>

RE: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

> -Original Message- > From: Dominik Brodowski [mailto:li...@dominikbrodowski.net] > Sent: Tuesday, March 13, 2018 2:54 AM > To: dvh...@infradead.org; Limonciello, Mario > Cc: platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Dell

Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical

Quoting Thierry Reding (2018-03-12 00:04:30) > On Fri, Mar 09, 2018 at 09:33:06AM -0800, Stephen Boyd wrote: > > > > Are you going to send us a PR at some point? > > Yes, I was going to let the patches cook a little in linux-next and send > a PR by the end of the week. Does that sound okay? >

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Fri, 9 Mar 2018 17:30:15 -0800 Kees Cook wrote: > > It's one reason why I wondered if simplifying the expression to have > > just that single __builtin_constant_p() might not end up working.. > > Yeah, it seems like it doesn't bail out as "false" for complex >

RE: linux-4.16-rc5/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:1723]: (warning) Possible null pointer dereference: pipe_ctx

There is a check just before for-loop that should ensure pipe_ctx is not null: /* Only supports single display */ if (context->stream_count != 1) return false; To remove the subject warning - we can rather add an assert: assert(pipe_ctx); Thanks, Roman

Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

On Tue, Mar 13, 2018 at 12:04 AM, Pavel Machek wrote: > Hi! > >> > >> Fully charged >> > >> battery shows as empty battery with red "x" in Mate desktop. After >> > >> reboot to recent mainline problem goes away. Tooltip says "battery >> > >> waiting to charge". >> > >> >> >> For the

[PATCH] netfilter: cttimeout: remove VLA usage

In preparation to enabling -Wvla, remove VLA and replace it with dynamic memory allocation. >From a security viewpoint, the use of Variable Length Arrays can be a vector for stack overflow attacks. Also, in general, as the code evolves it is easy to lose track of how big a VLA can get. Thus, we

Re: [PATCH] rtc: mcp795: remove VLA usage

Hi, On 13/03/2018 at 00:13:38 +0100, Stefano Manni wrote: > In preparation to enabling -Wvla, remove VLAs and replace them with > fixed-length arrays instead. > > rtc-mcp795.c uses a variable-length array declaration to contain > the command to write the rtcc; this can be replaced by a fixed- >

[PATCH] clang-format: add configuration file

clang-format is a tool to format C/C++/... code according to a set of rules and heuristics. Like all tools, it is not perfect nor covers every single case, but it is good enough to be helpful. In particular, it is useful for quickly re-formatting blocks of code, spotting coding style mistakes,

[PATCH v2] auxdisplay: arm-charlcd: Fix struct charlcd doc line

There was a missing first line and a missing member, which gave a warning under W=1: CC drivers/auxdisplay/arm-charlcd.o drivers/auxdisplay/arm-charlcd.c:57: warning: Cannot understand * @dev: a pointer back to containing device on line 57 - I thought it was a doc line Cc: Linus

Re: dcache: remove trylock loops (was Re: [BUG] lock_parent() breakage when used from shrink_dentry_list())

On Mon, Mar 12 2018, Al Viro wrote: > On Mon, Mar 12, 2018 at 07:13:51PM +, Al Viro wrote: > >> There's an unpleasant area around the ->s_root vs. NFS. There's >> code that makes assumptions about ->s_root that are simply not true >> for NFS. Is path_connected() correct wrt NFS multiple

Re: [PATCH v4 14/24] fpga: dfl: fme: add partial reconfiguration sub feature support

On Mon, Mar 12, 2018 at 02:36:48PM -0700, matthew.gerl...@linux.intel.com wrote: > > > On Mon, 12 Mar 2018, Wu Hao wrote: > > Hi Hao, > > Please see my two comments inline. > > Thanks, > Matthew Gerlach > > >On Sun, Mar 11, 2018 at 01:09:31PM -0700, matthew.gerl...@linux.intel.com > >wrote:

Re: [PATCH v3 5/5] drm/i915: Implement proper fallback training for MST

On Fri, Mar 09, 2018 at 04:32:31PM -0500, Lyude Paul wrote: > For a while we actually haven't had any way of retraining MST links with > fallback link parameters like we do with SST. While uncommon, certain > setups such as my Caldigit TS3 + EVGA MST hub require this since > otherwise, they end up

Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64

On Mon, 2018-03-12 at 17:53 -0400, Mimi Zohar wrote: > On Fri, 2018-03-09 at 09:11 -0800, James Bottomley wrote: > > > > On Thu, 2018-03-08 at 12:42 -0600, Jiandi An wrote: > > [...] > > > > > > I'm no expert on IMA and its driver.  James, will you be kind > > > enough to look into overhauling

Re: [PATCH] ARM: BCM5301X: Fix NAND ECC parameters for Linksys Panamera

On 03/11/2018 03:03 AM, Vivek Unune wrote: > Hi Rafał, > > On Sat, Mar 10, 2018 at 10:41:04PM +0100, Rafał Miłecki wrote: >> On 10 March 2018 at 18:12, Vivek Unune wrote: >>> Using BCH8 gives ecc errors and makes the router unsuable. >>> Switching to BCH1 fixes these

RE: [PATCH v5 1/4] dt-bindings: firmware: Add bindings for ZynqMP firmware

Hi Sudeep, > -Original Message- > From: Sudeep Holla [mailto:sudeep.ho...@arm.com] > Sent: Thursday, March 08, 2018 3:48 AM > To: Jolly Shah > Cc: gre...@linuxfoundation.org; m...@codeblueprint.co.uk; > hkallwe...@gmail.com; michal.si...@xilinx.com; robh...@kernel.org;

[PATCH] staging: comedi: adl_pci6208: remove redundant initialization of 'val'

From: Colin Ian King Variable 'val' is initialized with a value that is never read, it is updated with a new value again after intitialization. Remove the redundant initialization and move the declaration and assignment into the scope of the for-loop. Cleans up clang

[PATCH -mm] mm: Fix race between swapoff and mincore

From: Huang Ying >From commit 4b3ef9daa4fc ("mm/swap: split swap cache into 64MB trunks") on, after swapoff, the address_space associated with the swap device will be freed. So swap_address_space() users which touch the address_space need some kind of mechanism to prevent

Re: [PATCH] perf/x86/uncore: Add missing filter constraint for SKX CHA event

On 3/12/2018 12:39 PM, Peter Zijlstra wrote: On Mon, Mar 12, 2018 at 08:41:34AM -0700, Kan Liang wrote: From: Stephane Eranian Adding a filter constraint for Intel Skylake CHA event UNC_CHA_UPI_CREDITS_ACQUIRED (0x38). The event supports core-id/thread-id and link

Re: [PATCH 2/5] arm64: dts: allwinner: a64: Add watchdog

On 12/03/18 16:10, Harald Geyer wrote: Hi, > Add a watchdog node for the A64, automatically enabled on all boards. > Tested on Olimex Teres I. > > Signed-off-by: Harald Geyer > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 6 ++ > 1 file changed, 6 insertions(+)

Re: [PATCH V2] nvme-pci: assign separate irq vectors for adminq and ioq0

Hi Keith Thanks for your precious time for testing and reviewing. I will send out V3 next. Sincerely Jianchao On 03/13/2018 02:59 AM, Keith Busch wrote: > Hi Jianchao, > > The patch tests fine on all hardware I had. I'd like to queue this up > for the next 4.16-rc. Could you send a v3 with the

Re: [PATCH v4 1/3] mm/free_pcppages_bulk: update pcp->count inside

On Mon, Mar 12, 2018 at 02:22:28PM +0100, Vlastimil Babka wrote: > On 03/01/2018 07:28 AM, Aaron Lu wrote: > > Matthew Wilcox found that all callers of free_pcppages_bulk() currently > > update pcp->count immediately after so it's natural to do it inside > > free_pcppages_bulk(). > > > > No

Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits

On 03/12/2018 04:52 PM, Andrew Morton wrote: > On Mon, 12 Mar 2018 16:15:40 -0400 Waiman Long wrote: > >> Checking code is added to check for invalid flags in the ctl_table >> and return error if an unknown flag is used. > Why? What's wrong with the old code, what value does

Re: linux-4.16-rc5/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:1723]: (warning) Possible null pointer dereference: pipe_ctx

On 03/12/2018 06:22 AM, David Binderman wrote: hello there, Source code is     for (i = 0; i < dc->res_pool->pipe_count; i++) {     if (res_ctx->pipe_ctx[i].stream) {     pipe_ctx = _ctx->pipe_ctx[i];     *pipe_idx = i;     break;     }     } Indeed

Re: Future of STACKLEAK plugin?

On Mon, Mar 12, 2018 at 10:06 AM, Kees Cook wrote: > > I was curious, after the last week of discussion, what you thought of > the future of Alexander's port of the STACKLEAK plugin[0]. Given that > there is progress being made (by at least 8 people at last count) to >

Re: [PATCH] proc: reject "." and ".." as filenames

On Sat, 10 Mar 2018 03:12:23 +0300 Alexey Dobriyan wrote: > Various subsystems can create files and directories in /proc > with names directly controlled by userspace. > > Which means "/", "." and ".." are no-no. > > "/" split is already taken care of, do the other 2

[PATCH net] net: dsa: Fix dsa_is_user_port() test inversion

During the conversion to dsa_is_user_port(), a condition ended up being reversed, which would prevent the creation of any user port when using the legacy binding and/or platform data, fix that. Fixes: 4a5b85ffe2a0 ("net: dsa: use dsa_is_user_port everywhere") Signed-off-by: Florian Fainelli

Guidelines for Submitting an RFC PATCH

Hi All, What are the guidelines for submitting an RFC patch? If a developer wants to get early input on a design is it fine to submit a patch that is in reasonable shape but does not fully meets the requirements of a regular patch, for example, the patch consists of a series of patches, it only

Re: [PATCH 1/1] net: check dev->reg_state before deref of napi netdev_ops

On Sun, Mar 11, 2018 at 12:22 PM, Josh Elsasser wrote: > init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads > to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi > wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. > >

Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

Hi! > >> > >> Fully charged > >> > >> battery shows as empty battery with red "x" in Mate desktop. After > >> > >> reboot to recent mainline problem goes away. Tooltip says "battery > >> > >> waiting to charge". > >> > >> > >> > >> For the MATE bug see: > >>

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Tue, Feb 20, 2018 at 8:41 AM, Philippe Ombredanne wrote: > On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches wrote: >> On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: >>> Hi Philippe, >>> >>> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne

[PATCH] netfilter: nfnetlink_cthelper: Remove VLA usage

In preparation to enabling -Wvla, remove VLA and replace it with dynamic memory allocation. >From a security viewpoint, the use of Variable Length Arrays can be a vector for stack overflow attacks. Also, in general, as the code evolves it is easy to lose track of how big a VLA can get. Thus, we

Re: [PATCH 4.4 31/36] sctp: verify size of a new chunk in _sctp_make_chunk()

On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > -- > > From: Alexey Kodanev > > > [ Upstream commit 07f2c7ab6f8d0a7e7c5764c4e6cc9c52951b9d9c ] > > When

Re: [PATCH 3/3] dcache: account external names as indirectly reclaimable memory

On Mon, Mar 12, 2018 at 10:36:38PM +, Roman Gushchin wrote: > Ah, I see... > > I think, it's better to account them when we're actually freeing, > otherwise we will have strange path: > (indirectly) reclaimable -> unreclaimable -> free > > Do you agree? > +static void

[patch -mm v3 3/3] mm, memcg: add hierarchical usage oom policy

One of the three significant concerns brought up about the cgroup aware oom killer is that its decisionmaking is completely evaded by creating subcontainers and attaching processes such that the ancestor's usage does not exceed another cgroup on the system. Consider the example from the previous

Re: [PATCH 0/2] Remove VLA usage in rtc-s5m

On 03/12/2018 07:35 PM, Alexandre Belloni wrote: Hi, On 10/03/2018 at 00:27:02 -0600, Gustavo A. R. Silva wrote: This patchset aims to remove VLA usage from rtc-s5m. The first patch moves an enum from rtc.h to rtc-s5m.c, as this is the only driver in which such enum is actually being used

Re: [PATCH net-next] net: stmmac: remove superfluous wmb() memory barriers

From: Niklas Cassel Date: Mon, 12 Mar 2018 09:55:42 +0100 > Jose is simply responding to the commit message description of this patch. > > You explained that there is an implicit memory barrier between physical memory > writes and those to MMIO register space, as long as

Re: [PATCH v4 0/10] hisi_sas: support x6000 board and some misc changes

John, > This patchset primarily adds support for the Huawei x6000 board, > which includes hip07 chipset. Unfortunately, due to some board > layout differences with our development board, we need to set > a PHY-related register differently for optimal signal quality. As > such, a signal

Re: [PATCH v3 08/11] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

On 3/12/2018 9:55 PM, Sinan Kaya wrote: > On 3/12/2018 3:35 PM, Logan Gunthorpe wrote: >> -if (nvmeq->sq_cmds_io) > > I think you should keep the code as it is for the case where > (!nvmeq->sq_cmds_is_io && nvmeq->sq_cmds_io) Never mind. I misunderstood the code. > > You are changing the

linux-next: manual merge of the qcom tree with the amlogic tree

Hi Andy, Today's linux-next merge of the qcom tree got a conflict in: arch/arm64/configs/defconfig between commit: 266c157de3b2 ("arm64: defconfig: enable MESON EFUSE") from the amlogic tree and commit: 52fe48c2b9bb ("arm64: defconfig: enable thermal sensor on QCOM platforms") from

Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

Hi! > > >> Fully charged > > >> battery shows as empty battery with red "x" in Mate desktop. After > > >> reboot to recent mainline problem goes away. Tooltip says "battery > > >> waiting to charge". > > >> > > For the MATE bug see: > https://github.com/mate-desktop/mate-power-manager/pull/251 >

Re: [PATCH] Input: alps - Demystify trackstick initialization for v3 and v6 protocols

Masaki, if you have access to the internal ALPS v3 / Rushmore documentation, I would like to have a review of this patch or confirmation of those information :-) On Tuesday 13 March 2018 00:09:15 Pali Rohár wrote: > Remove cite "Not sure what this does, but it is absolutely essential". > >

[PATCH] rtc: mcp795: remove VLA usage

In preparation to enabling -Wvla, remove VLAs and replace them with fixed-length arrays instead. rtc-mcp795.c uses a variable-length array declaration to contain the command to write the rtcc; this can be replaced by a fixed- size array of length 2 (instruction, address) + 32 (data out), assuming

Re: [PATCH v12 0/6] Address error and recovery for AER and DPC

On Mon, Mar 12, 2018 at 02:47:30PM -0500, Bjorn Helgaas wrote: > [+cc Alex] > > On Mon, Mar 12, 2018 at 08:25:51AM -0600, Keith Busch wrote: > > On Sun, Mar 11, 2018 at 11:03:58PM -0400, Sinan Kaya wrote: > > > On 3/11/2018 6:03 PM, Bjorn Helgaas wrote: > > > > On Wed, Feb 28, 2018 at 10:34:11PM

Re: [PATCH] clang-format: add configuration file

On Tue, 2018-03-13 at 00:39 +0100, Miguel Ojeda wrote: > clang-format is a tool to format C/C++/... code according to a set > of rules and heuristics. Like all tools, it is not perfect nor > covers every single case, but it is good enough to be helpful. Yes, thanks. It'd also be nice to remove

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

On Mon, Mar 12, 2018 at 01:28:38PM +0800, Boqun Feng wrote: > On Fri, Mar 09, 2018 at 12:17:07PM -0800, Paul E. McKenney wrote: > > On Fri, Mar 09, 2018 at 02:57:00PM +0800, Boqun Feng wrote: > > > On Thu, Mar 08, 2018 at 07:42:55AM -0800, Paul E. McKenney wrote: > > > > On Thu, Mar 08, 2018 at

<    5   6   7   8   9   10   11   12   13   14   >