Michael Grzeschik m.grzesc...@pengutronix.de writes:
From: Philipp Wiesner p.wies...@phytec.de
Added this info to Kconfig and mt9m111.c, some comment cleanup,
replaced 'mt9m11x'-statements by clarifications or driver name.
Driver is fully compatible to mt9m131 which has only additional
Michael Grzeschik m.grzesc...@pengutronix.de writes:
Signed-off-by: Philipp Wiesner p.wies...@phytec.de
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
OK for me (the formal ack will be once we finish the review).
Cheers.
--
Robert
--
To unsubscribe from this list: send the line
Michael Grzeschik m.grzesc...@pengutronix.de writes:
Signed-off-by: Philipp Wiesner p.wies...@phytec.de
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
OK for me.
Cheers.
--
Robert
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to
Michael Grzeschik m.grzesc...@pengutronix.de writes:
Signed-off-by: Philipp Wiesner p.wies...@phytec.de
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
---
drivers/media/video/mt9m111.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Michael Grzeschik m...@pengutronix.de writes:
Hi Robert, Guennadi,
after the messed up previous patchseries, this v2 series is left
without any feedback. Hopefully not forgotten. :-)
No, not forgotten.
I need a week, but Guennadi can superseed me anytime if he is the first to fire
:)
Michael Grzeschik m.grzesc...@pengutronix.de writes:
Signed-off-by: Philipp Wiesner p.wies...@phytec.de
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
I would require a small change here.
I am using the testpattern for non regression tests. This change implies that
the test
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Robert, I'll need your ack / tested by on this one too. It actually
changes behaviour, for example, it sets MT9M111_OUTFMT_FLIP_BAYER_ROW in
the OUTPUT_FORMAT_CTRL register for the V4L2_MBUS_FMT_SBGGR8_1X8 8 bit
Bayer format. Maybe other
as before, and
probably even better.
Therefore, as I won't have much time ahead, please find my ack, for the full
serie:
Acked-by: Robert Jarzmik robert.jarz...@free.fr
Cheers.
--
Robert
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Yes, but this has another disadvantage - if you do not use s_register /
g_register, maybe you just have CONFIG_VIDEO_ADV_DEBUG off, then, once you
load the module with the testpattern parameter, you cannot switch using
testpatterns off
Delvare kh...@linux-fr.org
Acked-by: Robert Jarzmik robert.jarz...@free.fr
--
Robert
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hans Verkuil hverk...@xs4all.nl writes:
[zip]
@@ -1067,6 +968,26 @@ static int mt9m111_probe(struct i2c_client *client,
return -ENOMEM;
v4l2_i2c_subdev_init(mt9m111-subdev, client, mt9m111_subdev_ops);
+ v4l2_ctrl_handler_init(mt9m111-hdl, 5);
+
On 06/06/2011 07:20 PM, Guennadi Liakhovetski wrote:
It is more convenient to propagate the higher level abstraction - the
struct mt9m111 object into functions and then retrieve a pointer to
the i2c client, if needed, than to do the reverse.
Agreed.
One minor point, you ofter replace :
-
On 06/06/2011 07:02 PM, Guennadi Liakhovetski wrote:
soc_camera core now performs the standard .bytesperline and .sizeimage
calculations internally, no need to duplicate in drivers.
Haven't I noticed that this patch is twofold :
- the calculation duplication
- the suspend/resume change from
On 06/07/2011 12:02 PM, Guennadi Liakhovetski wrote:
On Mon, 6 Jun 2011, Robert Jarzmik wrote:
On 06/06/2011 07:20 PM, Guennadi Liakhovetski wrote:
It is more convenient to propagate the higher level abstraction - the
struct mt9m111 object into functions and then retrieve a pointer to
the i2c
On 06/07/2011 12:02 PM, Guennadi Liakhovetski wrote:
A general question to you: from your comments I haven't understood: have
you also tested the patches or only reviewed them?
I had reviewed them so far.
Now, please have my :
Acked-by: Robert Jarzmik robert.jarz...@free.fr
The ack includes
Darius Augulis augulis.dar...@gmail.com writes:
Darius Augulis wrote:
Hi,
I'm trying to launch mx1_camera based on new v4l and soc-camera tree.
After loading mx1_camera module, I see that .add callback is not called.
In debug log I see that soc_camera_open() is not called too.
What should
Darius Augulis augulis.dar...@gmail.com writes:
Darius Augulis wrote:
Hi,
I'm trying to launch mx1_camera based on new v4l and soc-camera tree.
After loading mx1_camera module, I see that .add callback is not called.
In debug log I see that soc_camera_open() is not called too.
What
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
This is more or less the final version of the first step of the
v4l2-subdev conversion, hence, all affected driver authors / platform
maintainers are encouraged to review and test. I have eliminated
OK, here goes a preliminary review for
Robert Jarzmik robert.jarz...@free.fr writes:
I'll test fully this weekend.
I just made a first try, just to prepare my weekend. Even with Ming Lei patch
reverted, and all statically built, I have no camera detected ...
Is there something I need to know before attempting the brute force method
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Try with the patch-stack I mentioned in the previous mail, will see then.
Euh, which mail ? I can't find a reference to it.
As a preparation for the weekend, my first try revealed that oops. I must admit
I made that test without any
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
On Thu, 9 Apr 2009, Robert Jarzmik wrote:
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Did you enable DEBUG? Looks like one of dev_dbg() had a (yet) invalid
device pointer. I'll have to try that too.
No, don't think so.
I think
After DMA redesign, the pxa_camera dynamic behaviour should
be documented so that future contributors understand how it
works, and improve it.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
Documentation/video4linux/pxa_camera.txt | 49 ++
1 files changed
.
--
Robert
From 8f33b15891c8fe8ee317a8d0d7293d05fda3c6e6 Mon Sep 17 00:00:00 2001
From: Robert Jarzmik robert.jarz...@free.fr
Date: Mon, 13 Apr 2009 18:52:56 +0200
Subject: [PATCH] pxa_camera: Documentation of the FSM
After DMA redesign, the pxa_camera dynamic behaviour should
be documented so
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Register access routines only need the I2C client, not the soc-camera device
context.
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
For mt9m111.c :
Acked-by: Robert Jarzmik robert.jarz...@free.fr
Cheers.
--
Robert
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
This patch series is a preparation for the v4l2-subdev conversion. Please,
review and test. My current patch-stack in the form of a
(manually-created) quilt-series is at
http://www.open-technology.de/download/20090415/ based on linux-next
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Convert soc-camera core to a platform driver. With this approach I2C
devices are no longer statically registered in platform code, instead they
are registered dynamically by the soc-camera core, when a match with a
host driver is found. With
Robert Jarzmik robert.jarz...@free.fr writes:
I need to make some additionnal tests with I2C loading/unloading, but
otherwise
it works perfectly for (soc_camera / pxa_camera /mt9m111 combination).
Guennadi,
I made some testing, and there is something I don't understand in the new device
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
- I unload and reload mt9m111 and pxa_camera
= not any better
Actually, I think, in this case it should be found again, as long as you
reload pxa-camera while i2c-pxa is already loaded.
Damn, you're right. I cross-checked, and
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
...as promised, my current stack is at
http://download.open-technology.de/20090421/. To encourage you to test it
now without waiting for my rebase - the functionality shall be exactly the
same after the rebase, it really shouldn't change
Trent Piepho xy...@speakeasy.org writes:
Mauro,
Please pull from http://linuxtv.org/hg/~tap/v4l-dvb
This series adds a function for bounding and alignment image sizes and
modifies a number of drivers to use it. It came up when the pxa patches to
deal with the alignment issues for that
Trent Piepho xy...@speakeasy.org writes:
On Mon, 1 Jun 2009, Robert Jarzmik wrote:
Trent Piepho xy...@speakeasy.org writes:
Please pull from http://linuxtv.org/hg/~tap/v4l-dvb
If I'm not mistaken, these lines are an equivalent of :
balign = 1 align;
if (align)
x
Let's begin the maintainers party.
A board designer knows what the host supports, knows what the sensor
supports, and knows if he added any inverters on the board, and based on
all that information he can just setup these parameters for the sensor
chip. Settings that are fixed on the
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Hi Robert
Thanks, but I'm afraid you're a bit late:
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/10947/focus=10949
Ouch, missed this one on the mailing list.
You can drop that patch then, Jonathan's patch is exactly
has tested it, and if you want it,
please take my :
Acked-by: Robert Jarzmik robert.jarz...@free.fr
Cheers.
--
Robert
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Sascha Hauer s.ha...@pengutronix.de writes:
Hi Robert,
I have digged around in the Datasheet and if I understand it correctly
the PXA swaps red/blue in RGB mode. So if we do not use rgb mode but yuv
(which should be a pass through) we should be able to support rgb on PXA
aswell. Robert, can
I tried to upgrade from 2.6.30 to 2.6.33 and verify my board (ie. the mt9m111
sensor with pxa_camera host).
I'm a bit surprised it didn't work. I dig just a bit, and found that :
- in soc_camera_init_i2c(), the following call fails
subdev = v4l2_i2c_new_subdev_board(ici-v4l2_dev, adap,
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Hi Robert
a lot of things changed in and around soc-camera between 2.6.30 and
.33... E.g., previously you could load driver modules in any order, it
would work in any case. Now if you load your host driver (pxa) and your
client driver
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
a lot of things changed in and around soc-camera between 2.6.30 and
.33... E.g., previously you could load driver modules in any order, it
would work in any case. Now if you load your host driver (pxa) and your
client driver is not there
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
(moved to the new v4l list)
Wow, I missed a couple of mail I see ... :) I really should subscribe to that
one ...
On Mon, 2 Mar 2009, Robert Jarzmik wrote:
The DMA transfers in pxa_camera showed some weaknesses in
multiple queued buffers
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
(moved to the new v4l list)
The DMA transfers in pxa_camera showed some weaknesses in
multiple queued buffers context :
- poll/select problem
The order between list pcdev-capture and DMA chain was
not the same. This creates a
223 x 111 will work. If such a decision
was to be taken, patch 1 would have to amended.
Powermanagment with suspend to RAM, then resume in the middle of a capture does
work.
As Mike noticed, YUV planar format overlay was not tested after these changes.
Robert Jarzmik (4):
pxa_camera: remove YUV
1280 x 1024 (many RAM pages)
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/video/pxa_camera.c | 165 ++
1 files changed, 114 insertions(+), 51 deletions(-)
diff --git a/drivers/media/video/pxa_camera.c b/drivers/media/video
.
- Maintainability
DMA code was a bit obfuscated. Rationalize the code to be
easily maintainable by anyone.
This patch attemps to address these issues.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/video/pxa_camera.c | 264 --
1
Transform sequences of form:
foo = val1 | val2 |
val3 | val4;
into :
foo = val1 | val2
| val3 | val4;
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/video/pxa_camera.c | 43 ++---
1
.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/video/pxa_camera.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/pxa_camera.c b/drivers/media/video/pxa_camera.c
index 16bf0a3..dd56c35 100644
--- a/drivers/media/video
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
This is not a review yet - just an explanation why I was suggesting to
adjust height and width - you say yourself, that YUV422P (I think, this is
wat you meant, not just YUV422) requires planes to immediately follow one
another. But you
- Mail Original -
De: Guennadi Liakhovetski g.liakhovet...@gmx.de
À: Trent Piepho xy...@speakeasy.org
Cc: Robert Jarzmik robert.jarz...@free.fr, m...@compulab.co.il, Linux
Media Mailing List linux-media@vger.kernel.org
Envoyé: Jeudi 5 Mars 2009 23h15:03 GMT +01:00 Amsterdam / Berlin
- Mail Original -
De: Trent Piepho xy...@speakeasy.org
À: robert jarzmik robert.jarz...@free.fr
Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de, m...@compulab.co.il,
Linux Media Mailing List linux-media@vger.kernel.org
Envoyé: Vendredi 6 Mars 2009 10h56:39 GMT +01:00 Amsterdam / Berlin
Trent Piepho xy...@speakeasy.org writes:
I like the algorithm I posted, after another small improvement, better.
So push it toward v4l2, to have wider audience.
If I were you, I'd have a peek at include/linux/kernel.h, which brings you
beautiful functions like ALIGN(), IS_ALIGNED(), and so on
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Emn, no. Just looked in CodingStyle - haven't found a word about it. So, I
think, applies keep consistent with the rest of the file. And, you know,
someone might call this a matter of taste, but a line like
x = y
in a .c file
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
On Thu, 5 Mar 2009, Robert Jarzmik wrote:
The last buffer queued will often overrun, as the DMA chain
is finished, and the time the dma irq handler is activated,
s/and the time/and during the time/ ?
If you wish, or might be simply
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
+ * Returns 0 or -ENOMEM si no coherent memory is available
Let's stay with English for now:-) s/si/if/
Oups ... sorry ... the froggish touch is back :)
*/
static int pxa_init_dma_channel(struct pxa_camera_dev *pcdev,
Now consider the first vb was unqueued _and_ requeued in the meantime, while
the new buffer was under DMA active filling.
Won't we finish with something like :
+---+ +--+
| Former New vb | dummy | | First vb | dummy |
+---^---|---+
- Mail Original -
De: Guennadi Liakhovetski g.liakhovet...@gmx.de
À: Robert Jarzmik robert.jarz...@free.fr
Cc: osp...@studenti.unina.it, m...@compulab.co.il, Linux Media Mailing List
linux-media@vger.kernel.org
Envoyé: Mercredi 11 Mars 2009 13h22:19 GMT +01:00 Amsterdam / Berlin / Berne
Robert Jarzmik robert.jarz...@free.fr writes:
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
+ for (i = 0; i pcdev-channels; i++) {
+ pcdev-sg_tail[i] = buf-dmas[i].sg_cpu + buf-dmas[i].sglen;
+ pcdev-sg_tail[i]-ddadr = DDADR_STOP;
This function is now called
(so U plane size is a multiple of 8). It is enforced in
try_fmt() and set_fmt() primitives, be aligning height then
width on 4 multiples as need be, to reach a 16 multiple.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/video/pxa_camera.c | 28
1280 x 1024 (many RAM pages)
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/video/pxa_camera.c | 150 +++---
1 files changed, 108 insertions(+), 42 deletions(-)
diff --git a/drivers/media/video/pxa_camera.c b/drivers/media/video
attemps to address these issues / improvements.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
Documentation/video4linux/pxa_camera.txt | 125
drivers/media/video/pxa_camera.c | 317 ++
2 files changed, 315 insertions(+), 127 deletions
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
What is QIF? Do you mean Quick Capture Interface - QCI? I also see CIF
used in the datasheet, probably, for Capture InterFace, but I don't see
QIF anywhere. Also, please explain the first time you use the
abbreviation. Also fix it in the
(so U plane size is a multiple of 8). It is enforced in
try_fmt() and set_fmt() primitives, be aligning height then
width on 4 multiples as need be, to reach a 16 multiple.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/video/pxa_camera.c | 32
1280 x 1024 (many RAM pages)
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/video/pxa_camera.c | 145 +++--
1 files changed, 106 insertions(+), 39 deletions(-)
diff --git a/drivers/media/video/pxa_camera.c b/drivers/media/video
-using the calculated pointer. This also saves a bit of performance which is
always good during video-capture.
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
On Mon, 16 Mar 2009, Robert Jarzmik wrote:
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
pxa_dma_update_sg_tail
...@infradead.org
Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de
Cc: Robert Jarzmik robert.jarz...@free.fr
Certainly, clocks have to be prepared before being enabled AFAIK.
Acked-by: Robert Jarzmik robert.jarz...@free.fr
Cheers.
--
Robert
--
To unsubscribe from this list: send the line unsubscribe linux
Peter Meerwald pme...@pmeerw.net writes:
Signed-off-by: Peter Meerwald pme...@pmeerw.net
Acked-by: Robert Jarzmik robert.jarz...@free.fr
--
Robert
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
(adding Robert to CC)
I don't think any data is freed by pxa_free_dma(), it only disables DMA on
a certain channel. Theoretically there could be a different problem:
pxa_free_dma() deactivates DMA, whereas pxa_dma_start_channels()
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Hi all
While working on a context-switching test, I've cleaned up the mt9m111
driver a bit and fixed its cropping and scaling functions. These are
planned for 3.3.
Hi Guennadi,
I've been on holidays ... so I've not dived into your
Hi Guennadi,
I'm slowly converting all of my drivers to device-tree.
In the process, I met ... soc_camera.
I converted mt9m111.c and pxa_camera.c, but now I need the linking
soc_camera. And I don't have a clear idea on how it should be done.
I was thinking of having soc_camera_pdrv_probe()
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Hi Robert,
On Sat, 14 Jun 2014, Robert Jarzmik wrote:
Hi Guennadi,
I'm slowly converting all of my drivers to device-tree.
In the process, I met ... soc_camera.
I converted mt9m111.c and pxa_camera.c, but now I need the linking
Add documentation for pxa_camera host interface.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
.../devicetree/bindings/media/pxa-camera.txt | 40 ++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/pxa-camera.txt
Add device-tree support to pxa_camera host driver.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/platform/soc_camera/pxa_camera.c | 80 ++
1 file changed, 80 insertions(+)
diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
b/drivers
Add documentation for the Micron mt9m111 image sensor.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
.../devicetree/bindings/media/i2c/mt9m111.txt | 28 ++
1 file changed, 28 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/mt9m111
Add device-tree support for mt9m111 camera sensor.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/i2c/soc_camera/mt9m111.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/media/i2c/soc_camera/mt9m111.c
b/drivers/media/i2c/soc_camera
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
On Sun, 15 Jun 2014, Robert Jarzmik wrote:
+static const struct of_device_id pxacamera_dt_ids[] = {
+{ .compatible = mrvl,pxa_camera, },
as Documentation/devicetree/bindings/vendor-prefixes.txt defines, it
should be marvell.
OK, I'll
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Hi Robert,
On Sun, 15 Jun 2014, Robert Jarzmik wrote:
Add documentation for the Micron mt9m111 image sensor.
A nitpick: this isn't documentation for the sensor:) This is driver DT
bindings' documentation.
OK, for V2 (as its twin
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Hi Robert,
+static int of_get_mt9m111_platform_data(struct device *dev,
+struct soc_camera_subdev_desc *desc)
+{
+return 0;
+}
Why do you need this function? I would just drop it.
Yeah, drop it
Add device-tree bindings documentation for the Micron mt9m111 image
sensor.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
.../devicetree/bindings/media/i2c/mt9m111.txt | 28 ++
1 file changed, 28 insertions(+)
create mode 100644 Documentation/devicetree
Add device-tree support for mt9m111 camera sensor.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/i2c/soc_camera/mt9m111.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/i2c/soc_camera/mt9m111.c
b/drivers/media/i2c/soc_camera/mt9m111.c
Add device-tree bindings documentation for pxa_camera driver.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
.../devicetree/bindings/media/pxa-camera.txt | 39 ++
1 file changed, 39 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/pxa
Add device-tree support to pxa_camera host driver.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media/platform/soc_camera/pxa_camera.c | 77 +-
1 file changed, 75 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/soc_camera
Mark Rutland mark.rutl...@arm.com writes:
On Sat, Jun 21, 2014 at 11:21:47PM +0100, Robert Jarzmik wrote:
@@ -1650,6 +1651,64 @@ static struct soc_camera_host_ops
pxa_soc_camera_host_ops = {
.set_bus_param = pxa_camera_set_bus_param,
};
+static int pxa_camera_pdata_from_dt(struct
Mark Rutland mark.rutl...@arm.com writes:
On Sat, Jun 21, 2014 at 11:21:46PM +0100, Robert Jarzmik wrote:
+Required properties:
+ - compatible: Should be marvell,pxa27x-qci
Is that x a wildcard? Or is 'x' part of the name of a particular unit?
It's kind of a wildcard for a group of platforms
Add device-tree bindings documentation for pxa_camera driver.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
Since V1: Mark's review
- wildcard pxa27x becomes pxa270
- clock name camera becomes ciclk
- add mclk clock provider
---
.../devicetree/bindings
Add device-tree support to pxa_camera host driver.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
Since V1: Mark's review
- tmp u32 to long conversion for clock rate
- use device-tree clock binding for mclk output clock
- wildcard pxa27x becomes pxa270
Hi Guennadi,
I just noticed the subject contains a typo, mt8m111 instead of mt9m111. Is there
any other pending comment I'm overlooking before I post the final serie for
m9m111 dt conversion ?
Cheers.
--
Robert
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
Robert Jarzmik robert.jarz...@free.fr writes:
Hi Guennadi, Mark,
Can I consider my work done for this serie, or am I forgetting pending comments
? If done, an ack from Mark would be good.
Cheers.
--
Robert
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
Robert Jarzmik robert.jarz...@free.fr writes:
Robert Jarzmik robert.jarz...@free.fr writes:
Hi Guennadi, Mark,
Can I consider my work done for this serie, or am I forgetting pending
comments
? If done, an ack from Mark would be good.
Mark, ping ?
Cheers.
--
Robert
--
To unsubscribe
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Add device-tree support to pxa_camera host driver.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
[g.liakhovet...@gmx.de: added of_node_put()]
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
Robert, could you review
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Thanks for a quick test! One question: to test this you also needed a
version of Ben's soc_camera: add support for dt binding soc_camera
drivers patch, right?
Yes.
Did you use the last version from Ben or my amended version, that I sent
Robert Jarzmik robert.jarz...@free.fr writes:
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
If you didn't use my version, would it be possible for you to test it and
reply with your tested-by if all looks ok?
Of course, as soon as I find it. And yes, linux-media periodically drops me
From: Robert Jarzmik robert.jarz...@intel.com
Convert pxa_camera to dmaengine. This removes all DMA registers
manipulation in favor of the more generic dmaengine API.
The functional level should be the same as before. The biggest change is
in the videobuf_sg_splice() function, which splits
From: Robert Jarzmik robert.jarz...@intel.com
This moves the dma irq handling functions up in the source file, so that
they are available before DMA preparation functions. It prepares the
conversion to DMA engine, where the descriptors are populated with these
functions as callbacks.
Signed-off
From: Robert Jarzmik robert.jarz...@intel.com
Fix the error path where the video buffer wasn't allocated nor
mapped. In this case, in the driver free path don't try to unmap memory
which was not mapped in the first place.
Signed-off-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/media
Hi Guennadi,
Today I noticed the mioa701 build is broken on v4.1-rcX series. It was working
in v4.0.
The build error I get is :
LINKvmlinux
LD vmlinux.o
MODPOST vmlinux.o
GEN .version
CHK include/generated/compile.h
UPD include/generated/compile.h
CC
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
...zip...
First, a question for Russell :
Given that the current PXA architecture is not implementing the
clk_round_rate() function, while implementing clk_get(), etc..., is it correct
to say that it is betraying the clk API by doing so ?
Russell King - ARM Linux li...@arm.linux.org.uk writes:
On Wed, May 13, 2015 at 09:26:03PM +0200, Robert Jarzmik wrote:
First, a question for Russell :
Given that the current PXA architecture is not implementing the
clk_round_rate() function, while implementing clk_get(), etc
Stephen Boyd sb...@codeaurora.org writes:
On 04/04/15 05:43, Robert Jarzmik wrote:
Russell King rmk+ker...@arm.linux.org.uk writes:
clk_add_alias() is provided by clkdev, and is not part of the clk API.
Howver, it is prototyped in two locations: linux/clkdev.h and
linux/clk.h
-by: Russell King rmk+ker...@arm.linux.org.uk
Tested-by: Robert Jarzmik robert.jarz...@free.fr
Actually, this serie fixes a regression I've seen in linux-next, and which was
triggering the Oops in [1] on lubbock. With your serie, the kernel boots fine.
Cheers.
--
Robert
[1] Oops without this serie
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Hi Robert,
Please, correct me if I am wrong, but doesn't this patch have to be
updates? Elgl looking at this:
+for (i = 0; i 3 buf-descs[i]; i++) {
+async_tx_ack(buf-descs[i]);
+
Robert Jarzmik robert.jarz...@free.fr writes:
Robert Jarzmik robert.jarz...@free.fr writes:
Hi Guennadi,
I've been cooking this since 2012. At that time, I thought the dmaengine API
was
not rich enough to support the pxa_camera subtleties (or complexity).
I was wrong. I submitted
Guennadi Liakhovetski g.liakhovet...@gmx.de writes:
Hi Robert,
On Sun, 22 Mar 2015, Robert Jarzmik wrote:
From: Robert Jarzmik robert.jarz...@intel.com
Convert pxa_camera to dmaengine. This removes all DMA registers
manipulation in favor of the more generic dmaengine API
1 - 100 of 285 matches
Mail list logo
