Re: [PATCH 02/03] arm64: dts: renesas: r8a77980: Add IPMMU devices nodes

2018-05-23 Thread Magnus Damm
Hi Simon, On Tue, May 22, 2018 at 10:10 PM, Simon Horman wrote: > On Mon, May 21, 2018 at 11:45:01PM +0900, Magnus Damm wrote: >> From: Magnus Damm >> >> Add IPMMU device nodes for the R-Car V3H SoC aka r8a77980. >> >> The r8a77980 IPMMU is quite

Re: [PATCH v6 6/6] clk: renesas: Renesas RZ/N1 clock driver

2018-05-23 Thread kbuild test robot
Hi Michel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180517] [also build test WARNING on v4.17-rc6] [cannot apply to robh/for-next renesas-drivers/clk-renesas renesas/devel v4.17-rc6 v4.17-rc5 v4.17-rc4] [if your patch is applied to the wrong git

Re: [PATCH v6 5/6] ARM: dts: Renesas RZN1D-DB Board base file

2018-05-23 Thread kbuild test robot
Hi Michel, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20180517] [also build test ERROR on v4.17-rc6] [cannot apply to robh/for-next renesas-drivers/clk-renesas renesas/devel v4.17-rc6 v4.17-rc5 v4.17-rc4] [if your patch is applied to the wrong git tree,

Re: [PATCH v3 2/9] media: rcar-vin: Remove two empty lines

2018-05-23 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-18 16:40:38 +0200, Jacopo Mondi wrote: > Remove un-necessary empty lines. > > Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund > --- >

Re: [PATCH v3 1/9] media: rcar-vin: Rename 'digital' to 'parallel'

2018-05-23 Thread Niklas Söderlund
Hi Jacopo, Thanks for your patch. On 2018-05-18 16:40:37 +0200, Jacopo Mondi wrote: > As the term 'digital' is used all over the rcar-vin code in place of > 'parallel', rename all the occurrencies. > > Signed-off-by: Jacopo Mondi > --- >

Re: [PATCH 1/4] PCI: rcar: Rename rcar_pcie_parse_request_of_pci_ranges()

2018-05-23 Thread Bjorn Helgaas
On Wed, May 23, 2018 at 07:05:06PM +0200, Marek Vasut wrote: > On 05/23/2018 06:17 PM, Lorenzo Pieralisi wrote: > > On Mon, May 21, 2018 at 03:11:20PM +0200, Marek Vasut wrote: > >> The function name is just too confusing, rename it, no functional change. > >> Rename the function to

Re: [PATCH 1/6] dt-bindings: media: rcar-vin: Describe optional ep properties

2018-05-23 Thread Rob Herring
On Wed, May 23, 2018 at 2:38 PM, Laurent Pinchart wrote: > Hi Rob, > > On Wednesday, 23 May 2018 19:29:47 EEST Rob Herring wrote: >> On Wed, May 16, 2018 at 06:32:27PM +0200, Jacopo Mondi wrote: >> > Describe the optional endpoint properties for endpoint nodes

Re: [PATCH 1/6] dt-bindings: media: rcar-vin: Describe optional ep properties

2018-05-23 Thread Laurent Pinchart
Hi Rob, On Wednesday, 23 May 2018 19:29:47 EEST Rob Herring wrote: > On Wed, May 16, 2018 at 06:32:27PM +0200, Jacopo Mondi wrote: > > Describe the optional endpoint properties for endpoint nodes of port@0 > > and port@1 of the R-Car VIN driver device tree bindings documentation. > > > >

Re: [PATCH] iommu/ipmmu-vmsa: Document R-Car V3H and E3 IPMMU DT bindings

2018-05-23 Thread Rob Herring
On Mon, May 21, 2018 at 11:41:33PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Update the IPMMU DT binding documentation to include the compat strings > for the IPMMU devices included in the R-Car V3H and E3 SoCs. > > Signed-off-by: Magnus Damm

Re: [PATCH 1/4] PCI: rcar: Rename rcar_pcie_parse_request_of_pci_ranges()

2018-05-23 Thread Marek Vasut
On 05/23/2018 06:17 PM, Lorenzo Pieralisi wrote: > On Mon, May 21, 2018 at 03:11:20PM +0200, Marek Vasut wrote: >> The function name is just too confusing, rename it, no functional change. >> Rename the function to rcar_pcie_alloc_and_parse_pci_resource_list() as >> it's matching failpath function

Re: [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints

2018-05-23 Thread Rob Herring
On Thu, May 17, 2018 at 01:32:12AM +0200, Niklas Söderlund wrote: > The style for referring to ports and endpoint are wrong. Refer to them > using lowercase and a unit address, port@x and endpoint@x. > > Signed-off-by: Niklas Söderlund > Reported-by: Geert

Re: [PATCH 2/6] dt-bindings: media: rcar-vin: Document data-active

2018-05-23 Thread Rob Herring
On Wed, May 16, 2018 at 06:32:28PM +0200, Jacopo Mondi wrote: > Document 'data-active' property in R-Car VIN device tree bindings. > The property is optional when running with explicit synchronization > (eg. BT.601) but mandatory when embedded synchronization is in use (eg. > BT.656) as specified

Re: [PATCH 5/6] ARM: dts: rcar-gen2: Remove unused VIN properties

2018-05-23 Thread Rob Herring
On Thu, May 17, 2018 at 12:13:07AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-16 18:32:31 +0200, Jacopo Mondi wrote: > > The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN > > driver and only confuse users. Remove them in all Gen2 SoC

Re: [PATCH 1/6] dt-bindings: media: rcar-vin: Describe optional ep properties

2018-05-23 Thread Rob Herring
On Wed, May 16, 2018 at 06:32:27PM +0200, Jacopo Mondi wrote: > Describe the optional endpoint properties for endpoint nodes of port@0 > and port@1 of the R-Car VIN driver device tree bindings documentation. > > Signed-off-by: Jacopo Mondi > --- >

Re: [PATCH V2] mfd: dt: Add bindings for DA9063L

2018-05-23 Thread Rob Herring
On Wed, May 23, 2018 at 02:21:40PM +0200, Marek Vasut wrote: > Add device tree bindings for the Dialog DA9063L. This is a > variant of the DA9063 chip with smaller package, with less > LDO regulators and without RTC block. The other properties > of the chip are the same, including the content of

Re: [PATCH 1/4] PCI: rcar: Rename rcar_pcie_parse_request_of_pci_ranges()

2018-05-23 Thread Lorenzo Pieralisi
On Mon, May 21, 2018 at 03:11:20PM +0200, Marek Vasut wrote: > The function name is just too confusing, rename it, no functional change. > Rename the function to rcar_pcie_alloc_and_parse_pci_resource_list() as > it's matching failpath function is pci_free_resource_list() so the names > align much

Re: [PATCH v6 3/6] dt-bindings: clock: renesas,rzn1-clocks: document RZ/N1 clock driver

2018-05-23 Thread Rob Herring
On Wed, May 23, 2018 at 1:52 AM, M P wrote: > Hi Rob, > > On Tue, 22 May 2018 at 17:09, Rob Herring wrote: > >> On Tue, May 22, 2018 at 11:01:23AM +0100, Michel Pollet wrote: >> > The Renesas RZ/N1 Family (Part #R9A06G0xx) requires a driver >> > to provide

Re: [PATCH/RFC v4 2/4] usb: gadget: udc: renesas_usb3: Add register of usb role switch

2018-05-23 Thread Rob Herring
On Wed, May 23, 2018 at 1:52 AM, Yoshihiro Shimoda wrote: > Hi Rob, > > Thank you for the review! > >> From: Rob Herring, Sent: Wednesday, May 23, 2018 2:13 AM >> >> On Tue, May 22, 2018 at 09:01:07PM +0900, Yoshihiro Shimoda wrote: >> > This patch adds role

[PATCH] arm64: defconfig: Enable BD9571MWV regulator

2018-05-23 Thread Geert Uytterhoeven
From: Dien Pham The BD9571 PMIC is present on the Renesas Salvator-X(S) and R-Car Starter Kit Premier/Pro development boards. Signed-off-by: Dien Pham Signed-off-by: Geert Uytterhoeven ---

[git pull] pinctrl: sh-pfc: Updates for v4.18 (take two)

2018-05-23 Thread Geert Uytterhoeven
Hi Linus, The following changes since commit 73dacc3403436fc246258c0933e35b6e809640ac: pinctrl: sh-pfc: Add r8a77470 PFC support (2018-05-16 13:32:15 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git

[PATCH] arm64: dts: r8a77965: Add Watchdog Timer controller node using RCLK Watchdog Timer

2018-05-23 Thread Yoshihiro Kaneko
From: Takeshi Kihara Add a device node for the Watchdog Timer (WDT) controller on the Renesas R-Car M3N (R8A77965) SoC. Based on a similar patch of the R8A7796 device tree by Geert Uytterhoeven . Signed-off-by: Takeshi Kihara

Re: [PATCH V2] mfd: dt: Add bindings for DA9063L

2018-05-23 Thread Geert Uytterhoeven
On Wed, May 23, 2018 at 2:21 PM, Marek Vasut wrote: > Add device tree bindings for the Dialog DA9063L. This is a > variant of the DA9063 chip with smaller package, with less > LDO regulators and without RTC block. The other properties > of the chip are the same, including

Re: [PATCH 2/6] mfd: da9063: Replace model with type

2018-05-23 Thread Marek Vasut
On 05/23/2018 01:55 PM, Geert Uytterhoeven wrote: > On Wed, May 23, 2018 at 1:42 PM, Marek Vasut wrote: >> The model number stored in the struct da9063 is the same for all >> variants of the da9063 since it is the chip ID, which is always >> the same. Replace that with a

Re: [PATCH] mfd: dt: Add bindings for DA9063L

2018-05-23 Thread Marek Vasut
On 05/23/2018 02:08 PM, Geert Uytterhoeven wrote: > Hi Marek, > > On Wed, May 23, 2018 at 1:26 PM, Marek Vasut wrote: >> Add device tree bindings for the Dialog DA9063L. This is a >> variant of the DA9063 chip with smaller package, with less >> LDO regulators and without

[PATCH V2] mfd: dt: Add bindings for DA9063L

2018-05-23 Thread Marek Vasut
Add device tree bindings for the Dialog DA9063L. This is a variant of the DA9063 chip with smaller package, with less LDO regulators and without RTC block. The other properties of the chip are the same, including the content of the chip ID register. Signed-off-by: Marek Vasut

Re: [PATCH] mfd: dt: Add bindings for DA9063L

2018-05-23 Thread Geert Uytterhoeven
Hi Marek, On Wed, May 23, 2018 at 1:26 PM, Marek Vasut wrote: > Add device tree bindings for the Dialog DA9063L. This is a > variant of the DA9063 chip with smaller package, with less > LDO regulators and without RTC block. The other properties > of the chip are the same,

Re: [PATCH 6/6] mfd: da9063: Add DA9063L support

2018-05-23 Thread Geert Uytterhoeven
On Wed, May 23, 2018 at 1:42 PM, Marek Vasut wrote: > Add support for DA9063L, which is a reduced variant of the DA9063 > with less regulators and without RTC. > > Signed-off-by: Marek Vasut Reviewed-by: Geert Uytterhoeven

Re: [PATCH 5/6] mfd: da9063: Handle less LDOs on DA9063L

2018-05-23 Thread Geert Uytterhoeven
On Wed, May 23, 2018 at 1:42 PM, Marek Vasut wrote: > Move the LDOs present only on DA9063 at the end of the list, so that > the DA9063L can simply indicate less LDOs and still share the list of > regulators with DA9063. > > Signed-off-by: Marek Vasut

Re: [PATCH 4/6] mfd: da9063: Disallow RTC on DA9063L

2018-05-23 Thread Geert Uytterhoeven
On Wed, May 23, 2018 at 1:42 PM, Marek Vasut wrote: > The DA9063L does not contain RTC block, unlike the full DA9063. > Do not allow binding RTC driver on this variant of the chip. > > Signed-off-by: Marek Vasut Reviewed-by: Geert

Re: [PATCH 3/6] mfd: da9063: Add DA9063L type

2018-05-23 Thread Geert Uytterhoeven
On Wed, May 23, 2018 at 1:42 PM, Marek Vasut wrote: > Add type for DA9063L, which is a reduced variant of the DA9063 > without RTC block and with less regulators. > > Signed-off-by: Marek Vasut Reviewed-by: Geert Uytterhoeven

Re: [PATCH 2/6] mfd: da9063: Replace model with type

2018-05-23 Thread Geert Uytterhoeven
On Wed, May 23, 2018 at 1:42 PM, Marek Vasut wrote: > The model number stored in the struct da9063 is the same for all > variants of the da9063 since it is the chip ID, which is always > the same. Replace that with a separate identifier instead, which > allows us to discern

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

2018-05-23 Thread Marek Vasut
On 05/23/2018 01:52 PM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Wed, May 23, 2018 at 1:43 PM, Marek Vasut wrote: >> Add PMIC nodes to Porter and connect CPU DVFS supply. There is >> one DA9063L and one DA9210 on Porter, the only difference from >> the other boards

Re: [PATCH v6 4/6] ARM: dts: Renesas RZ/N1 SoC base device tree file

2018-05-23 Thread M P
Hi Geert, On Wed, 23 May 2018 at 12:18, Geert Uytterhoeven wrote: > Hi Michel, > On Wed, May 23, 2018 at 11:20 AM, M P wrote: > > On Wed, 23 May 2018 at 10:12, Geert Uytterhoeven > > wrote: > >> On Tue, May 22, 2018 at 12:01 PM,

Re: [PATCH 1/6] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063

2018-05-23 Thread Geert Uytterhoeven
On Wed, May 23, 2018 at 1:42 PM, Marek Vasut wrote: > The PMIC_DA9063 is a complete misnomer, it denotes the value of the > DA9063 chip ID register, so rename it as such. It is also the value > of chip ID register of DA9063L though, so drop the enum as all the > DA9063

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

2018-05-23 Thread Geert Uytterhoeven
Hi Marek, On Wed, May 23, 2018 at 1:43 PM, Marek Vasut wrote: > Add PMIC nodes to Porter and connect CPU DVFS supply. There is > one DA9063L and one DA9210 on Porter, the only difference from > the other boards is that DA9063L is at I2C address 0x5a rather > than 0x58 .

Re: [PATCH 6/6] mfd: da9063: Add DA9063L support

2018-05-23 Thread Mark Brown
On Wed, May 23, 2018 at 01:42:30PM +0200, Marek Vasut wrote: > Add support for DA9063L, which is a reduced variant of the DA9063 > with less regulators and without RTC. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 2/6] mfd: da9063: Replace model with type

2018-05-23 Thread Mark Brown
On Wed, May 23, 2018 at 01:42:26PM +0200, Marek Vasut wrote: > The model number stored in the struct da9063 is the same for all > variants of the da9063 since it is the chip ID, which is always > the same. Replace that with a separate identifier instead, which Acked-by: Mark Brown

Re: [PATCH 5/6] mfd: da9063: Handle less LDOs on DA9063L

2018-05-23 Thread Mark Brown
On Wed, May 23, 2018 at 01:42:29PM +0200, Marek Vasut wrote: > Move the LDOs present only on DA9063 at the end of the list, so that > the DA9063L can simply indicate less LDOs and still share the list of > regulators with DA9063. Acked-by: Mark Brown signature.asc

Re: [PATCH 1/6] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063

2018-05-23 Thread Mark Brown
On Wed, May 23, 2018 at 01:42:25PM +0200, Marek Vasut wrote: > The PMIC_DA9063 is a complete misnomer, it denotes the value of the > DA9063 chip ID register, so rename it as such. It is also the value > of chip ID register of DA9063L though, so drop the enum as all the Acked-by: Mark Brown

[PATCH] ARM: dts: porter: Add missing PMIC nodes

2018-05-23 Thread Marek Vasut
Add PMIC nodes to Porter and connect CPU DVFS supply. There is one DA9063L and one DA9210 on Porter, the only difference from the other boards is that DA9063L is at I2C address 0x5a rather than 0x58 . Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven

[PATCH 5/6] mfd: da9063: Handle less LDOs on DA9063L

2018-05-23 Thread Marek Vasut
Move the LDOs present only on DA9063 at the end of the list, so that the DA9063L can simply indicate less LDOs and still share the list of regulators with DA9063. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Lee Jones

[PATCH 6/6] mfd: da9063: Add DA9063L support

2018-05-23 Thread Marek Vasut
Add support for DA9063L, which is a reduced variant of the DA9063 with less regulators and without RTC. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Lee Jones Cc: Mark Brown Cc: Steve

[PATCH 2/6] mfd: da9063: Replace model with type

2018-05-23 Thread Marek Vasut
The model number stored in the struct da9063 is the same for all variants of the da9063 since it is the chip ID, which is always the same. Replace that with a separate identifier instead, which allows us to discern the DA9063 variants by setting the type based on either DT match or otherwise.

[PATCH 3/6] mfd: da9063: Add DA9063L type

2018-05-23 Thread Marek Vasut
Add type for DA9063L, which is a reduced variant of the DA9063 without RTC block and with less regulators. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Lee Jones Cc: Mark Brown Cc: Steve

[PATCH 1/6] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063

2018-05-23 Thread Marek Vasut
The PMIC_DA9063 is a complete misnomer, it denotes the value of the DA9063 chip ID register, so rename it as such. It is also the value of chip ID register of DA9063L though, so drop the enum as all the DA9063 "models" share the same chip ID and thus the distinction will have to be made using DT

[PATCH] mfd: dt: Add bindings for DA9063L

2018-05-23 Thread Marek Vasut
Add device tree bindings for the Dialog DA9063L. This is a variant of the DA9063 chip with smaller package, with less LDO regulators and without RTC block. The other properties of the chip are the same, including the content of the chip ID register. Signed-off-by: Marek Vasut

Re: [PATCH v6 4/6] ARM: dts: Renesas RZ/N1 SoC base device tree file

2018-05-23 Thread Geert Uytterhoeven
Hi Michel, On Wed, May 23, 2018 at 11:20 AM, M P wrote: > On Wed, 23 May 2018 at 10:12, Geert Uytterhoeven > wrote: >> On Tue, May 22, 2018 at 12:01 PM, Michel Pollet >> wrote: >> > + #address-cells = <1>; >> > +

Re: [PATCH 4/4] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails

2018-05-23 Thread Marek Vasut
On 05/23/2018 08:18 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Tue, May 22, 2018 at 11:53 PM, Marek Vasut wrote: >> On 05/22/2018 08:36 PM, Geert Uytterhoeven wrote: >>> On Mon, May 21, 2018 at 3:11 PM, Marek Vasut wrote: ---

Re: [PATCH] PCI: rcar: Remove IRQ mappings in rcar_pcie_enable_msi failpath

2018-05-23 Thread Geert Uytterhoeven
Hi Marek, On Wed, May 23, 2018 at 12:52 PM, Marek Vasut wrote: > The rcar_pcie_enable_msi() creates IRQ mappings using irq_create_mapping() > before requesting the IRQs using devm_request_irq(). If devm_request_irq() > fails for some reason, rcar_pcie_enable_msi() does not

[PATCH] PCI: rcar: Remove IRQ mappings in rcar_pcie_enable_msi failpath

2018-05-23 Thread Marek Vasut
The rcar_pcie_enable_msi() creates IRQ mappings using irq_create_mapping() before requesting the IRQs using devm_request_irq(). If devm_request_irq() fails for some reason, rcar_pcie_enable_msi() does not remove the mapping. Pull out the code for disposing IRQ mappings from

Re: [PATCH 15/61] gpu: drm: omapdrm: displays: simplify getting .drvdata

2018-05-23 Thread Tomi Valkeinen
On 19/04/18 17:05, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang > --- > > Build tested only. buildbot is happy. Please apply

Re: [PATCH] gpio: dwapb: Rework support for 1 interrupt per port A GPIO

2018-05-23 Thread Linus Walleij
On Wed, May 23, 2018 at 10:52 AM, Phil Edworthy wrote: > Treat DT and ACPI the same as much as possible. Note that we can't use > platform_get_irq() to get the DT interrupts as they are in the port > sub-node and hence do not have an associated platform device. > >

Re: [PATCH v6 1/6] dt-bindings: arm: Document the RZN1D-DB board

2018-05-23 Thread Simon Horman
On Wed, May 23, 2018 at 11:03:56AM +0200, Geert Uytterhoeven wrote: > On Tue, May 22, 2018 at 12:01 PM, Michel Pollet > wrote: > > This documents the RZ/N1 bindings for the RZN1D-DB board. > > > > Signed-off-by: Michel Pollet > >

Re: [PATCH v6 4/6] ARM: dts: Renesas RZ/N1 SoC base device tree file

2018-05-23 Thread M P
Hi Geert, On Wed, 23 May 2018 at 10:12, Geert Uytterhoeven wrote: > Hi Michel, > On Tue, May 22, 2018 at 12:01 PM, Michel Pollet > wrote: > > This adds the Renesas RZ/N1D (Part #R9A06G032) SoC bare > > bone support. > > > > This currently

Re: [PATCH 2/2] arm64: dts: renesas: v3hsk: add GEther support

2018-05-23 Thread Simon Horman
On Tue, May 22, 2018 at 10:52:21AM +0200, Simon Horman wrote: > On Fri, May 18, 2018 at 10:46:19PM +0300, Sergei Shtylyov wrote: > > Define the V3H Starter Kit board dependent part of the GEther device node. > > > > Based on the original (and large) patch by Vladimir Barinov. > > > >

RE: [PATCH] gpio: dwapb: Rework support for 1 interrupt per port A GPIO

2018-05-23 Thread Phil Edworthy
Hi Simon, On 23 May 2018 10:12 Simon Horman wrote: > On Wed, May 23, 2018 at 09:52:44AM +0100, Phil Edworthy wrote: > > Treat DT and ACPI the same as much as possible. Note that we can't use > > platform_get_irq() to get the DT interrupts as they are in the port > > sub-node and hence do not have

Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support

2018-05-23 Thread Simon Horman
On Wed, May 23, 2018 at 12:05:30PM +0300, Sergei Shtylyov wrote: > Hello! > > On 5/23/2018 11:41 AM, Simon Horman wrote: > > > > > > Define the generic R8A77980 part of the GEther device node. > > > > > > > > > > Based on the original (and large) patch by Vladimir Barinov. > > > > > > > > > >

Re: [PATCH] spi: sh-msiof: Fix setting SIRMDR1.SYNCAC to match SITMDR1.SYNCAC

2018-05-23 Thread Simon Horman
On Wed, May 23, 2018 at 11:02:04AM +0200, Geert Uytterhoeven wrote: > According to section 59.2.4 MSIOF Receive Mode Register 1 (SIRMDR1) in > the R-Car Gen3 datasheet Rev.1.00, the value of the SIRMDR1.SYNCAC bit > must match the value of the SITMDR1.SYNCAC bit. However, > sh_msiof_spi_setup()

Re: [PATCH v6 5/6] ARM: dts: Renesas RZN1D-DB Board base file

2018-05-23 Thread Geert Uytterhoeven
Hi Michel, On Tue, May 22, 2018 at 12:01 PM, Michel Pollet wrote: > This adds a base device tree file for the RZN1-DB board, with only the > basic support allowing the system to boot to a prompt. Only one UART is > used, with only a single CPU running. > >

Re: [PATCH] gpio: dwapb: Rework support for 1 interrupt per port A GPIO

2018-05-23 Thread Simon Horman
On Wed, May 23, 2018 at 09:52:44AM +0100, Phil Edworthy wrote: > Treat DT and ACPI the same as much as possible. Note that we can't use > platform_get_irq() to get the DT interrupts as they are in the port > sub-node and hence do not have an associated platform device. > > This also fixes a

Re: [PATCH v6 4/6] ARM: dts: Renesas RZ/N1 SoC base device tree file

2018-05-23 Thread Geert Uytterhoeven
Hi Michel, On Tue, May 22, 2018 at 12:01 PM, Michel Pollet wrote: > This adds the Renesas RZ/N1D (Part #R9A06G032) SoC bare > bone support. > > This currently only handles generic parts (gic, architected timer) > and a UART. > For simplicity sake, this also relies

Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes

2018-05-23 Thread Wolfram Sang
> > For the record: can you describe shortly which of these got tested with > > what setup? I don't know the Draak, so I don't know what is exposed. > > MSIOF2 is conveniently hooked up to a 1x4 pin header (CN41), no > weird-ass Samtec connectors required. My testing covered sending some > data

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

2018-05-23 Thread Simon Horman
On Wed, May 23, 2018 at 11:37:47AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote: > > On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman wrote: >

Re: [PATCH v6 4/6] ARM: dts: Renesas RZ/N1 SoC base device tree file

2018-05-23 Thread Simon Horman
On Tue, May 22, 2018 at 11:01:24AM +0100, Michel Pollet wrote: > This adds the Renesas RZ/N1D (Part #R9A06G032) SoC bare > bone support. > > This currently only handles generic parts (gic, architected timer) > and a UART. > For simplicity sake, this also relies on the bootloader to set the >

Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add GEther support

2018-05-23 Thread Sergei Shtylyov
Hello! On 5/23/2018 11:41 AM, Simon Horman wrote: Define the generic R8A77980 part of the GEther device node. Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov

Re: [PATCH v6 1/6] dt-bindings: arm: Document the RZN1D-DB board

2018-05-23 Thread Geert Uytterhoeven
On Tue, May 22, 2018 at 12:01 PM, Michel Pollet wrote: > This documents the RZ/N1 bindings for the RZN1D-DB board. > > Signed-off-by: Michel Pollet > Reviewed-by: Rob Herring Reviewed-by: Geert Uytterhoeven

[PATCH] spi: sh-msiof: Fix setting SIRMDR1.SYNCAC to match SITMDR1.SYNCAC

2018-05-23 Thread Geert Uytterhoeven
According to section 59.2.4 MSIOF Receive Mode Register 1 (SIRMDR1) in the R-Car Gen3 datasheet Rev.1.00, the value of the SIRMDR1.SYNCAC bit must match the value of the SITMDR1.SYNCAC bit. However, sh_msiof_spi_setup() changes only the latter. Fix this by updating the SIRMDR1 register like the

Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes

2018-05-23 Thread Ulrich Hecht
On Thu, May 17, 2018 at 9:56 AM, Wolfram Sang wrote: > On Wed, May 16, 2018 at 03:05:15PM +0200, Ulrich Hecht wrote: >> From: Hiromitsu Yamasaki >> >> This patch adds MSIOF device nodes for the R8A77995 SoC. >> >> Signed-off-by: Hiromitsu

Re: [PATCH v6 1/6] dt-bindings: arm: Document the RZN1D-DB board

2018-05-23 Thread Simon Horman
On Tue, May 22, 2018 at 11:01:21AM +0100, Michel Pollet wrote: > This documents the RZ/N1 bindings for the RZN1D-DB board. > > Signed-off-by: Michel Pollet > Reviewed-by: Rob Herring This looks fine but I will wait to see if there are other

Re: [PATCH v2 2/2] i2c: mux: demux-pinctrl: add symlinks to the demux device in sysfs

2018-05-23 Thread Wolfram Sang
> > + WARN(sysfs_create_link(>cur_adap.dev.kobj, >dev->kobj, > > + "demux_device"), > > +"can't create symlink to mux device\n"); > > + WARN(sysfs_create_link(>dev->kobj, >cur_adap.dev.kobj, > > + "channel-0"), > > +"can't

[PATCH] gpio: dwapb: Rework support for 1 interrupt per port A GPIO

2018-05-23 Thread Phil Edworthy
Treat DT and ACPI the same as much as possible. Note that we can't use platform_get_irq() to get the DT interrupts as they are in the port sub-node and hence do not have an associated platform device. This also fixes a problem introduced with error checking when calling platform_get_irq().

Re: [PATCH] media: dt-bindings: media: rcar_vin: add support for r8a77965

2018-05-23 Thread Simon Horman
On Sun, May 13, 2018 at 08:58:18PM +0200, Niklas Söderlund wrote: > Signed-off-by: Niklas Söderlund Reviewed-by: Simon Horman > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH/RFC] ARM: dts: r8a7791: Move enable-method to CPU nodes

2018-05-23 Thread Geert Uytterhoeven
Hi Simon, On Wed, May 23, 2018 at 10:37 AM, Simon Horman wrote: > On Tue, May 22, 2018 at 03:29:25PM +0200, Geert Uytterhoeven wrote: >> According to Documentation/devicetree/bindings/arm/cpus.txt, the >> "enable-method" property should be a property of the individual CPU >>

Re: [PATCH v2 1/2] i2c: mux: demux-pinctrl: use proper parent device for demux adapter

2018-05-23 Thread Simon Horman
On Mon, May 21, 2018 at 09:29:38AM +0200, Wolfram Sang wrote: > Due to a typo, the wrong parent device was assigned to the newly created > demuxing adapter device. It got connected to the demuxing platform > device but not to the selected parent I2C adapter device. Fix it to get > a proper

Re: [PATCH v2 2/2] i2c: mux: demux-pinctrl: add symlinks to the demux device in sysfs

2018-05-23 Thread Simon Horman
On Mon, May 21, 2018 at 09:29:39AM +0200, Wolfram Sang wrote: > Similar to mux devices, create special symlinks to connect the demuxed > bus with the demux device. > > Signed-off-by: Wolfram Sang Nit below not withstanding: Reviewed-by: Simon Horman

RE: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-23 Thread Phil Edworthy
Hi Linus, On 23 May 2018 09:29, Linus Walleij wrote: > On Fri, May 11, 2018 at 10:31 AM, Phil Edworthy wrote: > > > The DesignWare GPIO IP can be configured for either 1 interrupt or 1 > > per GPIO in port A, but the driver currently only supports 1 interrupt. > > See the DesignWare DW_apb_gpio

Re: [PATCH v4 3/3] arm64: dts: renesas: r8a77995: add thermal device support

2018-05-23 Thread Simon Horman
On Sun, May 20, 2018 at 06:26:19PM +0900, Yoshihiro Kaneko wrote: > Signed-off-by: Yoshihiro Kaneko > Reviewed-by: Geert Uytterhoeven Thanks, applied.

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

2018-05-23 Thread Laurent Pinchart
Hi Simon, On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote: > On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman wrote: > >>> --- a/drivers/media/platform/vsp1/vsp1_regs.h > >>> +++

Re: [PATCH/RFC] ARM: dts: r8a7791: Move enable-method to CPU nodes

2018-05-23 Thread Simon Horman
On Tue, May 22, 2018 at 03:29:25PM +0200, Geert Uytterhoeven wrote: > According to Documentation/devicetree/bindings/arm/cpus.txt, the > "enable-method" property should be a property of the individual CPU > nodes, not of the parent "cpus" node. However, on R-Car M2-W (and on > several other arm32

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

2018-05-23 Thread Simon Horman
On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman wrote: > >> --- a/drivers/media/platform/vsp1/vsp1_regs.h > >> +++ b/drivers/media/platform/vsp1/vsp1_regs.h > >> @@ -1,4 +1,4 @@ > >> -/*

Re: [PATCH] arm64: dts: renesas: r8a77980: add SMP support

2018-05-23 Thread Simon Horman
On Tue, May 22, 2018 at 11:49:36AM +0200, Geert Uytterhoeven wrote: > On Tue, May 22, 2018 at 10:54 AM, Simon Horman wrote: > > On Sat, May 19, 2018 at 08:38:13PM +0300, Sergei Shtylyov wrote: > >> On 05/17/2018 11:23 PM, Geert Uytterhoeven wrote: > >> > >> >> Add the device

Re: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-23 Thread Linus Walleij
On Fri, May 11, 2018 at 10:31 AM, Phil Edworthy wrote: > The DesignWare GPIO IP can be configured for either 1 interrupt or 1 > per GPIO in port A, but the driver currently only supports 1 interrupt. > See the DesignWare DW_apb_gpio Databook description of the >

Re: [PATCH v6 2/6] dt-bindings: Add the rzn1-clocks.h file

2018-05-23 Thread M P
Morning Geert, On Wed, 23 May 2018 at 08:26, Geert Uytterhoeven wrote: > Hi Michel, > On Wed, May 23, 2018 at 8:44 AM, M P wrote: > > On Tue, 22 May 2018 at 19:44, Geert Uytterhoeven > > wrote: > >> On Tue, May 22, 2018 at 12:01

Re: [PATCH] dt-bindings: gpio: rcar: Add support for r8a77990

2018-05-23 Thread Linus Walleij
On Fri, May 11, 2018 at 5:13 AM, Yoshihiro Shimoda wrote: > Add compatible string for R-Car E3 (r8a77990) in gpio-rcar. > > Signed-off-by: Yoshihiro Shimoda Quite uncontroversial so, patch applied with Simon's ACK. Yours,

Re: [PATCH v6 2/6] dt-bindings: Add the rzn1-clocks.h file

2018-05-23 Thread M P
On Tue, 22 May 2018 at 19:44, Geert Uytterhoeven wrote: > Hi Michel, > On Tue, May 22, 2018 at 12:01 PM, Michel Pollet > wrote: > > This adds the constants necessary to use the renesas,rzn1-clocks driver. > > > > Signed-off-by: Michel Pollet

Re: [PATCH 6/9] ARM: dts: wheat: Drop MTD partitioning from DT

2018-05-23 Thread Geert Uytterhoeven
Hi Marek, On Wed, May 23, 2018 at 12:01 AM, Marek Vasut wrote: > On 05/22/2018 04:43 PM, Geert Uytterhoeven wrote: >> On Tue, May 22, 2018 at 2:02 PM, Marek Vasut wrote: >>> Drop the MTD partitioning from DT, since it does not describe HW >>> and to

Re: [PATCH 4/4] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails

2018-05-23 Thread Geert Uytterhoeven
Hi Marek, On Tue, May 22, 2018 at 11:53 PM, Marek Vasut wrote: > On 05/22/2018 08:36 PM, Geert Uytterhoeven wrote: >> On Mon, May 21, 2018 at 3:11 PM, Marek Vasut wrote: >>> --- a/drivers/pci/host/pcie-rcar.c >>> +++ b/drivers/pci/host/pcie-rcar.c