Re: [linux-sunxi] [PATCH u-boot (sc)] Cleanups of various clock macro's

2014-03-27 Thread Ian Campbell
On Tue, 2014-03-25 at 11:00 +0100, oliver+l...@schinagl.nl wrote: From: Olliver Schinagl oli...@schinagl.nl This patch cleans up several macro's to remove magic values etc from clock.c and clock.h. Casualties being dragged in are some macro's from dram.c and the i2c driver. This addresses

[linux-sunxi] [PATCH] sunxi: use DIV_ROUND_UP in clock setup instead of custom RDIV

2014-03-27 Thread Ian Campbell
RDIV is lacking a set of brackets compared with DIV_ROUND_UP but due to precedence rules things work out the same for all callers. Confirmed with objdump before and after. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/clock.c | 5 ++--- 1 file changed, 2

[linux-sunxi] [PATCH] sunxi: use clrsetbit in gpio/pinmux code

2014-03-27 Thread Ian Campbell
as a single statement without barriers. I think this is safe. In any case the generated code is identical (confirmed with objdump). Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/pinmux.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff

[linux-sunxi] [PATCH] sunxi: remove some unnecesssary ()s from bare numbers

2014-03-27 Thread Ian Campbell
Picked up during upstream review. Signed-off-by: Ian Campbell i...@hellion.org.uk --- include/configs/sunxi-common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index 7b06c99..212b621 100644 --- a/include

[linux-sunxi] Re: [U-Boot] [PATCH v2 5/9] sunxi: generic sun7i build infrastructure.

2014-03-27 Thread Ian Campbell
On Mon, 2014-03-24 at 22:01 +0100, Marek Vasut wrote: diff --git a/arch/arm/cpu/armv7/sunxi/u-boot-spl-fel.lds b/arch/arm/cpu/armv7/sunxi/u-boot-spl-fel.lds new file mode 100644 index 000..cf02300 --- /dev/null +++ b/arch/arm/cpu/armv7/sunxi/u-boot-spl-fel.lds This file is

[linux-sunxi] Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-26 Thread Ian Campbell
On Mon, 2014-03-24 at 23:42 +0100, Olliver Schinagl wrote: [...] I've got a local cleanup patch set where I fixed this already to clrsetbits_le32 [...] Same here, got that in my local tree too Could you post what you've got please? +#ifdef CONFIG_SPL_BUILD +#define PLL1_CFG(N, K, M, P)

[linux-sunxi] Re: [U-Boot] [PATCH v2 2/9] sunxi: initial sun7i pinmux and gpio support

2014-03-26 Thread Ian Campbell
On Mon, 2014-03-24 at 21:54 +0100, Marek Vasut wrote: + cfg = readl(pio-cfg[0] + index); + cfg = ~(0xf offset); + cfg |= val offset; + + writel(cfg, pio-cfg[0] + index); clrsetbits_le32() here. I looked at this transform in a few different contexts and one concern I

[linux-sunxi] Re: [U-Boot] [PATCH v2 2/9] sunxi: initial sun7i pinmux and gpio support

2014-03-26 Thread Ian Campbell
On Mon, 2014-03-24 at 21:54 +0100, Marek Vasut wrote: +int sunxi_gpio_set_cfgpin(u32 pin, u32 val); +int sunxi_gpio_get_cfgpin(u32 pin); +int sunxi_gpio_set_drv(u32 pin, u32 val); +int sunxi_gpio_set_pull(u32 pin, u32 val); +int name_to_gpio(const char *name); +#define name_to_gpio

[linux-sunxi] Re: [U-Boot] [PATCH v2 2/9] sunxi: initial sun7i pinmux and gpio support

2014-03-26 Thread Ian Campbell
On Wed, 2014-03-26 at 10:03 +0100, Wolfgang Denk wrote: Dear Ian Campbell, In message 1395822781.29683.12.ca...@dagon.hellion.org.uk you wrote: On Mon, 2014-03-24 at 21:54 +0100, Marek Vasut wrote: +int sunxi_gpio_set_cfgpin(u32 pin, u32 val); +int sunxi_gpio_get_cfgpin(u32 pin

[linux-sunxi] Re: [PATCH+GIT 0/9] sunxi: upstream review based cleanups

2014-03-24 Thread Ian Campbell
On Mon, 2014-03-24 at 00:00 +0100, Henrik Nordström wrote: sön 2014-03-16 klockan 19:40 +0100 skrev Hans de Goede: Thanks I've added the 9 patches to the u-boot-sunxi repo sunxi branch, as for the merge with v2014.04-rc2, I would like to wait what HNO has to say about that. Merges from

Re: [linux-sunxi] Re: [PATCH 4/9] sunxi: only try to init dram once.

2014-03-24 Thread Ian Campbell
On Mon, 2014-03-24 at 00:21 +0100, Henrik Nordström wrote: sön 2014-03-16 klockan 17:34 + skrev Ian Campbell: As Alex explains in [0] this triple call likely dates back to before the DRAM init code used proper timings. It is not necessary any more. maybe, but not comfortable

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-24 Thread Ian Campbell
On Mon, 2014-03-24 at 12:55 +0800, Chen-Yu Tsai wrote: Hi, On Mon, Mar 24, 2014 at 4:21 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 03/23/2014 04:13 PM, Ian Campbell wrote: On Sat, 2014-03-22 at 20:22 +0100, Hans de Goede wrote: One thing that stands out when doing a diff

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-23 Thread Ian Campbell
On Sat, 2014-03-22 at 20:22 +0100, Hans de Goede wrote: One thing that stands out when doing a diff against sunxi-merge-v2014.04-rc2 is this: --- u-boot/drivers/net/designware.c 2014-03-21 16:26:42.229522420 +0100 +++ u-boot-sunxi/drivers/net/designware.c 2014-03-22

[linux-sunxi] Re: [U-Boot] [PATCH v2 4/9] sunxi: initial generic sun7i cpu, board and start of day support

2014-03-22 Thread Ian Campbell
On Sat, 2014-03-22 at 10:04 +0100, Hans de Goede wrote: Sorry, this is a NAK for these patches. These changes are not useful by themselves but are split out to make the patch sizes more manageable. This is not how we work. Patches have to implement specific features, or fix specific

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: use a 4MB malloc pool

2014-03-22 Thread Ian Campbell
On Fri, 2014-03-21 at 20:11 -0300, Emilio López wrote: Hi Ian, El vie 21 mar 2014 18:40:04 ART, Ian Campbell escribió: As advised by Tom. Signed-off-by: Ian Campbell i...@hellion.org.uk Cc: Tom Rini tr...@ti.com --- include/configs/sunxi-common.h | 4 ++-- 1 file changed, 2

[linux-sunxi] [PATCH u-boot-sunxi.git v2] sunxi: use a 4MB malloc pool

2014-03-22 Thread Ian Campbell
As advised by Tom. Signed-off-by: Ian Campbell i...@hellion.org.uk Cc: Tom Rini tr...@ti.com --- v2: Simplify (and make correct) the comment --- include/configs/sunxi-common.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/include/configs/sunxi-common.h b/include

[linux-sunxi] Re: [U-Boot] [PATCH v2 5/9] sunxi: generic sun7i build infrastructure.

2014-03-22 Thread Ian Campbell
On Sat, 2014-03-22 at 16:12 +0100, Hans de Goede wrote: Hi, On 03/22/2014 01:33 PM, Wolfgang Denk wrote: Dear Ian, In message 1395482650.2234.104.ca...@hastur.hellion.org.uk you wrote: What does that mean? I cannot find these names in the SoB lines? I explained the process by

[linux-sunxi] Re: [U-Boot] [PATCH v2 4/9] sunxi: initial generic sun7i cpu, board and start of day support

2014-03-22 Thread Ian Campbell
On Sat, 2014-03-22 at 13:27 +0100, Wolfgang Denk wrote: Dear Hans de Goede, In message 532d5238.6080...@redhat.com you wrote: These changes are not useful by themselves but are split out to make the patch sizes more manageable. This is not how we work. Patches have to implement

[linux-sunxi] Re: [PATCH u-boot sunxi 01/12] sunxi: Implement reset_cpu

2014-03-22 Thread Ian Campbell
On Sat, 2014-03-22 at 17:16 +0100, Hans de Goede wrote: Hi, On 03/18/2014 11:25 AM, Ian Campbell wrote: On Tue, 2014-03-18 at 00:00 +0100, Hans de Goede wrote: There is no way to reset the cpu, so use the watchdog for this. Did you see https://www.mail-archive.com/u-boot

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Ian Campbell
On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is: while(POKE THE HARDWARE); which obscures the potentially infinite loop, I've rewritten as: while(POKE

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Ian Campbell
On Fri, 2014-03-21 at 16:48 +0100, Hans de Goede wrote: Hi, On 03/21/2014 04:45 PM, Ian Campbell wrote: On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is: while

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Ian Campbell
On Fri, 2014-03-21 at 17:11 +0100, Hans de Goede wrote: Hi, On 03/21/2014 04:45 PM, Ian Campbell wrote: On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is: while

Re: [linux-sunxi] [PATCH 2/9] sunxi: define bit shifts for CPU_AHB_APB0_CFG_REG

2014-03-21 Thread Ian Campbell
On Fri, 2014-03-21 at 22:01 +0100, Olliver Schinagl wrote: On 03/16/2014 06:34 PM, Ian Campbell wrote: Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/clock.c| 31 +++ arch/arm/include/asm/arch-sunxi/clock.h | 8

[linux-sunxi] [PATCH v2 6/9] sunxi: add support for Cubietruck booting in FEL mode

2014-03-21 Thread Ian Campbell
Signed-off-by: Oliver Schinagl oli...@schinagl.nl Signed-off-by: Ian Campbell i...@hellion.org.uk Reviewed-by: Tom Rini tr...@ti.com --- v2: Based on u-boot-sunxi.git#sunxi d9aa5dd3d15c sunxi: mmc: checkpatch whitespace fixes with v2014.04-rc2 merged in. v1: Based on u-boot-sunxi.git#sunxi commit

[linux-sunxi] [PATCH v2 7/9] sunxi: add gmac Ethernet support

2014-03-21 Thread Ian Campbell
Signed-off-by: Chen-Yu Tsai w...@csie.org Signed-off-by: Jens Kuske jensku...@gmail.com Signed-off-by: Ian Campbell i...@hellion.org.uk --- v2: Based on u-boot-sunxi.git#sunxi d9aa5dd3d15c sunxi: mmc: checkpatch whitespace fixes with v2014.04-rc2 merged in: - drop accidentally doubled hunk

[linux-sunxi] [PATCH v2 2/9] sunxi: initial sun7i pinmux and gpio support

2014-03-21 Thread Ian Campbell
Schaik Henrik Nordstrom Stefan Roese Tom Cubie Signed-off-by: Chen-Yu Tsai w...@csie.org Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Ma Haijun mahaij...@gmail.com Signed-off-by: Oliver Schinagl oli...@schinagl.nl Signed-off-by: Ian Campbell i...@hellion.org.uk Reviewed-by: Tom

[linux-sunxi] [PATCH v2 0/9] sunxi: initial upstreamining effort

2014-03-21 Thread Ian Campbell
This is my second cut at an upstreamable series based upon the https://github.com/linux-sunxi/u-boot-sunxi.git#sunxi tree. The intention is to present a minimal starting point for upstreaming to which support for other processors, peripherals, boards etc can be added in the future. Therefore this

[linux-sunxi] [PATCH v2 9/9] sunxi: non-FEL SPL boot support for sun7i

2014-03-21 Thread Ian Campbell
As well as the following signed-off-by the sunxi branch shows commits to these files authored by the following: Henrik Nordstrom Tom Cubie Signed-off-by: Stefan Roese s...@denx.de Signed-off-by: Ian Campbell i...@hellion.org.uk --- v2: Based on u-boot-sunxi.git#sunxi d9aa5dd3d15c sunxi: mmc

[linux-sunxi] [PATCH v2 4/9] sunxi: initial generic sun7i cpu, board and start of day support

2014-03-21 Thread Ian Campbell
...@gmail.com Signed-off-by: Stefan Roese s...@denx.de Signed-off-by: Wills Wang wills.wang.o...@gmail.com Signed-off-by: Ian Campbell i...@hellion.org.uk --- v2: Based on u-boot-sunxi.git#sunxi d9aa5dd3d15c sunxi: mmc: checkpatch whitespace fixes with v2014.04-rc2 merged in: - just init dram once

[linux-sunxi] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-21 Thread Ian Campbell
...@henriknordstrom.net Signed-off-by: Jens Kuske jensku...@gmail.com Signed-off-by: Luke Leighton l...@lkcl.net Signed-off-by: Oliver Schinagl oli...@schinagl.nl Signed-off-by: Ian Campbell i...@hellion.org.uk --- v2: Based on u-boot-sunxi.git#sunxi d9aa5dd3d15c sunxi: mmc: checkpatch whitespace fixes

[linux-sunxi] [PATCH v2 8/9] sunxi: mmc support

2014-03-21 Thread Ian Campbell
...@schinagl.nl Signed-off-by: Wills Wang wills.wang.o...@gmail.com Signed-off-by: Ian Campbell i...@hellion.org.uk Cc: Pantelis Antoniou pa...@antoniou-consulting.com --- Pantelis, most of your review comments have been addressed but not all, in particular the timeout loops aren't sorted yet, but I wanted to get

[linux-sunxi] [PATCH v2 5/9] sunxi: generic sun7i build infrastructure.

2014-03-21 Thread Ian Campbell
patrickhw...@gmail.com Signed-off-by: Stefan Roese s...@denx.de Signed-off-by: Wills Wang wills.wang.o...@gmail.com Signed-off-by: Ian Campbell i...@hellion.org.uk --- v2: Based on u-boot-sunxi.git#sunxi d9aa5dd3d15c sunxi: mmc: checkpatch whitespace fixes with v2014.04-rc2 merged in: - sunxi

[linux-sunxi] [PATCH v2 3/9] sunxi: initial sun7i dram setup support

2014-03-21 Thread Ian Campbell
-by: Oliver Schinagl oli...@schinagl.nl Signed-off-by: Stefan Roese s...@denx.de Signed-off-by: Ian Campbell i...@hellion.org.uk --- v2: Based on u-boot-sunxi.git#sunxi d9aa5dd3d15c sunxi: mmc: checkpatch whitespace fixes with v2014.04-rc2 merged in: - remove redundant braces in mctl_ddr3_reset

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Ian Campbell
On Fri, 2014-03-21 at 17:11 +0100, Hans de Goede wrote: Hi, On 03/21/2014 04:45 PM, Ian Campbell wrote: On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is: while

[linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: setup environment so initrd and fdt are relocated to safe addresses

2014-03-20 Thread Ian Campbell
and initrd_high= are no longer required. Signed-off-by: Ian Campbell i...@hellion.org.uk Cc: Tom Rini tr...@ti.com --- include/configs/sunxi-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index efa77f2

[linux-sunxi] [PATCH u-boot-sunxi.git 0/9] sunxi: mmc: removal of magic numbers

2014-03-20 Thread Ian Campbell
The following patches remove the majority of the magic numbers from the mmc driver, as part of the preparation for upstreaming. The names/meanings of the various bits are partially inferred from existing comments and partially from the Linux driver. Also a little refactoring and checkpatch

[linux-sunxi] [PATCH u-boot-sunxi.git 1/9] sunxi: mmc: add braces to remove ambiguity

2014-03-20 Thread Ian Campbell
Signed-off-by: Ian Campbell i...@hellion.org.uk --- Cleanup due to upstream review. --- drivers/mmc/sunxi_mmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c index 80e4369..b6f2f96 100644 --- a/drivers/mmc/sunxi_mmc.c +++ b

[linux-sunxi] [PATCH u-boot-sunxi.git 3/9] sunxi: mmc: defines for clock bits

2014-03-20 Thread Ian Campbell
Objdump confirms no difference in the resulting binary. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/include/asm/arch-sunxi/clock.h | 7 +++ drivers/mmc/sunxi_mmc.c | 5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm

[linux-sunxi] [PATCH u-boot-sunxi.git 2/9] sunxi: mmc: defines for various mmc control bits

2014-03-20 Thread Ian Campbell
Mostly derived from existing comments. There are plenty of undefined bits still though. Objdump confirms that the resulting binary is identical. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/include/asm/arch-sunxi/mmc.h | 19 ++ drivers/mmc/sunxi_mmc.c

[linux-sunxi] [PATCH u-boot-sunxi.git 4/9] sunxi: mmc: defines for mmc ctrl and cmd registers

2014-03-20 Thread Ian Campbell
Inferred from Linux driver. Objdump confirms no change to the resulting binary. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/include/asm/arch-sunxi/mmc.h | 11 ++ drivers/mmc/sunxi_mmc.c | 39 --- 2 files changed, 24

[linux-sunxi] [PATCH u-boot-sunxi.git 6/9] sunxi: mmc: defines for rint register bits

2014-03-20 Thread Ian Campbell
Names from Linux driver Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/include/asm/arch-sunxi/mmc.h | 35 +++ drivers/mmc/sunxi_mmc.c | 19 +++ 2 files changed, 46 insertions(+), 8 deletions(-) diff --git a/arch/arm

[linux-sunxi] [PATCH u-boot-sunxi.git 8/9] sunxi: mmc: refactor similar wait loops

2014-03-20 Thread Ian Campbell
Signed-off-by: Ian Campbell i...@hellion.org.uk --- drivers/mmc/sunxi_mmc.c | 55 ++--- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c index 34c4996..a09e021 100644 --- a/drivers/mmc

[linux-sunxi] [PATCH u-boot-sunxi.git 7/9] sunxi: mmc: defines for status register

2014-03-20 Thread Ian Campbell
Objdump confirms no change to the resulting binary. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/include/asm/arch-sunxi/mmc.h | 8 drivers/mmc/sunxi_mmc.c | 8 +--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/arch/arm/include/asm

[linux-sunxi] [PATCH u-boot-sunxi.git 5/9] sunxi: mmc: refactor enabling/disable DMA accesses

2014-03-20 Thread Ian Campbell
And remove a magic number in the process. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/include/asm/arch-sunxi/mmc.h | 1 + drivers/mmc/sunxi_mmc.c | 18 ++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/arch/arm/include/asm/arch

[linux-sunxi] Re: [PATCH u-boot sunxi 01/12] sunxi: Implement reset_cpu

2014-03-18 Thread Ian Campbell
On Tue, 2014-03-18 at 00:00 +0100, Hans de Goede wrote: There is no way to reset the cpu, so use the watchdog for this. Did you see https://www.mail-archive.com/u-boot@lists.denx.de/msg134259.html ? Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/cpu/armv7/sunxi/board.c

[linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: add a comment about the magic numbers in dram.c

2014-03-18 Thread Ian Campbell
Wording mostly stolen from Henrik in http://mid.gmane.org/1394814510.13238.8.camel@localhost Signed-off-by: Ian Campbell i...@hellion.org.uk Cc: Henrik Nordström hen...@henriknordstrom.net --- Cleanup due to upstream review. --- arch/arm/cpu/armv7/sunxi/dram.c | 7 +++ 1 file changed, 7

[linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: mksunxiboot: be silent unless something goes wrong

2014-03-18 Thread Ian Campbell
Also notice that perror includes the : after the message but before the errno str, so omit it from the existing calls. Signed-off-by: Ian Campbell i...@hellion.org.uk --- Not immediately relevant, but these messages stick out like a sore thumb with the v2014.04-rc2 Kbuild stuff. --- tools

[linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: fix a typo

2014-03-18 Thread Ian Campbell
Signed-off-by: Ian Campbell i...@hellion.org.uk --- Cleanup due to upstream review --- arch/arm/cpu/armv7/sunxi/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/sunxi/board.c b/arch/arm/cpu/armv7/sunxi/board.c index 0abf27e..94c5cd0 100644 --- a/arch

[linux-sunxi] Re: [PATCH u-boot sunxi 5/5] mmc: sunxi: Use sunxi gpio functions to configure pins

2014-03-17 Thread Ian Campbell
On Mon, 2014-03-17 at 12:05 +0800, Chen-Yu Tsai wrote: @@ -162,40 +151,47 @@ static int mmc_clk_io_on(int sdc_no) switch (sdc_no) { case 0: /* D1-PF0, D0-PF1, CLK-PF2, CMD-PF3, D3-PF4, D4-PF5 */ - writel(0x22, gpio_f-cfg[0]); -

[linux-sunxi] Re: [PATCH u-boot sunxi 5/5] mmc: sunxi: Use sunxi gpio functions to configure pins

2014-03-17 Thread Ian Campbell
On Mon, 2014-03-17 at 09:49 +0100, Hans de Goede wrote: Hi, On 03/17/2014 09:28 AM, Ian Campbell wrote: On Mon, 2014-03-17 at 12:05 +0800, Chen-Yu Tsai wrote: @@ -162,40 +151,47 @@ static int mmc_clk_io_on(int sdc_no) switch (sdc_no) { case 0: /* D1-PF0, D0-PF1, CLK

[linux-sunxi] Re: [U-Boot] [PATCH v1 5/9] sunxi: generic sun7i build infrastructure.

2014-03-17 Thread Ian Campbell
On Mon, 2014-03-17 at 11:04 -0400, Tom Rini wrote: On Sun, Mar 16, 2014 at 01:25:33PM +, Ian Campbell wrote: On Fri, 2014-03-14 at 10:17 -0400, Tom Rini wrote: On Fri, Mar 14, 2014 at 10:33:47AM +, Ian Campbell wrote: +/* + * Size of malloc() pool + * 1MB = 0x10

[linux-sunxi] Re: [U-Boot] [PATCH v1 0/9] sunxi: initial upstreamining effort

2014-03-16 Thread Ian Campbell
On Fri, 2014-03-14 at 15:17 -0500, Dennis Gilmore wrote: On Fri, 14 Mar 2014 10:16:42 -0400 Tom Rini tr...@ti.com wrote: On Fri, Mar 14, 2014 at 10:33:32AM +, Ian Campbell wrote: Hi, This is my first cut at an upstreamable series based upon the https://github.com/linux

[linux-sunxi] Re: [U-Boot] [PATCH v1 5/9] sunxi: generic sun7i build infrastructure.

2014-03-16 Thread Ian Campbell
On Fri, 2014-03-14 at 10:17 -0400, Tom Rini wrote: On Fri, Mar 14, 2014 at 10:33:47AM +, Ian Campbell wrote: +/* + * Size of malloc() pool + * 1MB = 0x10, 0x10 = 1024 * 1024 + */ +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (1 20)) This is really

Re: [U-Boot] [linux-sunxi] [PATCH v1 9/9] sunxi: add gmac Ethernet support

2014-03-16 Thread Ian Campbell
On Fri, 2014-03-14 at 10:22 -0400, Tom Rini wrote: On Fri, Mar 14, 2014 at 11:28:06AM +, Ian Campbell wrote: On Fri, 2014-03-14 at 19:11 +0800, Chen-Yu Tsai wrote: [snip] I think you should keep them in the same patch. You can then just add the appropriate config options when support

[linux-sunxi] Re: [U-Boot] [PATCH v1 8/9] sunxi: non-FEL SPL boot support for sun7i

2014-03-16 Thread Ian Campbell
On Sun, 2014-03-16 at 15:19 +, Ian Campbell wrote: On Fri, 2014-03-14 at 15:03 -0400, Tom Rini wrote: On 03/14/2014 02:50 PM, Hans de Goede wrote: Hi, On 03/14/2014 03:17 PM, Tom Rini wrote: On Fri, Mar 14, 2014 at 10:33:50AM +, Ian Campbell wrote: Based linux-sunxi

[linux-sunxi] [PATCH 2/9] sunxi: define bit shifts for CPU_AHB_APB0_CFG_REG

2014-03-16 Thread Ian Campbell
Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/clock.c| 31 +++ arch/arm/include/asm/arch-sunxi/clock.h | 8 ++-- 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/arch/arm/cpu/armv7/sunxi/clock.c b/arch/arm/cpu

[linux-sunxi] [PATCH 7/9] sunxi: configuration updates

2014-03-16 Thread Ian Campbell
Based on feedback from Tom Rini: - drop unnecessary CONFIG_SYS_PROMPT_HUSH_PS2 - drop deprecated mtest settings - use generic baud rate table Signed-off-by: Ian Campbell i...@hellion.org.uk --- include/configs/sunxi-common.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff

[linux-sunxi] [PATCH 9/9] sunxi: remove key driver

2014-03-16 Thread Ian Campbell
This code hasn't been called since the calls to it randomly disappeared in 71e6be0ccbd5 sunxi: get u-boot mmc spl work and 4d29a5dd7414 sunxi: further clean sunxi platform. It seems to have only ever been used as test code anyway. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu

[linux-sunxi] [PATCH 1/9] sunxi: simplify get_tbclk

2014-03-16 Thread Ian Campbell
Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/timer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/cpu/armv7/sunxi/timer.c b/arch/arm/cpu/armv7/sunxi/timer.c index d21289a..d0d9953 100644 --- a/arch/arm/cpu/armv7/sunxi/timer.c

[linux-sunxi] [PATCH 8/9] sunxi: Increase CONFIG_SYS_BOOTMAPSZ to 256MB

2014-03-16 Thread Ian Campbell
This value is supposed to reflect the lowmem mapping of the kernel. The existing 16MB is clearly much to small for this. 256MB is likely to still be an underestimate but is a reasonable, if conservative, value. Signed-off-by: Ian Campbell i...@hellion.org.uk --- include/configs/sunxi-common.h

[linux-sunxi] [PATCH 5/9] sunxi: clock_set_pll1 takes Hz not MHz

2014-03-16 Thread Ian Campbell
This was only wrong in the prototype. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/include/asm/arch-sunxi/clock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/asm/arch-sunxi/clock.h b/arch/arm/include/asm/arch-sunxi/clock.h index dc8c371

[linux-sunxi] [PATCH 3/9] sunxi: #define default values and shifts for pll cfg registers

2014-03-16 Thread Ian Campbell
Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/clock.c| 10 ++ arch/arm/include/asm/arch-sunxi/clock.h | 9 + 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/arch/arm/cpu/armv7/sunxi/clock.c b/arch/arm/cpu/armv7/sunxi/clock.c

[linux-sunxi] Re: [PATCH u-boot sunxi 2/4] sunxi: FIXUP: sunxi: initial sun7i dram setup support

2014-03-16 Thread Ian Campbell
On Sun, 2014-03-16 at 14:53 +0100, Hans de Goede wrote: mctl_ddr3_reset() should not be called here for sun7i, at least the u-boot-sunxi sources don't do this. oops, I misread an ifndef. I'll fold in, thanks. Ian. -- You received this message because you are subscribed to the Google Groups

[linux-sunxi] Re: [PATCH u-boot sunxi 3/4] sunxi: Implement reset_cpu

2014-03-16 Thread Ian Campbell
On Sun, 2014-03-16 at 14:53 +0100, Hans de Goede wrote: There is no way to reset the cpu, so use the watchdog for this. The sunxi.git tree does this by calling watchdog_set(0). I think it would be better to introduce the generic watchdog support and the add this a patch to use it for reset.

[linux-sunxi] Re: [PATCH+GIT 0/9] sunxi: upstream review based cleanups

2014-03-16 Thread Ian Campbell
On Sun, 2014-03-16 at 19:40 +0100, Hans de Goede wrote: Thanks I've added the 9 patches to the u-boot-sunxi repo sunxi branch, Thanks. as for the merge with v2014.04-rc2, I would like to wait what HNO has to say about that. I've rebased onto what you've now applied and force pushed the

[linux-sunxi] Re: [U-Boot] [PATCH v1 7/9] sunxi: mmc support

2014-03-16 Thread Ian Campbell
On Fri, 2014-03-14 at 17:36 +0200, Pantelis Antoniou wrote: [...] Thanks for your review. It seems there are still quite a few issues dating back to the original allwinner dumps here. @linux-sunxi: if anyone wants to volunteer to help cleanup this particular driver I'd be very happy -- there's

[linux-sunxi] [PATCH v1 0/9] sunxi: initial upstreamining effort

2014-03-14 Thread Ian Campbell
Hi, This is my first cut at an upstreamable series based upon the https://github.com/linux-sunxi/u-boot-sunxi.git#sunxi tree. The intention is to present a minimal starting point for upstreaming to which support for other processors, peripherals, boards etc can be added in the future. Therefore

[linux-sunxi] [PATCH v1 4/9] sunxi: initial generic sun7i cpu, board and start of day support

2014-03-14 Thread Ian Campbell
-Yu Tsai w...@csie.org Signed-off-by: Emilio López emi...@elopez.com.ar Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Henrik Nordstrom hen...@henriknordstrom.net Signed-off-by: Ian Campbell i...@hellion.org.uk Signed-off-by: Jens Kuske jensku...@gmail.com Signed-off-by: Luc

[linux-sunxi] [PATCH v1 9/9] sunxi: add gmac Ethernet support

2014-03-14 Thread Ian Campbell
Based linux-sunxi#sunxi commit d854c4de2f57 arm: Handle .gnu.hash section in ldscripts vs v2014.01. Signed-off-by: Chen-Yu Tsai w...@csie.org Signed-off-by: Jens Kuske jensku...@gmail.com Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/board.c | 15

Re: [linux-sunxi] [PATCH v1 9/9] sunxi: add gmac Ethernet support

2014-03-14 Thread Ian Campbell
On Fri, 2014-03-14 at 19:11 +0800, Chen-Yu Tsai wrote: Thanks for working on this! No problem. I see you left out all the CONFIG_RGMII ifdefs from this file. Not sure if it's because you're aiming to support only the Cubietruck first. Yes, exactly. I think you should keep them in the same

[linux-sunxi] Re: [U-Boot] [PATCH v1 0/9] sunxi: initial upstreamining effort

2014-03-14 Thread Ian Campbell
On Fri, 2014-03-14 at 08:55 -0400, Tom Rini wrote: On Fri, Mar 14, 2014 at 10:33:32AM +, Ian Campbell wrote: Hi, This is my first cut at an upstreamable series based upon the https://github.com/linux-sunxi/u-boot-sunxi.git#sunxi tree. The intention is to present a minimal

[linux-sunxi] Re: [U-Boot] [PATCH v1 0/9] sunxi: initial upstreamining effort

2014-03-14 Thread Ian Campbell
On Fri, 2014-03-14 at 10:16 -0400, Tom Rini wrote: On Fri, Mar 14, 2014 at 10:33:32AM +, Ian Campbell wrote: Hi, This is my first cut at an upstreamable series based upon the https://github.com/linux-sunxi/u-boot-sunxi.git#sunxi tree. The intention is to present a minimal

Re: [linux-sunxi] [PATCH v3 0/4] uboot sata support for sunxi platform

2014-03-12 Thread Ian Campbell
On Wed, 2014-03-12 at 14:17 +0100, Koen Kooi wrote: Op 12 mrt. 2014, om 13:56 heeft Ian Campbell i...@hellion.org.uk het volgende geschreven: On Wed, 2014-03-12 at 05:43 -0700, Ezaul Zillmer wrote: I'm afraid much of your mail was incomprehensible to me. setenv bootargs console

Re: [linux-sunxi] [PATCH v3 0/4] uboot sata support for sunxi platform

2014-03-12 Thread Ian Campbell
On Wed, 2014-03-12 at 06:53 -0700, Ezaul Zillmer wrote: Nothing appears scsi info Perhaps try increasing WAIT_MS_LINKUP some more (as per patch 3/4)? Ian. -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from

Re: [linux-sunxi] [PATCH u-boot] cmd_gpio: fix warning with GPIO_OSCILLATE

2014-03-11 Thread Ian Campbell
On Sun, 2014-03-09 at 20:10 +0100, Olliver Schinagl wrote: Ian, sorry for not replying earlier, but isn't that a bug-fix against the generic U-Boot? In that case, it's probably wise to post it on the u-boot mailing list :) As Henrik says it's actually sunxi functionality. This particular

Default initrd and fdt load behaviour on ARM (Was: Re: [linux-sunxi] Re: Not able to boot ramdisk on cubietruck)

2014-03-11 Thread Ian Campbell
Adding u-boot list since I think this is a general issue/question. On Sun, 2014-03-09 at 20:00 +0100, Olliver Schinagl wrote: On 03/09/14 16:18, tyler.ba...@linaro.org wrote: On Sunday, March 9, 2014 8:06:27 AM UTC-7, tyler...@linaro.org wrote: Hello, I am trying to boot the cubietruck

Re: [linux-sunxi] [PATCH v3 0/4] uboot sata support for sunxi platform

2014-03-07 Thread Ian Campbell
On Fri, 2014-03-07 at 08:44 -0800, Ezaul Zillmer wrote: You would have a repository with these updates where I could play with git, compile and test my cubieboard2 using kernel 3.14.rc5 git://gitorious.org/ijc/u-boot.git ahci-sunxi It is based on jwrdegoede/sunxi-next. Ian. -- You

[linux-sunxi] [PATCH v3 0/4] uboot sata support for sunxi platform

2014-03-06 Thread Ian Campbell
This is the third version of my series to add support for AHCI to the sunxi platform. This uses the existing ahci platform support already present in u-boot. Most of the sunxi specific code comes from the Linux platform patches. Since last time I've cut out all the unused register #defines and

[linux-sunxi] [PATCH v3 1/4] ahci-plat: Provide a weak scsi_init hook

2014-03-06 Thread Ian Campbell
This allow the platform to register the platform ahci device. Signed-off-by: Ian Campbell i...@hellion.org.uk --- In theory this could perhaps be used by highbank. I have access to a Midway system (close enough for testing purposes, I think) but since Calxeda has folded I'm not sure it is worth

[linux-sunxi] [PATCH v3 2/4] highbank: use scsi_init hook

2014-03-06 Thread Ian Campbell
Signed-off-by: Ian Campbell i...@hellion.org.uk --- board/highbank/highbank.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/board/highbank/highbank.c b/board/highbank/highbank.c index 4b272c7..d42447d 100644 --- a/board/highbank/highbank.c +++ b/board

[linux-sunxi] [PATCH v3 3/4] ahci: wait longer for link.

2014-03-06 Thread Ian Campbell
there is any harm in waiting a bit longer. Signed-off-by: Ian Campbell i...@hellion.org.uk --- drivers/block/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c index d5370fa..90a0719 100644 --- a/drivers/block/ahci.c +++ b/drivers/block

[linux-sunxi] [PATCH v3 4/4] ahci: provide sunxi SATA driver using AHCI platform framework

2014-03-06 Thread Ian Campbell
to the core driver, under a suitable ifdef. This option is enabled for Cubieboard, Cubieboard2, Cubietruck and Olinuxino Micro based on contents of Linux DTS files, including SATA power pin config taken from the DTS. All build tested, but runtime tested on cubietruck (FEL) only. Signed-off-by: Ian

Re: [linux-sunxi] [PATCH v3 0/4] uboot sata support for sunxi platform

2014-03-06 Thread Ian Campbell
On Fri, 2014-03-07 at 01:19 +, Ian Campbell wrote: This is the third version of my series to add support for AHCI to the sunxi platform. This uses the existing ahci platform support already present in u-boot. Most of the sunxi specific code comes from the Linux platform patches. Since

[linux-sunxi] [PATCH v2 0/3] uboot sata support for sunxi platform

2014-02-20 Thread Ian Campbell
This is the second version of my series to add support for AHCI to the sunxi platform. This uses the existing ahci platform support already present in u-boot. Most of the sunxi specific code comes from the Linux platform patches. As requested I am also cross posting to the main uboot mailing list

[linux-sunxi] [PATCH v2 1/3] ahci-plat: Provide a weak scsi_init hook

2014-02-20 Thread Ian Campbell
This allow the platform to register the platform ahci device. Signed-off-by: Ian Campbell i...@hellion.org.uk --- In theory this could perhaps be used by highbank. I have access to a Midway system (close enough for testing purposes, I think) but since Calxeda has folded I'm not sure it is worth

[linux-sunxi] [PATCH v2 2/3] ahci: wait longer for link.

2014-02-20 Thread Ian Campbell
there is any harm in waiting a bit longer. Signed-off-by: Ian Campbell i...@hellion.org.uk --- drivers/block/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c index d5370fa..90a0719 100644 --- a/drivers/block/ahci.c +++ b/drivers/block

Re: [linux-sunxi] [PATCH u-boot 2/3] ahci: wait longer for link.

2014-02-12 Thread Ian Campbell
On Wed, 2014-02-12 at 11:41 +0100, Marek Vasut wrote: Just make sure you don't bring in another DWC AHCI driver ;-) I think we have three already and someone should start looking into cleaning this up too. FWIW I was just reusing the existing platform AHCI stuff, no new driver here ;-). Ian.

Re: [linux-sunxi] [PATCH u-boot 2/3] ahci: wait longer for link.

2014-02-12 Thread Ian Campbell
On Wed, 2014-02-12 at 14:19 +0100, Henrik Nordström wrote: ons 2014-02-12 klockan 10:29 + skrev Ian Campbell: What I've thought of doing is creating a rebasing git branch based on the current mainline base used in the sunxi branch. The contents of the mainlining branch would

Re: [linux-sunxi] [PATCH 0/3] uboot sata support

2014-02-10 Thread Ian Campbell
On Fri, 2014-02-07 at 17:36 +0100, Hans de Goede wrote: Hi, On 02/07/2014 05:14 PM, Ian Campbell wrote: This is the result of my afternoons hacking at the urlab hacklab in Brussels before FOSDEM, thanks for hosting us guys! This uses the existing ahci platform support in u-boot. Most

Re: [linux-sunxi] [PATCH 2/3] ahci: wait longer for link.

2014-02-10 Thread Ian Campbell
On Sun, 2014-02-09 at 13:50 +0100, Oliver Schinagl wrote: On 02/07/14 17:15, Ian Campbell wrote: -#define WAIT_MS_LINKUP 4 +#define WAIT_MS_LINKUP 40 wont this affect every platform? Yes. I figured that since this was a timeout it was pretty harmless to increase it, the only

[linux-sunxi] [PATCH 0/3] uboot sata support

2014-02-07 Thread Ian Campbell
This is the result of my afternoons hacking at the urlab hacklab in Brussels before FOSDEM, thanks for hosting us guys! This uses the existing ahci platform support in u-boot. Most of the siunxi specific code comes from the Linux platform patches. I've tested this only on cubietruck. Ian. --

[linux-sunxi] [PATCH 1/3] ahci-plat: Provide a weak scsi_init hook

2014-02-07 Thread Ian Campbell
This allow the platform to register the platform ahci device. Signed-off-by: Ian Campbell i...@hellion.org.uk --- In theory this could go into mainline now and perhaps be used by highbank. --- arch/arm/lib/board.c | 6 ++ drivers/block/ahci.c | 5 + 2 files changed, 11 insertions

[linux-sunxi] [PATCH 3/3] ahci: provide sunxi SATA driver using AHCI platform framework

2014-02-07 Thread Ian Campbell
-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/clock.c | 4 ++ boards.cfg | 4 +- drivers/block/Makefile | 1 + drivers/block/ahci.c | 15 ++- drivers/block/ahci_sunxi.c | 95 include

[linux-sunxi] [PATCH 2/3] ahci: wait longer for link.

2014-02-07 Thread Ian Campbell
I have observed timeouts on a cubietruck. The increase to 40ms is completely arbitrary and Works For Me(tm). I couldn't find a good reference for how long you are supposed to wait. Signed-off-by: Ian Campbell i...@hellion.org.uk --- drivers/block/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1

[linux-sunxi] [PATCH u-boot] sunxi: correct CLK_DLY configuration loop

2014-01-31 Thread Ian Campbell
) and AFAICT all board/sunxi/dram_* files currently in the tree set trp3 to zero. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/dram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/sunxi/dram.c b/arch/arm/cpu/armv7/sunxi/dram.c index

[linux-sunxi] [PATCH u-boot] cmd_gpio: fix warning with GPIO_OSCILLATE

2014-01-31 Thread Ian Campbell
In do_gpio value is not initialised in the GPIO_OSCILLATE case: cmd_gpio.c: In function ‘do_gpio’: cmd_gpio.c:92:2: warning: ‘value’ may be used uninitialized in this function [-Wmaybe-uninitialized] return value; ^ Returning 0 in this case seems fairly logical. Signed-off-by: Ian Campbell

Re: [linux-sunxi] [PATCH] tools: correct proftool build rule

2014-01-31 Thread Ian Campbell
On Fri, 2014-01-31 at 17:07 +, Ian Campbell wrote: The incorrect substitution made it rebuild every time. I sent this to linux-sunxi@ instead of the u-boot list by mistake. Sorry! Will resend to the correct place shortly... -- You received this message because you are subscribed

[linux-sunxi] [PATCH] sunxi: dts: add a note that memory size is adjusted by boot loader.

2014-01-24 Thread Ian Campbell
I had to spend a couple of minutes proving to myself that this was the case on cubietruck, so add a comment to save the next guy some effort. Signed-off-by: Ian Campbell i...@hellion.org.uk Cc: Maxime Ripard maxime.rip...@free-electrons.com Cc: Hans de Goede hdego...@redhat.com Cc: linux-arm-ker

[linux-sunxi] Re: [PATCH] sunxi: dts: add a note that memory size is adjusted by boot loader.

2014-01-24 Thread Ian Campbell
On Fri, 2014-01-24 at 16:31 +0100, Hans de Goede wrote: Hi, On 01/24/2014 03:14 PM, Ian Campbell wrote: I had to spend a couple of minutes proving to myself that this was the case on cubietruck, so add a comment to save the next guy some effort. Seems like a good idea to me, one

Re: [linux-sunxi] Doing some sunxi hacking in Brussels the Friday before Fosdem ?

2014-01-23 Thread Ian Campbell
On Wed, 2014-01-22 at 20:16 +0100, Hans de Goede wrote: I will be at the urlab at around 12:00 (if I make my train connection otherwise 13:00), it is fine if you decide to show up announced, I plan to stay till 20:00 and then go out for dinner. I hope to see you there. I think I should be

<    1   2   3   4   5   >