Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-11 Thread Felipe Balbi
Hi, On Fri, Mar 08, 2013 at 10:26:45AM -0700, Stephen Warren wrote: On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that we have sensible names for all phy drivers.

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-11 Thread Felipe Balbi
Hi, On Fri, Mar 08, 2013 at 11:33:48AM -0700, Stephen Warren wrote: On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that we have sensible names for all phy drivers.

Re: [PATCH 3/3] usb: phy: isp1301: implement PHY API

2013-03-11 Thread Felipe Balbi
On Fri, Mar 08, 2013 at 11:53:21PM +0400, Sergei Shtylyov wrote: Hello. On 08-03-2013 15:30, Felipe Balbi wrote: this patch implements -init() and -set_vbus() methods for isp1301 transceiver driver. Later patches can now come in order to remove the hackery from ohci-nxp and lpc32xx udc

Re: [PATCH 1/3] usb: phy: isp1301: give it a context structure

2013-03-11 Thread Felipe Balbi
On Fri, Mar 08, 2013 at 11:47:13PM +0400, Sergei Shtylyov wrote: Hello. On 08-03-2013 15:30, Felipe Balbi wrote: this patch is a small preparation to fix isp1301 driver so that other platforms can use it. We're defining our private data structure to represent this device and adding

RE: [PATCH 00/12] UVC gadget patches for v3.10

2013-03-11 Thread Bhupesh SHARMA
Hi Laurent, -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Saturday, March 02, 2013 1:16 AM To: linux-usb@vger.kernel.org Cc: Bhupesh SHARMA; Cyril Roelandt; Chen Gang; Felipe Balbi Subject: [PATCH 00/12] UVC gadget patches for v3.10

Re: [PATCH 01/13] usb: phy: nop: Add device tree support and binding information

2013-03-11 Thread Roger Quadros
On 03/08/2013 05:45 PM, Marc Kleine-Budde wrote: On 03/08/2013 11:46 AM, Marc Kleine-Budde wrote: On 02/04/2013 04:58 PM, Roger Quadros wrote: The PHY clock, clock rate, VCC regulator and RESET regulator can now be provided via device tree. Signed-off-by: Roger Quadros rog...@ti.com ---

[PATCH] vers/usb/gadget: beautify code, delete useless comments

2013-03-11 Thread Chen Gang
since parameter driver has been deleted, also need delete relative comments. relative commit number is d93e2600d80fc41ccf339b4a2843a3007d479907 Signed-off-by: Chen Gang gang.c...@asianux.com --- drivers/usb/gadget/s3c-hsudc.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-)

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Chen Gang
于 2013年03月04日 22:35, Felipe Balbi 写道: since stop_activity() also gets called from RESET interrupt, and in that case we need to call driver-disconnect(). Can you make a simple test that would take current code and issue a device reset to see if that would break, then apply my suggestion above

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Felipe Balbi
On Mon, Mar 11, 2013 at 06:17:10PM +0800, Chen Gang wrote: 于 2013年03月04日 22:35, Felipe Balbi 写道: since stop_activity() also gets called from RESET interrupt, and in that case we need to call driver-disconnect(). Can you make a simple test that would take current code and issue a device

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Chen Gang
于 2013年03月11日 18:17, Chen Gang 写道: 于 2013年03月04日 22:35, Felipe Balbi 写道: since stop_activity() also gets called from RESET interrupt, and in that case we need to call driver-disconnect(). Can you make a simple test that would take current code and issue a device reset to see if that would

Re: [PATCH] vers/usb/gadget: beautify code, delete useless comments

2013-03-11 Thread Felipe Balbi
On Mon, Mar 11, 2013 at 06:14:19PM +0800, Chen Gang wrote: since parameter driver has been deleted, also need delete relative comments. relative commit number is d93e2600d80fc41ccf339b4a2843a3007d479907 Signed-off-by: Chen Gang gang.c...@asianux.com please come up with a better

[PATCH] usb: gadget: s3c-hsudc: delete outdated comment

2013-03-11 Thread Chen Gang
since commit d93e260 (usb: gadget: s3c-hsudc: use udc_start and udc_stop functions) the 'driver' parameter has been deleted from s3c_hsudc_stop_activity() but its documentation was left outdated. This patch deletes the comment since it makes no sense anymore. Signed-off-by: Chen Gang

[PATCH] usb: gadget: pxa25x: fix disconnect reporting

2013-03-11 Thread Felipe Balbi
when commit 6166c24 (usb: gadget: pxa25x_udc: convert to udc_start/udc_stop) converted this driver to udc_start/udc_stop, it failed to consider the fact that stop_activity() is called from disconnect interrupt. Fix the problem so that gadget drivers know about proper disconnect sequences.

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Felipe Balbi
On Mon, Mar 11, 2013 at 06:42:25PM +0800, Chen Gang wrote: if I can not find other members to help us, I will try to find another ways. code inspection works most of the time. all together: I beleive ways is always more than issues. BTW: I also add comments for your test

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Chen Gang
于 2013年03月11日 18:50, Felipe Balbi 写道: On Mon, Mar 11, 2013 at 06:42:25PM +0800, Chen Gang wrote: if I can not find other members to help us, I will try to find another ways. code inspection works most of the time. excuse me, my English is not quite well, could you describe it with

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Felipe Balbi
On Mon, Mar 11, 2013 at 07:03:02PM +0800, Chen Gang wrote: 于 2013年03月11日 18:50, Felipe Balbi 写道: On Mon, Mar 11, 2013 at 06:42:25PM +0800, Chen Gang wrote: if I can not find other members to help us, I will try to find another ways. code inspection works most of the time.

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Chen Gang F T
于 2013年03月11日 19:07, Felipe Balbi 写道: I mean just reading the code and understanding what it does. When you don't have HW to test, it's the only way to patch the driver. ok, thanks. and I still try to find another ways, at least within this week (before 2013-03-15). thanks again. --

[GIT PULL] USB patches

2013-03-11 Thread Felipe Balbi
Hi Greg, Here's my second set of fixes for this -rc cycle. Since my previous pull request didn't reach v3.9-rc2, this one is based out of the previous. Surprised to see that git gracefully found a common commit by just running: $ git request-pull greg/usb-linus usb fixes-for-v3.9-rc3

Re: [PATCH] vers/usb/gadget: beautify code, delete useless comments

2013-03-11 Thread Sergei Shtylyov
Hello. On 11-03-2013 14:14, Chen Gang wrote: since parameter driver has been deleted, also need delete relative comments. relative You probably meant related in both cases? commit number is d93e2600d80fc41ccf339b4a2843a3007d479907 Please also specify that commit's summary

Re: About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-11 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Fri, Mar 08, 2013 at 04:06:30PM +0200, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: On Fri, Mar 08, 2013 at 12:39:04PM +0200, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Hi David

RE: About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-11 Thread Chen Peter-B29397
For USB 3.0 host CV test, the host sends GET_DESCRIPTOR very quick (500us) once it accept the status of SET_ADDRESS The USB 2.0 spec says the recovery period after the status phase of SetAddress is 2ms. That should be enough to process the transfer completion interrupt, shouldn't it?

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-11 Thread Ming Lei
On Sat, Mar 9, 2013 at 12:50 AM, Alexey Khoroshilov khoroshi...@ispras.ru wrote: As it was described by Oliver Neukum in commit acbe2fe USB: Don't use GFP_KERNEL while we cannot reset a storage device: Memory allocations with GFP_KERNEL can cause IO to a storage device which can fail

RE: fsl_udc_core: set address request aren't handled like expected. usb30cv test suite fails.

2013-03-11 Thread Peter Bestler
On Fri, Mar 08, 2013 at 11:54:41AM +0200, Felipe Balbi wrote: On Fri, Mar 08, 2013 at 05:38:53PM +0800, Peter Chen wrote: On Thu, Mar 07, 2013 at 09:58:52AM +0100, Peter Bestler wrote: Hi, We try to get our device (based on p2020rdb) usb 2.0 compliant. We ran the usb30cv test

Re: [PATCH 00/12] UVC gadget patches for v3.10

2013-03-11 Thread Laurent Pinchart
Hi Bhupesh, On Monday 11 March 2013 15:07:05 Bhupesh SHARMA wrote: On Saturday, March 02, 2013 1:16 AM Laurent Pinchart wrote: Hello, Here are the miscellaneous fixes and enhacements for the UVC gadget driver that I would like to push for v3.10. All the patches have already been

Re: About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-11 Thread Alan Stern
On Mon, 11 Mar 2013, Alexander Shishkin wrote: For USB 3.0 host CV test, the host sends GET_DESCRIPTOR very quick (500us) once it accept the status of SET_ADDRESS The USB 2.0 spec says the recovery period after the status phase of SetAddress is 2ms. That should be enough to process the

Re: [PATCH] usb: Use resource_size function

2013-03-11 Thread Alan Stern
On Sun, 10 Mar 2013, Paul Vlase wrote: Signed-off-by: Paul Vlase vlase.p...@gmail.com --- drivers/usb/host/ehci-mv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index 3065809..5cd9f96 100644 ---

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-11 Thread Alan Stern
On Mon, 11 Mar 2013, Jenya Y wrote: // Update Alan, I'm happy to say that the errors disappeared. I recompiled the latest master from torvalds with USB_CONFIG=Y instead of 'm' and the errors are gone. I'm not sure it was this particular config flag + the settings you suggested earlier or

[PATCH -next] USB: misc: usb3503: use module_i2c_driver to simplify the code

2013-03-11 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Use the module_i2c_driver() macro to make the code smaller and a bit simpler. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/usb/misc/usb3503.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git

Re: REQUEST : Some help to write a new driver for LEAP motion device

2013-03-11 Thread Greg KH
On Sun, Mar 10, 2013 at 07:52:55PM +0100, LECOQ Vincent wrote: Hello Dears, I have near me 2 piece of the Leap Motion device released as developpers release kits. (http://www.leapmotion.com/) The constructor give me only drivers for Microsoft ans Apple environements, and of course closed

Re: [GIT PULL] USB patches

2013-03-11 Thread Greg KH
On Mon, Mar 11, 2013 at 01:14:36PM +0200, Felipe Balbi wrote: Hi Greg, Here's my second set of fixes for this -rc cycle. Since my previous pull request didn't reach v3.9-rc2, this one is based out of the previous. That is fine, due to my travels last week, I didn't get a chance to get stuff

[PATCH] usb/gadget: FunctionFS: Fix enable multiple instances

2013-03-11 Thread Andrzej Pietrasiewicz
This patch fixes an off-by-one bug found in 581791f5c7a480b2cc3431af9a6e799ffd51eb5e. During gfs_bind/gfs_unbind the functionfs_bind/functionfs_unbind should be called for every functionfs instance. With the i pre-decremented they were not called for the zeroth instance. Signed-off-by: Andrzej

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-11 Thread Alan Stern
On Mon, 11 Mar 2013, Ming Lei wrote: On Sat, Mar 9, 2013 at 12:50 AM, Alexey Khoroshilov khoroshi...@ispras.ru wrote: As it was described by Oliver Neukum in commit acbe2fe USB: Don't use GFP_KERNEL while we cannot reset a storage device: Memory allocations with GFP_KERNEL can cause

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-11 Thread Ming Lei
On Mon, Mar 11, 2013 at 11:32 PM, Alan Stern st...@rowland.harvard.edu wrote: Of course you have to lock the device before changing its driver. What would happen if two different threads tried to change a device's driver at the same time? Yes, claim/release interface need device lock, but

Re: [PATCH 01/13] usb: phy: nop: Add device tree support and binding information

2013-03-11 Thread Marc Kleine-Budde
On 02/05/2013 08:26 AM, Felipe Balbi wrote: Hi, On Mon, Feb 04, 2013 at 05:58:48PM +0200, Roger Quadros wrote: The PHY clock, clock rate, VCC regulator and RESET regulator can now be provided via device tree. Signed-off-by: Roger Quadros rog...@ti.com ---

Re: [PATCH 02/13] USB: phy: nop: Defer probe if device needs VCC/RESET

2013-03-11 Thread Marc Kleine-Budde
On 02/05/2013 10:43 AM, Roger Quadros wrote: On 02/05/2013 11:09 AM, Felipe Balbi wrote: On Tue, Feb 05, 2013 at 10:44:05AM +0200, Roger Quadros wrote: diff --git a/include/linux/usb/nop-usb-xceiv.h b/include/linux/usb/nop-usb-xceiv.h index 3265b61..148d351 100644 ---

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-11 Thread Alan Stern
On Mon, 11 Mar 2013, Ming Lei wrote: On Mon, Mar 11, 2013 at 11:32 PM, Alan Stern st...@rowland.harvard.edu wrote: Of course you have to lock the device before changing its driver. What would happen if two different threads tried to change a device's driver at the same time? Yes,

Re: [PATCH] usb/gadget: FunctionFS: Fix enable multiple instances

2013-03-11 Thread Michal Nazarewicz
On Mon, Mar 11 2013, Andrzej Pietrasiewicz wrote: This patch fixes an off-by-one bug found in 581791f5c7a480b2cc3431af9a6e799ffd51eb5e. During gfs_bind/gfs_unbind the functionfs_bind/functionfs_unbind should be called for every functionfs instance. With the i pre-decremented they were not

Re: [PATCH] usb: musb: log VBUS error

2013-03-11 Thread Tony Lindgren
* Grazvydas Ignotas nota...@gmail.com [130309 16:53]: VBUS_ERROR is a serious error that the driver often doesn't recover from in my tests, so we should at least inform the user about it. Patch makes sens to me, just a related question.. Do you get this when trying to enable the host mode,

RE: Problem with linux-3.7.7 (Stern - d01875f11f05f76fc471cec94d701201c1b34389)

2013-03-11 Thread Alan Stern
On Mon, 11 Mar 2013, Adrian Bassett wrote: You know, the 6e0c3339a6 commit consists of two hunks, and they are pretty much independent of one another. You could try reverting each of the hunks separately to narrow things down. Maybe only one of them is responsible for your problem.

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-11 Thread Ming Lei
On Tue, Mar 12, 2013 at 12:08 AM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 11 Mar 2013, Ming Lei wrote: On Mon, Mar 11, 2013 at 11:32 PM, Alan Stern st...@rowland.harvard.edu wrote: Of course you have to lock the device before changing its driver. What would happen if two

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-11 Thread Stephen Warren
On 03/11/2013 12:59 AM, Felipe Balbi wrote: Hi, On Fri, Mar 08, 2013 at 10:26:45AM -0700, Stephen Warren wrote: On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that

Re: [PATCH] usb: musb: log VBUS error

2013-03-11 Thread Grazvydas Ignotas
On Mon, Mar 11, 2013 at 6:24 PM, Tony Lindgren t...@atomide.com wrote: * Grazvydas Ignotas nota...@gmail.com [130309 16:53]: VBUS_ERROR is a serious error that the driver often doesn't recover from in my tests, so we should at least inform the user about it. Patch makes sens to me, just a

Re: [PATCH] usb: musb: log VBUS error

2013-03-11 Thread Tony Lindgren
* Grazvydas Ignotas nota...@gmail.com [130311 10:12]: On Mon, Mar 11, 2013 at 6:24 PM, Tony Lindgren t...@atomide.com wrote: * Grazvydas Ignotas nota...@gmail.com [130309 16:53]: VBUS_ERROR is a serious error that the driver often doesn't recover from in my tests, so we should at least

RE: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-03-11 Thread Cortes, Alexis
Hi Sarah, Sorry for my delayed response, I was investigating this. By 'Inactive' state you mean the Compliance mode? since SS.Inactive and Compliance are not the same. When in D3hot or D3cold, the host must be able to transmit a PME whenever a device is plugged into the DS port. If a SS

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-03-11 Thread Greg Kroah-Hartman
On Fri, Feb 15, 2013 at 12:30:11PM +0100, Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: We have to let user space recover. To do so we need to indicate when exactly we dropped

Re: [GIT PULL] USB patches

2013-03-11 Thread Felipe Balbi
Hi, On Mon, Mar 11, 2013 at 08:29:00AM -0700, Greg KH wrote: On Mon, Mar 11, 2013 at 01:14:36PM +0200, Felipe Balbi wrote: Hi Greg, Here's my second set of fixes for this -rc cycle. Since my previous pull request didn't reach v3.9-rc2, this one is based out of the previous. That is

[PATCH] usb: musb: core: fix possible build error with randconfig

2013-03-11 Thread Felipe Balbi
when making commit e574d57 (usb: musb: fix compile warning) I forgot to git add this part of the patch which ended up introducing a possible build error. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/musb/musb_core.c | 4 1 file changed, 4 deletions(-) diff --git

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-11 Thread Felipe Balbi
Hi, On Mon, Mar 11, 2013 at 11:05:15AM -0600, Stephen Warren wrote: On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that we have sensible names for all phy

Re: [GIT PULL] USB patches

2013-03-11 Thread Greg KH
On Mon, Mar 11, 2013 at 08:00:29PM +0200, Felipe Balbi wrote: Hi, On Mon, Mar 11, 2013 at 08:29:00AM -0700, Greg KH wrote: On Mon, Mar 11, 2013 at 01:14:36PM +0200, Felipe Balbi wrote: Hi Greg, Here's my second set of fixes for this -rc cycle. Since my previous pull request

Re: PROBLEM: USB device registered on OHCI instead of EHCI at boot

2013-03-11 Thread Bruce Guenter
On Fri, Mar 08, 2013 at 09:35:50PM -0500, Alan Stern wrote: The dmesg log shows the card reader attached to the EHCI controller at timestamp 2.569228 (which should be the boot-time detection) -- not to the OHCI controller. And it doesn't show any devices on bus 5. Why not? I have no idea.

Re: PROBLEM: USB device registered on OHCI instead of EHCI at boot

2013-03-11 Thread Alan Stern
On Mon, 11 Mar 2013, Bruce Guenter wrote: On Fri, Mar 08, 2013 at 09:35:50PM -0500, Alan Stern wrote: The dmesg log shows the card reader attached to the EHCI controller at timestamp 2.569228 (which should be the boot-time detection) -- not to the OHCI controller. And it doesn't show any

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-11 Thread Felipe Balbi
Hi, On Mon, Mar 11, 2013 at 11:02:43AM -0600, Stephen Warren wrote: On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that we have sensible names for all phy

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-11 Thread Alan Stern
On Tue, 12 Mar 2013, Ming Lei wrote: In general it isn't, no. But usbfs uses the lock to prevent races with driver_disconnect() -- it is invalid to submit URBs after the disconnect routine has returned. If so, we may introduce another lock to avoid the race. So I think we may figure

[PATCH] usb: chipidea: core: switch over to devm_ioremap_resource

2013-03-11 Thread Felipe Balbi
switch over to the newly added devm_ioremap_resource which provides more consistent error messages. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/chipidea/core.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipidea/core.c

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-11 Thread Stephen Warren
On 03/11/2013 12:49 PM, Felipe Balbi wrote: Hi, On Mon, Mar 11, 2013 at 11:02:43AM -0600, Stephen Warren wrote: On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that

[PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

2013-03-11 Thread Paul Bolle
The Kconfig option MACH_OMAP_H4_OTG was already considered dead as of v2.6.36, as can be seen in commit 267ecec95f7d215d2da38252640b06198515acc3 (Removing dead MACH_OMAP_H4_OTG). Remove its last trace now. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Tested with make ARCH=arm menuconfig

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-11 Thread Felipe Balbi
Hi, On Mon, Mar 11, 2013 at 01:54:54PM -0600, Stephen Warren wrote: On Mon, Mar 11, 2013 at 11:02:43AM -0600, Stephen Warren wrote: On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote:

Re: RFC: [PATCH 1/3] usb: cdc_ncm: patch for VMware

2013-03-11 Thread Ben Hutchings
On Sun, 2013-03-10 at 22:12 +0100, Loic Domaigne wrote: On Fri, Mar 08, 2013 at 04:28:59PM -0600, Dan Williams wrote: On Fri, 2013-03-08 at 22:03 +0100, Loic Domaigne wrote: +/* maximum Rx URB size */ +/* + * in the original Linux driver, the rx urb size can be up to + *

Re: REQUEST : Some help to write a new driver for LEAP motion device

2013-03-11 Thread LECOQ Vincent
On 03/11/2013 04:24 PM, Greg KH wrote: On Sun, Mar 10, 2013 at 07:52:55PM +0100, LECOQ Vincent wrote: Hello Dears, I have near me 2 piece of the Leap Motion device released as developpers release kits. (http://www.leapmotion.com/) The constructor give me only drivers for Microsoft ans Apple

Re: REQUEST : Some help to write a new driver for LEAP motion device

2013-03-11 Thread Greg KH
On Mon, Mar 11, 2013 at 09:41:47PM +0100, LECOQ Vincent wrote: On 03/11/2013 04:24 PM, Greg KH wrote: On Sun, Mar 10, 2013 at 07:52:55PM +0100, LECOQ Vincent wrote: Hello Dears, I have near me 2 piece of the Leap Motion device released as developpers release kits.

[RFC] USB: cdc-wdm: implement IOCTL_WDM_MAX_COMMAND

2013-03-11 Thread Bjørn Mork
Userspace applications need to know the maximum supported message size. Using a character device as interface to USB control messages hides the fact that these messages have a strict size limit. The userspace application must in most cases still be aware of this limit. It must allocate

Re: [RFC] USB: cdc-wdm: implement IOCTL_WDM_MAX_COMMAND

2013-03-11 Thread Greg KH
On Mon, Mar 11, 2013 at 10:00:21PM +0100, Bjørn Mork wrote: Userspace applications need to know the maximum supported message size. Can't they get that from sysfs from the USB field that defines this? Adding a new ioctl is usually not a good idea, who is going to change the userspace tools to

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-03-11 Thread Bjørn Mork
Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Fri, Feb 15, 2013 at 12:30:11PM +0100, Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: We have to let user space recover. To

Re: [RFC] USB: cdc-wdm: implement IOCTL_WDM_MAX_COMMAND

2013-03-11 Thread Bjørn Mork
Greg KH gre...@linuxfoundation.org writes: On Mon, Mar 11, 2013 at 10:00:21PM +0100, Bjørn Mork wrote: Userspace applications need to know the maximum supported message size. Can't they get that from sysfs from the USB field that defines this? Not at the moment since we don't export it.

Re: [RFC] USB: cdc-wdm: implement IOCTL_WDM_MAX_COMMAND

2013-03-11 Thread Greg KH
On Mon, Mar 11, 2013 at 10:28:21PM +0100, Bjørn Mork wrote: Greg KH gre...@linuxfoundation.org writes: On Mon, Mar 11, 2013 at 10:00:21PM +0100, Bjørn Mork wrote: Userspace applications need to know the maximum supported message size. Can't they get that from sysfs from the USB field

Re: Flood of xhci warnings with 3.9.0-rc1

2013-03-11 Thread Sarah Sharp
On Sun, Mar 10, 2013 at 12:04:40PM -0700, Stephen Hemminger wrote: My test kernel is screaming with xHCI messages into kernel log. [ 76.117016] xhci_hcd :00:14.0: WARN Event TRB for slot 1 ep 0 with no TDs queued? This is using kernel based on net-next which is based on 3.9.0-rc1.

Re: Isochronous transfer error on USB3

2013-03-11 Thread Sarah Sharp
On Mon, Mar 11, 2013 at 01:21:48PM +0100, jean-philippe francois wrote: Hi, The company I work for is doing USB cameras, for which I wrote the drivers (out of tree). Kernel driver or userspace driver? Raw camera data are transferred using isochronous transfer, which work fine when used on

Re: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-03-11 Thread Sarah Sharp
On Mon, Mar 11, 2013 at 05:33:26PM +, Cortes, Alexis wrote: Hi Sarah, Sorry for my delayed response, I was investigating this. By 'Inactive' state you mean the Compliance mode? since SS.Inactive and Compliance are not the same. Yes, I mean Compliance mode. When in D3hot or D3cold,

Re: Flood of xhci warnings with 3.9.0-rc1

2013-03-11 Thread Stephen Hemminger
On Mon, 11 Mar 2013 14:48:01 -0700 Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Sun, Mar 10, 2013 at 12:04:40PM -0700, Stephen Hemminger wrote: My test kernel is screaming with xHCI messages into kernel log. [ 76.117016] xhci_hcd :00:14.0: WARN Event TRB for slot 1 ep 0 with

Re: [PATCH] vers/usb/gadget: beautify code, delete useless comments

2013-03-11 Thread Chen Gang
Felipe Balbi also pointed my subject and comments issue. and I have sent the related new patch for it. the new patch subject is [PATCH] usb: gadget: s3c-hsudc: delete outdated comment please help checking the new patch, thanks. :-) 于 2013年03月11日 19:28, Sergei Shtylyov 写道: Hello.

[PATCH v7 0/6] staging: DWC2 DesignWare USB HS OTG driver

2013-03-11 Thread Paul Zimmerman
Hi Greg, Here is the latest version of the DWC2 patch set. This version includes changes suggested by Felipe in his review of the HCD code. Only patch #2 has had any substantial changes since last time. I have also moved the driver to the staging tree, since it doesn't look like it's ready for

[PATCH v7 3/6] staging: HCD descriptor DMA support for the DWC2 driver

2013-03-11 Thread Paul Zimmerman
This file contains code to support the HCD descriptor DMA mode of the controller Signed-off-by: Paul Zimmerman pa...@synopsys.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/staging/dwc2/hcd_ddma.c | 1196 +++ 1 file changed, 1196 insertions(+) create

[PATCH v7 4/6] staging: PCI bus interface for the DWC2 driver

2013-03-11 Thread Paul Zimmerman
This file contains the PCI bus interface glue for the DWC2 driver Signed-off-by: Paul Zimmerman pa...@synopsys.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/staging/dwc2/pci.c | 198 + 1 file changed, 198 insertions(+) create mode 100644

[PATCH v7 5/6] staging: Hook the DWC2 driver into the build system

2013-03-11 Thread Paul Zimmerman
Add the DWC2 Kconfig and Makefile, and modify the USB Kconfig and Makefile to include them Signed-off-by: Paul Zimmerman pa...@synopsys.com --- drivers/staging/Kconfig | 2 ++ drivers/staging/Makefile | 1 + drivers/staging/dwc2/Kconfig | 41

[PATCH v7 6/6] staging: Add a MAINTAINERS entry for the DWC2 driver

2013-03-11 Thread Paul Zimmerman
Add myself as maintainer of the DWC2 driver Signed-off-by: Paul Zimmerman pa...@synopsys.com --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e95b1e9..6672165 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2470,6 +2470,12 @@ M:

Re: fsl_udc_core: set address request aren't handled like expected. usb30cv test suite fails.

2013-03-11 Thread Peter Chen
Hi, I tested your patch, Peter and it works fine. All tests of the usbcv30 are passing with my setup. Thank you so far. So you get a tested-by: peter.best...@omicron.at In my opinion we do it in the wrong order; we set the address before the status stage completes. But isn't the

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-11 Thread Jenya Y
On 03/11/2013 04:06 PM, Alan Stern wrote: On Mon, 11 Mar 2013, Jenya Y wrote: // Update Alan, I'm happy to say that the errors disappeared. I recompiled the latest master from torvalds with USB_CONFIG=Y instead of 'm' and the errors are gone. I'm not sure it was this particular config flag +

Re: Flood of xhci warnings with 3.9.0-rc1

2013-03-11 Thread Stephen Hemminger
On Mon, 11 Mar 2013 17:55:42 -0700 Sarah Sharp sarah.a.sh...@linux.intel.com wrote: Well, let's find out. Can you please run the following command as root? for f in /sys/bus/usb/devices/*; do if [ -e $f/power/control ]; then echo Filename: $f; cat $f/power/control; fi done All are marked

Re: Flood of xhci warnings with 3.9.0-rc1

2013-03-11 Thread Stephen Hemminger
On Mon, 11 Mar 2013 17:55:42 -0700 Sarah Sharp sarah.a.sh...@linux.intel.com wrote: All right. You've got a Intel Panther Point xHCI host then. Did you notice these messages on older kernels, or just with the 3.9-rc1 kernel? It seems to be new in 3.9, haven't bisected it down. -- To

Re: Fwd: a usb regression in kernel 2.6.37 and upper

2013-03-11 Thread Alan Stern
On Mon, 11 Mar 2013, Sarah Sharp wrote: On Mon, Mar 11, 2013 at 02:50:57PM +0800, Joshua wrote: ... Recently, I read the EHCI 1.1 addendum specification. I noticed there are some implementations in kernel for that spec by intel engineers, but i didn't find the Hardware Prefetching

Re: About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-11 Thread Peter Chen
On Mon, Mar 11, 2013 at 10:58:05AM -0400, Alan Stern wrote: On Mon, 11 Mar 2013, Alexander Shishkin wrote: For USB 3.0 host CV test, the host sends GET_DESCRIPTOR very quick (500us) once it accept the status of SET_ADDRESS The USB 2.0 spec says the recovery period after the

[PATCH 15/18] driver: usb: storage: remove cast for kmalloc return value

2013-03-11 Thread Zhang Yanfei
remove cast for kmalloc return value. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Cc: Matthew Dharm mdharm-...@one-eyed-alien.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Andrew Morton a...@linux-foundation.org Cc: linux-usb@vger.kernel.org Cc: