[PATCHv4] mac80211: fix A-MSDU outer SA/DA

According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS values. Signed-off-by: Michael Braun -- v4: - h_80211_src/dst has been memmove'd and thus needs to be fixed v3: - write to outer

Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

Steve deRosier writes: > Sorry to quibble, but the subsystem label on the commit subject line > should be "ath6kl:" it's a lower-case "L", not a one. Heh, I missed that :) I can fix it before I commit. >> --- a/drivers/net/wireless/ath/ath6kl/sdio.c >> +++

Re: TCP data throughput for BCM43362

On Thu, 2016-10-13 at 00:25 +0200, Arend Van Spriel wrote: > Op 12 okt. 2016 23:19 schreef "Jörg Krause" cks>: > > > > On Wed, 2016-10-12 at 23:08 +0200, Arend Van Spriel wrote: > > > Op 12 okt. 2016 21:30 schreef "Jörg Krause" > > d.ro > > >

Re: TCP data throughput for BCM43362

On Wed, 2016-10-12 at 23:08 +0200, Arend Van Spriel wrote: > Op 12 okt. 2016 21:30 schreef "Jörg Krause" cks>: > > > > On Mi, 2016-10-12 at 21:08 +0200, Arend van Spriel wrote: > > > > [snip] > > > > > On 12-10-16 16:27, Jörg Krause wrote: > > > > > > > > It is

Re: TCP data throughput for BCM43362

On Wed, 2016-10-12 at 21:08 +0200, Arend van Spriel wrote: [snip] > > You referred to 20 Mbps claim on wiced dev kit page at mouser so I > assumed you were using that and it includes firmware. As you > confirmed > using firmware from linux-firmware repo this question does not > matter. Note,

Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

Hi Alan, Sorry to quibble, but the subsystem label on the commit subject line should be "ath6kl:" it's a lower-case "L", not a one. On Wed, Oct 12, 2016 at 11:08 AM, Alan wrote: > From: Adam Williamson > > SDIO ID 0271:0418 > > Signed-off-by:

Re: TCP data throughput for BCM43362

On Mi, 2016-10-12 at 21:08 +0200, Arend van Spriel wrote: [snip] > On 12-10-16 16:27, Jörg Krause wrote: > > > > It is running the iperf server. It is running in station mode as > > well > > as in AP mode, depending on the use case. The wireshark dump was > > taken > > when the bcm43362 is

Re: TCP data throughput for BCM43362

On 12-10-16 16:27, Jörg Krause wrote: > On Mi, 2016-10-12 at 10:11 +0200, Arend Van Spriel wrote: >> On 11-10-2016 8:14, Jörg Krause wrote: >>> >>> >>> >>> Hi Arend, >>> >>> Am 22. September 2016 16:00:36 MESZ, schrieb Arend Van Spriel >> d.vanspr...@broadcom.com>: Op 22 sep. 2016 14:52

[PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

From: Adam Williamson SDIO ID 0271:0418 Signed-off-by: Alan Cox Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921 diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c index eab0ab9..76eb336

[PATCH V2] rtlwifi: Fix regression caused by commit d86e64768859

In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), the configuration struct for most of the drivers was changed to be constant. The problem is that five of the modified drivers need to be able to update the firmware name based on the exact model of the card. As the file names

Re: [PATCH] rtlwifi: Fix regression caused by commit d86e64768859

On 10/12/2016 11:54 AM, Kalle Valo wrote: Larry Finger writes: In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), the configuration struct for most of the drivers was changed to be constant. The problem is that five of the modified drivers need

Re: bcmdhd: Strange Power Save messages

On 12-10-16 16:26, Gucea Doru wrote: > On Tue, Oct 11, 2016 at 10:12 PM, Arend van Spriel > wrote: >> On 07-10-16 16:33, Gucea Doru wrote: >>> On Thu, Oct 6, 2016 at 10:25 AM, Arend Van Spriel >>> wrote: On 6-10-2016 10:07, Gucea

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Wed, Oct 12, 2016 at 1:05 PM, Paul Bolle wrote: > On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: >> This may already be apparent, but Dell sells two versions of the 9350: >> one with the Broadcom adapter and one with the AC 8260. > > Off topic, for most readers: my

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: > This may already be apparent, but Dell sells two versions of the 9350: > one with the Broadcom adapter and one with the AC 8260. Off topic, for most readers: my version (with the AC 8260) came with Ubuntu preinstalled. Perhaps Chris'

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

Hi Luca, FYI, It seems that Google does not like your email as I'm not receiving any of your messages in gmail. Some responses below: On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > Hi Chris, > On Tue, 2016-10-11 at 09:09 -0500, Chris Rorvick wrote: > > On Tue, Oct 11, 2016 at 5:11 AM,

Re: [PATCH] docs-rst: sphinxify 802.11 documentation

On Wed, 12 Oct 2016 00:08:30 +0200 Johannes Berg wrote: > > As an alternative, one or the other of us could just send it up in > > the next couple of days and be done with it.  I'd say the chances of > > regressions are pretty small...:)  If you want to do that, feel

Re: [PATCH] rtlwifi: Fix regression caused by commit d86e64768859

Larry Finger writes: > In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), > the configuration struct for most of the drivers was changed to be > constant. The problem is that five of the modified drivers need to be > able to update the firmware

Re: [PATCH v2] mac80211: fix A-MSDU outer SA/DA

Am 12.10.2016 14:25, schrieb Johannes Berg: So, I actually think my first instinct that you were erroneously changing the inner header *was* right. You're right. Seems like this code should be inserted towards the end of ieee80211_amsdu_aggregate() instead, where it's adding the RFC 1042

Re: TCP data throughput for BCM43362

On Mi, 2016-10-12 at 10:11 +0200, Arend Van Spriel wrote: > On 11-10-2016 8:14, Jörg Krause wrote: > > > > > > > > Hi Arend, > > > > Am 22. September 2016 16:00:36 MESZ, schrieb Arend Van Spriel > d.vanspr...@broadcom.com>: > > > > > > Op 22 sep. 2016 14:52 schreef "Jörg Krause" > > >

Re: [bug report] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue

Dan Carpenter writes: > Hello Toke Høiland-Jørgensen, > > This is a semi-automatic email about new static checker warnings. > > The patch bb42f2d13ffc: "mac80211: Move reorder-sensitive TX handlers > to after TXQ dequeue" from Sep 22, 2016, leads to the following >

Re: [PATCH] rsi: update in vap_capabilities frame to device

Kalle Valo writes: > Prameela Rani Garnepudi writes: > >> added vap status(add/delete) field in vap capabilities frame to device >> added sending vap capabilites frame(with vap status 'delete') in remove >> interface >> >> Signed-off-by: Prameela

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

> > Can you elaborate on how exactly it kills your system? > > the last time I saw it it was a NULL deref at > ieee80211_aes_ccm_decrypt. Hm. I was expecting something within the crypto code would cause the crash, this seems strange. Anyway, I'm surely out of my depth wrt. the actual cause.

Re: [PATCH] rsi: update in vap_capabilities frame to device

Prameela Rani Garnepudi writes: > added vap status(add/delete) field in vap capabilities frame to device > added sending vap capabilites frame(with vap status 'delete') in remove > interface > > Signed-off-by: Prameela Rani Garnepudi Why?

Re: bcmdhd: Strange Power Save messages

On Tue, Oct 11, 2016 at 10:12 PM, Arend van Spriel wrote: > On 07-10-16 16:33, Gucea Doru wrote: >> On Thu, Oct 6, 2016 at 10:25 AM, Arend Van Spriel >> wrote: >>> On 6-10-2016 10:07, Gucea Doru wrote: On Wed, Oct 5, 2016 at 11:12

Re: [PATCH] rsi: fix memory leak in module unload

Prameela Rani Garnepudi writes: > debugfs entry removal statement moved inside CONFIG_RSI_DEBUGSFS flag > added freeing of below structures > * channel list for each supported band > * rsi debugfs info > > Signed-off-by: Prameela Rani Garnepudi

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

Hello, On 12/10/2016 15:34:46 CEST, Kalle Valo wrote: "Vittorio Gambaletta (VittGam)" writes: Hello, On 04/10/2016 17:46:44 CEST, Kalle Valo wrote: "Vittorio Gambaletta (VittGam)" writes: If generic entries are positioned above

Re: [PATCH] rsi: fix memory lean in module unload

Prameela Rani Garnepudi writes: > Moved debugfs entry removal under CONFIG_RSI_DEBUGFS flag > Added freeing of below structures > * channels list in each supported band > * rsi debugfs info > > Signed-off-by: Prameela Rani Garnepudi There

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

Hello, On (10/12/16 11:05), Johannes Berg wrote: > Sorry - I meant to look into this yesterday but forgot. > > > Andy, can this be related to CONFIG_VMAP_STACK? > > I think it is. yeah, the system works fine with !CONFIG_VMAP_STACK. > > > current -git kills my system. > > Can you elaborate

Re: QCA9887 Firmware Memory Usage

Am 12.10.2016 um 15:51 schrieb Valo, Kalle: David Hutchison writes: I am using a Mikrotik hAP AC Lite which has a QCA9887 radio. It appears to be working; however ath10k ( or the qca9887 firmware ) is utilizing 15 - 20mb of memory. I applied the kfree(caldata) patch,

Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

Yeoh Chun-Yeow writes: >> My understanding is that 10.2 branch does not have this feature, >> unfortunately. >> > > Alright, noted. > > Is QCA988X going to have firmware 10.4 support? I wish it would have but I don't know the current status. -- Kalle Valo

Re: QCA9887 Firmware Memory Usage

David Hutchison writes: > I am using a Mikrotik hAP AC Lite which has a QCA9887 radio. It > appears to be working; however ath10k ( or the qca9887 firmware ) is > utilizing 15 - 20mb of memory. I applied the kfree(caldata) patch, to > insure there is no memory leak. > >

Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

> > My understanding is that 10.2 branch does not have this feature, > unfortunately. > Alright, noted. Is QCA988X going to have firmware 10.4 support? --- Chun-Yeow

[PATCH v3 1/2] ath10k: clean up HTT tx buffer allocation and free

From: Mohammed Shafi Shajakhan cleanup 'ath10k_htt_tx_alloc' by introducing the API's 'ath10k_htt_tx_alloc/free_{cont_txbuf, txdone_fifo} and re-use them whereever needed Signed-off-by: Mohammed Shafi Shajakhan ---

[PATCH v3 2/2] ath10k: Remove extraneous error message in tx alloc

From: Mohammed Shafi Shajakhan Remove extraneous error message in 'ath10k_htt_tx_alloc_cont_frag_desc' as the caller 'ath10k_htt_tx_alloc' already dumps a proper error message Signed-off-by: Mohammed Shafi Shajakhan ---

Re: [PATCH v2 0/7] ath9k: EEPROM swapping improvements

Martin Blumenstingl writes: > There are two types of swapping the EEPROM data in the ath9k driver. > Before this series one type of swapping could not be used without the > other. > > The first type of swapping looks at the "magic bytes" at the start of > the

Re: [v2] rt2x00: add support for mac addr from device tree

Kalle Valo writes: >> I thought about _adding_ a devicetree binding document before sending >> the patch. But in the end it would be an empty file, since I neither >> add any bindings nor introduce a compatible string. I'm just add >> support for the generic

[PATCH v2] cfg80211: Check radar_detect and num_different_channels with beacon interface combinations.

This commit enhances the current beacon interval validation to also consider the "radar_detect" and "num_different_channels". Rename "cfg80211_validate_beacon_int" to "cfg80211_validate_beacon_combination" as the validation considers other parameters. Signed-off-by: Purushottam Kushwaha

[PATCH v2] cfg80211: Create structure for combination check/iter function parameters

Move growing parameter list to a structure for check/iter combination functions in cfg80211 and mac80211. Signed-off-by: Purushottam Kushwaha --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 26 ++- include/net/cfg80211.h |

[PATCH v10] cfg80211: Provision to allow the support for different beacon intervals

This commit provides a mechanism for the host drivers to advertise the support for different beacon intervals among the respective interface combinations in a group, through beacon_int_min_gcd (u32). This beacon_int_min_gcd will be compared against GCD of all beaconing interfaces of matching

Re: [PATCH] mac80211: fix sequence number allocation regression

On Wed, Oct 12, 2016 at 08:49:45AM +0200, Johannes Berg wrote: > On Tue, 2016-10-11 at 11:28 +0200, Felix Fietkau wrote: > > The recent commit that moved around TX handlers dropped the sequence > > number allocation at the end of ieee80211_tx_dequeue and calls > > ieee80211_tx_h_sequence instead

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > Okay... Actually this is a structure in the BIOS and the actual method > we call is SPLC.  The SPLC method may return one item from this table, > or something entirely different, possible one of the three values > depending on a configuration

Re: [PATCH v2] mac80211: fix A-MSDU outer SA/DA

On Wed, 2016-10-12 at 12:57 +0200, Michael Braun wrote: > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS > values. actually ... >   struct ieee80211_hdr *hdr; 802.11 header > - struct ethhdr

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Tue, 2016-10-11 at 23:32 -0500, Chris Rorvick wrote: > On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: > > For what it's worth, on my machine I have twenty (!) SPLX entries, all > > reading: > > Name (SPLX, Package (0x04) > > { > > Zero, > >

[PATCH] mac80211: preserve more bits when building QoS header

From: Johannes Berg Michael Braun reported that when trying to inject A-MSDUs over monitor interfaces, the frame doesn't come out right since the QoS header A-MSDU bit is overwritten. Rather than adding that bit specifically simply preserve those bits that we don't set

USB WiFi driver for AP mode

Hi, we are looking for well supported USB WiFi chips/modules with the following requirements * Be able to support AP mode * Support at least 20 concurrent clients (stations) * Support multiple SSIDs * (preferred, optional: Support 2x2 802.11gn) We did a survey through the various wiki

Re: [PATCH v6 2/4] mac80211: filter multicast data packets on AP / AP_VLAN

On Mon, 2016-10-10 at 19:12 +0200, Michael Braun wrote: > This patch adds filtering for multicast data packets on AP_VLAN > interfaces >  [...] Applied patches 1 and 2 for now, I'll look at the others again later. johannes

[PATCH v2] mac80211: fix A-MSDU outer SA/DA

According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS values. Signed-off-by: Michael Braun -- v2: - avoid the extra write to amsdu_hdr - avoid copy of asmdu_hdr into skb, use ptr instead

Re: [PATCH v2] mac80211: enable to inject a-msdu frames using monitor interface

Am 12.10.2016 09:33, schrieb Johannes Berg: However, re-reading *p looks strange to me. Why don't we just refactor this to preserve everything but the TID and ACK policy, after all, we have just previous created this all zeroed in most cases, so it won't really matter. Looks good to me. I've

Re: [PATCH] cfg80211: Create structure for combination check/iter function parameters

On Mon, 2016-10-10 at 17:36 +0530, Purushottam Kushwaha wrote: > Move growing parameter list to a structure for check/iter combination > functions in cfg80211 and mac80211. Looking at this, and how it changes brcmfmac, I'd prefer you did this as the first patch in the series so we only have to

Re: [PATCH v2] mac80211: enable to inject a-msdu frames using monitor interface

On Mon, 2016-10-10 at 18:48 +0200, Michael Braun wrote: > Problem: When injecting an A-MSDU using a PF_PACKET socket, the qos > flag > IEEE80211_QOS_CTL_A_MSDU_PRESENT is cleared. > > How to reproduce: Inject a frame on a mac80211 hwsim monitor > interface and > have tshark sniffing on this

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

Hi, Sorry - I meant to look into this yesterday but forgot. > Andy, can this be related to CONFIG_VMAP_STACK? I think it is. > > current -git kills my system. Can you elaborate on how exactly it kills your system? > > adding > > > > if (!virt_addr_valid([2])) { > >

[bug report] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue

Hello Toke Høiland-Jørgensen, This is a semi-automatic email about new static checker warnings. The patch bb42f2d13ffc: "mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue" from Sep 22, 2016, leads to the following Smatch complaint: net/mac80211/tx.c:3242

Re: [PATCH] mac80211: fix A-MSDU outer SA/DA

On Mon, 2016-10-10 at 18:52 +0200, Michael Braun wrote: > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS > values. "Need to" is perhaps a bit strongly worded, but whatever :) I was going to write a long reply

Re: TCP data throughput for BCM43362

On 11-10-2016 8:14, Jörg Krause wrote: > > > Hi Arend, > > Am 22. September 2016 16:00:36 MESZ, schrieb Arend Van Spriel > : >> Op 22 sep. 2016 14:52 schreef "Jörg Krause" >> : >>> >>> On Do, 2016-09-22 at 10:09 +0200, Arend Van Spriel

Re: Revert "rtlwifi: rtl818x: constify local structures"

Larry Finger wrote: > This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. > > For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and rtl8821ae, > the Coccinelle script missed the fact that the code changes the firmware > name. When that happens, the

Re: [PATCH] mac80211: fix A-MSDU outer SA/DA

On Wed, 2016-10-12 at 09:53 +0200, Johannes Berg wrote: > On Mon, 2016-10-10 at 18:52 +0200, Michael Braun wrote: > > > > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer > > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS > > values. > > "Need to" is perhaps

Re: [PATCHv3 2/3] mac80211: check A-MSDU inner frame source address on AP interfaces

On Mon, 2016-10-03 at 13:14 +0200, Michael Braun wrote: > When using WPA security, the station and thus the required key is > identified by its mac address when packets are received. So a > station usually cannot spoof its source mac address. > > But when a station sends an A-MSDU frame, port

Re: [v2,1/2] ath10k: clean up HTT tx buffer allocation and free

Mohammed Shafi Shajakhan writes: > Hi Kalle, > > On Tue, Oct 11, 2016 at 01:36:22PM +0200, Kalle Valo wrote: >> Mohammed Shafi Shajakhan wrote: >> > From: Mohammed Shafi Shajakhan >> > >> > cleanup

[PATCH] ath10k: Fix failure to send NULL func frame for 10.4

From: Mohammed Shafi Shajakhan This partially reverts 'commit 2cdce425aa33 ("ath10k: Fix broken NULL func data frame status for 10.4")' Unfortunately this breaks sending NULL func and the existing issue of obtaining proper tx status for NULL function will be fixed.

Re: [PATCHv2 1/3] mac80211: fix CMD_FRAME for AP_VLAN

On Mon, 2016-10-03 at 13:14 +0200, Michael Braun wrote: > When using IEEE 802.11r FT OVER-DS roaming with AP_VLAN, hostapd > needs to > send out a frame using CMD_FRAME for a station assigned to an AP_VLAN > interface. > > Right now, the userspace needs to give the exact AP_VLAN interface > index

Re: [v2,1/2] ath10k: clean up HTT tx buffer allocation and free

Hi Kalle, On Tue, Oct 11, 2016 at 01:36:22PM +0200, Kalle Valo wrote: > Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > cleanup 'ath10k_htt_tx_alloc' by introducing the API's > >

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

Luca, On Wed, 2016-10-12 at 09:11 +0300, Luca Coelho wrote: > By "platform" I meant the PC you are using.  The ACPI table is created > by the OEM, so different PCs have different tables. Like Chris I use a Dell XPS 13 (9350), but mine came with an AC 8260 out of it's assembly plant:     Detected

Re: [PATCH] mac80211: fix sequence number allocation regression

On Tue, 2016-10-11 at 11:28 +0200, Felix Fietkau wrote: > The recent commit that moved around TX handlers dropped the sequence > number allocation at the end of ieee80211_tx_dequeue and calls > ieee80211_tx_h_sequence instead (for the non-fast-xmit case). > However, it did not change the fast-xmit

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

Hi Paul, On Tue, 2016-10-11 at 12:11 +0200, Paul Bolle wrote: > On Mon, 2016-10-10 at 17:02 +0300, Luca Coelho wrote: > > On Mon, 2016-10-10 at 02:19 -0500, Chris Rorvick wrote: > > This is not coming from the NIC itself, but from the platform's ACPI > > tables.  Can you tell us which platform you