[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb created this revision. hhb added a project: LLDB. hhb planned changes to this revision. This is the last part. And we can remove the python script. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

davide added a comment. What are you trying to accomplish here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69016/new/ https://reviews.llvm.org/D69016 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Move the copy of six.py, lldb.py and macosx/heap Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69016 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D68962: update ScriptInterpreterPython to use File, not FILE*

This revision was automatically updated to reflect the committed changes. Closed by commit rGb07823f3e2da: update ScriptInterpreterPython to use File, not FILE* (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68962/new/

[Lldb-commits] [lldb] r374964 - update ScriptInterpreterPython to use File, not FILE*

Author: lawrence_danna Date: Tue Oct 15 18:58:15 2019 New Revision: 374964 URL: http://llvm.org/viewvc/llvm-project?rev=374964=rev Log: update ScriptInterpreterPython to use File, not FILE* Summary: ScriptInterpreterPython needs to save and restore sys.stdout and friends when LLDB runs a python

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, clayborg, labath, jingham. Herald added a project: LLDB. lawrence_danna added a parent revision: D68995: clean up the implementation of PythonCallable::GetNumArguments. When users define a debugger command from

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

teemperor added a comment. Oh, I wasn't aware we already had that in the allocator. I looked at the source and it seems that we need to first create about 1024 slabs before we reach the 1MiB limit, which means we need 256 * 1024 = 262144 slabs in LLDB due to the 256 different string pools.

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna updated this revision to Diff 225142. lawrence_danna added a comment. python 2 fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 Files:

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

joerg added a comment. I'm a bit puzzled by the need for this change. The bump allocator already has logic to do power-of-two scaling for the allocation, so I wonder why it doesn't work properly here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

teemperor added subscribers: xiaobai, teemperor. teemperor added a comment. This patch actually made the RSS memory in our benchmarks go up by quite a bit (see lldb-bench ). The reason is that while we only create 1MiB chunks in the new allocator,

[Lldb-commits] [PATCH] D69008: Add arm64_32 support

jasonmolenda created this revision. Herald added subscribers: JDevlieghere, abidh, arphaman, kristof.beyls. Herald added a project: LLDB. This patchset adds support for an AArch64 aka arm64 ABI used on Apple's WatchOS -- it's an ILP32 ABI that runs on the arm64 ISA, e.g. the entire process runs

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG208e9c01fc09: [lldb] Creates _liblldb symlink from cmake (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D68858?vs=224955=225123#toc Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] r374953 - [lldb] Creates _liblldb symlink from cmake

Author: hhb Date: Tue Oct 15 14:58:45 2019 New Revision: 374953 URL: http://llvm.org/viewvc/llvm-project?rev=374953=rev Log: [lldb] Creates _liblldb symlink from cmake Summary: This is another attempt of D67993. This change removed hard coded relative paths. This way we can generate correct

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb added a comment. One additional statement in openSUSE comparing to standard python: libdir = plat_specific and get_config_var("platlibdir") or "lib" Hmmm basically what does platform dependent mean... Anyway this change looks good to me. Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb added a comment. Python 3.6.8 (default, Apr 30 2019, 13:27:23) [GCC] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import distutils.sysconfig >>> print(distutils.sysconfig.get_python_lib(True, False, '')) lib64/python3.6/site-packages >>>

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb accepted this revision. hhb added a comment. In D68910#1710009 , @llunak wrote: > How about this one? This is fine for me. Actually it doesn't make any difference for all platforms I tried... Out of curiosity, is it possible to share the

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

clayborg added a comment. LGTM. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace updated this revision to Diff 225113. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 Files: lldb/include/lldb/Utility/ProcessInfo.h

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace updated this revision to Diff 225112. wallace edited the summary of this revision. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace updated this revision to Diff 225107. wallace added a comment. Herald added a subscriber: krytarowski. now using bundle_id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 Files:

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! With a little work, "gui" mode can really become great. I hope to see more patches? Happy to discuss next stops on the mailing list if you are interested! Repository:

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo added a comment. In D68980#1710018 , @stella.stamenova wrote: > In D68980#1709967 , @mstorsjo wrote: > > > In D68980#1709931 , @labath wrote: > > > > > In

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. In D68980#1709967 , @mstorsjo wrote: > In D68980#1709931 , @labath wrote: > > > In D68980#1709884 , > > @stella.stamenova wrote: > > > > >

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak updated this revision to Diff 225102. llunak added a comment. Adjusted the testcase. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/ https://reviews.llvm.org/D68541 Files: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/Makefile

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. In D68980#1709968 , @mstorsjo wrote: > In D68980#1709954 , > @stella.stamenova wrote: > > > Both. Again, it's been a long time, but when we use VS for building, the > >

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

llunak updated this revision to Diff 225101. llunak retitled this revision from " use LLVM_LIBDIR_SUFFIX for python lib path" to "python path should be platform-dependent". llunak edited the summary of this revision. llunak added a comment. How about this one? Repository: rLLDB LLDB CHANGES

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

llunak added a comment. In D68910#1709832 , @hhb wrote: > Can you sync to the latest code and try again? Your problem is likely to be > fixed in a previous change... With current master 'ninja install' at least proceeds without an error. But it still

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. Ok, I was able to debug it finally. I think we should add a .symtab in a few more cases implicitly. For example, when we have a SHT_RELA/SHT_REL section that has an empty Link, i.e. it refers to .symtab by default and we should provide it. There are other cases, like when

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 225097. wallace added a comment. Addressed comments. It turns out from the definition of ProcessInfo that Arguments shuoldn't contain arg0, so I updated the code accordingly. I ran the test suite locally and I didn't see any failure caused due to that, so

[Lldb-commits] [PATCH] D68962: update ScriptInterpreterPython to use File, not FILE*

lawrence_danna updated this revision to Diff 225096. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. remove superfluous resets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68962/new/

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

labath added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; jingham wrote: > labath wrote: > > jingham wrote: > > > jingham wrote: > >

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:63-66 +self.assertRaises( +Exception, +lambda :

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo added a comment. In D68980#1709954 , @stella.stamenova wrote: > Both. Again, it's been a long time, but when we use VS for building, the > environment already contains a path to clang-cl so regardless of whether the > build is standalone or

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo added a comment. In D68980#1709931 , @labath wrote: > In D68980#1709884 , > @stella.stamenova wrote: > > > The two things that come to mind are the path to clang-cl (which is > > sometimes a clang build

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:32 +self.child.send("s") # step +

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. In D68980#1709931 , @labath wrote: > In D68980#1709884 , > @stella.stamenova wrote: > > > The two things that come to mind are the path to clang-cl (which is > > sometimes a

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:63-66 +self.assertRaises( +Exception, +lambda : self.expect("platform process list -xv",

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; labath wrote: > jingham wrote:

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

labath added a comment. In D68980#1709884 , @stella.stamenova wrote: > The two things that come to mind are the path to clang-cl (which is sometimes > a clang build and sometimes installed on the system as part of a VS > installation or an LLVM

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

labath added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; jingham wrote: > jingham wrote: > > labath wrote: > > > labath wrote: > >

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:1456 +// separated by the character '-', where each argument is +// hex-encoded. // labath

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

amccarth added a comment. > I know there are some complexities with configuring msvc/clang-cl, where > one needs to fetch registry keys and whatnot in order to get the right build > environment. My understanding is that the clang-cl driver does some poking around in the file system and

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; jingham wrote: > labath wrote:

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. In D68980#1709866 , @labath wrote: > In D68980#1709830 , > @stella.stamenova wrote: > > > I suspect that using clang-cl directly will not work though - the script > > does a lot

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

labath added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:1456 +// separated by the character '-', where each argument is +// hex-encoded. // Does that include argv[0]? I take it does, but argv[0]

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna updated this revision to Diff 225083. lawrence_danna added a comment. oops, revert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 Files:

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:655 + auto new_file = PythonFile::FromFile(file, mode); + if (!new_file) +return false;

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 225082. wallace marked 2 inline comments as done. wallace added a comment. Add end to end test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 Files:

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

lawrence_danna updated this revision to Diff 225081. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. put in missing consumeError() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68963/new/

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna updated this revision to Diff 225079. lawrence_danna added a comment. put in missing consumeError() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 Files:

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; labath wrote: > labath wrote: >

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

labath added a comment. In D68980#1709830 , @stella.stamenova wrote: > I suspect that using clang-cl directly will not work though - the script does > a lot of the setup needed to run clang-cl correctly today (previously the > environment for clang-cl

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

grimar added inline comments. Comment at: llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml:3 + +# Test that we report an error for an ExceptionStream where the specified +# number of parameters is greater than the number of ExceptionInformation

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb marked an inline comment as done. hhb added a comment. In D68858#1709458 , @tatyana-krasnukha wrote: > Build and installation completed successfully! LGTM, though it would be good > if anyone tests this with Xcode. I just tested Xcode. For xcode

[Lldb-commits] [PATCH] D68960: remove FILE* usage from SBStream.i

This revision was automatically updated to reflect the committed changes. Closed by commit rG30cf609548d9: remove FILE* usage from SBStream.i (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68960/new/

[Lldb-commits] [PATCH] D68910: use LLVM_LIBDIR_SUFFIX for python lib path

hhb requested changes to this revision. hhb added a comment. This revision now requires changes to proceed. Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

labath added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; labath wrote: > lawrence_danna wrote: > > jingham wrote: > > >

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

labath added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; lawrence_danna wrote: > jingham wrote: > > lawrence_danna wrote: > > >

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. This change looks fine assuming all the tests continue to pass. I think it makes sense to update the script to allow more arguments and/or invoke clang-cl directly instead of using the script. I suspect that using clang-cl directly will not work though - the

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

thakis added a comment. This fails on Windows: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/5779/steps/test-check-llvm-unit-check-clang-unit/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

lawrence_danna added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; jingham wrote: > lawrence_danna wrote: > > labath wrote: > > >

[Lldb-commits] [lldb] r374924 - remove FILE* usage from SBStream.i

Author: lawrence_danna Date: Tue Oct 15 10:41:40 2019 New Revision: 374924 URL: http://llvm.org/viewvc/llvm-project?rev=374924=rev Log: remove FILE* usage from SBStream.i Summary: This patch removes FILE* and replaces it with SBFile and FileSP the SWIG interface for `SBStream.i`. And this is

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b9981b180ef: [VirtualFileSystem] Support virtual working directory in the RedirectingFS (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68918: eliminate virtual methods from PythonDataObjects

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3bd5b3d71ae: eliminate virtual methods from PythonDataObjects (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68918/new/

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham marked 2 inline comments as done. jingham added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; lawrence_danna wrote: > labath

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak updated this revision to Diff 225064. llunak added a comment. Removed the explicit test timeout. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/ https://reviews.llvm.org/D68541 Files:

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak marked an inline comment as done. llunak added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:31 +# which is not necessarily the order on the screen.) +self.child.timeout = 2 +

[Lldb-commits] [lldb] r374916 - eliminate virtual methods from PythonDataObjects

Author: lawrence_danna Date: Tue Oct 15 10:12:49 2019 New Revision: 374916 URL: http://llvm.org/viewvc/llvm-project?rev=374916=rev Log: eliminate virtual methods from PythonDataObjects Summary: This patch eliminates a bunch of boilerplate from PythonDataObjects, as well as the use of virtual

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG311dbb1bd7c2: convert SBDebugger::***FileHandle() wrappers to native files. (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r374912 - convert SBDebugger::***FileHandle() wrappers to native files.

Author: lawrence_danna Date: Tue Oct 15 09:59:20 2019 New Revision: 374912 URL: http://llvm.org/viewvc/llvm-project?rev=374912=rev Log: convert SBDebugger::***FileHandle() wrappers to native files. Summary: This patch converts the swig wrappers for SetInputFileHandle() and friends to emulate the

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9b553ec9961: SBFile::GetFile: convert SBFile back into python native files. (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r374911 - SBFile::GetFile: convert SBFile back into python native files.

Author: lawrence_danna Date: Tue Oct 15 09:46:27 2019 New Revision: 374911 URL: http://llvm.org/viewvc/llvm-project?rev=374911=rev Log: SBFile::GetFile: convert SBFile back into python native files. Summary: This makes SBFile::GetFile public and adds a SWIG typemap to convert the result back

[Lldb-commits] [PATCH] D68968: [android/process list] use arg0 as fallback for process name

clayborg added a comment. I think it would be nice to have a new member to ProcessInfo like: std::string m_bundle_id; This notion works for MacOS and for Android. When launching on iOS, we need to application bundle identifier to do the launching as the install of the app registers the app

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

clayborg added a comment. Have many compilers supported DW_AT_export_symbols for a while now? If not, are there any serious issues introduced here that would change debugger behavior if this attribute is not emitted by a compiler? Or is this a new fix in clang that was recently introduced in

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, clayborg, labath, jingham. Herald added a project: LLDB. The current implementation of PythonCallable::GetNumArguments is not exception safe, has weird semantics, and is just plain incorrect for some kinds of

[Lldb-commits] [lldb] r374906 - Increase gdbremote_testcase timeouts when running under ASAN.

Author: adrian Date: Tue Oct 15 08:46:17 2019 New Revision: 374906 URL: http://llvm.org/viewvc/llvm-project?rev=374906=rev Log: Increase gdbremote_testcase timeouts when running under ASAN. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

[Lldb-commits] [lldb] r374905 - Skip PExpect tests under ASAN, I can't get them to work reliably.

Author: adrian Date: Tue Oct 15 08:38:49 2019 New Revision: 374905 URL: http://llvm.org/viewvc/llvm-project?rev=374905=rev Log: Skip PExpect tests under ASAN, I can't get them to work reliably. Modified:

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet updated this revision to Diff 225044. JosephTremoulet added a comment. - punctuation fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68657/new/ https://reviews.llvm.org/D68657 Files:

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet marked an inline comment as done. JosephTremoulet added inline comments. Comment at: llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml:3 + +# Test that we report an error for an ExceptionStream where the specified +# number of parameters is

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:781 +with open(self.out_filename, 'r') as f: +# python2

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. @stella.stamenova I've fixed it with r374888, thanks again for pointing to that. The fix of unwind can fix some stepping issues, because stepping logic uses call stack information actively. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

aleksandr.urakov added a comment. In D68980#1709327 , @labath wrote: > @aleksandr.urakov, since you probably know more about windows and these tests > than I do, I'd be interested in hearing your thoughts too... Sorry, I made some changes to the

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. Build and installation completed successfully! LGTM, though it would be good if anyone tests this with Xcode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] r374888 - [Windows][NFC] Fix tests after r374528.

Author: aleksandr.urakov Date: Tue Oct 15 06:52:27 2019 New Revision: 374888 URL: http://llvm.org/viewvc/llvm-project?rev=374888=rev Log: [Windows][NFC] Fix tests after r374528. Differential Revision: https://reviews.llvm.org/D67347 Modified:

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna updated this revision to Diff 225009. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. pass ::flush to PyFile_FromFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68737/new/

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

labath added a comment. In D68980#1709346 , @mstorsjo wrote: > In D68980#1709314 , @labath wrote: > > > Yeah, I raised this issue back when build.py was first introduced, but it > > did not really get resolved

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

lawrence_danna added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; labath wrote: > lawrence_danna wrote: > > labath wrote: > > > In

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. In D68943#1709330 , @kwk wrote: > I noticed that the order of sections does matter to some tests. Before the > `.symtab` section was always the first one and now it is the last of the > implicit sections being created. Some

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo added a comment. In D68980#1709314 , @labath wrote: > Yeah, I raised this issue back when build.py was first introduced, but it did > not really get resolved properly. (Back then, windows arm wasn't considered, > so I guess the issue wasn't

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo added a comment. In D68980#1709314 , @labath wrote: > For the tests that "assume" that they are building for x86, how exactly do > these assumptions of theirs manifest? Two tests fail, SymbolFile/NativePDB/disassembly.cpp and

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk added a comment. I noticed that the order of sections does matter to some tests. Before the `.symtab` section was always the first one and now it is the last of the implicit sections being created. Some `Link: X` checks break because `X` points to a different section. In order to

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Yea, let's discuss this a bit further. It's possible this may turn out to be the best solution to the problem, but I'd like to explore the various aspects of the problem first...

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

aleksandr.urakov added a comment. Sorry, I didn't see Pavel's message. In this case I have no objections to the patch if other people also won't have. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68980/new/ https://reviews.llvm.org/D68980

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

labath added a reviewer: stella.stamenova. labath added a comment. +stella, for the aspects of running msvc/clang in various environments.. Yeah, I raised this issue back when build.py was first introduced, but it did not really get resolved properly. (Back then, windows arm wasn't considered,

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68980/new/ https://reviews.llvm.org/D68980

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

labath added a comment. In D68293#1708863 , @wallace wrote: > address comments > > Btw, @labath, could you point me to a example of a full end to end test like > the attach one you mention? > I haven't been able to find it :( I think you can use

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

labath added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; lawrence_danna wrote: > labath wrote: > > In light of varargs functions

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

mstorsjo created this revision. mstorsjo added reviewers: rnk, labath, amccarth, aleksandr.urakov. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. This fixes running check-lldb on arm linux. Previously the helper python scipt only passed -m32/-m64, but some

[Lldb-commits] [PATCH] D68939: [LLDB] [PECOFF] Use a "pc" vendor name in aarch64 triples

This revision was automatically updated to reflect the committed changes. Closed by commit rG674d55438d25: [LLDB] [PECOFF] Use a pc vendor name in aarch64 triples (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68939/new/

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 register contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1f6ba2a2ecd: [LLDB] [Windows] Initial support for ARM64 register contexts (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67954/new/

  1   2   >