Re: [patch] tiny listings signal fix

2007-06-25 Thread Alfredo Braunstein
Jürgen Spitzmüller wrote: > The attached simple patch fixes the following: > > - Open the listings dialog and type in some unknown command: OK button is > greyed out (correct) > - now click "pass validation": OK button is activated (correct) > - uncheck "pass validation" again: OK button still ac

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-25 Thread Angus Leeming
Uwe Stöhr wrote: > Btw. Why do you have a [EMAIL PROTECTED] email adress and me not? You do. Now you just need to learn how to use it ;-) $ ssh [EMAIL PROTECTED] $ cat .forward [EMAIL PROTECTED] -- Angus

[patch] tiny listings signal fix

2007-06-25 Thread Jürgen Spitzmüller
The attached simple patch fixes the following: - Open the listings dialog and type in some unknown command: OK button is greyed out (correct) - now click "pass validation": OK button is activated (correct) - uncheck "pass validation" again: OK button still activated (wrong). Same for Document an

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Why should the quotation be OS-dependent? quoteName is OS-dependent: switch(style) { case quote_shell: // This does not work for filenames containing " (windows) // or ' (all other OSes). This can't be changed easily, since

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Jean-Marc Lasgouttes wrote: >> It seems to me that FuncRequest::getArg handles properly quoted >> arguments. Can't you rely on that? Jürgen> getArg handles only double-quoted arguments (the filename Jürgen> quoting is OS-dep

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Jürgen Spitzmüller wrote: >> > The print dialog is currently unusable on Windows due to bug >> 3915: > http://bugzilla.lyx.org/show_bug.cgi?id=3915 >> the attached patch should fix it Jürgen> Tested by Uwe. OK to commit? O

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Jean-Marc Lasgouttes
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes: Richard> Please read this exchange carefully. Helge said, "This way Richard> you see clearly whether the alignment is explicit or at its Richard> default". The proposal you are endorsing does not do this: Richard> There's only the one but

[patch] bug 2753: LyX doesn't support paths and filenames with parentheses

2007-06-25 Thread Jürgen Spitzmüller
http://bugzilla.lyx.org/show_bug.cgi?id=2753 The patch does what Georg proposed on bugzilla: remove the patch validators in the dialog (since those filenames are mangled and copied to the temp dir anyway) and add a validator/warning to LaTeX export instead. Tested by Uwe. OK to go in? Jürgen I

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > > The print dialog is currently unusable on Windows due to bug 3915: > > http://bugzilla.lyx.org/show_bug.cgi?id=3915 > the attached patch should fix it Tested by Uwe. OK to commit? Jürgen

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > Please try if the attached fixes the crash Approved by Uwe. OK to commit? Jürgen

Re: [patch] Re: RTL justification bug

2007-06-25 Thread Martin Vermeer
On Mon, Jun 25, 2007 at 11:17:15PM +0300, Dov Feldstern wrote: > Dov Feldstern wrote: > >Hi! > > > >Here's another RTL regression --- I think this should be really easy to > >solve for anyone familiar with the painting code. I'd be happy to try > >and help out if necessary. > > > >http://bugzilla

Re: RC2 coming soon

2007-06-25 Thread Bo Peng
PS: The plan is to release RC2 in a couple of days as soon as the remaining patches are committed, and this should happen before Tuesday night. What is the status now? Bo

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-25 Thread Uwe Stöhr
Dov Feldstern schrieb: Thanks for taking care of the lyx2lyx stuff! I added the requisite comment to the FORMAT file --- could you just check your name (I'm not sure my accents are correct) and email? The name is fine there. Btw. Why do you have a [EMAIL PROTECTED] email adress and me not?

Re: [patch] Re: RTL justification bug

2007-06-25 Thread Stefan Schimanski
+ // If the last logical character is a separator, skip it, unless + // it's in the last row of a paragraph + if (end > 0 && end < par.size() && par.isSeparator(end - 1)) + skipped_sep_vpos = bidi.log2vis(end - 1); I thought it's about the visually last (or first

[patch] Re: RTL justification bug

2007-06-25 Thread Dov Feldstern
Dov Feldstern wrote: Hi! Here's another RTL regression --- I think this should be really easy to solve for anyone familiar with the painting code. I'd be happy to try and help out if necessary. http://bugzilla.lyx.org/show_bug.cgi?id=3889 Thanks! Dov Hi! Attached find a patch for this

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-25 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Any thoughts on this? Attached a newer version of the patch, the Dov> only difference is incrementing the format number by one, after Dov> Jurgen's format change. I'll let Jose decide about whether it is good e

Re: [PATCH] Paragraph Setting UI Bugs

2007-06-25 Thread Jean-Marc Lasgouttes
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes: Richard> Yes, and the problem was that people found it hard to use, Richard> and annoying that you had to uncheck the Default box before Richard> you were allowed to check anything else. I like the current solution better, except that we

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-25 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Any thoughts on this? Attached a newer version of the patch, the Dov> only difference is incrementing the format number by one, after Dov> Jurgen's format change. I'll let Jose decide about whether it is good enough now, but I do not l

Re: strange math-matrix dialog

2007-06-25 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > The math-matrix dialog is working here in an utterly awkward way: This is Bug 3919. A/

Re: [patch] linking source view with text

2007-06-25 Thread Alfredo Braunstein
Bo Peng wrote: >> I cannot judge the ViewSource part but the TexRow simplification is good >> by itself IMHO. > > Then you have a combined OK from Abdel and me, you need to wait for > Jose's. > > Jose: This looks like 1.5.x stuff but showing where the cursor is in > the view source window is a n

Re: [patch] linking source view with text

2007-06-25 Thread Bo Peng
I cannot judge the ViewSource part but the TexRow simplification is good by itself IMHO. Then you have a combined OK from Abdel and me, you need to wait for Jose's. Jose: This looks like 1.5.x stuff but showing where the cursor is in the view source window is a nice thing to have. Bo

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Edwin Leuven
Richard Heck wrote: Some people have seen this, for sure, but I don't think the costs of that are being properly appreciated. i see it, but i think that these costs (or the benefits) are overstated by you guys... There are plenty of cases, even if they are not extremely common, where it wou

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-25 Thread Dov Feldstern
Any thoughts on this? Attached a newer version of the patch, the only difference is incrementing the format number by one, after Jurgen's format change. Dov Feldstern wrote: Uwe Stöhr wrote: Attached is Dov's latest patch. I added the font encoding stuff and the fileformat change. It is furth

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Joost Verburg
Leuven, E. wrote: it will stick in many cases in my implementation, and it won't always stick in the current implementation It may not happen very often that you need to set the alignment to the option that is already the default, there still is an important difference between the default an

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Helge Hafting wrote: If the layout is then changed to "Title", then the box will say o default (center) o justified o right o center o left This way you see clearly whether the alignment is explicit or at its default - and everything (including defa

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Richard Heck
Abdelrazak Younes wrote: Helge Hafting wrote: If the layout is then changed to "Title", then the box will say o default (center) o justified o right o center o left This way you see clearly whether the alignment is explicit or at its default - and everything (including default) can be set with

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Richard Heck
Abdelrazak Younes wrote: I would miss the possibility to reset a bunch of paragraphs to default though that is a question of ui design and is orthogonal to what i am proposing. i think for this there should be a reset button... This is a sensible suggestion IMHO. As we all agree that "Default" i

Re: A small patch for "List of Algorithms"

2007-06-25 Thread Mael Hilléreau
Le 23 juin 07 à 22:44, Jean-Marc Lasgouttes a écrit : > Mael> I don't think so, to be translatable, the code should be > Mael> something like '\listof {algorithm}{\listalgorithmname}'. > > I just double checked that here it outputs > \listof{algorithm}{Liste des Algorithmes} Just one last word on

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Abdelrazak Younes
Helge Hafting wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: that is a question of ui design and is orthogonal to what i am proposing. i think for this there should be a reset button... This is a sensible suggestion IMHO. As we all agree that "Default" is somewhat a different setting th

Re: [PATCH] Paragraph Setting UI Bugs

2007-06-25 Thread Richard Heck
Martin Vermeer wrote: On Sat, Jun 23, 2007 at 11:35:13PM +0200, Abdelrazak Younes wrote: Joost Verburg wrote: Abdelrazak Younes wrote: I agree with Edwin personally. I would also agree with o Justified (Default) o Left o Center o Right But we can change that later if we reach

Re: [Bug 3632] Conversion borks child docs when originaldir flag is set

2007-06-25 Thread Richard Heck
Is an HTML copier defined in your preferences? After you run HTML Export, what files do you have in the temporary LyX directory? [EMAIL PROTECTED] wrote: http://bugzilla.lyx.org/show_bug.cgi?id=3632 --- Additional Comments From [EMAIL PROTECTED] 2007-06-24 19:24 --- O.k. I have

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Helge Hafting
Abdelrazak Younes wrote: Edwin Leuven wrote: Alfredo Braunstein wrote: It has become sort of a religious issue lyx has a tendency to put a stupid button, checkbox you name it for whatever stupid thing that is around. in the end you get a bad, cluttered ui... (i this respect i think i comp

Re: [patch] linking source view with text

2007-06-25 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Bo Peng wrote: Err... what doesn't work exactly? This texrow stuff work at the outer paragraphs level, so there should be no particular problem with tables. I meant, if you click on texts inside table, your gray bar does not go there. It always stays at the first line

strange math-matrix dialog

2007-06-25 Thread Alfredo Braunstein
The math-matrix dialog is working here in an utterly awkward way: - it's not possible to change the number of columns and rows by dragging the mouse as before; it's still possible to enter the number of row and columns and/or use the +/- buttons though. - it's possible to enter text inside the mat

Re: [patch] linking source view with text

2007-06-25 Thread Alfredo Braunstein
Bo Peng wrote: >> Err... what doesn't work exactly? This texrow stuff work at the outer >> paragraphs level, so there should be no particular problem with tables. > > I meant, if you click on texts inside table, your gray bar does not go > there. It always stays at the first line (\begin{table}?)

Re: [patch] bug 1749: figures are scaled before rotation, resulting in broken layout

2007-06-25 Thread Jürgen Spitzmüller
José Matos wrote: > I took some time to look this problem. > > The logic seems right, there are one place where there is a off by one, > because in python range(a,b), assuming a and b integers goes from a to b-1. > This logic may seems strange but it pays because. > > range(a,b) + range(b,c) ==

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jürgen Spitzmüller
Alfredo Braunstein wrote: > Ah. How come it's not needed in other places where a filename is required > from the user? (Sorry if this is a stupid question :-) ) There we do not have to rip the filename off a complex string I guess. Jürgen

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Abdelrazak Younes
Edwin Leuven wrote: Alfredo Braunstein wrote: It has become sort of a religious issue lyx has a tendency to put a stupid button, checkbox you name it for whatever stupid thing that is around. in the end you get a bad, cluttered ui... (i this respect i think i compared lyx to a x-mas tree o

Re: print dialog quite unusable at the moment

2007-06-25 Thread Alfredo Braunstein
Jürgen Spitzmüller wrote: > Alfredo Braunstein wrote: >> Maybe the quote handling stuff could go to support/ ? > > Dunno. It's a rather specific case. Ah. How come it's not needed in other places where a filename is required from the user? (Sorry if this is a stupid question :-) ) A/

RE: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Leuven, E.
Helge Hafting wrote: > Most of the time, I don't use the alignment settings at all, > of course. I do change paragraph types though. > Not having to change alignment when changing paragraph types > is very nice. in these cases there is no difference between the implementation i suggested and the

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jürgen Spitzmüller
Alfredo Braunstein wrote: > Maybe the quote handling stuff could go to support/ ? Dunno. It's a rather specific case. Jürgen

Re: [tentative patch]: bug 3834: LyX crashes on startup

2007-06-25 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > This looks good. OK. I'll commit. Jürgen

Re: [patch] bug 1749: figures are scaled before rotation, resulting in broken layout

2007-06-25 Thread José Matos
On Monday 04 June 2007 07:20:15 Jürgen Spitzmüller wrote: > OK here's a start. > convert_graphics_rotation seems to work (but I'm not sure it really does), > however, revert_graphics_rotation does not. > > I really don't know what I'm doing here, so please help. I took some time to look this pro

Re: [tentative patch]: bug 3834: LyX crashes on startup

2007-06-25 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> http://bugzilla.lyx.org/show_bug.cgi?id=3834 I suspect the Jürgen> crash happens in some circumstances, because ":" is not valid Jürgen> in Windows file names, and boost::fs throws an exception in Jürgen> the given test case.

Re: print dialog quite unusable at the moment

2007-06-25 Thread Alfredo Braunstein
Jürgen Spitzmüller wrote: > Uwe Stöhr wrote: >> The print dialog is currently unusable on Windows due to bug 3915: >> http://bugzilla.lyx.org/show_bug.cgi?id=3915 > > Rather: printing to a file is completely broken when a path contains > spaces (not only on Windows). > > I guess this went unnoti

Re: [tentative patch]: bug 3834: LyX crashes on startup

2007-06-25 Thread Jürgen Spitzmüller
Leuven, E. wrote: > put it in if it works... Actually, I'm not sure. I'm not on Windows and the reporter isn't able to compile. Jürgen

RE: [tentative patch]: bug 3834: LyX crashes on startup

2007-06-25 Thread Leuven, E.
put it in if it works... -Original Message- From: Jürgen Spitzmüller [mailto:[EMAIL PROTECTED] Sent: Mon 6/25/07 13:05 To: LyX Devel Subject: [tentative patch]: bug 3834: LyX crashes on startup http://bugzilla.lyx.org/show_bug.cgi?id=3834 I suspect the crash happens in some circumstanc

Re: [PATCH-updated] Paragraph Setting UI Bugs

2007-06-25 Thread Helge Hafting
Jürgen Spitzmüller wrote: Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2? I'd prefer two clicks over the waste of space. But I have no strong opinion on this. I prefer one click in t

[tentative patch]: bug 3834: LyX crashes on startup

2007-06-25 Thread Jürgen Spitzmüller
http://bugzilla.lyx.org/show_bug.cgi?id=3834 I suspect the crash happens in some circumstances, because ":" is not valid in Windows file names, and boost::fs throws an exception in the given test case. Now I wonder if it makes sense to have an icon file with a colon in the name at all. So I'd

RE: No paragraph alignment options

2007-06-25 Thread Leuven, E.
Helge Hafting wrote: >> could you give a meaningful example with specific layouts between >> which you would be switching (out of curiosity) which would give rise >> to the above? > I can't remember a layout with default centering, f.e. title in the article layout > but I believe the headings a

Re: [PATCH-update] Finish Reworking of Paragraph Settings Dialog

2007-06-25 Thread Helge Hafting
Edwin Leuven wrote: Richard Heck wrote: be the Default for that paragraph. The reason to make this distinction is that it is one thing to say, "Give this paragraph the default alignment, whatever that is" and another to say, "Make this paragraph fully justified, no matter what". The difference w

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > It seems to me that FuncRequest::getArg handles properly quoted > arguments. Can't you rely on that? getArg handles only double-quoted arguments (the filename quoting is OS-dependent). And it's difficult to get command with it, since that includes "alle the rest" af

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Jean-Marc Lasgouttes wrote: >> What do the arguments of BUFFER_PRINT look like? Jürgen> It's a string in the form "file 'path/to/File Name/file.ps' Jürgen> dvips -t letter" Jürgen> We used to split up the string at each spa

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > What do the arguments of BUFFER_PRINT look like? It's a string in the form "file 'path/to/File Name/file.ps' dvips -t letter" We used to split up the string at each space, which gives: - target: file - target_name: 'path/to/File - command: Name/file.ps' dvips -t let

Re: No paragraph alignment options

2007-06-25 Thread Helge Hafting
Edwin Leuven wrote: Alfredo Braunstein wrote: Edwin Leuven wrote: case 2 is in my opinion not so relevant because i don't see why (in the current solution) one would have default unchecked and then choose the explicit alignment that matches default behavior One such cases: I'm in Standard La

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> However, the attached patch should fix it (the fix for the Jürgen> crash is not included). If someone has a more elegant idea to Jürgen> strip out the target_name argument, please let me know. What do the arguments of BUFFER

Re: print dialog quite unusable at the moment

2007-06-25 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > The print dialog is currently unusable on Windows due to bug 3915: > http://bugzilla.lyx.org/show_bug.cgi?id=3915 Rather: printing to a file is completely broken when a path contains spaces (not only on Windows). I guess this went unnoticed since nobody actually uses this (but

Re: drawing of selection in tabulars

2007-06-25 Thread Alfredo Braunstein
Stefan Schimanski wrote: > Looks good. While you are at it, can you take care of 80 columns per > line? That one is more than 150... Done. A/

RE: Re: drawing of selection in tabulars

2007-06-25 Thread Leuven, E.
> I'm specializing in one-liners lately ;-) good work! > OK? yes

Re: [patch] remove unused code

2007-06-25 Thread Abdelrazak Younes
Alfredo Braunstein wrote: I'll commit the following if nobody objects. These are remainings from the late invalidation signaling mechanism. Go ahead. Abdel.

Re: [PATCH] Paragraph Setting UI Bugs

2007-06-25 Thread Abdelrazak Younes
Martin Vermeer wrote: On Sat, Jun 23, 2007 at 11:35:13PM +0200, Abdelrazak Younes wrote: Joost Verburg wrote: Abdelrazak Younes wrote: I agree with Edwin personally. I would also agree with o Justified (Default) o Left o Center o Right But we can change that later if we reach consensus. I th